[Koha-bugs] [Bug 21685] New: Name our exceptions consistently

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21685

            Bug ID: 21685
           Summary: Name our exceptions consistently
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

Few examples of inconsistencies:

*
Koha::Exceptions::WrongParameter
Koha::Exceptions::BadParameter

*
Koha::Exceptions::CannotDeleteDefault
Koha::Exceptions::Patron::FailedDelete

*
Koha::Exceptions::Account::IsNotCredit
Koha::Exceptions::Password::Invalid
=> IsNotCredit vs NotCredit
=> IsNotValid vs Invalid vs NotValid

*
Koha::Exceptions::DuplicateObject
Koha::Exceptions::Object::DuplicateID

It would be good a write a guideline and adapt existing occurrences.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.