[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #110 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Pierre-Marc,

some things here:

1) Please make sure all your patches pass the QA script before submitting them:
https://gitlab.com/koha-community/qa-test-tools
Currently, it fails:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
   FAIL   filters
                missing_filter at line 380 (                deleteIssues("[%
subscriptionidlist %]");)
                missing_filter at line 39 (                <h5>Number of items
available: [% countitems %]</h5>)
                missing_filter at line 46 (            <input type="hidden"
name="subscriptionid" value="[% subscriptionid %]" />)
                missing_filter at line 48 (                <input type="hidden"
name="serialid" value="[% serialid %]" />)
                missing_filter at line 148 (            <input type="button"
value="Delete selected issues" class="delete-issues btn btn-default btn-sm"
data-subscriptionids="[% subscriptionidlist %]" />)
                missing_filter at line 36 (        <h3>You are about to delete
[% serialnumber %] serial(s). Do you want to continue?</h3>)
                missing_filter at line 45 (            <input type="hidden"
name="biblionumber" value="[% biblionumber %]" />)
                missing_filter at line 53 (            <input type="hidden"
name="subscriptionid" value="[% subscriptionid %]" />)

2) Please make sure that the subject lines of your commits are formatted
correctly. The QA script will also help with that:

        * Commit title does not start with 'Bug XXXXX: ' - 12463c45e7

3) Please make sure all text is translatable:
https://wiki.koha-community.org/wiki/Coding_Guidelines#JS2:_Enabling_translation_of_language_strings_in_embedded_JavaScript

+                alert("No serials selected");

-- 
You are receiving this mail because:
You are watching all bug changes.