[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #121 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Katrin Fischer from comment #120)
> Hi all, 
> 
> really happy to see this one moving! 
Really happy too!

> 
> Maybe time to think about a few things:
> 
> - When is the best moment to push this to master? Should we aim to before
> string freeze? In this case it would be nice to get an OK from Bernardo
> before we do that. The scheduled time for translating is not very long this
> time, so we should avoid issues. I think plural forms might not be set in
> all our files. Some languages like Japanese don't even have proper plural.
Apart from the "Example usage of I18N Template::Toolkit plugin" patch, this
whole patchset won't affect existing translations at all. I'm thinking that
maybe I can provide an other example in a more hidden place, so if there is
problem with it at release it won't be noticed (or maybe just don't push the
example, to be totally safe)

> 
> - Does it affect performance? I see you discussed times for generating the
> .po/.mo files already. What about page loads? I am not sure if I understood
> the method correctly here, are we still creating translated templates or is
> this more 'on the fly'?
We'll have to continue to create translated templates until all translatable
messages are "wrapped" (see bug 20988 which aims to do that) and translated.
But once it is done we should stop, as all translations would be retrieved on
the fly. So it will affect performance, but it should be negligible. I did some
performance tests some time ago and noticed an increase in page load time of
~3ms for 100 strings translated in a template file. I'm currently trying to
write another performance test script. I'll publish it as soon as it is
finished so other people can test.

> 
> - Can we have some dev documentation for the wiki with explanations and
> examples?
I can certainly do that. What kind of explanations would you expect from such
documentation ?

-- 
You are receiving this mail because:
You are watching all bug changes.