[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've attached rebased patches and added Cori Lynn's sign-off to the first patch
as well. 

1) Can you please add POD to CustomXSLTExportList (see comment #19)

2) There is lots of minor (fast to fix) fails in the QA script:

FAIL    koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
   FAIL   filters
                wrong_html_filter at line 100 (            <li><a
href="/cgi-bin/koha/catalogue/export.pl?format=[% filesOption.format
%]&op=exportxsl&file=[% filesOption.value %]&bib=[% biblionumber |
html %]">[% filesOption.filename %]</a></li>)
                missing_filter at line 100 (            <li><a
href="/cgi-bin/koha/catalogue/export.pl?format=[% filesOption.format
%]&op=exportxsl&file=[% filesOption.value %]&bib=[% biblionumber |
html %]">[% filesOption.filename %]</a></li>)
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc
   FAIL   filters
                wrong_html_filter at line 27 (                        <li><a
href="/cgi-bin/koha/virtualshelves/downloadshelf.pl?format=xsl.[%
xsl_export.value %]&shelfid=[% shelf.shelfnumber %]">XSL - [%
xsl_export.filename %]</a></li>)
                missing_filter at line 27 (                        <li><a
href="/cgi-bin/koha/virtualshelves/downloadshelf.pl?format=xsl.[%
xsl_export.value %]&shelfid=[% shelf.shelfnumber %]">XSL - [%
xsl_export.filename %]</a></li>)
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt
   FAIL   filters
                missing_filter at line 60 (                               
<li><a href="/cgi-bin/koha/basket/downloadcart.pl?format=xsl.[%
xsl_export.value %]&bib_list=[% bib_list %]">XSL - [% xsl_export.filename
%]</a></li>)
                wrong_html_filter at line 60 (                               
<li><a href="/cgi-bin/koha/basket/downloadcart.pl?format=xsl.[%
xsl_export.value %]&bib_list=[% bib_list %]">XSL - [% xsl_export.filename
%]</a></li>)
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
   FAIL   filters
                missing_filter at line 860 (            <option value="[%
filesOption.value %]">[% filesOption.filename %]</option>)
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt
   FAIL   filters
                missing_filter at line 40 (            <option value="xsl.[%
xsl_export.value %]">XSL - [% xsl_export.filename %]</option>)
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 OK    
koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl
   OK     git manipulation
   OK     xml_valid

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
   FAIL   filters
                missing_filter at line 71 (                                    
   <li><a role="menuitem" href="/cgi-bin/koha/opac-export.pl?format=[%
filesOption.format %]&op=exportxsl&file=[% filesOption.value
%]&bib=[% biblionumber %]">[% filesOption.filename %]</a></li>)
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt
   FAIL   filters
                missing_filter at line 24 (                                   
<option value="xsl.[% xsl_export.value %]">XSL - [% xsl_export.filename
%]</option>)
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt
   FAIL   filters
                missing_filter at line 63 (                                    
           <option value="xsl.[% xsl_export.value %]">XSL - [%
xsl_export.filename %]</option>)
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

3) t/XSLT.t passes, but there is a warning that should be fixed:
t/XSLT.t .. 2/12 Use of uninitialized value $outputformat in string eq at
/home/vagrant/kohaclone/C4/XSLT.pm line 404.

4) I think we should leave the example out of production. You only provide an
example for MARC21 that will not work for UNIMARC and NORMARC users and that
can't be removed from display unless you delete the file (and will come back on
each update using packages).

-- 
You are receiving this mail because:
You are watching all bug changes.