[Koha-bugs] [Bug 21702] mancredit.pl incorrectly passes user_id instead of the patron id

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Oct 29 10:33:10 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21702

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81360|0                           |1
        is obsolete|                            |

--- Comment #3 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 81464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81464&action=edit
Bug 21702: Make mancredit.pl use the patron id for the staff user

I think unsafe SQL modes and the fact that manager_id has no FK allowed this to
go unnoticed. But now we catch it!

To test:
- On a patron, try adding a new manual credit of any type
=> FAIL: It fails telling the userid of the logged user is not a valid integer!
- Apply this patch
- Try adding a manual credit of any type
=> SUCCESS: Manual credit added!
- Sign off!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list