[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 81620
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81620
Bug 21002: Add ->add_debit method to Koha::Account

Review of attachment 81620:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21002&attachment=81620)
-----------------------------------------------------------------

::: Koha/Account.pm
@@ +435,5 @@
> +  - 'lost'
> +  - 'processing'
> +  - 'management'
> +  - 'sundry'
> +  - 'card'

You are missing some types from $account_types_debit here

@@ +454,5 @@
> +    }
> +
> +    my $description  = $params->{description} // q{};
> +    my $note         = $params->{note} // q{};
> +    my $user_id      = $params->{user_id};

Should not user_id be taken from C4::Context->userenv when not available in
params?

@@ +488,5 @@
> +                    amount            => $amount,
> +                    description       => $description,
> +                    accounttype       => $account_type,
> +                    amountoutstanding => $amount,
> +                    invoice_type      => $invoice_type,

There is no invoice_type column in accountlines

@@ +498,5 @@
> +
> +            # Record the account offset
> +            my $account_offset = Koha::Account::Offset->new(
> +                {   debit_id => $line->id,
> +                    type      => $Koha::Account::offset_type->{$type},

This will not work, values from $type are not defined in offset_type

-- 
You are receiving this mail because:
You are watching all bug changes.