[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to M. Tompsett from comment #21)
> Comment on attachment 81530 [details] [review]
> Bug 21526: Use the 'url' filter when needed
> 
> Review of attachment 81530 [details] [review]:

Thanks Mark!


> > +            [% link = BLOCK %]<a href="[% authidurl _ authid | url %]">[% heading | html %]</a>[% END %]
> 
> Perhaps this line and line 31 should use the same method to build the URL? I
> tend to prefer 31's split.

I do not understand what you mean.

> > +    <fieldset class="action"><input type="hidden" name="op" value="[% op | html %]" />[% IF ( suggestionid ) %]<input type="submit" value="Save" /> <a class="cancel" href="[% IF ( returnsuggestedby ) %]/cgi-bin/koha/members/moremember.pl?borrowernumber=[% returnsuggestedby | uri %]#suggestions[% ELSE %]suggestion.pl[% END %]">Cancel</a>[% ELSE %]<input type="submit" value="Submit your suggestion" /> <a class="cancel" href="suggestion.pl">Cancel</a>[% END %]
> 
> Nice correction of html to uri in the url build part, but the hidden value's
> value... perhaps uri? After all, it's like the portion of a long GET
> request, not a string to display.

What are you suggestion here?


> > +                <a href="[% OPACBaseURL | url %]/cgi-bin/koha/opac-news-rss.pl?branchcode=[% branchcode | uri %]"><img src="[% interface | html %]/[% theme | html %]/images/feed-icon-16x16.png"></a>
> 
> The img src url.... is interface url? is theme just a piece of the url?
> Something feels wrong about this, but I could be wrong.

"interface" must be "intranet-tmpl" or "opac-tmpl"
"theme" must be "bootstrap" or "prog"

=> I did not take care of them, not important for now.

I have fixed the search/facets on a separate bug reports.

Other comments have been fixed or ignored when I disagree.

Please provide tests to recreate an error if you think you find some.

Reopening the bug, as I think it must be fixed here. The last 3 patches need to
be tested.

-- 
You are receiving this mail because:
You are watching all bug changes.