From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 01:17:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Aug 2018 23:17:28 +0000 Subject: [Koha-bugs] [Bug 21308] New: Results from order search do not show the search parameters. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Bug ID: 21308 Summary: Results from order search do not show the search parameters. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org A report from one of our partner libraries: "It would be nice if the system told us what our search was. We are often interrupted and then come back and have to get back into our previous work flow. ... it would be nice to see the search parameter explicitly shown in the breadcrumb trail - or somewhere" The breadcrumb trail showed Home ? Acquisitions ? Orders search ? Search results ... and there was no indication of what had been searched for in the URL, or anywhare on the page (aside from implicitly in the returned results). I ran several searches from cgi-bin/koha/acqui/histsearch.pl myself, and confirmed this. To re-create: 1) Navigate to Home ? Acquisitions 2) Click on 'Orders Search' under the masthead search bar 3) Search for a title and click 'Submit' 4) Run a browser search for the the title, note that it appears only in the results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 01:18:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Aug 2018 23:18:20 +0000 Subject: [Koha-bugs] [Bug 21308] Results from order search do not show the search parameters. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 --- Comment #1 from Barton Chittenden --- Created attachment 78359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78359&action=edit Screenshot of search results, search for Title 'test' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 09:01:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2018 07:01:08 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #73 from Cab Vinton --- Software error on PTFS sandbox 0: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha.circulation_rules' doesn't exist at /home/koha/src/Koha/Objects.pm line 191 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 09:58:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2018 07:58:58 +0000 Subject: [Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 --- Comment #10 from Katrin Fischer --- For the release notes it might be nice to rephrase it the bug title a bit. The word automatic made me think of the printer working in the background without needing interaction, but it's not quite what happens here. It's just that it takes away the other confusing options and bringing up the print screen immediately. Fast print hold slips? Speed up hold print process? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 10:39:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2018 08:39:25 +0000 Subject: [Koha-bugs] [Bug 21240] Tables with lot of columns should have autoWidth turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- So they are smaller without auto-width? Not sure I understand the difference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 11:51:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2018 09:51:21 +0000 Subject: [Koha-bugs] [Bug 17845] Remove printer related code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 john thomas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raghuram88585 at gmail.com --- Comment #1 from john thomas --- If you run into any hardware issues while checking your printer, you will need to consult your printer manual or contact the printer manufacturer for assistance. Visit this link https://www.brotherprintersupportnumber.com/brother-customer-support/ for solving printer related issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 18:36:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2018 16:36:20 +0000 Subject: [Koha-bugs] [Bug 21219] NULL values in updated_on field break the Patrons REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21219 --- Comment #2 from Pete Edwards --- I did wonder whether it could be an update issue but I couldn't find any evidence of a script that would have set a value on the column for existing records when the column was added. Does simply changing the column definition to "NOT NULL" cause the default timestamp to be set - if so I really don't understand why it was created with "NULL". Obviously, this leaves me concerned that there could be other other discrepancies - is there an easy way to compare my actual schema to the one the should be installed - I installed v18.05 but my database has the column defined as: `updated_on` timestamp NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 21:42:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2018 19:42:03 +0000 Subject: [Koha-bugs] [Bug 21309] New: Add flag to change password Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21309 Bug ID: 21309 Summary: Add flag to change password Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We should add a flag to patron accounts that, if checked, would require the patron to sign in to their account and change their password. This option could incorporate the following functionality: * Allow patron to sign in with old password then prompt for a new password. * E-mail patron notifying them with the need to change. * When active, it would block checkouts and sip authentication until done. * Anytime a password is changed in the account, whether staff side or opac, the change would clear the flag in the patron account. * Date of change should be time stamped. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 17:15:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2018 15:15:30 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bibliwho at gmail.com --- Comment #92 from Cab Vinton --- Patch failed on PTFS sanbdbox 0: Some problems occurred applying patches from bug 15565:

Something went wrong !

Applying: Bug 15565: Place multiple holds at once for the same record on staff and OPAC. Applying: Bug 15565: CSS changes error: Failed to merge in the changes. Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/opac.css M koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css Patch failed at 0001 Bug 15565: CSS changes The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 15565 - Place multiple holds at once for the same record 78242 - Bug 15565: Place multiple holds at once for the same record on staff and OPAC. 78243 - Bug 15565: CSS changes 78244 - Bug 15565: Use item's biblionumber only on item-level request 78245 - Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off 78246 - Bug 15565: Alert librarian that maximum holds per record is reached 78247 - Bug 15565: Remove use of GetBiblionumberFromItemnumber 78248 - Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC 78266 - Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl 78305 - Bug 15565: Allow up to (and including) maxreserves number of OPAC item levelholds Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-15565-CSS-changes-i7sD5P.patch . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 19:11:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2018 17:11:22 +0000 Subject: [Koha-bugs] [Bug 17845] Remove printer related code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 02:27:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 00:27:20 +0000 Subject: [Koha-bugs] [Bug 20554] New OPAC CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 02:27:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 00:27:24 +0000 Subject: [Koha-bugs] [Bug 20554] New OPAC CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78258|0 |1 is obsolete| | --- Comment #24 from Dilan Johnpull? --- Created attachment 78360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78360&action=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpull? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 08:29:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 06:29:52 +0000 Subject: [Koha-bugs] [Bug 21299] Move referer code from changelanguage to module in opac and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #6 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #5) > Signed-off-by: Tomas Cohen Arazi Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 10:18:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 08:18:16 +0000 Subject: [Koha-bugs] [Bug 21310] New: sdgsdgsdgsdgsdg Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21310 Bug ID: 21310 Summary: sdgsdgsdgsdgsdg Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Continuous Integration Assignee: tomascohen at gmail.com Reporter: gludaggaming231 at gmail.com Created attachment 78361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78361&action=edit gsdgsdgsdg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 10:43:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 08:43:10 +0000 Subject: [Koha-bugs] [Bug 21310] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|sdgsdgsdgsdgsdg |SPAM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 10:43:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 08:43:01 +0000 Subject: [Koha-bugs] [Bug 21310] sdgsdgsdgsdgsdg In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:15:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:15:38 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78030|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy --- Created attachment 78362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78362&action=edit Bug 17530: Add Koha::IssuingRules->guess_article_requestable_itemtypes This routine looks at the issuingrules and makes a fast 'intelligent guess' if article requests may be allowed for item types while branch code and patron category may not be available. We also add Koha::Biblio->may_article_request using the routine based on default item type or parameter. Implemented as both class and instance method. Added a few tests. Test plan: [1] Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t [2] Run t/db_dependent/ArticleRequests.t to test Koha::Biblio changes. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:15:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:15:44 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78031|0 |1 is obsolete| | --- Comment #55 from Marcel de Rooy --- Created attachment 78363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78363&action=edit Bug 17530: Use may_article_request method in opac-search If you enable pref ArticleRequests, until now all search results got the 'Request article' link. This patch tries to improve the situation by using the new sub with the itemtype of the search result. In most cases the number of links will drastically decrease. It may still be possible sometimes that a link is shown while it effectively is not possible, but we do not get the performance burden of determining that and going through all items. Test plan: [1] Look for two borrowers P1 and P2 within categories C1 resp. C2. [2] Look for two biblios B1 and B2 with default item types I1 resp. I2. (See 942c in case of MARC21.) [3] Make sure that no circ rules allow article requests. Enable the pref. [4] Add/modify circ rule category=C1, itemtype=I1, art_req=yes. Log out. Search for B1 and B2, verify that only B1 has AR link. Log in as P1. Verify that only B1 has AR link. Log in as P2. Verify that no biblio has AR link. [5] Add/modify circ rule category=C2, itemtype=I2, art_req=item_only. Log out. Search for B1 and B2, verify that both have AR links. Log in as P1. Verify that only B1 has AR link. Log in as P2. Verify that only B2 has AR link. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:15:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:15:49 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78032|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy --- Created attachment 78364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78364&action=edit Bug 17530: Use can_article_request to control sidebar link Before this patch, the 'Request article' link is displayed whenever the pref is enabled. In many cases this might be useless. Instead of a guess as in opac-search, we now call can_article_request to know for sure. Note: at least this is the case when a user has logged in. Update sidebar template with template variable artreqpossible. Add code in opac-detail, MARCdetail and ISBDdetail to fill it. Test plan: [1] Look for two biblios with items: one that should allow article requests and one that should not (respecting branch, patron, item type). [2] Verify on detail, ISBD and MARC that the link is displayed for the first biblio and hidden for the second biblio. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:15:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:15:56 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78033|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy --- Created attachment 78365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78365&action=edit Bug 17530: (QA follow-up) Replace our variable by cached value Instead of saving the state locally in a variable during Plack lifetime, we move the saved hash to the cache. We clear the key when we enter smart-rules.pl. This makes a change in circ rules immediately effective. Test plan: Run the modified tests. Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:16:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:16:01 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78034|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy --- Created attachment 78366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78366&action=edit Bug 17530: (QA follow-up) Replace class_or_self variables See comment23. Requested by QA. Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:16:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:16:06 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78035|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy --- Created attachment 78367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78367&action=edit Bug 17530: (QA follow-up) Move may_article_request to ItemType As requested by QA, we should move may_article_request out of Biblio. For reasons of performance removed the wrapper layer of may_article_request in opac-search. No need to look up all item types. For readability kept the routine in the detail scripts. Note for running ArticleRequests.t: A possible failure on the subtest 'search_limited' is addressed on bug 20866. So you can ignore that one. As long as the subtest for may_article_request passes. Test plan: See previous patches. Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:16:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:16:11 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 --- Comment #60 from Marcel de Rooy --- Created attachment 78368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78368&action=edit Bug 17530: (QA follow-up) Add pref ArticleRequestsLinkControl As requested by RM on Bugzilla comment53. This pref allows you to always display the link on search results. Which is the previous behavior ;) It will raise false positives, whereas the algorithm may result in false positives or negatives (depending on default item type and circulation rules). When upgrading the pref is set to always (current behavior), new installs get the new calc value using the algorithm in may_article_request. Test plan: Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t Run t/db_dependent/ArticleRequests.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:17:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:17:46 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|NeedsMoreQA | Status|In Discussion |Passed QA --- Comment #61 from Marcel de Rooy --- Back in the PQA queue. Removed some lines from patch 6 and added patch 7 in order to meet comment53. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:28:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:28:40 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77264|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy --- Created attachment 78369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78369&action=edit Bug 20819: Dbrev for new table patron_consent and sysprefs [1] We add table patron_consent. It allows for future extension. We could e.g. save consent for newsletter etc. [2] Add one field to borrower_modifications Datetime the patron who self-registered, gave consent. [3] Syspref PrivacyPolicyURL [4] Syspref GDPR_Policy: enforced, permissive or disabled. Test plan: [1] Run the dbrev or do a new install. [2] Look at the description of the new prefs in Administration. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:28:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:28:45 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77265|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy --- Created attachment 78370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78370&action=edit Bug 20819: DBIx schema changes No test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:28:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:28:50 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77266|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy --- Created attachment 78371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78371&action=edit Bug 20819: Add Koha object classes for patron consents Introduces Koha::Patron::Consent[s] for new table. Adds basic CRUD test. Test plan: Run t/db_dependent/Koha/Patron/Consents.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:28:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:28:56 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77267|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy --- Created attachment 78372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78372&action=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:29:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:29:01 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77268|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy --- Created attachment 78373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78373&action=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:29:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:29:06 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77269|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy --- Created attachment 78374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78374&action=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:30:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 11:30:29 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #32 from Marcel de Rooy --- Needed a rebase for removed NorwegianDB prefs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:04:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:04:23 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com --- Comment #2 from Cab Vinton --- Created attachment 78375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78375&action=edit Next record glitch All looks good except for the Return to Results display. For all examples Next Record is offset on the next line rather than on the same line as Previous Record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:18:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:18:33 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77820|0 |1 is obsolete| | --- Comment #26 from Andrew Isherwood --- Created attachment 78377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78377&action=edit Bug 20581: Provide status_alias on IllRequest This patch provides status_alias support for the Koha::Illrequest object. - New 'statusalias' getter method, returns the request's status_alias authorised value object if set, otherwise undef - Overloads existing 'status' method, getter/setter accessors intact, but setting the request's status now implicitly removes any status_alias that has been set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:18:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:18:39 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77821|0 |1 is obsolete| | --- Comment #27 from Andrew Isherwood --- Created attachment 78378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78378&action=edit Bug 20581: API provide status_alias embed - This patch provides the illrequests API route with an additional embed, called 'status_alias'. Requesting this embed returns an object for the request's status_alias authorised value, or null if one is not set. - This patch also adds the new status_alias as a default embed on the API call made by the illlist view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:18:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:18:44 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77822|0 |1 is obsolete| | --- Comment #28 from Andrew Isherwood --- Created attachment 78379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78379&action=edit Bug 20581: Add display of status_alias to staff vw - This patch adds display of the new status_alias value, when set, in favour of the request's status value. - It also allows the user to set a status_alias for an existing request. When set, this value will be displayed in preference to the status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:18:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:18:27 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77819|0 |1 is obsolete| | --- Comment #25 from Andrew Isherwood --- Created attachment 78376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78376&action=edit Bug 20581: Modifications to database schema - This patch provides an illrequests.status_alias column that is a foreign key to authorised_values.id. This provides the ability for an ILL request to have an optional status alias that is defined as an authorised valued. - A new ILLSTATUS authorised value category is also made available during install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:18:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:18:49 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77823|0 |1 is obsolete| | --- Comment #29 from Andrew Isherwood --- Created attachment 78380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78380&action=edit Bug 20581: Add support for status_alias to OPAC view - This patch adds the abililty for the OPAC to display a set status_alias value in preference to a request's status value. During ILL request listing or individual ILL request view, the status_alias value, if set, will be displayed in favour of the status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:18:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:18:54 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77824|0 |1 is obsolete| | --- Comment #30 from Andrew Isherwood --- Created attachment 78381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78381&action=edit Bug 20581: Unit tests for status_alias This patch adds unit tests for the specific status_alias functionality added in this bug - Creation of the ILLSTATUS authorised value - Illrequest->statusalias accessor - Illrequest->status overloading to reset status_alias To test: 1) Apply this patch 2) prove t/db_dependent/Illrequests.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:18:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:18:59 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |J.P.Knight at lboro.ac.uk |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:19:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:19:00 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77825|0 |1 is obsolete| | --- Comment #31 from Andrew Isherwood --- Created attachment 78382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78382&action=edit Bug 20581: DO NOT PUSH: Updated Schema Files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:19:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:19:07 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77826|0 |1 is obsolete| | --- Comment #32 from Andrew Isherwood --- Created attachment 78383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78383&action=edit Bug 20581: (follow-up) Display status name Rather than display the status code for custom statuses, we should be displaying the name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:19:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:19:12 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #33 from Andrew Isherwood --- Created attachment 78384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78384&action=edit Bug 20581: Fix display of status alias in OPAC Fix for status alias display in OPAC, we should be displaying the status name, not the status code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:21:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:21:11 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #35 from Andrew Isherwood --- Rebased on current master and provided an additional fix. Test custom status creation: 1) Apply this bug's patches 2) Apply database updates 3) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 4) Ensure you have the "ILLModule" preference enabled 5) Log in as a user with the ability to add authorised values. 6) Depending on whether you opted to accept the "Default ILL request status authorised value category name" data population during install, you may or may not have an authorised values category ILLSTATUS, if not, create it. 7) Add some authorised values to the ILLSTATUS category, these can be custom request statuses of your choice Test custom status usage: 8) From the staff interface, create an ILL request from a backend of your choice 9) On the resulting "Request details" page, observe that the request's status is "New request" 10) Click the "Edit request" button 11) In the "Request details" pane, observe that the request's status is now available in a drop down box, it should contain the current status PLUS your custom statuses. 12) Select a custom status and Submit the form 13) In the resulting "View ILL requests" page, observe that your request is now displaying your custom status. 14) Click the "Manage request" button for your new request 15) In the "Request details" page, observe that the request's status is displaying as your custom status Test custom status is overridden when request progresses through workflow: 16) Click "Confirm request", then the "Confirm request" confirmation 17) Observe that in the resulting "Request details" page, the request's status is now no longer displaying your custom status but has switched to "Requested" Test custom status is removed when authorised value is removed: 18) Observe that the request has the status "Requested", we are going to override that with a custom status, then remove that custom status authorised value 19) Click "Edit request" 20) Select a custom status and Submit the form 21) In the resulting "View ILL requests" page, observe that your request is now displaying your custom status. 22) Go to the authorised values management page 23) Delete the custom status you previously selected in step 19 24) Return to the list of ILL requests 25) Observe that the request that previously had the custom status now has it's former status of "Requested" Test API response for View ILL requests view: 26) Modify an existing request and set a custom status as discussed above 27) Navigate to the "View ILL requests" page 28) Examine the response to the API call made to the /api/v1/illrequests?embed=metadata,patron,capabilities,library,status_alias route 28) Observe that for requests with a custom status, the status_alias property contains an object for the request's authorised value containing the custom status 29) Observe that for requests without a custom status, status_alias is null Test OPAC view: 30) Modify an existing request and set a custom status as discussed above 31) In the OPAC, navigate to "your interlibrary loan requests" 32) In the "Interlibrary loan requests" view, observe that the request's status is displaying your custom value 33) Click "View" on the request with a custom value 34) In the "View Interlibrary loan request" view, observe that the request's status is displaying your custom value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:20:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:20:46 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #34 from Andrew Isherwood --- Rebased on current master and provided an additional fix. Test custom status creation: 1) Apply this bug's patches 2) Apply database updates 3) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 4) Ensure you have the "ILLModule" preference enabled 5) Log in as a user with the ability to add authorised values. 6) Depending on whether you opted to accept the "Default ILL request status authorised value category name" data population during install, you may or may not have an authorised values category ILLSTATUS, if not, create it. 7) Add some authorised values to the ILLSTATUS category, these can be custom request statuses of your choice Test custom status usage: 8) From the staff interface, create an ILL request from a backend of your choice 9) On the resulting "Request details" page, observe that the request's status is "New request" 10) Click the "Edit request" button 11) In the "Request details" pane, observe that the request's status is now available in a drop down box, it should contain the current status PLUS your custom statuses. 12) Select a custom status and Submit the form 13) In the resulting "View ILL requests" page, observe that your request is now displaying your custom status. 14) Click the "Manage request" button for your new request 15) In the "Request details" page, observe that the request's status is displaying as your custom status Test custom status is overridden when request progresses through workflow: 16) Click "Confirm request", then the "Confirm request" confirmation 17) Observe that in the resulting "Request details" page, the request's status is now no longer displaying your custom status but has switched to "Requested" Test custom status is removed when authorised value is removed: 18) Observe that the request has the status "Requested", we are going to override that with a custom status, then remove that custom status authorised value 19) Click "Edit request" 20) Select a custom status and Submit the form 21) In the resulting "View ILL requests" page, observe that your request is now displaying your custom status. 22) Go to the authorised values management page 23) Delete the custom status you previously selected in step 19 24) Return to the list of ILL requests 25) Observe that the request that previously had the custom status now has it's former status of "Requested" Test API response for View ILL requests view: 26) Modify an existing request and set a custom status as discussed above 27) Navigate to the "View ILL requests" page 28) Examine the response to the API call made to the /api/v1/illrequests?embed=metadata,patron,capabilities,library,status_alias route 28) Observe that for requests with a custom status, the status_alias property contains an object for the request's authorised value containing the custom status 29) Observe that for requests without a custom status, status_alias is null Test OPAC view: 30) Modify an existing request and set a custom status as discussed above 31) In the OPAC, navigate to "your interlibrary loan requests" 32) In the "Interlibrary loan requests" view, observe that the request's status is displaying your custom value 33) Click "View" on the request with a custom value 34) In the "View Interlibrary loan request" view, observe that the request's status is displaying your custom value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:25:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:25:13 +0000 Subject: [Koha-bugs] [Bug 21312] New: Show lockout on Patrons form Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312 Bug ID: 21312 Summary: Show lockout on Patrons form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a patron account has been locked out, we cannot see it on the Patrons form in staff. Would be nice however.. We can reset the lockout by changing the password. (Unfortunately we cannot force a temporary password for one-time use. Not for this report now.) Before removing an account, it might be handy to have the feature of locking it from the Patrons form (or automatically by script?). (Might be a step e.g. in handling GDPR unsubscribe requests.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:25:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:25:31 +0000 Subject: [Koha-bugs] [Bug 21312] Show lockout on Patrons form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |18314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 [Bug 18314] Account lockout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:25:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:25:31 +0000 Subject: [Koha-bugs] [Bug 18314] Account lockout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21312 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312 [Bug 21312] Show lockout on Patrons form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:55:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 13:55:31 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 jmbroust changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 16:11:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 14:11:55 +0000 Subject: [Koha-bugs] [Bug 18531] REST api: Add an endpoint for use by GOBI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #1 from Jon Knight --- Is there a link for documentation on the GOBI API available? I've been asked about integrating it with our open source LORLS reading list system (which itself is integrated with our live Koha instance) but my Google-fu has let me down finding any public documentation about how the GobiAPI works or the XML it expects/generates. If I could hit this bug fix at the same time it could kill two birds with one stone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:18:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2018 15:18:29 +0000 Subject: [Koha-bugs] [Bug 8937] Translation process removes CDATA in RSS XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 --- Comment #3 from Victor Grousset/tuxayo --- Should be fixed by bug 15395 So it might be better to put the efforts in treating the cause instead of yet another symptom. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 07:40:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 05:40:09 +0000 Subject: [Koha-bugs] [Bug 8038] Enable network printing when UsePrintQueues is on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8038 john thomas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raghuram88585 at gmail.com --- Comment #3 from john thomas --- If you are using personal Firewall software, you disable this application and attempt to print again. The Firewall may be blocking the necessary network communication between your computer and the Brother machine. For more information visit this link https://www.brotherprintersupportnumber.com/blog/how-to-fix-brother-printer-error-code-2147500037/ for solving this issues disable your Firewall as soon as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 07:43:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 05:43:48 +0000 Subject: [Koha-bugs] [Bug 8038] Enable network printing when UsePrintQueues is on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8038 --- Comment #4 from john thomas --- If you are using personal Firewall software, you disable this application and attempt to print again. The Firewall may be blocking the necessary network communication between your computer and the Brother machine. For more information visit this link https://www.brotherprintersupportnumber.com/blog/how-to-fix-brother-printer-error-code-2147500037/ for solving this issues disable your Firewall as soon as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 08:38:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 06:38:24 +0000 Subject: [Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18097 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 08:38:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 06:38:24 +0000 Subject: [Koha-bugs] [Bug 18097] It is possible to create unusable category codes (ccode) due to field length mismatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18097 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5458 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 10:00:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 08:00:50 +0000 Subject: [Koha-bugs] [Bug 21313] New: Database recovery error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21313 Bug ID: 21313 Summary: Database recovery error Change sponsored?: --- Product: Koha Version: 17.11 Hardware: HP OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: nshutieve at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com My client's server hard disk crashed. They had not made any backups since the use of Koha ILS. So my option was to recover database from MySQL database files (copy from old to new installation). But the problem i am having is that on loading the staff client interface, the web installation restarts and after selecting defaults, i get a Software Error like this: DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_library.search_field' doesn't exist at /usr/share/koha/lib/Koha/Objects.pm line 110. I really need help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 10:39:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 08:39:51 +0000 Subject: [Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 10:53:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 08:53:37 +0000 Subject: [Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 12:19:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 10:19:07 +0000 Subject: [Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 12:19:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 10:19:11 +0000 Subject: [Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 --- Comment #3 from Fridolin SOMERS --- Created attachment 78385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78385&action=edit Bug 5458: increase ccode column to varchar 80 Koha allows you to define an authorised value having length 80, but then you can't use it. Here is why: The SQL field items.ccode is a varchar(10). The SQL field authorised_values.authorised_value is a varchar(80). Therefore the authorised value is truncated to length 10 in items.ccode and the mapping from authorised value to description string fails in Koha. This patch increases ccode column to varchar 80, like location. Test plan : 1) Check there is on item field a subfield with authorised value category CCODE 2) Check this subfield is linked with database column items.ccode 3) Create an authorised values in category CCODE with 'DOCUMENTATION' 4) Edit an item on ccode and choose 'DOCUMENTATION' 5) Save item 6) Look at items.ccode in database or export in MARCXML 7) Without patch the value is troncated to 'DOCUMENTAT', not with patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 12:19:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 10:19:30 +0000 Subject: [Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 --- Comment #4 from Fridolin SOMERS --- Created attachment 78386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78386&action=edit Bug 5458: Update DBIx schema -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 12:54:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 10:54:43 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77623|0 |1 is obsolete| | --- Comment #278 from Martin Renvoize --- Created attachment 78387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78387&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 12:54:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 10:54:51 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77624|0 |1 is obsolete| | --- Comment #279 from Martin Renvoize --- Created attachment 78388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78388&action=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 12:55:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 10:55:00 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77625|0 |1 is obsolete| | --- Comment #280 from Martin Renvoize --- Created attachment 78389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78389&action=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 12:55:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 10:55:09 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77626|0 |1 is obsolete| | --- Comment #281 from Martin Renvoize --- Created attachment 78390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78390&action=edit Bug 11897: Stockrotation The stock rotation feature adds a batch process to automate rotation of catalgue items with a staff client page under tools to manage rotas/schedules. Once a rota is configured, and your staff user has the right permissions to allocate items, then an additional tab will appear on biblio records allowing the management of of which rota, if any, individual items belong to. It also includes a cron script to process the items on a daily basis. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 12:56:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 10:56:48 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #282 from Martin Renvoize --- Sorry for the delay, you caught me on vacation ;). I've rebased the patches upon master and accordingly updated the CSS to the SCSS equivalent. I'd appreciate Owens input on that side of things as I'm pretty new to scss in koha myself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 13:12:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 11:12:43 +0000 Subject: [Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com --- Comment #5 from Cab Vinton --- Patch applied successfully in sandbox, but value still appears truncated to DOCUMENTAT both w/ report displaying items.ccode and w/ XML export of record. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 13:28:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 11:28:09 +0000 Subject: [Koha-bugs] [Bug 21237] Clean up staff client SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize --- Enhancement will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 13:28:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 11:28:10 +0000 Subject: [Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Bug 21239 depends on bug 21237, which changed state. Bug 21237 Summary: Clean up staff client SCSS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21237 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 13:29:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 11:29:34 +0000 Subject: [Koha-bugs] [Bug 21239] CSS regressions caused by SCSS move In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21239 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Martin Renvoize --- Fixes to issues caused by bug 19474 not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 14:00:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 12:00:21 +0000 Subject: [Koha-bugs] [Bug 21313] Database recovery error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21313 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 14:41:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 12:41:17 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 14:47:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 12:47:35 +0000 Subject: [Koha-bugs] [Bug 21313] Database recovery error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21313 --- Comment #2 from Evelyne --- (In reply to Owen Leonard from comment #1) > This sounds like a support request rather than a bug. > > Questions about Koha should be asked on the Koha mailing list > (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC > channel (http://koha-community.org/get-involved/irc/). > > Hopefully you've already seen the Koha documentation: > http://koha-community.org/documentation/ > > You can also find options for paid support here: > https://koha-community.org/support/ Thanks for redirecting me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:12:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:12:46 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78387|0 |1 is obsolete| | --- Comment #283 from Martin Renvoize --- Created attachment 78391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78391&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:12:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:12:54 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78388|0 |1 is obsolete| | --- Comment #284 from Martin Renvoize --- Created attachment 78392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78392&action=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:13:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:13:10 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78390|0 |1 is obsolete| | --- Comment #286 from Martin Renvoize --- Created attachment 78394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78394&action=edit Bug 11897: Stockrotation The stock rotation feature adds a batch process to automate rotation of catalgue items with a staff client page under tools to manage rotas/schedules. Once a rota is configured, and your staff user has the right permissions to allocate items, then an additional tab will appear on biblio records allowing the management of of which rota, if any, individual items belong to. It also includes a cron script to process the items on a daily basis. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:13:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:13:02 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78389|0 |1 is obsolete| | --- Comment #285 from Martin Renvoize --- Created attachment 78393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78393&action=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:18:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:18:03 +0000 Subject: [Koha-bugs] [Bug 18480] Get rid of unwanted / distracting link in patron search for fund owner In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:18:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:18:06 +0000 Subject: [Koha-bugs] [Bug 18480] Get rid of unwanted / distracting link in patron search for fund owner In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77743|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 78395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78395&action=edit Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:34:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:34:27 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:34:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:34:32 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77661|0 |1 is obsolete| | Attachment #77662|0 |1 is obsolete| | Attachment #77663|0 |1 is obsolete| | Attachment #77664|0 |1 is obsolete| | Attachment #77665|0 |1 is obsolete| | Attachment #77666|0 |1 is obsolete| | Attachment #77667|0 |1 is obsolete| | --- Comment #93 from Nick Clemens --- Created attachment 78396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78396&action=edit Bug 18316: Ability to weight search fields Weight can be defined between 1 and 99. only search fields mapped with biblios can be weighted Test plan: - apply this patch, - update schema file (perl misc/devel/update_dbix_class_files.pl), - go to Administration > Search engine configuration, - in search fields tab, define weights for some fields and save, - check weights has been saved, - reset some weights (empty) and save, - check weights has been reset Signed-off-by: S?verine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:34:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:34:38 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #94 from Nick Clemens --- Created attachment 78397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78397&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on all fields plus those with the coresponding weights. Else, search is done on the entire record with no weighting. The advanced search page is unaffected by these changes Test plan (having Koha working with Elasticsearch): - apply this patch - have some weights defined for various fields - try searches from the search bar and from the advanced search page - confirm weighting affects the relevancy (in expected ways) e.g. 1. search for 'a' from advanced search, note results 2. give 'title' a weight 3. search for 'a' using the simple search bar 4. results with 'a' in the title should now be more relevant - confirm search results on advanced search page are unaffected Signed-off-by: S?verine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:34:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:34:43 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #95 from Nick Clemens --- Created attachment 78398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78398&action=edit Bug 18316: String changes Signed-off-by: Nick Clemens Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:34:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:34:49 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #96 from Nick Clemens --- Created attachment 78399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78399&action=edit Bug 18316: (follow-up) Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:34:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:34:54 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #97 from Nick Clemens --- Created attachment 78400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78400&action=edit Bug 18316: Change search field weight field to decimal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:34:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:34:59 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #98 from Nick Clemens --- Created attachment 78401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78401&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:35:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:35:04 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #99 from Nick Clemens --- Created attachment 78402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78402&action=edit Bug 18316: Fix field weight validation/deletion bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:35:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:35:09 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #100 from Nick Clemens --- Created attachment 78403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78403&action=edit Bug 18316: (follow-up) Fix tests and update statement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:35:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:35:56 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78391|0 |1 is obsolete| | --- Comment #287 from Martin Renvoize --- Created attachment 78404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78404&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:36:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:36:05 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78392|0 |1 is obsolete| | --- Comment #288 from Martin Renvoize --- Created attachment 78405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78405&action=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:36:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:36:12 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78393|0 |1 is obsolete| | --- Comment #289 from Martin Renvoize --- Created attachment 78406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78406&action=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:36:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:36:20 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #290 from Martin Renvoize --- Created attachment 78407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78407&action=edit Bug 11897: Add Boolean handling to dbic classes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:36:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 13:36:27 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78394|0 |1 is obsolete| | --- Comment #291 from Martin Renvoize --- Created attachment 78408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78408&action=edit Bug 11897: Stockrotation The stock rotation feature adds a batch process to automate rotation of catalgue items with a staff client page under tools to manage rotas/schedules. Once a rota is configured, and your staff user has the right permissions to allocate items, then an additional tab will appear on biblio records allowing the management of of which rota, if any, individual items belong to. It also includes a cron script to process the items on a daily basis. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:12:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 14:12:52 +0000 Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:12:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 14:12:56 +0000 Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77789|0 |1 is obsolete| | Attachment #77790|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 78409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78409&action=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpull? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:12:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 14:12:59 +0000 Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #9 from Owen Leonard --- Created attachment 78410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78410&action=edit Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:14:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:14:34 +0000 Subject: [Koha-bugs] [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20779 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 [Bug 20779] Style refresh for patron detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:14:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:14:34 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21209 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:15:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:15:54 +0000 Subject: [Koha-bugs] [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize --- Caused by bug 20779 not in 18.05.x series, marking resolved fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:31:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:31:25 +0000 Subject: [Koha-bugs] [Bug 21314] New: Koha enforces 3 character password length even if RequireStrongPassword is disabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Bug ID: 21314 Summary: Koha enforces 3 character password length even if RequireStrongPassword is disabled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 18298 added the option to enforce password complexity *if* the new system preference RequireStrongPassword is enabled. However, it appears that the code defining the minimum number of characters was not put under control of this preference and thus Koha enforces a minimum password length of 3 even if RequireStrongPassword is disabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:31:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:31:28 +0000 Subject: [Koha-bugs] [Bug 21314] Koha enforces 3 character password length even if RequireStrongPassword is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:31:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:31:31 +0000 Subject: [Koha-bugs] [Bug 18298] Allow enforcing password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 [Bug 21314] Koha enforces 3 character password length even if RequireStrongPassword is disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:31:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:31:31 +0000 Subject: [Koha-bugs] [Bug 21314] Koha enforces 3 character password length even if RequireStrongPassword is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 [Bug 18298] Allow enforcing password complexity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:31:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:31:45 +0000 Subject: [Koha-bugs] [Bug 21314] Koha enforces three character password length even if RequireStrongPassword is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha enforces 3 character |Koha enforces three |password length even if |character password length |RequireStrongPassword is |even if |disabled |RequireStrongPassword is | |disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:32:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:32:01 +0000 Subject: [Koha-bugs] [Bug 21314] Koha enforces three (3) character password length even if RequireStrongPassword is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha enforces three |Koha enforces three (3) |character password length |character password length |even if |even if |RequireStrongPassword is |RequireStrongPassword is |disabled |disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:47:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:47:09 +0000 Subject: [Koha-bugs] [Bug 20223] Merge members-menu and circ-menu inc files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76575|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 78411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78411&action=edit Bug 20223: Merge members-menu and circ-menu inc files This patch removes members-menu.inc and replaces the last functional use of it with a call to circ-menu.inc. An invalid use of members-menu.inc has been removed from member.tt. To test, apply the patch and open a patron record for editing. The sidebar menu should look correct and all sidebar links should work correctly. View the patrons home page and confirm that nothing has broken. Search the Koha codebase for references to members-menu.inc. There should be none. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:47:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:47:06 +0000 Subject: [Koha-bugs] [Bug 20223] Merge members-menu and circ-menu inc files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:49:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 15:49:59 +0000 Subject: [Koha-bugs] [Bug 21231] BlockReturnofLostItems does not prevent lost items being found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21231 --- Comment #20 from Andrew --- Thanks, folks! Anrdrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:00:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 16:00:12 +0000 Subject: [Koha-bugs] [Bug 21186] Incorrect Bootstrap modal event name in multiple templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21186 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:00:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 16:00:15 +0000 Subject: [Koha-bugs] [Bug 21186] Incorrect Bootstrap modal event name in multiple templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21186 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77630|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 78412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78412&action=edit Bug 21186: Incorrect Bootstrap modal event name in multiple templates Modals in the staff client which load data via AJAX require an "on close" action in order to clear the modal of the loaded data. The problem presents itself the second time the modal is opened: The "loading" message doesn't appear, and the data from the previous link is shown until the new data loads. To test, apply the patch and test the following pages. In each case, click multiple instances of the modal trigger link/button to confirm that the "loading" message always appears between re-displays of the modal. - Acquisitions -> Vendor -> Add to basket -> From a staged file -> Add orders - Test the "MARC" and "Card" links - Acquisitions -> EDIFACT messages - Test the "View message" button - Acquisitions -> Vendor -> Add to basket -> From an existing record - Test "View MARC" link - Acquisitions -> Vendor -> Invoices -> Invoice -> Receipt page - Test the "Order," "MARC," and "Card" links. - Catalog -> Bibliographic record details - Test the MARC Preview link. - Cataloging -> Cataloging search results - Test the Actions -> MARC preview and Actions -> Card preview menu items - Cataloging -> Cataloging search results -> Merge - Test the "View MARC" linkscataloguing/merge.tt - Tools -> Patron lists -> Actions -> Print patron cards - Tools -> Batch record modification -> Results -> Show MARC - Tools -> Staged MARC record management -> View batch - Test MARC preview shown when you click a staged title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:10:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 16:10:04 +0000 Subject: [Koha-bugs] [Bug 10442] Remove references to non-standard "error" class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77742|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 78413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78413&action=edit Bug 10442: Remove references to non-standard "error" class The CSS for
is obsolete and should not be used. This patch removes the definition from the main CSS file and corrects instances of its use in the templates to the standard
. To test: - In Acquisitions -> Late orders, locate an order from a vendor which doesn't have an email address. Selecting that order and clicking "Claim" should trigger an error dialog, "This vendor has no email." It should be styled correctly. - With AcqCreateItem set to "when placing an order," add to an existing order using the "From a new (empty) record" option. Add two items with identical barcodes and submit the form. A error should show at the top of the page. - With AcqCreateItem set to "when receiving an order," receive an order and add two items with identical barcodes. Submitting the form should trigger an error message at the top of the page. With the remaining cases I don't know how to trigger the errors in question, so a visual check of the changes may be required: - Administration -> Funds -> "You are not authorized to modify this fund" - Administration -> Search engine configuration (/admin/searchengine/elasticsearch/mappgings.pl) -> Various modification errors. - With the AutoEmailOpacUser preference set to "send," adding a patron without an email address can trigger an error, "This member has no email." - With plugins enabled, and installed, there are error messages displayed under various circumstances. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:10:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 16:10:01 +0000 Subject: [Koha-bugs] [Bug 10442] Remove references to non-standard "error" class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 19:04:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 17:04:49 +0000 Subject: [Koha-bugs] [Bug 21314] Koha enforces three (3) character password length even if RequireStrongPassword is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Hi Kyle, another pref drives this behavior, see minPasswordLength -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 19:16:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 17:16:41 +0000 Subject: [Koha-bugs] [Bug 21314] Koha enforces three (3) character password length even if RequireStrongPassword is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 19:16:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 17:16:44 +0000 Subject: [Koha-bugs] [Bug 21314] Koha enforces three (3) character password length even if RequireStrongPassword is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 --- Comment #2 from Kyle M Hall --- Created attachment 78414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78414&action=edit Bug 21314: Koha enforces three (3) character password length even if RequireStrongPassword is disabled Bug 18298 added the option to enforce password complexity *if* the new system preference RequireStrongPassword is enabled. However, it appears that the code defining the minimum number of characters was not put under control of this preference and thus Koha enforces a minimum password length of 3 even if RequireStrongPassword is disabled. Test Plan: 1) Set minPasswordLength to 2 2) Disable RequireStrongPassword 3) Attempt to change a password to a two character password 4) Note Koha tells you the minimum length is 3 characters 5) Apply this patch 6) Restart memached/plack, Reload the page 7) You should now be able to set the password to a 2 character string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 19:18:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 17:18:26 +0000 Subject: [Koha-bugs] [Bug 21314] Koha enforces three (3) character password length even if RequireStrongPassword is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #1) > Hi Kyle, another pref drives this behavior, see minPasswordLength That is not correct, that bug hard coded the 3 limit in such that if minPassword is less than 3 it is changed to 3. Please see the patch file for where this happens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 19:20:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 17:20:39 +0000 Subject: [Koha-bugs] [Bug 21314] Koha enforces three (3) character password length even if RequireStrongPassword is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Should we really allow such short passwords? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 19:28:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 17:28:01 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #101 from Nick Clemens --- (In reply to Joonas Kylm?l? from comment #90) > Instead of adding a new 'advsearch' parameter maybe checking whether the > 'idx' parameter is present would work just fine? I think having the search parameter to weight or not could be useful - advsearch should get weighting in future but may offer specific weighting. We also may want the ability to sometimes search without weights -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 20:08:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 18:08:11 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #74 from Jonathan Druart --- (In reply to Cab Vinton from comment #73) > Software error on PTFS sandbox 0: > > Template process failed: undef error - > DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha.circulation_rules' > doesn't exist at /home/koha/src/Koha/Objects.pm line 191 On which page do you get this error? The circulation_rules should have been created during the upgrade process, do you see any errors displayed in the news section on the Koha home page? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 20:54:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 18:54:38 +0000 Subject: [Koha-bugs] [Bug 21273] After upgrade from 17.11.08 to 18.05.02 intra not working, Software error: Template process failed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21273 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |tomascohen at gmail.com Version|18.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 21:13:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 19:13:23 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #248 from Jonathan Druart --- Created attachment 78415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78415&action=edit Bug 13618: Do not use html filters with KohaSpan To recreate the issue: Go to Home ? Administration ? Library groups Create a new group "Group xxx created." Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 21:20:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 19:20:17 +0000 Subject: [Koha-bugs] [Bug 21255] memberetnry.pl is missing categories in the Category pull-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21255 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master Status|NEW |In Discussion --- Comment #3 from Jonathan Druart --- Agreed, this feature has been poorly implemented, I am the one to blame. I am wondering if it makes sense to keep it as now we can limit access to patron's info by group of libraries (see bug 18403). Do you think this new feature could fit your use case? Does it really make sense to limit access to patron's categories? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 22:59:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 20:59:24 +0000 Subject: [Koha-bugs] [Bug 21315] New: test Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21315 Bug ID: 21315 Summary: test Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 22:59:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 20:59:59 +0000 Subject: [Koha-bugs] [Bug 21315] test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21315 --- Comment #1 from Alex Buckley --- Created attachment 78416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78416&action=edit Bug 15565: Place multiple holds at once for the same record on staff and OPAC. Test plan: 1. Create an circulation rule to use for testing the patches on this bug report. Ensure it has a value greater than 1 for 'Holds allowed', 'Holds per record (count)', and 'Item level holds' is enabled. 2. Also ensure the 'RequestOnOpac' syspref is set to 'Allow'. 3. Go to the reservation page (request.pl) of a biblio in the staff client with more than one item. 4. Notice beside each item a radio button is displayed preventing you from being able to select multiple items to place a hold on. 5. Go to the reservation page (opac-reserve.pl) of the same biblio in the OPAC also notice a radio button is displayed beside every item. 6. Apply patches 7. Repeat step 3 and 5 and notice in both the staff client and OPAC checkboxes rather than radio buttons are displayed beside each item so you can select multiple items for reservation at a time. 8. From staff interface, place several item-level holds for the same user on the same record at once: - check that you are warned if you exceed "Holds per record (count)" (circulation rules) for this record. - check also maxReserves system preference. 9. From opac, place several item-level and record level holds for the same user on the same record at once: - check that can't exceed "Holds per record (count)" for this record. This is enforced by all unticked item checkboxes being disabled after the number of ticked checkboxes equals the 'Holds per record (count)' (circulation rules) value. - check also maxReserves system preference. Do the same in OPAC and staff by selecting several record (multi-hold). Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:00:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:00:37 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78243|0 |1 is obsolete| | --- Comment #93 from Alex Buckley --- Created attachment 78417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78417&action=edit Bug 15565: CSS changes Note: Reworked as we have switched to CSS since this commit was first written. This commit now contains 2 files: * koha-tmpl/opac-tmpl/bootstrap/css/opac.css * koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:01:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:01:32 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78244|0 |1 is obsolete| | --- Comment #94 from Alex Buckley --- Created attachment 78418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78418&action=edit Bug 15565: Use item's biblionumber only on item-level request Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:06:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:06:27 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #95 from Alex Buckley --- I am going to go through obsoleting the existing patches and attach rebased patches onto this bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:07:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:07:36 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78418|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:07:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:07:50 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:08:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:08:04 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78305|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:08:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:08:15 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78266|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:08:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:08:31 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78248|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:08:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:08:43 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78247|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:08:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:08:58 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78246|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:09:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:09:10 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78245|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:10:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:10:15 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #96 from Alex Buckley --- Created attachment 78419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78419&action=edit Bug 15565: CSS changes Note: Reworked as we have switched to CSS since this commit was first written. This commit now contains 2 files: * koha-tmpl/opac-tmpl/bootstrap/css/opac.css * koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:11:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:11:58 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #97 from Alex Buckley --- Created attachment 78420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78420&action=edit Bug 15565: Use item's biblionumber only on item-level request Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:12:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:12:31 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #98 from Alex Buckley --- Created attachment 78421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78421&action=edit Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off Signed-off-by: Danielle Elder Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:12:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:12:58 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #99 from Alex Buckley --- Created attachment 78422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78422&action=edit Bug 15565: Alert librarian that maximum holds per record is reached Signed-off-by: Dani Elder Signed-off-by: Danielle Elder Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:13:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:13:24 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #100 from Alex Buckley --- Created attachment 78423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78423&action=edit Bug 15565: Remove use of GetBiblionumberFromItemnumber Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:13:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:13:53 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #101 from Alex Buckley --- Created attachment 78424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78424&action=edit Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC This commit fixes two bugs: 1. C4::Reserves->CanItemBeReserved() returns an output in a hash in the format: status => 'output' However opac-reserve.pl is not accessing th output of this function correctly consequently no item is ever reservable. And so after a patron submits the reservation form on opac-reserve.pl it looks like the item-level reservation has successfully been placed however it has not and no error message is displayed to them. This commit stores the output of the aforementioned function in a hash and then checks the value of the status key. As a result opac-reserve.pl now correctly accesses the value returned and item level holds are successfully placed from the OPAC. 2. If a biblio has previously been reserved then the opac-reserve.pl page shows the 'Next available item' and 'A specific item' radio buttons to be disabled to ensure patrons cannot place a reservation of a different type on the biblio. With both of these radio buttons being disabled it results in item level holds placed in the OPAC on a previously reserved item not being stored in the database. This is very confusing for users. I have implemented a conditional which checks what the forced_hold_type of the previous hold was. If it was 'item' then the $reqtype = 'Specific' and if it was 'record' then $reqtype is 'Any'. This means there will always be a value for $reqtype, and this variable is checked if it is equal to 'Specific' and if it is then an item level hold is placed. Test plan: 1. Ensure in your circulation rules that 'Item level holds' is enabled 2. Apply all patches on this bug report except this commit 3. In the OPAC try placing a item level hold (and notice you can submit the opac-reserve.pl page and no error messages are displayed. However the hold(s) are not being placed. 4. Place an item level hold(s) on the biblio from staff client interface and then return to the opac-reserve.pl page for the biblio in the OPAC and notice both the 'Next available' and 'A specific item' radio buttons are disabled. 5. Again try placing an item level hold in the OPAC and notice dispite no error/warning message being displayed the hold is not being placed. 6. Apply this patch 7. Restart memcached, and plack 8. In the staff client remove the reservation you placed from the staff client. 9. Repeat step 3 and notice when you go to your opac summary (opac-user.pl) page the holds are displayed. .i.e. You can now successfully place item level holds in the OPAC. 10. Return to the opac-reserve.pl page for the biblio and notice that because you have already placed a hold on this biblio the 'Next available item' and 'A specific item' radiobuttons are disabled. 11. Select several of the items checkboxes to place more item level holds and press the 'Confirm hold' button. 12. Go to your opac summary (opac-user.pl) page again and notice the holds you placed in step 11 are shown there. i.e. you can place item level holds from the OPAC on biblios which have previously had reserves placed on them. Sponsored-By: Brimbank Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:14:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:14:40 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #102 from Alex Buckley --- Created attachment 78425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78425&action=edit Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl Previously the selected branch dropdown value was not being successfully retrieved in opac-reserve.pl, this resulted in opac holds being placed with no pickup branch being set. Consequently as no branch was associated with the hold an Ajax error was thrown when viewing the holds-table in the patron page in the staff client. This commit successfully retrieves the selected branch value and so fixing the Ajax error. Test plan: 1. Apply all patches on bug report 15565 except this commit 2. Place a hold(s) from opac-reserve.pl. 3. Go to your opac patron summary page (opac-user.pl) and notice although the holds are successfully displayed they have no 'Pickup location' value 4. Go to the patron page in the staff client and click on the 'Hold(s)' tab and notice a popup explaining the datatable Ajax error is loaded 5. Apply this patch 6. Repeat step 3 noticing this time in the opac-user.pl a 'Pickup location' is displayed for the hold you just created. 6. Repeat step 4 and notice the hold datatable is successfully loaded and populated without an Ajax error popup being loaded. Sponsored-By: Brimbank Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:15:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:15:23 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #103 from Alex Buckley --- Created attachment 78426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78426&action=edit Bug 15565: Allow up to (and including) maxreserves number of OPAC item levelholds This commit implements changes to opac-reserve.tt and opac-reserve.pl. 1. The change to opac-reserve.tt JS fixes the total_requested() function which returns an output which is always 2 digits higher than the actual number of selected item checkboxes. i.e. if the 'maxreserves' syspref (limit for the overall number of reserves allowed by a user) is 4 and a user has no previous holds and ticks 3 item checkboxes and submits the form. The 'Maximum number of reserve exceded.' popup message is displayed, however as they have selected 3 items for reservation this is less than the maxreserves value of 4. The popup is displayed because total_requested() JS function is returning 5 (i.e. 2 on top of the actual number of requested holds). This commit usbtracts 2 from the number of holds calculated by total_requested() so that the accurate number of requested holds is being used to determine whether or not to display the excess holds popup. 2. When the 'Holds per record (count)' (circulation rule) and 'maxreserves' syspref are the same value (e.g. 4) you can tick 4 item checkboxes in opac-reserve.pl and submit the form. The form will submit successfully and to the user everything looks to have worked however the holds will not be successfully created. This is because after the form is submitted to opac-reserve.pl a check is done: If 'number of submitted hold requests' + 'number of previous existing holds' greater than or equal to maxreserves syspref then set the variable '$canreserve' to 0. If the $canreserve variable is 0 the form will submit, no warning/error message is displayed to the user but the holds are not created. Users should be able to place 4 holds if the maxreserves syspref is 4 (just not more than 4 holds). This commit changes this check to: If 'number of submitted hold requests' + 'number of previous existing holds' greater than maxreserves syspref then set the variable '$canreserve' to 0.. i.e. notice we only check for greater than (not equal to). Which solves the bug of the form submitting and no holds being created when the maxreserves syspref and 'Holds per record (count)' (circulation rule) are the same. Test plan (in two parts to test fix #1 and #2 (above)): Test plan for fix #1: 1. Apply all patches on this bug report (15565) and follow and confirm the feature works as described in the test plan in the first commit 2. Set the 'maxreserves' syspref to 3 (and 'Holds per record (count)' (circulation rule) to 5) 3. Ensure your logged in patron account has no existing reserves 4. In the OPAC go to a biblio page with 3 or more items 5. In the reservation page (opac-reserve.pl) for that biblio select 2 item checkboes to place 2 item level holds and notice the 'Maximum number of reserve exceded.' popup message is displayed. As the maxreserves syspref value is 3 you should be able to place 2 holds without exceeding that value 6. Apply this patch 7. Repeat step 5 and notice the form submits without the exceeding popup message and the holds are successfully placed. Test plan for fix #2: 1. Apply all patches attached to this bug report (bug 15565) and perform the test plan in the first commit and verify it works. 2. Set your 'Holds per record (count)' (circulation rule) and 'maxreserves' syspref to the same value 3 3. Go to a biblio in the OPAC with 3 or more items 4. In the opac-reserve.pl reservation interface for that biblio tick 3 item checkboxes to place 3 item level holds and submit the form. 5. Notice the form submits and no warning/error message is displayed 6. In the opac user summary page that is displayed after the reserve form is submitted notice the holds are not displayed this is because they have not been placed 7. Apply this patch 8. Repeat step 4 and 5 and notice the holds have been successfully placed and are displayed in your opac user summary page. Sponsored-By: Brimbank Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:17:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:17:54 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #104 from Alex Buckley --- The rebased patches should now apply cleanly on master (as of 5/9/2018), as shown below: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15565: Place multiple holds at once for the same record on staff and OPAC. Applying: Bug 15565: CSS changes Applying: Bug 15565: Use item's biblionumber only on item-level request Applying: Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off Applying: Bug 15565: Alert librarian that maximum holds per record is reached Applying: Bug 15565: Remove use of GetBiblionumberFromItemnumber Applying: Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC Applying: Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl Applying: Bug 15565: Allow up to (and including) maxreserves number of OPAC item levelholds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:19:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2018 21:19:25 +0000 Subject: [Koha-bugs] [Bug 21315] test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21315 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 02:19:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2018 00:19:27 +0000 Subject: [Koha-bugs] [Bug 21314] Koha enforces three (3) character password length even if RequireStrongPassword is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan at calyx.net.au --- Comment #5 from Dilan Johnpull? --- Created attachment 78427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78427&action=edit Error message when changing password Applied the patch, restarted plack, apache and memcached and attempted to set a patron password of 2 characters after changing the sysprefs as per the test plan. I'm getting a very confusing error message saying that I'm not entering two characters even though I am. I tried setting the minPasswordLength syspref to one but it then complains that I'm not entering at least 1 character. This is also true if I type in a password with two characters. It looks like it's still searching for three characters when changing patron passwords. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 03:04:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2018 01:04:23 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 03:04:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2018 01:04:27 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78358|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpull? --- Created attachment 78428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78428&action=edit Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from Use assets for external js and css - see https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML8:_use_Asset_TT_plugin_for_linking_javascript_and_css_files @@ +3,5 @@ > +[% INCLUDE 'doc-head-close.inc' %] > +[% INCLUDE 'calendar.inc' %] > + > +[% INCLUDE 'timepicker.inc' %] > +' %] [% x | $Price %] => Display '0.00' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 18:14:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 16:14:23 +0000 Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 --- Comment #3 from Jonathan Druart --- Created attachment 79616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79616&action=edit Bug 21454: Remove html filter for Price filtered variables Generated with: perl -p -i -e 's/\|\s?\$Price\s?\|\s?html\s%]/| \$Price %]/g' **/*.tt **/*.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 18:14:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 16:14:31 +0000 Subject: [Koha-bugs] [Bug 21167] Correct price formatting on printed fee receipt and invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21167 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21454 --- Comment #26 from Jonathan Druart --- (In reply to Jonathan Druart from comment #25) > Jenkins is not happy since these changes (xt/find-missing-filters.t). The > Price filter is not correctly handled by the tests, we should not need to > html escape the result. I will try and provide a global fix on a separate > bug report. See bug 21454. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 18:14:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 16:14:31 +0000 Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21167 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 18:14:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 16:14:10 +0000 Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 18:24:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 16:24:11 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #64 from Jonathan Druart --- (In reply to Nick Clemens from comment #63) > I think some of the lines in chart.inc need filters? They are not failing > the test but want to make sure before pushing. Which ones? Did you see the last patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 18:37:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 16:37:09 +0000 Subject: [Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 --- Comment #9 from Katrin Fischer --- (In reply to Jonathan Druart from comment #8) > I tried the label in red but it looked bad, it takes too much visibility. I think you are right, it would be too prominent, when the search is only one valid option on the form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 19:49:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 17:49:57 +0000 Subject: [Koha-bugs] [Bug 21423] When removing one sub-permission all permissions of the module are removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21423 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I do not recreate, maybe one step is missing. Can you give more details? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 20:00:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 18:00:13 +0000 Subject: [Koha-bugs] [Bug 21423] When removing one sub-permission all permissions of the module are removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21423 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal --- Comment #2 from Katrin Fischer --- I can't reproduce it now - lowering severity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 20:01:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 18:01:07 +0000 Subject: [Koha-bugs] [Bug 21423] When removing one sub-permission all permissions of the module are removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21423 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Katrin Fischer --- I am not sure what happened there, but happy it's not a bug apparently :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 20:16:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 18:16:37 +0000 Subject: [Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com --- Comment #3 from Jonathan Druart --- I am wondering if this is the right fix, I guess we should handle the "no" value instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 20:17:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 18:17:35 +0000 Subject: [Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 --- Comment #4 from Jonathan Druart --- Created attachment 79617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79617&action=edit [ALTERNATIVE-PATCH] Bug 21426: Handle USE_MEMCACHED=no in koha-create -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 20:18:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 18:18:19 +0000 Subject: [Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18342 | Status|Signed Off |In Discussion Depends on| |18342 --- Comment #5 from Jonathan Druart --- What about this alternative patch? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 [Bug 18342] Set memcached as 'enabled' by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 20:18:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 18:18:19 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21426 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21426 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 20:22:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 18:22:20 +0000 Subject: [Koha-bugs] [Bug 21446] Permanent location should show with cart location - course-details.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 --- Comment #1 from Christopher Brannon --- Created attachment 79618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79618&action=edit Bug 21446: Correct perm location and enhance TO TEST: 1) Set ReturnToShelvingCart on. 2) Create a Course Reserve and make inactive. 3) Add an item, changing Item type, Collection code, Shelving location, and Holding library. 4) Note these four fields in the item list. 5) Activate course reserve. 6) Note subtle/no difference in these fiels in the list. 7) Check in the item. 8) Go back to course reserves and note that the cart is listed in the field instead of permanent location. 9) Deactivate course reserve. 10) Reset permanent location on item manually. 11) Apply patch. 12) Repeat steps 4-9 noting that the permanent location is showing instead of current location. Also, if a change is assigned to the item, the change AND the regular state always show. The active state will be in bold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 20:27:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 18:27:03 +0000 Subject: [Koha-bugs] [Bug 21446] Permanent location should show with cart location - course-details.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Christopher Brannon --- I've tracked the actual location change to course-details.tt. I also did some enhancements of the temporary changes and regular states so it is more obvious. I am also noting a couple flaws in the module: Notes can be changed by the course reserves, but should be appended to temporarily. The course reserves appears to permanently change the notes. Also, once an item is added to the reserve, editing the item will not produce any changes. You have to delete the item and add it again with the new changes for it to take. These items should be addressed in a new bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 20:32:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 18:32:51 +0000 Subject: [Koha-bugs] [Bug 21446] Permanent location should instead of cart location - course-details.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Permanent location should |Permanent location should |show with cart location - |instead of cart location - |course-details.pl |course-details.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 20:59:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 18:59:37 +0000 Subject: [Koha-bugs] [Bug 17845] Remove printer related code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart --- Found 3 smalls things: 1. installer/data/mysql/atomicupdate/bug_17845_remove_printers should be a .perl and DROP COLUMN should only be executed if the column exists (column_exists) 2. koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc: Can be removed 3. in circulation.tt: 604 Can be removed as well TODO later: rename selectbranchprinter(.pl|.tt) Note: I have checked the set_userenv calls and they are all good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:02:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:02:14 +0000 Subject: [Koha-bugs] [Bug 21446] Permanent location should instead of cart location - course-details.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 --- Comment #3 from Christopher Brannon --- Scratch the comment about the notes. They seem to operate differently from the rest of the fields. This should be noted in the manual. Notes entered in course reserves do not replace notes in the item record as the other fields do. These notes only appear to show up in the course reserve modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:03:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:03:58 +0000 Subject: [Koha-bugs] [Bug 21448] Field 606 doesn't add multiple x subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18904 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Caused by commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551 Bug 18904: (follow-up) Retrieve subfield in the order they are stored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 [Bug 18904] Advanced editor - Rancor - Add authority support -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:03:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:03:58 +0000 Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21448 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448 [Bug 21448] Field 606 doesn't add multiple x subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:04:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:04:11 +0000 Subject: [Koha-bugs] [Bug 21448] Field 606 doesn't add multiple x subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Version|18.05 |master Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:09:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:09:54 +0000 Subject: [Koha-bugs] [Bug 21446] Permanent location should instead of cart location - course-details.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 --- Comment #4 from Christopher Brannon --- Created attachment 79619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79619&action=edit Bug 21446: Remove fix comment Fix is not needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:10:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:10:03 +0000 Subject: [Koha-bugs] [Bug 21448] Field 606 doesn't add multiple x subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:10:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:10:07 +0000 Subject: [Koha-bugs] [Bug 21448] Field 606 doesn't add multiple x subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448 --- Comment #2 from Jonathan Druart --- Created attachment 79620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79620&action=edit Bug 21448: Fix copy repeated subfields when linking an authority with 6xx The reported issue was: On field 606, if I use an Authority with multiple "x" subfields, it will add just the first "x" Error in the logs: Odd number of elements in anonymous hash at /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97. We should pass a ref (!), caused by commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551 Bug 18904: (follow-up) Retrieve subfield in the order they are stored Test plan: Edit an authority and add several $x to 600 Link this authority to a bibliographic record => Without this patch only the first subfield is copied => With this patch applied they are all copied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:15:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:15:49 +0000 Subject: [Koha-bugs] [Bug 21446] Permanent location should instead of cart location - course-details.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Permanent location should |Permanent location should |instead of cart location - |instead of cart location - |course-details.pl |course-details.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:45:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:45:24 +0000 Subject: [Koha-bugs] [Bug 21377] Variable declarations erroneously filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13618 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:45:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:45:24 +0000 Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21377 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 [Bug 21377] Variable declarations erroneously filtered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:54:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:54:06 +0000 Subject: [Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424 --- Comment #26 from Jonathan Druart --- Copyright is wrong in svc/bib_framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 21:55:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 19:55:27 +0000 Subject: [Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424 --- Comment #27 from Jonathan Druart --- Created attachment 79621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79621&action=edit Bug 16424: (follow-up) remove wrong copyright statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 22:07:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 20:07:05 +0000 Subject: [Koha-bugs] [Bug 13272] Many inputs lack a type attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 22:07:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 20:07:14 +0000 Subject: [Koha-bugs] [Bug 13272] Many inputs lack a type attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 --- Comment #27 from Jonathan Druart --- Created attachment 79623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79623&action=edit Bug 13272: (follow-up) fix concerns from comment #5 Correct the two issues I pointed out. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 22:07:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 20:07:10 +0000 Subject: [Koha-bugs] [Bug 13272] Many inputs lack a type attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79593|0 |1 is obsolete| | Attachment #79594|0 |1 is obsolete| | Attachment #79595|0 |1 is obsolete| | Attachment #79596|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 79622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79622&action=edit Bug 13272: Adds type="text" to inputs missing it Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 22:07:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 20:07:18 +0000 Subject: [Koha-bugs] [Bug 13272] Many inputs lack a type attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 --- Comment #28 from Jonathan Druart --- Created attachment 79624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79624&action=edit Bug 13272: (follow-up) Replace tabs with spaces Cleaned up whitespace issues tab vs. space in template. After applying all patches: git diff -w origin/master For the koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt only the changed type="text" lines will show, but without the -w, there will be more whitespace changes. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 22:07:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 20:07:23 +0000 Subject: [Koha-bugs] [Bug 13272] Many inputs lack a type attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 --- Comment #29 from Jonathan Druart --- Created attachment 79625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79625&action=edit Bug 13272: (follow-up) add missing type="text" This addresses comment #13. This also applies cleanly. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:18:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:18:48 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78744|0 |1 is obsolete| | Attachment #78745|0 |1 is obsolete| | Attachment #78746|0 |1 is obsolete| | Attachment #78747|0 |1 is obsolete| | Attachment #78748|0 |1 is obsolete| | Attachment #78749|0 |1 is obsolete| | Attachment #78750|0 |1 is obsolete| | Attachment #78751|0 |1 is obsolete| | Attachment #78752|0 |1 is obsolete| | Attachment #78753|0 |1 is obsolete| | Attachment #78879|0 |1 is obsolete| | Attachment #79119|0 |1 is obsolete| | --- Comment #105 from Jonathan Druart --- Created attachment 79626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79626&action=edit Bug 18887: Update database Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:18:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:18:55 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #106 from Jonathan Druart --- Created attachment 79627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79627&action=edit Bug 18887: Add Koha::CirculationRule(s) Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:18:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:18:41 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:19:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:19:01 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #107 from Jonathan Druart --- Created attachment 79628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79628&action=edit Bug 18887: Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend_Revamp_RFC This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:19:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:19:08 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #108 from Jonathan Druart --- Created attachment 79629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79629&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:19:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:19:15 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #109 from Jonathan Druart --- Created attachment 79630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79630&action=edit Bug 18887: (follow-up) Fix null/empty behavior Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:19:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:19:21 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #110 from Jonathan Druart --- Created attachment 79631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79631&action=edit Bug 18887: Fix issues caused by rebase Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:19:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:19:28 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #111 from Jonathan Druart --- Created attachment 79632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79632&action=edit Bug 18887: Fix DB structure issues - Make atomic update idempotent - Correct COLLAT (atomic update) - Add index on rule_name (kohastructure.sql) - Add rule_name to the unique constraint (kohastructure.sql) - Remove max_holds columns (kohastructure.sql) Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:19:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:19:35 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #112 from Jonathan Druart --- Created attachment 79633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79633&action=edit Bug 18887: Insert undef instead of '*' Koha::CirculationRules->get_effective_rule will become the method to call to retrieve a specific rule, we should start using it when possible. Moreover undef could replace '*' to mean 'any', that way we will be able to add FK on circulation_rules TODO: Add more tests Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:19:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:19:41 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #113 from Jonathan Druart --- Created attachment 79634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79634&action=edit Bug 18887: Use get_effective_rule instead of search Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:19:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:19:48 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #114 from Jonathan Druart --- Created attachment 79635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79635&action=edit Bug 18887: Add 2 missing html filters Signed-off-by: Lisette Scheer Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:20:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:20:00 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #115 from Jonathan Druart --- Created attachment 79636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79636&action=edit Bug 18887: Add foreign keys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:20:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:20:08 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #116 from Jonathan Druart --- Created attachment 79637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79637&action=edit Bug 18887: Add new schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:20:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:20:15 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #117 from Jonathan Druart --- Created attachment 79638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79638&action=edit Bug 18887: Update existing schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:20:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:20:23 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #118 from Jonathan Druart --- Created attachment 79639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79639&action=edit Bug 18887: Fix POD c/p issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:20:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:20:30 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #119 from Jonathan Druart --- Created attachment 79640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79640&action=edit Bug 18887: Replace croak with exceptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:20:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:20:37 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #120 from Jonathan Druart --- Created attachment 79641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79641&action=edit Bug 18887: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:24:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:24:55 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #121 from Jonathan Druart --- Several things here: 1. I have reattached the patch in the correct order and add the signed-off-by lines for Lisette and Jesse (only last patch was signed off) 2. (In reply to Josef Moravec from comment #103) > Comment on attachment 78744 [details] [review] > In the schema files I can see the foreign keys for branchcode, categorycode > and itemtype, but they aren't defined in db update nor kohastructure.sql. > But I think we want them. I have reworked the schema files (md5sum was wrong which caused the script to fail). Foreign keys have been added to both kohastructure.sql and atomic update file. 3. (In reply to Josef Moravec from comment #104) > Comment on attachment 78746 [details] [review] > > +Koha::Hold - Koha Hold object class > > C & P mistake Fixed (x2) 4. > @@ +47,5 @@ > > + my $categorycode = $params->{categorycode}; > > + my $itemtype = $params->{itemtype}; > > + my $branchcode = $params->{branchcode}; > > + > > + croak q{No rule name passed in!} unless $rule_name; > > Please use Exception instead of croak Removed and exceptions are now thrown 5. Tests have been provided, finally! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:31:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:31:47 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #41 from Jonathan Druart --- Created attachment 79643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79643&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:31:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:31:52 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #42 from Jonathan Druart --- Created attachment 79644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79644&action=edit Bug 18925: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:31:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:31:57 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #43 from Jonathan Druart --- Created attachment 79645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79645&action=edit Bug 18925: Replace logic in GetBranchBorrowerCircRule with get_effective_rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:32:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:32:01 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #44 from Jonathan Druart --- Created attachment 79646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79646&action=edit Bug 18925: Update schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:31:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:31:42 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78881|0 |1 is obsolete| | Attachment #78882|0 |1 is obsolete| | Attachment #78883|0 |1 is obsolete| | Attachment #78884|0 |1 is obsolete| | Attachment #78885|0 |1 is obsolete| | Attachment #78886|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 79642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79642&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 23:32:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2018 21:32:29 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #45 from Jonathan Druart --- Rebased on top of new patches submitted on bug 18887. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:00:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:00:02 +0000 Subject: [Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78008|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:00:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:00:26 +0000 Subject: [Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78010|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:00:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:00:59 +0000 Subject: [Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sysprefs to enable the |Change default behavior to |opening of OPAC cart in one |open OPAC cart in one click |click | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:01:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:01:34 +0000 Subject: [Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #19 from Alex Buckley --- Created attachment 79647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79647&action=edit Bug 21174 - Open the OPAC cart with one click by default Feedback from the Koha mailing list in Aug 2018 showed there was widespread concensus for making the default behaviour of the OPAC cart to be to open with one click, rather than clicking on the cart icon then on the dropdown box to load the cart popup. This commit is a combination of Owen Leonard's alternative patch (slightly changing the markup in masthead.inc) and my work to remove the dropdown elements from the template and basket.js Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, and plack 6. Click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 7. Confirm the items in your cart are displayed by the cart popup 8. Confirm you can remove items from/empty the cart, and that as you do this the number of cart items shown by the number to the right of the cart icon changes accordingly Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:05:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:05:23 +0000 Subject: [Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart in one click In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #20 from Alex Buckley --- (In reply to Katrin Fischer in comment 18): Thanks for the reminder Katrin! Apologies for the display. I have attached a patch making clicking on the OPAC cart icon once to load the cart popup the default behavior (no syspref), with also incorporates Owen's work from his alternative patch. Please test, as you say it would be great to get this into master :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:14:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:14:40 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #17 from Julian Maurice --- Created attachment 79648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79648&action=edit Bug 20582: Fix memory cache flush Cache flush should be in around_action hook instead of before_dispatch Otherwise it is flushed before every request (even static files requests) Also, make sure the Cache::Memory cache is really flushed (not only L1 cache) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:32:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:32:09 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #14 from Alex Buckley --- Created attachment 79649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79649&action=edit Bug 15529 - Wrapping email sending up in the verbose flag Thus the cron email telling the administrator or support company that a second execution of the process_message_queue.pl cron whilst it is already running is only sent if it is wanted and verbose is set. Sponsored-By: New Zealand Parliamentary Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:37:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:37:14 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #15 from Alex Buckley --- (In response to M. Tompsett in comment 13): >If another process is running, why not queue this as a message, rather than add another layer of emailing ugliness? Thanks for your feedback M. Tompsett. I had a conversation about this with Liz Rea and we came to the conclusion that the benefit of sending it immediately rather than enqueuing the email is because the administrator (or support company) knows straight away and can go and troubleshoot. My latest patch addition wraps the sending of the email up in the verbose flag so the email is only sent if you want it to be, by default it will not be sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:37:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:37:03 +0000 Subject: [Koha-bugs] [Bug 21455] New: Authority search options get shuffled around when you click on 'Search' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Bug ID: 21455 Summary: Authority search options get shuffled around when you click on 'Search' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: arouss1980 at gmail.com QA Contact: testopia at bugs.koha-community.org As per the attached screenshots, when you perform an authority search in the staff client and click on the 'Search' button, the selected values for the 'Search all headings:' and 'Search entire record:' options get flipped around. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:37:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:37:56 +0000 Subject: [Koha-bugs] [Bug 21455] Authority search options get shuffled around when you click on 'Search' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |arouss1980 at gmail.com |ity.org | --- Comment #1 from Andreas Roussos --- Created attachment 79650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79650&action=edit Authority search window before clicking on 'Search' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:38:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:38:31 +0000 Subject: [Koha-bugs] [Bug 21455] Authority search options get shuffled around when you click on 'Search' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 --- Comment #2 from Andreas Roussos --- Created attachment 79651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79651&action=edit Authority search window after clicking on 'Search' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:44:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:44:44 +0000 Subject: [Koha-bugs] [Bug 21455] Authority search options get shuffled around when you click on 'Search' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 --- Comment #3 from Andreas Roussos --- Created attachment 79652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79652&action=edit Bug 21455: Authority search options get shuffled around when you click on 'Search' In the staff client, when you perform an authority search the selected values for the 'Search all headings:' and 'Search entire record:' options get shuffled around when you click on the 'Search' button. This patch fixes that. Test plan: 1) Perform an authority search and set the 'Search all headings:' option to 'starts with'. 2) Click on the 'Search' button. 3) Notice how the 'Search all headings:' option is now 'contains', and 'starts with' has moved down to the 'Search entire record:' option. 4) Apply the patch. 5) Hit 'Search' again. This time the selected search options do not move around. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:49:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:49:26 +0000 Subject: [Koha-bugs] [Bug 21455] Authority search options get shuffled around when you click on 'Search' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21455 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Priority|P5 - low |P3 Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:51:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:51:16 +0000 Subject: [Koha-bugs] [Bug 21440] koha-create expects the file passed by $DEFAULTSQL to be in gzip format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21440 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 11:59:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 09:59:41 +0000 Subject: [Koha-bugs] [Bug 21456] New: The 'New authority' button lists authority types inconsistently Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Bug ID: 21456 Summary: The 'New authority' button lists authority types inconsistently Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: arouss1980 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com As per the attached staff client screenshots, in Home > Authorities (authorities-home.pl), the button 'New authority' lists the available authority types in alphabetical order based on their _description_. The same button in an authority's detail view (detail.pl) lists auth types in alphabetical order based on their _code_. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 12:01:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 10:01:58 +0000 Subject: [Koha-bugs] [Bug 21456] The 'New authority' button lists authority types inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |arouss1980 at gmail.com |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Andreas Roussos --- Created attachment 79653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79653&action=edit Authority types sorted by description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 12:02:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 10:02:19 +0000 Subject: [Koha-bugs] [Bug 21456] The 'New authority' button lists authority types inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 --- Comment #2 from Andreas Roussos --- Created attachment 79654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79654&action=edit Authority types sorted by code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 12:10:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 10:10:23 +0000 Subject: [Koha-bugs] [Bug 21456] The 'New authority' button lists authority types inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 --- Comment #3 from Andreas Roussos --- Created attachment 79655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79655&action=edit Bug 21456: The 'New authority' button lists authority types inconsistently The 'New authority' button does not always list the available authority types in A-Z order based on their description. This patch fixes that. Test plan: 1) Go to Home > Authorities in the staff client; notice how the 'New authority' button lists auth types sorted by description. 2) Go to an authority's detail page; notice how the same 'New authority' button will list auth types sorted by their code. 3) Apply the patch. 4) In an authority's detail page, the 'New authority' button will now list the available authority types sorted by description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 12:11:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 10:11:01 +0000 Subject: [Koha-bugs] [Bug 21456] The 'New authority' button lists authority types inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Priority|P5 - low |P3 Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 13:58:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 11:58:45 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #60 from Katrin Fischer --- Hi Caroline, I can't reproduce the error - can you try again with another course reserve? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 14:02:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 12:02:35 +0000 Subject: [Koha-bugs] [Bug 14786] Use text "MARC file" instead of "ISO2709" everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 14:02:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 12:02:39 +0000 Subject: [Koha-bugs] [Bug 14786] Use text "MARC file" instead of "ISO2709" everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79552|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 79656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79656&action=edit Bug 14786: Use MARC istead of ISO2709 everywhere This patch changes the term ISO2709 in the templates to use MARC instead. Test plan: - The term was changed on the following pages in staff: - Advanced catalouging editor > Save to catalog - Patron account > Check out (Activate ExportCircHistory) > Format - Patron account > Check out > Help page - Lists > Download list - Acquisitions > Add order to basket > From a staged file (breadcrumbs) - Administration > System preferences > ExportRemoveFields - Cart > Download - Tools > Export data > Output format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 14:03:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 12:03:20 +0000 Subject: [Koha-bugs] [Bug 14786] Use text "MARC file" instead of "ISO2709" everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786 --- Comment #6 from Katrin Fischer --- A little embarassing that I forgot to run the tests, was only 2 pre-existing tabs to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 14:04:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 12:04:56 +0000 Subject: [Koha-bugs] [Bug 14786] Use text "MARC file" instead of "ISO2709" everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79656|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 79657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79657&action=edit Bug 14786: Use MARC istead of ISO2709 everywhere This patch changes the term ISO2709 in the templates to use MARC instead. Test plan: - The term was changed on the following pages in staff: - Advanced catalouging editor > Save to catalog - Patron account > Check out (Activate ExportCircHistory) > Format - Patron account > Check out > Help page - Lists > Download list - Acquisitions > Add order to basket > From a staged file (breadcrumbs) - Administration > System preferences > ExportRemoveFields - Cart > Download - Tools > Export data > Output format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 14:07:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 12:07:13 +0000 Subject: [Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 14:07:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 12:07:18 +0000 Subject: [Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79606|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 79658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79658&action=edit Bug 20450: (follow-up) Add missing template filters This patch adds two missing template filters as pointed out by the template test. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 14:07:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 12:07:35 +0000 Subject: [Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 --- Comment #16 from Katrin Fischer --- Thank you for the follow-up, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 14:14:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 12:14:03 +0000 Subject: [Koha-bugs] [Bug 21447] Inventory lists incorrectly sorted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447 --- Comment #3 from Katrin Fischer --- I think we have foregone the Zebra updates - but we will update them soon anyway which will include a full reindex. Another thing to check: Is cn_source set correctly in all items? It's easy to have some bad configuration there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 14:16:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 12:16:19 +0000 Subject: [Koha-bugs] [Bug 21452] Items available for hold or loan must have an item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- If the problem is acq items, maybe setting the itemtype not-mandatory for the ACQ framework but mandatory for every other would work? There is a lot more things that influence if an item can be checked out, not only the not-for-loan status. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 14:39:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 12:39:02 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #16 from M. Tompsett --- Then why not trigger the process_messages.pl immediately after queuing? Adding more libraries is still very ugly. my $return = qx{echo "foobar"}; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 19:12:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 17:12:22 +0000 Subject: [Koha-bugs] [Bug 9188] Remove 'debug' information from patron statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch --- Comment #11 from Andreas Roussos --- (In reply to M. Tompsett from comment #9) > If you believe the counter patch is good, obsolete the first patch and sign > off the second. If you believe there is need for more discussion, discuss > away. Do not apply both patches, just one or the other. Please accept my apologies for taking so long to reply. Thank you for providing a counter patch, I've had a look at it and it's good, definitely a better approach than mine ;-) Interestingly, it still applies to the current master after all this time without any need for rebasing. I'm going to sign it off and obsolete mine. Also, as per the patch submitting guidelines in the wiki, I'm raising the patch complexity from trivial to small. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 19:14:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 17:14:40 +0000 Subject: [Koha-bugs] [Bug 9188] Remove 'debug' information from patron statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55625|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 19:22:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 17:22:05 +0000 Subject: [Koha-bugs] [Bug 9188] Remove 'debug' information from patron statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64087|0 |1 is obsolete| | --- Comment #12 from Andreas Roussos --- Created attachment 79659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79659&action=edit Bug 9188: counter patch -- just meaningful filter information TEST PLAN --------- run patron statistics without filtering -- notice lots of text at top. run patron statistics with filtering -- notice lots of text at top. apply patch run it without and without filtering -- amount of text should be small or none and be related to the filtering selected. run koha qa test tools Signed-off-by: Andreas Roussos Works as expected, i.e. only filtering information is displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 19:26:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 17:26:04 +0000 Subject: [Koha-bugs] [Bug 9188] Remove 'debug' information from patron statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 19:41:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 17:41:00 +0000 Subject: [Koha-bugs] [Bug 9188] Remove 'debug' information from patron statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Andreas Roussos --- Sorry, I've set the wrong status after signing off Mark's patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 20:33:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 18:33:56 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 21:10:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 19:10:46 +0000 Subject: [Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 --- Comment #6 from Andreas Roussos --- (In reply to Jonathan Druart from comment #3) > I am wondering if this is the right fix, I guess we should handle the "no" > value instead. Fine with me :-) FWIW my interpretation of the changes and comments in Bug 18342 was that it would no longer be possible to create an install without memcached, and I based my patch on that. I'll obsolete it now. (In reply to Jonathan Druart from comment #5) > What about this alternative patch? Looks OK overall; is the echo bit above the if statement intentional? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 21:11:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 19:11:48 +0000 Subject: [Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79603|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 22:20:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 20:20:02 +0000 Subject: [Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 22:20:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 20:20:07 +0000 Subject: [Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79617|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 79660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79660&action=edit Bug 21426: Handle USE_MEMCACHED=no in koha-create -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 22:21:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 20:21:03 +0000 Subject: [Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in koha-sites.conf does not have any effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426 --- Comment #8 from Jonathan Druart --- (In reply to Andreas Roussos from comment #6) > (In reply to Jonathan Druart from comment #5) > > What about this alternative patch? > Looks OK overall; is the echo bit above the if statement intentional? Of course no, I amended the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 23:44:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 21:44:02 +0000 Subject: [Koha-bugs] [Bug 21385] Vendor search: Item count is incorrectly updated on partial receive. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart --- (In reply to Caroline Cyr La Rose from comment #14) > Item count stays the same. You changed the status to "Signed Off", I guess it was not expected :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 23:56:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 21:56:55 +0000 Subject: [Koha-bugs] [Bug 21456] The 'New authority' button lists authority types inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 23:56:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2018 21:56:59 +0000 Subject: [Koha-bugs] [Bug 21456] The 'New authority' button lists authority types inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21456 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79655|0 |1 is obsolete| | --- Comment #4 from Michal Denar --- Created attachment 79661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79661&action=edit Bug 21456: The 'New authority' button lists authority types inconsistently The 'New authority' button does not always list the available authority types in A-Z order based on their description. This patch fixes that. Test plan: 1) Go to Home > Authorities in the staff client; notice how the 'New authority' button lists auth types sorted by description. 2) Go to an authority's detail page; notice how the same 'New authority' button will list auth types sorted by their code. 3) Apply the patch. 4) In an authority's detail page, the 'New authority' button will now list the available authority types sorted by description. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes.