[Koha-bugs] [Bug 21036] Fix a bunch of older warnings

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 76702
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76702
Bug 21036: Fix warnings from C4/Biblio

Review of attachment 76702:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21036&attachment=76702)
-----------------------------------------------------------------

::: C4/Biblio.pm
@@ +2324,4 @@
>          if ( ( @$tags[$i] ne $prevtag ) ) {
>              $close_last_tag = 0;
>              $j++ unless ( @$tags[$i] eq "" );
> +            my $str = ( $indicator->[$j] // q{} ) . ' '; # extra space prevents substr outside of string warn

Shouldn't this be two spaces? just because substr(' ',1,1) doesn't explode,
doesn't mean you shouldn't hand it a nice string.

-- 
You are receiving this mail because:
You are watching all bug changes.