[Koha-bugs] [Bug 18229] update_dbix_class_files.pl loads defaults from ~/.my.cnf

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Sep 13 11:38:59 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18229

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #4)
> Actually I already wrote such a patch, but when I say Galen's patch I did
> not submit mine.
> 
> I think this could be re-discussed.

Hmm.. I also wrote a similar patch (in bug 21177). We are at least 3 developers
annoyed enough to have written a patch to change that.
I think the reasoning behind this "roadblock" is not valid. Developers are lazy
by definition, and if they are annoyed or frustrated by this they will quickly
write a custom script to read $KOHA_CONF (or my.cnf) and call
update_dbix_class_files.pl with the correct parameters (like this one:
https://gitlab.com/snippets/1753594)
Anyway the real danger is for people that push these modifications (RM and
RMaint), and I think they know what they're doing.

Now, about this particular bug, I think reading .my.cnf will not be useful for
everyone. I, for instance, have several instances of Koha on the same host, and
.my.cnf references my primary koha database. So if I'm working on another
instance and forget to set --db_name, the script will update my local schema
based on another database.
So reading $KOHA_CONF would be better in my case.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list