[Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #141 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
(In reply to Martin Renvoize from comment #139)
> I'm afraid I agree with marcelr, I don't really like that one can enter one
> thing and when it's displayed later see a different thing due to the
> distinct preferences.

Unfortunately the only simple solution might be to keep them separated (but one
should configure them coherently!) because it's a requirement to be able to use
multiple separators in the same instance.

During the last hackfest (march in Marseille) after talking to enough devs and
librarians, I couldn't not put that in the requirements :(


> I also can't help but feel like there's a better way out there, input
> masking or something?

That's not compatible with pasting values [1]

And also we might prefer focusing on getting rid of x100 or /100 of the amounts
+ decimal part truncation.
It might not be possible in a reasonable time put up a great UX + handle most
cases at the same time.
That might be better to refine out decimal number handling in various steps.
Considering how complicated the problem is and that a perfect solution will
take years to get enough resources and get into master.


[1] The cases could be in acquisition when copying from another software, an
invoice email, a PDF.
Or maybe from somewhere else in Koha? I'm not sure about that use case.


> Finally, there's a lot of test cases here, if we did push this I'd really
> like to see some tests added to ensure we don't end up with a regression.

You having a Selenium test that go to one field and try a part of the cases of
the test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.