[Koha-bugs] [Bug 10869] can't delete order line if title deleted

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26692|0                           |1
        is obsolete|                            |

--- Comment #83 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 78862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78862&action=edit
Bug 10869: Allow the deletion of order line if the record is deleted

This patch fixes 2 issues :
(medium issue) It is not possible to delete an order in a basket if the biblio
record is deleted.
(minor issue) There is a useless hyperlink around "Deleted bibliographic
notice", and "notice" is a frenchism for "record"

Biblionumber was passed to the function as 1st parameter, which made impossible
to suppress an order whose associated biblio record was suppressed.
Moreover, the biblionumber is not needed to get and suppress the order, but
only to suppress items, in a second step.

Change made to Acquisitions::DelOrder:
- I changed the order of the 2 parameters: now $ordernumber as 1st parameter
and $biblionumber as 2d parameter
- I renamed $bibnum to $biblionumber
- I removed $biblionumber from the main SQL query of the function
- I suppressed useless $sth->finish
- if no $biblionumber is provided, Koha does not try to suppress the items
linked created by acq process

Change made to the calls to Acquisitions::DelOrder in Koha's code, to change
the order of the parameters
- in addorder.pl
- in basket.pl
- in UT t/db_dependant/Acquisition.t

Change made in template basket.tt.

This bug was signed off by Cedric some time ago, but it needs a second sign
off, because I had to made some little changes.

To test :
1. Fill a basket with some records (some records with items or holds, some
without items)
2. Supress one of the record
3. In the basket (refresh the screen) check that "Deleted bibliographic notice"
line was replaced with "Deleted bibliographic record", without hyperlink
arround
4. Delete this order with the link "Delete order" to the right column of the
table
5. Check there is a new line in the "Deleted orders" table
6. Check there is no regression : delete an other order (one with no item),
then check you cannot delete an order with an item (like before patch)

Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.