[Koha-bugs] [Bug 21215] Saved SQL reports code improvements

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77781|0                           |1
        is obsolete|                            |

--- Comment #3 from Michal Denar <black23 at gmail.com> ---
Created attachment 79060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79060&action=edit
Bug 21215: Saved SQL reports code improvements

The saved SQL reports code is a bit warty, so improve it:

Instead of using the same code in multiple places to split the SQL
move that code into the Guided.pm module.

Add several tests for parameter substitution and SQL validation.

Make it much easier to add more parameter types for substitution.

Test plan:

1) Run your saved SQL reports and check that they work correctly
2) Create new SQL reports and check that the parameters are queried
   correctly.
3) Prove the t/db_dependent/Reports/Guided.t

Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Signed-off-by:  Michal Denar <black23 at gmail.coml>

-- 
You are receiving this mail because:
You are watching all bug changes.