[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #163 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Alex Arnaud from comment #143)
> Comment on attachment 72574 [details] [review]
> Bug 18606: Database changes - Add foreign keys to collections_tracking
> 
> Review of attachment 72574 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: installer/data/mysql/kohastructure.sql
> @@ +969,5 @@
> > +  PRIMARY KEY (collections_tracking_id)
> > +) ENGINE=InnoDB  DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
> > +
> > +ALTER TABLE `collections_tracking`
> > +  ADD CONSTRAINT `collections_tracking_ibfk_1` FOREIGN KEY (`colId`) REFERENCES `collections` (`colId`) ON DELETE CASCADE ON UPDATE CASCADE;
> 
> Why did add constraints separatly from the table creation? It seems to me
> that it is less readable for people wanting to quickly get the structure of
> the table.

No strong reason from me, fixed in follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.