[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

--- Comment #50 from Josef Moravec <josef.moravec at gmail.com> ---
I started to testing 21393 with this one, so my QA tools are on steroids now ;)

Few comments
1) Missing filters:

FAIL    koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
   FAIL   filters
                missing_filter at line 26 (                        <option
value="[% header.cell %]">[% header.cell %]</option>)
                missing_filter at line 46 (                            <a
class="chart-column-delete" href="#" data-column="[% column %]">)
                missing_filter at line 72 (                                    
   <option value="[% i %]">[% i %]</option>)
                missing_filter at line 47 (                                <img
src="[% interface %]/[% theme %]/img/x.png" alt="Delete" />)
                missing_filter at line 24 (                    <option
value="[% supposed_x %]" selected>[% supposed_x %]</option>)
                missing_filter at line 70 (                                    
   <option value="[% i %]" selected>[% i %]</option>)
                missing_filter at line 56 (                                    
   <option value="[% h.cell %]" selected>[% h.cell %]</option>)
                missing_filter at line 52 (                            <select
id="y_[% column %]" name="y">)
                missing_filter at line 58 (                                    
   <option value="[% h.cell %]">[% h.cell %]</option>)
                missing_filter at line 43 (                    <fieldset
class="chart-column-conf" id="column_[% column %]" style="display: inline
!important;">)
                missing_filter at line 66 (                            <label
for="group_[% column %]">Group:</label>)
                missing_filter at line 81 (                            <input
class="column-line" id="column-line" name="[% header.cell %]" type="checkbox">)
                missing_filter at line 67 (                            <select
id="group_[% column %]" name="group">)
                missing_filter at line 45 (                            Column
[% column %])
                missing_filter at line 94 (    [% header_row.unshift(item) %])
                missing_filter at line 51 (                            <label
for="y_[% column %]" >y:</label>)
                missing_filter at line 80 (                            <label
for="line_[% column %]">line:</label>)
                missing_filter at line 53 (                               
<option value="[% supposed_x %]" selected>[% supposed_x %]</option>)

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
   FAIL   filters
                missing_filter at line 1108 (                   
$('#chart').prepend('<div style="font-size: 1rem; text-align: center;">' + "[%
name %]" + '</div>');)
                missing_filter at line 1058 (                        results =
[% results.json %])
                missing_filter at line 1055 (                        results =
[% allresults.json %])
                missing_filter at line 1051 (                    headers = [%
header_row.json %];)

2) Could you please split the patch? At least staff-global.css should not be in
main patch, as it is generated by RM and here should be only for ease the
testing.

-- 
You are receiving this mail because:
You are watching all bug changes.