[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, 

1) some complaints from the QA script:

 FAIL   installer/data/mysql/atomicupdate/bug_14715-searchresults_syspref.sql
   FAIL   git manipulation
                The file has been added and deleted in the same patchset

 FAIL  
installer/data/mysql/atomicupdate/bug_14715_-_results_per_page_dropdown_sysprefs.sql
   OK     git manipulation
   FAIL   semicolon
                simicolon found instead of comma at line 3
   FAIL   sysprefs_order
                Not blocker: Sysprefs numSearchResultsDropdown is bad placed
(see bug 10610)

It appears the change to sysprefs.sql is missing?

2) I think I would just remove the display of 'library default' in the OPAC and
staff. I think we don't need the extra entry in the pull down and it's more
confusing as the difference between Library default:20 and 20 is not clear.

3) It appears to break when Elasticsearch is activated in a non-good way.
Switching the number of results made the OPAC load forever for me showing a
white page. Then it started to work, but the number of pages doesn't change.
Can you please check? If we can't make this work, we should at least add a note
to the pref and keep it from showing up with Elasticsearch active. 

Note for later:
New cookie needs to be documented in the wiki, once this has been pushed:
https://wiki.koha-community.org/wiki/Use_of_Cookies

-- 
You are receiving this mail because:
You are watching all bug changes.