[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #72 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
> > Why only changes to the ...style-us and not the other templates?
> 
> If I look at it chronologically, this patch was first submitted at a time
> when no {de,fr} templates existed. Commits for these templates came in 2015
> and 2017, and I couldn't say when they were added to the master. It's no
> excuse for not reworking the patch, if that's what QA needs, but at least
> there's a rationale: it was rebased over and over without extending what had
> been done.

I see the follow-up doesn't contain changes to the other address format files
still, could you please check?

> > What has this to do with making it possible for adults to be guarantors? ;)
> 
> That looks like a prime candidate for an optional patch, I concede. But some
> of the 'extra' developments in this patch were naturally asked by our
> clients when we offered linking adults to adults. I do think there are
> merits to keeping these functionalities together (though perhaps not as far
> as keeping the example you quoted).

I understand that it happens, my main point is documentation. By slipping in
features into bugs without documenting them at least in the commit message,
they often get lost and end up undocumented, especially when they don't fit the
bugs description which is often all people look at in release notes.

I hope to see this signed off soon!

-- 
You are receiving this mail because:
You are watching all bug changes.