[Koha-bugs] [Bug 21427] Format prices on ordered/spent lists

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Copying across Jonathans issue with this implimentation:

(Jonathan Druart from comment #5)
> I would not format the prices in the same patch/bug report, I am expecting
> regressions here: sum of round numbers (sprintf %.2f) vs round of sum (if it
> makes sense...)

(Jonathan Druart from comment #7)
> use Modern::Perl;
> my $x = 12.344;
> my $y = 67.213;
> say sprintf("%.2f", $x)+sprintf("%.2f", $y);
> say sprintf("%.2f", $x+$y);'
> 
> 79.55
> 79.56

(Martin Renvoize from comment #8)
> Man that's upsetting, but I have to agree with Jonathan here..  the totals
> shouldn't really be calculated in this script in my opinion.  But because
> they are, we can't make this change here.
> 
> Could we perhaps split into two bugs please Katrin?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.