[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I am requesting another signoff here.
The third patch has no signoff line yet.
And additionally please tell me explicitly what you tested! 

I have been looking more carefully at CourseReserves.pm and I am not really
impressed by what I saw unfortunately. I have the impression that this patch
set might improve things a bit, but I am not sure if we break something else
now.

Saw tricky things like:
push( @values, $params{$_} || undef );
Together with constructions like:
     foreach (@FIELDS) {
        if ( defined($params{$_}) ) {
            push( @fields_to_update, $_ );
            push( @values_to_update, $params{$_} );
        }
    }
ModCourseItem adds an course item without affecting items or updates it and
does affect items. EnableOrDisable etc. etc.
The way we handle the data between items and course items is unclear. Including
handling empty string and null values.

I am not unwilling to pass QA after another signoff but the traffic lights will
not be green :)

-- 
You are receiving this mail because:
You are watching all bug changes.