[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #18 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
I've dug into this some more. The additional weight appears to be due to
exactly what you observed. This is due to us now returning all metadata
associated with a request rather than just a subset defined by the relevant
backend. For example, prior to these patches, the metadata was populated via
(for example, with the BLDSS backend):

https://github.com/PTFS-Europe/koha-ill-bldss/blob/master/Base.pm#L244-L293

With this bug, it's populated by:

https://github.com/PTFS-Europe/koha/blob/bug_20996/Koha/REST/V1/Illrequests.pm#L126-L136

which gets *all* metadata regardless of the backend.

Whether this is a good idea or not is up for debate I guess. Any calls on a
request object's 'metadata' method will still use the backend's metadata method
to return the curated metadata from the backend. Dunno what the best thing to
do is really..

Anyway, putting the response weight aside, this all now appears to be working
as designed, so I'm going to change the status back to "Needs Signoff"

-- 
You are receiving this mail because:
You are watching all bug changes.