[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 28 14:43:25 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996

--- Comment #21 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
OK, I know what it is. In the FreeForm backend's metadata method (and, I
presume, your backend's metadata method), there is this line:

https://github.com/PTFS-Europe/koha-ill-freeform/blob/master/Base.pm#L124

Which, as you can see, title cases the name of the property (Author etc), which
breaks the JS when we use the alternative method of getting our metadata, which
doesn't title case it. I've no idea why the properties are title cased, but it
seems to have been the case since day 1.

I'm going to fix it by changing what the JS expects from "metadata_Author" to
"metadata_author", same for title, and leave it at that. This whole issue is
made irrelevant by bug 21063 which changes how the datatable JS works anyway
and has no expectation of column names from the API.

I'll attach a patch momentarily.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list