[Koha-bugs] [Bug 11897] Stock Rotation for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #299 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The patches don't apply right now. Some remarks while I keep trying:
- For table names I usually follow the 'table names conventions'[1], which I'm
surprised are not on the Coding guidelines
- CHARSET and COLLATE shoul dbe utf8mb4 and utf8mb4_unicode_ci respectively
- I would use a perl atomicupdate (based on skeleton.perl) instead. VERY MINOR

[1]
https://wiki.koha-community.org/wiki/Koha_Objects#Database_Table_Conventions
[2] https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans

-- 
You are receiving this mail because:
You are watching all bug changes.