[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kyle at bywatersolutions.com   |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #121 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Several things here:

1. I have reattached the patch in the correct order and add the signed-off-by
lines for Lisette and Jesse (only last patch was signed off)

2. (In reply to Josef Moravec from comment #103)
> Comment on attachment 78744 [details] [review]
> In the schema files I can see the foreign keys for branchcode, categorycode
> and itemtype, but they aren't defined in db update nor kohastructure.sql.
> But I think we want them.

I have reworked the schema files (md5sum was wrong which caused the script to
fail). Foreign keys have been added to both kohastructure.sql and atomic update
file.

3. 
(In reply to Josef Moravec from comment #104)
> Comment on attachment 78746 [details] [review]
> > +Koha::Hold - Koha Hold object class
> 
> C & P mistake

Fixed (x2)

4.
> @@ +47,5 @@
> > +    my $categorycode = $params->{categorycode};
> > +    my $itemtype     = $params->{itemtype};
> > +    my $branchcode   = $params->{branchcode};
> > +
> > +    croak q{No rule name passed in!} unless $rule_name;
> 
> Please use Exception instead of croak

Removed and exceptions are now thrown

5. Tests have been provided, finally!

-- 
You are receiving this mail because:
You are watching all bug changes.