From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 01:54:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 23:54:42 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #85 from David Cook --- Comment on attachment 86002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86002 Bug 20664: Optimize retrieval of biblio and item data Review of attachment 86002: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20664&attachment=86002) ----------------------------------------------------------------- ::: C4/Items.pm @@ +1357,5 @@ > + my $item_level_itype = C4::Context->preference('item-level_itypes'); > + # This is so much faster than using Koha::Items->search that it makes sense even if it's ugly. > + my $query = 'SELECT * FROM items WHERE biblionumber = ?'; > + if (@$itemnumbers) { > + $query .= ' AND itemnumber IN (' . join(',', @$itemnumbers) . ')'; This should be adding ? placeholders and binding the itemnumbers before executing. While it would probably be rare, a malformed record could cause SQL errors here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 02:00:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 00:00:50 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #86 from David Cook --- (In reply to Marcel de Rooy from comment #84) > + # This is so much faster than using Koha::Items->search that it makes > sense even if it's ugly. > + my $query = 'SELECT * FROM items WHERE biblionumber = ?'; > > Patch still applies. > If I am reading thru the comments above, the main point of discussion is > now: Do we want to return to raw sql in the above lines? It is rather > obvious that this is faster than Koha::Object/DBIx. But we made a choice for > DBIx and are still wrestling to implement it in the codebase. What would be > the decisive reason for making the exception here, and would it be a > precedent for doing similar things elsewhere? Also note that although the > test plan refers to verifying that things are faster, I do not see any > benchmark figures on the report. > > Moving to discussion and sending mail to QA. I'd say the decisive reason would be that the low-performance of DBIx::Class adds up when doing batch operations. While low-performance and high convenience might be tolerable for many single requests, if you're dealing with high volumes of data, it's a nightmare. Even fractions of a second per record can add up to unacceptably slow amounts of time. I've used raw SQL at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662#c221 for the same reason. I wish I had included benchmarks on that bug, but with the raw SQL and re-using the statement handle, I was able to process much higher volumes. I think it was like 100 records per second instead of 4 records per second. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 02:04:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 00:04:55 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #33 from David Cook --- (In reply to Bj?rn Nyl?n from comment #31) > From our perspective Davids patch is the logical way it should function. > Don't do anything until it's time to renew. > > However it does change the behaviour and I guess some libraries might like > to keep sending early notices if no further renewal will be possible. > Perhaps it's possible to control it with a command line option (eg > '--early-notice') to skip the no-renwal-before check?(with the risk of > asking for a more complex solution) Oh that's a good point. In fact, locally, I have wrapped it in a system preference, so that it only applies to one instance of Koha. With Koha, when changing things, we typically make the new behaviour opt-in, so we'd either want to use a system preference or a command line option like "--no-early-notices" or something like that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 02:10:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 00:10:46 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #34 from David Cook --- (In reply to Ray Delahunty from comment #32) > (In reply to Andrew from comment #26) > > Are we focussing too much on manipulating when the auto-renewal takes place > as being the driver of limiting how many people receive renewal-failure > emails? I think we need a better driver. Auto-renewing an item earlier than > the moment it is due back penalises other users who may want the item. No it doesn't. Other users can place a hold on the item. > If it > has already auto-renewed (early) and they place a reservation / hold on it, > they will have to wait longer for it. The same thing could be achieved by a person manually renewing it. I don't see how this is relevant? > That is why we have opted for the > (admittedly harsh) situation where we only warn users that items have failed > auto-renewal when they are overdue. (We use a No Renewal Before value set to > zero, but we do use a long grace period.) > I think this is what most people do with Koha at the moment. > We have multiple copies of the same item (with various loan periods) out on > loan. If a reservation is placed we want to send renewal-failure > notification only to users whose copy is due ?soon?, and not to people who > have, say, just taken a long-term loan copy out. Native Koha auto-renewal > functionality currently sees every holder of the item emailed. But the > first copy returned satisfies the reservation. Why pester everyone- we want > to better target the email. > Fair enough although I think that's a separate issue to this one. > In comment 26 Andrew mentions what I think could be the ideal solution- a No > Notice Before parameter. Rather than this being a system preference I see it > better as an additional column in the Circulation & Fine rules. This would > be configurable line by line (user category / item type) and allow the Koha > library to email as many or as few current holders of the non-renewed items > as they wished. Libraries that wanted to be more lenient that us could > increase the No Renewal Before to 1, 2, or 3, say, but it would be the wise > choice of a No Notice Before value that would be the best driver in > targeting users whose items are likely to fulfil the reservation / hold. I'm not interested in this idea, but you are free to pursue that idea by yourself or pay someone else to pursue it. I've provided my alternate patch as it's how me and my clients think the auto-renewal should work, and we've already implemented it locally and are satisfied with that. I've uploaded it here as I think other people would benefit from it as well. That's the limit to my contribution on this particular bug report though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 07:06:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 05:06:33 +0000 Subject: [Koha-bugs] [Bug 21648] Patron Merge needs more flexibility and transparency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Carlos Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clopez at dml.vic.edu.au --- Comment #1 from Carlos Lopez --- Verified: When we've merged borrower records we've found that the resulting record contains multiple patron attributes (even when these are set as not repeatable). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 07:42:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 05:42:29 +0000 Subject: [Koha-bugs] [Bug 22612] New: opac-auth.tt should contain OpacLoginInstructions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22612 Bug ID: 22612 Summary: opac-auth.tt should contain OpacLoginInstructions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Good morning I think that opac-auth.tt should also include [% IF Koha.Preference( 'OpacLoginInstructions' ) %]
[% Koha.Preference( 'OpacLoginInstructions' ) %]
[% END %] This add login instrucctions, it appears for example in opac-main.tt or masthed.inc but on opac-auth.tt there is no login instructions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 09:31:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 07:31:46 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 --- Comment #5 from Ere Maijala --- Frank, sorry, I'm not following. Can you explain with a bit more detail? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 09:38:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 07:38:47 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #96 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #95) > QA Script is complaining.. though I'm not entirely sure what it means: > > FAIL Koha/Patron.pm > FAIL valid > Constant subroutine Koha::Patron::ADMINISTRATIVE_LOCKOUT > redefined > > > Any thoughts? Look at Koha/Patron.pm without these patches. And run perl -cw You will see lots of redefines warnings due to some circular inheritance issue there. The new constant suffers from this problem too. So this is a false negative. Back to SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 09:47:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 07:47:25 +0000 Subject: [Koha-bugs] [Bug 21712] Report anonymized patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21712 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Marcel de Rooy --- 21336 is moving again, so i am coming back here soon hopefully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:08:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:08:51 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|mail at jkozlovsky.cz |josef.moravec at gmail.com URL| |https://wiki.koha-community | |.org/wiki/Checkouts_endpoin | |t_RFC#Update_-_Circulation_ | |history_aka_old_checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:17:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:17:52 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86677|0 |1 is obsolete| | --- Comment #69 from Ere Maijala --- Created attachment 87248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87248&action=edit Bug 11529: Add new fields to biblio table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:17:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:17:57 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86678|0 |1 is obsolete| | --- Comment #70 from Ere Maijala --- Created attachment 87249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87249&action=edit Bug 11529: Use new biblio fields whenever possible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:18:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:18:02 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86679|0 |1 is obsolete| | --- Comment #71 from Ere Maijala --- Created attachment 87250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87250&action=edit Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:18:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:18:07 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86680|0 |1 is obsolete| | --- Comment #72 from Ere Maijala --- Created attachment 87251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87251&action=edit Bug 11529: Clean up subtitle usage Unify and clean up subtitle usage so that it's always used as a simple array and not the old hash structure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:18:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:18:12 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86681|0 |1 is obsolete| | --- Comment #73 from Ere Maijala --- Created attachment 87252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87252&action=edit Bug 11529: Remove field mapping table and admin page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:18:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:18:16 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86682|0 |1 is obsolete| | --- Comment #74 from Ere Maijala --- Created attachment 87253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87253&action=edit Bug 11529: DBIx schema changes Updates to Biblio schema and removal of FieldMapping schema. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:20:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:20:15 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #75 from Ere Maijala --- Thanks Michal. Both issues should now be fixed. The displaying of null happened if part_number and part_name in database were null, which is possible if there's no mapping for them or the batch rebuild has not been run. Now the service guards against that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:25:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:25:34 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #21 from Josef Moravec --- Created attachment 87254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87254&action=edit Bug 17005: Add checked_in checkouts to REST API response This patch implements parameter 'checked_in' on checkouts endpoint to enable getting circulation history. Test plan: 1) Apply the patch and restart plack 2) Use your favorite REST API tester and play with /checkouts endpoint: - use it without checked_in parameter - use checked_in=1 for getting all (not only current) checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:25:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:25:38 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 --- Comment #22 from Josef Moravec --- Created attachment 87255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87255&action=edit Bug 17005: Test for checked_in parameter Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:26:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:26:00 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56699|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:26:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:26:18 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:26:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:26:28 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:34:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:34:36 +0000 Subject: [Koha-bugs] [Bug 22613] New: Add /patrons/patron_id/checkouts endpoints Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 Bug ID: 22613 Summary: Add /patrons/patron_id/checkouts endpoints Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com Target Milestone: --- As described in RFC, there should be endpoint in the form /patrons/{patron_id}/checkouts for getting patrons checkouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:34:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:34:46 +0000 Subject: [Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | URL| |https://wiki.koha-community | |.org/wiki/Checkouts_endpoin | |t_RFC Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:35:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:35:23 +0000 Subject: [Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 [Bug 17005] REST API: add routes to list checkouts history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:35:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:35:23 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22613 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 [Bug 22613] Add /patrons/patron_id/checkouts endpoints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:47:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:47:52 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #87 from Ere Maijala --- David, you're right about the placeholders for itemnumbers, though the change will only be necessary if the code will actually be used instead of Koha objects. About benchmarks, I find them difficult since everyone's mileage will vary. I can fabricate a worst case benchmark such as exporting 1000 biblios that each have 1000 items, but someone else would have hard time getting the impressive results I got. In many cases a simple situation with one item per biblio might not show a meaningful change at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:52:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:52:46 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:52:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:52:51 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87248|0 |1 is obsolete| | Attachment #87249|0 |1 is obsolete| | Attachment #87250|0 |1 is obsolete| | Attachment #87251|0 |1 is obsolete| | Attachment #87252|0 |1 is obsolete| | Attachment #87253|0 |1 is obsolete| | --- Comment #76 from Michal Denar --- Created attachment 87256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87256&action=edit Bug 11529: Add new fields to biblio table Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:52:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:52:57 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #77 from Michal Denar --- Created attachment 87257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87257&action=edit Bug 11529: Use new biblio fields whenever possible Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:53:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:53:02 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #78 from Michal Denar --- Created attachment 87258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87258&action=edit Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:53:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:53:08 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #79 from Michal Denar --- Created attachment 87259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87259&action=edit Bug 11529: Clean up subtitle usage Unify and clean up subtitle usage so that it's always used as a simple array and not the old hash structure. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:53:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:53:13 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #80 from Michal Denar --- Created attachment 87260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87260&action=edit Bug 11529: Remove field mapping table and admin page Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 10:53:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 08:53:18 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #81 from Michal Denar --- Created attachment 87261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87261&action=edit Bug 11529: DBIx schema changes Updates to Biblio schema and removal of FieldMapping schema. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 11:54:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 09:54:24 +0000 Subject: [Koha-bugs] [Bug 22581] Include the Verovio library to show musical incipits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 11:54:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 09:54:47 +0000 Subject: [Koha-bugs] [Bug 22580] Remove misc/cronjobs/delete_expired_opac_registrations.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 11:55:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 09:55:09 +0000 Subject: [Koha-bugs] [Bug 22573] Hold expiration date could be in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22573 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 11:55:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 09:55:47 +0000 Subject: [Koha-bugs] [Bug 22584] Add YAML support for Codemirror In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:00:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:00:35 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:17:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:17:47 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87226|0 |1 is obsolete| | Attachment #87227|0 |1 is obsolete| | Attachment #87228|0 |1 is obsolete| | Attachment #87229|0 |1 is obsolete| | Attachment #87230|0 |1 is obsolete| | Attachment #87231|0 |1 is obsolete| | Attachment #87232|0 |1 is obsolete| | Attachment #87233|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 87262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87262&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:24:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:24:51 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #30 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:24:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:24:51 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 21304, which changed state. Bug 21304 Summary: Update two-column templates with Bootstrap grid: Catalog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:24:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:24:51 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Bug 21948 depends on bug 21304, which changed state. Bug 21304 Summary: Update two-column templates with Bootstrap grid: Catalog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:24:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:24:52 +0000 Subject: [Koha-bugs] [Bug 22032] Improve local cover image tab on detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 Bug 22032 depends on bug 21304, which changed state. Bug 21304 Summary: Update two-column templates with Bootstrap grid: Catalog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:28:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:28:15 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- Always nice to have a little tidy up.. pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:29:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:29:46 +0000 Subject: [Koha-bugs] [Bug 19661] Add routes for funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #24 from Martin Renvoize --- As per my commitment to backporting new API endpoints wherever reasonable to do so... Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:32:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:32:44 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Keywords| |Manual, | |release-notes-needed --- Comment #25 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:34:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:34:29 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement add the release notes| |`--digest-per-branch` | |option to | |advanced_notices.pl to | |allow notices to be grouped | |by branch rather than | |grouped by borrower if so | |required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:35:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:35:04 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #43 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:35:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:35:05 +0000 Subject: [Koha-bugs] [Bug 7811] borrowers.borrowernumber should be a foreign key for 8 tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7811 Bug 7811 depends on bug 22008, which changed state. Bug 22008 Summary: accountlines.manager_id is missing a foreign key constraint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:35:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:35:05 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Bug 22593 depends on bug 22008, which changed state. Bug 22008 Summary: accountlines.manager_id is missing a foreign key constraint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:38:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:38:32 +0000 Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Martin Renvoize --- As a preparatory enhancement for GDPR work I've chosen to backport this one. Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:39:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:39:00 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 Bug 19605 depends on bug 18589, which changed state. Bug 18589 Summary: Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:39:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:39:00 +0000 Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 Bug 21460 depends on bug 18589, which changed state. Bug 18589 Summary: Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:39:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:39:01 +0000 Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121 Bug 22121 depends on bug 18589, which changed state. Bug 18589 Summary: Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:39:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:39:01 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Bug 22440 depends on bug 18589, which changed state. Bug 18589 Summary: Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:39:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:39:02 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Bug 22464 depends on bug 18589, which changed state. Bug 18589 Summary: Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:39:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:39:02 +0000 Subject: [Koha-bugs] [Bug 22491] Patrons should be searchable by surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22491 Bug 22491 depends on bug 18589, which changed state. Bug 18589 Summary: Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:39:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:39:02 +0000 Subject: [Koha-bugs] [Bug 22528] Add tab with current/active ILL requests to patron circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22528 Bug 22528 depends on bug 18589, which changed state. Bug 18589 Summary: Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:39:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:39:02 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Bug 22531 depends on bug 18589, which changed state. Bug 18589 Summary: Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:39:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:39:02 +0000 Subject: [Koha-bugs] [Bug 22268] Data displayed in request list datatable is not sanitized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268 Bug 22268 depends on bug 18589, which changed state. Bug 18589 Summary: Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:38:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:38:59 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #41 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:39:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:39:41 +0000 Subject: [Koha-bugs] [Bug 22032] Improve local cover image tab on detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:39:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:39:42 +0000 Subject: [Koha-bugs] [Bug 22035] Improve local cover image browser page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22035 Bug 22035 depends on bug 22032, which changed state. Bug 22032 Summary: Improve local cover image tab on detail page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:41:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:41:06 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 --- Comment #20 from Martin Renvoize --- Followup pushed to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:42:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:42:28 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:43:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:43:53 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:44:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:44:46 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:51:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:51:36 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #26 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:52:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:52:02 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87262|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 87263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87263&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:52:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:52:14 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #13 from Kyle M Hall --- Created attachment 87265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87265&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:52:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:52:17 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #14 from Kyle M Hall --- Created attachment 87266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87266&action=edit Bug 20256: Add new methods for checking item editing permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:52:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:52:20 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #15 from Kyle M Hall --- Created attachment 87267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87267&action=edit Bug 20256: Update Schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:52:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:52:11 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #12 from Kyle M Hall --- Created attachment 87264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87264&action=edit Bug 20256: Add new permission to editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:52:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:52:23 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #16 from Kyle M Hall --- Created attachment 87268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87268&action=edit Bug 20256: Update groups editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:52:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:52:25 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #17 from Kyle M Hall --- Created attachment 87269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87269&action=edit Bug 20256: Use new methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:52:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:52:28 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #18 from Kyle M Hall --- Created attachment 87270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87270&action=edit Bug 20256: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:52:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:52:56 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 12:53:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 10:53:52 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:03:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:03:02 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22043 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:03:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:03:02 +0000 Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22076 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:05:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:05:54 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #16 from Martin Renvoize --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:06:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:06:56 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:07:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:07:42 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Severity|minor |enhancement Patch complexity|--- |Trivial patch Resolution|--- |FIXED --- Comment #16 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:07:43 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Bug 10535 depends on bug 10577, which changed state. Bug 10577 Summary: C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:14:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:14:09 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Severity|minor |enhancement Resolution|--- |FIXED --- Comment #48 from Martin Renvoize --- Architectural enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:14:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:14:10 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Bug 16846 depends on bug 12159, which changed state. Bug 12159 Summary: Duplicate borrower_add_additional_fields function https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:14:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:14:10 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Bug 20443 depends on bug 12159, which changed state. Bug 12159 Summary: Duplicate borrower_add_additional_fields function https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:14:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:14:11 +0000 Subject: [Koha-bugs] [Bug 20648] Attribute option "Display in check-out" should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648 Bug 20648 depends on bug 12159, which changed state. Bug 12159 Summary: Duplicate borrower_add_additional_fields function https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:14:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:14:48 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Bug 22518 depends on bug 22593, which changed state. Bug 22593 Summary: Cronjobs/Scripts dealing with accountlines need updating for bug 22008 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:14:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:14:49 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Bug 22577 depends on bug 22593, which changed state. Bug 22593 Summary: Cronjobs/Scripts dealing with accountlines need updating for bug 22008 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:14:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:14:47 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #6 from Martin Renvoize --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:26:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:26:42 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 --- Comment #7 from Hugo Agud --- It works fine, this is very useful for example if we share records via oai-pmh to a discovery and it has the functionality of full text extraction, it needs direct access to full text, now with this developement this is achievable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:36:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:36:53 +0000 Subject: [Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87225|0 |1 is obsolete| | CC| |colin.campbell at ptfs-europe. | |com --- Comment #2 from Colin Campbell --- Created attachment 87271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87271&action=edit patch to make test consistent with initial copy In addition to the typo, the patch used a different call to for subsequent copies to the initial copy. That could create confusion in the future -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:42:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:42:30 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86583|0 |1 is obsolete| | --- Comment #8 from Hugo Agud --- Created attachment 87272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87272&action=edit Bug 22508: Add upload_public_path to config Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:42:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:42:36 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86585|0 |1 is obsolete| | --- Comment #10 from Hugo Agud --- Created attachment 87274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87274&action=edit Bug 22508: Add the ability to prefill 856$u with the direct URL of the file When uploading a file using the cataloguing plugin, the current value used to fill 856$u (or others) in is OPACBaseURL/cgi-bin/koha/opac-retrieve-file.pl?id=a-big-hash This patch add the ability to define a custom and direct URL to this file. To accomplish that we need 2 new entries in our config file: * upload_public_path * upload_public_url The first one will be the local path where the files will be stored, that will be publicly accessible. The second one is the root of the URL which links to ths public dir path. Test plan: 0. Define the 2 new config entries, like: /home/vagrant/kohaclone/koha-tmpl/public_path http://catalogue.kohadev.org/public_path Then restart memcached+plack to take into account the changes 1. Link the cataloguing plugin 'upload.pl' to 856$u 2. Edit a record, 856$u > click the plugin link 3. A new "Use a public path:" appears if the config is set, tick it and upload a file 4. Pick "Choose the direct url" 5. 856$u will be prefilled with http://catalogue.kohadev.org/public_path/$hash_value instead of the usual http://catalogue.kohadev.org/cgi-bin/koha/opac-retrieve-file.pl?id=$hash_value 6. Use the link and confirm that you can access the file. Note: This patch is not ready for inclusion yet and is published to get feedback. There are several things that will block its inclusion: * TODO: "Delete" button must delete the file * See TODO and FIXME in the patch * Tests and POD for new methods are missing * Variable naming is not perfect * In discussion - what about the upload of files from outside of the cataloguing plugin? * TODO: add check to the about page (?) * FIXME: in upload_public_path the files are not suffixed by the filename as it is for upload_path. We certainly want to be consistent here. Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:42:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:42:33 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86584|0 |1 is obsolete| | --- Comment #9 from Hugo Agud --- Created attachment 87273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87273&action=edit Bug 22508: Add upload_public_url to config Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 13:58:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 11:58:13 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 14:11:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 12:11:19 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #26 from Hugo Agud --- (In reply to Owen Leonard from comment #25) > I have a concern which I think may be a blocker for this feature: All other > cover image sources use a "normalized_isbn" variable which is provided to > the templates. This feature doesn't use a normalized ISBN, so a library > might upload an image file with a name like this: > > "0553573403.png" > > ...and find that Koha is trying to load an image with this file name: > > "0553573403 | 9780553573404 (pbk.).png" > > I think it would be more consistent to have custom cover images use a > normalized ISBN too. Not all books have ISBN for example historical books have not any kind of ISBN, even it should be great to be able to use non isbn and issn fields like 024. I think force a normalized ISBN will reduce the potential value of it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 14:12:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 12:12:11 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #27 from Hugo Agud --- I have applied the patch, it appears the class Cover Image, but src is emtpy then no image is published -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 14:13:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 12:13:15 +0000 Subject: [Koha-bugs] [Bug 21663] Incorrect filter prevents predefined notes from being added to patron acccounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 --- Comment #6 from Josef Moravec --- Created attachment 87275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87275&action=edit Bug 21663: Add /patrons/{patron_id}/checkouts endpoint to REST API Test plan: 1) Apply the patch 2) Restart plack 3) Access GET to /patrons/{patron_id}/checkouts It should have the same abilities as /checkouts?patron_id={patron_id} 4) prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 14:28:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 12:28:05 +0000 Subject: [Koha-bugs] [Bug 21663] Incorrect filter prevents predefined notes from being added to patron acccounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Attachment #87275|0 |1 is obsolete| | --- Comment #7 from Josef Moravec --- Comment on attachment 87275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87275 Bug 21663: Add /patrons/{patron_id}/checkouts endpoint to REST API Sorry, wrong bug number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 14:30:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 12:30:02 +0000 Subject: [Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 --- Comment #1 from Josef Moravec --- Created attachment 87276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87276&action=edit Bug 22613: Add /patrons/{patron_id}/checkouts endpoint to REST API Test plan: 1) Apply the patch 2) Restart plack 3) Access GET to /patrons/{patron_id}/checkouts It should have the same abilities as /checkouts?patron_id={patron_id} 4) prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 14:30:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 12:30:43 +0000 Subject: [Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 14:31:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 12:31:14 +0000 Subject: [Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 14:42:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 12:42:02 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #28 from Owen Leonard --- (In reply to Hugo Agud from comment #26) > > I think it would be more consistent to have custom cover images use a > > normalized ISBN too. > > Not all books have ISBN for example historical books have not any kind of > ISBN I'm not suggesting that the feature should be limited to only normalized ISBN. I'm saying that if ISBN is selected, normalized ISBN should be provided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 14:48:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 12:48:28 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 --- Comment #2 from Hugo Agud --- Ths script allow a better integration with vufind, and allow to create hierarchy facets by date 1st level year, 2 level mont, third level day NOw the script add the same date to all records but 1. Each record should have its onw date, perhaps import from a marc tag? 2. the script should only apply to records without 905, not recreated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 14:50:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 12:50:17 +0000 Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at hypernova.fi --- Comment #23 from Josef Moravec --- *** Bug 19072 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 14:50:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 12:50:17 +0000 Subject: [Koha-bugs] [Bug 19072] REST API: Toggle suspend for /api/v1/holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |josef.moravec at gmail.com Resolution|--- |DUPLICATE --- Comment #7 from Josef Moravec --- *** This bug has been marked as a duplicate of bug 22206 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 15:06:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 13:06:16 +0000 Subject: [Koha-bugs] [Bug 22614] New: Request migration from one backend to another should not create new request Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22614 Bug ID: 22614 Summary: Request migration from one backend to another should not create new request Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com Target Milestone: --- Currently, when requests are migrated from one backend to another, a new request is created containing the attributes of the existing one but with the backend set to the migration destination backend and the metadata is derived from the migration destination backend. The existing request is then marked as reverted and a record is made of where the request was migrated to. The downside of this approach is that two requests now exist in the system, whereas in actual fact, it's still the same request. This can be problematic for statistics etc. This bug proposes that request migration should preserve the original request and, instead, change its backend and replace the metadata from the original backend to that of the migration destination backend. Also, we should log where the request has been migrated from and to. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 15:06:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 13:06:38 +0000 Subject: [Koha-bugs] [Bug 22614] Request migration from one backend to another should not create new request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22614 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 15:14:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 13:14:04 +0000 Subject: [Koha-bugs] [Bug 22614] Request migration from one backend to another should not create new request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22614 --- Comment #1 from Andrew Isherwood --- Created attachment 87277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87277&action=edit Bug 22614: Migrate original request This patch changes an active request's backend and initiates the migration on that request, rather than creating another and migrating that. The majority of the work to accomplish this bug is being carried out in the backends, since Koha delegates migrations to them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 15:43:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 13:43:59 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 1 15:44:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Apr 2019 13:44:04 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #16 from Owen Leonard --- Created attachment 87278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87278&action=edit Bug 21582: Use CodeMirror for *UserJS & *UserCSS This patch adds CodeMirror syntax highlighting by default to JS and CSS system preferences. HTML preferences will use CodeMirror editors if UseWYSIWYGinSystemPreferences is disabled. Three new CodeMirror files are added to support three new syntax highlighting modes: XML (for HTML), CSS, and JS. A new option is added to *.pref file configurations for textareas which are intended for HTML, JS, or CSS: syntax. This option is passed to the CodeMirror configuration to control syntax highlighting mode. Textareas without a syntax option specified will not have CodeMirror enabled. To test, apply the patch and go to Administration -> System preferences. Test the behavior of several preferences which use ) FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 11) forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 376) FAIL js_in_body A " - Create another list named "k\o\h\a" - Hit /cgi-bin/koha/virtualshelves/shelves.pl => Without this patch the lists will not be displayed, JSON is malformated => With this patch everything is ok Signed-off-by: Marcel de Rooy Signed-off-by: Liz Rea Resolved minor merge issues, QA plz check they are ok - but it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 17:29:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 15:29:53 +0000 Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #19 from Liz Rea --- Created attachment 88638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88638&action=edit Bug 20891: Escape html then JSON To my understanding we need to escape first html chars then to JSON. If this patch works we will need to rethink the 'To' TT plugin. It was originally designed to have several escape methods, but with these changes it will not make sense to name it 'To' if used only to escape JSON IIRC we should keep the 2 different ways to use it: * [% To.json( string ) %] * [% string | $To %] otherwise it will be hard to use it when called in argument of patron-title.inc (`git grep To.json`) Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 17:29:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 15:29:33 +0000 Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 17:36:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 15:36:19 +0000 Subject: [Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 17:36:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 15:36:21 +0000 Subject: [Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 --- Comment #1 from Nick Clemens --- Created attachment 88639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88639&action=edit Bug 22650: Prevent multiple holds on individual items This patch corrects a missing id on the holds_to_place field and adds code to disable the box when an item is checked Additionally script login now places a single hold if an itemnumebr is passed and checks for holdability of the specific item To test: 1 - Allow multiple holds per record in circ rules 2 - In staff client, go to place a hold on a record 3 - Select a patron 4 - Increase the number of holds 5 - Then select a specific item to hold 6 - Patron now has multiple holds on a single item 7 - Apply patch 8 - Repeat, notice that count is disabled when item checked 9 - Confirm count is enabled when 'Hold next available item' is checked 10 - Set number to more than 1 11 - Check an item and submit 12 - Confirm only one item is reserved 13 - Hit the script directly (with valid info): http://localhost:8081/cgi-bin/koha/reserve/placerequest.pl?biblionumber=1&checkitem=1&holds_to_place_count=2&borrowernumber=5 14 - Confirm only one hold is placed 15 - Confirm multiple hits of the url do not generate further holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 17:36:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 15:36:40 +0000 Subject: [Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 17:37:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 15:37:15 +0000 Subject: [Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 17:39:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 15:39:31 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec at gmail.com Status|Signed Off |Failed QA --- Comment #153 from Josef Moravec --- Started QAing: 1) QA test tools have complains about missing filters FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt FAIL filters missing_filter at line 22 ( [% UNLESS ( I ) %][% IF ( othernames ) %]“[% othernames %]”[% END %]) missing_filter at line 64 (
  • Card number: [% cardnumber %]
    • ) missing_filter at line 65 (
  • Borrowernumber: [% borrowernumber %]
    • ) missing_filter at line 66 (
  • Category: [% categoryname %] ([% categorycode %])
    • ) missing_filter at line 66 (
  • Category: [% categoryname %] ([% categorycode %])
    • ) 2) The database update is not consistent, in atomic file you add columns after other columns then in kohastructure.sql Also, you should use .perl atomic update here, to check for column existence before adding it - see skeleton.perl for example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 17:51:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 15:51:58 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Liz Rea --- So terribly sorry Aleisha, this patch doesn't apply cleanly anymore. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 18:22:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 16:22:47 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 18:29:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 16:29:01 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 --- Comment #32 from Katrin Fischer --- Should we close the bug? Or mark as dependency? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 18:29:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 16:29:10 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 18:29:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 16:29:10 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Bug 7890 depends on bug 22399, which changed state. Bug 22399 Summary: Improve responsive behavior of the basic marc editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 18:29:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 16:29:11 +0000 Subject: [Koha-bugs] [Bug 22582] Authority plugin link broken by Bug 22399 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 Bug 22582 depends on bug 22399, which changed state. Bug 22399 Summary: Improve responsive behavior of the basic marc editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 18:29:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 16:29:20 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 18:29:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 16:29:26 +0000 Subject: [Koha-bugs] [Bug 22768] New: Basic MARC editor tab keyboard navigation broekn Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 Bug ID: 22768 Summary: Basic MARC editor tab keyboard navigation broekn Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org, testopia at bugs.koha-community.org Depends on: 22045 Blocks: 22399 Target Milestone: --- Dobrica's comment from Bug 22045: This bug broke keyboard shortcuts because of following change: --- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ -31,7 +31,7 @@ $.fn.tabIndex = function () { return $(this).parent().children('div').index(this); }; $.fn.selectTabByID = function (tabID) { - $(this).tabs("option", "active", $(tabID).tabIndex()); + $(this).tabs("option", "active", $( "#" + tabID ).tabIndex()); }; $(document).ready(function() { without modification to calling which also prefix tabID with #, thus creating invalid ##tabID Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 [Bug 22045] Cataloging UX enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 18:29:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 16:29:26 +0000 Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access to tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 [Bug 22768] Basic MARC editor tab keyboard navigation broekn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 18:29:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 16:29:26 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 [Bug 22768] Basic MARC editor tab keyboard navigation broekn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 18:46:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 16:46:25 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #42 from Martin Renvoize --- I'm confused.. was that last patch a followup to silence the spurious warnings on koha-testing-docker after this bug was applied? I get the feeling we should probably make the logpath writable in koha-testing-docker as a resolution (I like being told loudly that logging isn't working, which this bug actually introduced). Either way.. the followup doesn't appear to resolve the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 19:16:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 17:16:06 +0000 Subject: [Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 19:16:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 17:16:09 +0000 Subject: [Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88639|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 88640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88640&action=edit Bug 22650: Prevent multiple holds on individual items This patch corrects a missing id on the holds_to_place field and adds code to disable the box when an item is checked Additionally script login now places a single hold if an itemnumebr is passed and checks for holdability of the specific item To test: 1 - Allow multiple holds per record in circ rules 2 - In staff client, go to place a hold on a record 3 - Select a patron 4 - Increase the number of holds 5 - Then select a specific item to hold 6 - Patron now has multiple holds on a single item 7 - Apply patch 8 - Repeat, notice that count is disabled when item checked 9 - Confirm count is enabled when 'Hold next available item' is checked 10 - Set number to more than 1 11 - Check an item and submit 12 - Confirm only one item is reserved 13 - Hit the script directly (with valid info): http://localhost:8081/cgi-bin/koha/reserve/placerequest.pl?biblionumber=1&checkitem=1&holds_to_place_count=2&borrowernumber=5 14 - Confirm only one hold is placed 15 - Confirm multiple hits of the url do not generate further holds Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 19:29:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 17:29:51 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Liz Rea --- Hi, Sorry to report that the updatadatabase failed with DEV atomic update: plugin_methods.perl Atomic update generated errors: Can't call method "InstallPlugins" on an undefined value at (eval 1398) line 13. Have a look? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 20:01:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 18:01:47 +0000 Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |wizzyrea at gmail.com --- Comment #18 from Liz Rea --- Hi, before I got into functional testing I tried the unit tests, and got a failure: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove -v t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CalcDateDue.t .. 1..17 ok 1 - use C4::Circulation; ok 2 - date expiry ok 3 - date expiry with useDaysMode to noDays ok 4 - date expiry should be 2013-01-01 -1 day not ok 5 - date expiry should be 2013-01-01 -2 day # Failed test 'date expiry should be 2013-01-01 -2 day' # at t/db_dependent/Circulation/CalcDateDue.t line 80. # got: '2013-01-02T23:59:00' # expected: '2012-12-30T23:59:00' ok 6 - date expiry ( 9 + 10 ) ok 7 - date expiry ( 9 + 5 ) ok 8 - useDaysMode = Dayweek, no closed days, issue date expiry ( start + 10 ) ok 9 - useDaysMode = Dayweek, no closed days, renewal date expiry ( start + 5 ) ok 10 - useDaysMode = Dayweek, closed on due date, 10 day loan (should not trigger 7 day roll forward), issue date expiry ( start + 10 + 1 ) ok 11 - useDaysMode = Dayweek, closed on due date, 5 day renewal (should not trigger 7 day roll forward), renewal date expiry ( start + 5 + 1 ) ok 12 - useDaysMode = Dayweek, closed on due date, 14 day loan (should trigger 7 day roll forward), issue date expiry ( start + 21 ) ok 13 - useDaysMode = Dayweek, closed on due date, 7 day renewal (should trigger 7 day roll forward), renewal date expiry ( start + 14 ) ok 14 - useDaysMode = Dayweek, closed on due date and two subequent due dates, 14 day loan (should trigger 2 x 7 day roll forward), issue date expiry ( start + 28 ) ok 15 - useDaysMode = Dayweek, closed on due date and three subsequent due dates, 7 day renewal (should trigger 3 x 7 day roll forward), issue date expiry ( start + 28 ) ok 16 - useDaysMode = Dayweek, due on Saturday, closed on Saturdays, 14 day loan (should trigger 1 day roll forward), issue date expiry ( start + 15 ) ok 17 - useDaysMode = Dayweek, due on Saturday, closed on Saturdays, 7 day renewal (should trigger 1 day roll forward), issue date expiry ( start + 8 ) # Looks like you failed 1 test of 17. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/17 subtests Test Summary Report ------------------- t/db_dependent/Circulation/CalcDateDue.t (Wstat: 256 Tests: 17 Failed: 1) Failed test: 5 Non-zero exit status: 1 Files=1, Tests=17, 3 wallclock secs ( 0.03 usr 0.01 sys + 1.45 cusr 0.52 csys = 2.01 CPU) Result: FAIL I have decided not to continue on with functional testing until the tests pass. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 20:10:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 18:10:45 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #51 from Martin Renvoize --- (In reply to Fridolin SOMERS from comment #50) > > have a granular set of permissions on the server > What about adding to koha-conf.xml a boolean to allow or not uploading > plugins ? > If not allowed only system admin can add plugins. > > My 2c You can already enable and disable plugins entirely from koha-conf can't you.. I was thinking more having classifactions of plugins so you could allow a whitelist of supported ones for example.. or say.. all cataloguing plugins but not auth plugins. I like the idea of a whitelist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 20:14:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 18:14:58 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #18 from Martin Renvoize --- Sorry, this one isn't ready at all for testing yet I'm afraid. I've been working through the tree of bugs above it and may will split this one up a little further too once a few more of those foundations are closer to being in. Don't worry, I've certainly not forgotten this one though, we have lots of customers very eager to see it too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 20:50:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 18:50:42 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #18 from Tom?s Cohen Arazi --- (In reply to David Cook from comment #16) > (In reply to Tom?s Cohen Arazi from comment #15) > > Proposal for discussion: > > - Make it explicit by declaring what 'capabilities' the plugin has, like > > our $capabilities = { tools => 1, ... }; > > - Rename methods => capabilities: > > Just for the sake of discussion, is there a different word that could be > used instead of capabilities? It seems to me like a word where typos might > be easily introduced? As THE native speaker, it is your responsbility to propose another word :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 20:52:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 18:52:26 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #144 from Michal Denar --- Hi Ere, I get error: Applying: Bgu 11529: Update kohafield in default framework only if not already set. Using index info to reconstruct a base tree... A installer/data/mysql/atomicupdate/bug_11529.perl Falling back to patching base and 3-way merge... CONFLICT (modify/delete): installer/data/mysql/atomicupdate/bug_11529.perl deleted in HEAD and modified in Bgu 11529: Update kohafield in default framework only if not already set.. Version Bgu 11529: Update kohafield in default framework only if not already set. of installer/data/mysql/atomicupdate/bug_11529.perl left in tree. error: Failed to merge in the changes. Please, can you rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 20:54:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 18:54:34 +0000 Subject: [Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Liz Rea --- Hi Jonathan, It all seems alright until we save the item - the window/tab doesn't close and the receive window doesn't seem to update. Have another look? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 20:56:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 18:56:42 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #19 from Michal Denar --- Hi Martin, we want this feature too. So, I'm ready for testing. Just set status if follow-up will be ready. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 21:26:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 19:26:54 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #73 from Kyle M Hall --- Comment on attachment 88314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88314 Bug 18308: Added step to onboarding tool to set minPasswordLength Review of attachment 88314: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18308&attachment=88314) ----------------------------------------------------------------- ::: installer/onboarding.pl @@ +292,5 @@ > > +if ( $step == 6 ) { > + if ( $op eq 'set_validate_min_password_length' ) { > + my $minPasswordLength = $input->param('pref_minPasswordLength'); > + warn $minPasswordLength; This should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 21:27:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 19:27:44 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #74 from Kyle M Hall --- Comment on attachment 88315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88315 Bug 18308: Added warning and dialog alert Review of attachment 88315: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18308&attachment=88315) ----------------------------------------------------------------- ::: members/memberentry.pl @@ +174,5 @@ > +#Check passwords > +my $minPasswordLength = C4::Context->preference('minPasswordLength'); > +warn $minPasswordLength; > +if ($minPasswordLength < 8) { > + warn my $warning = "Your minPasswordLength system preference is less than 8 characters this means library patrons can potentially set passwords which are vulnerable to cracking. Please set your minPasswordLength syspref to 8 or more characters"; This is not translatable and should not be warn'ed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 21:29:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 19:29:45 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #75 from Kyle M Hall --- Remove the warns and move the string from the perl script to the template and this should be good to go! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 21:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 19:41:45 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 21:43:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 19:43:57 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 --- Comment #11 from Marjorie Barry-Vila --- Hi, Is it a duplicate of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 ? Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 21:59:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 19:59:09 +0000 Subject: [Koha-bugs] [Bug 22738] Software Error after LDAP Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal CC| |wizzyrea at gmail.com --- Comment #18 from Liz Rea --- Can't replicate, suspect config, not a project blocker. Please, if you need more ideas, send your query to the Koha mailing list. Cheers, Liz Rea -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:02:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:02:08 +0000 Subject: [Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 --- Comment #15 from Jonathan Druart --- (In reply to Katrin Fischer from comment #14) > What we had discussed I think was storing data in other formats than MARC - > so still 1:1 No, it would become 1:n then. What about renaming the method in Koha::S::R::Biblio to ->marc_xml_metadata (adding the conditions in it) and Koha::Biblio->metadata to ->marc_xml (make it returns the MARX XML directly)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:03:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:03:43 +0000 Subject: [Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 --- Comment #16 from Katrin Fischer --- (In reply to Jonathan Druart from comment #15) > (In reply to Katrin Fischer from comment #14) > > What we had discussed I think was storing data in other formats than MARC - > > so still 1:1 > > No, it would become 1:n then. I meant still only 1 metadata entry - either MARC or Dublincore or... not having both or multiple formats. It would allow to load data without converting to MARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:06:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:06:29 +0000 Subject: [Koha-bugs] [Bug 22762] Collection codes not displayed on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88587|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:09:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:09:11 +0000 Subject: [Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Jonathan Druart --- Hi Liz, thanks for testing. The window closes correctly here, make sure you refreshed the cache. However the data are not updated, because of the "method not covered by tests" error, with the patch from bug 22762 it looks ok. Could you retest with both patches applied? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:09:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:09:37 +0000 Subject: [Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 [Bug 22762] Collection codes not displayed on receiving -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:09:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:09:37 +0000 Subject: [Koha-bugs] [Bug 22762] Collection codes not displayed on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:10:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:10:52 +0000 Subject: [Koha-bugs] [Bug 22732] Redundant search box on admin-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22732 --- Comment #5 from Christopher Brannon --- Can't you just turn the top search filed blue or something? I'm not sure why having it two inches lower makes any difference. It's just wasted space, IMO. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:16:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:16:40 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #29 from Jonathan Druart --- Just a note: there is bug 20307 that could have handled the translation part. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:16:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:16:49 +0000 Subject: [Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |katrin.fischer at bsz-bw.de Summary|Move hold to top button |Move hold to top button |doesn't work if waiting |doesn't work if waiting |holds exist. |holds exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:23:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:23:55 +0000 Subject: [Koha-bugs] [Bug 21591] Data inconsistencies - Item types and biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591 --- Comment #7 from Jonathan Druart --- Comment on attachment 88377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88377 Bug 21591: Additionally check for blank strings in itypes Review of attachment 88377: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21591&attachment=88377) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +330,4 @@ > > # Check for item on shelves and OnShelfHoldsAllowed > return { status => 'onShelfHoldsNotAllowed' } > + unless ( IsAvailableForItemLevelRequest($item->unblessed,$borrower) ); Is that change correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:24:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:24:38 +0000 Subject: [Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:24:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:24:41 +0000 Subject: [Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88555|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 88641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88641&action=edit Bug 22753: Fix hold priority adjustment, move to top Since the holds table can be split we need to calculate the first priority for each table. However, currently we use the first in the loop, not taking into account the waiting status. This patchset sets the first_priority to the first non-found hold Additionally, some clean-up is done to not display the alter priority arrows for waiting holds. To test: 1 - Place several holds on a title 2 - Confirm one of the holds to be waiting 3 - Attempt to move the last hold to the top 4 - Nothing happens 5 - Apply patch 6 - Note that the waiting hold has no options to move in the list 7 - Attempt to move the last hold to the top 8 - It moves as expected! 9 - Split the holds queue by pickup library 10 - PLace some holds for pickup at another branch 11 - Confirm moving these holds works within their own table 12 - Unsplit the queue 13 - Ensure the holds end where you expect (moving in a split table didn't move above holds form another table) Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:24:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:24:45 +0000 Subject: [Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 --- Comment #5 from Katrin Fischer --- Created attachment 88642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88642&action=edit Bug 22753: Fix tabs pointed out by QA script Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:25:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:25:09 +0000 Subject: [Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 --- Comment #17 from Martin Renvoize --- I do sort of agree that 'metadata' feels like a bit a generic term if in reality it's always marc.. As an aside, do we have any inflators setup with our dbic schemata? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:29:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:29:17 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #15 from Martin Renvoize --- Oh, sorry, I hadn't spotted that this one had come to life.. I'll try hard to find a moment to have a look at it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:30:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:30:15 +0000 Subject: [Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:30:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:30:19 +0000 Subject: [Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88595|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 88643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88643&action=edit Bug 21757: Clenup of moremember.pl and its templates This patch: - removes unused templates - use objects as much as possible - remove many template params Test plan: 1) Apply the patch 2) Play with patron detail page and try to broke it anyhow ;) - messaging preferences - enhanced attributes - guarantors and guarantees - fines - messages - checkouts - overdues - use different date formats, price formats and address formats - ... there is many thinks you could try with this one page ;) Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:30:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:30:22 +0000 Subject: [Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88596|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer --- Created attachment 88644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88644&action=edit Bug 21757: (folow-up) Restore patron brief detail page Test plan 1) Try to create patron with same name/datefobirth to trigger the duplicate patron check 2) Click on "View existing record" link on "Duplicate patron record?" alert message 3) You should see the patron data, but withou toolbar, menu, and so on. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:30:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:30:26 +0000 Subject: [Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88597|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer --- Created attachment 88645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88645&action=edit Bug 21757: (follow-up) Fix number of columns in checkouts table footer template Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:37:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:37:26 +0000 Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #2 from Jonathan Druart --- What is the error? Is this a duplicate of bug 22453? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:40:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:40:38 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #49 from Katrin Fischer --- Hi Andrew, I am very sorry, not sure the last patch is quite right. I think what happens now is that either will make 'all' checkboxes appear, if the item is on hold or not. I think we need to control the checkboxes separately, if that makes sense? Test case: Have at least 2 items checked out, 1 is on hold. AllowRenewalOnHoldOverride AllowRenewalLimitOverride - Restriction override checkbox below table appears - OK - Checking the box, enables the on hold item for renewal - OK - Checking the box also enabled all other items for renewal - not OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:44:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:44:42 +0000 Subject: [Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 --- Comment #18 from Jonathan Druart --- (In reply to Martin Renvoize from comment #17) > As an aside, do we have any inflators setup with our dbic schemata? Like: Koha/ItemTypes.pm: $Koha::Schema::Result::Itemtype::LANGUAGE = $language; ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:55:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:55:41 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 --- Comment #20 from Jonathan Druart --- (In reply to Martin Renvoize from comment #12) > Jonathan isn't around much at the moment so Katrin asked me to check in > here. I believe Jonathans last followup was somewhat flawed (looks like a > copy paste issue). Martin, I tried to reuse the previous code to prevent other regressions. But it seems I left a 'grep'. The code was: - my $new_member = { map { join(' ', at columns) =~ /$_/ ? ( $_ => $data{$_} ) : () } keys(%data) } ; So, I am now wondering: should not you test 'exists' instead of 'defined' in your code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:56:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:56:44 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88451|0 |1 is obsolete| | --- Comment #140 from Katrin Fischer --- Created attachment 88646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88646&action=edit Bug 14576: Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Michal Denar Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:56:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:56:50 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88452|0 |1 is obsolete| | --- Comment #141 from Katrin Fischer --- Created attachment 88647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88647&action=edit Bug 14576: Unit tests To test: 1 - prove -v t/db_dependent/Circulation/Returns.t 2 - prove -v t/db_dependent/Circulation/issue.t 3 - prove -v t/db_dependent/UsageStats.t 4 - All should pass Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:56:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:56:57 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88453|0 |1 is obsolete| | --- Comment #142 from Katrin Fischer --- Created attachment 88648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88648&action=edit Bug 14576: Update to use get_yaml_pref_hash Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:57:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:57:03 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88454|0 |1 is obsolete| | --- Comment #143 from Katrin Fischer --- Created attachment 88649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88649&action=edit Bug 14576: (follow-up) fix some typos and style Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:56:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:56:37 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:57:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:57:09 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88455|0 |1 is obsolete| | --- Comment #144 from Katrin Fischer --- Created attachment 88650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88650&action=edit Bug 14576: Rebase fixes Fix test Rebase code Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:57:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:57:16 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88456|0 |1 is obsolete| | --- Comment #145 from Katrin Fischer --- Created attachment 88651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88651&action=edit Bug 14576: Replaced calls using deprecated method GetItem with Koha::Items->find Test plan: 1) Apply all patches except this one 2) Checkout out an item to a patron 3) Check the item in - note that this will fail 4) Apply this patch, and repeat steps 1-3, noting instead that the the check is instead successful 5) Verify also that reserves act as expected 5) Sign off Sponsored-by: Catalyst IT Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:57:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:57:22 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88457|0 |1 is obsolete| | --- Comment #146 from Katrin Fischer --- Created attachment 88652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88652&action=edit Bug 14576: (follow-up) Using item objects, not hashrefs Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:57:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:57:28 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88458|0 |1 is obsolete| | --- Comment #147 from Katrin Fischer --- Created attachment 88653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88653&action=edit Bug 14576: (QA follow-up) Tidy up feature documentation To test: Apply this patch with all of the others run the updatedatabase, it should work install a new Koha, this pref should be installed and look fine in the interface. Check the syspref, make sure the text looks ok and makes sense. Bonus points: for checking to make sure PROC: _PERM_ appears in the new pereference if InProcessingToShelvingCart was set for checking to make sure _ALL_: CART appears in the new preferenec if ReturnToShelvingCart was previously set. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 22:57:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 20:57:35 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88459|0 |1 is obsolete| | --- Comment #148 from Katrin Fischer --- Created attachment 88654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88654&action=edit Bug 14576: (follow-up) Add code highlighting to system preference UpdateItemLocationOnCheckin Test plan: 1) Go to system preferences and find preference UpdateItemLocationOnCheckin 2) Ensure the yaml code higlighting is used on textarea when editing this setting Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:01:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:01:07 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 --- Comment #21 from Jonathan Druart --- Try that: use Koha::Patrons; my @columns = Koha::Patrons->columns; my $xxx = { cardnumber => 1, foo => 2, borrowernumber => 3, bar => 4, opacnote => undef }; my $h1 = { map { join(' ', at columns) =~ /$_/ ? ( $_ => $xxx->{$_} ) : () } keys(%$xxx) } ; # original version my $h2 = { map { defined( $xxx->{$_} ) ? ( $_ => $xxx->{$_} ) : () } @columns }; # new version use Data::Printer colored => 1; warn p $h1; use Data::Printer colored => 1; warn p $h2; Note sure if it is relevant however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:04:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:04:55 +0000 Subject: [Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:04:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:04:58 +0000 Subject: [Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88562|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 88655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88655&action=edit Bug 21502: Add check for YAML formatted system preferences to about page So far there are these yaml formatted preferences: UpdateNotForLoanStatusOnCheckin OpacHiddenItems BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder Test plan: 1) Add some badly formatted YAML into some of preferences listed above 2) Check the System information tab on About page for appropriate warnings Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:05:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:05:02 +0000 Subject: [Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88563|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 88656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88656&action=edit Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:05:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:05:06 +0000 Subject: [Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88564|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 88657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88657&action=edit Bug 21502: Add ItemsDeniedRenewal system preference to check syntax Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:10:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:10:03 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #25 from Josef Moravec --- Comment on attachment 86134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86134 Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Review of attachment 86134: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18928&attachment=86134) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +1706,5 @@ > + > + # Search for rules! > + foreach my $rule_name (qw( holdallowed hold_fulfillment_policy returnbranch )) { > + foreach my $params (@params) { > + my $rule = Koha::CirculationRules->search( Why do you use ->search instead of get_effective_rule? ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ +720,4 @@ > Return policy >   > > + [% FOREACH i IN itemtypeloop %] There is something strange in displaying hold policy for itemtypes. When I have set values in Default checkout, hold and return policy section, i see all item types listed with the same value as set in Default section, even if i set some itemtypes differently... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:10:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:10:38 +0000 Subject: [Koha-bugs] [Bug 22757] Use YAML CodeMirror higlighting on YAML preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22757 --- Comment #6 from Katrin Fischer --- Created attachment 88658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88658&action=edit Bug 22757: Add CodeMirror highlighting on more YAML formatted preferences Test plan: Go to system preferences and ensure the code highlighting is used on these preferences: UpdateNotForLoanStatusOnCheckin BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder ItemsDeniedRenewal Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:11:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:11:12 +0000 Subject: [Koha-bugs] [Bug 22757] Use YAML CodeMirror higlighting on YAML preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:11:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:11:14 +0000 Subject: [Koha-bugs] [Bug 22757] Use YAML CodeMirror higlighting on YAML preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88461|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:16:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:16:07 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #26 from Josef Moravec --- Created attachment 88659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88659&action=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in Default checkout, hold and return policy section on circulation rules admin page, try for all libraries and for one specific library. Save. 2) Click on unset and confitm --> without patch, the Maximum total holds allowed value remains --> with patch the unset removex Maximum holds value too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:16:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:16:36 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:20:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:20:53 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Hi Hayley, I think if we decide to remvoe the script, we should also remove the directory test and the README file. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:22:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:22:06 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com --- Comment #5 from Katrin Fischer --- Adding Jonathan and Tomas as I can see them in the history for these files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:28:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:28:31 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22600 Status|Signed Off |Patch doesn't apply CC| |josef.moravec at gmail.com --- Comment #39 from Josef Moravec --- Just a note: use Koha::Script -cron; should be added to cronjob script - see bug 22600 Also, this needs a rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:28:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:28:31 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17168 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:29:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:29:03 +0000 Subject: [Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:30:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:30:50 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer --- > As there has been some controversy about showing this information - could > you consider wrapping a span with a class around the years part? Hi Josef, totally my fault for not being clear :( ... I meant a span around the _whole_ age (number + text). So you can choose not to see it. Guarantor search is ok now (not sure what happened before) - just this little bit left. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:36:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:36:28 +0000 Subject: [Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:36:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:36:32 +0000 Subject: [Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86119|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 88660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88660&action=edit Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest Almost everywhere we call IsAvailableForItemLevelRequest we already have a Koha::Patron and Koha::Item object. It makes sense to use them to avoid a refetch Test plan: It would be good to test this patch on top of 19300 and 19301 and make sure everything works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:42:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:42:46 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 --- Comment #6 from Jonathan Druart --- Added by bug 5309. See also: commit f8a58d310ee96a4bf272c9ae16dc347bf1d0e4ea Author: Marcel de Rooy Date: Mon Aug 17 13:54:44 2015 +0200 Bug 14321: Final cleanup, removing obsolete files The new Upload.pm, unit test and file-upload.js obsolete a number of files, including an older jQuery plugin. The test files progressbar.pl and progressbarsubmit.pl are outdated and do not serve any purpose in this form. (Actually, we could argue if they should be here or just be part of a debugging phase.) I am fine with removing -r search/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:56:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:56:56 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:57:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:57:02 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86521|0 |1 is obsolete| | Attachment #86522|0 |1 is obsolete| | --- Comment #14 from Josef Moravec --- Created attachment 88661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88661&action=edit Bug 10300: Allow transferring of items to be have separate IndependentBranches syspref Some libraries want to have IndependentBranches enabled, but still be able to transfer items between themselves. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndpendentBranches and IndependentBranchesTransfers 4) Log in as a super librarian 5) Note you can transfer items 6) Log in as a non-super librarian 7) Note you cannot transfer items 8) Disable IndependentBranchesTransfers 9) Note you can now transfer items Signed-off-by: Maribeth Shafer Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:57:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:57:07 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 --- Comment #15 from Josef Moravec --- Created attachment 88662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88662&action=edit Bug 10300: (follow-up) add controls on transfers page This patch moves the check of IndependentBranchesTransfers pref to templates and adds permission test inside branchtransfers.pl. It also corrects the libraries combobox in branchtransfers.tt, this list can contain all libraries, it is the access to the page that may be protected. Additions to test plan : 1) 1.1) Enable CircSidebar 1.2) In circulation home page check the effect of IndependentBranchesTransfers on "Transfer" link 1.3) Go to return page and check then effect of IndependentBranchesTransfers on "Transfer" link 2) 2.1) In circ/branchtransfers.pl, with and without IndependentBranches you see all libraries are in combobox 3) 3.1) Set IndependentBranchesTransfers to no and go to circ/branchtransfers.pl 3.2) You are redirected to page 403 unless you are superlibarian Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:57:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:57:11 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 --- Comment #16 from Josef Moravec --- Created attachment 88663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88663&action=edit Bug 10300: (QA follow-up) Make database update idempotent Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:57:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:57:25 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 24 23:57:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 21:57:36 +0000 Subject: [Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 --- Comment #18 from Katrin Fischer --- Created attachment 88664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88664&action=edit Bug 21502: (QA follow-up) Rephrase warning slightly Test plan: Follow first test plan, look at warning, decide if you like it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:03:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:03:05 +0000 Subject: [Koha-bugs] [Bug 21651] Force insert of notices related tables during the install process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 --- Comment #6 from Jonathan Druart --- Hum yes, indeed. I have no idea why I added that to the commit message. Do you think we should disable the checkboxes? If we do, we certainly we want to disable all the mandatory ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:11:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:11:02 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86602|0 |1 is obsolete| | --- Comment #111 from Josef Moravec --- Created attachment 88665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88665&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:11:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:11:07 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86603|0 |1 is obsolete| | --- Comment #112 from Josef Moravec --- Created attachment 88666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88666&action=edit Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:11:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:11:12 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86604|0 |1 is obsolete| | --- Comment #113 from Josef Moravec --- Created attachment 88667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88667&action=edit Bug 8995: (follow-up) Adapt to current codebase Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:11:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:11:17 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86605|0 |1 is obsolete| | --- Comment #114 from Josef Moravec --- Created attachment 88668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88668&action=edit Bug 8995: (follow-up) Added test Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:11:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:11:22 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86606|0 |1 is obsolete| | --- Comment #115 from Josef Moravec --- Created attachment 88669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88669&action=edit Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:11:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:11:27 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86607|0 |1 is obsolete| | --- Comment #116 from Josef Moravec --- Created attachment 88670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88670&action=edit Bug 8995: (follow-up) Move GetOpenURLResolverURL to Koha::Biblio->get_openurl Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:11:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:11:33 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86608|0 |1 is obsolete| | --- Comment #117 from Josef Moravec --- Created attachment 88671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88671&action=edit Bug 8995: (follow-up) Move GetCOinSBiblio to Koha::Biblio->get_coins Signed-off-by: Magnus Enger Test plan: 1) Ensure the COinS span tag is still included on this pages. You need to look into html source and search for span tag with class 'Z3988', which has COinS string in title. Staff client: catalogue -> ISBDdetail catalogue -> MARCdetail catalogue -> detail virtualshelves -> shelves OPAC (you should have COinSinOPACResults system preference enabled): opac detail opac search opac shelves 2) Run tests: prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:11:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:11:38 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86609|0 |1 is obsolete| | --- Comment #118 from Josef Moravec --- Created attachment 88672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88672&action=edit Bug 8995: (follow-up) Add one more test fot get_openurl Test plan: prove t/db_dependent/Koha/Biblio.t Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:11:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:11:43 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86610|0 |1 is obsolete| | --- Comment #119 from Josef Moravec --- Created attachment 88673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88673&action=edit Bug 8995: (follow-up) Tak system preference item-level_itypes into account Signed-off-by: Magnus Enger Tested with all 9 current patches. Works as advertised, including OPACURLOpenInNewWindow. If a record has no items, no OpenURL link is displayed. All the suggested tests pass. I did not test with XSLT turned off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:12:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:12:04 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #120 from Josef Moravec --- Just rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:43:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:43:19 +0000 Subject: [Koha-bugs] [Bug 22316] Double quotes in some patron's attributes breaks patrons search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22316 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22715 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:43:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:43:19 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22316 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:57:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:57:12 +0000 Subject: [Koha-bugs] [Bug 22764] More YUI grid cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88621|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 88674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88674&action=edit Bug 22764: More YUI grid cleanup This patch cleans up a few places where templates still contain YUI grid markup. Some other minor markup problems are also fixed. - additional-fields.tt: - Converts YUI grid to Bootstrap - Replaces obsolete tag with styled - Adds _() function to string in embedded JavaScript - detail.tt: - Fixes some stray YUI grid classes - Fixes corresponding JavaScript to enable page adjustments - moredetail.tt: - Removes unnecessary YUI grid markup To test, apply the patch and view the affected pages, confirming that everything looks correct and that the page adjusts well to various browser widthds. When testing the bibliographic detail page, enable AmazonCoverImages and view a record with and without an Amazon cover image. The layout should work in both cases. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:57:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:57:44 +0000 Subject: [Koha-bugs] [Bug 22764] More YUI grid cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 00:59:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Apr 2019 22:59:15 +0000 Subject: [Koha-bugs] [Bug 22764] More YUI grid cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 --- Comment #3 from Lucas Gass --- All these pages look good, at all screen sizes. The details.tt seems clean with or without Amazon cover images and at all screen sizes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 06:04:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 04:04:32 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #30 from paxed --- or something like [% SET location = BLOCK %]OPAC news[% END %] would let the text be translatable while still being assigned into a variable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 06:57:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 04:57:28 +0000 Subject: [Koha-bugs] [Bug 22769] New: Editing a record value missing if value has double quote Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22769 Bug ID: 22769 Summary: Editing a record value missing if value has double quote Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: apirak at punsarn.asia QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- Test plan: [0] Use staff interface [1] Add record [2] Add title with double quote in the middle of title example. 'The test "123" koha' [3] Edit record [4] Go to title field [5] In input box, value has missing also happends in editing Authorities record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:26:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:26:46 +0000 Subject: [Koha-bugs] [Bug 22367] Editing a record has quotes changed to " In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 21986 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:26:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:26:46 +0000 Subject: [Koha-bugs] [Bug 21986] Quotation marks are wrongly escaped in several places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |b.pastern4k at gmail.com --- Comment #20 from Katrin Fischer --- *** Bug 22367 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:28:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:28:55 +0000 Subject: [Koha-bugs] [Bug 22769] Editing a record value missing if value has double quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22769 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi apirak, this sounds like bug 21986 and should be fixed in version 18.05.10. *** This bug has been marked as a duplicate of bug 21986 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:28:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:28:55 +0000 Subject: [Koha-bugs] [Bug 21986] Quotation marks are wrongly escaped in several places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |apirak at punsarn.asia --- Comment #21 from Katrin Fischer --- *** Bug 22769 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:33:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:33:36 +0000 Subject: [Koha-bugs] [Bug 22766] Tags cloud link in OPAC does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|minor |critical Version|18.11 |master --- Comment #2 from Katrin Fischer --- Confirmed. - Make sure Tags are activatd - Add some tags and mark them 'approved' - Log out - Go to Tag cloud in the OPAC - Nothing displays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:38:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:38:21 +0000 Subject: [Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at koha-suomi.fi --- Comment #7 from Katrin Fischer --- *** Bug 13231 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:38:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:38:21 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #12 from Katrin Fischer --- Marking this a duplicate of the older bug 17661, because there are more people on CC list there. Not sure if the patch here could be rescued? *** This bug has been marked as a duplicate of bug 17661 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:43:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:43:46 +0000 Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #20 from Katrin Fischer --- Tested with a little meaner version: \ Seems to work like a charm! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:44:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:44:30 +0000 Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:44:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:44:34 +0000 Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88637|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 88675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88675&action=edit Bug 20891: Escape list's names in JSON When someone uses \ in the description of a list, the datatable in staff won't load and keeps processing. Test plan: - Create a list named "" - Create another list named "k\o\h\a" - Hit /cgi-bin/koha/virtualshelves/shelves.pl => Without this patch the lists will not be displayed, JSON is malformated => With this patch everything is ok Signed-off-by: Marcel de Rooy Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:44:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:44:38 +0000 Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88638|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 88676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88676&action=edit Bug 20891: Escape html then JSON To my understanding we need to escape first html chars then to JSON. If this patch works we will need to rethink the 'To' TT plugin. It was originally designed to have several escape methods, but with these changes it will not make sense to name it 'To' if used only to escape JSON IIRC we should keep the 2 different ways to use it: * [% To.json( string ) %] * [% string | $To %] otherwise it will be hard to use it when called in argument of patron-title.inc (`git grep To.json`) Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:45:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:45:12 +0000 Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #23 from Katrin Fischer --- Updating severity a little bit - broken searches can be quite an issue for the library and are hard to fix without SQL access. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:45:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:45:49 +0000 Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21716 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:45:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:45:49 +0000 Subject: [Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20891 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:45:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:45:51 +0000 Subject: [Koha-bugs] [Bug 22738] Software Error after LDAP Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 morsch at iza.org changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:46:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:46:15 +0000 Subject: [Koha-bugs] [Bug 22768] Basic MARC editor tab keyboard navigation broekn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:46:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:46:22 +0000 Subject: [Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 --- Comment #12 from Katrin Fischer --- Maybe the fix from bug 20891 would be helpful here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:47:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:47:07 +0000 Subject: [Koha-bugs] [Bug 22738] Software Error after LDAP Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 morsch at iza.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:50:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:50:59 +0000 Subject: [Koha-bugs] [Bug 22738] Software Error after LDAP Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC|koha-bugs at lists.koha-commun | |ity.org | Severity|major |normal --- Comment #19 from Katrin Fischer --- Hi, adding the mailing list CC won't help, especially not the koha-bugs one as this is for the bugzilla changes and only very few are subscribed there (not including the bugzilla user itself). The normal mailing lists has a much wider audience. I suggest sending all information to the koha-devel list: http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel Someone might be able to spot the issue, that we haven't been able to figure out. Severity has been downgraded because we can't reproduce the problem at the moment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:53:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:53:07 +0000 Subject: [Koha-bugs] [Bug 22764] More YUI grid cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- (In reply to Lucas Gass from comment #3) > All these pages look good, at all screen sizes. The details.tt seems clean > with or without Amazon cover images and at all screen sizes. Thx for your testing notes! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:58:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:58:46 +0000 Subject: [Koha-bugs] [Bug 22764] More YUI grid cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:58:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:58:49 +0000 Subject: [Koha-bugs] [Bug 22764] More YUI grid cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88674|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 88677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88677&action=edit Bug 22764: More YUI grid cleanup This patch cleans up a few places where templates still contain YUI grid markup. Some other minor markup problems are also fixed. - additional-fields.tt: - Converts YUI grid to Bootstrap - Replaces obsolete tag with styled - Adds _() function to string in embedded JavaScript - detail.tt: - Fixes some stray YUI grid classes - Fixes corresponding JavaScript to enable page adjustments - moredetail.tt: - Removes unnecessary YUI grid markup To test, apply the patch and view the affected pages, confirming that everything looks correct and that the page adjusts well to various browser widthds. When testing the bibliographic detail page, enable AmazonCoverImages and view a record with and without an Amazon cover image. The layout should work in both cases. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:58:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:58:52 +0000 Subject: [Koha-bugs] [Bug 22764] More YUI grid cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 --- Comment #6 from Katrin Fischer --- Created attachment 88678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88678&action=edit Bug 22764: Change marcfield to MARC field in alert message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:59:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:59:36 +0000 Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:59:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:59:14 +0000 Subject: [Koha-bugs] [Bug 22764] More YUI grid cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 --- Comment #7 from Katrin Fischer --- Also includes a translation and a few capitalization fixes ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:59:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:59:40 +0000 Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88444|0 |1 is obsolete| | Attachment #88445|0 |1 is obsolete| | Attachment #88626|0 |1 is obsolete| | --- Comment #32 from Josef Moravec --- Created attachment 88679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88679&action=edit Bug 21460: Simplify the code to have only 1 assignment Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:59:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:59:43 +0000 Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 --- Comment #33 from Josef Moravec --- Created attachment 88680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88680&action=edit Bug 21460: (follow-up) Filter params in .pl This patch filters the passed parameters in the .pl, rather than doing it in the template. As per comment 16 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460#c16) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 07:59:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 05:59:47 +0000 Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 --- Comment #34 from Josef Moravec --- Created attachment 88681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88681&action=edit Bug 21460: (follow-up) Fix bugs found in QA Fix silly bugs mentioned in comment #29 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:01:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:01:08 +0000 Subject: [Koha-bugs] [Bug 22765] Add class beside loggedinusername to indicate if logged in user is a superlibrarian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:05:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:05:00 +0000 Subject: [Koha-bugs] [Bug 22765] Add class beside loggedinusername to indicate if logged in user is a superlibrarian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:05:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:05:03 +0000 Subject: [Koha-bugs] [Bug 22765] Add class beside loggedinusername to indicate if logged in user is a superlibrarian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88634|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 88682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88682&action=edit Bug 22765: Add class beside loggedinusername to indicate if logged in user is a superlibrarian It would be useful to know if a logged in user is a superlibrarian for the purpose of customization using Javascript and CSS. Test Plan: 1) Apply this patch, restart all the things 2) Log in as a superlibraraian 3) Note the new class 'is_superlibrarian' next to the 'loggedinusername' class 4) Log in as a non-superlibrarian 5) Note the new class is not present Signed-off-by: Barton Chittenden Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:05:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:05:27 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #33 from Josef Moravec --- (In reply to Kyle M Hall from comment #31) > Comment on attachment 88546 [details] [review] > Bug 20256: Use new methods > > Review of attachment 88546 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Items.pm > @@ +1746,4 @@ > > $status = "book_on_loan"; > > } > > elsif ( defined C4::Context->userenv > > + and !Koha::Patrons->find( C4::Context->userenv->{number} )->can_edit_item( $item ) ) > > cli scripts have no userenv, so this is cli safe. Sorry, I totally misread the code, you are right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:07:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:07:36 +0000 Subject: [Koha-bugs] [Bug 22743] OverDrive results page is missing overdrive-login include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Patch reads well, trusting Owen's testing here! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:08:12 +0000 Subject: [Koha-bugs] [Bug 22743] OverDrive results page is missing overdrive-login include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:09:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:09:32 +0000 Subject: [Koha-bugs] [Bug 22743] OverDrive results page is missing overdrive-login include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:09:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:09:35 +0000 Subject: [Koha-bugs] [Bug 22743] OverDrive results page is missing overdrive-login include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88371|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 88683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88683&action=edit Bug 22743: Add password modal to overdrive results page This patch also removes a line abotu ratings which was throwing an error. Confirm stars rating for OD results are still shown as expected To test: 1 - Enable overdrive circulation with password required 2 - Sign in to OPAC but not overdrive 3 - Perform a search that returns overdrive results 4 - Click in to results page http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats 5 - Note 'Login to OverDrive account' link 6 - Click it 7 - Nothing happens! 8 - Apply patch 9 - Repeat 10 - Success! Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:11:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:11:03 +0000 Subject: [Koha-bugs] [Bug 22738] Software Error after LDAP Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 --- Comment #20 from morsch at iza.org --- Thank you very much. Hopefully one from the list could help me. Thanks for your help and patience Katrin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:15:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:15:20 +0000 Subject: [Koha-bugs] [Bug 22664] Link basket name and basket group name instead of the, often short, basket numbers in order search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:15:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:15:23 +0000 Subject: [Koha-bugs] [Bug 22664] Link basket name and basket group name instead of the, often short, basket numbers in order search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88290|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 88684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88684&action=edit Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:15:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:15:26 +0000 Subject: [Koha-bugs] [Bug 22664] Link basket name and basket group name instead of the, often short, basket numbers in order search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88291|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 88685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88685&action=edit Bug 22664: More making acquisitions links more easily clickable To test: * create a basket with an order from a staged record, and an order from a suggestion * add that basket to a basket group when you close it. * note that the links to the basket in the first column, the link to the basket group in the second column, and the link to the suggester in the summary column are very small (only the ID# is linked) * apply this patch, restart the things * refresh the page, note that the previously ogled links are now bigger and easier to find and click, and that the links work and such * rejoice. Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:15:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:15:45 +0000 Subject: [Koha-bugs] [Bug 22664] Link basket name and basket group name instead of the, often short, basket numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Link basket name and basket |Link basket name and basket |group name instead of the, |group name instead of the, |often short, basket numbers |often short, basket numbers |in order search results | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:19:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:19:10 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #80 from Katrin Fischer --- Hi Aleisha, I am sorry, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:25:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:25:50 +0000 Subject: [Koha-bugs] [Bug 20421] Apply CheckPrevCheckout logic when placing a hold on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86691|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 88686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88686&action=edit Bug 20421: Inform staff that patron does have the title checked out during placing hold Test plan: 1) Enable the CheckPrevCheckout and DisplayMultiPlaceHold system preferences 2) Have a patron with some checkouts history 3) Try to place hold on one of titles from history for this patron 4) You should see an information at the top of confirm request page, but you still should be able to place a hold 5) Try this with multiple titles - one or more of them should be from history 6) You should see this information in "Information" column 7) There is also new column placed at the beggining with checkbox, you could uncheck it for titles you do not want to place a hold on it 8) Confirm the hold is placed only on checked titles Signed-off-by: Martin Renvoize Signed-off-by: Bin Wen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:25:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:25:54 +0000 Subject: [Koha-bugs] [Bug 20421] Apply CheckPrevCheckout logic when placing a hold on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88002|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 88687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88687&action=edit Bug 20421: (follow-up) Fix styling Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:25:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:25:47 +0000 Subject: [Koha-bugs] [Bug 20421] Apply CheckPrevCheckout logic when placing a hold on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:27:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:27:02 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:55:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:55:44 +0000 Subject: [Koha-bugs] [Bug 22551] Stray "//" appears at bottom of opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88041|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 88688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88688&action=edit Bug 22551: Stray "//" appears at bottom of opac-detail.tt Removes a couple stray "// Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:56:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:56:19 +0000 Subject: [Koha-bugs] [Bug 22551] Stray "//" appears at bottom of opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- It's great to see such teamwork going on here guys, well done. Patch works well and causes no regressions.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 08:57:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 06:57:46 +0000 Subject: [Koha-bugs] [Bug 22551] Stray "//" appears at bottom of opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551 --- Comment #11 from Martin Renvoize --- As an addendum to the advice given here, you might find git-bz helpful Eric. https://wiki.koha-community.org/wiki/Git_bz_configuration It's automates the creation and upload of patches to bugzilla (as well as making the application of such patches to your development environment very simple too) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:00:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:00:30 +0000 Subject: [Koha-bugs] [Bug 22723] Syntax error on confess call in Koha/MetadataRecord/Authority.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88616|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 88689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88689&action=edit Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes. It may generates this error : Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186. Simply missing double quotes. Also missing use Carp to call confess. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:00:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:00:45 +0000 Subject: [Koha-bugs] [Bug 22723] Syntax error on confess call in Koha/MetadataRecord/Authority.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Good catch, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:03:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:03:29 +0000 Subject: [Koha-bugs] [Bug 19241] Items with status of hold show as available in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88127|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 88690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88690&action=edit Bug 19241: Waiting items show as available in the cart The cart uses the same item-status.inc that the details page uses, however, we don't set the waiting or reserved flags. This patch adds those flags to the script To test: 1 - Find an item on the opac 2 - Place a hold on the item 3 - Check in the item to confirm the hold 4 - Note the details page on OPAC shows 'On hold' 5 - Add the item to a basket 6 - Note the basket shows 'Available' 7 - Apply patch 8 - Check the cart, should show as 'On hold' Signed-off-by: Hayley Mapley Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:03:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:03:57 +0000 Subject: [Koha-bugs] [Bug 19241] Items with status of hold show as available in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- No regressions found, simple fix. Thanks all, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:08:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:08:43 +0000 Subject: [Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88640|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 88691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88691&action=edit Bug 22650: Prevent multiple holds on individual items This patch corrects a missing id on the holds_to_place field and adds code to disable the box when an item is checked Additionally script login now places a single hold if an itemnumebr is passed and checks for holdability of the specific item To test: 1 - Allow multiple holds per record in circ rules 2 - In staff client, go to place a hold on a record 3 - Select a patron 4 - Increase the number of holds 5 - Then select a specific item to hold 6 - Patron now has multiple holds on a single item 7 - Apply patch 8 - Repeat, notice that count is disabled when item checked 9 - Confirm count is enabled when 'Hold next available item' is checked 10 - Set number to more than 1 11 - Check an item and submit 12 - Confirm only one item is reserved 13 - Hit the script directly (with valid info): http://localhost:8081/cgi-bin/koha/reserve/placerequest.pl?biblionumber=1&checkitem=1&holds_to_place_count=2&borrowernumber=5 14 - Confirm only one hold is placed 15 - Confirm multiple hits of the url do not generate further holds Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:09:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:09:06 +0000 Subject: [Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Nice fix, no regressions found.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:09:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:09:13 +0000 Subject: [Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:10:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:10:45 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20256 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:10:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:10:45 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22600 --- Comment #34 from Josef Moravec --- (In reply to Josef Moravec from comment #33) > (In reply to Kyle M Hall from comment #31) > > Comment on attachment 88546 [details] [review] [review] > > Bug 20256: Use new methods > > > > Review of attachment 88546 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: C4/Items.pm > > @@ +1746,4 @@ > > > $status = "book_on_loan"; > > > } > > > elsif ( defined C4::Context->userenv > > > + and !Koha::Patrons->find( C4::Context->userenv->{number} )->can_edit_item( $item ) ) > > > > cli scripts have no userenv, so this is cli safe. > > > Sorry, I totally misread the code, you are right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:14:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:14:39 +0000 Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #2) > What is the error? Is this a duplicate of bug 22453? Yeah it looks like it *** This bug has been marked as a duplicate of bug 22453 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:14:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:14:39 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from Marcel de Rooy --- *** Bug 22741 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:18:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:18:04 +0000 Subject: [Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88350|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 88692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88692&action=edit Bug 22729: DB update Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:18:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:18:07 +0000 Subject: [Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88351|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 88693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88693&action=edit Bug 22729: [DO_NOT_PUSH] DBIC update I add this DBIC update because I didn't manage to add the +anonymize => { is_boolean => 1 } change without the schema updating script to bark because of the non-existent column... Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:18:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:18:10 +0000 Subject: [Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88352|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 88694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88694&action=edit Bug 22729: Adapt Koha::Patron(s) and tests This patch adapts the Koha::Patron(s) code to the column change. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:18:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:18:13 +0000 Subject: [Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88353|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 88695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88695&action=edit Bug 22729: Adapt /patrons controller code to the change This patch makes the controller code aware of the flgAnonymized => anonymized change. To test: - Run $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:18:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:18:16 +0000 Subject: [Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #21 from Martin Renvoize --- Created attachment 88696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88696&action=edit Bug 22729: (QA follow-up) Ensure no NULL values before setting NOT NULL Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:19:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:19:23 +0000 Subject: [Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize --- Great work, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:22:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:22:24 +0000 Subject: [Koha-bugs] [Bug 22734] Fund not marked as mandatory when ordering from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88322|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 88697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88697&action=edit Bug 22734: Fund not marked as mandatory when ordering from a staged file This patch does some refactoring of JavaScript to make handling of required fields more robust. It also moves some template JavaScript to the footer and some to a separate file. A fallback "pattern" attribute is added to the quantity field, requiring 0-9+ values. The "required" property of the funds dropdown is now dependent on the value set under the "Default accounting details" tab. If a default is selected, the individual item funds are preselected and not marked required. To test, apply the patch and begin the process of ordering from a staged file. - Select all items to import. - Under each item, the fund should be marked mandatory. - The quantity field should accept only numbers. - Select the "Default accounting details" tab and select a default fund. - Return to the "Select to import" tab. Your selected default fund should now be preselected under each item. The fund should no longer be marked required. Un-selecting a default fund should result in each item fund select becoming required. Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:22:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:22:34 +0000 Subject: [Koha-bugs] [Bug 22734] Fund not marked as mandatory when ordering from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:23:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:23:46 +0000 Subject: [Koha-bugs] [Bug 22734] Fund not marked as mandatory when ordering from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- When I came to this bug I wasn't expecting to find such a large patch.. refactoring seems to be solid though and I can't find any regressions, well done Owen. I'd love to see some selenium regression tests here but I'm not going to fail QA for that. Passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:25:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:25:40 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:25:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:25:50 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88253|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:26:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:26:57 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #145 from Ere Maijala --- Oops, sorry. There was an older version of one of the patches left over because of a typo in the title. I obsoleted it so it should be better now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:30:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:30:49 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88085|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 88698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88698&action=edit Bug 20692: Extreme toggle checking for plack TEST PLAN --------- sudo koha-plack --disable sudo koha-plack --disable sudo koha-plack --enable sudo koha-plack --disable echo $? sudo koha-plack --disable echo $? sudo koha-list --noplack echo $? sudo koha-plack --enable echo $? sudo koha-plack --enable echo $? sudo koha-list --plack echo $? git bz apply 20692 sudo perl ~/misc4dev/cp_debian_files.pl then repeat the test. It should also be noted, because the enable and disable are now split, if for some reason they become out of sync, an enable or disable should correct them. Because these are bash scripts, the test tool (/home/vagrant/qa-test-tools/koha-qa.pl) does not apply. Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:31:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:31:00 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:31:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:31:24 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Nice bit of code curling there guys, a solid improvement, thanks. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:33:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:33:26 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:36:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:36:05 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #17 from Martin Renvoize --- Haha.. thanks for the follow-up Liz.. but you fell into the whole I nearly always also fall into 'follow-up' vs 'Follow-up'... QA script complained.. I've fixed it ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:37:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:37:46 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #18 from Martin Renvoize --- ooh.. also you forgot your signoff lines.. must have been a late night for you aye... so glad it's not just me who does that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:41:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:41:02 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87673|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 88699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88699&action=edit Bug 20837: Unit tests To test: prove -v t/db_dependent/Holds.t prove -v t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:41:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:41:05 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87674|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 88700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88700&action=edit Bug 20837: Use ReservesControlBranch to determine holdability of items To test: 1 - Set a default holds plicy for an item type as 'from home library' 2 - Set CircControl to 'logged in library' 3 - Log in as staff from a library without the rule set 4 - Note you can set holds for patrons of any library on items of type above 5 - Toggle ReservesControlBranch and note that nothing changes 6 - Toggle CircControl and note some combinations don't allow holds 7 - Apply patch 8 - Toggle ReservesControlBranch and note that holdability is affected 9 - Toggle CircControl and note holdability does not change 10 - Read the note on admin/smartrules.pl and confirm it makes sense Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:41:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:41:08 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #21 from Martin Renvoize --- Created attachment 88701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88701&action=edit Bug 20837: (QA follow-up) adding missing filter to make QA tool happy Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:43:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:43:08 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |WARNING: This patch release notes| |corrects the behaviour of | |reserve rules such that | |they match the system | |preference descriptions. | |This may initial lead to | |confusion as prior to this | |the CircControl branches | |were used incorrectly. Keywords|Manual, | |release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:43:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:43:29 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:43:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:43:40 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:43:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:43:22 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87675|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:44:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:44:05 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize --- Nick, could you check my release notes make sense? Otherwise, looks good and Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:47:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:47:02 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 --- Comment #10 from Marcel de Rooy --- As discussed on the duplicate report, the second prove of Koha/Patrons.t always failed. And with this patch it does no longer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:48:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:48:08 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88632|0 |1 is obsolete| | --- Comment #35 from Josef Moravec --- Created attachment 88702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88702&action=edit Bug 20256: (QA follow-up) Remove double negative from code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:48:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:48:12 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #36 from Josef Moravec --- Created attachment 88703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88703&action=edit Bug 20256: (QA follow-up) Change meaning should change code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:48:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:48:15 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #37 from Josef Moravec --- Created attachment 88704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88704&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:48:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:48:18 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #38 from Josef Moravec --- Created attachment 88705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88705&action=edit Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:49:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:49:48 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 --- Comment #11 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #10) > As discussed on the duplicate report, the second prove of Koha/Patrons.t > always failed. And with this patch it does no longer. And just after writing that, the error came up again with this patch. Too bad.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 09:52:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 07:52:05 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Josef Moravec --- (In reply to Josef Moravec from comment #33) > (In reply to Kyle M Hall from comment #31) > > Comment on attachment 88546 [details] [review] [review] > > Bug 20256: Use new methods > > > > Review of attachment 88546 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: C4/Items.pm > > @@ +1746,4 @@ > > > $status = "book_on_loan"; > > > } > > > elsif ( defined C4::Context->userenv > > > + and !Koha::Patrons->find( C4::Context->userenv->{number} )->can_edit_item( $item ) ) > > > > cli scripts have no userenv, so this is cli safe. > > > Sorry, I totally misread the code, you are right I misread the code, but it is still valid, since bug 22600 added userenv to commandline/cron scripts... I added follow-up for this and for some other minor issues. But there is still one bigger problem: On biblio detail page, the checkbox is shown only when user can edit the item, but the edit button in the most right column of items table does not respect this logic. Even worse, I am able to edit the item, when i click it or reach the edit item form directly. This should be fixed on module level I think... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:02:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:02:39 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87905|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 88706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88706&action=edit Bug 22339: Fix search field mappings of MARC fixed fields Fixes handling of /0 selector in addition to several fixed field positions. Note that ff7-01-02 is in fact 00-01 in Zebra and that has been replicated here. Test plan: 1. Before applying a patch, check from Elasticsearch (e.g. localhost:9200/koha_biblios/_search?q=_id:123) what is indexed in Elasticsearch for a record for date-entered-on-file, ff7-00, ff7-01, ff7-02 and lleader. 2. Apply the patch, update database and save the record again. 3. Verify that the contents of the forementioned fields is now correct in Elasticsearch. 4. Verify that tests pass: prove -v t/Koha/SearchEngine/Elasticsearch.t Signed-off-by: Bj?rn Nyl?n Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:03:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:03:38 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- I'll confess to not being a total expert when it comes to MARC fields, but these changes appear to be solid and I can't see any obvious regressions. I really like that we're indexing by '0' now too. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:10:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:10:06 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost after sorting, faceting or paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Sorry Ere, I had a quick go at re-basing this but I wasn't entirely confident I was getting it right. Setting to Does Not Apply, once rebased please set back to SO and I'll get back to QAing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:10:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:10:14 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost after sorting, faceting or paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:37:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:37:16 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:37:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:37:23 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #51 from Josef Moravec --- Created attachment 88708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88708&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:37:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:37:19 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87869|0 |1 is obsolete| | Attachment #87870|0 |1 is obsolete| | Attachment #87871|0 |1 is obsolete| | Attachment #87872|0 |1 is obsolete| | Attachment #87873|0 |1 is obsolete| | --- Comment #50 from Josef Moravec --- Created attachment 88707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88707&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:37:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:37:27 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #52 from Josef Moravec --- Created attachment 88709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88709&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:37:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:37:30 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #53 from Josef Moravec --- Created attachment 88710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88710&action=edit Bug 22511: (follow-up) Fix test plans Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:37:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:37:34 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #54 from Josef Moravec --- Created attachment 88711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88711&action=edit Bug 22511: (follow-up) Add DB Update This update takes old VOID accountlines and attempts to restore the original accounttypes using the offsets and set the status to 'VOID' Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:37:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:37:37 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #55 from Josef Moravec --- Created attachment 88712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88712&action=edit Bug 22511: (QA follow-up) Fix update database Test plan: Run db update (and have some voided accountlines) --> without patch it fails with error message similar to: Can't use string ("Payment") as a HASH ref while "strict refs" in use at (eval 1393) line 19. --> with patch it runs as expected Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:37:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:37:41 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #56 from Josef Moravec --- Created attachment 88713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88713&action=edit Bug 22511: (QA follow-up) Refactor status description in templates Test plan: Before this patch, some accounttypes does not show status (for example voided payment) After this patch, the status is always generated - defaults to empty string This behaviour should be same in intranet and opac In OPAC templates there was even bug (used variable account instead of ACCOUNt_LINE), so the status was not shown at all Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:39:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:39:16 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | --- Comment #57 from Josef Moravec --- Martin, it would be nice if you could sign-off my follow-ups ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:44:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:44:08 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88712|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize --- Created attachment 88714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88714&action=edit Bug 22511: (QA follow-up) Fix update database Test plan: Run db update (and have some voided accountlines) --> without patch it fails with error message similar to: Can't use string ("Payment") as a HASH ref while "strict refs" in use at (eval 1393) line 19. --> with patch it runs as expected Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:44:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:44:11 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88713|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize --- Created attachment 88715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88715&action=edit Bug 22511: (QA follow-up) Refactor status description in templates Test plan: Before this patch, some accounttypes does not show status (for example voided payment) After this patch, the status is always generated - defaults to empty string This behaviour should be same in intranet and opac In OPAC templates there was even bug (used variable account instead of ACCOUNt_LINE), so the status was not shown at all Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:45:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:45:00 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #60 from Martin Renvoize --- Thanks for the followups, nice bit of tidying and makes great sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:45:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:45:38 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #61 from Josef Moravec --- (In reply to Martin Renvoize from comment #59) > Signed-off-by: Martin Renvoize Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:47:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:47:09 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost after sorting, faceting or paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87026|0 |1 is obsolete| | --- Comment #9 from Ere Maijala --- Created attachment 88716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88716&action=edit Bug 22413: Improve query string and desc creation for Elasticsearch Test plan: After each of the following steps, verify that the results and query description looks ok. 1. Do a simple keyword query 2. Change sort order 3. Click a facet 4. Do an advanced search with title and author 5. Change sort order 6. Click a facet Signed-off-by: Josef Moravec Signed-off-by: Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:48:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:48:39 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost after sorting, faceting or paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #10 from Ere Maijala --- Rebased. I also sneaked in a tweak to exclude any limits from the displayed query since they're displayed separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 10:53:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 08:53:26 +0000 Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply QA Contact|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:00:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:00:16 +0000 Subject: [Koha-bugs] [Bug 22035] Improve local cover image browser page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22035 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88390|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 88717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88717&action=edit Bug 22035: Improve local cover image browser page This patch makes changes to the way local cover images are handled on the image viewer page in the staff client. From this page you can now delete images or reach the upload images page. The patch also modifies slightly the process for deleting an image from the images tab on the bibliographic detail page. To test, apply the patch and regenerate the staff client CSS. LocalCoverImages and AllowMultipleCovers should be enabled. - Open the detail view for a record which has multiple cover images attached. On the Images tab, click the "Delete image" link for an image. After confirming, the link should change to a spinner icon and image should fade out. - Click one of the cover images to open the image viewer page. The thumbnails should each have a delete link which looks like and behaves like the delete links on the biblio detail page. - Clicking an image thumbnail should load a spinner icon into the area where the full-sized image was, which should be replaced by the image you chose. - There should be a button for uploading images which takes you to the correct page for adding images to that record. - The page title and breadcrumbs should show the title of the record. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:00:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:00:14 +0000 Subject: [Koha-bugs] [Bug 22035] Improve local cover image browser page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22035 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:10:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:10:57 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88304|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 88718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88718&action=edit Bug 22200: Add Tests for change Unit tests to check for the addition of a credit of type 'FOR' when _FixOverduesOnReturn is called with $exemptfine set to true. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:11:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:11:00 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88305|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 88719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88719&action=edit Bug 22200: Add credit when forgiving overdue Prior to this patch the exemptfine option for_FixOverduesOnReturn would directly set the overdue amount to 0 rather than creating an appropriate credit of the type forgiven and offseting it against the debt. Test Plan: 1) Find a checkout that is overdue with fines 2) Check the item in with the forgive fines option checked 3) Note that the users account details now shows the overdue as forgiven and a forgiven credit is added which matches the overdue amount (and is applied against it, i.e. both overdue and forgiven lines have 0 amountoutstanding). Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:12:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:12:07 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88323|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize --- Created attachment 88720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88720&action=edit Bug 22563: Be more descriptive with accountypes Convert 'L' to 'LOST' to become more descriptive in it's use. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:12:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:12:10 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88324|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize --- Created attachment 88721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88721&action=edit Bug 22563: Update lost handling to use accountline.status Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:12:13 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88325|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize --- Created attachment 88722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88722&action=edit Bug 22563: (follow-up) Corrections for tests Updates to unit tests to reflect the accounttype changes and introduction of status usage. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:12:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:12:16 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88326|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize --- Created attachment 88723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88723&action=edit Bug 22563: (follow-up) Items LOST should not be RETURNED Up until now we marked lost items as returned in the accountlines, now we have the oportunity to mark these distinctly with an appropriate status we should. Test Plan 1) Find an overdue with fines 2) Ensure you are not forgiving fines when an item is marked as lost 3) Mark the item as lost 4) Confirm the Fine is given a status of 'Lost' Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:12:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:12:19 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88327|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize --- Created attachment 88724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88724&action=edit Bug 22563: (follow-up) Corrections for overdue tests Updates to unit tests to reflect the accounttype changes and introduction of status usage for _FixOverduesOnReturn. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:12:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:12:22 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88328|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 88725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88725&action=edit Bug 22563: (follow-up) Clean up remaing L, LR and CR cases in the database Test plan: 1) Confirm that after the DB update there are no L, LR or CR accountlines present. 2) Read the db update and confirm is makes sense. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:15:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:15:18 +0000 Subject: [Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88603|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 88726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88726&action=edit Bug 11573: Make rental accountlines translatable To test: 1. Set up an item type with a rental charge 2. Issue an item with that item type 3. Check fines, a charge of type 'Rent' will be visible with a description of 'Rental'. 4. Renew the item 5. Check fines, a charge of type 'Rent' will be visible with a description of 'Renewal of Rental Item TITLE BARCODE' where TITLE and BARCODE are the items title and barcode. 5. Apply the patch 6. Repeat steps 1-4, charge descriptions should now be empty and charge types should display 'Rental fee' and 'Renewal of rental item'. 7. Repeat steps 1-6 for an item type with a daily rental charge and note the charge types are now 'Daily rental fee' and 'Renewal of daily rental item' Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:15:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:15:22 +0000 Subject: [Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88604|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize --- Created attachment 88727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88727&action=edit Bug 11573: Update existing accountlines for 'Rent' Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:15:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:15:26 +0000 Subject: [Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88605|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize --- Created attachment 88728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88728&action=edit Bug 11573: Update of unit tests This patch updates the unit tests to reflect the changes to the core routines. The relevant changes are the removal of a hard coded 'description' and the splitting up of the 'Rent' accounttype into 'RENT', 'RENT_RENEW', 'RENT_DAILY' and 'RENT_DAILY_RENEW'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:15:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:15:30 +0000 Subject: [Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88606|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize --- Created attachment 88729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88729&action=edit Bug 11573: (follow-up) Correction to accountype search on opac-user.pl With the update of accountype from 'Rent' to four distinct accountypes we need to update the search here to catch all four types of charge. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:16:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:16:42 +0000 Subject: [Koha-bugs] [Bug 22621] Filters on subscription result list search the wrong column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:16:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:16:45 +0000 Subject: [Koha-bugs] [Bug 22621] Filters on subscription result list search the wrong column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88585|0 |1 is obsolete| | --- Comment #3 from Claire Gravely --- Created attachment 88730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88730&action=edit Bug 22621: Fix filters on subscription search results Caused by commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b Bug 18426: Allow to edit subscriptions in batch There is a shift caused by a hidden column, which make the filters searching on the previous column. Test plan: - Add 1+ searchable additional field for subscription - Create a new subscription - Search for subscriptions - Use the column filters to filter the results => The results must be filtered accordingly Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:17:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:17:22 +0000 Subject: [Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88614|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 88731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88731&action=edit Bug 6759: Split account creation and renewal charges Test plan: 1. Enable charging for patron enrolement 2. Add a new patron where the category is charged for 3. Note the charge of type 'Account management fee' 4. Renew the patron 5. Note the next charge of type 'Account management fee' 6. Apply patch 7. Repeat steps 1-6 and note the first charge will be of type 'Account creation fee' and the second of type 'Account renewal fee' 8. Bonus points, enable 'FeeOnChangePatronCategory' and check that when changing a patron from a free category to a charged one that a new 'Account renewal fee' is charged. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:17:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:17:25 +0000 Subject: [Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88615|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 88732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88732&action=edit Bug 6759: Update existing accountlines for 'A' Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:22:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:22:03 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost after sorting, faceting or paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88716|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 88733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88733&action=edit Bug 22413: Improve query string and desc creation for Elasticsearch Test plan: After each of the following steps, verify that the results and query description looks ok. 1. Do a simple keyword query 2. Change sort order 3. Click a facet 4. Do an advanced search with title and author 5. Change sort order 6. Click a facet Signed-off-by: Josef Moravec Signed-off-by: Marjorie Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:22:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:22:42 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost after sorting, faceting or paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize --- Awesome, works well and no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:23:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:23:13 +0000 Subject: [Koha-bugs] [Bug 22762] Collection codes not displayed on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |claire_gravely at hotmail.com --- Comment #3 from Claire Gravely --- Hiya, sorry I got following conflict when applying this Auto-merging catalogue/getitem-ajax.pl CONFLICT (content): Merge conflict in catalogue/getitem-ajax.pl Failed to merge in the changes. Patch failed at 0001 Bug 22762: Fix items.collection display on receiving -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:32:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:32:01 +0000 Subject: [Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:32:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:32:04 +0000 Subject: [Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88582|0 |1 is obsolete| | --- Comment #8 from Claire Gravely --- Created attachment 88734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88734&action=edit Bug 21589: Series link formed from 830 field is incorrect Bug 13692 corrected the series link for records using a 490/800 combination When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank) Test Plan: 1) Catalog two or more records with 830 fields 2) Note the series links are broken 3) Apply this patch 4) Reload the record details page 5) The series link should now work 6) Repeat for the OPAC Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:45:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:45:44 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88665|0 |1 is obsolete| | --- Comment #121 from Martin Renvoize --- Created attachment 88735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88735&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:45:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:45:49 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88666|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize --- Created attachment 88736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88736&action=edit Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:45:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:45:54 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88667|0 |1 is obsolete| | --- Comment #123 from Martin Renvoize --- Created attachment 88737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88737&action=edit Bug 8995: (follow-up) Adapt to current codebase Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:45:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:45:58 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88668|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize --- Created attachment 88738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88738&action=edit Bug 8995: (follow-up) Added test Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:45:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:45:33 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|WARNING: This patch |WARNING: This patch release notes|corrects the behaviour of |corrects the behaviour of |reserve rules such that |reserve rules such that |they match the system |they match the system |preference descriptions. |preference descriptions. |This may initial lead to |This may initial lead to |confusion as prior to this |confusion as prior to this |the CircControl branches |the CircControl branches |were used incorrectly. |were used incorrectly. | |Settings for | |ReservesControlBranch and | |CircControl should be | |reviewed to ensure proper | |behaviour is enforced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:46:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:46:04 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88669|0 |1 is obsolete| | --- Comment #125 from Martin Renvoize --- Created attachment 88739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88739&action=edit Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:46:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:46:08 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88670|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize --- Created attachment 88740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88740&action=edit Bug 8995: (follow-up) Move GetOpenURLResolverURL to Koha::Biblio->get_openurl Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:46:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:46:14 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88671|0 |1 is obsolete| | --- Comment #127 from Martin Renvoize --- Created attachment 88741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88741&action=edit Bug 8995: (follow-up) Move GetCOinSBiblio to Koha::Biblio->get_coins Signed-off-by: Magnus Enger Test plan: 1) Ensure the COinS span tag is still included on this pages. You need to look into html source and search for span tag with class 'Z3988', which has COinS string in title. Staff client: catalogue -> ISBDdetail catalogue -> MARCdetail catalogue -> detail virtualshelves -> shelves OPAC (you should have COinSinOPACResults system preference enabled): opac detail opac search opac shelves 2) Run tests: prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:46:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:46:18 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88672|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize --- Created attachment 88742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88742&action=edit Bug 8995: (follow-up) Add one more test fot get_openurl Test plan: prove t/db_dependent/Koha/Biblio.t Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:46:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:46:23 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #129 from Martin Renvoize --- Created attachment 88743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88743&action=edit Bug 8995: (follow-up) Take system preference item-level_itypes into account Signed-off-by: Magnus Enger Tested with all 9 current patches. Works as advertised, including OPACURLOpenInNewWindow. If a record has no items, no OpenURL link is displayed. All the suggested tests pass. I did not test with XSLT turned off. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:46:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:46:28 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #130 from Martin Renvoize --- Created attachment 88744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88744&action=edit Bug 8995: (QA follow-up) Convert db update to perl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:46:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:46:48 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #88673|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:48:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:48:27 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #131 from Martin Renvoize --- Good work team, well shepherded to completion. This works well for me and I'm unable to find any regressions.. QA scripts all pass (with the exception of the git manipulation issue where I converted the .sql file to a .perl one as per the current RM's preference). Passing QA.. any chance of something for the release notes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:48:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:48:37 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 11:55:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 09:55:25 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|Signed Off |Patch doesn't apply --- Comment #12 from Alex Arnaud --- Patch does not apply Applying: Bug 22592: Add index scan emulation to Elasticsearch fatal: sha1 information is lacking or useless (Koha/SearchEngine/Elasticsearch/QueryBuilder.pm). error: could not build fake ancestor Patch failed at 0001 Bug 22592: Add index scan emulation to Elasticsearch The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22592-Add-index-scan-emulation-to-Elasticsearc-ykcnua.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:02:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:02:15 +0000 Subject: [Koha-bugs] [Bug 22762] Collection codes not displayed on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Claire Gravely --- (In reply to Claire Gravely from comment #3) > Hiya, sorry I got following conflict when applying this > > Auto-merging catalogue/getitem-ajax.pl > CONFLICT (content): Merge conflict in catalogue/getitem-ajax.pl > Failed to merge in the changes. > Patch failed at 0001 Bug 22762: Fix items.collection display on receiving sorry, just saw the second patch is for other versions. First applies just fine! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:08:04 +0000 Subject: [Koha-bugs] [Bug 18868] Pay Selected doesn't add payment information to item information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18868 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- Is this still an issue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:08:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:08:38 +0000 Subject: [Koha-bugs] [Bug 18868] Pay Selected doesn't add payment information to item information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18868 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:08:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:08:38 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18868 [Bug 18868] Pay Selected doesn't add payment information to item information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:11:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:11:53 +0000 Subject: [Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 --- Comment #23 from Nick Clemens --- Created attachment 88745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88745&action=edit Bug 22729: (RM follow-up) Correct column in schema addition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:12:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:12:02 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #44 from Martin Renvoize --- Ready for SO again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:15:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:15:32 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #20 from Martin Renvoize --- Probably the best way to get this one moving again at this point is for someone to follow the dependencies down from bug 22200. I think I've added reasonable test plans to each of the bugs now so they should be reasonably clear. I intend to get back onto this bug in earnest very shortly, but I have my doubts that it'll make it into 19.05 at this stage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:25:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:25:30 +0000 Subject: [Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:25:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:25:33 +0000 Subject: [Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88586|0 |1 is obsolete| | --- Comment #10 from Claire Gravely --- Created attachment 88746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88746&action=edit Bug 22669: Fix item editing on receiving an order Since commit 1253975389975a8ff11a9bb2ef84582aeb6bd08b Bug 21091: Move add item template JavaScript to a separate file items cannot longer be edited when receiving an order. When moving the code to the JS file, the JS variable "opisadd" was always set to "true": var opisadd = '[% opisadd | html %]'; Even if the TT variable is 0, opisadd will be "0", which is evaluated to true in Javascript To clean the situation it is easier to remove this variable and use "op" instead. Test plan: - Make sure acqcreateitem is set to "when placing an order" - Create a basket with some orders - Close the basket - Go to your vendor and receive an order - On the receive page, try to edit your item => Without the patch, the pop up page will open and then close, not allowing the item to be edited. => With this patch applied you will see the item edit form. Save and confirm that the parent window is updated with the new value (actually it's refreshed) Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:29:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:29:11 +0000 Subject: [Koha-bugs] [Bug 22762] Collection codes not displayed on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88587|0 |1 is obsolete| | --- Comment #5 from Claire Gravely --- Created attachment 88747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88747&action=edit Bug 22762: Fix items.collection display on receiving Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). Test plan: - Set acqcreateitem to "when placing an order" - Receive an order with items => The "Collection code" column must be filled with the items.ccode value - Edit an item (You may need the patches on bug 22669) - Change the collection code value => The "Collection code" column must be filled with the new value Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:31:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:31:08 +0000 Subject: [Koha-bugs] [Bug 22762] Collection codes not displayed on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:32:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:32:44 +0000 Subject: [Koha-bugs] [Bug 22762] Collection codes not displayed on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 --- Comment #6 from Claire Gravely --- note: I have NOT tested the second patch for earlier versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:52:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:52:55 +0000 Subject: [Koha-bugs] [Bug 12817] Remove internal item field paidfor from MARC structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Moving this to be a duplicate of bug 19919 as it also discusses the removal. *** This bug has been marked as a duplicate of bug 19919 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:52:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:52:55 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from Katrin Fischer --- *** Bug 12817 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:54:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:54:15 +0000 Subject: [Koha-bugs] [Bug 18868] Pay Selected doesn't add payment information to item information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18868 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Fines and fees CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- There is some good discussion on items.paidfor on bug 19919. Marking this as a duplicate trying to get all discussion into one place. *** This bug has been marked as a duplicate of bug 19919 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:54:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:54:15 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #12 from Katrin Fischer --- *** Bug 18868 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:54:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:54:16 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Bug 14825 depends on bug 18868, which changed state. Bug 18868 Summary: Pay Selected doesn't add payment information to item information https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18868 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 12:55:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 10:55:15 +0000 Subject: [Koha-bugs] [Bug 4809] Lost & Paid For doesn't record payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Fines and fees -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:10:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:10:45 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #62 from Nick Clemens --- Created attachment 88748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88748&action=edit Bug 22511: Fix type role->roll -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:11:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:11:19 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #63 from Nick Clemens --- (In reply to Nick Clemens from comment #62) > Created attachment 88748 [details] [review] > Bug 22511: Fix type role->roll Will fix List item->Lost item in the DB update on pushing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:22:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:22:27 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88116|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 88749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88749&action=edit Bug 22715: Searching for patrons with "" in the circulation note hangs patron search To replicate: Edit a patron to have a circ note, include quoted text in it, such as "this is quoted string" Go to the patron search, search for a set of results that would include the patron with the quotes in the note Enjoy looking at "Processing" for forever. Test Plan: 1) Apply this patch 2) Attempt to replicate using the steps above -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:22:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:22:24 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:23:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:23:12 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 [Bug 20891] Lists in staff don't load when \ was used in the description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:23:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:23:12 +0000 Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:23:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:23:58 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #64 from Josef Moravec --- (In reply to Nick Clemens from comment #63) > (In reply to Nick Clemens from comment #62) > > Created attachment 88748 [details] [review] [review] > > Bug 22511: Fix type role->roll > > Will fix List item->Lost item in the DB update on pushing Silly me, I oversee it... thanks Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:36:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:36:18 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #20 from Martin Renvoize --- Created attachment 88750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88750&action=edit Bug 22200: (follow-up) Wrap accountline creation in a transaction Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:41:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:41:02 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:41:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:41:09 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87346|0 |1 is obsolete| | --- Comment #128 from Ere Maijala --- Created attachment 88751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88751&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:41:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:41:15 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87347|0 |1 is obsolete| | --- Comment #129 from Ere Maijala --- Created attachment 88752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88752&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:41:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:41:20 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87348|0 |1 is obsolete| | --- Comment #130 from Ere Maijala --- Created attachment 88753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88753&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:41:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:41:25 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87349|0 |1 is obsolete| | --- Comment #131 from Ere Maijala --- Created attachment 88754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88754&action=edit Bug 20447: DBIX schema changes Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:41:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:41:30 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #132 from Ere Maijala --- Created attachment 88755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88755&action=edit Bug 20447: Use blessed objects and fix issues found during review -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:46:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:46:45 +0000 Subject: [Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:46:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:46:48 +0000 Subject: [Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88746|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 88756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88756&action=edit Bug 22669: Fix item editing on receiving an order Since commit 1253975389975a8ff11a9bb2ef84582aeb6bd08b Bug 21091: Move add item template JavaScript to a separate file items cannot longer be edited when receiving an order. When moving the code to the JS file, the JS variable "opisadd" was always set to "true": var opisadd = '[% opisadd | html %]'; Even if the TT variable is 0, opisadd will be "0", which is evaluated to true in Javascript To clean the situation it is easier to remove this variable and use "op" instead. Test plan: - Make sure acqcreateitem is set to "when placing an order" - Create a basket with some orders - Close the basket - Go to your vendor and receive an order - On the receive page, try to edit your item => Without the patch, the pop up page will open and then close, not allowing the item to be edited. => With this patch applied you will see the item edit form. Save and confirm that the parent window is updated with the new value (actually it's refreshed) Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:47:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:47:47 +0000 Subject: [Koha-bugs] [Bug 22762] Collection codes not displayed on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:47:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:47:49 +0000 Subject: [Koha-bugs] [Bug 22762] Collection codes not displayed on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88747|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 88757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88757&action=edit Bug 22762: Fix items.collection display on receiving Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). Test plan: - Set acqcreateitem to "when placing an order" - Receive an order with items => The "Collection code" column must be filled with the items.ccode value - Edit an item (You may need the patches on bug 22669) - Change the collection code value => The "Collection code" column must be filled with the new value Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:49:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:49:32 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #133 from Ere Maijala --- Thanks Josef, I believe I've addressed the comments in the latest patch. I'd rather leave editor unification to bug 21280 or a separate bug. Regarding changing the framework, I had in one version a new column for the framework type so that the selection list could be filtered, but I dropped it to keep the changes to minimum. That can be revisited later. I don't consider it a big issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:51:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:51:18 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:51:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:51:18 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:51:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:51:34 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #149 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:51:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:51:46 +0000 Subject: [Koha-bugs] [Bug 16232] Edit as new (duplicate) doesn't work correctly with Rancor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:52:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:52:01 +0000 Subject: [Koha-bugs] [Bug 19241] Items with status of hold show as available in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:52:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:52:12 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:52:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:52:25 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:52:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:52:53 +0000 Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #35 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:53:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:53:05 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:52:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:52:39 +0000 Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:56:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:56:19 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost after sorting, faceting or paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:56:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:56:34 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #65 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:56:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:56:47 +0000 Subject: [Koha-bugs] [Bug 22551] Stray "//" appears at bottom of opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:56:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:56:59 +0000 Subject: [Koha-bugs] [Bug 22556] Add ability to quickly filter funds/budgets by library on the Acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:57:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:57:14 +0000 Subject: [Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:58:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:58:15 +0000 Subject: [Koha-bugs] [Bug 22723] Syntax error on confess call in Koha/MetadataRecord/Authority.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:58:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:58:20 +0000 Subject: [Koha-bugs] [Bug 21851] Improve style of sidebar forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21851 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:57:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:57:57 +0000 Subject: [Koha-bugs] [Bug 22664] Link basket name and basket group name instead of the, often short, basket numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:58:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:58:29 +0000 Subject: [Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #24 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:58:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:58:42 +0000 Subject: [Koha-bugs] [Bug 22734] Fund not marked as mandatory when ordering from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:58:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:58:54 +0000 Subject: [Koha-bugs] [Bug 22739] Self check in module JS breaks if SelfCheckInTimeout is unset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22739 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 13:59:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 11:59:37 +0000 Subject: [Koha-bugs] [Bug 22743] OverDrive results page is missing overdrive-login include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:00:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:00:14 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:00:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:00:18 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88063|0 |1 is obsolete| | --- Comment #5 from Ere Maijala --- Created attachment 88758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88758&action=edit Bug 22524: Fix publication date search with Elasticsearch Also fixes the mappings.yaml to use correct field name (left over issue from bug 19575), so reset mappings and reindex before testing. Test plan: 1. Reset mappings and reindex biblios. 2. Check that tests in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t pass. 3. Try that all of the following year range type work in publication date search in advanced search: yyyy yyyy-yyyy -yyyy yyyy- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:02:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:02:05 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #140 from Ere Maijala --- I tested again, and applied cleanly on top of current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:02:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:02:47 +0000 Subject: [Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:02:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:02:57 +0000 Subject: [Koha-bugs] [Bug 22762] Collection codes not displayed on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:03:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:03:14 +0000 Subject: [Koha-bugs] [Bug 22764] More YUI grid cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:08:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:08:58 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:09:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:09:01 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88718|0 |1 is obsolete| | Attachment #88719|0 |1 is obsolete| | Attachment #88750|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 88759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88759&action=edit Bug 22200: Add Tests for change Unit tests to check for the addition of a credit of type 'FOR' when _FixOverduesOnReturn is called with $exemptfine set to true. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:09:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:09:09 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #22 from Kyle M Hall --- Created attachment 88760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88760&action=edit Bug 22200: Add credit when forgiving overdue Prior to this patch the exemptfine option for_FixOverduesOnReturn would directly set the overdue amount to 0 rather than creating an appropriate credit of the type forgiven and offseting it against the debt. Test Plan: 1) Find a checkout that is overdue with fines 2) Check the item in with the forgive fines option checked 3) Note that the users account details now shows the overdue as forgiven and a forgiven credit is added which matches the overdue amount (and is applied against it, i.e. both overdue and forgiven lines have 0 amountoutstanding). Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:09:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:09:12 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #23 from Kyle M Hall --- Created attachment 88761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88761&action=edit Bug 22200: (follow-up) Wrap accountline creation in a transaction Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:10:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:10:01 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88433|0 |1 is obsolete| | --- Comment #146 from Ere Maijala --- Created attachment 88762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88762&action=edit Bug 11529: Add new fields to biblio table Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:10:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:10:07 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88434|0 |1 is obsolete| | --- Comment #147 from Ere Maijala --- Created attachment 88763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88763&action=edit Bug 11529: Use new biblio fields whenever possible Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:10:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:10:13 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88435|0 |1 is obsolete| | --- Comment #148 from Ere Maijala --- Created attachment 88764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88764&action=edit Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:10:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:10:19 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88436|0 |1 is obsolete| | --- Comment #149 from Ere Maijala --- Created attachment 88765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88765&action=edit Bug 11529: Clean up subtitle usage Unify and clean up subtitle usage so that it's always used as a simple array and not the old hash structure. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:10:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:10:25 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88437|0 |1 is obsolete| | --- Comment #150 from Ere Maijala --- Created attachment 88766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88766&action=edit Bug 11529: Remove field mapping table and admin page Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:10:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:10:30 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88438|0 |1 is obsolete| | --- Comment #151 from Ere Maijala --- Created attachment 88767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88767&action=edit Bug 11529: DBIx schema changes Updates to Biblio schema and removal of FieldMapping schema. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:10:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:10:36 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88439|0 |1 is obsolete| | --- Comment #152 from Ere Maijala --- Created attachment 88768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88768&action=edit Bug 11529: Update kohafield in default framework only if not already set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:10:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:10:44 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88440|0 |1 is obsolete| | --- Comment #153 from Ere Maijala --- Created attachment 88769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88769&action=edit Bug 11529: Replace bibliosubtitle with biblio in all framework sql's. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:10:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:10:50 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88441|0 |1 is obsolete| | --- Comment #154 from Ere Maijala --- Created attachment 88770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88770&action=edit Bug 11529: Remove duplicate column name from select query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:10:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:10:57 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88442|0 |1 is obsolete| | --- Comment #155 from Ere Maijala --- Created attachment 88771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88771&action=edit Bug 11529: (follow-up) Remove manage_keywords2koha_mappings permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:11:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:11:05 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88443|0 |1 is obsolete| | --- Comment #156 from Ere Maijala --- Created attachment 88772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88772&action=edit Bug 11529: Add templates for biblio title display. Unify display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:11:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:11:33 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #157 from Ere Maijala --- Rebased again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:11:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:11:48 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |Future Status|Signed Off |In Discussion --- Comment #43 from Katrin Fischer --- I am moving this to "Milestone Future" and "In Discussion" - to be put back into the QA queue for 19.11 (see discussion during yesterday's Dev meeting) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:15:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:15:13 +0000 Subject: [Koha-bugs] [Bug 22621] Filters on subscription result list search the wrong column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:15:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:15:15 +0000 Subject: [Koha-bugs] [Bug 22621] Filters on subscription result list search the wrong column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88730|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 88773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88773&action=edit Bug 22621: Fix filters on subscription search results Caused by commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b Bug 18426: Allow to edit subscriptions in batch There is a shift caused by a hidden column, which make the filters searching on the previous column. Test plan: - Add 1+ searchable additional field for subscription - Create a new subscription - Search for subscriptions - Use the column filters to filter the results => The results must be filtered accordingly Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:41:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:41:44 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 14:41:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 12:41:47 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86199|0 |1 is obsolete| | --- Comment #3 from Claire Gravely --- Created attachment 88774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88774&action=edit Bug 12533: Improve authority search result display This patch implements a few changes in the way authority records are displayed in search results. - In most cases heading type is now displayed as a separate column in the table of search results. - The heading itself is now linked rather than a separate "details" link. In the authority search results for MARC editor plugins the heading link triggers a modal with the authority details instead of linking to a separate page. To test, apply the patch and go to Authorities. - Perform an authority search which will return results. - In the search results headings should be linked to the corresponding detail page. - There should be a separate column for heading type. - Go to Cataloging and create a new record using a framework which has a field linked to an authority type (e.g. 100a -> PERSO_NAME ). - Perform a search which will return results. - In the search results, clicking a heading link should trigger a modal window with the authority details. - Test multiple entries in the results and confirm that each time the correct data is loaded into the modal window. - Test the same process for a field which is linked to the unimarc_field_210c.pl plugin. - Go to Tools -> Batch record modification and submit multiple authority record numbers. - In the results list the heading should be linked correctly to the corresponding detail page. Heading type is not present in this view. - Perform the same test with batch record deletion. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:00:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:00:39 +0000 Subject: [Koha-bugs] [Bug 22010] RecordedBooks and OverDrive should check preferences over passing variables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88378|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 88775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88775&action=edit Bug 22010: Check preferences for ebook integration To test: 1 - Enable OverDrive and RecordedBooks (you can put anything in the prefs) 2 - Search on the opac - verify you get results (or search error) on first page of results' 3 - Go to second page of results - OD and RB are not searched 4 - Apply patch 5 - Verify nothing has changed If you have valid credentials: 1 - Enable RB prefs 2 - Sign in with an account that has an email matching your registered account for recordedbooks 3 - Confirm you RB account loads on opac-user.pl Otherwise: Read the patches, verify it all makes sense Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:00:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:00:37 +0000 Subject: [Koha-bugs] [Bug 22010] RecordedBooks and OverDrive should check preferences over passing variables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:04:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:04:04 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Keywords| |release-notes-needed --- Comment #27 from Martin Renvoize --- Non-trivial backport for a long standing issue. I'm taking the decision not to backport at the present time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:04:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:04:05 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Bug 22160 depends on bug 22330, which changed state. Bug 22330 Summary: Transfer limits should be respected for placing holds in staff interface and APIs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:04:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:04:11 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:05:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:05:00 +0000 Subject: [Koha-bugs] [Bug 12166] Improve display of hold charges in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:05:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:05:57 +0000 Subject: [Koha-bugs] [Bug 12166] Improve display of hold charges in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #23 from Martin Renvoize --- Non-trivial backport for long standing bug, choosing not to backport due to risk for regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:05:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:05:58 +0000 Subject: [Koha-bugs] [Bug 18352] Need barcode along with record details in fines section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18352 Bug 18352 depends on bug 12166, which changed state. Bug 12166 Summary: Improve display of hold charges in patron account https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:05:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:05:58 +0000 Subject: [Koha-bugs] [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628 Bug 22628 depends on bug 12166, which changed state. Bug 12166 Summary: Improve display of hold charges in patron account https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:06:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:06:04 +0000 Subject: [Koha-bugs] [Bug 12166] Improve display of hold charges in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:06:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:06:10 +0000 Subject: [Koha-bugs] [Bug 12166] Improve display of hold charges in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:06:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:06:59 +0000 Subject: [Koha-bugs] [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Martin Renvoize --- Depends upon 12166 not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:06:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:06:59 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Bug 21953 depends on bug 22628, which changed state. Bug 22628 Summary: FFOR and VOID show up as codes to end users in OPAC, SCO and staff https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:07:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:07:07 +0000 Subject: [Koha-bugs] [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:07:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:07:26 +0000 Subject: [Koha-bugs] [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:09:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:09:48 +0000 Subject: [Koha-bugs] [Bug 19648] Repeated positions and some options missing in cataloguing plugin 007 (XML file) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:11:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:11:26 +0000 Subject: [Koha-bugs] [Bug 22597] Remove "more_subfields_xml" from GetPatronInfo response (xml broken) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:12:13 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED --- Comment #41 from Martin Renvoize --- Long standing bug depends on bug 22628 not in 18.11.x series.. will not be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:12:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:12:14 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Bug 22521 depends on bug 21953, which changed state. Bug 21953 Summary: Term "Lost item" is untranslatable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:13:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:13:24 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:17:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:17:18 +0000 Subject: [Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:17:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:17:24 +0000 Subject: [Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:17:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:17:47 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #23 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:17:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:17:47 +0000 Subject: [Koha-bugs] [Bug 22584] Add YAML support for Codemirror In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Bug 22584 depends on bug 21582, which changed state. Bug 21582 Summary: Use CodeMirror for *UserJS & *UserCSS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:17:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:17:54 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:18:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:18:03 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:18:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:18:14 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at ptfs-europe.com --- Comment #4 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by Marjorie Barry-Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:18:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:18:31 +0000 Subject: [Koha-bugs] [Bug 21890] Allow forgotten password functionality to be limited by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #50 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:18:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:18:31 +0000 Subject: [Koha-bugs] [Bug 10796] Allow password changes for logged in OPAC users by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Bug 10796 depends on bug 21890, which changed state. Bug 21890 Summary: Allow forgotten password functionality to be limited by patron category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:18:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:18:38 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 --- Comment #5 from PTFS Europe Sandboxes --- Created attachment 88776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88776&action=edit Bug 12533: Improve authority search result display This patch implements a few changes in the way authority records are displayed in search results. - In most cases heading type is now displayed as a separate column in the table of search results. - The heading itself is now linked rather than a separate "details" link. In the authority search results for MARC editor plugins the heading link triggers a modal with the authority details instead of linking to a separate page. To test, apply the patch and go to Authorities. - Perform an authority search which will return results. - In the search results headings should be linked to the corresponding detail page. - There should be a separate column for heading type. - Go to Cataloging and create a new record using a framework which has a field linked to an authority type (e.g. 100a -> PERSO_NAME ). - Perform a search which will return results. - In the search results, clicking a heading link should trigger a modal window with the authority details. - Test multiple entries in the results and confirm that each time the correct data is loaded into the modal window. - Test the same process for a field which is linked to the unimarc_field_210c.pl plugin. - Go to Tools -> Batch record modification and submit multiple authority record numbers. - In the results list the heading should be linked correctly to the corresponding detail page. Heading type is not present in this view. - Perform the same test with batch record deletion. Signed-off-by: Claire Gravely Signed-off-by: Marjorie Barry-Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:18:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:18:39 +0000 Subject: [Koha-bugs] [Bug 21890] Allow forgotten password functionality to be limited by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:18:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:18:28 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:19:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:19:20 +0000 Subject: [Koha-bugs] [Bug 10796] Allow password changes for logged in OPAC users by patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED --- Comment #20 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:22:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:22:49 +0000 Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #62 from Martin Renvoize --- Pushed to 18.11.x series for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:24:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:24:25 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:26:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:26:19 +0000 Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #33 from Katrin Fischer --- Hi Hayley and Alex, bug 14576 was pushed now and I think it would make sense to have a look and make both checkout and checkin features match in functionality. I am a little worried about the blanking. Usually when CART is used you don't want to blank, but to set back to 'permanent location' (that can be blank if none was assigned before). There seems to be some mismatch here, as we still have BlankShelvingLocation but then also UpdateItemLocationOnCheckout. I feel like this needs a bit more work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:26:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:26:29 +0000 Subject: [Koha-bugs] [Bug 22652] Editing Course reserves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:26:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:26:33 +0000 Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on checkout based on syspref values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Blank item shelving |Blank item shelving |location (952$c) on issue |location (952$c) on |and return based on syspref |checkout based on syspref |values |values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:27:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:27:39 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:27:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:27:42 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87668|0 |1 is obsolete| | --- Comment #13 from Ere Maijala --- Created attachment 88777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88777&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:27:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:27:46 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87669|0 |1 is obsolete| | --- Comment #14 from Ere Maijala --- Created attachment 88778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88778&action=edit Bug 22592: Fixes to index scan Makes sure the scan term is displayed and redirection to record page is not used with index scan for a single result. Also adds a submit button so that you can submit a change for selected index or term easier. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:27:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:27:56 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:27:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:27:54 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:27:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:27:59 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:28:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:28:01 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:28:42 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #24 from Tom?s Cohen Arazi --- Created attachment 88779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88779&action=edit Bug 22200: Add Tests for change Unit tests to check for the addition of a credit of type 'FOR' when _FixOverduesOnReturn is called with $exemptfine set to true. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:28:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:28:46 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #25 from Tom?s Cohen Arazi --- Created attachment 88780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88780&action=edit Bug 22200: Add credit when forgiving overdue Prior to this patch the exemptfine option for_FixOverduesOnReturn would directly set the overdue amount to 0 rather than creating an appropriate credit of the type forgiven and offseting it against the debt. Test Plan: 1) Find a checkout that is overdue with fines 2) Check the item in with the forgive fines option checked 3) Note that the users account details now shows the overdue as forgiven and a forgiven credit is added which matches the overdue amount (and is applied against it, i.e. both overdue and forgiven lines have 0 amountoutstanding). Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:28:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:28:50 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #26 from Tom?s Cohen Arazi --- Created attachment 88781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88781&action=edit Bug 22200: (follow-up) Wrap accountline creation in a transaction Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:29:06 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #17 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:31:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:31:12 +0000 Subject: [Koha-bugs] [Bug 22688] TT plugin for pickup locations code wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22688 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #20 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:35:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:35:44 +0000 Subject: [Koha-bugs] [Bug 22069] Log viewer not displaying item renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on| |22363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 [Bug 22363] Move C4::Logs::GetLogs to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:35:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:35:44 +0000 Subject: [Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22069 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069 [Bug 22069] Log viewer not displaying item renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:36:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:36:04 +0000 Subject: [Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:36:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:36:14 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #17 from Tom?s Cohen Arazi --- I like the idea of a more generic fallback exception handling method. I'm not sure how it fits what we already do in Koha::REST::V1::Auth::under. I will mark it as blocked until bug 18205 moves to avoid confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:47:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:47:06 +0000 Subject: [Koha-bugs] [Bug 12490] Choose notices to receive in copy (bcc) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12490 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Choose notices to receive |Choose notices to receive |in copy with |in copy (bcc) |OverdueNoticebcc | --- Comment #2 from Marjorie Barry-Vila --- Hi, I changed the title of the ticket because ultimately, it would be nice to choose which notice we want to receive a copy, whether it is overdue notice or any other notice. The notice code could be written in a system preference. Regards Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:47:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:47:56 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com --- Comment #19 from Claire Gravely --- Baskets with uncertain pricing still get a close basket option on the basket summary page. Instead they are marked bold and have dark red text. Everything else looks good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:48:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:48:02 +0000 Subject: [Koha-bugs] [Bug 22069] Log viewer not displaying item renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #15 from Martin Renvoize --- Re-implemented for 18.11.x series as we don't have the refactor that took place in bug 22363. Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:50:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:50:12 +0000 Subject: [Koha-bugs] [Bug 22770] New: Typo in German translation for Greek in language pull down Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 Bug ID: 22770 Summary: Typo in German translation for Greek in language pull down Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- There is a typo in the German translation for the Greek language: 241 INSERT INTO language_descriptions(subtag, type, lang, description) 242 VALUES ( 'el', 'language', 'de', 'Griechisch (Moern [1453- ]'); Moern should be: Modern -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:50:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:50:23 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:50:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:50:25 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 --- Comment #1 from Owen Leonard --- Created attachment 88782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88782&action=edit Bug 22424: Add search by all lost statuses to item search This patch changes the item search form so that searching by lost status includes options for all lost authorised values instead of just "yes" or "no." To test you should have multiple authorized values for LOST. - Apply the patch and open the item search form. - Test searches which limit by lost status. Confirm that results are correctly limited. - Confirm that lost statuses are correctly displayed in the search results. - Confirm that in the search results table, the column header for "Lost" includes a dropdown menu for filtering by all available authorized values for lost. - Test the CSV export function and confirm that lost status is correctly exported. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:51:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:51:28 +0000 Subject: [Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 --- Comment #1 from Katrin Fischer --- And ( needs a closing ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 15:52:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 13:52:19 +0000 Subject: [Koha-bugs] [Bug 22770] Typo in German translation for Greek in language pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22770 --- Comment #2 from Katrin Fischer --- Griechisch (Modern 1453-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:03:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:03:31 +0000 Subject: [Koha-bugs] [Bug 22090] Cash register report missing data in CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22090 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:06:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:06:16 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |--- Status|CLOSED |REOPENED --- Comment #9 from Katrin Fischer --- I am still seeing this issue, tested in 18.11: To test: - Create a record using umlauts ??? - Put the record in your cart in OPAC - Use the Download button and MARC as format - Try to reimport the record or use MarcEdit to create a mrk - Verify the Umlauts don't appear correctly Example: Deutsche ?bersetzung turns into: Deutsche {DC}bersetzung -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:05:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:05:53 +0000 Subject: [Koha-bugs] [Bug 22474] Authority and biblio field mapping improperly shared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22474 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:06:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:06:28 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Broken diacritics on |Broken diacritics on |records exported as MARC |records exported as MARC |from cart on reimport |from cart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:07:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:07:51 +0000 Subject: [Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #8 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:08:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:08:29 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #43 from Kyle M Hall --- (In reply to Martin Renvoize from comment #42) > I'm confused.. was that last patch a followup to silence the spurious > warnings on koha-testing-docker after this bug was applied? > > I get the feeling we should probably make the logpath writable in > koha-testing-docker as a resolution (I like being told loudly that logging > isn't working, which this bug actually introduced). > > Either way.. the followup doesn't appear to resolve the problem. The followup match stops the unit tests from failing and resolves circular dependencies. Can you post an example of the warnings you are seeing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:11:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:11:53 +0000 Subject: [Koha-bugs] [Bug 21284] ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21284 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin SOMERS --- use C4::Reserves qw(AddReserve CanBookBeReserved CanItemBeReserved IsAvailableForItemLevelRequest); use C4::Context; use C4::AuthoritiesMarc; +use C4::Reserves; use XML::Simple; I think this is a mistake, use C4::Reserves already exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:12:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:12:22 +0000 Subject: [Koha-bugs] [Bug 22771] New: Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 Bug ID: 22771 Summary: Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21) Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at collecto.ca Target Milestone: --- Hi, In marc21, second indicator in field 245 contains number of nonfiling characters. Sort by title (A-Z, Z-A) with ElasticSearch do not considerate this number. Has this problem already been reported? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:15:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:15:46 +0000 Subject: [Koha-bugs] [Bug 22695] Remove non-XSLT search results view from the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Marking as an enhancement as it's a cleanup piece which 'might' surprise users of the stable branch. Will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:19:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:19:31 +0000 Subject: [Koha-bugs] [Bug 21975] Unnecessary substitutions in automatic item modification by age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #24 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:32:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:32:50 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:32:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:32:54 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86961|0 |1 is obsolete| | Attachment #86962|0 |1 is obsolete| | Attachment #86963|0 |1 is obsolete| | --- Comment #15 from Claire Gravely --- Created attachment 88783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88783&action=edit [SIGNED-OFF] Bug 22053: create unit tests Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:32:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:32:57 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #16 from Claire Gravely --- Created attachment 88784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88784&action=edit [SIGNED-OFF] Bug 22053: ability to enable/disable some plugins Test plan: - apply this patch(es), - launch an updatedabase, - go to plugins/plugins-home.pl and deal with enable/disable method - install a plugin like KitchenSink https://github.com/bywatersolutions/koha-plugin-kitchen-sink - once installed, the plugin change the background color of the staff client to orange. - disable the plugin, - background color should be set back to the original one Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:33:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:33:00 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #17 from Claire Gravely --- Created attachment 88785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88785&action=edit [SIGNED-OFF] Bug 22053: update database Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:48:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:48:34 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88749|0 |1 is obsolete| | --- Comment #12 from Liz Rea --- Created attachment 88786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88786&action=edit Bug 22715: Searching for patrons with "" in the circulation note hangs patron search To replicate: Edit a patron to have a circ note, include quoted text in it, such as "this is quoted string" Go to the patron search, search for a set of results that would include the patron with the quotes in the note Enjoy looking at "Processing" for forever. Test Plan: 1) Apply this patch 2) Attempt to replicate using the steps above Signed-off-by: Liz Rea I took this a step further and used for my test note and this worked just fine. YAY. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:48:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:48:32 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 16:51:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 14:51:00 +0000 Subject: [Koha-bugs] [Bug 19648] Repeated positions and some options missing in cataloguing plugin 007 (XML file) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19648 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- deciding not to backport this one to the 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:22:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:22:08 +0000 Subject: [Koha-bugs] [Bug 22772] New: Menu link hover color incorrect in OPAC language choosers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 Bug ID: 22772 Summary: Menu link hover color incorrect in OPAC language choosers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 22274 Target Milestone: --- The hover color is incorrect in the OPAC's language selection menus. In the footer it's blue, in the header it's the same color as the background (so, invisible). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 [Bug 22274] Self-checkout pages not covered by OPAC CSS changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:22:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:22:08 +0000 Subject: [Koha-bugs] [Bug 22274] Self-checkout pages not covered by OPAC CSS changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 [Bug 22772] Menu link hover color incorrect in OPAC language choosers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:22:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:22:29 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88393|0 |1 is obsolete| | --- Comment #20 from Nick Clemens --- Created attachment 88787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88787&action=edit Bug 21364: (follow-up) Check for standing status and uncertain prices Fetch 'uncertainprices' when getting basket info. A side effect is that styling on baskets with uncertain prices is restored by this bug. They will appear in red To test: 1 - Add an order with an uncertainprice to the basket 2 - Return to vendor baskets view 3 - Note the actions now include "Uncertain prices" 4 - Click that, resolve the uncertain prcie 5 - Return to vendor basket view 6 - Note you can now close the basket, but don't 7 - Edit the basket, mark it as standing 8 - Return to vendor basket view 9 - Note you cannot close the basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:23:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:23:32 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #44 from Martin Renvoize --- Comment on attachment 87993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87993 Bug 15253: Add Koha::Logger based logging for SIP2 Review of attachment 87993: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15253&attachment=87993) ----------------------------------------------------------------- ::: Koha/Logger.pm @@ +159,5 @@ > if ( $l =~ /(OPAC|INTRANET)\.filename\s*=\s*(.*)\s*$/i ) { > > # we only check the two default logfiles, skipping additional ones > + if ( !-w $2 ) { > + warn "Log file $2 is not writable!"; It's this line that's fireing.. I think we must have been talking at cross purposes. Because koha-testing-docker doesn't have a writable logdir by default if you apply this patch and then run any tests that happen to use a module that uses Koha::Logger you now spam the screen with the above warning. It's just noise rather than a failure.. but it can make the test results rather cumbersome to read.. that's what I'm getting at. I think Tomas is now on the case from the koha-testing-docker side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:24:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:24:28 +0000 Subject: [Koha-bugs] [Bug 22773] New: Bulk Close invoices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Bug ID: 22773 Summary: Bulk Close invoices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The invoice screen shows all invoices and is not filtered by open and closed. We propose to: 1. Create a closed tab on the invoices view. 2. Move all closed invoices to a closed tab on the invoices view. All open invoices would remain in the open tab until closed. This would provide the filtering needed and clean up the display for users. 3. Allow users to select multiple invoices on the Open tab and then provide a button on the screen to 'close selected invoices' in bulk. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:24:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:24:39 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:26:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:26:28 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bulk Close invoices |Bulk Close invoices and | |Filter invoice view | |(open/closed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:27:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:27:49 +0000 Subject: [Koha-bugs] [Bug 22297] Limit Purchase Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22297 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |joy at bywatersolutions.com Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:27:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:27:59 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88787|0 |1 is obsolete| | --- Comment #21 from Nick Clemens --- Created attachment 88788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88788&action=edit Bug 21364: (follow-up) Check for standing status and uncertain prices Fetch 'uncertainprices' when getting basket info. A side effect is that styling on baskets with uncertain prices is restored by this bug. They will appear in red To test: 1 - Add an order with an uncertainprice to the basket 2 - Return to vendor baskets view 3 - Note the actions now include "Uncertain prices" 4 - Click that, resolve the uncertain prcie 5 - Return to vendor basket view 6 - Note you can now close the basket, but don't 7 - Edit the basket, mark it as standing 8 - Return to vendor basket view 9 - Note you cannot close the basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:30:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:30:14 +0000 Subject: [Koha-bugs] [Bug 22772] Menu link hover color incorrect in OPAC language choosers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:30:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:30:16 +0000 Subject: [Koha-bugs] [Bug 22772] Menu link hover color incorrect in OPAC language choosers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 --- Comment #1 from Owen Leonard --- Created attachment 88789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88789&action=edit Bug 22772: Menu link hover color incorrect in OPAC language choosers This patch makes a few corrections to OPAC CSS to fix colors in the language menus. To test, apply the patch and rebuild the OPAC CSS. - Enable multiple languages in the OPAC, including more than one language "variation" (fr-FR, fr-CA). - Set the OpacLangSelectorMode preference to "both." - In the OPAC, test the language menu in both the header and footer. When you hover over the sub-menu items the background should be green and the text color white. - Perform the same test in the self checkout and self checkin interfaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:36:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:36:07 +0000 Subject: [Koha-bugs] [Bug 22774] New: Limit Purchase Suggestion in a specified Time period Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Bug ID: 22774 Summary: Limit Purchase Suggestion in a specified Time period Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Many libraries would like the ability to limit purchase suggestions made by a patron to a certain number over a specified period. i.e. 3 suggestions every 30 days. The MaxOpenSuggestions works to limit 'open' suggestions, but does not take into account the total suggestions made by patrons. We need the ability to limit the number of suggestions a patron can make in a "rolling number of weeks" (over last X weeks). The variables for this would be the number of suggestions and the number of rolling weeks. Suggested system preference "MaxTotalSuggestions" with two variables. First is the number of total suggestions and the second is the number of days. e.g. MaxTotalSuggestion Allow 3 total suggestions over 30 days. (user configures the numbers to suit their policy) Result: Users are prevented from making any suggestions if the total suggestions (pending/checked/accepted/rejected) they've made over the last X days is equal to the max specified. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:39:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:39:22 +0000 Subject: [Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:39:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:39:25 +0000 Subject: [Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82980|0 |1 is obsolete| | Attachment #83147|0 |1 is obsolete| | --- Comment #13 from Liz Rea --- Created attachment 88790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88790&action=edit Bug 21716: Escape publisher in item search To prevent endless processing errors. To test: * create a biblio with a publisher with a backslash - i.e. 260$b with graham\lineham * do an item search that will include that title in the results * wait forever, because it won't work. * apply this patch * repeat steps, notice that you a. get results b. your result is listed with it's correct publisher * rejoice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:49:31 +0000 Subject: [Koha-bugs] [Bug 22734] Fund not marked as mandatory when ordering from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #8 from Nick Clemens --- Erk, I missed an issue here: If the funds are defined per item we shouldn't have to supply a fund for the order as a whole. This will need a followup to take that into account or cannot be in the release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 17:50:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 15:50:53 +0000 Subject: [Koha-bugs] [Bug 22734] Fund not marked as mandatory when ordering from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #9 from Nick Clemens --- Created attachment 88791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88791&action=edit Fund defined for all item(s) shoudln't need for order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:12:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:12:04 +0000 Subject: [Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |alex.arnaud at biblibre.com CC| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:21:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:21:08 +0000 Subject: [Koha-bugs] [Bug 22775] New: It would be nice to be able to get to 'add to basket' directly from Tools > Manage staged MARC records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22775 Bug ID: 22775 Summary: It would be nice to be able to get to 'add to basket' directly from Tools > Manage staged MARC records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- One can add to a basket via acquisitions > vendors > basket > add to basket and then selecting 'from staged file'. It would be nice to be able to go in the opposite direction too.. having a button on the 'Manage staged MARC files' screen table to be able to select a basket to add your items to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:24:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:24:39 +0000 Subject: [Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 --- Comment #16 from Alex Arnaud --- All is working here and i don't have any QA warning. But i have concerns about Bug 20589. This last disable searching on _all and could make this one useless. Am i right ? if (yes) { Ere, David: Is there something planned to build these 2 bugs together ? } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:30:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:30:06 +0000 Subject: [Koha-bugs] [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:30:09 +0000 Subject: [Koha-bugs] [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 --- Comment #1 from Nick Clemens --- Created attachment 88792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88792&action=edit Bug 22713: Pass replacement price in to order if defined by MarcItemFieldsToOrder To test: 1 - Have AcqCreateItems set to 'On ordering' (or set in a basket) 2 - Define MARCItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 970$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$g replacementprice: 975$p 3 - Have a marc record with some order info defined as above, including a replacementprice 4 - Add to basket - > from a new file 5 - Don't check for duplicates, add the order 6 - Note the order has no replacementprice, but the item does 7 - Close basket, receive order, do not enter a new replacement price 8 - Note the items replacement price is clear 9 - Apply patch 10 - Repeat 11 - Note when order added to basket it has a replacement price 12 - Note when order is received the replacement price is populated and passed into item correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:30:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:30:52 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88138|0 |1 is obsolete| | --- Comment #20 from Agust?n Moyano --- Created attachment 88793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88793&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) run perl installer/data/mysql/updatedatabase.pl SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:30:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:30:55 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88139|0 |1 is obsolete| | --- Comment #21 from Agust?n Moyano --- Created attachment 88794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88794&action=edit Bug 22284: (follow-up) Add schema modifications Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:30:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:30:59 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88140|0 |1 is obsolete| | --- Comment #22 from Agust?n Moyano --- Created attachment 88795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88795&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:31:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:31:02 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88142|0 |1 is obsolete| | --- Comment #23 from Agust?n Moyano --- Created attachment 88796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88796&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:31:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:31:06 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88143|0 |1 is obsolete| | --- Comment #24 from Agust?n Moyano --- Created attachment 88797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88797&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:31:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:31:09 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88144|0 |1 is obsolete| | --- Comment #25 from Agust?n Moyano --- Created attachment 88798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88798&action=edit Bug 22284: New messages in reserve/request.tt This patch adds new messages to 'Hold' column in 'Place a hold on a specific item' table Those messages are 1) Cannot place hold from patrons's library: this message appears when patron's homebranch is not in item's hold group 2) Pickup library is not in hold group: self explanatory To test: 1) In library groups add a root group and check it as hold group. 2) Add a library to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 4) Search a patron from a different library than step 2, select one and click 'search to hold' 5) Search by location for items in the library of step 2 6) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column 7) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 4 to 6 SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Pickup library is not in hold group" in 'Hold' column 9) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:31:13 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88145|0 |1 is obsolete| | --- Comment #26 from Agust?n Moyano --- Created attachment 88799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88799&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:31:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:31:17 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88369|0 |1 is obsolete| | --- Comment #27 from Agust?n Moyano --- Created attachment 88800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88800&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:31:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:31:20 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88561|0 |1 is obsolete| | --- Comment #28 from Agust?n Moyano --- Created attachment 88801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88801&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:31:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:31:24 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #29 from Agust?n Moyano --- Created attachment 88802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88802&action=edit Bug 22284: (follow-up) fix test count after merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:32:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:32:57 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #30 from Agust?n Moyano --- (In reply to Agust?n Moyano from comment #29) > Created attachment 88802 [details] [review] > Bug 22284: (follow-up) fix test count after merge Bad bug title.. wasn't merge.. was rebase Sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 18:54:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 16:54:44 +0000 Subject: [Koha-bugs] [Bug 22776] New: Remove 5 periods on tools-home.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22776 Bug ID: 22776 Summary: Remove 5 periods on tools-home.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- On the Tools homepage, we're inconsistent about whether or not we put periods at the end of tool descriptions. The following tools have periods: - Patron lists - Patron clubs (has two periods) - Comments - Stage MARC records for import We should remove these periods for consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 19:09:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 17:09:27 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #13 from Katrin Fischer --- I am in doubt about the filters used here: "[% data.borrowernotes | html_line_break | collapse | html | $To %]" html_line_break = turns line breaks into
    OK collapse = removes additional whitespace - OK html = escapes... so it shoudl escape the
    tags $To = ? We had other cases where we needed to switch to html html_line_break to make things work. Can someone help me out here an explain? That said.... it DOES work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 19:13:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 17:13:56 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer --- Ok... actually it's me: I was testing without the patch applied. It did work. But now with the patch, I have: TEst
    das
    Hier\ Instead of the correct display. Without the patch (just master), I get: TEst (in bold) das Hier\ Help? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 19:32:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 17:32:08 +0000 Subject: [Koha-bugs] [Bug 22776] Remove 5 periods on tools-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22776 --- Comment #1 from Nick Clemens --- Created attachment 88803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88803&action=edit Bug 22776: Remove some periods for consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 19:47:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 17:47:36 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 19:47:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 17:47:38 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #15 from Nick Clemens --- Created attachment 88804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88804&action=edit Bug 22715: Remove extraneous html filter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 19:52:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 17:52:43 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #16 from Nick Clemens --- (In reply to Katrin Fischer from comment #13) > I am in doubt about the filters used here: > > "[% data.borrowernotes | html_line_break | collapse | html | $To %]" I think we just need one html filter - the link break should take care of filtering: [% data.borrowernotes | html_line_break | collapse | $To %] Alternately: If we don't want to process any of the html here but add line breaks: [% data.borrowernotes | html | html_line_break | collapse | $To %] I suspect we do expect 'bold' etc to be processed though, I imagine some libraries could have links here -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 20:04:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 18:04:30 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #17 from Katrin Fischer --- (In reply to Nick Clemens from comment #16) > (In reply to Katrin Fischer from comment #13) > > I am in doubt about the filters used here: > > > > "[% data.borrowernotes | html_line_break | collapse | html | $To %]" > > I think we just need one html filter - the link break should take care of > filtering: > [% data.borrowernotes | html_line_break | collapse | $To %] > > Alternately: > If we don't want to process any of the html here but add line breaks: > [% data.borrowernotes | html | html_line_break | collapse | $To %] > > I suspect we do expect 'bold' etc to be processed though, I imagine some > libraries could have links here I don't think that html_line_break does any escapign beyond changing the new lines. I think actually there should be a $raw as we just allowed to add HTML to that field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 20:11:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 18:11:36 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 20:19:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 18:19:01 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #18 from Nick Clemens --- (In reply to Katrin Fischer from comment #17) > I don't think that html_line_break does any escapign beyond changing the new > lines. I think actually there should be a $raw as we just allowed to add > HTML to that field. I don't think we need a raw since we are filtering in other ways, I think we do want the link breaks, so this works as expected, no? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 20:39:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 18:39:36 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #19 from Katrin Fischer --- I think the $raw would have no other effect than showing we want HTML there. We are not really filtering.. we are adding and removing whitespace. Not sure what $To all does. Need another opinion, maybe Jonathan? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 20:47:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 18:47:51 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 20:47:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 18:47:55 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88786|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 88805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88805&action=edit Bug 22715: Searching for patrons with "" in the circulation note hangs patron search To replicate: Edit a patron to have a circ note, include quoted text in it, such as "this is quoted string" Go to the patron search, search for a set of results that would include the patron with the quotes in the note Enjoy looking at "Processing" for forever. Test Plan: 1) Apply this patch 2) Attempt to replicate using the steps above Signed-off-by: Liz Rea I took this a step further and used for my test note and this worked just fine. YAY. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 20:47:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 18:47:59 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88804|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 88806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88806&action=edit Bug 22715: Remove extraneous html filter Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 20:52:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 18:52:23 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 20:52:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 18:52:26 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88777|0 |1 is obsolete| | Attachment #88778|0 |1 is obsolete| | --- Comment #15 from Michal Denar --- Created attachment 88807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88807&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 20:52:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 18:52:29 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #16 from Michal Denar --- Created attachment 88808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88808&action=edit Bug 22592: Fixes to index scan Makes sure the scan term is displayed and redirection to record page is not used with index scan for a single result. Also adds a submit button so that you can submit a change for selected index or term easier. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:25:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:25:01 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:25:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:25:08 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85871|0 |1 is obsolete| | --- Comment #41 from Nick Clemens --- Created attachment 88810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88810&action=edit Bug 17168: (follow-up) Tidy, clean params/options, use date tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:25:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:25:12 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85872|0 |1 is obsolete| | --- Comment #42 from Nick Clemens --- Created attachment 88811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88811&action=edit Bug 17168: (follow-up) Clean up QA errors Cleanup variable names Remove Dumper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:25:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:25:15 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85873|0 |1 is obsolete| | --- Comment #43 from Nick Clemens --- Created attachment 88812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88812&action=edit Bug 17168: (follow-up) Address QA concerns and update for strict mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:25:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:25:18 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #44 from Nick Clemens --- Created attachment 88813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88813&action=edit Bug 17168: Add Koha:Script -cron, remove Dumper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:25:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:25:22 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #45 from Nick Clemens --- Created attachment 88814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88814&action=edit Bug 17168: Remove j2a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:25:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:25:04 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85870|0 |1 is obsolete| | --- Comment #40 from Nick Clemens --- Created attachment 88809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88809&action=edit Bug 17168: Add a command line script for updating patron category based on status This patch adds a new script update_patrons_category.pl which allows for updating patron categories in a batch upon meeting provided criteria. This script additionally can replace j2a.pl. To test: 1 - perl update_patrons_category.pl -h 2 - Ensure help text makes sense and covers all options 3 - Test converting patrons supplying only fromcat and tocat perl update_patrons_category.pl -f PT -t J -v --confirm perl update_patrons_category.pl -f J -t PT -v --confirm 4 - All patrons should have been switched to and from Juveniles 5 - Try without --confirm switch perl update_patrons_category.pl -f PT -t J -v 6 - Should list all patrons but not update 7 - Set the age for juvenile patrons to be outside the range provided in categories (or set the upper age limit for juveniles to '2') 8 - Test with verbosity and with without --confirm perl update_patrons_category.pl -f J -a -t PT -v perl update_patrons_category.pl -f J -a -t PT -v --confirm 9 - Repeat above and verify linked/unlinked guarantors are removed in above scenario 10 - Test various fine and registration limits 11 - Test matching on specific fields i.e. --field surname=acosta 12 - Sign off Sponsored by: Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:48:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:48:24 +0000 Subject: [Koha-bugs] [Bug 22777] New: Google OpenId Connect Internal server error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 Bug ID: 22777 Summary: Google OpenId Connect Internal server error Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Target Milestone: --- Internal Server Error when trying to login with Google OpenID Connection. See file attached please. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:49:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:49:43 +0000 Subject: [Koha-bugs] [Bug 22778] New: Suggestions with no "suggester" can cause errors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 Bug ID: 22778 Summary: Suggestions with no "suggester" can cause errors Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- If one tries to modify a suggestion that has no suggester you will get the following error: Can't call method "lang" on an undefined value at /usr/share/koha/lib/C4/Suggestions.pm line 506 Koha assumes that every suggestion has a borrowernumber in suggestedb.y -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:49:51 +0000 Subject: [Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:49:58 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #1 from Claudio --- Created attachment 88815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88815&action=edit OpenID connect internal server error Google OpenID Connect sysprefs configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:52:38 +0000 Subject: [Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 --- Comment #1 from Kyle M Hall --- Created attachment 88816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88816&action=edit Bug 22778: Suggestions with no "suggester" can cause errors If one tries to modify a suggestion that has no suggester you will get the following error: Can't call method "lang" on an undefined value at /usr/share/koha/lib/C4/Suggestions.pm line 506 Koha assumes that every suggestion has a borrowernumber in suggestedby Test Plan: 1) Create a suggestion with an unpopulated suggestedby 2) Attempt to modify that suggestion 3) Note the error 4) Apply this patch 5) Restart all teh things 6) Attempt to modify that suggestion 7) No error! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:52:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:52:36 +0000 Subject: [Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:53:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:53:20 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #2 from Claudio --- No error with existing patrons. This occurs when patrons are created automatically, i.e., when GoogleOpenIDConnectAutoRegister is set to "Allow". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:56:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:56:09 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #3 from Claudio --- Thers's no Koha logs' useful information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 21:56:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 19:56:33 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 22:24:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 20:24:54 +0000 Subject: [Koha-bugs] [Bug 22779] New: Simplify serials form to single page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22779 Bug ID: 22779 Summary: Simplify serials form to single page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- Right now this is a 2 column, 2 step page, I think this can all be done on a single page. Additionally we use alerts instead of modals, we prevent submission when a vendor is not entered, even though it is not required, and we force the user to click a button to predict the serial. I think we can greatly simplify this form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 22:25:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 20:25:40 +0000 Subject: [Koha-bugs] [Bug 22779] Simplify serials form to single page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22779 --- Comment #1 from Nick Clemens --- Created attachment 88817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88817&action=edit Bug 22779: WIP POC combining the page and making the prediction automatic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 22:26:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 20:26:48 +0000 Subject: [Koha-bugs] [Bug 22779] Simplify serials form to single page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22779 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, bwsdonna at gmail.com, | |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 23:27:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 21:27:33 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Liz Rea --- Hi Agustin, I seem to be getting test failures like these on these current patches, have a look please? Functionally, the dev seems to be working up to this point of testing, so don't stress too much about that. :) Cheers, Liz (In reply to Josef Moravec from comment #16) > Hi August?n, > I started to testing, overall it is looking good, I will continue on that, > but just found some issues, which should be addressed: > > prove t/db_dependent/Reserves.t > > # Failed test 'CheckReserves Test 1' > # at t/db_dependent/Reserves.t line 132. > # got: '' > # expected: 'Reserved' > > # Failed test 'CheckReserves() include reserve_id in its response' > # at t/db_dependent/Reserves.t line 134. > > # Failed test 'CheckReserves Test 2' > # at t/db_dependent/Reserves.t line 137. > # got: '' > # expected: 'Reserved' > > # Failed test 'CheckReserves Test 3' > # at t/db_dependent/Reserves.t line 140. > # got: '' > # expected: 'Reserved' > t/db_dependent/Reserves.t .................... 59/60 # Looks like you failed > 4 tests of 60. > t/db_dependent/Reserves.t .................... Dubious, test returned 4 > (wstat 1024, 0x400) > Failed 4/60 subtests > > > prove t/db_dependent/Holds.t > # Failed test '$branch_1 patron allowed to reserve $branch_2 item with > IndependentBranches OFF (bug 2394)' > # at t/db_dependent/Holds.t line 270. > > # Failed test '$branch_1 patron NOT allowed to reserve $branch_2 item with > IndependentBranches ON ... (bug 2394)' > # at t/db_dependent/Holds.t line 278. > > # Failed test '... unless canreservefromotherbranches is ON (bug 2394)' > # at t/db_dependent/Holds.t line 285. > t/db_dependent/Holds.t .. 41/60 > # Failed test 'Hold can be trapped for damaged item with > AllowHoldsOnDamagedItems enabled' > # at t/db_dependent/Holds.t line 309. > t/db_dependent/Holds.t .. 53/60 > # Failed test 'Patron can reserve item with hold limit of 1, no holds > placed' > # at t/db_dependent/Holds.t line 594. > # Structures begin differing at: > # $got->{status} = 'branchNotInHoldGroup' > # $expected->{status} = 'OK' > > # Failed test 'Patron can reserve item with 2 reserves daily cap' > # at t/db_dependent/Holds.t line 611. > # Structures begin differing at: > # $got->{status} = 'branchNotInHoldGroup' > # $expected->{status} = 'OK' > > # Failed test 'Patron can reserve item with 2 bib level hold placed on > different days, 2 reserves daily cap' > # at t/db_dependent/Holds.t line 630. > # Structures begin differing at: > # $got->{status} = 'branchNotInHoldGroup' > # $expected->{status} = 'OK' > > # Failed test 'Patron can reserve if holds_per_day is undef (i.e. > undef is unlimited daily cap)' > # at t/db_dependent/Holds.t line 649. > # Structures begin differing at: > # $got->{status} = 'branchNotInHoldGroup' > # $expected->{status} = 'OK' > > # Failed test 'Patron can reserve if holds_per_day is undef (i.e. > undef is unlimited daily cap)' > # at t/db_dependent/Holds.t line 656. > # Structures begin differing at: > # $got->{status} = 'branchNotInHoldGroup' > # $expected->{status} = 'OK' > # Looks like you failed 5 tests of 10. > t/db_dependent/Holds.t .. 58/60 > # Failed test 'CanItemBeReserved / holds_per_day tests' > # at t/db_dependent/Holds.t line 676. > t/db_dependent/Holds.t .. 60/60 # Looks like you failed 5 tests of 60. > t/db_dependent/Holds.t .. Dubious, test returned 5 (wstat 1280, 0x500) > Failed 5/60 subtests > > The tests needs to reflect changes in C4::Reserves. > > The Comment 13 is not reflected yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 23:53:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 21:53:30 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #22 from Jonathan Druart --- (In reply to Katrin Fischer from comment #19) > I think the $raw would have no other effect than showing we want HTML there. > We are not really filtering.. we are adding and removing whitespace. Not > sure what $To all does. Need another opinion, maybe Jonathan? Hi Katrin, see bug 20891 comment 5: """ If this patch works we will need to rethink the 'To' TT plugin. It was originally designed to have several escape methods, but with these changes it will not make sense to name it 'To' if used only to escape JSON """ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 25 23:55:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 21:55:30 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #32 from Agust?n Moyano --- (In reply to Liz Rea from comment #31) > Hi Agustin, > > I seem to be getting test failures like these on these current patches, have > a look please? > > Functionally, the dev seems to be working up to this point of testing, so > don't stress too much about that. :) > > Cheers, > Liz > > (In reply to Josef Moravec from comment #16) > > Hi August?n, > > I started to testing, overall it is looking good, I will continue on that, > > but just found some issues, which should be addressed: > > > > prove t/db_dependent/Reserves.t > > > > # Failed test 'CheckReserves Test 1' > > # at t/db_dependent/Reserves.t line 132. > > # got: '' > > # expected: 'Reserved' > > > > # Failed test 'CheckReserves() include reserve_id in its response' > > # at t/db_dependent/Reserves.t line 134. > > > > # Failed test 'CheckReserves Test 2' > > # at t/db_dependent/Reserves.t line 137. > > # got: '' > > # expected: 'Reserved' > > > > # Failed test 'CheckReserves Test 3' > > # at t/db_dependent/Reserves.t line 140. > > # got: '' > > # expected: 'Reserved' > > t/db_dependent/Reserves.t .................... 59/60 # Looks like you failed > > 4 tests of 60. > > t/db_dependent/Reserves.t .................... Dubious, test returned 4 > > (wstat 1024, 0x400) > > Failed 4/60 subtests > > > > > > prove t/db_dependent/Holds.t > > # Failed test '$branch_1 patron allowed to reserve $branch_2 item with > > IndependentBranches OFF (bug 2394)' > > # at t/db_dependent/Holds.t line 270. > > > > # Failed test '$branch_1 patron NOT allowed to reserve $branch_2 item with > > IndependentBranches ON ... (bug 2394)' > > # at t/db_dependent/Holds.t line 278. > > > > # Failed test '... unless canreservefromotherbranches is ON (bug 2394)' > > # at t/db_dependent/Holds.t line 285. > > t/db_dependent/Holds.t .. 41/60 > > # Failed test 'Hold can be trapped for damaged item with > > AllowHoldsOnDamagedItems enabled' > > # at t/db_dependent/Holds.t line 309. > > t/db_dependent/Holds.t .. 53/60 > > # Failed test 'Patron can reserve item with hold limit of 1, no holds > > placed' > > # at t/db_dependent/Holds.t line 594. > > # Structures begin differing at: > > # $got->{status} = 'branchNotInHoldGroup' > > # $expected->{status} = 'OK' > > > > # Failed test 'Patron can reserve item with 2 reserves daily cap' > > # at t/db_dependent/Holds.t line 611. > > # Structures begin differing at: > > # $got->{status} = 'branchNotInHoldGroup' > > # $expected->{status} = 'OK' > > > > # Failed test 'Patron can reserve item with 2 bib level hold placed on > > different days, 2 reserves daily cap' > > # at t/db_dependent/Holds.t line 630. > > # Structures begin differing at: > > # $got->{status} = 'branchNotInHoldGroup' > > # $expected->{status} = 'OK' > > > > # Failed test 'Patron can reserve if holds_per_day is undef (i.e. > > undef is unlimited daily cap)' > > # at t/db_dependent/Holds.t line 649. > > # Structures begin differing at: > > # $got->{status} = 'branchNotInHoldGroup' > > # $expected->{status} = 'OK' > > > > # Failed test 'Patron can reserve if holds_per_day is undef (i.e. > > undef is unlimited daily cap)' > > # at t/db_dependent/Holds.t line 656. > > # Structures begin differing at: > > # $got->{status} = 'branchNotInHoldGroup' > > # $expected->{status} = 'OK' > > # Looks like you failed 5 tests of 10. > > t/db_dependent/Holds.t .. 58/60 > > # Failed test 'CanItemBeReserved / holds_per_day tests' > > # at t/db_dependent/Holds.t line 676. > > t/db_dependent/Holds.t .. 60/60 # Looks like you failed 5 tests of 60. > > t/db_dependent/Holds.t .. Dubious, test returned 5 (wstat 1280, 0x500) > > Failed 5/60 subtests > > > > The tests needs to reflect changes in C4::Reserves. > > > > The Comment 13 is not reflected yet. Hello Liz, thanks for testing.. It's weird.. I've tested it and it passes. I changed chekcout rules before testing, and get no errors (that's the only thing I can think of that may affect those tests).. could you please tell me what was your rules configuration before testing? Thanks kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=60, 9 wallclock secs ( 0.02 usr 0.01 sys + 2.81 cusr 0.39 csys = 3.23 CPU) Result: PASS kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. ok All tests successful. Files=1, Tests=61, 11 wallclock secs ( 0.02 usr 0.01 sys + 3.09 cusr 0.68 csys = 3.80 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 00:10:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 22:10:57 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 --- Comment #33 from Jonathan Druart --- (In reply to Katrin Fischer from comment #32) > Should we close the bug? Or mark as dependency? I would mark as fixed once done. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 00:34:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 22:34:28 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #18 from Agust?n Moyano --- Created attachment 88818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88818&action=edit Bug 22053: create unit tests Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 00:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 22:34:32 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #19 from Agust?n Moyano --- Created attachment 88819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88819&action=edit Bug 22053: ability to enable/disable some plugins Test plan: - apply this patch(es), - launch an updatedabase, - go to plugins/plugins-home.pl and deal with enable/disable method - install a plugin like KitchenSink https://github.com/bywatersolutions/koha-plugin-kitchen-sink - once installed, the plugin change the background color of the staff client to orange. - disable the plugin, - background color should be set back to the original one Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 00:34:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 22:34:37 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #20 from Agust?n Moyano --- Created attachment 88820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88820&action=edit Bug 22053: update database Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 00:40:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 22:40:04 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io --- Comment #21 from Agust?n Moyano --- Hello Alex, awesome job!, it works great.. Just a little question.. I noticed that disabled plugins have the "run plugin" button enabled, and when you click on it works.. shouldn't that button be disabled if you disable the entire plugin?.. or this bug is intended only for hookup functions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 00:47:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 22:47:21 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #22 from Agust?n Moyano --- (In reply to Agust?n Moyano from comment #21) > Hello Alex, awesome job!, it works great.. > > Just a little question.. > > I noticed that disabled plugins have the "run plugin" button enabled, and > when you click on it works.. > > shouldn't that button be disabled if you disable the entire plugin?.. or > this bug is intended only for hookup functions? s/"run plugin" button/"run tool" option/g :P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 00:59:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 22:59:20 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #23 from Katrin Fischer --- (In reply to Jonathan Druart from comment #22) > (In reply to Katrin Fischer from comment #19) > > I think the $raw would have no other effect than showing we want HTML there. > > We are not really filtering.. we are adding and removing whitespace. Not > > sure what $To all does. Need another opinion, maybe Jonathan? > > Hi Katrin, see bug 20891 comment 5: > """ > If this patch works we will need to rethink the 'To' TT plugin. > It was originally designed to have several escape methods, but with > these changes it will not make sense to name it 'To' if used only to > escape JSON > """ Sorry Jonathan, but that doesn't help me :) What filters should be used here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 01:32:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 23:32:29 +0000 Subject: [Koha-bugs] [Bug 22629] Maps are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22629 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Assignee|chris at bigballofwax.co.nz |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |MOVED --- Comment #1 from Jonathan Druart --- Reported on gitlab: https://gitlab.com/koha-community/hea-app/issues/5 Merge request done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 01:45:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 23:45:56 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #24 from Jonathan Druart --- We need "To" (which must be renamed or adjusted) to correctly json escaped. We do not want to html filter the circulation notes, so it makes sense to remove this filter. The patches look ok to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 01:47:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 23:47:42 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #26 from Katrin Fischer --- Thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 01:47:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Apr 2019 23:47:30 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 --- Comment #25 from Jonathan Druart --- Additionally we should json filter all the other TT variables in this template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 03:47:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 01:47:54 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82896|0 |1 is obsolete| | Attachment #82897|0 |1 is obsolete| | Attachment #82898|0 |1 is obsolete| | Attachment #82899|0 |1 is obsolete| | Attachment #82900|0 |1 is obsolete| | Attachment #82901|0 |1 is obsolete| | Attachment #83312|0 |1 is obsolete| | --- Comment #50 from Aleisha Amohia --- Created attachment 88821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88821&action=edit Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 03:48:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 01:48:03 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #51 from Aleisha Amohia --- Created attachment 88822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88822&action=edit Bug 8628: Digital signs - schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 03:48:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 01:48:09 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #52 from Aleisha Amohia --- Created attachment 88823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88823&action=edit Bug 8628: Digital signs - Koha objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 03:48:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 01:48:14 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #53 from Aleisha Amohia --- Created attachment 88824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88824&action=edit Bug 8628: Digital signs - preferences and permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 03:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 01:48:20 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #54 from Aleisha Amohia --- Created attachment 88825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88825&action=edit Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 03:48:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 01:48:25 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #55 from Aleisha Amohia --- Created attachment 88826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88826&action=edit Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 03:52:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 01:52:04 +0000 Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #63 from Lucas Gass --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:07:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:07:14 +0000 Subject: [Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Hayley Mapley --- (In reply to Jonathan Druart from comment #8) > Created attachment 88660 [details] [review] > Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest > > Almost everywhere we call IsAvailableForItemLevelRequest we already have > a Koha::Patron and Koha::Item object. It makes sense to use them to > avoid a refetch > > Test plan: > It would be good to test this patch on top of 19300 and 19301 and make > sure everything works as expected Sorry Jonathan, still has merge conflicts Applying: Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest Using index info to reconstruct a base tree... M C4/Circulation.pm M C4/Reserves.pm M t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t CONFLICT (content): Merge conflict in t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:11:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:11:28 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84841|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia --- Created attachment 88827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88827&action=edit Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Run updatedatabase.pl * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:11:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:11:36 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84842|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia --- Created attachment 88828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88828&action=edit Bug 14367: (follow-up) Fixing merge conflicts... ...and other fixes to make patch work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:12:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:12:15 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84859|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia --- Created attachment 88829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88829&action=edit Bug 14367: (follow-up) Rebasing to make patch work on master Run through test plan and confirm everything still works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:12:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:12:31 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #25 from Aleisha Amohia --- Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:24:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:24:52 +0000 Subject: [Koha-bugs] [Bug 22188] Use publication date as numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:24:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:24:56 +0000 Subject: [Koha-bugs] [Bug 22188] Use publication date as numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87433|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia --- Created attachment 88830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88830&action=edit Bug 22188: (follow-up) Introducing dateformat field and other fixes To test with this patch, please update the database and update the schema. With this patch, you can now choose the dateformat of the date pattern by editing the subscription. This information is now saved in the DB subscription table. This patch also fixes previous problems with receiving and generating the next serial. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:38:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:38:16 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88102|0 |1 is obsolete| | --- Comment #81 from Aleisha Amohia --- Created attachment 88831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88831&action=edit Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:38:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:38:24 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88103|0 |1 is obsolete| | --- Comment #82 from Aleisha Amohia --- Created attachment 88832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88832&action=edit Bug 14715: [QA Follow up] Fixing qa-tools issues and merge conflicts Signed-off-by: Owen Leonard Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:38:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:38:38 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88105|0 |1 is obsolete| | --- Comment #84 from Aleisha Amohia --- Created attachment 88834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88834&action=edit Bug 14715: [QA Follow up] Rebase and fix up I noticed that the two sysprefs initially created with this patch weren't really being used, so I removed them. Instead I've added two new sysprefs: numSearchResultsDropdown OPACnumSearchResultsDropdown that control whether the dropdown shows or not. Otherwise the defaults in numSearchResults and OPACnumSearchResults are used to decide number of search results per page. When testing: Run updatedatabase.pl Test with values in numSearchResults and OPACnumSearchResults. Use original test plan in Comment 12 but test with the dropdown sysprefs off and on. Sponsored-by: Region Halland Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:38:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:38:45 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88106|0 |1 is obsolete| | --- Comment #85 from Aleisha Amohia --- Created attachment 88835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88835&action=edit Bug 14715: (QA Follow up) Fix results not showing This fixes the display issue for me. Can someone please test? Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:38:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:38:52 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88107|0 |1 is obsolete| | --- Comment #86 from Aleisha Amohia --- Created attachment 88836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88836&action=edit Bug 14715: (QA follow-up) some code changes 1) adds sysprefs to sysprefs.sql 2) removes a merge conflict error that should not have been added Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:38:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:38:31 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88104|0 |1 is obsolete| | --- Comment #83 from Aleisha Amohia --- Created attachment 88833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88833&action=edit Bug 14715: [QA Follow up] Removing 'all' option, fixing QA tools issues Signed-off-by: Simon Pouchol Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:38:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:38:59 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88108|0 |1 is obsolete| | --- Comment #87 from Aleisha Amohia --- Created attachment 88837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88837&action=edit Bug 14715: (QA follow-up) Edits for ElasticSearch Note added to preferences that the dropdown should not be used with ElasticSearch activated. Dropdowns do not show on search results on staff side or OPAC side if Elasticsearch enabled. Ready to test Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:39:07 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88109|0 |1 is obsolete| | --- Comment #88 from Aleisha Amohia --- Created attachment 88838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88838&action=edit Bug 14715: (QA Follow up) More QA tool cleanup Tools are picking up more stuff now, so a few more things to fix! Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:39:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:39:14 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88195|0 |1 is obsolete| | --- Comment #89 from Aleisha Amohia --- Created attachment 88839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88839&action=edit Bug 14715: (follow-up) Fixing database updates This patch removes the atomic update that adds the 'perPage' system preferences and keeps the 'dropdown' system preferences. Also sql file is moved into perl file. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:39:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:39:44 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:55:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:55:20 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #76 from Hayley Mapley --- Created attachment 88840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88840&action=edit Bug 18308: Removed warns and moved password length warning to template Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 04:55:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 02:55:17 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 05:24:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 03:24:25 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 05:24:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 03:24:28 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88368|0 |1 is obsolete| | --- Comment #7 from Hayley Mapley --- Created attachment 88841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88841&action=edit Bug 22056: Removed test directory, including search.pl and README Test plan: Check that this directory has been removed. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 07:53:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 05:53:54 +0000 Subject: [Koha-bugs] [Bug 22772] Menu link hover color incorrect in OPAC language choosers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 07:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 05:53:57 +0000 Subject: [Koha-bugs] [Bug 22772] Menu link hover color incorrect in OPAC language choosers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88789|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 88842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88842&action=edit Bug 22772: Menu link hover color incorrect in OPAC language choosers This patch makes a few corrections to OPAC CSS to fix colors in the language menus. To test, apply the patch and rebuild the OPAC CSS. - Enable multiple languages in the OPAC, including more than one language "variation" (fr-FR, fr-CA). - Set the OpacLangSelectorMode preference to "both." - In the OPAC, test the language menu in both the header and footer. When you hover over the sub-menu items the background should be green and the text color white. - Perform the same test in the self checkout and self checkin interfaces. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 07:54:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 05:54:47 +0000 Subject: [Koha-bugs] [Bug 22035] Improve local cover image browser page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22035 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88717|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 88843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88843&action=edit Bug 22035: Improve local cover image browser page This patch makes changes to the way local cover images are handled on the image viewer page in the staff client. From this page you can now delete images or reach the upload images page. The patch also modifies slightly the process for deleting an image from the images tab on the bibliographic detail page. To test, apply the patch and regenerate the staff client CSS. LocalCoverImages and AllowMultipleCovers should be enabled. - Open the detail view for a record which has multiple cover images attached. On the Images tab, click the "Delete image" link for an image. After confirming, the link should change to a spinner icon and image should fade out. - Click one of the cover images to open the image viewer page. The thumbnails should each have a delete link which looks like and behaves like the delete links on the biblio detail page. - Clicking an image thumbnail should load a spinner icon into the area where the full-sized image was, which should be replaced by the image you chose. - There should be a button for uploading images which takes you to the correct page for adding images to that record. - The page title and breadcrumbs should show the title of the record. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 07:54:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 05:54:44 +0000 Subject: [Koha-bugs] [Bug 22035] Improve local cover image browser page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22035 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 07:57:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 05:57:49 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88841|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 88844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88844&action=edit Bug 22056: Removed test directory, including search.pl and README Test plan: Check that this directory has been removed. Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 07:57:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 05:57:45 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 07:58:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 05:58:13 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Katrin Fischer --- Going straight to PQA here, thx Hayley! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 07:59:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 05:59:44 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88278|0 |1 is obsolete| | --- Comment #37 from Josef Moravec --- Created attachment 88845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88845&action=edit Bug 15400: (follow-up) Add class to years span -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:00:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:00:45 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88845|0 |1 is obsolete| | --- Comment #38 from Josef Moravec --- Created attachment 88846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88846&action=edit Bug 15400: (follow-up) Add class to years span -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:07:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:07:59 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 --- Comment #6 from Katrin Fischer --- Comment on attachment 88776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88776 Bug 12533: Improve authority search result display Review of attachment 88776: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12533&attachment=88776) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc @@ -56,2 @@ > [% BLOCK authresult %] > - [% IF ( summary.label ) %][% summary.label | html %]:[% END %] This all seems to work well, but i am in doubt about this line here. I think the summary feature is only used by UNIMARC, but are we sure this has no side effects? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:08:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:08:50 +0000 Subject: [Koha-bugs] [Bug 21535] Anonymize function in Patron should not scramble email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21535 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:09:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:09:55 +0000 Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many items to display unless viewing them all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:12:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:12:50 +0000 Subject: [Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 --- Comment #14 from Claire Gravely --- Hi, I tried testing but with the patch applied I get no results at all (even the pages without my dodgy biblio). The item search results page hangs on processing and in the console I get a response 'internal server error' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:15:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:15:32 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I've tried this: http://koha.1045719.n5.nabble.com/Authority-Type-Help-in-Koha-td3062760.html But didn't seem to get it to work. I Notice it displays on top without getting interpreted. Can you have a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:25:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:25:20 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:25:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:25:23 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79470|0 |1 is obsolete| | Attachment #88788|0 |1 is obsolete| | --- Comment #22 from Claire Gravely --- Created attachment 88847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88847&action=edit [SIGNED-OFF] Bug 21364: Allow closing basket from vendor view/search To test: 1 - Have a vendor 2 - Add some empty baskets 3 - Add some non-empty baskets 4 - Search for vendor and note you now a - Can only 'View' empty or closed baskets b - Have a dropup menu to 'Add to ' or 'Close' open baskets 5 - Confirm things look correct and buttons work 6 - Confirm that basket name is now a link to view basket Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:25:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:25:26 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #23 from Claire Gravely --- Created attachment 88848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88848&action=edit [SIGNED-OFF] Bug 21364: (follow-up) Check for standing status and uncertain prices Fetch 'uncertainprices' when getting basket info. A side effect is that styling on baskets with uncertain prices is restored by this bug. They will appear in red To test: 1 - Add an order with an uncertainprice to the basket 2 - Return to vendor baskets view 3 - Note the actions now include "Uncertain prices" 4 - Click that, resolve the uncertain prcie 5 - Return to vendor basket view 6 - Note you can now close the basket, but don't 7 - Edit the basket, mark it as standing 8 - Return to vendor basket view 9 - Note you cannot close the basket Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:27:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:27:25 +0000 Subject: [Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #9 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:31:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:31:25 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #37 from Martin Renvoize --- Awesome, thanks for the clarifications Chris ?, I've really enjoyed doing this patch, learning a little bit more about kohas' history and all the great people who have been part of it. I'll give this patch another update with this new info and taking Katrins suggestions into account too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:34:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:34:35 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:42:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:42:07 +0000 Subject: [Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:42:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:42:11 +0000 Subject: [Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88734|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 88849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88849&action=edit Bug 21589: Series link formed from 830 field is incorrect Bug 13692 corrected the series link for records using a 490/800 combination When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank) Test Plan: 1) Catalog two or more records with 830 fields 2) Note the series links are broken 3) Apply this patch 4) Reload the record details page 5) The series link should now work 6) Repeat for the OPAC Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:43:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:43:26 +0000 Subject: [Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:53:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:53:13 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:53:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:53:15 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88782|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 88850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88850&action=edit Bug 22424: Add search by all lost statuses to item search This patch changes the item search form so that searching by lost status includes options for all lost authorised values instead of just "yes" or "no." To test you should have multiple authorized values for LOST. - Apply the patch and open the item search form. - Test searches which limit by lost status. Confirm that results are correctly limited. - Confirm that lost statuses are correctly displayed in the search results. - Confirm that in the search results table, the column header for "Lost" includes a dropdown menu for filtering by all available authorized values for lost. - Test the CSV export function and confirm that lost status is correctly exported. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 08:58:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 06:58:27 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #61 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:29:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:29:42 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #45 from Martin Renvoize --- Tomas has corrected the config on the koha-testing-docker side to silence the warnings for us during testing now :). However, I asked Colin to take a look at these patches one last time whilst it's on the edge of being pushed again. He noted: 1) The followup actually breaks the SIPServer (simple fix, we're missing export from the newly introduced SIP::Logger.pm) 2) It looks like we're still initialising syslogd so there's a somewhat erratic behaviour as to where log messages are being directed. 3) It's a bit misleading having a 'syslog' call that doesn't actually go to syslog.. I personally would rather go through the code in a followup and clarify that method name to not match one that many people know and assume goes to the system syslogs ;) 4) The new format is great, but it's also considerably different and so any monitoring scripts already out there in the wild will need to be completely re-written. 5) Net::Server has a bunch of internal logging which could be passed a Log4Perl logger but we're not doing that here so that logging is not being included 6) You could configure logging via the sipserver config file before.. and it looks like you still can, but that's very confusing Colins working on a followup for me to correct the export and is quickly investigating the config side to see if we can reduce some of the impacts above. I'm keen to see this continue working it way through though so please don't read all the above as a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:36:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:36:01 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:36:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:36:05 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88762|0 |1 is obsolete| | Attachment #88763|0 |1 is obsolete| | Attachment #88764|0 |1 is obsolete| | Attachment #88765|0 |1 is obsolete| | Attachment #88766|0 |1 is obsolete| | Attachment #88767|0 |1 is obsolete| | Attachment #88768|0 |1 is obsolete| | Attachment #88769|0 |1 is obsolete| | Attachment #88770|0 |1 is obsolete| | Attachment #88771|0 |1 is obsolete| | Attachment #88772|0 |1 is obsolete| | --- Comment #158 from Josef Moravec --- Created attachment 88851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88851&action=edit Bug 11529: Add new fields to biblio table Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:36:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:36:12 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #159 from Josef Moravec --- Created attachment 88852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88852&action=edit Bug 11529: Use new biblio fields whenever possible Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:36:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:36:17 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #160 from Josef Moravec --- Created attachment 88853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88853&action=edit Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:36:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:36:23 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #161 from Josef Moravec --- Created attachment 88854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88854&action=edit Bug 11529: Clean up subtitle usage Unify and clean up subtitle usage so that it's always used as a simple array and not the old hash structure. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:36:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:36:28 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #162 from Josef Moravec --- Created attachment 88855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88855&action=edit Bug 11529: Remove field mapping table and admin page Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:36:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:36:33 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #163 from Josef Moravec --- Created attachment 88856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88856&action=edit Bug 11529: DBIx schema changes Updates to Biblio schema and removal of FieldMapping schema. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:36:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:36:38 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #164 from Josef Moravec --- Created attachment 88857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88857&action=edit Bug 11529: Update kohafield in default framework only if not already set. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:36:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:36:44 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #165 from Josef Moravec --- Created attachment 88858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88858&action=edit Bug 11529: Replace bibliosubtitle with biblio in all framework sql's. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:36:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:36:50 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #166 from Josef Moravec --- Created attachment 88859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88859&action=edit Bug 11529: Remove duplicate column name from select query Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:36:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:36:55 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #167 from Josef Moravec --- Created attachment 88860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88860&action=edit Bug 11529: (follow-up) Remove manage_keywords2koha_mappings permission. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:37:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:37:01 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #168 from Josef Moravec --- Created attachment 88861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88861&action=edit Bug 11529: Add templates for biblio title display. Unify display. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 09:37:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 07:37:06 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #169 from Josef Moravec --- Created attachment 88862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88862&action=edit Bug 11529: (follow-up) Fix link on hold request page Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 10:18:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 08:18:06 +0000 Subject: [Koha-bugs] [Bug 22738] Software Error after LDAP Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 --- Comment #21 from morsch at iza.org --- I used to fix it by myself. For those of you who are interested in the working ldap config, here it is: ldap://xx.xxx.80.5 dc=xx,dc=xx cn=admin,dc=xx,dc=xx xxxxxxxxx 1 1 0 0 uid=%s,dc=xx,dc=xx 1
    Bonn BIB MA     Keep in mind to replace all individual settings, like IP, categorycode etc. It seems the problem was the former missing "principal_name" setting. Furthermore you need to check the case sensitivity of the mapping attributes from ldap. You need to type "giveNname" instead of "givenname". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 10:23:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 08:23:58 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 10:24:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 08:24:02 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80735|0 |1 is obsolete| | --- Comment #62 from Marcel de Rooy --- Created attachment 88863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88863&action=edit Bug 14407: Allow restricting SCO to IP or IP range Converted this to actual applicable patches. I think the test plan is comment #28. -- Mark Tompsett Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 10:24:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 08:24:07 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80736|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy --- Created attachment 88864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88864&action=edit Bug 14407: Unit tests for in_ipset TEST PLAN --------- 1) apply all pathches 2) sudo koha-shell -c bash kohadev prove t/Auth.t -- should run. 3) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 10:24:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 08:24:12 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80737|0 |1 is obsolete| | --- Comment #64 from Marcel de Rooy --- Created attachment 88865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88865&action=edit Bug 14407: Follow up add missing atomic update The patch only added the system preference for fresh installs. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 10:24:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 08:24:17 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86123|0 |1 is obsolete| | --- Comment #65 from Marcel de Rooy --- Created attachment 88866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88866&action=edit Bug 14407: Follow up to add test case and clean noise Comment #28 has a /36 which is invalid CIDR. This triggers a crash and noise. This cleans up the crash and noise, and adds test cases to check for them. prove t/Auth.t -- before missing null case, and /36 case. -- after null case, and /36 with/without warnings. Signed-off-by: Mark Tompsett Signed-off-by: Hayley Mapley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 10:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 08:31:21 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #66 from Marcel de Rooy --- @RM: Do we still have a keyword for packaging? dependency? Net::CIDR is added, but it seems to be installed already with koha-common and friends. The pref allows both start-finish and CIDR IP ranges. Although formally piping the pref into range2cidr converts start-finish ranges into CIDR. Both work. The patch uses CGI header(status=> ...) notation. The codebase also contains the older -status notation. But CGI::Util handles both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 10:37:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 08:37:33 +0000 Subject: [Koha-bugs] [Bug 22738] Software Error after LDAP Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 --- Comment #22 from Katrin Fischer --- Thx a lot for sharing the fix! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 10:41:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 08:41:28 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Keywords|Academy |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 10:55:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 08:55:39 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #25 from Marcel de Rooy --- + my @enabled_languages = + ( $interface && $interface eq 'intranet' ) + ? split ",", C4::Context->preference('language') + : split ",", C4::Context->preference('opaclanguage'); Seems to reverse the previous logic. If eq opac then opac else intranet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 10:57:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 08:57:44 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88598|0 |1 is obsolete| | --- Comment #2 from Matthias Meusburger --- Created attachment 88867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88867&action=edit Bug 21903: koha-dump can export uploaded and temporary uploaded files Sponsored-by: Orex Test plan: - Apply the patch - Try using koha-dump without any option - Try using koha-dump with --uploaded_files - Try using koha-dump with --uploaded_temp_files - Try using koha-dump with both of the options above Expected results: the .tar.gz dump will include uploaded and/or temporary uploaded files if requested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 11:00:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 09:00:02 +0000 Subject: [Koha-bugs] [Bug 13342] Not logged in user can place a review/comment as a deleted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Summary|not logged in user can |Not logged in user can |place a review/comment as a |place a review/comment as a |deleted patron |deleted patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 11:11:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 09:11:45 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #169 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 11:11:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 09:11:48 +0000 Subject: [Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #1 from Katrin Fischer --- Still valid for 18.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 11:17:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 09:17:47 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #50 from Katrin Fischer --- (In reply to Katrin Fischer from comment #49) > Hi Andrew, > > I am very sorry, not sure the last patch is quite right. I think what > happens now is that either will make 'all' checkboxes appear, if the item is > on hold or not. I think we need to control the checkboxes separately, if > that makes sense? > > Test case: > Have at least 2 items checked out, 1 is on hold. > > AllowRenewalOnHoldOverride Allow > AllowRenewalLimitOverride Don't allow > > - Restriction override checkbox below table appears - OK > - Checking the box, enables the on hold item for renewal - OK > - Checking the box also enabled all other items for renewal - not OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 11:21:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 09:21:19 +0000 Subject: [Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 --- Comment #1 from Katrin Fischer --- Appears to be still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 11:24:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 09:24:46 +0000 Subject: [Koha-bugs] [Bug 17772] Allow to sort lists by date the record was created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17772 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19039 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 11:24:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 09:24:46 +0000 Subject: [Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17772 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 11:25:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 09:25:28 +0000 Subject: [Koha-bugs] [Bug 17772] Allow to sort lists by date the record was created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17772 --- Comment #1 from Katrin Fischer --- There is a new sort option "date added", but this refers to the date the entry was added to the list, not the creation date of the bibliographic record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:03:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:03:28 +0000 Subject: [Koha-bugs] [Bug 22779] Simplify add serials form to single page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22779 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Simplify serials form to |Simplify add serials form |single page |to single page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:05:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:05:59 +0000 Subject: [Koha-bugs] [Bug 22780] New: MarkLostItemsAsReturned - map to Lost-sttaus instead of context where the transaction took place Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22780 Bug ID: 22780 Summary: MarkLostItemsAsReturned - map to Lost-sttaus instead of context where the transaction took place Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: klas.blomberg at skovde.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Syspref MarkLostItemsAsReturned is mapped to the context where you make the transaction - Holds to pull list, longoverdue cronjob et.c. I can't see any logical reason for this! I think it would be better to map to Lost-statuses: Lost = don't mark as returned Longoverdue = don't mark as returned Lost and paid for = mark as returned et.c. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:06:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:06:20 +0000 Subject: [Koha-bugs] [Bug 22780] MarkLostItemsAsReturned - map to Lost-status instead of context where the transaction took place In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22780 Klas Blomberg changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MarkLostItemsAsReturned - |MarkLostItemsAsReturned - |map to Lost-sttaus instead |map to Lost-status instead |of context where the |of context where the |transaction took place |transaction took place -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:06:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:06:28 +0000 Subject: [Koha-bugs] [Bug 22779] Simplify add serials form to single page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I know Owen was working on subscriptiosn too recently: Bug 22408 - Subscription entry form cleanup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:07:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:07:27 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Alex Arnaud --- 1) This feature is MARC21 specific. Doesn't work with UNIMARC. 2) Typo in the POD for _build_scan_query and _create_regex_filter (missing underscores) 3) Missing tests for _aggregation_scan / search_compat 4) 4 tests added in QueryBuilder.t but subtest's plan test not updated. Tests fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:08:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:08:54 +0000 Subject: [Koha-bugs] [Bug 22779] Simplify add serials form to single page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22779 --- Comment #3 from Nick Clemens --- (In reply to Katrin Fischer from comment #2) > I know Owen was working on subscriptiosn too recently: > Bug 22408 - Subscription entry form cleanup Ah, nice! I will try to rebase some of these changes on top if his work there when I get a chance I would still like the auto pattern testing and to remove some of the alerts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:10:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:10:15 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:10:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:10:19 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #51 from Andrew Isherwood --- Created attachment 88868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88868&action=edit Bug 7088: (follow-up) Modify checkbox enabling As described in comment #50, we need to only enable renewal on items that are disabled in line with which sysprefs are enabled. So we now only enable renewal of on hold items if the AllowRenewalOnHoldOverride syspref is on and we only enable renewal of all other limited items when the AllowRenewalLimitOverride syspref is on. NOTE: The test plan below has changed substantially from previous iterations Test plan (you might want to make a coffee first...): - Apply patch - Rebuild CSS - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - The patron also needs to have an item on loan that cannot be renewed for some other reason, say renewal limit has been reached => TEST: Observe that it is NOT possible to select either item for renewal - Enable the "AllowRenewalLimitOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, but not the item that is on hold - Disable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it is NOT possible to select the the item that has reached the renewal limit, but it IS possible to select the item on hold - Enable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, AND it IS possible to select the item on hold - Select the item that is on hold => TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item => TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" => TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" => TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" => TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" => TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit => TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" => TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:16:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:16:11 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88479|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize --- Created attachment 88869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88869&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:16:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:16:14 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88480|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize --- Created attachment 88870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88870&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:16:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:16:18 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88481|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize --- Created attachment 88871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88871&action=edit Bug 21662: Add Contributors.yaml file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:16:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:16:21 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88482|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize --- Created attachment 88872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88872&action=edit Bug 21662: Use contributors.yaml for contributors list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:16:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:16:24 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #42 from Martin Renvoize --- Created attachment 88873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88873&action=edit Bug 21662: Other history correction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:17:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:17:43 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #43 from Martin Renvoize --- Hows this Katrin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:20:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:20:34 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:20:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:20:41 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86861|0 |1 is obsolete| | --- Comment #170 from Marcel de Rooy --- Created attachment 88874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88874&action=edit Bug 8000: Redirect all emails to SendAllEmailsTo Rebased and squashed after changes to master. Only difference from previous patches are small adjustements to conflicts in t/db_dependent/Letters.t Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) Signed-off-by: Ed Veal Signed-off-by: BWS Sandboxes Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:20:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:20:48 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86862|0 |1 is obsolete| | --- Comment #171 from Marcel de Rooy --- Created attachment 88875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88875&action=edit Bug 8000: (QA follow-up) Centralise Bcc too Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:20:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:20:56 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86863|0 |1 is obsolete| | --- Comment #172 from Marcel de Rooy --- Created attachment 88876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88876&action=edit Bug 8000: (QA follow-up) Fix accidently edited sysprefs.sql file Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:21:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:21:04 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86864|0 |1 is obsolete| | --- Comment #173 from Marcel de Rooy --- Created attachment 88877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88877&action=edit Bug 8000: (QA follow-up) Update the to_address in the message queue Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:21:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:21:19 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #175 from Marcel de Rooy --- Created attachment 88879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88879&action=edit Bug 8000: (QA follow-up) Two lastminute fixes [1] Number of tests Letters.t [2] Resolving uninitialized warn on Letters, L1327 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:21:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:21:11 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86865|0 |1 is obsolete| | --- Comment #174 from Marcel de Rooy --- Created attachment 88878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88878&action=edit Bug 8000: (QA follow-up) Add email validation to system preferences This patch uses the JQuery validator plugin to add validation to preferences of class email in the system preferences page. A field containing an invalid value (even if not modified) should prevent saving. To test, confirm that when entering an invalid email address in the SendAllEmailsTo field, an error message appears and saving is prevented. Correcting the value should hide the message and let you save as normal. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:21:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:21:51 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:22:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:22:38 +0000 Subject: [Koha-bugs] [Bug 22781] New: Fields on patron search results should be html/json filtered Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 Bug ID: 22781 Summary: Fields on patron search results should be html/json filtered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- On bug 22715 we added a filter for circulation notes - this should probably be applied to all the fields on the page for consistency/safety -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:23:21 +0000 Subject: [Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:23:21 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 [Bug 22781] Fields on patron search results should be html/json filtered -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:26:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:26:21 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88483|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 88880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88880&action=edit Bug 21626: Add teams.yaml to /docs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:26:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:26:23 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88484|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 88881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88881&action=edit Bug 21626: Use teams.yaml for teams section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:28:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:28:00 +0000 Subject: [Koha-bugs] [Bug 14662] Allow blank values in pull downs in cataloguing forms when subfield is mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21927 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21927 [Bug 21927] Acq: Allow blank values in pull downs in the item form when subfield is mandatory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:28:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:28:00 +0000 Subject: [Koha-bugs] [Bug 21927] Acq: Allow blank values in pull downs in the item form when subfield is mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21927 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Depends on| |14662 Version|17.11 |master --- Comment #1 from Katrin Fischer --- After some digging in the code I believe we need the same or similar changes as bug 14662 for C4::Items::PrepareItemrecordDisplay. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 [Bug 14662] Allow blank values in pull downs in cataloguing forms when subfield is mandatory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:34:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:34:34 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:40:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:40:14 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88880|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 88882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88882&action=edit Bug 21626: Add teams.yaml to /docs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:40:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:40:17 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88881|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 88883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88883&action=edit Bug 21626: Use teams.yaml for teams section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:44:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:44:49 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80968|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:45:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:45:24 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 --- Comment #14 from Martin Renvoize --- Created attachment 88884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88884&action=edit before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:45:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:45:47 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 --- Comment #15 from Martin Renvoize --- Created attachment 88885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88885&action=edit after on a stable release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:46:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:46:19 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 --- Comment #16 from Martin Renvoize --- Created attachment 88886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88886&action=edit after on a development release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:46:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:46:38 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21477 --- Comment #67 from Nick Clemens --- I think dependency works, I will also email Mirko just for confirmation I added a see also to bug 21477 - this is just another case of a thing we already do so no blocker, just mentioning Once Mirko confirms I think this one is good -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:46:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:46:38 +0000 Subject: [Koha-bugs] [Bug 21477] Use of REMOTE_ADDR causes problems when Koha is behind a proxy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21477 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14407 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:47:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:47:39 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 --- Comment #17 from Martin Renvoize --- I've added some screenshots to show how this looks before this patch, and after this patch when backported to a stable branch and when on the current development version. I'm sure it could be made to look even nicer and to display more than just the current maintenance and your running versions release teams but I think this is a good starting point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:47:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:47:52 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74992|0 |1 is obsolete| | --- Comment #24 from Hugo Agud --- Created attachment 88887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88887&action=edit Bug 20310: Introduce Koha::Biblio->host_record This is a more generic method that allows you to get to the host record as defined in MARC21 field 773$w. Test plan: Run t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Marcel de Rooy Signed-off-by: Maksim Sen Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:47:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:47:55 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74993|0 |1 is obsolete| | --- Comment #25 from Hugo Agud --- Created attachment 88888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88888&action=edit Bug 20310: Redirect article record without items for article requests If an article record has been catalogued separately, has no items and contains a reference to its host via MARC21 field 773 (host item entry), this patch makes an article request redirect to the host record while copying title, author and page info (from 773$g). This is accomplished by using the new Koha::Biblio->host_record method. Note: Subfield 773$g may contain additional information on volume and issue number etc. It will be very hard or perhaps impossible to parse $g and copy these details into the corresponding fields of the article request form for all possible variations used in libraries. A similar remark can be made for selecting the correct item (when item level is used). We could try this on a future report, but will probably need at least a preference to define the expected format. Test plan: [1] Enable article requests. Add rules for an ART and a SER itemtype. [2] Create a SER host biblio record. [3] Create an ART biblio record, no items. Include a 773w pointing to the SER record with '(MARCorgcode)[recno]' (keep the parentheses, remove the square brackets when inserting the biblionumber). Include text in 773$g too. [4] Place an article request on the ART record. Verify that it redirects you to the SER record while copying title, author, page info. Signed-off-by: Marcel de Rooy Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:47:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:47:59 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74994|0 |1 is obsolete| | --- Comment #26 from Hugo Agud --- Created attachment 88889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88889&action=edit Bug 20310: (follow-up) Allow repeatable $w even without org code As mentioned in the BZ comments, we might expect people to add $w subfields without a MARC organization code. And we should keep in mind that 773 is repeatable, and both $g as well as $w is also repeatable. Added these cases into sub host_record, including tests. Test plan: Run t/db_dependent/Koha/Biblio/host_record.t again Signed-off-by: Marcel de Rooy Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:48:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:48:59 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:51:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:51:06 +0000 Subject: [Koha-bugs] [Bug 17724] Callnumber not copied into serial issue, when callnumber subfield is linked to a plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17724 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:52:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:52:00 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88882|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 88890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88890&action=edit Bug 21626: Add teams.yaml to /docs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:52:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:52:04 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88883|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 88891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88891&action=edit Bug 21626: Use teams.yaml for teams section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 12:58:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 10:58:21 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #8 from Katrin Fischer --- Matthias, can you please rebase? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:02:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:02:41 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #23 from Alex Arnaud --- (In reply to Agust?n Moyano from comment #21) > Hello Alex, awesome job!, it works great.. > > Just a little question.. > > I noticed that disabled plugins have the "run plugin" button enabled, and > when you click on it works.. > > shouldn't that button be disabled if you disable the entire plugin?.. or > this bug is intended only for hookup functions? Hello Agust?n, IMO, disabled plugins can be run and configured in the "plugins area" (koha/plugins/*). The only thing this patch does is to prevent calls of disabled plugins anywhere else in Koha (hooks). I don't see any advantage of preventing uses of run or configure methods since you can just ignore them. But a hook calls systematically all plugins implementing a specific method and you might need that does not happen for one of them until your are done with the configuration (for exemple) without removing it from your server. Thx for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:03:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:03:05 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #20 from Magnus Enger --- This looks great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:22:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:22:22 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88225|0 |1 is obsolete| | Attachment #88226|0 |1 is obsolete| | Attachment #88227|0 |1 is obsolete| | Attachment #88228|0 |1 is obsolete| | Attachment #88229|0 |1 is obsolete| | Attachment #88230|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 88892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88892&action=edit Bug 15496: Add API endoint for deleting a bib Signed-off-by: Liz Rea Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:22:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:22:36 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #36 from Kyle M Hall --- Created attachment 88893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88893&action=edit Bug 15496: Tidy code block (Whitespace changes only) Signed-off-by: Liz Rea Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:22:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:22:41 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #37 from Kyle M Hall --- Created attachment 88894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88894&action=edit Bug 15496: Delete Bib After Moving Item Librarians have requested the ability to delete records with no items quickly and easily from the "Attach item" results page as items are moved from one record to another. Test Plan: 1) Apply this patch 2) Create 2 records with 2 items each 3) Move one item from record A to record B 4) You should see no change from pre-patch behavior 5) Move the second item from record A to record B 6) You should now see a "Delete record" button 7) Click the button 8) Note the record in question has been deleted Signed-off-by: Liz Rea Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:22:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:22:44 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #38 from Kyle M Hall --- Created attachment 88895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88895&action=edit Bug 15496: (QA Follow up) remove text/javascript Make the QA tool happy for html5 Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:22:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:22:48 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #39 from Kyle M Hall --- Created attachment 88896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88896&action=edit Bug 15496: (QA follow-up) Change success status on api DELETE response code must be 204, not 200 according to our API coding guidelines Test plan: prove t/db_dependent/api/v1/biblios.t Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:22:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:22:51 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #40 from Kyle M Hall --- Created attachment 88897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88897&action=edit Bug 15496: (follow-up) Update interaction for deleting records This patch makes minor changes to markup and JavaScript to alter the interaction for deleting the record. Now a successful deletion will convert the dialog to a "message" type dialog and show only the success message. To test, apply the patch and test the process of attaching the last item from a record and deleting that record. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:24:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:24:57 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #68 from Mirko Tietgen --- libnet-server-perl depends on libnet-cidr-perl so we already have it. But it should be declarded as dependency for koha-common for this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:41:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:41:30 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88869|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 88898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88898&action=edit Bug 21662: Make history.txt whitespace consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:41:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:41:34 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88870|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 88899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88899&action=edit Bug 21662: Update history.txt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:41:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:41:37 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88871|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize --- Created attachment 88900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88900&action=edit Bug 21662: Add Contributors.yaml file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:41:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:41:41 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88872|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize --- Created attachment 88901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88901&action=edit Bug 21662: Use contributors.yaml for contributors list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:41:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:41:44 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88873|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize --- Created attachment 88902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88902&action=edit Bug 21662: Other history correction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:42:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:42:45 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #49 from Martin Renvoize --- That last update removes all the 'Contributions Unknown' lines I'd inadvertently added as notes for myself to revisit later. One day I'd love to dig further into the history to understand what these people have done but I think that can be for another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:44:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:44:58 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #41 from Kyle M Hall --- Created attachment 88903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88903&action=edit Bug 15496: (QA Followup) Fix new uses of Koha::Biblio::items in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:48:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:48:22 +0000 Subject: [Koha-bugs] [Bug 22154] Subtype search for Format - Braille doesn't look for the right codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #10 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:49:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:49:02 +0000 Subject: [Koha-bugs] [Bug 22698] Fix incorrect button classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22698 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:49:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:49:33 +0000 Subject: [Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #13 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:50:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:50:00 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED --- Comment #41 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:51:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:51:02 +0000 Subject: [Koha-bugs] [Bug 22702] Circulation note on patron page should allow for HTML tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #8 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:52:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:52:07 +0000 Subject: [Koha-bugs] [Bug 22702] Circulation note on patron page should allow for HTML tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22715 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:52:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:52:07 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks|22702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702 [Bug 22702] Circulation note on patron page should allow for HTML tags -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:56:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:56:23 +0000 Subject: [Koha-bugs] [Bug 22044] NoRenewalBeforePrecision should be set by default for new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.5.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #16 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:57:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:57:46 +0000 Subject: [Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #12 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:58:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:58:15 +0000 Subject: [Koha-bugs] [Bug 22274] Self-checkout pages not covered by OPAC CSS changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Bug 22274 depends on bug 22638, which changed state. Bug 22638 Summary: Self checkin CSS update https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:58:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:58:15 +0000 Subject: [Koha-bugs] [Bug 22638] Self checkin CSS update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #23 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:58:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:58:58 +0000 Subject: [Koha-bugs] [Bug 22274] Self-checkout pages not covered by OPAC CSS changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #22 from Martin Renvoize --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 13:58:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 11:58:59 +0000 Subject: [Koha-bugs] [Bug 22772] Menu link hover color incorrect in OPAC language choosers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 Bug 22772 depends on bug 22274, which changed state. Bug 22274 Summary: Self-checkout pages not covered by OPAC CSS changes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:00:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:00:26 +0000 Subject: [Koha-bugs] [Bug 22716] Use gender-neutral pronouns in system preference descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22716 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:01:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:01:57 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #125 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:01:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:01:58 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Bug 18081 depends on bug 21336, which changed state. Bug 21336 Summary: GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:01:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:01:59 +0000 Subject: [Koha-bugs] [Bug 21191] GDPR: Script to block inactive users (with no successful logins on a defined period) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21191 Bug 21191 depends on bug 21336, which changed state. Bug 21336 Summary: GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:01:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:01:59 +0000 Subject: [Koha-bugs] [Bug 21312] Show lockout on Patrons form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21312 Bug 21312 depends on bug 21336, which changed state. Bug 21336 Summary: GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:02:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:02:00 +0000 Subject: [Koha-bugs] [Bug 21533] Do not allow password recovery for administrative locked patrons (see 21336) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21533 Bug 21533 depends on bug 21336, which changed state. Bug 21336 Summary: GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:02:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:02:00 +0000 Subject: [Koha-bugs] [Bug 21535] Anonymize function in Patron should not scramble email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21535 Bug 21535 depends on bug 21336, which changed state. Bug 21336 Summary: GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:02:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:02:00 +0000 Subject: [Koha-bugs] [Bug 21712] Report anonymized patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21712 Bug 21712 depends on bug 21336, which changed state. Bug 21336 Summary: GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:02:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:02:00 +0000 Subject: [Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Bug 22729 depends on bug 21336, which changed state. Bug 21336 Summary: GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:02:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:02:50 +0000 Subject: [Koha-bugs] [Bug 22576] OPAC password change text changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22576 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:03:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:03:20 +0000 Subject: [Koha-bugs] [Bug 22616] Update error text messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22616 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:07:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:07:00 +0000 Subject: [Koha-bugs] [Bug 21533] Do not allow password recovery for administrative locked patrons (see 21336) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:07:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:07:03 +0000 Subject: [Koha-bugs] [Bug 21533] Do not allow password recovery for administrative locked patrons (see 21336) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80348|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 88904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88904&action=edit Bug 21533: Do not allow password recovery for administrative locked patrons Depends on bug 21336 for the ADMINISTRATIVE_LOCKOUT constant. This is a bit lazy solution (but good enough): The account will not be found when recovering the password. The user should contact the library. Since the library chose to lock the account, that seems appropriate. Test plan: Select a borrower and set login_attempts to -1. Via mysql command line or with Koha::Patrons->find(borrowernumber)->lock. Enable password recovery. Try to recover password from OPAC. You should fail with 'Not found, contact the library'. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:11:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:11:13 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88903|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall --- Created attachment 88905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88905&action=edit Bug 15496: (QA follow-up) Fix new uses of Koha::Biblio::items in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:12:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:12:12 +0000 Subject: [Koha-bugs] [Bug 22782] New: Schema change for SocialData Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22782 Bug ID: 22782 Summary: Schema change for SocialData Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- If you regenerate the schema on stretch you get a change to SocialData I haven't committed it because I didn't kow where it came from, I don't believe it will affect anything, but wanted to document the change at the least To recreate: On debian 9 run misc/devel/update_dbix_class_files.pl (devbox or koha testing docker just do dbic) Note the change Verify all works with this change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:12:41 +0000 Subject: [Koha-bugs] [Bug 22782] Schema change for SocialData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22782 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:22:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:22:21 +0000 Subject: [Koha-bugs] [Bug 21535] Anonymize function in Patron should not scramble email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21535 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:22:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:22:24 +0000 Subject: [Koha-bugs] [Bug 21535] Anonymize function in Patron should not scramble email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21535 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80349|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 88906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88906&action=edit Bug 21535: Anonymize function in Patron should not scramble email addresses Scrambled email addresses will only generate warnings etc. Clear them although they might be in BorrowerMandatoryField. Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard t/db_depepended/Koha/Patrons.t runs with no warnings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:29:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:29:24 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86353|0 |1 is obsolete| | --- Comment #141 from Stefan Berndtsson --- Created attachment 88907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88907&action=edit Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields This creates a new daemon, misc/z3950_responder.pl, which can respond to Z39.50 requests. By default, it just proxies searches to Zebra. If desired, however, it can also add a subfield to the item tags on outgoing records with a textual description of the item's status (checked out, lost, etc.). This is useful for certain ILL systems. These strings can be translated using the 'Z3950_STATUS' authorized value. Test plan: 1) Start the Z39.50 server using `perl misc/z3950_responder.pl`. 2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`. 3) Run a search, such as `find @attr 1=1016 book`. 4) Fetch the results both one at a time with `show 1` and in a batch using `show 1+5`. 5) Turn on MARCXML using `format xml` and `elements marcxml`, and verify that the records are still correctly fetched. 6) Enable the item status subfield by restarting the server with the option `--add-item-status=k`. 7) Search for and fetch records, and verify that a $k subfield is added to the item tags as appropriate. It should show some combination of "Checked Out", "Lost", "Not For Loan", "Damaged", "Withdrawn", "In Transit", or "On Hold" as appropriate, or "Available". 8) Add an authorized value named "Z3950_STATUS" with any of the keys "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED", "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their descriptions are used instead of the default values above. Signed-off-by: George Williams Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:29:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:29:34 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86354|0 |1 is obsolete| | --- Comment #142 from Stefan Berndtsson --- Created attachment 88908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88908&action=edit Bug 13937: (follow-up) Remove reference to sub _prefetch_records Remove reference to sub _prefetch_records It appears this sub is built into fetch and this call is a duplicate Signed-off-by: George Williams Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:29:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:29:42 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86355|0 |1 is obsolete| | --- Comment #143 from Stefan Berndtsson --- Created attachment 88909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88909&action=edit Bug 13937: (follow-up) Correct error call to use self Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:29:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:29:52 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86356|0 |1 is obsolete| | --- Comment #144 from Stefan Berndtsson --- Created attachment 88910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88910&action=edit Bug 13937: Add unit tests Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:29:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:29:59 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86357|0 |1 is obsolete| | --- Comment #145 from Stefan Berndtsson --- Created attachment 88911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88911&action=edit Bug 13937: (follow-up) Pass through yaz switches and don't ignore case Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:30:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:30:08 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86358|0 |1 is obsolete| | --- Comment #146 from Stefan Berndtsson --- Created attachment 88912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88912&action=edit Bug 13937: Fix issues found in QA Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:30:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:30:15 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86359|0 |1 is obsolete| | --- Comment #147 from Stefan Berndtsson --- Created attachment 88913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88913&action=edit Bug 13937: Add support for SRU and Elasticsearch Splits Session to GenericSession and ZebraSession where Generic supports any search backend via the SearchEngine classes and Zebra maintains the direct channel to the Zebra server. Adds config files required for mapping BIB-1 attributes to Koha search fields and SRU indexes to BIB-1 attributes. Adds PODs. Sponsored-by: National Library of Finland Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:30:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:30:22 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86360|0 |1 is obsolete| | --- Comment #148 from Stefan Berndtsson --- Created attachment 88914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88914&action=edit Bug 13937: Add tests for search and retrieval Sponsored-by: National Library of Finland Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:30:29 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86361|0 |1 is obsolete| | --- Comment #149 from Stefan Berndtsson --- Created attachment 88915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88915&action=edit Bug 13937: Fix RPN conversion Fixes handling of parenthesis and removes unused quote handling. Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:30:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:30:36 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86362|0 |1 is obsolete| | --- Comment #150 from Stefan Berndtsson --- Created attachment 88916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88916&action=edit Bug 13937: Add support for Z39.50 responder to the Debian scripts Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:30:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:30:43 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86363|0 |1 is obsolete| | --- Comment #151 from Stefan Berndtsson --- Created attachment 88917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88917&action=edit Bug 13937: Fix the daemon log path. directory _LOG_DIR_/logs does't exists. All other log4perl -logs are out to _LOG_DIR_ Thank you for the good work Ere! Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:34:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:34:14 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86364|0 |1 is obsolete| | --- Comment #152 from Stefan Berndtsson --- Created attachment 88918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88918&action=edit Bug 13937: Switch from GetItem() to Koha::Items->find() Signed-off-by: Stefan Berndtsson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:33:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:33:57 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:34:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:34:29 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_05_candidate CC| |nick at bywatersolutions.com --- Comment #132 from Nick Clemens --- I like this one a lot - can we get a squashed/clean version of these patches just for readability sake? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:39:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:39:04 +0000 Subject: [Koha-bugs] [Bug 10655] Include list of holds on circ slip or offer separate printing option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10655 --- Comment #1 from Katrin Fischer --- Would this be possible with TT notices now? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:40:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:40:23 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #17 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:40:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:40:37 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #43 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:41:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:41:05 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #4 from Claudio --- Created attachment 88919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88919&action=edit OpenID Internal Server Error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:41:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:41:06 +0000 Subject: [Koha-bugs] [Bug 22035] Improve local cover image browser page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22035 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:41:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:41:17 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:40:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:40:51 +0000 Subject: [Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:41:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:41:24 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #27 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:41:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:41:38 +0000 Subject: [Koha-bugs] [Bug 22621] Filters on subscription result list search the wrong column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:41:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:41:49 +0000 Subject: [Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:42:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:42:05 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #27 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:42:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:42:22 +0000 Subject: [Koha-bugs] [Bug 22765] Add class beside loggedinusername to indicate if logged in user is a superlibrarian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22765 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:47:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:47:51 +0000 Subject: [Koha-bugs] [Bug 22408] Subscription entry form cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Owen Leonard --- Sorry, I couldn't reproduce this problem. Do you have Mana turned on and configured? Did you test the same process in master? Thank you for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:51:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:51:43 +0000 Subject: [Koha-bugs] [Bug 16925] Shelving location search in OPAC nests search term in single quotes for every level of search results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16925 SiobhanC changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |siobhancottam at gmail.com --- Comment #2 from SiobhanC --- I'm not sure if this is the exact same problem, but when trying to sort an Advanced Search that uses a shelf location, it does not sort. The search term becomes further nested, as described above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:52:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:52:20 +0000 Subject: [Koha-bugs] [Bug 16925] Shelving location search in OPAC nests search term in single quotes for every level of search results. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16925 --- Comment #3 from SiobhanC --- I should have mentioned that this *is* happening in Chrome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 14:53:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 12:53:28 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #153 from Katrin Fischer --- Woohoooo! Thx, Stefan! Next time icecream is on me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:06:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:06:01 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #44 from Tom?s Cohen Arazi --- Comment on attachment 88894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88894 Bug 15496: Delete Bib After Moving Item > =head3 items > >-my @items = $biblio->items(); > my $items = $biblio->items(); > >-Returns the related Koha::Items object for this biblio in scalar context, >-or list of Koha::Item objects in list context. >+Returns the related Koha::Items object for this biblio > > =cut > >@@ -363,10 +361,7 @@ sub items { > > my $items_rs = $self->_result->items; > >- return >- wantarray >- ? Koha::Items->_new_from_dbic($items_rs)->as_list >- : Koha::Items->_new_from_dbic($items_rs); >+ return Koha::Items->_new_from_dbic( $items_rs ); > } This was a bad rebase. We should revert the last follow-up, and fix this. I can provide such a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:06:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:06:39 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:08:12 +0000 Subject: [Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kohadevinim at devinim.com.tr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:08:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:08:39 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall at gmail.com |kohadevinim at devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:08:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:08:51 +0000 Subject: [Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Assignee|kyle at bywatersolutions.com |kohadevinim at devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:08:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:08:53 +0000 Subject: [Koha-bugs] [Bug 17006] Add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Municipal Libray Ceska |Sponsored by Municipal release notes|Trebova |Library Ceska Trebova -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:14:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:14:58 +0000 Subject: [Koha-bugs] [Bug 22782] Schema change for SocialData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22096 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:14:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:14:58 +0000 Subject: [Koha-bugs] [Bug 22096] Missing default values in 'social_data' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22096 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22782 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:18:17 +0000 Subject: [Koha-bugs] [Bug 21943] Clean up holds template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:18:17 +0000 Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Bug 14546 depends on bug 21943, which changed state. Bug 21943 Summary: Clean up holds template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:19:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:19:00 +0000 Subject: [Koha-bugs] [Bug 22656] Report charts broken after bug 22023 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22656 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #5 from Martin Renvoize --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:20:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:20:15 +0000 Subject: [Koha-bugs] [Bug 21899] Update MARC21 frameworks to Update 27 (November 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21899 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:20:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:20:42 +0000 Subject: [Koha-bugs] [Bug 22372] Add shelving location to Holds awaiting pickup report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22372 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:20:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:20:45 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #45 from Tom?s Cohen Arazi --- Created attachment 88920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88920&action=edit Bug 15496: (QA follow-up) Restore Koha::Biblio->items broken by rebase This patch restores the implementation introduced by 22701. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:21:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:21:20 +0000 Subject: [Koha-bugs] [Bug 22311] Add a SysPref to allow adding content to the #moresearches div in the opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22311 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #8 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:21:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:21:49 +0000 Subject: [Koha-bugs] [Bug 11969] Show patrons star rating on their reading history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #12 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:21:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:21:53 +0000 Subject: [Koha-bugs] [Bug 15329] Show budget in addition to fund for late orders in acquisition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 --- Comment #2 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:21:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:21:44 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #46 from Tom?s Cohen Arazi --- (In reply to Kyle M Hall from comment #42) > Created attachment 88905 [details] [review] > Bug 15496: (QA follow-up) Fix new uses of Koha::Biblio::items in list context Work to be done, revert this one, and apply the last follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:22:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:22:15 +0000 Subject: [Koha-bugs] [Bug 3766] Cities/Towns only on one address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:22:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:22:46 +0000 Subject: [Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:23:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:23:16 +0000 Subject: [Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | --- Comment #9 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:23:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:23:50 +0000 Subject: [Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com --- Comment #29 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:24:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:24:18 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED --- Comment #21 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:24:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:24:18 +0000 Subject: [Koha-bugs] [Bug 22748] Wrong permission check in addbiblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22748 Bug 22748 depends on bug 20128, which changed state. Bug 20128 Summary: Permission for advanced editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:24:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:24:49 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #16 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:24:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:24:59 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:24:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:24:49 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Bug 22521 depends on bug 22547, which changed state. Bug 22547 Summary: C4::Overdues - UpdateFine is barely tested https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:29:06 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Text to go in the| |WARNING: You will need to release notes| |update your reports to | |account for the introduced | |use of 'status' in | |accountlines for fines. | | | |"accounttype = 'FU'" needs | |changing to "accounttype = | |'FINE' AND status = | |'UNRETURNED'" | | | |"accounttype | |= 'F'" needs changing to | |"accounttype = 'FINE' AND | |status != 'UNRETURNED'" Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #117 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:29:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:29:07 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Bug 22564 depends on bug 22521, which changed state. Bug 22521 Summary: Convert fines handling to use 'status' instead of two accounttypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:29:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:29:07 +0000 Subject: [Koha-bugs] [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519 Bug 22519 depends on bug 22521, which changed state. Bug 22521 Summary: Convert fines handling to use 'status' instead of two accounttypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:30:09 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|WARNING: You will need to |This patch clarifies the release notes|update your reports to |intended purpose of the |account for the introduced |various accounttypes used |use of 'status' in |for fines calculations in |accountlines for fines. |the accounttline table. | | |"accounttype = 'FU'" needs |WARNING: You will need to |changing to "accounttype = |update your reports to |'FINE' AND status = |account for the introduced |'UNRETURNED'" |use of 'status' in | |accountlines for fines. |"accounttype | |= 'F'" needs changing to |"accounttype = 'FU'" needs |"accounttype = 'FINE' AND |changing to "accounttype = |status != 'UNRETURNED'" |'FINE' AND status = | |'UNRETURNED'" | | | |"accounttype | |= 'F'" needs changing to | |"accounttype = 'FINE' AND | |status != 'UNRETURNED'" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:33:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:33:48 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #22 from Martin Renvoize --- Good catch, I think you're right, and exists would be more appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:36:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:36:37 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88920|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:37:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:37:05 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 --- Comment #23 from Martin Renvoize --- Created attachment 88921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88921&action=edit Bug 22461: (follow-up) Use `exists` not `defined` Prior to this patch there is a regression in the LDAP replication functionality such that clearing a field become impossible. This patch restores that functionality. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:39:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:39:49 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 --- Comment #18 from claire.hernandez at biblibre.com --- Created attachment 88922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88922&action=edit Mappings review -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:41:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:41:10 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 --- Comment #24 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 (including followup not yet in master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:41:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:41:20 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:42:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:42:13 +0000 Subject: [Koha-bugs] [Bug 22139] Fields of ACCTDETAILS not working properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #15 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:43:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:43:49 +0000 Subject: [Koha-bugs] [Bug 8701] Help for OpacHiddenItems pref should not point to text in install directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Severity|normal |enhancement Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #15 from Martin Renvoize --- Minor enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:45:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:45:01 +0000 Subject: [Koha-bugs] [Bug 21957] LinkBibHeadingsToAuthorities can be called twice when running link_bibs_to_authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21957 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #13 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:45:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:45:51 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #19 from Martin Renvoize --- Better safe than sorry I'm not going to backport this cleanup bug just in case anyone is using these fields locally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:47:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:47:05 +0000 Subject: [Koha-bugs] [Bug 6730] Rename 'basket' filter to 'basket name' on receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6730 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | --- Comment #8 from Martin Renvoize --- Minor string change, not backporting to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:47:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:47:37 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #31 from Martin Renvoize --- Great new enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:47:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:47:39 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Bug 22544 depends on bug 22318, which changed state. Bug 22318 Summary: Extend Koha news feature to include other content areas https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:50:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:50:27 +0000 Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Veronica changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vgolden at vtc.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:50:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:50:28 +0000 Subject: [Koha-bugs] [Bug 22783] New: 'Location' not picked up by translation toolchain Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Bug ID: 22783 Summary: 'Location' not picked up by translation toolchain Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Target Milestone: --- (In reply to paxed from bug 22318 comment #28) > This is not picked up by the translation toolchain: > > koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt: > [% SET location = "OPAC news" %] Moving this to it's own bug to get some attention. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:50:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:50:54 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 --- Comment #1 from Martin Renvoize --- Suggested fix (also from paxed) is: [% SET location = BLOCK %]OPAC news[% END %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:53:29 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 --- Comment #2 from Martin Renvoize --- Created attachment 88923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88923&action=edit Bug 22783: Make 'OPAC News' string translatable Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:54:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:54:06 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 [Bug 22783] 'Location' not picked up by translation toolchain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:54:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:54:06 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 [Bug 22318] Extend Koha news feature to include other content areas -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:54:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:54:19 +0000 Subject: [Koha-bugs] [Bug 22783] 'Location' not picked up by translation toolchain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22783 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:56:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:56:31 +0000 Subject: [Koha-bugs] [Bug 22532] Remove "random" from Z39.50 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22532 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:56:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:56:32 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 Bug 19220 depends on bug 22532, which changed state. Bug 22532 Summary: Remove "random" from Z39.50 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22532 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:57:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:57:20 +0000 Subject: [Koha-bugs] [Bug 22175] Make stock rotation table sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00 released in| | Resolution|--- |FIXED --- Comment #13 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:58:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:58:15 +0000 Subject: [Koha-bugs] [Bug 22645] Add 'ISSN' option to OPAC's basic search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22645 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #7 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 15:59:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 13:59:05 +0000 Subject: [Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:00:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:00:01 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #69 from Mirko Tietgen --- (Please declare the dependency in PerlDependencies, I'll do the rest.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:01:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:01:15 +0000 Subject: [Koha-bugs] [Bug 21545] Update German web Installer for 18.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Severity|enhancement |minor Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:02:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:02:00 +0000 Subject: [Koha-bugs] [Bug 21308] Show acq history search filters on search results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #11 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:02:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:02:23 +0000 Subject: [Koha-bugs] [Bug 21942] Clean up cataloging merge template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:05:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:05:25 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86749|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 88924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88924&action=edit Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. This patch adds to the user summary page in the OPAC a check for waiting or in-transit holds. If all holds are waiting or in transit the "Suspend all" controls will be hidden. This patch also adds a missing $KohaDates filter to the "suspended until" date. To test, apply the patch and log in to the OPAC as a patron with holds. Test these conditions: - All holds are waiting and/or in transit - The "Suspend holds" controls at the bottom of the page should not appear. - Some holds are waiting and/or in transit - The "Suspend holds" controls should appear. Signed-off-by: Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:05:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:05:23 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:15:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:15:30 +0000 Subject: [Koha-bugs] [Bug 22365] Warn on Log Viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22365 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:16:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:16:32 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88922|0 |1 is obsolete| | --- Comment #19 from claire.hernandez at biblibre.com --- Created attachment 88925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88925&action=edit (follow-up) Unimarc mappings evolution for Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:16:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:16:41 +0000 Subject: [Koha-bugs] [Bug 22365] Warn on Log Viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22365 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:20:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:20:49 +0000 Subject: [Koha-bugs] [Bug 22697] Reindent catalogue/result.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | --- Comment #5 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:25:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:25:47 +0000 Subject: [Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a popup/keyboard |Add a popup/keyboard |shortcuts for diacritics |shortcuts for diacritics |and symbols in the |and symbols in the advanced |cataloging editor |cataloging editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:28:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:28:40 +0000 Subject: [Koha-bugs] [Bug 569] Searches need 'browse' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:30:29 +0000 Subject: [Koha-bugs] [Bug 22584] Add YAML support for Codemirror In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Version(s)| |19.05.00 released in| | --- Comment #7 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:30:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:30:30 +0000 Subject: [Koha-bugs] [Bug 22757] Use YAML CodeMirror higlighting on YAML preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22757 Bug 22757 depends on bug 22584, which changed state. Bug 22584 Summary: Add YAML support for Codemirror https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:31:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:31:04 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #18 from Martin Renvoize --- Enahancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:31:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:31:04 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 21307, which changed state. Bug 21307 Summary: Switch two-column templates to Bootstrap grid: Cataloging https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:32:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:32:25 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|Pushed to Master |Pushed to Stable --- Comment #20 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:33:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:33:43 +0000 Subject: [Koha-bugs] [Bug 21937] Syspref autoBarcode annual doesn't increment properly barcode in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21937 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:34:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:34:43 +0000 Subject: [Koha-bugs] [Bug 22174] Add link to help page for API key management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22174 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | Severity|enhancement |normal --- Comment #6 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:35:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:35:36 +0000 Subject: [Koha-bugs] [Bug 22649] Add item type to item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22649 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | --- Comment #7 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:36:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:36:11 +0000 Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on report output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | --- Comment #28 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:36:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:36:13 +0000 Subject: [Koha-bugs] [Bug 22755] Import Koha::Script to patron_emailer cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22755 Bug 22755 depends on bug 16149, which changed state. Bug 16149 Summary: Generate and send custom notices based on report output https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:37:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:37:05 +0000 Subject: [Koha-bugs] [Bug 22687] Type in Koha::Manual breaks Portuguese links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22687 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable Severity|enhancement |normal --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:37:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:37:38 +0000 Subject: [Koha-bugs] [Bug 21783] Reindent admin/columns_settings.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:43:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:43:46 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:44:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:44:24 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #33 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:44:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:44:25 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Bug 22511 depends on bug 22564, which changed state. Bug 22564 Summary: accounttype 'Rep' is still referred to but is never set https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:44:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:44:25 +0000 Subject: [Koha-bugs] [Bug 22737] Restore patron replacement process for lost items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22737 Bug 22737 depends on bug 22564, which changed state. Bug 22564 Summary: accounttype 'Rep' is still referred to but is never set https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:45:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:45:32 +0000 Subject: [Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #18 from Martin Renvoize --- Follow-up pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:46:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:46:29 +0000 Subject: [Koha-bugs] [Bug 22759] Circulation rules for maxissueqty are applied per branch even for defaults In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #8 from Martin Renvoize --- Bug in enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:46:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:46:30 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Bug 21946 depends on bug 22759, which changed state. Bug 22759 Summary: Circulation rules for maxissueqty are applied per branch even for defaults https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22759 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:47:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:47:05 +0000 Subject: [Koha-bugs] [Bug 22679] circulation_rules are not deleted when accompanying issuingrules are deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22679 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #6 from Martin Renvoize --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:47:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:47:35 +0000 Subject: [Koha-bugs] [Bug 19618] Automatic/standing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Assignee|jesse at bywatersolutions.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:48:20 +0000 Subject: [Koha-bugs] [Bug 22735] Broken MARC and ISBD views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #13 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:49:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:49:15 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 --- Comment #21 from Tom?s Cohen Arazi --- Great work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:52:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:52:41 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:52:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:52:44 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88574|0 |1 is obsolete| | Attachment #88575|0 |1 is obsolete| | Attachment #88576|0 |1 is obsolete| | Attachment #88577|0 |1 is obsolete| | Attachment #88578|0 |1 is obsolete| | Attachment #88579|0 |1 is obsolete| | Attachment #88580|0 |1 is obsolete| | Attachment #88581|0 |1 is obsolete| | --- Comment #19 from Liz Rea --- Created attachment 88926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88926&action=edit Bug 21946: Database updates Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:53:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:53:46 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #20 from Liz Rea --- Created attachment 88927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88927&action=edit Bug 21946: SCHEMA UPDATES DO NOT PUSH Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:53:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:53:49 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #21 from Liz Rea --- Created attachment 88928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88928&action=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:53:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:53:53 +0000 Subject: [Koha-bugs] [Bug 22749] Koha::Item->hidden_in_opac should consider hidelostitems syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22749 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize --- Depends on bug not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:53:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:53:53 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #22 from Liz Rea --- Created attachment 88929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88929&action=edit Bug 21946: Update Administration->Item types to allow for defining parent types To test: 1 - Browse to Administration -> Item types 2 - Not a new colum for prent type 3 - Edit an existing type and not you can select any type (except the current) as a parent 4 - Select one 5 - Edit the type you selected as parent 6 - Note it cannot have a parent defined 7 - Edit a new type, note you can select a parent Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:53:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:53:56 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #23 from Liz Rea --- Created attachment 88930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88930&action=edit Bug 21946: Fix display of parent types Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:53:59 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #24 from Liz Rea --- Created attachment 88931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88931&action=edit Bug 21946: Use objects for displaying circulation rules Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:54:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:54:02 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #25 from Liz Rea --- Created attachment 88932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88932&action=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:54:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:54:08 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #27 from Liz Rea --- Created attachment 88934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88934&action=edit Bug 21946: (QA follow-up) - remove console.log To make QA tools happy Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:54:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:54:05 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #26 from Liz Rea --- Created attachment 88933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88933&action=edit Bug 21946: (follow-up) Correct dropdown when editing rule Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:54:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:54:44 +0000 Subject: [Koha-bugs] [Bug 22755] Import Koha::Script to patron_emailer cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22755 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize --- Dependency not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:55:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:55:15 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om --- Comment #102 from claire.hernandez at biblibre.com --- I see this line: $dbh->do( "UPDATE `search_field` SET `name` = 'date-of-publication', `label` = 'date-of-publication' WHERE `name` = 'pubdate'" ); The name is changed in database, but in YAML file, I always have pubdate, this has not been modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:56:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:56:49 +0000 Subject: [Koha-bugs] [Bug 22748] Wrong permission check in addbiblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22748 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #6 from Martin Renvoize --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:56:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:56:49 +0000 Subject: [Koha-bugs] [Bug 16232] Edit as new (duplicate) doesn't work correctly with Rancor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Bug 16232 depends on bug 22748, which changed state. Bug 22748 Summary: Wrong permission check in addbiblio.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22748 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:57:29 +0000 Subject: [Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | --- Comment #19 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:57:29 +0000 Subject: [Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407 Bug 22407 depends on bug 22700, which changed state. Bug 22700 Summary: Make biblio_metadata prefetchable from Koha::Biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:57:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:57:30 +0000 Subject: [Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Bug 22696 depends on bug 22700, which changed state. Bug 22700 Summary: Make biblio_metadata prefetchable from Koha::Biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:57:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:57:54 +0000 Subject: [Koha-bugs] [Bug 22694] Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | --- Comment #10 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:57:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:57:55 +0000 Subject: [Koha-bugs] [Bug 22457] OpacHiddenItemsExceptions should be moved to a category attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Bug 22457 depends on bug 22694, which changed state. Bug 22694 Summary: Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:57:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:57:55 +0000 Subject: [Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Bug 22696 depends on bug 22694, which changed state. Bug 22694 Summary: Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:58:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:58:27 +0000 Subject: [Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407 Bug 22407 depends on bug 22701, which changed state. Bug 22701 Summary: Make items prefetchable from Koha::Biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22701 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:58:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:58:28 +0000 Subject: [Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Bug 22696 depends on bug 22701, which changed state. Bug 22701 Summary: Make items prefetchable from Koha::Biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22701 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:58:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:58:53 +0000 Subject: [Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #10 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:58:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:58:27 +0000 Subject: [Koha-bugs] [Bug 22701] Make items prefetchable from Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22701 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:59:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:59:34 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:59:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:59:37 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #40 from Kyle M Hall --- Created attachment 88935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88935&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:59:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:59:47 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #41 from Kyle M Hall --- Created attachment 88936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88936&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 16:59:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 14:59:36 +0000 Subject: [Koha-bugs] [Bug 21784] Clean up js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21784 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00 released in| | --- Comment #5 from Martin Renvoize --- Enhancement will not be backported into 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:00:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:00:10 +0000 Subject: [Koha-bugs] [Bug 22674] Change wording of payments in the GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22674 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:00:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:00:41 +0000 Subject: [Koha-bugs] [Bug 22418] Authority link magnifying glass icon doesn't appear for 655 subject tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00 released in| | Resolution|--- |FIXED --- Comment #9 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:01:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:01:10 +0000 Subject: [Koha-bugs] [Bug 21034] Re-indent circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | --- Comment #14 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:01:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:01:16 +0000 Subject: [Koha-bugs] [Bug 21651] Force insert of notices related tables during the install process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Liz Rea --- This was a thing I wanted Alex to do along with the onboarder, but translation problems hung it up. Usability wise YES 100% we should not allow mandatory ones to be unticked. But you (or somebody) can do that on another bug if you like. :) I'll test it again, with that not in the test plan and update the commit message if it looks ok. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:01:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:01:41 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 22751, which changed state. Bug 22751 Summary: Switch two-column templates to Bootstrap grid: Patron details https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22751 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:01:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:01:41 +0000 Subject: [Koha-bugs] [Bug 22751] Switch two-column templates to Bootstrap grid: Patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22751 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:04:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:04:16 +0000 Subject: [Koha-bugs] [Bug 22762] Collection codes not displayed on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #9 from Martin Renvoize --- 18.11 version pushed to 18.11.x for 18.11.05. Thanks Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:06:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:06:05 +0000 Subject: [Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:07:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:07:00 +0000 Subject: [Koha-bugs] [Bug 22723] Syntax error on confess call in Koha/MetadataRecord/Authority.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #9 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:09:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:09:27 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #9 from Matthias Meusburger --- Frido, I don't get the status of this BZ or your comment. The patch applies on master. What is to rebase exactly? Which bug are you referring to? What are you expecting me to do? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:11:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:11:08 +0000 Subject: [Koha-bugs] [Bug 16232] Edit as new (duplicate) doesn't work correctly with Rancor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:12:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:12:00 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #33 from Liz Rea --- I think this test failure may be related to bug 22453 - I've got a correct date/tz devbox this morning and it's all ok - I'm sorry I didn't catch that yesterday. Onward with testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:12:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:12:20 +0000 Subject: [Koha-bugs] [Bug 22739] Self check in module JS breaks if SelfCheckInTimeout is unset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22739 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:12:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:12:50 +0000 Subject: [Koha-bugs] [Bug 22729] flgAnonymized shouldn't be NULL and should be renamed anonymized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED --- Comment #25 from Martin Renvoize --- Bug in enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:13:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:13:00 +0000 Subject: [Koha-bugs] [Bug 22784] New: Archiving Purchase Suggestions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Bug ID: 22784 Summary: Archiving Purchase Suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Create a way to archive the 'completed' purchase suggestions on the staff side. 1. Add an 'archived' column to purchase suggestions 2. Add a script to automatically mark suggestions of a certain age and status as archived 3. Add a button on the purchase suggestions page to archive specific suggestions 4. Add a 'view archived suggestions' button to view archived suggestions. Default view does not display archived suggestions 5. Add 'archived' option to the filters on the purchase suggestions page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:14:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:14:24 +0000 Subject: [Koha-bugs] [Bug 22743] OverDrive results page is missing overdrive-login include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22743 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:15:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:15:32 +0000 Subject: [Koha-bugs] [Bug 19241] Items with status of hold show as available in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:15:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:15:54 +0000 Subject: [Koha-bugs] [Bug 19241] Items with status of hold show as available in cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:17:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:17:52 +0000 Subject: [Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #6 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:18:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:18:44 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #24 from Martin Renvoize --- This could be a rather confusing change for a stable branch.. opting not to backport to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:18:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:18:51 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:20:10 +0000 Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #25 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:22:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:22:35 +0000 Subject: [Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette Scheer --- This would be very helpful for a number of libraries I've talked with about purchase suggestions. Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:23:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:23:19 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #12 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:24:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:24:28 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #103 from Katrin Fischer --- (In reply to claire.hernandez at biblibre.com from comment #102) > I see this line: > $dbh->do( "UPDATE `search_field` SET `name` = 'date-of-publication', `label` > = 'date-of-publication' WHERE `name` = 'pubdate'" ); > > The name is changed in database, but in YAML file, I always have pubdate, > this has not been modified. Hi Claire, can you please open a new bug report and link to this one? It's already in a released version, so we need a fix on a new bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:24:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:24:37 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Search settings are lost after sorting, faceting or paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #14 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:25:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:25:26 +0000 Subject: [Koha-bugs] [Bug 22551] Stray "//" appears at bottom of opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #13 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:26:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:26:24 +0000 Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com --- Comment #36 from Martin Renvoize --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:27:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:27:02 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | --- Comment #66 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:27:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:27:03 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Bug 22200 depends on bug 22511, which changed state. Bug 22511 Summary: Koha::Account::Line->void loses the original type of the credit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:28:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:28:08 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #15 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:29:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:29:49 +0000 Subject: [Koha-bugs] [Bug 22734] Fund not marked as mandatory when ordering from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |enhancement Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #10 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:30:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:30:23 +0000 Subject: [Koha-bugs] [Bug 22734] Fund not marked as mandatory when ordering from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #11 from Martin Renvoize --- Do we need a new bug opening for comment #8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:30:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:30:59 +0000 Subject: [Koha-bugs] [Bug 22664] Link basket name and basket group name instead of the, often short, basket numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22664 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | --- Comment #17 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:31:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:31:03 +0000 Subject: [Koha-bugs] [Bug 22785] New: Manage Multiple Matches when importing through Stage Marc Record Import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Bug ID: 22785 Summary: Manage Multiple Matches when importing through Stage Marc Record Import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Work to be done: On the stage-marc-import.pl screen, the wording would change from: [X] records with at least one match in catalog per matching rule "Y" To [X] records with one match in catalog per matching rule "Y" [X] records with two or more matches in catalog per matching rule "Y" On the manage-marc-import.pl?import_batch_id=#### screen, each record number that is a match would be displayed (multiple matches). The user would then be able to click to see all matches (modal/popup) and select (checkbox) which record(s) they would like to overlay. User would have the option of selecting none, one, or multiple records. - if there are items on the imported record and items are being imported then only one record could be selected - selecting multiple records would overlay the record onto each selected record - no records existing in the catalog would be merged by this tool - the default selection would be the first record found -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:31:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:31:33 +0000 Subject: [Koha-bugs] [Bug 22764] More YUI grid cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:31:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:31:34 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 22764, which changed state. Bug 22764 Summary: More YUI grid cleanup https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:32:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:32:12 +0000 Subject: [Koha-bugs] [Bug 16698] UpdateItemLocationOnCheckin preference needs a gui editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16698 Bug 16698 depends on bug 14576, which changed state. Bug 14576 Summary: Allow automatic update of location on checkin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:32:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:32:12 +0000 Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on checkout based on syspref values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Bug 21159 depends on bug 14576, which changed state. Bug 14576 Summary: Allow automatic update of location on checkin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:32:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:32:13 +0000 Subject: [Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Bug 21502 depends on bug 14576, which changed state. Bug 14576 Summary: Allow automatic update of location on checkin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:32:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:32:10 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | --- Comment #150 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:32:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:32:53 +0000 Subject: [Koha-bugs] [Bug 22556] Add ability to quickly filter funds/budgets by library on the Acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:44:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:44:53 +0000 Subject: [Koha-bugs] [Bug 21534] ElasticSearch - Dash is considered like a boolean operator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534 --- Comment #4 from Marjorie Barry-Vila --- (In reply to Nick Clemens from comment #1) > I tested this on master and cannot recreate. > > According to the docs: > https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl- > query-string-query.html > > Hyphen is considered a boolean 'not' operator > > in testing though it seems to work as long as there is no space Hi Nick, You may not have been able to reproduce the problem on your side because the QueryAutoTruncate system preference was already set to "only if a * is added"? I realized that I was getting results if I changed the system preference for this option. On the other hand, with the preference system on "only if a * is added" if I search : saints-anges* this gives no result (cgi-bin/koha/opac-search.pl?q=saints-anges*) Could you test this point? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:48:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:48:02 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #34 from Liz Rea --- This morning I've got something different: I have a test failing in Libraries.t - I've updated all the things(dbic and restart_all) and I feel like it should be good to go, but it's not >.< 1..2 # Subtest: UseBranchTransferLimits = OFF 1..5 # No tests run! not ok 1 - No tests run for subtest "UseBranchTransferLimits = OFF" # Failed test 'No tests run for subtest "UseBranchTransferLimits = OFF"' # at t/db_dependent/Koha/Libraries.t line 152. # Looks like you planned 2 tests but ran 1. # Looks like you failed 1 test of 1 run. not ok 6 - pickup_locations# Failed test 'pickup_locations' # at t/db_dependent/Koha/Libraries.t line 409. The method Koha::Items->pickup_locations is not covered by tests! I know you all want to get this feature in before slush, sorry to keep bouncing it back to you. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:52:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:52:44 +0000 Subject: [Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize --- Bug not in 18.11.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:52:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:52:33 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- not backporting to 18.05.x . Needs rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:54:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:54:19 +0000 Subject: [Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #28 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:55:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:55:07 +0000 Subject: [Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize at ptfs-europe | |.com --- Comment #12 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:56:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:56:09 +0000 Subject: [Koha-bugs] [Bug 22621] Filters on subscription result list search the wrong column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:56:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:56:47 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FOR) does not create a FORGIVEN credit line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #28 from Martin Renvoize --- Depends on enhancements not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:56:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:56:48 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Bug 22563 depends on bug 22200, which changed state. Bug 22200 Summary: Forgiving a fine (FOR) does not create a FORGIVEN credit line https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:57:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:57:41 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #11 from Martin Renvoize --- Prefer not to tidy out during stable cycle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:58:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:58:04 +0000 Subject: [Koha-bugs] [Bug 22035] Improve local cover image browser page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22035 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Version(s)| |19.05.00 released in| | --- Comment #5 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:58:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:58:20 +0000 Subject: [Koha-bugs] [Bug 22652] Editing Course reserves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:58:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:58:45 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #47 from Martin Renvoize --- Dependants not in 18.11.x series.. will not be backported at this time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:59:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:59:08 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:59:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:59:36 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #18 from Martin Renvoize --- Enhancement will not be backported at this time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 17:59:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 15:59:36 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass --- missing dependency for 18.05.x, not backporting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 18:00:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 16:00:19 +0000 Subject: [Koha-bugs] [Bug 22765] Add class beside loggedinusername to indicate if logged in user is a superlibrarian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22765 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 18:00:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 16:00:51 +0000 Subject: [Koha-bugs] [Bug 22688] TT plugin for pickup locations code wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22688 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #21 from Lucas Gass --- missing dependencies for 18.05.x, not backporting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 18:01:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 16:01:48 +0000 Subject: [Koha-bugs] [Bug 22069] Log viewer not displaying item renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #16 from Lucas Gass --- not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:10:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:10:47 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #48 from Tom?s Cohen Arazi --- Created attachment 88938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88938&action=edit Bug 15496: (QA follow-up) Fix remaining cases This patch fixes remaining cases of the list => scalar change. To test: - Run: $ kshell k$ prove t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Reserves.t => FAIL: Tests fail - Apply this patch - Run: k$ prove t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Reserves.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:21:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:21:48 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:21:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:21:54 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88801|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:21:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:21:56 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:21:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:21:59 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88793|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:22:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:22:02 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88794|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:22:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:22:05 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88795|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:21:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:21:51 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88800|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:22:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:22:07 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88796|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:22:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:22:10 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88797|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:22:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:22:12 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88798|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:22:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:22:15 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88799|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:23:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:23:03 +0000 Subject: [Koha-bugs] [Bug 22786] New: Can create new funds for locked budgets Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 Bug ID: 22786 Summary: Can create new funds for locked budgets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- To recreate: 1 - Have a budget 2 - Lock it 3 - Click on a fund from acqui-home to view funds for the budget 4 - Select new->New fund for budget 5 - Note the link displays as disabled 6 - Click it and note it is not disabled 7 - Add a new budget -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:23:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:23:14 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #35 from Tom?s Cohen Arazi --- Created attachment 88939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88939&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) run perl installer/data/mysql/updatedatabase.pl SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:23:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:23:18 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #36 from Tom?s Cohen Arazi --- Created attachment 88940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88940&action=edit Bug 22284: (follow-up) Add schema modifications Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:23:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:23:22 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #37 from Tom?s Cohen Arazi --- Created attachment 88941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88941&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:23:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:23:26 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #38 from Tom?s Cohen Arazi --- Created attachment 88942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88942&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:23:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:23:29 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #39 from Tom?s Cohen Arazi --- Created attachment 88943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88943&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:23:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:23:33 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #40 from Tom?s Cohen Arazi --- Created attachment 88944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88944&action=edit Bug 22284: New messages in reserve/request.tt This patch adds new messages to 'Hold' column in 'Place a hold on a specific item' table Those messages are 1) Cannot place hold from patrons's library: this message appears when patron's homebranch is not in item's hold group 2) Pickup library is not in hold group: self explanatory To test: 1) In library groups add a root group and check it as hold group. 2) Add a library to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 4) Search a patron from a different library than step 2, select one and click 'search to hold' 5) Search by location for items in the library of step 2 6) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column 7) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 4 to 6 SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Pickup library is not in hold group" in 'Hold' column 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:23:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:23:37 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #41 from Tom?s Cohen Arazi --- Created attachment 88945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88945&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:23:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:23:41 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #42 from Tom?s Cohen Arazi --- Created attachment 88946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88946&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:23:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:23:44 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #43 from Tom?s Cohen Arazi --- Created attachment 88947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88947&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:23:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:23:48 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #44 from Tom?s Cohen Arazi --- Created attachment 88948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88948&action=edit Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:26:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:26:26 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 [Bug 15496] Delete bibliographic record after moving last item to another record(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:26:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:26:26 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:27:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:27:22 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #45 from Agust?n Moyano --- New dependency on bug 15496 only needs to apply last patch 88938 - Bug 15496: (QA follow-up) Fix remaining cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:31:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:31:14 +0000 Subject: [Koha-bugs] [Bug 22786] Can create new funds for locked budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9628 [Bug 9628] Replace YUI buttons and menus on budgets administration pages with Bootstrap -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:31:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:31:14 +0000 Subject: [Koha-bugs] [Bug 9628] Replace YUI buttons and menus on budgets administration pages with Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9628 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 [Bug 22786] Can create new funds for locked budgets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:34:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:34:02 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #46 from Agust?n Moyano --- Created attachment 88949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88949&action=edit Bug 22284: (follow-up) fixes after 15496 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:43:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:43:41 +0000 Subject: [Koha-bugs] [Bug 22687] Typo in Koha::Manual breaks Portuguese links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22687 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Type in Koha::Manual breaks |Typo in Koha::Manual breaks |Portuguese links |Portuguese links CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:45:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:45:23 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88938|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize --- Created attachment 88950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88950&action=edit Bug 15496: (QA follow-up) Fix remaining cases This patch fixes remaining cases of the list => scalar change. To test: - Run: $ kshell k$ prove t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Reserves.t => FAIL: Tests fail - Apply this patch - Run: k$ prove t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Reserves.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:46:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:46:03 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #50 from Martin Renvoize --- Final follow-up tested.. working solidly for me, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:48:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:48:33 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_22787=5D_New=3A_Mapping_missing_for_?= =?utf-8?q?=C5=AF_to_u_in_word-phrafe-utf-chr?= Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22787 Bug ID: 22787 Summary: Mapping missing for ? to u in word-phrafe-utf-chr Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The problem was noticed when searching for this author: https://en.wikipedia.org/wiki/Bohuslav_Martin%C5%AF It seems we map this: https://software.hixie.ch/utilities/cgi/unicode-decoder/character-identifier?characters=u%CC%8A But not: https://software.hixie.ch/utilities/cgi/unicode-decoder/character-identifier?characters=%C5%AF -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:53:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:53:24 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_22787=5D_Mapping_missing_for_=C5=AF_?= =?utf-8?q?to_u_in_word-phrase-utf-chr?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22787 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Mapping missing for ? to u |Mapping missing for ? to u |in word-phrafe-utf-chr |in word-phrase-utf-chr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:54:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:54:03 +0000 Subject: [Koha-bugs] [Bug 22788] New: Wrong accruing Overdue Amount Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22788 Bug ID: 22788 Summary: Wrong accruing Overdue Amount Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: hien.pham at dlcorp.com.vn QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Created attachment 88951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88951&action=edit Accruing fine amount Hi All, I found an issue with fine function on koha 18.11.02. Please help to check. When the item is overdue, koha run fines.pl cronjob and update accruing fine to patron account. But i think something wrong when koha run fines.pl cronjob to update accruing fine. Example: I checked out two barcode for one patron account. The barcodes have the same item type, checkout from same location and same time. System configuration: - CalculateFinesOnReturn option is "Do" - finesMode is "Calculate and charge" - Loan period: 21 days - Fine amount: RM0.5/day - Overdue fines cap (amount): RM40 I checked out item on January 06, 2019 and item overdue on January 27, 2019. By circulation rule, patron has RM40 accruing fine in his account for one overdue item. But when i check accruing fine of patron, i see accruing fine incorrectly and timestamp of action is not today. The attached file is screenshot of this issue. Besides, this issue don't happen with all patron account in koha. Please help to check this -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:54:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:54:08 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #51 from Nick Clemens --- (In reply to Martin Renvoize from comment #50) > Final follow-up tested.. working solidly for me, thanks Tomas! Final follow-up pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:54:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:54:25 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 --- Comment #25 from Nick Clemens --- (In reply to Martin Renvoize from comment #23) > Created attachment 88921 [details] [review] > Bug 22461: (follow-up) Use `exists` not `defined` > > Prior to this patch there is a regression in the LDAP replication > functionality such that clearing a field become impossible. This patch > restores that functionality. > > Signed-off-by: Martin Renvoize Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:55:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:55:07 +0000 Subject: [Koha-bugs] [Bug 22788] Wrong accruing Overdue Amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22788 --- Comment #1 from hienpn --- Created attachment 88952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88952&action=edit Checkout transaction -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:55:36 +0000 Subject: [Koha-bugs] [Bug 22788] Wrong accruing Overdue Amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22788 hienpn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hien.pham at dlcorp.com.vn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 19:56:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 17:56:08 +0000 Subject: [Koha-bugs] [Bug 22788] Wrong accruing Overdue Amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22788 hienpn changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 20:42:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 18:42:17 +0000 Subject: [Koha-bugs] [Bug 22408] Subscription entry form cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 20:42:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 18:42:20 +0000 Subject: [Koha-bugs] [Bug 22408] Subscription entry form cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88189|0 |1 is obsolete| | --- Comment #8 from Michal Denar --- Created attachment 88953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88953&action=edit Bug 22408: Subscription entry form cleanup This patch makes a number of changes to the subscription entry form: - Make the default layout single-column. - Switch the layout to two-column only when testing prediction pattern. - Add a button to hide the prediction pattern test pane. - Change the style of some buttons and links. Add Font Awesome icons to some. - Clean up some issues with capitalization and spacing. - Make it clearer when form fields are read-only: Move "locked" form field style from addbiblio.css to staff-global.css and improve it with regard to mouse interactions To test, apply the patch and regenerate the staff client CSS. Clear your browser cache if necessary. - Go to Serials -> New subscription. - Readonly fields under "Vendor" and "Record" should show a small padlock icon. - Test the process of adding a subscription, paying special attention to the advanced pattern controls: Showing, hiding, modifying, canceling. - Test the process of editing a subscription in the same way. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 20:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 18:53:33 +0000 Subject: [Koha-bugs] [Bug 21512] CalculateFinesOnReturn doesn't work without the syspref finesMode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512 hienpn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hien.pham at dlcorp.com.vn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:22 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:24 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:27 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:29 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88941|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:32 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88942|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:34 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:37 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:39 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88945|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:42 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88946|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:44 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88947|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:47 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88948|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:15:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:15:49 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88949|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:16:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:16:51 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #48 from Agust?n Moyano --- Created attachment 88956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88956&action=edit Bug 22284: (follow-up) Add schema modifications Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:16:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:16:55 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #49 from Agust?n Moyano --- Created attachment 88957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88957&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:16:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:16:59 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #50 from Agust?n Moyano --- Created attachment 88958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88958&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:17:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:17:03 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #51 from Agust?n Moyano --- Created attachment 88959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88959&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:17:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:17:07 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #52 from Agust?n Moyano --- Created attachment 88960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88960&action=edit Bug 22284: New messages in reserve/request.tt This patch adds new messages to 'Hold' column in 'Place a hold on a specific item' table Those messages are 1) Cannot place hold from patrons's library: this message appears when patron's homebranch is not in item's hold group 2) Pickup library is not in hold group: self explanatory To test: 1) In library groups add a root group and check it as hold group. 2) Add a library to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 4) Search a patron from a different library than step 2, select one and click 'search to hold' 5) Search by location for items in the library of step 2 6) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column 7) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 4 to 5 9) Find a biblio with items in 2 different libraries SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Pickup library is not in hold group" in 'Hold' column for the item that has no hold group 10) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:16:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:16:48 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #47 from Agust?n Moyano --- Created attachment 88955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88955&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) run perl installer/data/mysql/updatedatabase.pl SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:17:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:17:11 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #53 from Agust?n Moyano --- Created attachment 88961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88961&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:17:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:17:15 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #54 from Agust?n Moyano --- Created attachment 88962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88962&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:17:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:17:18 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #55 from Agust?n Moyano --- Created attachment 88963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88963&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:17:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:17:22 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #56 from Agust?n Moyano --- Created attachment 88964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88964&action=edit Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:17:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:17:26 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #57 from Agust?n Moyano --- Created attachment 88965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88965&action=edit Bug 22284: (follow-up) fixes after 15496 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:40:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:40:56 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com --- Comment #6 from Michal Denar --- Hi Ere, I'm not sure why, but search with range don't work for me. Test passed. If I try 1989-2001 I get "No results match your search with limit(s): 'copydate:1989-2001'. " I chcecked all twoce but same results. Mike -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:42:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:42:18 +0000 Subject: [Koha-bugs] [Bug 22789] New: Establish Non-Priority Holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Bug ID: 22789 Summary: Establish Non-Priority Holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- This development would allow holds to be placed so the hold wouldn't prevent the current checkout from renewing the hold. The goal is a better customer service because certain library departments will place holds to repair or replace a book when it is returned to the library (the internal library need has no rush), they only want the catch the book on it's return. The library needs to allow the patron who has it out have the flexibility to renew it on their account without a staff override. This functionality would be specific to the staffside only. - Add a Checkbox on the hold form that stipulates that the hold being placed is a 'non-priority' hold. - Add a field in the reserves tables to flag the hold as 'non-priority'. - The checkreserves module in Koha checks for this flag. If found, the hold request is 'ignored' and item can be renewed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:42:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:42:48 +0000 Subject: [Koha-bugs] [Bug 22790] New: The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Bug ID: 22790 Summary: The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: andreas.jonsson at kreablo.se QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- I would expect the filter specified by the system preference itemBarcodeInputFilter to be applied to any item barcode inputed to the system. As equipment connected via SIP2 is used to input item barcodes, the filter should be applied. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:46:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:46:35 +0000 Subject: [Koha-bugs] [Bug 22790] The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 --- Comment #1 from Andreas Jonsson --- Created attachment 88966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88966&action=edit Bug 22790: The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:48:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:48:51 +0000 Subject: [Koha-bugs] [Bug 22790] The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 --- Comment #2 from Andreas Jonsson --- Testplan for kohadevbox: 1. Set syspref itemBarcodeInputFilter to "Remove spaces from" 2. Disable syspref RequireStrongPassword 3. Add a bibliographic record 4. Add an item with barcode '12' 5. Add a borrower with cardnumber 2 and password aaa 6 Add a borrower with username term1 and password term1 and grant circulate permissions 7. Confirm that this input match the item added in step 2. 8. Login to server via ssh and run 'sudo koha-sip-enable kohadev && sudo koha-start-sip kohadev' 9. Try checking out an item using sip: /usr/share/koha/bin/sip_cli_emulator.pl --sip_user=term1 --sip_pass=term1 --patron=2 --password=aaa --item='1 2' -m checkout -a 127.0.0.1 -p 6001 -l MAIN 10. Without patch, the sip response will be 'Invalid item' 11. With patch, the sip response will be 'Item cannot be issued: TOO_MANY' (or any other response indicating that the item was at least found) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:50:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:50:24 +0000 Subject: [Koha-bugs] [Bug 22790] The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:52:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:52:13 +0000 Subject: [Koha-bugs] [Bug 21533] Do not allow password recovery for administrative locked patrons (see 21336) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21533 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88904|0 |1 is obsolete| | --- Comment #3 from Bouzid Fergani --- Created attachment 88967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88967&action=edit Bug 21533: Do not allow password recovery for administrative locked patrons Depends on bug 21336 for the ADMINISTRATIVE_LOCKOUT constant. This is a bit lazy solution (but good enough): The account will not be found when recovering the password. The user should contact the library. Since the library chose to lock the account, that seems appropriate. Test plan: Select a borrower and set login_attempts to -1. Via mysql command line or with Koha::Patrons->find(borrowernumber)->lock. Enable password recovery. Try to recover password from OPAC. You should fail with 'Not found, contact the library'. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:57:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:57:44 +0000 Subject: [Koha-bugs] [Bug 22791] New: Calculation differs on aqui-home/spent and ordered.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Bug ID: 22791 Summary: Calculation differs on aqui-home/spent and ordered.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Order an example with 8 * 16,99 and 42% discount, 19.45% tax. Ordered.pl is doing: get_rounded_price( quantity * price ) Other pages are: quantity * get_rounded_price( price ) The second is more correct I believe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:57:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:57:52 +0000 Subject: [Koha-bugs] [Bug 22791] Calculation differs on aqui-home/spent and ordered.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18736 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 [Bug 18736] Problems in order calculations (rounding errors) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:57:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:57:52 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 [Bug 22791] Calculation differs on aqui-home/spent and ordered.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:59:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:59:53 +0000 Subject: [Koha-bugs] [Bug 22791] Calculation differs on aqui-home/spent and ordered.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 21:59:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 19:59:55 +0000 Subject: [Koha-bugs] [Bug 22791] Calculation differs on aqui-home/spent and ordered.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 --- Comment #1 from Nick Clemens --- Created attachment 88968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88968&action=edit Bug 22791: Unify calculation between aqui-home and ordered.pl To test: 1 - Enable order price rounding 2 - Order an example with 8 * 16,99 and 42% discount, 19.45% tax. 3 - Check ordered page - 94.17 is total 4 - Check aqui-home - 94.16 is total 5 - Apply patch 6 - Verify numbers now match -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 22:29:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 20:29:11 +0000 Subject: [Koha-bugs] [Bug 21036] Fix a bunch of older warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78456|0 |1 is obsolete| | --- Comment #13 from Bouzid Fergani --- Created attachment 88969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88969&action=edit Bug 21036: Remove odd number of elements warnings from AuthoritiesMarc.pm Like this one (16.11 line number): Odd number of elements in anonymous hash at C4/AuthoritiesMarc.pm line 1070. We need to add a scalar to some MARC::Field::subfield calls. In list context an empty list returned affects the hash built around it. Test plan: Could reproduce this warning easily from OPAC authority search. opac-authorities-home.pl calling BuildSummary. Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 23:07:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 21:07:44 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77756|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 23:30:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 21:30:24 +0000 Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 --- Comment #4 from Marie-Luce Laflamme --- Created attachment 88970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88970&action=edit Bug 21042: Make 'pay amount' also return lost fines To test: 1 - Checkout an item to a patron, and make it lost ( but not returned) and ensure fine is levied against the account 2 - Add some other fines to their account 3 - Click 'Pay amount' and pay everything they owe 4 - Note the book is not returned 5 - Repeat with 'Pay selected' and note item is returned 6 - Apply patch 7 - Repeat 1-5 and note item is returned in both cases -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 23:33:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 21:33:51 +0000 Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 --- Comment #5 from Marie-Luce Laflamme --- Created attachment 88971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88971&action=edit toto -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 23:39:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 21:39:37 +0000 Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88971|0 |1 is obsolete| | --- Comment #6 from Marie-Luce Laflamme --- Created attachment 88972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88972&action=edit toto -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 23:43:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 21:43:49 +0000 Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme at inlibro | |.com Attachment #88970|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 23:44:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 21:44:01 +0000 Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88972|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 23:53:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 21:53:03 +0000 Subject: [Koha-bugs] [Bug 21042] Pay amount does not mark lost items as returned when those accountlines are paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21042 --- Comment #4 from Marie-Luce Laflamme --- Created attachment 88973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88973&action=edit Bug 21042: Make 'pay amount' also return lost fines To test: 1 - Checkout an item to a patron, and make it lost ( but not returned) and ensure fine is levied against the account 2 - Add some other fines to their account 3 - Click 'Pay amount' and pay everything they owe 4 - Note the book is not returned 5 - Repeat with 'Pay selected' and note item is returned 6 - Apply patch 7 - Repeat 1-5 and note item is returned in both cases https://bugs.koha-community.org/show_bug.cgi?id=21014 Signed-off-by: marieluce -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 26 23:54:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 21:54:03 +0000 Subject: [Koha-bugs] [Bug 21042] Pay amount does not mark lost items as returned when those accountlines are paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21042 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme at inlibro | |.com Attachment #88973|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 00:05:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 22:05:01 +0000 Subject: [Koha-bugs] [Bug 22782] Schema change for SocialData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22782 --- Comment #1 from Jonathan Druart --- *** Bug 22096 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 00:05:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 22:05:01 +0000 Subject: [Koha-bugs] [Bug 22096] Missing default values in 'social_data' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22096 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 22782 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 00:06:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 22:06:50 +0000 Subject: [Koha-bugs] [Bug 22782] Schema change for SocialData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22782 --- Comment #2 from Jonathan Druart --- My bet would be a change in DBIx::Class::Schema::Loader, however I did not find it. social_data.isbn is a varchar and used as PK, so cannot be NULL, I guess that's why it has a default ''. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 00:07:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 22:07:50 +0000 Subject: [Koha-bugs] [Bug 22782] Schema change for SocialData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22782 --- Comment #3 from Jonathan Druart --- Also note that "show create table" will display the NOT NULL constraint: `isbn` varchar(30) COLLATE utf8mb4_unicode_ci NOT NULL, It looks safe to commit, and better to fix the kohastructure.sql as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 00:14:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 22:14:02 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #26 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #25) > + my @enabled_languages = > + ( $interface && $interface eq 'intranet' ) > + ? split ",", C4::Context->preference('language') > + : split ",", C4::Context->preference('opaclanguage'); > > Seems to reverse the previous logic. If eq opac then opac else intranet. I do not think I get that one, please read again the whole diff: before: if $interface == opac: use opaclanguages elsif $interface == intranet: use language else: use opaclanguages after: if $interface == intranet: use language else: use opaclanguages Looks equal for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 01:48:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 23:48:25 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766 [Bug 22766] Tags cloud link in OPAC does not work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 01:48:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 23:48:25 +0000 Subject: [Koha-bugs] [Bug 22766] Tags cloud link in OPAC does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14385 Assignee|oleonard at myacpl.org |mtompset at hotmail.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Caused by bug 14385. Mark, could you take a look? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 01:51:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 23:51:40 +0000 Subject: [Koha-bugs] [Bug 22766] Tags cloud link in OPAC does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22420 --- Comment #4 from Jonathan Druart --- Note that Tomas's patch from bug 22420 might fix this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 01:51:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 23:51:40 +0000 Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22766 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 01:52:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 23:52:12 +0000 Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 --- Comment #7 from Jonathan Druart --- Sending to NSO with your patch then ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 01:52:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 23:52:22 +0000 Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 01:52:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Apr 2019 23:52:31 +0000 Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85748|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:12:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:12:16 +0000 Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:16:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:16:16 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Hello Claudio, If there is a 500 error you might have an error in the log. It would help a lot to have it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:18:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:18:38 +0000 Subject: [Koha-bugs] [Bug 22484] /svc/members/search has no tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22781 --- Comment #1 from Jonathan Druart --- There is none indeed. What would you want to test? I think we should provide along with bug 22781. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:18:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:18:38 +0000 Subject: [Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22484 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:27:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:27:46 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #6 from Claudio --- Jonathan, hope this helps: /var/log/koha/INSTANCE/plack-error,log ======================================================== Can't locate Koha/Plugin/EDS in @INC (@INC contains: /usr/share/koha/lib /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86$ Attempt to reload Koha/Plugin/EDS.pm aborted. Compilation failed in require at /usr/share/perl/5.20/Module/Load.pm line 77. Can't locate Koha/Plugin/EDS in @INC (@INC contains: /usr/share/koha/lib /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86$ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:35:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:35:50 +0000 Subject: [Koha-bugs] [Bug 22552] Adding users to serials routing search requires edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22552 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Just asking but, does it really appear in a real life condition? How could we fix that? Considering it a config issue? Add a new "search patrons" permissions (and so hide the "Add recipients" link in this case)? Hide the link if logged in patron does not have edit_borrowers? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:45:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:45:26 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #7 from Jonathan Druart --- Do you use the EDS plugin? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:46:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:46:09 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22777 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:46:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:46:09 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22717 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:47:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:47:27 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #8 from Claudio --- No Jonathan, I do not use EDS plugin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:52:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:52:00 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 --- Comment #1 from Jonathan Druart --- Hi Maya, which exact version of Koha are you using? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:53:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:53:16 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:53:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:53:22 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 --- Comment #2 from Jonathan Druart --- Created attachment 88974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88974&action=edit Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration Silly bug caused by: commit ef410fd62f279a10687636a4f26babb2c91ecadc Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber Constructors take a hashref! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:53:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:53:46 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #9 from Jonathan Druart --- Could you test the patch I have added on bug 22717? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:54:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:54:12 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22717 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 [Bug 22717] google oauth auto registration error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:54:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:54:12 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Depends on| |20287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 [Bug 20287] Move AddMember and ModMember to Koha::Patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 02:56:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 00:56:43 +0000 Subject: [Koha-bugs] [Bug 22720] Including branchcode in PatronSelfModificationBorrowerUnwantedField causes internal server error on self registration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Hi Barton, why do you suggest? Which library to you pick if there is more than one? A workaround could be to hide it with JS. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 03:02:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 01:02:17 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #10 from Claudio --- It fails, same error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 03:12:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 01:12:45 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #11 from Claudio --- Plack-error.log in other customer: Use of uninitialized value in string ne at /usr/share/koha/opac/cgi-bin/opac/svc/auth/googleopenidconnect line 102. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 03:31:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 01:31:12 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #12 from Jonathan Druart --- The error you got before was about the EDS plugin, you may have installed it at some point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 03:55:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 01:55:59 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #13 from Claudio --- Created attachment 88975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88975&action=edit EDS Jonathan, look at the file attached. There's an EDS directory in koha/plugins since 2016! But Koha backoffice says that there's no EDS plugin installed. I do not know what to do. How can I uninstall EDS? Simply delete it? Probably it was for a test, but do not need it now... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 03:58:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 01:58:04 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #14 from Claudio --- In the second customer plugin directoy is empty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 10:43:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 08:43:06 +0000 Subject: [Koha-bugs] [Bug 22792] New: Baishs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22792 Bug ID: 22792 Summary: Baishs Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.druart at bugs.koha-community.org Reporter: jimmi.baee at yahoo.com Target Milestone: --- Created attachment 88976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88976&action=edit Kahahs Bzhzhs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 14:43:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 12:43:51 +0000 Subject: [Koha-bugs] [Bug 22792] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Baishs |SPAM CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 14:44:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 12:44:02 +0000 Subject: [Koha-bugs] [Bug 22792] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:17:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:17:05 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 --- Comment #15 from Claudio --- Jonathan, please discard comments 6, 11 and 13. From my point of view the problem is not linked to plugin system. I have two istallation of Koha in two differents servers. One has plugin system enabled (which echoes EDS issue) and one has plugin system disabled. So I disabled the plugin system in the first and could reproduce the same error in both installations: PLACK-ERROR.LOG Can't use string ("firstname") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/Koha/Object.pm line 69. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:25:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:25:14 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:25:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:25:20 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88274|0 |1 is obsolete| | --- Comment #39 from Katrin Fischer --- Created attachment 88977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88977&action=edit Bug 15400: Display date of birth and age more consistantly Test plan: 0) Apply the patch 1) Go to all of these pages Patron detail Other patron pages - look on the left side (circ-menu) Patron search Guarantor search ( go to child patron -> edit -> in guarantor section click "Set to patron" Search through "Check out" (in the header) 2) Confirm that does show date of birth and date consistantly, try it on patrons with and without date of birth set to find possible reggressions Signed-off-by: Aleisha Amohia Signed-off-by: Kyle M Hall Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:25:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:25:25 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88275|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer --- Created attachment 88978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88978&action=edit Bug 15400: (follow-up) Updating text display Now shows as 'Born: [date of birth] (age)' in circ sidebar menu and search results Sponsored-by: Catalyst IT Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:25:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:25:31 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88276|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer --- Created attachment 88979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88979&action=edit Bug 15400: (follow-up) Adding age to check out search dropdown Confirm age shows in the suggestions dropdown when using the checkout search in header (if user set DOB). Confirm 'Age unknown' shows if no DOB set. Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:25:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:25:36 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88277|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer --- Created attachment 88980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88980&action=edit Bug 15400: (follow-up) Restore 'years' string, remove untranslatable string Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:25:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:25:41 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88846|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer --- Created attachment 88981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88981&action=edit Bug 15400: (follow-up) Add class to years span Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:34:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:34:39 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- If the lost value is not set, the search results will display 0, same for the CSV export. The entry 'Lost' is repeated in the datatables filter on top of the list. Maybe this needs to be renamed "Status" to be less confusing. Or "Not lost"? Actually, in that context: I also think the "Status" column should be "not for loan" - but that belongs on a different bug maybe. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:34:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:34:57 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:45:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:45:19 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #24 from Katrin Fischer --- FAIL C4/Acquisition.pm OK critic FAIL forbidden patterns forbidden pattern: tab char (line 688) OK git manipulation OK pod OK pod coverage OK spelling OK valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt FAIL filters wrong_html_filter at line 105 ( [% basket.basketname | html %]) wrong_html_filter at line 154 (
  • Uncertain prices
    • ) wrong_html_filter at line 156 (
  • Close this basket
    • ) wrong_html_filter at line 156 (
  • Close this basket
    • ) Trying to fix in a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:57:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:57:54 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #25 from Katrin Fischer --- I am not super happy about the 'add to basket' option being hidden now in a menu in all cases. I would have preferred to keep it visible and easy to access. It kind of contradicts the original purpose of being a fast action now. No longer saving any clicks compared to viewing and adding. I do like the 'uncertain prices' and 'close basket' actions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:58:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:58:35 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:58:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:58:39 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #26 from Katrin Fischer --- Created attachment 88982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88982&action=edit Bug 21364: (follow-up) Check for standing status and uncertain prices Fetch 'uncertainprices' when getting basket info. A side effect is that styling on baskets with uncertain prices is restored by this bug. They will appear in red To test: 1 - Add an order with an uncertainprice to the basket 2 - Return to vendor baskets view 3 - Note the actions now include "Uncertain prices" 4 - Click that, resolve the uncertain prcie 5 - Return to vendor basket view 6 - Note you can now close the basket, but don't 7 - Edit the basket, mark it as standing 8 - Return to vendor basket view 9 - Note you cannot close the basket Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 15:58:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 13:58:44 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 --- Comment #27 from Katrin Fischer --- Created attachment 88983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88983&action=edit Bug 21364: (QA follow-up) Fix QA script complaints (tabs and filters) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 16:08:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 14:08:35 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #52 from Katrin Fischer --- I am very very sorry :( The checkbox behaviour looks better now, but the 'hold date' input is now always visible and not just appearing when needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 16:21:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 14:21:51 +0000 Subject: [Koha-bugs] [Bug 22408] Subscription entry form cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 16:21:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 14:21:56 +0000 Subject: [Koha-bugs] [Bug 22408] Subscription entry form cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88953|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 88984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88984&action=edit Bug 22408: Subscription entry form cleanup This patch makes a number of changes to the subscription entry form: - Make the default layout single-column. - Switch the layout to two-column only when testing prediction pattern. - Add a button to hide the prediction pattern test pane. - Change the style of some buttons and links. Add Font Awesome icons to some. - Clean up some issues with capitalization and spacing. - Make it clearer when form fields are read-only: Move "locked" form field style from addbiblio.css to staff-global.css and improve it with regard to mouse interactions To test, apply the patch and regenerate the staff client CSS. Clear your browser cache if necessary. - Go to Serials -> New subscription. - Readonly fields under "Vendor" and "Record" should show a small padlock icon. - Test the process of adding a subscription, paying special attention to the advanced pattern controls: Showing, hiding, modifying, canceling. - Test the process of editing a subscription in the same way. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 16:34:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 14:34:14 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 --- Comment #6 from Katrin Fischer --- Hi Owen, this works great. Can we have a similar fix for the staff side? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 16:35:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 14:35:38 +0000 Subject: [Koha-bugs] [Bug 22793] New: Suspend all hold button appears even if the hold can no longer be suspended in staff Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22793 Bug ID: 22793 Summary: Suspend all hold button appears even if the hold can no longer be suspended in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- If all holds are waiting or in transit, don't show the suspend options in the patron account (details and checkouts tabs) in the staff client. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 16:36:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 14:36:02 +0000 Subject: [Koha-bugs] [Bug 22793] Suspend all hold button appears even if the hold can no longer be suspended in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22537 --- Comment #1 from Katrin Fischer --- Fix for the OPAC is on bug 22537 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 16:36:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 14:36:02 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22793 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 16:36:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 14:36:56 +0000 Subject: [Koha-bugs] [Bug 22537] Don't show Suspend all holds button when holds can no longer be susppended in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suspend all hold button |Don't show Suspend all |appears even if the hold |holds button when holds can |can no longer be suspended |no longer be susppended in | |OPAC --- Comment #7 from Katrin Fischer --- I've filed bug 22793 for staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 16:37:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 14:37:58 +0000 Subject: [Koha-bugs] [Bug 22537] Don't show Suspend all holds button when holds can no longer be susppended in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 16:38:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 14:38:03 +0000 Subject: [Koha-bugs] [Bug 22537] Don't show Suspend all holds button when holds can no longer be susppended in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88924|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 88985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88985&action=edit Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. This patch adds to the user summary page in the OPAC a check for waiting or in-transit holds. If all holds are waiting or in transit the "Suspend all" controls will be hidden. This patch also adds a missing $KohaDates filter to the "suspended until" date. To test, apply the patch and log in to the OPAC as a patron with holds. Test these conditions: - All holds are waiting and/or in transit - The "Suspend holds" controls at the bottom of the page should not appear. - Some holds are waiting and/or in transit - The "Suspend holds" controls should appear. Signed-off-by: Marjorie Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 16:40:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 14:40:55 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #50 from Katrin Fischer --- The QA script has some complaints: FAIL docs/contributors.yaml OK git manipulation FAIL yaml_valid YAML Error: Invalid element in map FAIL koha-tmpl/intranet-tmpl/prog/en/modules/about.tt FAIL filters missing_filter at line 828 ( [% FOREACH r IN p.roles %]
  • [% INCLUDE role role=r %] ([% r.value.join(', ') %])
    • [% END %]) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 17:00:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 15:00:07 +0000 Subject: [Koha-bugs] [Bug 21662] Missing developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #51 from Katrin Fischer --- Looks good in the GUI! Looking at the YAML file I notice a big discrepancy in numbers to what we have on our git repository: http://git.koha-community.org/stats/koha-master/authors.html I think we don't use the numbers yet, so no blocker. But can you tell why? Some entries don't have a commits counter, like Marco Gaiarin: {} I believe the double names don't have the right capitalization in some cases: Pierre-marc => Pierre-Marc Jose-mario => Jose-Mario Pierre-luc => Pierre-Luc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 17:07:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 15:07:58 +0000 Subject: [Koha-bugs] [Bug 22772] Menu link hover color incorrect in OPAC language choosers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 17:08:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 15:08:01 +0000 Subject: [Koha-bugs] [Bug 22772] Menu link hover color incorrect in OPAC language choosers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88842|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 88986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88986&action=edit Bug 22772: Menu link hover color incorrect in OPAC language choosers This patch makes a few corrections to OPAC CSS to fix colors in the language menus. To test, apply the patch and rebuild the OPAC CSS. - Enable multiple languages in the OPAC, including more than one language "variation" (fr-FR, fr-CA). - Set the OpacLangSelectorMode preference to "both." - In the OPAC, test the language menu in both the header and footer. When you hover over the sub-menu items the background should be green and the text color white. - Perform the same test in the self checkout and self checkin interfaces. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 17:12:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 15:12:52 +0000 Subject: [Koha-bugs] [Bug 22772] Menu link hover color incorrect in OPAC language choosers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 17:29:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 15:29:55 +0000 Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer --- Something is odd here :( kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove -v t/db_dependent/Koha/KeyboardShortcuts.t t/db_dependent/Koha/KeyboardShortcuts.t .. 1..4 ok 1 - use Koha::KeyboardShortcuts; DBIx::Class::Row::store_column(): No such column 'shortcut_desc' on Koha::Schema::Result::KeyboardShortcut at /home/vagrant/kohaclone/Koha/Object.pm line 75 # Looks like your test exited with 255 just after 1. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/4 subtests Test Summary Report ------------------- t/db_dependent/Koha/KeyboardShortcuts.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 4 tests but ran 1. Files=1, Tests=1, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.50 cusr 0.37 csys = 1.91 CPU) Result: FAIL I've run updatedatabase, dbic, restart_all etc. :( Functionality wise this seems ok so far, can you please have a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 20:29:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 18:29:31 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com --- Comment #3 from Jonathan Druart --- *** Bug 22777 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 20:29:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 18:29:31 +0000 Subject: [Koha-bugs] [Bug 22777] Google OpenId Connect Internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #16 from Jonathan Druart --- So it's a duplicate of bug 22717. *** This bug has been marked as a duplicate of bug 22717 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 20:29:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 18:29:48 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 20:45:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 18:45:08 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 --- Comment #4 from Claudio --- Hi Jonathan, I have just test this patch but still fails (same error, internal server error) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:03:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:03:43 +0000 Subject: [Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88660|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 88987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88987&action=edit Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest Almost everywhere we call IsAvailableForItemLevelRequest we already have a Koha::Patron and Koha::Item object. It makes sense to use them to avoid a refetch Test plan: It would be good to test this patch on top of 19300 and 19301 and make sure everything works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:03:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:03:39 +0000 Subject: [Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:04:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:04:30 +0000 Subject: [Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 --- Comment #11 from Jonathan Druart --- Conflict with bug 20837 fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:07:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:07:19 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 --- Comment #5 from Jonathan Druart --- (In reply to Claudio from comment #4) > Hi Jonathan, I have just test this patch but still fails (same error, > internal server error) Are you sure you restarted plack? Still getting the "Can't use string" error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:14:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:14:43 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 --- Comment #6 from Claudio --- I'm soooooooo sorry Jonathan, you're right. I restarted plack and all work fine again. Thank you sooooo much for you patience.. If you agree I can sign this bug off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:18:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:18:28 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #10 from Jonathan Druart --- Still ok for me on 18.11.x following comments 1 and 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:19:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:19:33 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #11 from Jonathan Druart --- % marcdump ~/Downloads/cart.iso2709|grep 245 /home/jonathan/Downloads/cart.iso2709 245 10 _a??? ? ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:23:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:23:45 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #12 from Katrin Fischer --- I have no idea what's going on there... but it doesn't work for me. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:25:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:25:00 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 --- Comment #7 from Jonathan Druart --- No worries Claudio, thank you for testing! If it works, you can sign it off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:26:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:26:21 +0000 Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on test BorrowerLogs and TrackLastPatronActivity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #4 from Jonathan Druart --- But then you wrote on bug 22453 comment 11 that it is still failing? :) Looks ok for me, I ran it several times and still passing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:27:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:27:06 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Claudio --- Tested! This patch solves the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:31:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:31:17 +0000 Subject: [Koha-bugs] [Bug 22766] Tags cloud link in OPAC does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766 --- Comment #5 from Claudio --- Jonathan, bug 22420 solves the problem. I have just tested and all work fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:38:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:38:03 +0000 Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Michal Denar --- Can yopu rebase this on the master? Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:46:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:46:03 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #21 from Jonathan Druart --- (In reply to Julian Maurice from comment #20) > I'm a little concerned about the potential loss of jobs with the RabbitMQ > option. Is there any way to avoid this problem ? Using Monit to make sure the service is always up? :) But indeed we should return an error if the server has not been reached, and so the job not enqueued. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:48:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:48:47 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #13 from Jonathan Druart --- Could you attach the record here and tell us the different options you chose on importing it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:49:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:49:10 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #14 from Jonathan Druart --- Also on which screen the display starts to be incorrect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:53:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:53:47 +0000 Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |tomascohen at gmail.com |ommunity.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 21:57:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 19:57:23 +0000 Subject: [Koha-bugs] [Bug 19847] tracklinks.pl accepts any url from a parameter for proxying In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shoriful19 at yahoo.com --- Comment #9 from Jonathan Druart --- *** Bug 22703 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 22:25:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 20:25:56 +0000 Subject: [Koha-bugs] [Bug 22619] Adding a new circ rule with unlimited checkouts is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 --- Comment #10 from Jonathan Druart --- (In reply to Nick Clemens from comment #2) > We don't execute in a transaction, but I didn't know if this is intentional? It will not help, they are simulating hits on the interface, so outside the transaction you would create. So, if the data is created using the interface, you need to delete them in the cleanup sub. And if the data is created from the test file, inside a transaction, the interface will have "see" it. For intance: 1. $itemtype is created using the admin form (click /admin/itemtypes.pl?op=add_form&itemtype=) => Need to be deleted in the cleanup sub 2. $itype is created using TestBuilder, inside a transaction => No need to delete it in the cleanup, but you will not be able to use it. It is useless 3. $itype is created using TestBuilder, without transaction (our case here) => You need to delete it, otherwise it will still exist after the test is ran. *And* you must delete it in the cleanup (called from END), to make sure the data will be deleted even if something goes wrong. A good example how to handle those data to delete is regression.t (push to @cleanup what we want to delete) Hope it makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 22:33:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 20:33:27 +0000 Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #15 from Jonathan Druart --- I'd say we could go without test plan, if the changes make sense and work in that case it must work for the "special" cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:17:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:17:13 +0000 Subject: [Koha-bugs] [Bug 9762] Log circulation overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|way to track overrides |Log circulation overrides CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:20:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:20:40 +0000 Subject: [Koha-bugs] [Bug 22794] New: Omnibus: Improve and extend logging in Koha Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Bug ID: 22794 Summary: Omnibus: Improve and extend logging in Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Target Milestone: --- An omnibus to gather the bug reports asking for extending/improving the logs in some way (action_logs and statistics). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:20:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:20:57 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 [Bug 9762] Log circulation overrides -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:20:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:20:57 +0000 Subject: [Koha-bugs] [Bug 9762] Log circulation overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:23:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:23:09 +0000 Subject: [Koha-bugs] [Bug 9753] Make it possible to customize display of bibliographic information on holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|XSLT on holds queue |Make it possible to | |customize display of | |bibliographic information | |on holds queue CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:24:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:24:43 +0000 Subject: [Koha-bugs] [Bug 9750] Bring routing lists into notices & slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|bring routing lists in to |Bring routing lists into |notices & slips |notices & slips CC| |katrin.fischer at bsz-bw.de Component|Tools |Notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:26:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:26:14 +0000 Subject: [Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #3 from Katrin Fischer --- Would be interesting to test with Elasticsearch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:29:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:29:24 +0000 Subject: [Koha-bugs] [Bug 9721] Umbrella report for hold changes to meet special library needs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9721 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #9 from Katrin Fischer --- All linked bug reports have been closed, closing this one as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:35:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:35:43 +0000 Subject: [Koha-bugs] [Bug 9717] Local use recorded for holds/transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|localuse recorded for |Local use recorded for |holds/transfers |holds/transfers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:37:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:37:19 +0000 Subject: [Koha-bugs] [Bug 9710] Alllow multi-select on search criteria in statistic wizards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|multi-select on stats |Alllow multi-select on |wizards |search criteria in | |statistic wizards CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:43:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:43:22 +0000 Subject: [Koha-bugs] [Bug 9708] Add filter on home library to batch patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|batch patron anonymize |Add filter on home library |based on library |to batch patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:44:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:44:16 +0000 Subject: [Koha-bugs] [Bug 9699] Allow patrons to see notices sent to them in their OPAC account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9699 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |OPAC Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:56:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:56:46 +0000 Subject: [Koha-bugs] [Bug 9687] Subject Searching not working for records with parentheses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9687 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- This appears to be fixed. When looking at the link of a subject with () the parentheses have been removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 27 23:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 21:57:29 +0000 Subject: [Koha-bugs] [Bug 9682] Pull price from 020$c when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9682 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|pull price from 020$c |Pull price from 020$c when | |adding an item CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:01:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:01:54 +0000 Subject: [Koha-bugs] [Bug 9666] Add columns for status to inventory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9666 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Summary|add columns for status to |Add columns for status to |inventory |inventory Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- The inventory tool displays not for loan, lost, damaged, withdrawn now and can be filtered on those. Marking as resolved fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:03:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:03:36 +0000 Subject: [Koha-bugs] [Bug 9664] Additional fees tracking in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9664 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|additional fees tracking in |Additional fees tracking in |acquisitions |acquisitions Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- The description is not very clear and the question was never answered. I assume this is covered by shipping cost and invoice adjustments. Marking resolved fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:06:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:06:26 +0000 Subject: [Koha-bugs] [Bug 9607] Pagination wrong if OPACShowUnusedAuthorities is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9607 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Searching Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Summary|Pagination wrong if |Pagination wrong if |OPACShowUnusedAuthorities |OPACShowUnusedAuthorities |set to "don't show" |is used --- Comment #4 from Katrin Fischer --- Changing module to Searching as I think the fix would be to remove the unused authorities from the search result before paging them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:07:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:07:52 +0000 Subject: [Koha-bugs] [Bug 9606] When exporting to RIS the page information is not included In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|If you export to Ris the |When exporting to RIS the |page information is not |page information is not |included |included -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:08:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:08:48 +0000 Subject: [Koha-bugs] [Bug 9602] Allow/disallow self check out based on item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|new feature |enhancement Summary|allow/disallow self check |Allow/disallow self check |out based on item type |out based on item type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:11:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:11:42 +0000 Subject: [Koha-bugs] [Bug 9600] Create authorities on import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9600 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|create authorities on |Create authorities on |import |import --- Comment #1 from Katrin Fischer --- I thought that we had another bug that might have added the feature, but couldn't locate it yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:17:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:17:31 +0000 Subject: [Koha-bugs] [Bug 9599] Printable work slip on receive in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9599 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|printable work slip on |Printable work slip on |receive in acquisitions |receive in acquisitions --- Comment #7 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:19:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:19:42 +0000 Subject: [Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|longoverdue by library |Allow longoverdue.pl to be | |configured by library CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:19:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:19:54 +0000 Subject: [Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz Component|Circulation |Command-line Utilities -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:22:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:22:18 +0000 Subject: [Koha-bugs] [Bug 9589] Authorities to authorities linker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org Summary|authorities to authorities |Authorities to authorities |linker |linker CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Still valid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:23:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:23:17 +0000 Subject: [Koha-bugs] [Bug 9577] Prevent library staff from checking out/checking in to their own account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9577 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Prevent self issue by |Prevent library staff from |library staff |checking out/checking in to | |their own account CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:52:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:52:28 +0000 Subject: [Koha-bugs] [Bug 9567] Favorite reports per user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|favorite reports per user |Favorite reports per user --- Comment #4 from Katrin Fischer --- Still a nice idea :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 00:54:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Apr 2019 22:54:21 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |m.de.rooy at rijksmuseum.nl Component|Staff Client |Cataloging --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 02:35:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 00:35:55 +0000 Subject: [Koha-bugs] [Bug 22795] New: output of debian upgrade referecnes incorrect script Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22795 Bug ID: 22795 Summary: output of debian upgrade referecnes incorrect script Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: shifting-koha at shifting.ca QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net Target Milestone: --- When upgrading from debian koha-common 18.11.03 to 18.11.04, I received the message WARNING: (Bug 21846) You need to manually run /usr/share/koha/intranet/cgi-bin/misc/maintenance/fix_tags_weight.pl to fix possible issues with tags. It seems to me, this should refer to the debian path for that script, which is /usr/share/koha/bin/maintenance/fix_tags_weight.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 02:39:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 00:39:50 +0000 Subject: [Koha-bugs] [Bug 22796] New: koha-common and mariadb start in the wrong order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22796 Bug ID: 22796 Summary: koha-common and mariadb start in the wrong order Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: shifting-koha at shifting.ca QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net Target Milestone: --- when running my last apt-upgrade, koha-common and mariadb both updated. Unfortunately, koha tried to configure before mariadb did, meaning that the database server was still stopped when koha tried to run it's configuration: Setting up linux-image-amd64 (4.9+80+deb9u7) ... Setting up koha-common (18.11.04-1) ... Upgrading database schema for library DBI connect('database=koha_theatrealberta;host=localhost;port=3306','koha_theatrealberta',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2 "No such file or directory") at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1517. DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2 "No such file or directory") at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1520. at /usr/share/koha/lib/Koha/Database.pm line 107 dpkg: error processing package koha-common (--configure): subprocess installed post-installation script returned error exit status 255 Setting up mariadb-server-10.1 (10.1.38-0+deb9u1) ... of course, this was easy to fix by running "dpkg-configure -a" again. But it would be nice if these packages configured themselves in the right order. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 09:51:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 07:51:16 +0000 Subject: [Koha-bugs] [Bug 8619] Remove hidelostitems syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I am not sure how hidelostitems is realized, but there are several disadvantages to using OpacHiddenItems that keep some libraries from using it (we also have a lot that do): 1) It works outside of Zebra, so there are holes in the search results and you can end up with almost empty pages if you hide a lot of things 2) Because of the holes, we have removed the numbering from the search results when OpacHiddenItems is used, to make it less obvious 3) It will need updating, as Owen points out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 09:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 07:55:36 +0000 Subject: [Koha-bugs] [Bug 9557] Syndetics: Include EANs from MARC records in links on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9557 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha does not include EANs |Syndetics: Include EANs |from MARC records in |from MARC records in links |Syndetics links on OPAC |on OPAC pages |pages | Version|unspecified |master CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- (In reply to rkuiper from comment #1) > We are also experiencing this problem. The cover images are showing up on > the details page but not the search results page. Hi Rhonda, this could be a separate issue. Are you still experiencing this problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 09:56:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 07:56:35 +0000 Subject: [Koha-bugs] [Bug 9553] Link authorities to bibs when imported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9553 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|link authorities to bibs |Link authorities to bibs |when imported |when imported CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:02:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:02:30 +0000 Subject: [Koha-bugs] [Bug 9548] Log changes to baskets/basket groups so you can print/download the same data as at time of creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a way to 'freeze' the |Log changes to |content of a basket group |baskets/basket groups so | |you can print/download the | |same data as at time of | |creation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:03:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:03:50 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #52 from Katrin Fischer --- *** Bug 9538 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:03:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:03:50 +0000 Subject: [Koha-bugs] [Bug 9538] After moving an item, add ability to suppress record if there are no item left In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9538 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15496 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:07:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:07:44 +0000 Subject: [Koha-bugs] [Bug 9536] Simplify adding to the the list of possible encodings for Z39.50 servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |katrin.fischer at bsz-bw.de Summary|Make it still easier to add |Simplify adding to the the |to the the list of possible |list of possible encodings |encodings for Z39.50 |for Z39.50 servers |servers. | --- Comment #1 from Katrin Fischer --- If the code already supports those, maybe we could move the encoding list to an authorized value category to give more flexibility. I think adding all of those would probably make the list hard to use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:11:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:11:51 +0000 Subject: [Koha-bugs] [Bug 9514] 'and' in subject searches causes a problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #5 from Katrin Fischer --- (In reply to Jon Knight from comment #4) > (In reply to Owen Leonard from comment #3) > > Jon, the "importance" setting has no effect on how bug fixes are > > prioritized. If a bug isn't moving there are a few things you can do: > > It might be a good idea to hide it from the Bugzilla UI in that case. I think that is not possible by configuration and while bugzilla is open source, we don't want to make too many changes as they would give us trouble at the time of updating. As of the previous discussion I close this WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:19:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:19:21 +0000 Subject: [Koha-bugs] [Bug 9474] Merge "Overdues" and "Overdues with fines" reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|filter overdues with fines |Merge "Overdues" and | |"Overdues with fines" | |reports CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I really like the idea of merging the the "Overdues" and "Overdues with fines" reports. We'd have to take a closer look to work out the similarities and differences, but I see no real merit in having both right now apart from the first missing the 'has fines' search flag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:22:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:22:55 +0000 Subject: [Koha-bugs] [Bug 9472] Improve sequence of subfields used and unused while cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|subfields in order when |Improve sequence of |cataloging |subfields used and unused | |while cataloguing Patch complexity|Small patch |--- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:24:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:24:42 +0000 Subject: [Koha-bugs] [Bug 9447] Auto approve/block tags/comments from specified users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|auto approve/block users |Auto approve/block |for tags/comments |tags/comments from | |specified users -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:28:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:28:45 +0000 Subject: [Koha-bugs] [Bug 9442] Copy serial holding information to MARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20447 CC| |katrin.fischer at bsz-bw.de Summary|Why not copying serial |Copy serial holding |holdings in Marc records |information to MARC --- Comment #1 from Katrin Fischer --- I wonder if the work on holdings records could be helpful in this context. Adding a see also on bug 20447. As we work in a union catalog setting where local information in Koha would be overwritten by incoming new versions of the record, the holding records seem like a good solution. Another might be to handle this like items, where the information is only inserted at the time of indexing or exporting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:28:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:28:45 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9442 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:32:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:32:08 +0000 Subject: [Koha-bugs] [Bug 9400] On a multi-arch debian system, parts of the INSTALL.debian fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Installation and upgrade |Packaging |(command-line installer) | CC| |katrin.fischer at bsz-bw.de, | |mirko at abunchofthings.net --- Comment #3 from Katrin Fischer --- Adding Mirko, wondering if this can be closed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:38:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:38:25 +0000 Subject: [Koha-bugs] [Bug 9285] ban user from tagging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9285 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 9447 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:38:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:38:25 +0000 Subject: [Koha-bugs] [Bug 9447] Auto approve/block tags/comments from specified users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9447 --- Comment #2 from Katrin Fischer --- *** Bug 9285 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:46:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:46:14 +0000 Subject: [Koha-bugs] [Bug 9365] MARCXML ILS-DI GetRecords response incorrectly encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9365 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org CC| |alex.arnaud at biblibre.com, | |julian.maurice at biblibre.com Component|OPAC |Web services --- Comment #2 from Katrin Fischer --- I am not sure if this is a bug. We include a possibly 'bad' MARCXML in an XML answer, so the use of entities seem like a necessary safeguard to me? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:46:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:46:53 +0000 Subject: [Koha-bugs] [Bug 22797] New: ILS-DI: GetRecords doesn't work with documented parameter id_type Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22797 Bug ID: 22797 Summary: ILS-DI: GetRecords doesn't work with documented parameter id_type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: alex.arnaud at biblibre.com, julian.maurice at biblibre.com Target Milestone: --- I've tried GetRecords from ILS-DI and noticed that the id_type parameter listed doesn't work, although it's listed in documentation. IllegalParameterThe parameter id_type is illegal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:54:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:54:51 +0000 Subject: [Koha-bugs] [Bug 9355] Display of possible book title and author list in search box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9355 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 569 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:54:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:54:51 +0000 Subject: [Koha-bugs] [Bug 569] Searches need 'browse' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com --- Comment #2 from Katrin Fischer --- *** Bug 9355 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 10:57:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 08:57:52 +0000 Subject: [Koha-bugs] [Bug 9354] Add ability to validate MARC records before import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9354 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha has insufficient MARC |Add ability to validate |validation checks |MARC records before import CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:03:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:03:05 +0000 Subject: [Koha-bugs] [Bug 9313] Show fine amount on 'Overdues with fines' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Reports Summary|add fine amounts to overdue |Show fine amount on |with fines |'Overdues with fines' | |report CC| |katrin.fischer at bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9474 --- Comment #2 from Katrin Fischer --- I think we should show a total of all F and FU fines on the item. It might be worth adding this to the 'overdues' report instead, moving towards making the 'overdues with fines' report unnecessary (see bug 9474) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:03:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:03:05 +0000 Subject: [Koha-bugs] [Bug 9474] Merge "Overdues" and "Overdues with fines" reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9313 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:05:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:05:24 +0000 Subject: [Koha-bugs] [Bug 9273] Add price and replacement price fields to subscriptions for auto-populating items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|price fields for serials |Add price and replacement | |price fields to | |subscriptions for | |auto-populating items CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:07:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:07:39 +0000 Subject: [Koha-bugs] [Bug 9271] MARC21: Repeated 630 $p subfields missing -- separator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9271 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|bible subjects missing -- |MARC21: Repeated 630 $p | |subfields missing -- | |separator --- Comment #3 from Katrin Fischer --- Still valid! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:08:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:08:37 +0000 Subject: [Koha-bugs] [Bug 9271] MARC21: Repeated 630 $p subfields missing -- separator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9271 --- Comment #4 from Katrin Fischer --- But I wonder - should the punctuation not be part of the data entered? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:20:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:20:26 +0000 Subject: [Koha-bugs] [Bug 9244] Authorities sorting should take subdivisions into account thanks to DOM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master --- Comment #2 from Katrin Fischer --- Neither hdl nor Gaetan are around any longer. But maybe someone else could confirm this bug on a UNIMARC setup and add a step by step to reproduce? (not sure how to catalog this in UNIMARC or MARC21) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:21:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:21:40 +0000 Subject: [Koha-bugs] [Bug 9240] Search operators should be user-configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jcamins at cpbibliography.com |koha-bugs at lists.koha-commun | |ity.org CC| |katrin.fischer at bsz-bw.de Status|ASSIGNED |NEW --- Comment #1 from Katrin Fischer --- Resetting to NEW. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:22:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:22:13 +0000 Subject: [Koha-bugs] [Bug 9234] Koha's search code needs to be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9234 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:23:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:23:36 +0000 Subject: [Koha-bugs] [Bug 9232] It should be possible to limit on multiple years or date ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:28:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:28:25 +0000 Subject: [Koha-bugs] [Bug 9230] Selectively delete reading history entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9230 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Circulation |OPAC Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Summary|selectively delete reading |Selectively delete reading |history |history entries --- Comment #2 from Katrin Fischer --- Still valid and I think a nice idea! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:30:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:30:18 +0000 Subject: [Koha-bugs] [Bug 9198] total holds in opac doesn't stand out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- (In reply to Nicole C. Engard from comment #2) > Yes. But I do use CSS on my sites to make it stand out - I guess everyone > can do that too. Marking WONTFIX. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:34:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:34:10 +0000 Subject: [Koha-bugs] [Bug 9178] System error when generating the issue following an issue with no dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9178 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I can't replicate the issue. Removing the dates for an issue with a pattern that is not 'irregular' is not possible, they get reset to today's date. When using irregular, the "Generate next" works well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:35:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:35:20 +0000 Subject: [Koha-bugs] [Bug 9173] Using description for monetary amount with MANUAL_INV is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9173 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Fines and fees Summary|manual_inv description |Using description for |confusing |monetary amount with | |MANUAL_INV is confusing CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:38:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:38:06 +0000 Subject: [Koha-bugs] [Bug 9150] Add id and relevance as sort options for authorities search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9150 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add authorities search |Add id and relevance as |sorts by id and relevance |sort options for | |authorities search CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:39:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:39:06 +0000 Subject: [Koha-bugs] [Bug 9146] Ability to add reports to groups/sub groups in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9146 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|way to add reports to |Ability to add reports to |groups in bulk |groups/sub groups in bulk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:41:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:41:39 +0000 Subject: [Koha-bugs] [Bug 9131] Improve usability when linking to guarantor from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9131 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Guarantor Information |Improve usability when | |linking to guarantor from | |patron record --- Comment #1 from Katrin Fischer --- I agree that having the input field doing nothing is confusing. I think at least it should be greyed out/read only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:42:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:42:57 +0000 Subject: [Koha-bugs] [Bug 9125] Syck parser error caused by uploading Koha Offline Circulation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9125 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Kyle, do you know if this is still valid in current versions? (filed 2012) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:49:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:49:24 +0000 Subject: [Koha-bugs] [Bug 9099] Export today's checked in barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9099 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Circulation Summary|Checked-in barcode export |Export today's checked in |should not send empty file |barcodes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:49:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:49:57 +0000 Subject: [Koha-bugs] [Bug 9099] 'Export today's checked in barcodes' always shows and might export an empty file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9099 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Export today's checked in |'Export today's checked in |barcodes |barcodes' always shows and | |might export an empty file --- Comment #6 from Katrin Fischer --- I still think some additional logic here would be nice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:53:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:53:14 +0000 Subject: [Koha-bugs] [Bug 9082] option to notify librarians that i prefer phone calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9082 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 11879 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 11:53:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 09:53:14 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #154 from Katrin Fischer --- *** Bug 9082 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:01:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:01:04 +0000 Subject: [Koha-bugs] [Bug 9007] "@misses" block in overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9007 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Katrin Fischer --- There was never an answer to the question asked - setting to INVALID. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:09:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:09:27 +0000 Subject: [Koha-bugs] [Bug 9982] Select which collections/locations to show on advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9982 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|select which authorized |Select which |values to show on advanced |collections/locations to |search |show on advanced search --- Comment #1 from Katrin Fischer --- We now have options for grouping and hiding itemtypes from the the OPAC. So that leaves collections and locations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:11:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:11:23 +0000 Subject: [Koha-bugs] [Bug 9975] tracking branches in fines better In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9975 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Component|Patrons |Fines and fees Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I believe this to be resolved with the enhancements made to Accounting in Koha in recent versions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:12:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:12:50 +0000 Subject: [Koha-bugs] [Bug 9969] Sorting budget by labels rather than by codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- I think budgets is funds here (we switched descriptions at one point) which makes this a duplicate of bug 13944. *** This bug has been marked as a duplicate of bug 13944 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:12:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:12:50 +0000 Subject: [Koha-bugs] [Bug 13944] Fund sorting is inconsistent across different parts of Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #5 from Katrin Fischer --- *** Bug 9969 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:15:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:15:15 +0000 Subject: [Koha-bugs] [Bug 9959] Filters for 'Most popular' page in OPAC show wrong behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Katrin Fischer --- I can't reproduce the problems I reported in 2013. Marking WORKSFORME. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:20:05 +0000 Subject: [Koha-bugs] [Bug 9939] Add patron statistics to the OPAC (statistics tab in staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19005 Summary|preference to control |Add patron statistics to |visibility of patron stats |the OPAC (statistics tab in |in the OPAC |staff) Depends on| |19006, 21026, 21027 --- Comment #1 from Katrin Fischer --- A problem I see here is that the statistics display appears to be buggy in some cases. So before exposing this to the end user, we should take a deeper look at the logic there. bug 19005 asks for an option to hide this tab, we might want to add 2 prefs for OPAC and staff separately. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19006 [Bug 19006] Nicer formatting of statistics tab in patron account https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21026 [Bug 21026] Statistics tab in patron account should show descriptions instead of codes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 [Bug 21027] Totals in statistics tab change when StatisticsFields is changed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:20:05 +0000 Subject: [Koha-bugs] [Bug 19006] Nicer formatting of statistics tab in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19006 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9939 [Bug 9939] Add patron statistics to the OPAC (statistics tab in staff) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:20:05 +0000 Subject: [Koha-bugs] [Bug 21026] Statistics tab in patron account should show descriptions instead of codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21026 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9939 [Bug 9939] Add patron statistics to the OPAC (statistics tab in staff) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:20:05 +0000 Subject: [Koha-bugs] [Bug 19005] Option to hide statistics tab from patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19005 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9939 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:20:05 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9939 [Bug 9939] Add patron statistics to the OPAC (statistics tab in staff) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:20:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:20:46 +0000 Subject: [Koha-bugs] [Bug 19006] Nicer formatting of statistics tab in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19006 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 21026 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:20:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:20:46 +0000 Subject: [Koha-bugs] [Bug 9939] Add patron statistics to the OPAC (statistics tab in staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9939 Bug 9939 depends on bug 19006, which changed state. Bug 19006 Summary: Nicer formatting of statistics tab in patron account https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19006 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:20:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:20:46 +0000 Subject: [Koha-bugs] [Bug 21026] Statistics tab in patron account should show descriptions instead of codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21026 --- Comment #2 from Katrin Fischer --- *** Bug 19006 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:23:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:23:15 +0000 Subject: [Koha-bugs] [Bug 9938] Batch patron deletion based on list of cardnumbers or borrowernumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9938 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|batch patron deletion based |Batch patron deletion based |on cardnumber or |on list of cardnumbers or |borrowernumber |borrowernumbers --- Comment #3 from Katrin Fischer --- You can use a cardnumber list with the patron list tool and then use the patron list in the batch patron delete/anonymize. Still, it would be nice to make this an easier process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:24:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:24:42 +0000 Subject: [Koha-bugs] [Bug 9936] SIP2 should work with LDAP and CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP2 should use C4/Auth.pm |SIP2 should work with LDAP |for user authentication |and CAS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:29:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:29:01 +0000 Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for items "Waiting" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Katrin Fischer --- (In reply to HB-NEKLS from comment #10) > In 3.14 this issue is no longer present. Marking FIXED, please file a new bug linked to this, if there is still a problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:31:21 +0000 Subject: [Koha-bugs] [Bug 9778] display and change easily OPAC visibility status in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- We now have a clear indicator when a record is suppressed/hidden in the OPAC. Please open new bug reports, if any issues here were missed. *** This bug has been marked as a duplicate of bug 8536 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:31:21 +0000 Subject: [Koha-bugs] [Bug 8536] indicate in staff client that records are suppressed in the opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #2 from Katrin Fischer --- *** Bug 9778 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:32:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:32:35 +0000 Subject: [Koha-bugs] [Bug 9789] Add option to add Goodreads and Librarything to social networks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9789 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|goodreads and librarything |Add option to add Goodreads |in social share |and Librarything to social | |networks CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:33:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:33:15 +0000 Subject: [Koha-bugs] [Bug 9792] Layout problem with patron entry form when using Internet Explorer 11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Owen, I can't test, but can you tell if this is still an issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:34:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:34:09 +0000 Subject: [Koha-bugs] [Bug 9799] Prompt for due date for specific item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9799 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|prompt for due date for |Prompt for due date for |specific item types |specific item types --- Comment #1 from Katrin Fischer --- Still a nice idea to handle materials that you want to checkout with a flexible due date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:35:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:35:21 +0000 Subject: [Koha-bugs] [Bug 9800] Ability to suppress fines and holds alerts in dropbox mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9800 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|way to suppress alerts in |Ability to suppress fines |dropbox mode |and holds alerts in dropbox | |mode CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:37:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:37:04 +0000 Subject: [Koha-bugs] [Bug 9825] Fixed fields not limited in length after upgrade from 3.6.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- Maxlength is set correctly for fixed fields in my installation. Marking as WORKSFORME. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:39:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:39:08 +0000 Subject: [Koha-bugs] [Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Should reverting a waiting |Reverting a waiting hold |hold keep the item number? |should lead to the former | |hold type (item or biblio | |level) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:42:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:42:01 +0000 Subject: [Koha-bugs] [Bug 9844] Add a barcode queue to checkout / return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9844 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- This bug was filed 'pre-Plack' for staff interface and before the performance improvements done since (2013). Is it still valid? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:44:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:44:46 +0000 Subject: [Koha-bugs] [Bug 9852] Add interlibrary loan request form to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |ILL Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I think this is resolved with the addition of the ILL module and exsting backends. *** This bug has been marked as a duplicate of bug 7317 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:44:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:44:46 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #217 from Katrin Fischer --- *** Bug 9852 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:51:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:51:00 +0000 Subject: [Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9855 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:51:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:51:00 +0000 Subject: [Koha-bugs] [Bug 9855] Add OpenGraph (Facebook preview) tags to pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9855 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21850 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:52:38 +0000 Subject: [Koha-bugs] [Bug 9233] Use unambiguous boolean operators for searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Katrin Fischer --- *** Bug 8651 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:52:38 +0000 Subject: [Koha-bugs] [Bug 8651] 'or' in keyword searches causing problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8651 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 9233 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 12:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 10:52:38 +0000 Subject: [Koha-bugs] [Bug 9234] Koha's search code needs to be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9234 Bug 9234 depends on bug 8651, which changed state. Bug 8651 Summary: 'or' in keyword searches causing problems https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8651 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:00:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:00:34 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #22 from Julian Maurice --- (In reply to Jonathan Druart from comment #21) > (In reply to Julian Maurice from comment #20) > > I'm a little concerned about the potential loss of jobs with the RabbitMQ > > option. Is there any way to avoid this problem ? > > Using Monit to make sure the service is always up? :) > > But indeed we should return an error if the server has not been reached, and > so the job not enqueued. That solves one problem, but not the other: when RabbitMQ already has enqueued jobs but stops before koha_worker.pl had the chance to process them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:17:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:17:51 +0000 Subject: [Koha-bugs] [Bug 8957] Show information about existing items when ordering from an existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In neworderbiblio.pl the |Show information about |showmarc.pl doesn't show |existing items when |the $995 |ordering from an existing | |record --- Comment #8 from Katrin Fischer --- There is a link on the title now, but it might be nice to show the number of existing items? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:20:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:20:59 +0000 Subject: [Koha-bugs] [Bug 8950] Patron card creator: Barcode should not be covered by background image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron Card |Patron card creator: |Creator_Background Image |Barcode should not be |and barcode |covered by background image --- Comment #3 from Katrin Fischer --- Using an image with a transparent area might help the issue. Not all graphic formats support transparency, so this might be something to check. Otherwise I am not sure if this is still valid. Barcode size should be on a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:22:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:22:09 +0000 Subject: [Koha-bugs] [Bug 8937] Translation process removes CDATA in RSS XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #3) > Should be fixed by bug 15395 > > So it might be better to put the efforts in treating the cause instead of > yet another symptom. Bug 15395 is pushed now. Would you be able to provide a fix here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:27:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:27:55 +0000 Subject: [Koha-bugs] [Bug 8920] opac-showmarc does not use C4::XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- I don't understand the issue from the description. Multiple changes on the file since 2012, including use of C4:XSLT and something template related: http://git.koha-community.org/gitweb/?p=koha.git;a=history;f=opac/opac-showmarc.pl;h=232eac50a8578434fe76c2c77a82a34d6d2f66ed;hb=5a63c5baa23c5f8b1fdd343995f360147f519d4b I assume fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:29:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:29:27 +0000 Subject: [Koha-bugs] [Bug 8908] Starman/Plack hangs when faced with zombie Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8908 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Katrin Fischer --- I am not sure if this is still valid. There has been no new information provided since 2012. It's unclear how to turn Zebra into a zombie. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:34:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:34:49 +0000 Subject: [Koha-bugs] [Bug 8881] Tool to purge action logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|tool to purge action logs |Tool to purge action logs Depends on| |22794 CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:34:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:34:49 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8881 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8881 [Bug 8881] Tool to purge action logs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:36:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:36:58 +0000 Subject: [Koha-bugs] [Bug 8871] many warnings for 'perl -w ./C4/Reserves' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8871 --- Comment #3 from Katrin Fischer --- 36 now.(In reply to Katrin Fischer from comment #2) > The list grew longer since this was posted (35 -> 46). 36 now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:39:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:39:34 +0000 Subject: [Koha-bugs] [Bug 8858] C4::Circulation::GetBranchItemRule is poorly written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8858 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |18936 --- Comment #1 from Katrin Fischer --- Should we still keep this open in light of the work on issuing rules? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:39:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:39:34 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8858 [Bug 8858] C4::Circulation::GetBranchItemRule is poorly written -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:41:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:41:59 +0000 Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Digest option for HOLD |Digest option for HOLD |FILLED notice? |notice -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:44:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:44:48 +0000 Subject: [Koha-bugs] [Bug 8819] Enter claim data manually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8819 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|enter claim date manually |Enter claim data manually CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:46:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:46:07 +0000 Subject: [Koha-bugs] [Bug 8809] Ability to specify sequence of items placed on hold (cascading holds) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8809 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cascading Holds |Ability to specify sequence | |of items placed on hold | |(cascading holds) CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:46:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:46:14 +0000 Subject: [Koha-bugs] [Bug 8809] Ability to specify sequence of items placed on hold (cascading holds) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8809 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:47:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:47:52 +0000 Subject: [Koha-bugs] [Bug 8807] Add Carton support to Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|add Carton support to Koha |Add Carton support to Koha CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com --- Comment #5 from Katrin Fischer --- Can someone weigh in if this can be closed? No activity since 2012 (no answer to Owens question 2014). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:51:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:51:02 +0000 Subject: [Koha-bugs] [Bug 8785] Basic authentication troubleshootings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8785 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- (In reply to Martin Renvoize from comment #1) > Is anyone using http basic auth with koha in the wild I wonder? > > I'm trying to go through old auth bugs and work out if they're still > relevant... Matthias, any comments regarding the current state of this? I remember someone asking about it a while back on IRC, but it certainly lacks documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:51:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:51:44 +0000 Subject: [Koha-bugs] [Bug 8779] .deb upgrade fails on incomplete instance setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #41445|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:54:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:54:29 +0000 Subject: [Koha-bugs] [Bug 8779] .deb upgrade fails on incomplete instance setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Katrin Fischer --- The attachement is not a well formatted patch, so does not apply. Tomas, as you reported the initial bug, could you take a look if the patch could be saved/useful? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:54:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:54:35 +0000 Subject: [Koha-bugs] [Bug 8779] .deb upgrade fails on incomplete instance setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:57:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:57:18 +0000 Subject: [Koha-bugs] [Bug 8776] When using 'write off all' no note can be added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8776 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|note on why a fine was |When using 'write off all' |waived |no note can be added Component|Circulation |Fines and fees --- Comment #2 from Katrin Fischer --- Updating the bug report, it works most of the time, but not when using "Write off all". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 13:57:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 11:57:42 +0000 Subject: [Koha-bugs] [Bug 8776] When using 'write off all' no note can be added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8776 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:01:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:01:23 +0000 Subject: [Koha-bugs] [Bug 8748] Bib # Default Matching Rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8748 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10811 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:01:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:01:23 +0000 Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the MARC21 defaults In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811 --- Comment #21 from Katrin Fischer --- *** Bug 8748 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:02:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:02:16 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8731 [Bug 8731] Holds Log to track the number of times a hold is overriden -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:02:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:02:16 +0000 Subject: [Koha-bugs] [Bug 8731] Holds Log to track the number of times a hold is overriden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8731 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22794 CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:16:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:16:26 +0000 Subject: [Koha-bugs] [Bug 8712] We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|srikanth at catalyst.net.nz |oleonard at myacpl.org --- Comment #38 from Katrin Fischer --- Resetting assignee, no change since 2013. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:18:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:18:41 +0000 Subject: [Koha-bugs] [Bug 8691] Add a new 'hbincr' barcode plugin for cataloging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|add a new 'hbincr' barcode |Add a new 'hbincr' barcode |plugin, for cataloging |plugin for cataloging Status|NEW |Needs Signoff --- Comment #2 from Katrin Fischer --- Provided patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:18:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:18:46 +0000 Subject: [Koha-bugs] [Bug 8691] Add a new 'hbincr' barcode plugin for cataloging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:21:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:21:25 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool times out with large barcode files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inventory tool fails in |Inventory tool times out |timeout with large CB files |with large barcode files Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #24 from Katrin Fischer --- Judging from latest comments this has been resolved. Please reopen with your version and number of barcodes used if necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:24:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:24:25 +0000 Subject: [Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr, | |katrin.fischer at bsz-bw.de Component|Tools |I18N/L10N Status|ASSIGNED |NEW Assignee|pelletiermaxime at gmail.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #10 from Katrin Fischer --- (In reply to Owen Leonard from comment #9) > (In reply to Marc V?ron from comment #8) > > Still valid? > > Yes. There is still one English string in background-job-progressbar.js at > line 72: > > alert('Failed to submit form: ' + textStatus); Still valid. Resetting assignee (last comment was 2016) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:26:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:26:34 +0000 Subject: [Koha-bugs] [Bug 8634] Style should be user-selectable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8634 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Themes should be |Style should be |user-selectable |user-selectable --- Comment #1 from Katrin Fischer --- Maintaining multiple themes has been proven nearly impossible. You can still add your own, but not sure if you'd want patrons to use more than yours in that case. Maybe another approach: instead of a theme have multiple CSS files to choose from? Normal, high contrast, simplified... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:28:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:28:25 +0000 Subject: [Koha-bugs] [Bug 8618] Don't copy CQL queries into Z39.50 search form when using button from search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Z3950 is not processing CCL |Don't copy CQL queries into |Queries |Z39.50 search form when | |using button from search | |results Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:30:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:30:00 +0000 Subject: [Koha-bugs] [Bug 8615] XSLT on OPAC is broken for incomplete 6xx fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8615 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:33:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:33:53 +0000 Subject: [Koha-bugs] [Bug 8601] Allow more than 2 images on patron cards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8601 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow more pictures on |Allow more than 2 images on |Patron Cards |patron cards --- Comment #2 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:39:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:39:15 +0000 Subject: [Koha-bugs] [Bug 8023] Facebook share link not using current localization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|I18N/L10N |OPAC Summary|Facebook share link not |Facebook share link not |used current localization |using current localization --- Comment #2 from Katrin Fischer --- (In reply to Owen Leonard from comment #1) > I'm not sure there is a good solution for this. Here is what the share link > looks like: > > http://www.facebook.com/sharer.php?u=[ OPAC url ]&t=[ Title ] > > Nothing about the language of the OPAC page is being passed with the > Facebook link, and as far as I can tell there are no options to do so: > > https://developers.facebook.com/x/bugs/357750474364812/ > > The share link seems to work just the same as when you paste a link into a > new post: Facebook parses the page you linked to and tries to build a > preview for it. If the OPAC being linked to has more than one language > available, I assume Facebook can only see the default one. Hi Owen, I think what Serhij meant was the "Details for" part. Maybe we have that in the [Title] somehow? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:40:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:40:19 +0000 Subject: [Koha-bugs] [Bug 8023] Facebook share link not using current localization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Katrin Fischer --- That said.. it doesn't seem to be the case anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:44:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:44:48 +0000 Subject: [Koha-bugs] [Bug 8031] get rid of older notices from the patron notices tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I believe that this is fixed by adding pagination and search options to the table. There is also a cronjob to delete older messages regularly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:47:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:47:18 +0000 Subject: [Koha-bugs] [Bug 8053] Overdue calls list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8053 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX CC| |katrin.fischer at bsz-bw.de Status|ASSIGNED |RESOLVED --- Comment #1 from Katrin Fischer --- It looks like this was easy to implement as a custom report. Being brave closing this as a WONTFIX. Please reopen if you disagree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:48:56 +0000 Subject: [Koha-bugs] [Bug 8067] HTML blocks in sysprefs should be definable for multiple languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8067 --- Comment #5 from Katrin Fischer --- I am inclined to mark this duplicate of bug 2318 now. Or should we recylce for fixing the prefs listed using the new feature? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:50:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:50:51 +0000 Subject: [Koha-bugs] [Bug 8069] Ability to download fund summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8069 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|fund summary downloadable |Ability to download fund | |summary --- Comment #1 from Katrin Fischer --- I think adding the new datatables download and copy features could work well for this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:52:18 +0000 Subject: [Koha-bugs] [Bug 8075] Add XSLT script to remove NSB and NSE characters from Z39.50 downloads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8075 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|NSB and NSE characters |Add XSLT script to remove |proper handling |NSB and NSE characters from | |Z39.50 downloads -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:53:29 +0000 Subject: [Koha-bugs] [Bug 8090] item links should have descriptive text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8090 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 19360 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:53:29 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #26 from Katrin Fischer --- *** Bug 8090 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:56:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:56:23 +0000 Subject: [Koha-bugs] [Bug 8094] Record interface for web based self checkouts in action logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8094 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|stats specific to Self-CKO |Record interface for web |by branch |based self checkouts in | |action logs Depends on| |22794 --- Comment #4 from Katrin Fischer --- You can query self check/SIP checkouts in action_logs using the borrowercode, but I think it would also be nice to use a specific interface value. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:56:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:56:23 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8094 [Bug 8094] Record interface for web based self checkouts in action logs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 14:59:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 12:59:20 +0000 Subject: [Koha-bugs] [Bug 8126] Funkiness with Patrons w/ Most Checkouts Report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8126 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- (In reply to Agnes Rivers-Moore from comment #3) > This report seems to be working correctly now, at least for my single site > library. > Bug fixed somewhere along the way without anyone noticing and updating here? Marking RESOLVED FIXED, please open a new bug report for any remaining issues! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:00:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:00:32 +0000 Subject: [Koha-bugs] [Bug 8123] cronjob to pre-populate/Update patrons from ldap data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|unspecified |master Component|Architecture, internals, |Authentication |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:01:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:01:04 +0000 Subject: [Koha-bugs] [Bug 8123] Cronjob to pre-populate/update patrons using LDAP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply Summary|cronjob to |Cronjob to |pre-populate/Update patrons |pre-populate/update patrons |from ldap data |using LDAP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:02:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:02:40 +0000 Subject: [Koha-bugs] [Bug 8121] Add a workflow for urgent delivery items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8121 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|Need a provision to give |Add a workflow for urgent |timeline when creating a |delivery items |new basket in acquisition | |module | CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think a way to flag urgent items that we can use in different modules would be nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:06:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:06:31 +0000 Subject: [Koha-bugs] [Bug 8120] Add order date and basket information to order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master Summary|Need more details of order |Add order date and basket |when receiving books |information to order | |receive page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:08:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:08:47 +0000 Subject: [Koha-bugs] [Bug 8115] Compute items.totalissues on time of indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8115 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DOM indexing configuration |Compute items.totalissues |should compute totalissues |on time of indexing |from items.issues | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:10:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:10:16 +0000 Subject: [Koha-bugs] [Bug 8499] Add restriction automatically if a certain item type becomes overdue (hourly loans) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|block based on overdue item |Add restriction |type |automatically if a certain | |item type becomes overdue | |(hourly loans) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:11:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:11:21 +0000 Subject: [Koha-bugs] [Bug 8526] Limit commenting in OPAC to specific patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8526 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |OPAC Summary|limit comments to specific |Limit commenting in OPAC to |patron category |specific patron categories CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:14:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:14:19 +0000 Subject: [Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 --- Comment #4 from Katrin Fischer --- The framework is still not visible in the first modal, small change, but could be really helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:15:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:15:44 +0000 Subject: [Koha-bugs] [Bug 8472] Print Checkout Slip with filter criteria date and time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8472 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- There is no description on this bug report apart from the bug title and no action since 2012. Closing INVALID. Please reopen with more information if necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:23:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:23:29 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi Owen, do you want to leave this open? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:24:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:24:26 +0000 Subject: [Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|fines not cleared with |Fines not cleared with |dropbox mode |dropbox mode Status|REOPENED |NEW Component|Circulation |Fines and fees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:28:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:28:38 +0000 Subject: [Koha-bugs] [Bug 8331] Hidden field does not hide from plain MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8331 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|hidden field does not hide |Hidden field does not hide |from plain MARC view |from plain MARC view --- Comment #2 from Katrin Fischer --- Confirmed, testing with 245$c this time. Normal view and labelled MARC view are ok, plain MARC view displays the field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:30:09 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8273 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8273 [Bug 8273] Add biblionumber to deleted item on log -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:30:09 +0000 Subject: [Koha-bugs] [Bug 8273] Add biblionumber to deleted item on log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ADD biblionumber to deleted |Add biblionumber to deleted |item on log |item on log Depends on| |22794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:31:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:31:51 +0000 Subject: [Koha-bugs] [Bug 8285] Show OPAC suppress field (942n) for new basket items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8285 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- You can now fully configure how the form looks like using the ACQ framework. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:33:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:33:18 +0000 Subject: [Koha-bugs] [Bug 8295] patron duplicate message not checking required fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8295 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- (In reply to Jonathan Druart from comment #1) > Looks good to me using master, please confirm. Marking RESOLVED FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:34:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:34:29 +0000 Subject: [Koha-bugs] [Bug 8305] Add an icon for iOS home screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8305 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:35:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:35:11 +0000 Subject: [Koha-bugs] [Bug 8325] Auto-suggest for tags in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8325 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|autofill tags in the opac |Auto-suggest for tags in | |the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:36:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:36:57 +0000 Subject: [Koha-bugs] [Bug 8328] Max checkouts per time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8328 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature CC| |katrin.fischer at bsz-bw.de Summary|max checkouts per time |Max checkouts per time |period |period --- Comment #1 from Katrin Fischer --- We now have a daily limit on the number of holds a patron can place. This goes the same direction but with the added difficulty of having a user defined date range as a base. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:38:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:38:30 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #110 from Katrin Fischer --- Hi Alex, is assigned the correct status here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:39:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:39:21 +0000 Subject: [Koha-bugs] [Bug 8404] Show additional information about borrowers on routing list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8404 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 9750 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:39:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:39:21 +0000 Subject: [Koha-bugs] [Bug 9750] Bring routing lists into notices & slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9750 --- Comment #4 from Katrin Fischer --- *** Bug 8404 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:47:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:47:39 +0000 Subject: [Koha-bugs] [Bug 8400] Placing holds in staff creates lots of warnings in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Katrin Fischer --- INVALID by now, too old. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:49:51 +0000 Subject: [Koha-bugs] [Bug 8371] Add global level issuing rules (number of checkouts over all libraries, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add network level issuing |Add global level issuing |rules |rules (number of checkouts | |over all libraries, etc.) CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:50:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:50:57 +0000 Subject: [Koha-bugs] [Bug 8450] IndependantBranches prevents superlibrarians from checking in transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8450 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10300 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:50:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:50:57 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #19 from Katrin Fischer --- *** Bug 8450 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:54:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:54:10 +0000 Subject: [Koha-bugs] [Bug 8411] merging allows for creation of duplicate fields where not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I believe this is fixed. When checking the checkbox to get the second 001 or 245$a: The field is non-repeatable and already exists in the destination record. Therefore, you cannot add it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:56:55 +0000 Subject: [Koha-bugs] [Bug 8265] Allow a better form of the title to be included in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8265 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11529 CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Bug 11529 will add columns for subtitle, part, number, medium and it should be easily possible to include them in notices then. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 [Bug 11529] Add subtitle, medium and part fields to biblio table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 15:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 13:56:55 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8265 [Bug 8265] Allow a better form of the title to be included in notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 16:00:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 14:00:03 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8219 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8219 [Bug 8219] get_biblio_authorised_values embarrassingly inefficient -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 16:00:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 14:00:03 +0000 Subject: [Koha-bugs] [Bug 8219] get_biblio_authorised_values embarrassingly inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8219 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7923 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Katrin Fischer --- It looks like there is only one occurence of this method in the current codebase, but sadly it's Search.pm: C4/Search.pm: $oldbiblio->{'authorised_value_images'} = ($search_context->{'interface'} eq 'opac' && C4::Context->preference('AuthorisedValueImages')) || ($search_context->{'interface'} eq 'intranet' && C4::Context->preference('StaffAuthorisedValueImages')) ? C4::Items::get_authorised_value_images( C4::Biblio::get_biblio_authorised_values( $oldbiblio->{'biblionumber'}, $marcrecord ) ) : []; Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 16:03:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 14:03:36 +0000 Subject: [Koha-bugs] [Bug 8155] Comply with UK Electronic Commerce (EC Directive) Regulations 2002 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8155 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Katrin Fischer --- I wonder what the current status of this is? Since this has been filed we have added cookie documentation to the wiki and a coding guideline that new ones need to be documented: https://wiki.koha-community.org/wiki/Use_of_Cookies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 17:26:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 15:26:37 +0000 Subject: [Koha-bugs] [Bug 8198] Need to track the call to "C4::Context->userenv->{'xxxx'} without check if it is undefined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8198 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Is this still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 19:48:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 17:48:06 +0000 Subject: [Koha-bugs] [Bug 7999] Send test notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7999 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|send test notice |Send test notice Status|REOPENED |NEW --- Comment #4 from Katrin Fischer --- I think the problem is getting the test data for your test notice. we have a preview now for CHECKOUT/CHECKIN now, but it requires you to enter numbers of existing items and patrons - and it won't send an actual email. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 19:51:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 17:51:06 +0000 Subject: [Koha-bugs] [Bug 8822] Public calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7916 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 19:51:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 17:51:13 +0000 Subject: [Koha-bugs] [Bug 7916] Events module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 19:51:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 17:51:06 +0000 Subject: [Koha-bugs] [Bug 7916] Events module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8822 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 19:53:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 17:53:28 +0000 Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|kohapatch at gmail.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #9 from Katrin Fischer --- Attached patch was reported to have a problem, no action since 2016. Resetting to NEW. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 19:55:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 17:55:12 +0000 Subject: [Koha-bugs] [Bug 7908] Acquisitions: Maintain payment details against vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7908 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kohapatch at gmail.com |koha-bugs at lists.koha-commun | |ity.org Status|ASSIGNED |NEW --- Comment #5 from Katrin Fischer --- Resetting to new, no action since 2013. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 19:55:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 17:55:32 +0000 Subject: [Koha-bugs] [Bug 7908] Record more information about payment on invoice level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7908 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Acquisitions: Maintain |Record more information |payment details against |about payment on invoice |vendors |level -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 19:58:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 17:58:53 +0000 Subject: [Koha-bugs] [Bug 7862] Warns when creating a new notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7862 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Entries in error log when |Warns when creating a new |creating a new notice |notice --- Comment #2 from Katrin Fischer --- These days they look a little different: Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 263. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 263. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 263. CGI::param called in list context from /home/vagrant/kohaclone/svc/letters/get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:02:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:02:50 +0000 Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Illegal dates are used to |Don't use 0000-00-00 to |signal non existing dates. |signal a non-existing date --- Comment #6 from Katrin Fischer --- Actually, I find tons of 0000-00-00 now in the codebase... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:04:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:04:46 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #33 from Katrin Fischer --- Still an issue: C4/Acquisition.pm: DATEDIFF(CURDATE( ),closedate) AS latesince C4/Acquisition.pm: claimed_date = CURDATE() C4/NewsChannels.pm: AND DATE(timestamp) < DATE_ADD(CURDATE(), INTERVAL 1 DAY) circ/overdue.pl: $strsth .= " AND borrowers.debarred >= CURDATE()" ; misc/cronjobs/longoverdue.pl:our $bounds_sth = C4::Context->dbh->prepare("SELECT DATE_SUB(CURDATE(), INTERVAL ? DAY)"); misc/cronjobs/longoverdue.pl: AND DATE_SUB(CURDATE(), INTERVAL ? DAY) > date_due misc/cronjobs/longoverdue.pl: AND DATE_SUB(CURDATE(), INTERVAL ? DAY) <= date_due misc/cronjobs/remove_temporary_edifiles.pl:and datediff( CURDATE(), transfer_date ) > 5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:06:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:06:25 +0000 Subject: [Koha-bugs] [Bug 7750] Release notes for stable releases should be in Master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7750 --- Comment #3 from Katrin Fischer --- I am not sure how this could be solved, but it probably needs to be part of the release workflow, pulling the release notes created until a certain moment in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:08:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:08:20 +0000 Subject: [Koha-bugs] [Bug 7725] Marking a subfield mandatory makes the entire field mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7725 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I don't thinks is true anymore. I have checked the normal and the advanced editor and both test for 245$a nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:10:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:10:41 +0000 Subject: [Koha-bugs] [Bug 7712] a single holds report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7712 --- Comment #1 from Katrin Fischer --- I think the issue here is more the lack of documentation. Currently libraires might use the one or the other depending on their workflows (one is generated by the cronjob, the other is immediate, works better for single brnach) Maybe better labelling and documentation would help? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:17:46 +0000 Subject: [Koha-bugs] [Bug 10260] Enter a note when writing off all or pay selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10260 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Katrin Fischer --- Pay selected appears to have been fixed, only leaving Write off all. This makes it a duplicate of bug 8776. *** This bug has been marked as a duplicate of bug 876 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:17:46 +0000 Subject: [Koha-bugs] [Bug 876] Allow editing of virtual shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=876 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Katrin Fischer --- *** Bug 10260 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:17:53 +0000 Subject: [Koha-bugs] [Bug 10260] Enter a note when writing off all or pay selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10260 --- Comment #5 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 8776 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:17:53 +0000 Subject: [Koha-bugs] [Bug 8776] When using 'write off all' no note can be added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8776 --- Comment #3 from Katrin Fischer --- *** Bug 10260 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:20:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:20:32 +0000 Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|display more in frameworks |Display more when editing | |subfields in frameworks --- Comment #3 from Katrin Fischer --- I think while the accordeon is nice the process might be sped up by showing more information by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:22:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:22:37 +0000 Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com --- Comment #8 from Katrin Fischer --- *** Bug 8120 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:22:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:22:37 +0000 Subject: [Koha-bugs] [Bug 8120] Add order date and basket information to order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10531 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:23:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:23:34 +0000 Subject: [Koha-bugs] [Bug 10531] Add basket name, PO number and order date on receive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC| |katrin.fischer at bsz-bw.de Assignee|amitddng135 at gmail.com |koha-bugs at lists.koha-commun | |ity.org Summary|Basket name and PO number |Add basket name, PO number |on receipt screen |and order date on receive --- Comment #9 from Katrin Fischer --- Merging with the duplicate bug 8120 and resetting to NEW. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:24:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:24:10 +0000 Subject: [Koha-bugs] [Bug 10551] Merging records allows duplicaton of non-repeatable subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10551 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 8411 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:24:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:24:10 +0000 Subject: [Koha-bugs] [Bug 8411] merging allows for creation of duplicate fields where not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8411 --- Comment #3 from Katrin Fischer --- *** Bug 10551 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:25:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:25:07 +0000 Subject: [Koha-bugs] [Bug 10567] Ability to add a hidden/suppressed library branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|suppress a branch |Ability to add a | |hidden/suppressed library | |branch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:28:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:28:23 +0000 Subject: [Koha-bugs] [Bug 10603] Make required fields on course reserves configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|required fields in the |Make required fields on |courses table should be not |course reserves |null |configurable --- Comment #2 from Katrin Fischer --- I agree that we would like department and course number to not be mandatory to give greater flexibility. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:32:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:32:50 +0000 Subject: [Koha-bugs] [Bug 10846] Add preference for naming OverDrive collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10846 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- The problem with a pref would be translatability as you can only have one name for it. I am not sure how to best deal with this. We've had similar bugs reported for renaming course reserves and cart. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:34:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:34:46 +0000 Subject: [Koha-bugs] [Bug 10864] Diacritics in patron categories in advanced patron search broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:50:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:50:04 +0000 Subject: [Koha-bugs] [Bug 10945] Make Z39.50 work for queries that contain "Norwegian vowels" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10945 --- Comment #3 from Katrin Fischer --- I wonder if the problem is the target and not Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:52:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:52:03 +0000 Subject: [Koha-bugs] [Bug 10953] Missing subtitle fieldmapping unless you use ru-RU or uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10953 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11529 CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 [Bug 11529] Add subtitle, medium and part fields to biblio table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:52:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:52:03 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10953 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10953 [Bug 10953] Missing subtitle fieldmapping unless you use ru-RU or uk-UA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:55:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:55:57 +0000 Subject: [Koha-bugs] [Bug 11074] Batch delete fields and subfields from frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11074 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|add checkboxes to |Batch delete fields and |frameworks |subfields from frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:56:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:56:53 +0000 Subject: [Koha-bugs] [Bug 11073] Reorder subfields using drag and drop in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|drag and drop subfields |Reorder subfields using | |drag and drop in | |cataloguing CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:58:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:58:05 +0000 Subject: [Koha-bugs] [Bug 11072] Add pagination to search results in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11072 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- Pagination now shows on top and bottom of the search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:59:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:59:02 +0000 Subject: [Koha-bugs] [Bug 10238] Allow notes on transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10238 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|allow notes on transfer |Allow notes on transfer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:59:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:59:10 +0000 Subject: [Koha-bugs] [Bug 11152] transit notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10238 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 20:59:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 18:59:10 +0000 Subject: [Koha-bugs] [Bug 10238] Allow notes on transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10238 --- Comment #1 from Katrin Fischer --- *** Bug 11152 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 21:00:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 19:00:24 +0000 Subject: [Koha-bugs] [Bug 11073] Reorder subfields using drag and drop in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11073 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 21:01:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 19:01:15 +0000 Subject: [Koha-bugs] [Bug 10339] Link to content in the manual that matches the MARC flavor of the installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10339 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|make the content of some |Link to content in the |help files templates |manual that matches the |marflavor dependent |MARC flavor of the | |installation --- Comment #1 from Katrin Fischer --- There are no longer help files in Koha. I think we would need to have different pages on the manual first and then change the links according to the MARC flavour of the installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 21:03:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 19:03:32 +0000 Subject: [Koha-bugs] [Bug 10680] "Modification log" gives wrong data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 21:03:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 19:03:32 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10680 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680 [Bug 10680] "Modification log" gives wrong data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:01:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:01:30 +0000 Subject: [Koha-bugs] [Bug 9099] 'Export today's checked in barcodes' always shows and might export an empty file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9099 --- Comment #7 from Jonathan Druart --- Created attachment 88988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88988&action=edit Bug 9099: WIP - Hide the export of today's checkins if none FIXME: - Add POD - Add tests This patch is for discussion as I do not think it is ready for inclusion: as the page is not reloaded/updated when a checkin is done, the link will stay hidden. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:06:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:06:06 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #23 from Jonathan Druart --- But then the job will be in the DB table, so we will not lose it, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:09:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:09:54 +0000 Subject: [Koha-bugs] [Bug 8858] C4::Circulation::GetBranchItemRule is poorly written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Depends on|18936 | CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- Indeed, the problem reported by Kyle originally will be fixed by bug 18936. *** This bug has been marked as a duplicate of bug 18936 *** Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:09:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:09:54 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8858 | --- Comment #36 from Jonathan Druart --- *** Bug 8858 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8858 [Bug 8858] C4::Circulation::GetBranchItemRule is poorly written -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:13:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:13:56 +0000 Subject: [Koha-bugs] [Bug 7694] Syndetics Editons not included In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Syndetics_Editons not |Syndetics Editons not |included |included --- Comment #1 from Katrin Fischer --- Can someone using Syndetics content confirm this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:14:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:14:57 +0000 Subject: [Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:15:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:15:52 +0000 Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22279 --- Comment #20 from Katrin Fischer --- Maybe this could be wrapped into unifying the patron name display? (bug 22279) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:15:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:15:52 +0000 Subject: [Koha-bugs] [Bug 22279] Unify patron name display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7680 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:16:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:16:47 +0000 Subject: [Koha-bugs] [Bug 7672] add support of different means of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED Component|Patrons |Fines and fees CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I assume that payment types is meant here, which has been added since. Please reopen with more information if I am mistaken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:16:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:16:47 +0000 Subject: [Koha-bugs] [Bug 5905] Biblibre, Partial fine payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Bug 5905 depends on bug 7672, which changed state. Bug 7672 Summary: add support of different means of payment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7672 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:19:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:19:19 +0000 Subject: [Koha-bugs] [Bug 7664] Library transfer limits check/uncheck all will only work for displayed libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7664 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Summary|Library transfer limits |Library transfer limits |check/uncheck all will only |check/uncheck all will only |works for displayed |work for displayed |branches |libraries --- Comment #3 from Katrin Fischer --- I am not sure if this is still true, but it might require a lot of libraries - 12 don't make it page and changes over multiple tabs safe nicely. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:24:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:24:10 +0000 Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|enhancedmessagingpreference |Enhanced messaging |s are not inherited from |preferences are not set |what is defined for the |when creating a child |category when creating a |patron from the adult |child patron | CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- This is still an issue. I think we could solve this in different ways: - Force to select a patron category before showing the form to add the child patron - Use an Ajax call to reload the messaging preferences when the category is selected. But I have some doubts about this, as we only want to have 'initial' settings and respect if something has been changed manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:25:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:25:45 +0000 Subject: [Koha-bugs] [Bug 7655] Runtime parameters: Allow for an "optional" field tag, versus the need for % In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7655 --- Comment #1 from Katrin Fischer --- Something you can do as a work around: WHERE xxx LIKE CONCAT('%',<>,'%') This way the users don't have to add the %. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:28:49 +0000 Subject: [Koha-bugs] [Bug 7638] Add tool for printing patron notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7638 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|savitra.sirohi at osslabs.biz |koha-bugs at lists.koha-commun | |ity.org CC| |katrin.fischer at bsz-bw.de Summary|one page notice for |Add tool for printing |printing per student? |patron notices Status|ASSIGNED |NEW --- Comment #5 from Katrin Fischer --- I really like the ideas of a tool to print patron notices, but it would need some updates to fit into current practices. No action since 2012, resetting assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:31:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:31:06 +0000 Subject: [Koha-bugs] [Bug 7612] show received and cancelled orders on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7612 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- That works, but you have to change the search filters to include the cancelled orders (from the order advanced search). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:33:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:33:33 +0000 Subject: [Koha-bugs] [Bug 7591] deleting an issue from an expired subscription generates next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7591 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Katrin Fischer --- I believe the current behaviour is correct. Please reopen with more information on the use case if necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:35:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:35:08 +0000 Subject: [Koha-bugs] [Bug 7569] Add Google Transliteration tool to fields during cataloging and in advanced search in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|indradg at l2c2.co.in |koha-bugs at lists.koha-commun | |ity.org Status|ASSIGNED |NEW --- Comment #2 from Katrin Fischer --- No action since 2016, resetting to NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:36:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:36:53 +0000 Subject: [Koha-bugs] [Bug 7568] Allow to change labels on patron entry page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Flexible member entry page |Allow to change labels on |- hide fields, change |patron entry page |labels | Status|ASSIGNED |NEW Assignee|ebin.joseph at osslabs.biz |koha-bugs at lists.koha-commun | |ity.org --- Comment #3 from Katrin Fischer --- No action since 2012, resetting to NEW. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:38:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:38:02 +0000 Subject: [Koha-bugs] [Bug 7536] New permission for deleting items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|savitra.sirohi at osslabs.biz |koha-bugs at lists.koha-commun | |ity.org QA Contact|koha.sekjal at gmail.com |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:40:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:40:35 +0000 Subject: [Koha-bugs] [Bug 7525] Some database fields are displayed 'as is' when they are linked to authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|some database fields are |Some database fields are |displayed 'as is' when they |displayed 'as is' when they |are linked to autorised |are linked to authorised |values |values --- Comment #2 from Katrin Fischer --- The bug description is not clear on which fields should be fixed. I am wondering if this is a WONTFIX as arbitrary reuse of fields probably is causing other issues as well and improving more_subfields_xml instead might be the better idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:46:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:46:15 +0000 Subject: [Koha-bugs] [Bug 7508] Collapsable items on items tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|collapsable items |Collapsable items on items | |tab --- Comment #2 from Katrin Fischer --- Hi Owen, I like the idea :) Wondering about the best identifier too. The only other thing I could think of is using callnumber + copynumber. But that might not differ for all libraries. Could some kind of accordeon view also make sense? The selected or linked to item would be uncollapsed, the others collapsed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:49:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:49:52 +0000 Subject: [Koha-bugs] [Bug 7474] Error handling for 100$a incorrect value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #2) > Adrien doesn't work anymore at BibLibre. > Unassigning this bug to give it more visibility. Victor, would you be able to verify that the bug still exists? It seems related to UNIMARC as 100 has a different meaning in MARC21. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:51:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:51:16 +0000 Subject: [Koha-bugs] [Bug 7464] Add ability to automatically add punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|punctuation button in |Add ability to |cataloging |automatically add | |punctuation --- Comment #1 from Katrin Fischer --- This would be an amazing feature, but is not easy to do. We have written a converter to add punctuation and have found that the LOC documentation often is not clear on what should be used or there appear to be different options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:51:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:51:27 +0000 Subject: [Koha-bugs] [Bug 7464] Add ability to automatically add punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:55:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:55:10 +0000 Subject: [Koha-bugs] [Bug 7456] Itemtype codes with hyphens and spaces can cause unexpected search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7456 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|itypes with similar codes |Itemtype codes with hyphens |throw off search results |and spaces can cause | |unexpected search results --- Comment #5 from Katrin Fischer --- I don't think 'fixing' search would be easy here, I have to admit we also rely on that behaviour in at least one case. What we could do is add a warning when adding authorised values and item type codes that using hyphens and spaces can have unexpected consequences for search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 28 23:57:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 21:57:18 +0000 Subject: [Koha-bugs] [Bug 7423] Export MARC records based on barcode file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7423 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|export marc based on |Export MARC records based |barcode file |on barcode file --- Comment #1 from Katrin Fischer --- I wonder if this should be a WONTFIX. When the use case is creating a list of barocdes using a report, why not create a list if biblionumbers instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:02:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:02:20 +0000 Subject: [Koha-bugs] [Bug 8212] Omnibus bug report for C & P authority developments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8212 Bug 8212 depends on bug 7418, which changed state. Bug 7418 Summary: Add heading flipper script https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7418 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:02:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:02:20 +0000 Subject: [Koha-bugs] [Bug 7418] Add heading flipper script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7418 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #2 from Katrin Fischer --- When changing the main heading of a linked authority record, the records are upadated automagically. See AuthorityMerge* preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:03:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:03:30 +0000 Subject: [Koha-bugs] [Bug 7414] Analytics records need to use indicators to determine display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7414 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|analytics records need to |Analytics records need to |use indicators to determine |use indicators to determine |display |display --- Comment #1 from Katrin Fischer --- Is the note field $i in this case? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:07:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:07:39 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|ASSIGNED |NEW Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org QA Contact|koha.sekjal at gmail.com |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:09:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:09:32 +0000 Subject: [Koha-bugs] [Bug 7384] keyword to marc mapping in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7384 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11529 --- Comment #2 from Katrin Fischer --- Koha to Keyword mappings will be removed by bug 11529. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 [Bug 11529] Add subtitle, medium and part fields to biblio table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:09:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:09:32 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7384 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7384 [Bug 7384] keyword to marc mapping in emails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:12:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:12:53 +0000 Subject: [Koha-bugs] [Bug 7386] Label batches cannot be batch deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:14:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:14:10 +0000 Subject: [Koha-bugs] [Bug 7340] Only send HOLD_PLACED if item is available and hold was patron initiated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7340 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|emailLibrarianWhenHoldIsPla |Only send HOLD_PLACED if |ced enhancement |item is available and hold | |was patron initiated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:27:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:27:10 +0000 Subject: [Koha-bugs] [Bug 7260] User should be able to determine the number of search results per page (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7260 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 14715 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:27:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:27:10 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #90 from Katrin Fischer --- *** Bug 7260 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:30:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:30:59 +0000 Subject: [Koha-bugs] [Bug 7206] Improve usability of cancel order links in basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|delete links in basket |Improve usability of cancel |could use design work |order links in basket --- Comment #1 from Katrin Fischer --- I agree that this could still be improved. Especially if the record can't be deleted with the order, there is way too much information displayed. Might work better as a tooltip or similar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:32:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:32:25 +0000 Subject: [Koha-bugs] [Bug 7195] end date in the future prevents receiving - without error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7195 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I can't reproduce this - the end date should always be in the future? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:38:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:38:14 +0000 Subject: [Koha-bugs] [Bug 7003] Canned report to show patrons and permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7003 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|canned report to show |Canned report to show |patrons and permissions |patrons and permissions --- Comment #4 from Katrin Fischer --- I think this would be really nice, especially if it auto-updated with new permissions being added. If you have a lot of staff fluctuation you might want to check regularly that all old account have been removed or at least the permissions reset. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:39:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:39:23 +0000 Subject: [Koha-bugs] [Bug 7010] Select all records from search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Still much wanted and asked for often. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:40:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:40:05 +0000 Subject: [Koha-bugs] [Bug 7011] Warn the user that they have reached the limit of how many items they can have in their cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC| |katrin.fischer at bsz-bw.de Assignee|jcamins at cpbibliography.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:45:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:45:55 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:45:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:45:55 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7021 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 [Bug 7021] patron category in the statistics table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:47:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:47:50 +0000 Subject: [Koha-bugs] [Bug 7030] Define maximum number of holds on branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- I believe this has been fixed, we have the max number of holds in all 3 tables on circulation conditions now. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:50:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:50:21 +0000 Subject: [Koha-bugs] [Bug 7062] Titles on labels not truncating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:51:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:51:30 +0000 Subject: [Koha-bugs] [Bug 7170] Remove use of XML::Simple In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:52:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:52:05 +0000 Subject: [Koha-bugs] [Bug 7152] Koha should make it easy for librarians to attach covers using Open Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|robin at catalyst.net.nz |koha-bugs at lists.koha-commun | |ity.org CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:54:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:54:37 +0000 Subject: [Koha-bugs] [Bug 7107] 'used in' column on analytics not populating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7107 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- Is this still valid? It's marked major but has seen no action since 2015. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:58:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:58:50 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Hold requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 00:59:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 22:59:39 +0000 Subject: [Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow reply-to on cart |Allow reply-to on cart |emails to go to the sender |emails to go to the sender |of the cart. |of the cart -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:03:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:03:08 +0000 Subject: [Koha-bugs] [Bug 6948] Default hold expiry date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Default Hold Expiry Date |Default hold expiry date Component|Circulation |Hold requests CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:09:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:09:04 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #80 from Katrin Fischer --- *** Bug 6922 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:09:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:09:04 +0000 Subject: [Koha-bugs] [Bug 6922] staff should be able to have children In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6922 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12446 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:12:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:12:52 +0000 Subject: [Koha-bugs] [Bug 6172] Non-French UNIMARC frameworks need to be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #14 from Katrin Fischer --- (In reply to Jon Knight from comment #12) > (In reply to Giuseppe Ciaccio from comment #11) > > It seems that Koha/unimarc/en is working properly, provided the indexer has > > started (which does not happen initially, but this is another story; see > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745). > > As the Koha/unimarc/en is working OK, I assume you're happy for this case to > close? (In reply to Giuseppe Ciaccio from comment #13) > Yes I'm indeed :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:15:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:15:09 +0000 Subject: [Koha-bugs] [Bug 6523] Enhancement: Patron Refund Limits & Expirations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Fines and fees CC| |katrin.fischer at bsz-bw.de Version|rel_3_2 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:15:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:15:59 +0000 Subject: [Koha-bugs] [Bug 6548] Add karma system to encourage patrons to behave commendably In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:21:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:21:06 +0000 Subject: [Koha-bugs] [Bug 6685] circ rules by groups of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 21946 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:21:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:21:06 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #28 from Katrin Fischer --- *** Bug 6685 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:23:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:23:37 +0000 Subject: [Koha-bugs] [Bug 4166] No way to know what keywords to use for Keyword Mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11529 CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 [Bug 11529] Add subtitle, medium and part fields to biblio table -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:23:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:23:37 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4166 [Bug 4166] No way to know what keywords to use for Keyword Mapping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:24:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:24:19 +0000 Subject: [Koha-bugs] [Bug 4164] Way to Clone Keyword Mapping to other Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |11529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 [Bug 11529] Add subtitle, medium and part fields to biblio table -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:24:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:24:19 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4164 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4164 [Bug 4164] Way to Clone Keyword Mapping to other Frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:25:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:25:35 +0000 Subject: [Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cart now requires login |Optionally allow sending |before emailing contents |cart without requiring | |login -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:27:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:27:37 +0000 Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Katrin Fischer --- *** Bug 4467 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:27:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:27:37 +0000 Subject: [Koha-bugs] [Bug 4467] messaging defaults not on add child In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #5 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 7660 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:30:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:30:03 +0000 Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add explicit foreign key |Omnibus: Add explicit |constraints |foreign key constraints -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:32:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:32:30 +0000 Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18050, 22658, 22421, 18441, | |17160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160 [Bug 17160] Foreign key constraint for message_transports is too loose https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 [Bug 18050] Missing constraint foreign key on table aqbudget https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18441 [Bug 18441] add primary, foreign keys to statistics table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 [Bug 22421] accountlines.issue_id is missing a foreign key constraint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658 [Bug 22658] aqbasket.authorisedby is missing a foreign key constraint -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:32:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:32:30 +0000 Subject: [Koha-bugs] [Bug 17160] Foreign key constraint for message_transports is too loose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:32:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:32:30 +0000 Subject: [Koha-bugs] [Bug 18050] Missing constraint foreign key on table aqbudget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:32:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:32:30 +0000 Subject: [Koha-bugs] [Bug 18441] add primary, foreign keys to statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18441 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:32:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:32:30 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:32:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:32:30 +0000 Subject: [Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:32:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:32:59 +0000 Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #21 from Jonathan Druart --- (In reply to Katrin Fischer from comment #20) > Maybe this could be wrapped into unifying the patron name display? (bug > 22279) Agreed, we definitely should fix bug 22279 first, then this feature will be very easy to implement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:34:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:34:52 +0000 Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #7 from Jonathan Druart --- It could be useful to know if production DBs still contain such values (?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:35:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:35:33 +0000 Subject: [Koha-bugs] [Bug 5515] Leading 'and' in search never returns a result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5515 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 9233 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:35:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:35:33 +0000 Subject: [Koha-bugs] [Bug 9233] Use unambiguous boolean operators for searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com --- Comment #2 from Katrin Fischer --- *** Bug 5515 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:35:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:35:34 +0000 Subject: [Koha-bugs] [Bug 9234] Koha's search code needs to be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9234 Bug 9234 depends on bug 5515, which changed state. Bug 5515 Summary: Leading 'and' in search never returns a result https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5515 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:36:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:36:16 +0000 Subject: [Koha-bugs] [Bug 5561] Help on summary field in authority type editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:37:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:37:33 +0000 Subject: [Koha-bugs] [Bug 5666] regexp edits to URL fields in bibliographic edit screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5666 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- We do have a batch record modification tool now that supports changing 856$u using regex. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:44:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:44:43 +0000 Subject: [Koha-bugs] [Bug 22798] New: Double quote included in Publisher search on tag 264 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22798 Bug ID: 22798 Summary: Double quote included in Publisher search on tag 264 Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: cbutosi at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Created attachment 88989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88989&action=edit Field 264 double-quotes On the OPAC, if a user clicks on the hyperlinked Publisher value in the bibliographic record, a double-quote is appended to the search url if the publication value is catalogued in field 264, thus breaking the search. For example: http://library.craigbutosi.ca/cgi-bin/koha/opac-search.pl?q=Provider:Verso%2C%22 instead of http://library.craigbutosi.ca/cgi-bin/koha/opac-search.pl?q=Provider:Verso%2C The double-quote does not appear in records in which publication data is entered in field 260, thus search succeeds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 01:49:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Apr 2019 23:49:11 +0000 Subject: [Koha-bugs] [Bug 8198] Need to track the call to "C4::Context->userenv->{'xxxx'} without check if it is undefined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8198 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor --- Comment #4 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > Is this still valid? Yes, it could be a code cleaning. So far we have to test if userenv is defined before accessing a key, for instance: C4/Accounts.pm: my $branchcode = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; My fix would still be valid, but we still need a test: C4/Accounts.pm: my $branchcode = exist C4::Context->userenv->{branch} ? C4::Context->userenv->{'branch'} : undef; which actually makes less sense. A better approach could be to have a ->logged_in_user method, to retrieve a Koha::Patron object, representing the logged in user. But it is a quite huge work, and nobody will sign it off, and rebases will be tricky ;) Lowering severity for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:00:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:00:39 +0000 Subject: [Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 --- Comment #10 from Jonathan Druart --- (In reply to David Cook from comment #9) > (In reply to Katrin Fischer from comment #8) > > A human being might still misuse the feature - I think it should be a choice > > for the library, so they can turn off 'non logged in cart sending'. > > Agreed. We actually have this implemented locally as an "anonymous cart" > system preference. I think most of our libraries have it turned off (ie > require login), but a few want anyone to be able to use the cart. Still have the code somewhere? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:05:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:05:00 +0000 Subject: [Koha-bugs] [Bug 8219] get_biblio_authorised_values embarrassingly inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16167 --- Comment #2 from Jonathan Druart --- Well, not really, the method has been removed by commit 85e7d186ec2f0a30e479bc924a1023c73eefc28e Bug 16167: Remove Authorised value images prefs But the call has been re-added recently: commit 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7 Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories So, this bug is fixed, but we have another one running. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:05:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:05:00 +0000 Subject: [Koha-bugs] [Bug 16167] Remove prefs to drive authorised value images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8219 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:06:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:06:48 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #189 from Jonathan Druart --- I suspect a wrong resolution conflict here, see commit 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7 Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories The following line has been removed for years, and re-added by this patchset: + $oldbiblio->{'authorised_value_images'} = ($search_context->{'interface'} eq 'opac' && C4::Context->preference('AuthorisedValueImages')) || ($search_context->{'interface'} eq 'intranet' && C4::Context->preference('StaffAuthorisedValueImages')) ? C4::Items::get_authorised_value_images( C4::Biblio::get_biblio_authorised_values( $oldbiblio->{'biblionumber'}, $marcrecord ) ) : []; At first glance I'd say we just need a patch removing the line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:08:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:08:26 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #190 from Jonathan Druart --- Note: The routine C4::Biblio::get_biblio_authorised_values does not longer exist! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:09:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:09:23 +0000 Subject: [Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 --- Comment #11 from David Cook --- (In reply to Jonathan Druart from comment #10) > (In reply to David Cook from comment #9) > > (In reply to Katrin Fischer from comment #8) > > > A human being might still misuse the feature - I think it should be a choice > > > for the library, so they can turn off 'non logged in cart sending'. > > > > Agreed. We actually have this implemented locally as an "anonymous cart" > > system preference. I think most of our libraries have it turned off (ie > > require login), but a few want anyone to be able to use the cart. > > Still have the code somewhere? Yes, although we've customized the cart quite a bit, so it would take time, which I don't have, to unravel it enough to share. Basically, I think you have a system preference, and enable $authnotrequired where necessary and add Koha.Preference( '' ) where necessary in the templates. I could look at this another time, but need to focus on other things atm. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:10:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:10:11 +0000 Subject: [Koha-bugs] [Bug 8618] Don't copy CCL queries into Z39.50 search form when using button from search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8618 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't copy CQL queries into |Don't copy CCL queries into |Z39.50 search form when |Z39.50 search form when |using button from search |using button from search |results |results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:11:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:11:34 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #24 from David Cook --- (In reply to Jonathan Druart from comment #23) > But then the job will be in the DB table, so we will not lose it, right? If we're worried about losing messages, why not look at RabbitMQ persistence? https://www.rabbitmq.com/persistence-conf.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:13:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:13:10 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #191 from Jonathan Druart --- And the 2 prefs (AuthorisedValueImages and StaffAuthorisedValueImages) have been removed by bug 16167, that's why we never call the non-existing routine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:16:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:16:18 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #19 from David Cook --- (In reply to Tom?s Cohen Arazi from comment #18) > As THE native speaker, it is your responsbility to propose another word :-D Hehe fair enough, although I'm not sure of the exact context. Why do you want to rename it from "methods" to something else? Is methods too low-level or overloaded in terms of meaning? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:28:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:28:31 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #52 from David Cook --- (In reply to Katrin Fischer from comment #45) > The plugin idea Alex is working on here is not new - see the discussion in > the first comments. For added security we could discuss different solutions, > like a separate permission for handling authentication plugins maybe? > I see the logic of adding permissions, but I suppose I'm concerned about small libraries where a solo librarian might have all the permissions, but might not make the best choices with those permissions. > I don't agree with people saying it's too hard to get things in. But I > definitely think we should not have this discussion on bugzilla. The dev > meeting today would be a better place. Yes, perhaps Bugzilla is not the best place to have that discussion. I wasn't aware of the dev meeting until after it was finished, and it seems that it was at 5am my time, so I was still (barely) asleep. I think they're usually at 5am or 12am my time, which makes them difficult to attend. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:35:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:35:58 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #53 from David Cook --- (In reply to Chris Cormack from comment #46) > I think what David meant to say was thank you Alex, for testing and > providing your first patch to Koha to fix a broken test. Then gone on with > the discussion of technical merits > > Rest assured we do value your contribution, and we want Koha to be a > welcoming place. (In reply to Chris Cormack from comment #46) > My apologies Axel, my phone autocorrected your name to Alex Chris is absolutely right. I must admit that my eyes actually autocorrected "axel" to "Alex", and I thought the latest patches were follow-up from Alex Arnaud, so I didn't think twice. Looking back, thanks for the contributions, axel! I have no criticism of them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:48:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:48:25 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #54 from David Cook --- (In reply to Alex Arnaud from comment #48) > I do understand this argument. I even agree that plugins (and not only > authentication ones) could contain security issues. > For "our" hosted libraries, we disabled writing permission on plugins > directory. > Looks like a tricky solution and we probably need a better one but it means > that administrators have the final word. > That's really interesting to know. That's probably the most logical way to do it presently, but I agree that it would be nice to have a more elegant solution. I think that's the key thing I'd like to see come out of this discussion really. > IMO plugins are useful (even essential) to satisfy specific libraries > requests and not to avoid community processes. > i wrote this patch in order to create an authentication plugins that can > request many LDAP backends and fallback on an other one. > Seems too specific to be suggested to the community. > To go further, as discussed above, i think we should consider generally > LDAP, CAS etc... as specific feature that would become plugins (may be > another debate). I totally agree in theory. I would love to see all the authentication methods structured as plugins that can be added/removed as necessary, although I think it should be done by administrators rather than librarians. > To return to security topic: > Today, many free plugable systems provide repositories with a large amount > of plugins that have been reviewed, tested and validated by their community > as safe. Users can easily download ones from other sources but they know > it's at their own risk. > Maybe we should be inspired by that. I'd argue that "they know it's at their own risk" isn't necessarily true. It's like how many people sign contracts without reading them, or tick the "Terms and Conditions" box without reading the Terms and Conditions. People seem to just assume that nothing bad will ever happen to them. However, I like the sound of the plugins being reviewed, tested, and validated by their community. I recall there being an unwillingness to provide a repository for fear that it would create an "endorsement" of plugins by being in the repository, but... I think you're right. People read and trust reviews. If they had a centralized place for reviewing plugins, I think that could really build confidence in using them, and provide people without technical knowledge a source to make more informed decisions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:57:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:57:51 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #7 from Jonathan Druart --- Created attachment 88990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88990&action=edit Bug 21027; Fix checkout statistics if 1+ of the fields is not defined -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:57:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:57:48 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:58:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:58:59 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #8 from Jonathan Druart --- Hi Katrin, I think this patch fixes the problem you faced. I did not read a test plan as I have to admit I completely forgot about that code and not sure how the changes could be completely tested. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 02:59:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 00:59:41 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #55 from David Cook --- (In reply to Martin Renvoize from comment #49) > This is a manageable risk. I believe we should end up with a repository of > signed and trusted plugins as per Alex's response (comment #48) and have a > granular set of permissions on the server as to what types of plugins may be > installed via the client. I've been wanting to work towards this for some > time, along with adding translations to plugins and generally enhancing the > system as a whole.. but these things all need sponsorship, time and money. > I love the sound of all of that, and I really relate in terms of time and money. I know I must sound like a troll by leaving lots of comments and not "doing" anything about them, but it's all I have time for at the moment. > Koha is a well established and highly reliable system these days, relied > upon by countless libraries. I am a firm believer in our quality assurance > policies and the both the commit logs and release notes serve to prove that > the software is still moving forward rapidly with enhancements and new > features continually being integrated. Yes, we could always do with more > hands/eyes on the code and people supporting each other by offering SO and > QA time. That is something I intend to work on if I am elected to be RM over > the next two cycles, but I think it's very unfair to suggest one has to have > extensive influence/power to get code into the community. I believe we are a > very supportive and friendly community in 99% of cases and I would certainly > support anyone's efforts to get code in.. sometimes it is hard to pick which > bugs to focus on and I'm always open to suggestions via any means (email, > irc, bugzilla priorities) > This is very true. I should have chosen my words more carefully. The Koha community is very supportive and very friendly. I don't think there's an open source community that is warmer and receptive than this one. I'm reminded of that every time I look at the photo of my child in a "Future Koha Developer" onesie that Katrin sent us when bub was born. It's true that you don't need extensive influence/power to get code into the community, and I use my first patch as evidence of that: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b49af1df17c06cb41d168fa154cb2104798c33cf. I'd been using Koha for less than 2 months at that point, and I didn't really know anyone in the Koha community. I think my earlier comment about influence/power relates to particular frustrations experienced by individuals that can be discussed elsewhere. Good luck with the elections, Martin! Koha would be very safe in your hands! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:03:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:03:25 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #56 from David Cook --- (In reply to Martin Renvoize from comment #51) > (In reply to Fridolin SOMERS from comment #50) > > > have a granular set of permissions on the server > > What about adding to koha-conf.xml a boolean to allow or not uploading > > plugins ? > > If not allowed only system admin can add plugins. > > > > My 2c > > You can already enable and disable plugins entirely from koha-conf can't > you.. I was thinking more having classifactions of plugins so you could > allow a whitelist of supported ones for example.. or say.. all cataloguing > plugins but not auth plugins. > > I like the idea of a whitelist. I think Fridolin was talking about leaving plugins enabled, but disabling the ability to upload via the Web UI. I've thought about doing this myself. A whitelist could be interesting. I also liked your mention earlier about signed plugins. One way of whitelisting could be to only allow plugins signed by keys you trust. I mean... that's how a lot of software installers already work, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:09:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:09:10 +0000 Subject: [Koha-bugs] [Bug 22799] New: Batch item modification is case sensitive Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 Bug ID: 22799 Summary: Batch item modification is case sensitive Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The tool is able to search for barcodes in the database fine, but the code then tries to match barcodes to check if retrieved with barcodes requested. This part is case sensitive and it looks like the fetch failed if the case in the search isn't the same as the case in the DB. To reproduce: 1) Make/use an item with a barcode with letters in it 2) Go to Tools -> Batch item modification and enter this barcode in the barcode list text input field, but change the case of one or some letters. (i.e. if the barcode is 'abcde', enter the barcode in the field as 'abCDE') 3) Click Continue 4) Notice that the next page shows an error 'the following barcodes were not found', but the item still shows underneath (was correctly fetched from database). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:09:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:09:27 +0000 Subject: [Koha-bugs] [Bug 22799] Batch item modification is case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:35:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:35:53 +0000 Subject: [Koha-bugs] [Bug 22799] Batch item modification is case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:35:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:35:56 +0000 Subject: [Koha-bugs] [Bug 22799] Batch item modification is case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 --- Comment #1 from Aleisha Amohia --- Created attachment 88991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88991&action=edit Bug 22799: Avoiding batch item modification case sensitivity when entering barcodes Note: this fixes the bug that is present right now where batch item modification barcode matching is case sensitive, but if Koha barcodes ever do become case sensitive, this patch will need to be removed. To test: 1) Make/use an item with a barcode with letters in it. For testing purposes, I'll be using an item with the barcode 'abcde'. 2) Go to Tools -> Batch item modification and enter this barcode in the barcode list text input field, but change the case of one or some letters. (i.e. enter the barcode in the field as 'abCDE') 3) Click Continue 4) Notice that the next page shows an error 'the following barcodes were not found', but the item still shows underneath (was correctly fetched from database). 5) Create a text file and put the changed-case barcode in it (i.e. put the barcode 'abCDE' in the text file) 6) Go back to batch item modification and upload the text file as a barcode file 7) Notice same error as in Step 4 8) Apply patch and refresh page 9) Run through steps 1 to 6. There should no longer be an error and the barcodes should be found as expected. Sponsored-by: TBC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:36:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:36:38 +0000 Subject: [Koha-bugs] [Bug 22799] Batch item modification is case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #2 from Aleisha Amohia --- Sponsored-by line is not final, but this can be tested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:41:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:41:43 +0000 Subject: [Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:41:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:41:46 +0000 Subject: [Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87598|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 88992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88992&action=edit Bug 22357: Do not duplicate report rows if several reports exist At the moment every time you run runreport.pl with the --store-results option another line will appear for your report in the saved reports table. This is not a data, but a display problem as the report is still only stored once. 1) Create a report and note the report number 2) Run from command line (replace X by report number) : misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results 3) Go to saved reports table 4) Look at the table, each run of the cronjob will create a new row in the table instead of just updating the saved results column. 5) Apply patch 6) Veriy the table displays correctly again and there are no regressions QA: Run t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:46:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:46:49 +0000 Subject: [Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #9 from Jonathan Druart --- This could be a fix (yes, ugly). We could also remove the s.* from the fields selection, but this will need to know which one is used (how, without making sure we will not introduce regressions?) Or we could have 1 query to fetch the reports, then 1 query per report to fetch the results (O(n), bad) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:52:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:52:20 +0000 Subject: [Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #19 from Jonathan Druart --- From commit e427cf5b3f3ded54dbc6899c149a2de3e8ab13ea Bug 19490: Add a 'Holds' column to the items batchmodification tool This following line: + $this_row{item_holds} = Koha::Holds->search( itemnumber => $itemnumber )->count; displays a DBIC warning: [Mon Apr 29 01:49:32.831375 2019] [cgi:error] [pid 17243] [client 192.168.50.1:42814] AH01215: [Mon Apr 29 01:49:32 2019] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use search( \\%condition ) instead at /home/vagrant/kohaclone/Koha/Objects.pm line 136: /home/vagrant/kohaclone/tools/batchMod.pl, referer: http://pro.kohadev.org/cgi-bin/koha/tools/batchMod.pl Must be ->search({ itemnumber => $itemnumber })->count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:58:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:58:17 +0000 Subject: [Koha-bugs] [Bug 22642] DB upgrade 18.06.00.005 can fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- Too late for installs that upgraded already? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 03:59:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 01:59:42 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 --- Comment #8 from Jonathan Druart --- (In reply to Jonathan Druart from comment #7) > IMO it would have been better to encode TT-side (see TT plugin To.json), raw > must be avoided as much as possible. This must be addressed, we should not use $raw when can be avoided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 04:11:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 02:11:27 +0000 Subject: [Koha-bugs] [Bug 22800] New: No need to raw filter the mandatory fields var (OPAC suggestions) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Bug ID: 22800 Summary: No need to raw filter the mandatory fields var (OPAC suggestions) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- This is a follow-up for bug 22550, we do not need to use the $raw filter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 04:12:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 02:12:08 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |22800 --- Comment #9 from Jonathan Druart --- The usage of raw could be avoided here, I have opened bug 22800 to remove it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 04:12:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 02:12:08 +0000 Subject: [Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 [Bug 22550] OPAC suggestion form doesn't require mandatory fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 04:13:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 02:13:53 +0000 Subject: [Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 04:13:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 02:13:56 +0000 Subject: [Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 --- Comment #1 from Jonathan Druart --- Created attachment 88993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88993&action=edit Bug 22800: (bug 22550 follow-up) Do not raw filter when not necessary (OPAC suggestions) This is a follow-up for bug 22550, we do not need to use the $raw filter. Test plan: Same as bug 22550: Test plan: Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 04:17:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 02:17:35 +0000 Subject: [Koha-bugs] [Bug 22799] Batch item modification is case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88991|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 88994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88994&action=edit Bug 22799: Avoiding batch item modification case sensitivity when entering barcodes Note: this fixes the bug that is present right now where batch item modification barcode matching is case sensitive, but if Koha barcodes ever do become case sensitive, this patch will need to be removed. To test: 1) Make/use an item with a barcode with letters in it. For testing purposes, I'll be using an item with the barcode 'abcde'. 2) Go to Tools -> Batch item modification and enter this barcode in the barcode list text input field, but change the case of one or some letters. (i.e. enter the barcode in the field as 'abCDE') 3) Click Continue 4) Notice that the next page shows an error 'the following barcodes were not found', but the item still shows underneath (was correctly fetched from database). 5) Create a text file and put the changed-case barcode in it (i.e. put the barcode 'abCDE' in the text file) 6) Go back to batch item modification and upload the text file as a barcode file 7) Notice same error as in Step 4 8) Apply patch and refresh page 9) Run through steps 1 to 6. There should no longer be an error and the barcodes should be found as expected. Sponsored-by: South Taranaki District Council -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 04:30:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 02:30:00 +0000 Subject: [Koha-bugs] [Bug 21122] Make check-url-quick.pl handle utf8 characters in urls gracefuly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 --- Comment #11 from Jonathan Druart --- (In reply to Jos?-Mario Monteiro-Santos from comment #10) > I'm not quite sure if I can ask about this here, but I've been having > problems when urls contain characters such as ? or ?. I understand that this > patch makes it so check-url-quick doesn't explode when it encounters such > characters, but when the http request is sent they're encoded differently > and are marked as broken links (? turns into ?? for example). Is this > related to this bug ? No, or I do not understand what you meant exactly. I have tried with 856$u = https://en.wikipedia.org/wiki/M?ori, then run the script with --verbose: 1 https://en.wikipedia.org/wiki/M?ori 200 OK Looks ok for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 04:32:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 02:32:38 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #28 from Jonathan Druart --- So, what's next? Waiting something from me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 04:35:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 02:35:28 +0000 Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 05:01:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 03:01:07 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 05:01:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 03:01:11 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 --- Comment #15 from Jonathan Druart --- Created attachment 88995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88995&action=edit Bug 13420: Sort "Serial enumeration" by published date So far the sorting on volume information is incorrect. It sorts by the string displayed in the cell, which may not have any logics. A better solution would be to use Kyle's suggestion, see comments 7, 8, but it will need much more work. This patch suggests to use the publication date to sort this column. Note: In the code there is a switch depending on the existence of items.publisheddate, but I do not think it is valid, this valid should always exist if the item is received (did I miss something?) Test plan: You need to have different existing subscription, using different numbering. On the detail page of the bibliographic record you should be able to sort the serials (tab "Holdings") by "Serial enumeration". The sort will now use the publication dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 05:04:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 03:04:12 +0000 Subject: [Koha-bugs] [Bug 21892] Robin Sheat is not a typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #16 from Jonathan Druart --- This is just complexifying everything for... what exactly? I am ok with "Sheat" being a typo, really. I am sure Robin will not mind much. I still think that display 3 lines to explain what's need to update to the new version is the best and easiest way to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 05:18:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 03:18:30 +0000 Subject: [Koha-bugs] [Bug 7862] Warns when creating a new notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7862 --- Comment #3 from Aleisha Amohia --- Created attachment 88996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88996&action=edit Bug 7862: Preventing warns when creating a notice To reproduce warns: 1) Go to Tools -> Notices & slips 2) Create a new notice of any module Notice these warns: Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. 3) Create a new notice of the Circulation module Notice this additional warn: Use of uninitialized value $code in pattern match (m//) at /home/vagrant/kohaclone/tools/letter.pl line 258. To test: 4) Apply patch and refresh page 5) Run steps 1-3 again and confirm no warns show Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 05:18:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 03:18:27 +0000 Subject: [Koha-bugs] [Bug 7862] Warns when creating a new notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7862 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 05:28:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 03:28:53 +0000 Subject: [Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 --- Comment #5 from Aleisha Amohia --- Created attachment 88997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88997&action=edit Bug 8558: Improve confirmation message for importing frameworks This patch updates the confirmation message from: "Do you really want to import the framework fields and subfields? This will overwrite the current configuration. For safety reasons please use the export option to make a backup" to: "Are you sure you want to import the [% loo.frameworkcode | html %] framework structure? This will overwrite the current configuration. For safety reasons, it is recommended to use the export option to make a backup first." To test: 1) Go to Administration -> MARC bibliographic frameworks 2) Export one of the frameworks 3) Create a new test framework 4) Import the new test framework structure using the exported file 5) Upon clicking Confirm, confirm the message is improved and makes sense. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 05:28:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 03:28:50 +0000 Subject: [Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 05:29:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 03:29:24 +0000 Subject: [Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 05:29:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 03:29:39 +0000 Subject: [Koha-bugs] [Bug 7862] Warns when creating a new notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7862 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 07:44:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 05:44:33 +0000 Subject: [Koha-bugs] [Bug 22279] Unify patron name display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7680 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7680 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 07:44:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 05:44:33 +0000 Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22279 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22279 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279 [Bug 22279] Unify patron name display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 07:59:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 05:59:31 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- Libraries not using the serials module still use the enumchron fields. So a fallback to the current behaviour is needed, even if not perfect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 08:54:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 06:54:49 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22524 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 08:54:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 06:54:49 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19575 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 08:54:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 06:54:40 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #104 from Ere Maijala --- Claire, the publication date mapping will be fixed in bug 22524. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 09:20:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 07:20:28 +0000 Subject: [Koha-bugs] [Bug 10945] Make Z39.50 work for queries that contain "Norwegian vowels" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10945 --- Comment #4 from Magnus Enger --- > I wonder if the problem is the target and not Koha? Could be! Do you happen to have a German target that can be searched with e.g. umlauts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 09:29:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 07:29:30 +0000 Subject: [Koha-bugs] [Bug 10945] Make Z39.50 work for queries that contain "Norwegian vowels" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10945 --- Comment #5 from Katrin Fischer --- Searching with umlauts works fine for us. We also had a Hebrew target for use in acquisition configured. All use utf8 encoding. Try one of these where it says "Anmeldung" = nein https://wiki.k10plus.de/pages/viewpage.action?pageId=131891207 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 09:31:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 07:31:00 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #53 from Andrew Isherwood --- Hi Katrin - It sounds like you didn't rebuild the CSS. Can you check you did, the hold date input box was behaving correctly for me after I performed the last modifications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 09:33:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 07:33:49 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 --- Comment #7 from Ere Maijala --- Created attachment 88998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88998&action=edit Bug 22524: Fix publication date and year search with Elasticsearch Also fixes the mappings.yaml to use correct field name (left over issue from bug 19575), so reset mappings and reindex before testing. Test plan: 1. Reset mappings and reindex biblios. 2. Check that tests in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t pass. 3. Try that all of the following year range type work in publication date search and year limit in advanced search: yyyy yyyy-yyyy -yyyy yyyy- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 09:34:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 07:34:38 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 --- Comment #8 from Ere Maijala --- Mike, I didn't notice the year limit and only fixed the publication date in the normal search terms. Now both should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 09:35:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 07:35:10 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #54 from Katrin Fischer --- (In reply to Andrew Isherwood from comment #53) > Hi Katrin - It sounds like you didn't rebuild the CSS. Can you check you > did, the hold date input box was behaving correctly for me after I performed > the last modifications. I thought I did, but can#t make sure before tonight. Can you please retest to make sure? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 09:39:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 07:39:49 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #154 from Fridolin SOMERS --- I see there is pubdate in etc/z3950/attribute_mappings.yaml but since Bug 19575 it is date-of-publication, isn't it ? Maybe check all changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 09:43:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 07:43:28 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #155 from Ere Maijala --- Actually, it's a bit borked. Bug 19575 missed the change to default mappings file. That will be fixed in bug 22524. I'll check the mappings to match what should be correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 09:44:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 07:44:49 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19575 CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Bug 19575 also renamed : date-time-last-modified => date/time-last-modified Can we fix in this bug ? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 [Bug 19575] Use canonical field names and resolve aliased fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 09:44:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 07:44:49 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 [Bug 22524] Elasticsearch - Date range in advanced search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 09:49:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 07:49:29 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 --- Comment #10 from Ere Maijala --- Thanks for pointing that out. I'll add to the patch here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:05:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:05:10 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88998|0 |1 is obsolete| | --- Comment #11 from Ere Maijala --- Created attachment 88999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88999&action=edit Bug 22524: Fix publication date and year search with Elasticsearch Also fixes the mappings.yaml to use correct field name (left over issue from bug 19575), so reset mappings and reindex before testing. Test plan: 1. Reset mappings and reindex biblios. 2. Check that tests in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t pass. 3. Try that all of the following year range type work in publication date search and year limit in advanced search: yyyy yyyy-yyyy -yyyy yyyy- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:05:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:05:13 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 --- Comment #12 from Ere Maijala --- Created attachment 89000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89000&action=edit Bug 22524: Fix date/time-last-modified search with Elasticsearch Avoid using slash in the field name since it would need to be escaped. Fix conversion of dtlm and any existing mapping. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:26:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:26:51 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18589 | Resolution|FIXED |--- Severity|enhancement |normal Status|RESOLVED |REOPENED --- Comment #7 from Martin Renvoize --- OK, I've had a chat with Andrew and he's informed me this isn't actually dependant on 18589 at all in reality.. it was just marked that way to prevent too much work rebasing the enhancements tree. As such, I'll backport this one this morning before releasing 18.11.05 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:26:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:26:51 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22464 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 [Bug 22464] Copyright notice does not pass forward request properties -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:26:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:26:57 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:27:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:27:10 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:27:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:27:20 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:27:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:27:15 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:37:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:37:12 +0000 Subject: [Koha-bugs] [Bug 22801] New: Advance search yr uses copydate instead of date-of-publication Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 Bug ID: 22801 Summary: Advance search yr uses copydate instead of date-of-publication Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com Target Milestone: --- In advanced search with Elasticsearch the limit on years range is actually using copydate : Koha/SearchEngine/Elasticsearch/QueryBuilder.pm in _fix_limit_special_cases() : if ( $l =~ /^yr,st-numeric,ge=/ ) { my ( $start, $end ) = ( $l =~ /^yr,st-numeric,ge=(.*) and yr,st-numeric,le=(.*)$/ ); next unless defined($start) && defined($end); push @new_lim, "copydate:[$start TO $end]"; } With Zebra it uses date-of-publication and also in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm : our %index_field_convert = ( (...) 'yr' => 'date-of-publication', -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:37:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:37:21 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:39:07 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22801 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:39:07 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22524 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 10:48:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 08:48:23 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Not sure if it helps, but for MARC21 the date range uses 008 and the publication year option int he pull down uses 260$c (maybe also 264$c, haven't checked). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 11:29:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 09:29:13 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 --- Comment #2 from axel --- Created attachment 89001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89001&action=edit Bug 18829: Elasticsearch - Add ability to view the ES indexed record This is groundwork - we need to make the display prettier, but for now it does at least dump the record into the template We probably also need a swtich to enable/disable this - or just move it into the left hand tabs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 11:34:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 09:34:24 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 axel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axel.amghar at gmail.com Attachment #64456|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 11:36:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 09:36:44 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 axel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89001|0 |1 is obsolete| | --- Comment #3 from axel --- Created attachment 89007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89007&action=edit Bug 18829: Elasticsearch - Add ability to view the ES indexed record This is groundwork - we need to make the display prettier, but for now it does at least dump the record into the template We probably also need a swtich to enable/disable this - or just move it into the left hand tabs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 11:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 09:39:07 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Christian Stelzenm?ller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 11:39:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 09:39:08 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com, | |ere.maijala at helsinki.fi, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 11:42:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 09:42:03 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #55 from Andrew Isherwood --- Hi Katrin - I've re-tested and all seems fine to me. I recorded a video just to make sure you agree: https://nimb.ws/oMZJ7F -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 11:42:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 09:42:39 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #9 from Christian Stelzenm?ller --- Created attachment 89008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89008&action=edit Screenshot_total_checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 12:25:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 10:25:47 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89008|Screenshot_total_checkouts |Screenshot_total_checkouts description| |without patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 12:32:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 10:32:14 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 --- Comment #2 from Fridolin SOMERS --- This is actually in etc/zebradb/ccl.properties : #Date 30 The point of time at which 005, 008/00-05, # a transaction or event 008/07-10, 260$c, # takes place. 008/11-14, 033,etc. # interpreting this as the copyright date in 260$c (MARC21) and 210$d (UNIMARC) copydate 1=30 r=r #Date-publication 31 The date (usually year) in 008/07-10, 260$c # which a document is published. 046, 533$d Date-of-publication 1=31 r=r yr Date-of-publication pubdate Date-of-publication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 12:41:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 10:41:39 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 --- Comment #3 from Katrin Fischer --- Hm, so copydate = 260$c 443 444 445 copydate:w 446 copydate:s 447 And pubdate 008: 49 50 pubdate:w 51 and pubdate = yr = Date-of-publication ... and we are missing proper indexing of 264 (see 15704) It seems I missed a change to advanced search, could have sworn we had publication year in the drop downs too. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 13:46:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 11:46:05 +0000 Subject: [Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 13:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 11:52:38 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 13:58:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 11:58:18 +0000 Subject: [Koha-bugs] [Bug 22799] Batch item modification is case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #4 from Josef Moravec --- I don't think so the barcode should be case insensitive - if you refer to barcode as main identifier for items, you need to make exact matches - taking your examples barcodes "abcde" and "abcDE" will not have same graphics represantation - so they are different. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 13:58:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 11:58:35 +0000 Subject: [Koha-bugs] [Bug 22734] Fund not marked as mandatory when ordering from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #12 from Owen Leonard --- (In reply to Martin Renvoize from comment #11) > Do we need a new bug opening for comment #8 It sounds like we do, but I'm unable to reproduce the problem. I think I just don't understand what the right circumstances are to trigger it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 13:58:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 11:58:41 +0000 Subject: [Koha-bugs] [Bug 22797] ILS-DI: GetRecords doesn't work with documented parameter id_type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22797 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 13:59:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 11:59:17 +0000 Subject: [Koha-bugs] [Bug 22796] koha-common and mariadb start in the wrong order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22796 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 13:59:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 11:59:44 +0000 Subject: [Koha-bugs] [Bug 22795] output of debian upgrade referecnes incorrect script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22795 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:00:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:00:27 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:03:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:03:35 +0000 Subject: [Koha-bugs] [Bug 22789] Establish Non-Priority Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:06:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:06:01 +0000 Subject: [Koha-bugs] [Bug 22788] Wrong accruing Overdue Amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22788 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:15:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:15:50 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_22787=5D_Mapping_missing_for_=C5=AF_?= =?utf-8?q?to_u_in_word-phrase-utf-chr?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22787 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:16:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:16:14 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_22787=5D_Mapping_missing_for_=C5=AF_?= =?utf-8?q?to_u_in_word-phrase-utf-chr?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22787 --- Comment #1 from Josef Moravec --- (In reply to Nick Clemens from comment #0) > The problem was noticed when searching for this author: > https://en.wikipedia.org/wiki/Bohuslav_Martin%C5%AF > > It seems we map this: > https://software.hixie.ch/utilities/cgi/unicode-decoder/character- > identifier?characters=u%CC%8A > > But not: > https://software.hixie.ch/utilities/cgi/unicode-decoder/character- > identifier?characters=%C5%AF Good catch Nick, I'll add a patch soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:24:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:24:29 +0000 Subject: [Koha-bugs] [Bug 22799] Batch item modification is case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- (In reply to Josef Moravec from comment #4) > I don't think so the barcode should be case insensitive - if you refer to > barcode as main identifier for items, you need to make exact matches - > taking your examples barcodes "abcde" and "abcDE" will not have same > graphics represantation - so they are different. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:31:13 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:34:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:34:35 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_22787=5D_Mapping_missing_for_=C5=AF_?= =?utf-8?q?to_u_in_word-phrase-utf-chr?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22787 --- Comment #2 from Josef Moravec --- Created attachment 89010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89010&action=edit Bug 22787: Add mapping of letters "?" and "?" to zebra definitions Test plan: 0) Do not apply the patch 1) Add some word with character "?" into metadata, for example author "Martin?, Bohuslav" 2) Try to search it with "Martinu" and you'll see you can't find it 3) Apply the patch 4) Copy file etc/zebradb/etc/word-phrase-utf.chr to your /etc/koha directory sudo cp etc/zebradb/etc/word-phrase-utf.chr /etc/koha/zebradb/etc/ 5) koha-zebra --restart kohadev 6) koha-rebuild-zebra -f kohadev 6) try to search "Martinu" again - you should be able to find your record Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:34:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:34:41 +0000 Subject: [Koha-bugs] [Bug 22802] New: When ordering form a staged file, if funds are populated per item order level fund should not be required Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Bug ID: 22802 Summary: When ordering form a staged file, if funds are populated per item order level fund should not be required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- To recreate: 1 - Set MarcItemFieldsToOder: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 970$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$g replacementprice: 975$p 2 - Create a MARC record with a 975 like: =975 \\$aCPL$bCPL$g27.99$oONORDER$q1$p22.39$7-1$yBK$hBUDGET_CODE 3 - Ensure budget code, itype, and branches are valid values for your system 4 - In a basket with create items so to 'on ordering' add the file above 5 - Try to add the order 6 - Order level fund is required -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:34:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:34:57 +0000 Subject: [Koha-bugs] [Bug 22802] When ordering form a staged file, if funds are populated per item order level fund should not be required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 [Bug 22734] Fund not marked as mandatory when ordering from a staged file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:34:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:34:57 +0000 Subject: [Koha-bugs] [Bug 22734] Fund not marked as mandatory when ordering from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 [Bug 22802] When ordering form a staged file, if funds are populated per item order level fund should not be required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:35:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:35:20 +0000 Subject: [Koha-bugs] [Bug 22734] Fund not marked as mandatory when ordering from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 --- Comment #13 from Nick Clemens --- (In reply to Owen Leonard from comment #12) > (In reply to Martin Renvoize from comment #11) > > Do we need a new bug opening for comment #8 > > It sounds like we do, but I'm unable to reproduce the problem. I think I > just don't understand what the right circumstances are to trigger it. bug 22802 opened -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:35:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:35:43 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_22787=5D_Mapping_missing_for_=C5=AF_?= =?utf-8?q?to_u_in_word-phrase-utf-chr?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22787 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:35:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:35:28 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_22787=5D_Mapping_missing_for_=C5=AF_?= =?utf-8?q?to_u_in_word-phrase-utf-chr?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22787 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:36:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:36:55 +0000 Subject: [Koha-bugs] [Bug 22279] Unify patron name display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:38:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:38:07 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:38:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:38:51 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:39:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:39:50 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 --- Comment #5 from Owen Leonard --- I would really like to replace Greybox. The original site (http://orangoo.com/labs/GreyBox/) appears to no longer exist. I realize it has been working fine, but I hate to be using something which is abandoned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:46:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:46:55 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 --- Comment #16 from Martin Renvoize --- Oops, I made a mistake here.. Whilst going back through the release notes I appear to have backported this enhancement and so it will be available in 18.11.05. It's a trivial, but nice enhancement so I'm included to keep it rather than revert. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:47:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:47:03 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |19.05.00, 18.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:47:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:47:30 +0000 Subject: [Koha-bugs] [Bug 22793] Suspend all hold button appears even if the hold can no longer be suspended in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22793 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:47:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:47:49 +0000 Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:49:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:49:15 +0000 Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Preparatory patch for GDPR release notes| |enhancements that may be | |forthcoming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:57:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:57:06 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 --- Comment #6 from Katrin Fischer --- (In reply to Owen Leonard from comment #5) > I would really like to replace Greybox. The original site > (http://orangoo.com/labs/GreyBox/) appears to no longer exist. I realize it > has been working fine, but I hate to be using something which is abandoned. I agree, but not sure how hard it would be. Do you need help? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 14:57:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 12:57:54 +0000 Subject: [Koha-bugs] [Bug 7107] 'used in' column on analytics not populating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7107 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC|director at plaistowlibrary.co |bibliwho at gmail.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:02:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:02:43 +0000 Subject: [Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:03:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:03:49 +0000 Subject: [Koha-bugs] [Bug 22779] Simplify add serials form to single page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22779 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:04:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:04:30 +0000 Subject: [Koha-bugs] [Bug 22776] Remove 5 periods on tools-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22776 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:13:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:13:01 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)|19.05.00 |19.05.00, 18.11.05 released in| | --- Comment #8 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:13:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:13:36 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 --- Comment #17 from Andrew --- No complaints here, thanks for the backporting! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:14:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:14:39 +0000 Subject: [Koha-bugs] [Bug 7916] Events module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7916 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:20:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:20:53 +0000 Subject: [Koha-bugs] [Bug 9844] Add a barcode queue to checkout / return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9844 --- Comment #4 from Josef Moravec --- (In reply to Katrin Fischer from comment #3) > This bug was filed 'pre-Plack' for staff interface and before the > performance improvements done since (2013). Is it still valid? I think it is still valid, although not as critical as before, sometimes a network lag or waiting to db lock when making backup could make circulation process a bit slower than it could be... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:21:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:21:20 +0000 Subject: [Koha-bugs] [Bug 21026] Statistics tab in patron account should show descriptions instead of codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21026 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:22:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:22:00 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:24:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:24:20 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:24:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:24:23 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88785|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:24:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:24:26 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:28:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:28:44 +0000 Subject: [Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #27 from Jonathan Druart --- Comment on attachment 88629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88629 Bug 22761: Add ability to use print version of ACCOUNT_CREDIT slip Review of attachment 88629: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22761&attachment=88629) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt @@ +19,5 @@ > >
    > + > +[% IF letter %] > + [% letter.content | evaltt %] evaltt? ::: members/printfeercpt.pl @@ +83,2 @@ > > $template->param( There are more parameters than before, I would expect less. Is that correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:32:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:32:49 +0000 Subject: [Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:34:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:34:09 +0000 Subject: [Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:49:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:49:39 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Can you explain the use case for this one? It seems a rather specific script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:53:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:53:19 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 --- Comment #10 from Hugo Agud --- This script it is designed for a better integration of koha database into discoveries, the info of this script is used by discoveries for creating hierarchical Facets. This script created a data like 2019-04-29 into a formatted tag that allows to create hierarchical Facets, in a way that end users may seach for records by year, month or day at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:56:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:56:22 +0000 Subject: [Koha-bugs] [Bug 9557] Syndetics: Include EANs from MARC records in links on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9557 --- Comment #3 from rkuiper at roundrocktexas.gov --- Katrin, I have checked about 40 items that don't have the cover image in the search results page and didn't find any that had a cover image on the details page. It used to be easy to find an example. Tentatively, I am saying we don't have the problem any more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:56:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:56:36 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 --- Comment #11 from Katrin Fischer --- Which date would you index like that? The record creation date? I have never seen anything like that in discoveries. It still appears very specific. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 15:57:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 13:57:23 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:09:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:09:02 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 --- Comment #12 from Hugo Agud --- usually the creation date yes, and yes again it is specific but for press search is really useful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:12:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:12:58 +0000 Subject: [Koha-bugs] [Bug 22803] New: Set dataTable width issue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Bug ID: 22803 Summary: Set dataTable width issue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: arthur.suzuki at biblibre.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When some columns are hidden in the Serials Subscription columns settings (see bug 11976) the table shrinks due to a "style=width:0%" which is automatically added by dataTable. Solved by adding a rule in css/datatables.css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:13:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:13:20 +0000 Subject: [Koha-bugs] [Bug 22803] Set dataTable width issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11976 Assignee|oleonard at myacpl.org |arthur.suzuki at biblibre.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 [Bug 11976] Add column settings + new column "Publication date" to the subscription table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:13:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:13:20 +0000 Subject: [Koha-bugs] [Bug 11976] Add column settings + new column "Publication date" to the subscription table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 [Bug 22803] Set dataTable width issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:20:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:20:27 +0000 Subject: [Koha-bugs] [Bug 22803] Set dataTable width issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 --- Comment #1 from Arthur Suzuki --- Created attachment 89011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89011&action=edit Bug 22803: Fix dataTable width Test plan : 1 - Go to Administration / Configure columns 2 - check Opac/serial_notes "is hidden by defaut" 3 - search a serials on the opac and in the opac-details page, subscriptions tab, find out that the table is shrinked on the left 4 - Apply patch 5 - Find out subscription table fills the tab correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:22:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:22:49 +0000 Subject: [Koha-bugs] [Bug 22803] Set dataTable width issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:24:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:24:11 +0000 Subject: [Koha-bugs] [Bug 22804] New: OPAC Overdrive JavaScript contains untranslatable strings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 Bug ID: 22804 Summary: OPAC Overdrive JavaScript contains untranslatable strings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- There are several English strings in overdrive.js. These should be moved into the template so they can be translated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:31:13 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #58 from Jonathan Druart --- At first glance I'd say that this patchset is going to conflict a lot with bug 18936 (and deps), that is going to remove the circ tables you are modifying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:31:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:31:23 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88735|0 |1 is obsolete| | Attachment #88736|0 |1 is obsolete| | Attachment #88737|0 |1 is obsolete| | Attachment #88738|0 |1 is obsolete| | Attachment #88739|0 |1 is obsolete| | Attachment #88740|0 |1 is obsolete| | Attachment #88741|0 |1 is obsolete| | Attachment #88742|0 |1 is obsolete| | Attachment #88743|0 |1 is obsolete| | Attachment #88744|0 |1 is obsolete| | --- Comment #133 from Josef Moravec --- Created attachment 89012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89012&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:31:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:31:29 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #134 from Josef Moravec --- Created attachment 89013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89013&action=edit Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:31:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:31:34 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #135 from Josef Moravec --- Created attachment 89014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89014&action=edit Bug 8995: (follow-up) Add tests, move open_url/coins routines to Koha namespace Test plan: 1) Ensure the COinS span tag is still included on this pages. You need to look into html source and search for span tag with class 'Z3988', which has COinS string in title. Staff client: catalogue -> ISBDdetail catalogue -> MARCdetail catalogue -> detail virtualshelves -> shelves OPAC (you should have COinSinOPACResults system preference enabled): opac detail opac search opac shelves 2) Run tests: prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t Signed-off-by: Magnus Enger Tested with all 9 current patches. Works as advertised, including OPACURLOpenInNewWindow. If a record has no items, no OpenURL link is displayed. All the suggested tests pass. I did not test with XSLT turned off. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:31:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:31:39 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #136 from Josef Moravec --- Created attachment 89015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89015&action=edit Bug 8995: (QA follow-up) Convert db update to perl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:32:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:32:32 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #137 from Josef Moravec --- (In reply to Nick Clemens from comment #132) > I like this one a lot - can we get a squashed/clean version of these patches > just for readability sake? Is this rebase OK for you Nick? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:32:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:32:56 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:35:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:35:41 +0000 Subject: [Koha-bugs] [Bug 22487] Add Mana and Bugzilla components on bugzilla In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22487 --- Comment #7 from Jonathan Druart --- (In reply to Martin Renvoize from comment #6) > We have various side projects popping up these days.. and like that they're > getting centralised onto gitlab but I do wonder how the community should be > involved in their maintenance. I agree it's a good idea to have a project > here for them so we're able to keep track of them in one place.. but whose > role is it to SO, QA, and Release such fixes into the wild..? > > Should it fall to the same team or should there be some roles with a > subteam.. Mana feels especially important to get right as it could end up > tracking the Koha release cycle as we add features to it and add support for > them in Koha. In my understanding if the community decides to integrate a project (Mana, Hea, etc.), they have to maintain/keep an eye on it (server-side as well). Could be good to discuss that in dev meeting? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 16:44:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 14:44:23 +0000 Subject: [Koha-bugs] [Bug 22803] Set dataTable width issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 --- Comment #2 from Owen Leonard --- Could you add a screeshot showing the problem? I don't think I'm seeing the problem. I'm hoping there might be another way to fix it. Adding an "!important" rule is not ideal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:14:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:14:38 +0000 Subject: [Koha-bugs] [Bug 22803] Set dataTable width issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 --- Comment #3 from Arthur Suzuki --- Created attachment 89016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89016&action=edit Shrinked subscription table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:14:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:14:56 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #59 from Agust?n Moyano --- (In reply to Jonathan Druart from comment #58) > At first glance I'd say that this patchset is going to conflict a lot with > bug 18936 (and deps), that is going to remove the circ tables you are > modifying. Hello Jonathan, for what I see, mostly test are going to conflict with those changes.. the modifications I did to circ tables where to add a new value to enum columns.. and with this new schema I don't think it will be a problem. I'll make this patch depend on 18936 and see what happens. Thanks for the warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:21:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:21:17 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:21:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:21:21 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86134|0 |1 is obsolete| | Attachment #86135|0 |1 is obsolete| | Attachment #86136|0 |1 is obsolete| | Attachment #86137|0 |1 is obsolete| | Attachment #86138|0 |1 is obsolete| | Attachment #86139|0 |1 is obsolete| | Attachment #88659|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 89017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89017&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:21:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:21:24 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #28 from Jonathan Druart --- Created attachment 89018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89018&action=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:21:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:21:28 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #29 from Jonathan Druart --- Created attachment 89019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89019&action=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:21:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:21:33 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #30 from Jonathan Druart --- Created attachment 89020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89020&action=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:21:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:21:36 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #31 from Jonathan Druart --- Created attachment 89021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89021&action=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:21:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:21:40 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #32 from Jonathan Druart --- Created attachment 89022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89022&action=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in Default checkout, hold and return policy section on circulation rules admin page, try for all libraries and for one specific library. Save. 2) Click on unset and confitm --> without patch, the Maximum total holds allowed value remains --> with patch the unset removex Maximum holds value too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:21:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:21:43 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #33 from Jonathan Druart --- Created attachment 89023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89023&action=edit [DO NOT PUSH] Bug 18928: DBIC schema update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:21:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:21:47 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #34 from Jonathan Druart --- Created attachment 89024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89024&action=edit Bug 18928: Use get_effective_rule in GetBranchItemRule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:22:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:22:58 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #35 from Jonathan Druart --- (In reply to Josef Moravec from comment #25) > Comment on attachment 86134 [details] [review] > Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to > circulation_rules > > Review of attachment 86134 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Circulation.pm > @@ +1706,5 @@ > > + > > + # Search for rules! > > + foreach my $rule_name (qw( holdallowed hold_fulfillment_policy returnbranch )) { > > + foreach my $params (@params) { > > + my $rule = Koha::CirculationRules->search( > > Why do you use ->search instead of get_effective_rule? Yes you are are right, it seems to make sense to use get_effective_rule. Done in a follow-up. > ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt > @@ +720,4 @@ > > Return policy > >   > > > > + [% FOREACH i IN itemtypeloop %] > > There is something strange in displaying hold policy for itemtypes. When I > have set values in Default checkout, hold and return policy section, i see > all item types listed with the same value as set in Default section, even if > i set some itemtypes differently... I cannot recreate that, can you share screenshots? I have attached a rebased version of these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:29:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:29:47 +0000 Subject: [Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 --- Comment #3 from Jonathan Druart --- Hi Hayley, It will work, but I am wondering if something like that would not be more readable: my $borr = sprintf( "%s%s%s (%s)", $data->{surname} || '', $data->{firstname} && $data->{surname} ? ', ' : '', $data->{firstname} || '', $borrowernumber ); What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:44:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:44:38 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:44:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:44:41 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 --- Comment #4 from Owen Leonard --- Created attachment 89025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89025&action=edit Bug 22424: (follow-up) Show blank value for empty status This patch updates the screen and CSV output of item searches so that if the item does not have a lost status a blank table cell is shown instead of "0." This patch also amends the table headers so that "Not for loan" statuses are explicitly labeled as such, and the "Lost" column has the header "Lost status." To test, apply the patch and perform an item search in the staff client which will return results with notforloan and lost items. Verify that the values display correctly in both onscreen and CSV output. Verify that the column headers look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:48:56 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:49:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:49:00 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85434|0 |1 is obsolete| | Attachment #85435|0 |1 is obsolete| | Attachment #85436|0 |1 is obsolete| | Attachment #85437|0 |1 is obsolete| | Attachment #85438|0 |1 is obsolete| | Attachment #85439|0 |1 is obsolete| | Attachment #85440|0 |1 is obsolete| | Attachment #88446|0 |1 is obsolete| | Attachment #88868|0 |1 is obsolete| | --- Comment #56 from Liz Rea --- Created attachment 89026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89026&action=edit Bug 7088: Add AllowRenewalOnHoldOverride syspref Enables the renewal of on hold items with specified due dates to be turned on/off Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:49:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:49:09 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #57 from Liz Rea --- Created attachment 89027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89027&action=edit Bug 7088: Allow renew on hold items with due date This patch adds the ability for items that are on hold to be renewed with a due date specfied by the user. It is enabled by the new "AllowRenewalOnHoldOverride" syspref. It is manifested in two locations: 1. In the "Checkouts" table on the Patron Details screen. It is now possible to select on loan items that would otherwise fulfil a hold request to be renewed. When such an item is selected, an additional date selection box is displayed to allow the user to specify the due date for all on hold items that are to be renewed. 2. In the Circulation > Renew alert screen. When a barcode of an on loan item that would ordinarily fulfil a hold request is entered, the usual alert is displayed indicating that the item is on hold, it is still possible to override this, and renew, however it is now also possible to specify a due date. Test plan: - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it is NOT possible to select this item - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it IS possible to select this item - Select the item - TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item - TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" - TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" - TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" - TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" - TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit - TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" - TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:49:13 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #58 from Liz Rea --- Created attachment 89028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89028&action=edit Bug 7088: (follow-up) Fix renewal limit bug There was a bug in that altering the state of the "Override renewal limit" checkbox was altering the appearance of the per-item "On hold" checkbox. This is incorrect, the "Override renewal limit" checkbox is unconnected with this bug. Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:49:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:49:16 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #59 from Liz Rea --- Created attachment 89029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89029&action=edit Bug 7088: (follow-up) Remove script "type" attribute As per item 1 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:49:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:49:20 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #60 from Liz Rea --- Created attachment 89030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89030&action=edit Bug 7088: (follow-up) Set syspref default to off As per item 2 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:49:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:49:25 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #61 from Liz Rea --- Created attachment 89031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89031&action=edit Bug 7088: (follow-up) Default hold checkbox display As per item 4 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Now, the checkbox for renewing on hold items behaves the same way as the checkbox for renewing items that have reached their renew limit. It is necessary to check the re-labelled "Override renewal restrictions" checkbox before it is possible to select on-hold items for renewal. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:49:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:49:29 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #62 from Liz Rea --- Created attachment 89032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89032&action=edit Bug 7088: (follow-up) Add pref to checkbox As per commit #29 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c29 Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:49:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:49:33 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #63 from Liz Rea --- Created attachment 89033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89033&action=edit Bug 7088: (follow-up) AllowRenewalLimitOverride fix This patch causes the click event listener on the #override_limit to be created if EITHER the AllowRenewalOnHoldOverride OR AllowRenewalLimitOverride sysprefs are enabled. Previously, it would only be created if the AllowRenewalLimitOverride syspref was enabled, which would cause the checkbox to be displayed but do nothing. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:49:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:49:37 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #64 from Liz Rea --- Created attachment 89034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89034&action=edit Bug 7088: (follow-up) Modify checkbox enabling As described in comment #50, we need to only enable renewal on items that are disabled in line with which sysprefs are enabled. So we now only enable renewal of on hold items if the AllowRenewalOnHoldOverride syspref is on and we only enable renewal of all other limited items when the AllowRenewalLimitOverride syspref is on. NOTE: The test plan below has changed substantially from previous iterations Test plan (you might want to make a coffee first...): - Apply patch - Rebuild CSS - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - The patron also needs to have an item on loan that cannot be renewed for some other reason, say renewal limit has been reached => TEST: Observe that it is NOT possible to select either item for renewal - Enable the "AllowRenewalLimitOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, but not the item that is on hold - Disable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it is NOT possible to select the the item that has reached the renewal limit, but it IS possible to select the item on hold - Enable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, AND it IS possible to select the item on hold - Select the item that is on hold => TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item => TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" => TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" => TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" => TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" => TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit => TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" => TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:54:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:54:02 +0000 Subject: [Koha-bugs] [Bug 22803] Set dataTable width issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:54:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:54:04 +0000 Subject: [Koha-bugs] [Bug 22803] Set dataTable width issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 --- Comment #4 from Owen Leonard --- Created attachment 89035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89035&action=edit Bug 22803: (alternate) Set dataTable width issue This patch sets the "autowidth" option to "false" for the OPAC subscriptions DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with a subscription. Under the "Subscriptions" tab, the table of latest issues should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 17:54:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 15:54:58 +0000 Subject: [Koha-bugs] [Bug 22803] Set dataTable width issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 --- Comment #5 from Owen Leonard --- I'm proposing an alternate solution. I think this is the correct way to deal with it within the options provided by DataTables. The "autowidth" option should probably be set to "false" globally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:00:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:00:06 +0000 Subject: [Koha-bugs] [Bug 22805] New: When borrowers.dateofbirth is set to a date matching '0YYY-MM-DD', memberentry.pl crashes on save. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22805 Bug ID: 22805 Summary: When borrowers.dateofbirth is set to a date matching '0YYY-MM-DD', memberentry.pl crashes on save. Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Symptom: Crash on save when in memberentry.pl for a particular patron. Inspecting the plack error logs, I saw The given date (02/26/986) does not match the date format (us) at /usr/share/koha/lib/Koha/DateUtils.pm line 168. To replicate: Edit a patron. Set the first digit in the year of the patron's birthday to 0, e.g for a 'MM/DD/YYYY' formatted date, this would be '02/26/0986' Click save. This causes an Internal Server Error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:00:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:00:31 +0000 Subject: [Koha-bugs] [Bug 22805] When borrowers.dateofbirth is set to a date matching '0YYY-MM-DD', memberentry.pl crashes on save. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22805 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:00:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:00:55 +0000 Subject: [Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:00:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:00:58 +0000 Subject: [Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88992|0 |1 is obsolete| | --- Comment #10 from Liz Rea --- Created attachment 89036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89036&action=edit Bug 22357: Do not duplicate report rows if several reports exist At the moment every time you run runreport.pl with the --store-results option another line will appear for your report in the saved reports table. This is not a data, but a display problem as the report is still only stored once. 1) Create a report and note the report number 2) Run from command line (replace X by report number) : misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results 3) Go to saved reports table 4) Look at the table, each run of the cronjob will create a new row in the table instead of just updating the saved results column. 5) Apply patch 6) Veriy the table displays correctly again and there are no regressions QA: Run t/db_dependent/Reports/Guided.t Signed-off-by: Liz Rea I didn't assess this for "code ugliness" but the functionality does seem good, and fixes the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:20:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:20:01 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #57 from Martin Renvoize --- QA looking here. I've got a couple of points to make before continuing. 1) The 'die' on fork failure isn't cleaning up after itself.. imagine a case where we want to sporn 5 subprocesses, it we get to process 4 and then run out of memory for example. The parent script will die and leave behind zombie child processes. 2) It doesn't look like there's any form of signal handling here and as such a CTRL+C for example could end up leaving zombie processes too. I'm also wrapping my head around the use of wait vs waitpid here.. I remember tripping myself up using them before, but can't remember the details well enough right now to be confident I've not missed something. Finally, I'll be looking into the possibility of race conditions being introduced with this. We had to introduce lock files for the zebra indexer as overlapping runs of the script could cause problems, especially with the query that got the list of bib/auths to index during each run. I'm vaguely feeling that might also be a problem here, but I'm not entirely sure yet as I'm still looking at how the iterator is being built. It's great to see this work however.. I'd love to see if make it into the 19.05 release. Failing for the first issue raised above for now. (I found https://www.perl.com/article/fork-yeah-/ pretty helpful whilst QAing this.. it gave me the insight to spot the above issues where I may have missed them otherwise) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:20:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:20:03 +0000 Subject: [Koha-bugs] [Bug 20421] Apply CheckPrevCheckout logic when placing a hold on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #19 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:20:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:20:28 +0000 Subject: [Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #19 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:20:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:20:30 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 --- Comment #12 from Jonathan Druart --- Hi Josef, thanks for the rebase. I have also rebased them against master (so hard!) and added a fix for the Auth_with_ldap.t failure. I am stuck with the other failure. I think we need to know if we (dev team) want this patchset. If so we will need to have a task force to have it cleaned and pushed at the beginning of the next release cycle. It will be impossible to rebase this branch for months. Who's in? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:20:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:20:52 +0000 Subject: [Koha-bugs] [Bug 22537] Don't show Suspend all holds button when holds can no longer be susppended in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:20:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:20:39 +0000 Subject: [Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #27 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:21:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:21:19 +0000 Subject: [Koha-bugs] [Bug 22772] Menu link hover color incorrect in OPAC language choosers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:21:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:21:05 +0000 Subject: [Koha-bugs] [Bug 22757] Use YAML CodeMirror higlighting on YAML preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22757 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:22:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:22:26 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #138 from Nick Clemens --- (In reply to Josef Moravec from comment #137) > (In reply to Nick Clemens from comment #132) > > I like this one a lot - can we get a squashed/clean version of these patches > > just for readability sake? > > Is this rebase OK for you Nick? Indeed, thanks Josef!. I was worried that changes don't work without XSLT, but if I understand earlier comments they were remove as that view is deprecated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:22:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:22:35 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #176 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:23:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:23:09 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #139 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:27:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:27:54 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:27:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:27:57 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87369|0 |1 is obsolete| | --- Comment #7 from Liz Rea --- Created attachment 89037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89037&action=edit Bug 22630: Allow to change homebranch in course reserves Test plan: 1. Create a course (disabled) 2. Add a reserve to this course for an item and set a homebranch different from the item's homebranch 3. Enable the course 4. Verify that the item's homebranch has changed 5. Disable the course 6. Verify that the item's homebranch was reset to its initial value 7. prove t/db_dependent/CourseReserves/CourseItems.t Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:30:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:30:33 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #8 from Liz Rea --- Have just retested this on a dockerbox, all looks ok by me, item is modified as I expected (on top of 22652) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:42:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:42:21 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #140 from Katrin Fischer --- Maybe we should update to new feature? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:50:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:50:01 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 --- Comment #58 from David Gustafsson --- Good points. With regard to the race condition I'm pretty sure there is none since the data is partitioned per process. No process should ever process the data of any of the others. Or are you talking about running multiple instances of the script at the same time? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:56:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:56:04 +0000 Subject: [Koha-bugs] [Bug 21671] Koha/Patron/Modifications.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:56:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:56:06 +0000 Subject: [Koha-bugs] [Bug 21671] Koha/Patron/Modifications.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82238|0 |1 is obsolete| | --- Comment #3 from Liz Rea --- Created attachment 89038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89038&action=edit Bug 21671: Prevent Modifications.t to fail randomly If repeatable is set to 0 by TestBuilder, the tests will fail with: t/db_dependent/Koha/Patron/Modifications.t .. 1/6 # Looks like you planned 20 tests but ran 9. # Failed test 'approve tests' # at t/db_dependent/Koha/Patron/Modifications.t line 259. [repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5. Signed-off-by: Liz Rea I couldn't get the test to fail, but it still passes with this change and if Jonathan thinks it needs it, it probably does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 18:59:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 16:59:24 +0000 Subject: [Koha-bugs] [Bug 22806] New: HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Bug ID: 22806 Summary: HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: arthur.suzuki at biblibre.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- ILS-DI methods HoldTitle and HoldItem do not check this syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 19:04:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 17:04:09 +0000 Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |arthur.suzuki at biblibre.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 19:04:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 17:04:21 +0000 Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #1 from Arthur Suzuki --- Created attachment 89039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89039&action=edit Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and reply "itemAlreadyOnLoan" Veuillez saisir le message de validation pour vos modifications. Les lignes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 19:48:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 17:48:32 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|david.bourgault at inlibro.com | |, | |francois.charbonnier at inlibr | |o.com, | |maxime.beaulieu at inlibro.com | |, | |philippe.audet-fortin at inlib | |ro.com, | |remi.mayrand-provencher at inL | |ibro.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 19:50:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 17:50:43 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|francois.charbonnier at inlibr |eric.begin at inLibro.com |o.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 19:50:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 17:50:58 +0000 Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|francois.charbonnier at inlibr | |o.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 20:07:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 18:07:16 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 --- Comment #13 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #12) > Hi Josef, thanks for the rebase. > I have also rebased them against master (so hard!) and added a fix for the > Auth_with_ldap.t failure. > I am stuck with the other failure. > > I think we need to know if we (dev team) want this patchset. If so we will > need to have a task force to have it cleaned and pushed at the beginning of > the next release cycle. It will be impossible to rebase this branch for > months. > > Who's in? I'm in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 20:29:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 18:29:10 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88820|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 20:29:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 18:29:16 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88818|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 20:29:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 18:29:21 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88819|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 20:29:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 18:29:24 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86964|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 20:29:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 18:29:05 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 20:30:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 18:30:13 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #25 from Tom?s Cohen Arazi --- Created attachment 89041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89041&action=edit Bug 22053: ability to enable/disable some plugins Test plan: - apply this patch(es), - launch an updatedabase, - go to plugins/plugins-home.pl and deal with enable/disable method - install a plugin like KitchenSink https://github.com/bywatersolutions/koha-plugin-kitchen-sink - once installed, the plugin change the background color of the staff client to orange. - disable the plugin, - background color should be set back to the original one Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 20:30:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 18:30:22 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #26 from Tom?s Cohen Arazi --- Created attachment 89042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89042&action=edit Bug 22053: update database Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 20:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 18:30:29 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #27 from Tom?s Cohen Arazi --- Created attachment 89043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89043&action=edit Bug 22053: (QA follow-up) More tests This patch adds tests for: - $plugin->enable and $plugin->disable are chainable (i.e. return $self) - Disabled plugins don't inject routes To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t \ t/db_dependent/Plugins.t => SUCCESS: Tests pass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 20:30:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 18:30:06 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #24 from Tom?s Cohen Arazi --- Created attachment 89040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89040&action=edit Bug 22053: create unit tests Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 20:31:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 18:31:36 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:29:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:29:44 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89026|0 |1 is obsolete| | --- Comment #65 from Katrin Fischer --- Created attachment 89044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89044&action=edit Bug 7088: Add AllowRenewalOnHoldOverride syspref Enables the renewal of on hold items with specified due dates to be turned on/off Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:29:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:29:50 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89027|0 |1 is obsolete| | --- Comment #66 from Katrin Fischer --- Created attachment 89045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89045&action=edit Bug 7088: Allow renew on hold items with due date This patch adds the ability for items that are on hold to be renewed with a due date specfied by the user. It is enabled by the new "AllowRenewalOnHoldOverride" syspref. It is manifested in two locations: 1. In the "Checkouts" table on the Patron Details screen. It is now possible to select on loan items that would otherwise fulfil a hold request to be renewed. When such an item is selected, an additional date selection box is displayed to allow the user to specify the due date for all on hold items that are to be renewed. 2. In the Circulation > Renew alert screen. When a barcode of an on loan item that would ordinarily fulfil a hold request is entered, the usual alert is displayed indicating that the item is on hold, it is still possible to override this, and renew, however it is now also possible to specify a due date. Test plan: - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it is NOT possible to select this item - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it IS possible to select this item - Select the item - TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item - TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" - TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" - TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" - TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" - TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit - TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" - TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:29:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:29:55 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89028|0 |1 is obsolete| | --- Comment #67 from Katrin Fischer --- Created attachment 89046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89046&action=edit Bug 7088: (follow-up) Fix renewal limit bug There was a bug in that altering the state of the "Override renewal limit" checkbox was altering the appearance of the per-item "On hold" checkbox. This is incorrect, the "Override renewal limit" checkbox is unconnected with this bug. Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:29:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:29:59 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89029|0 |1 is obsolete| | --- Comment #68 from Katrin Fischer --- Created attachment 89047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89047&action=edit Bug 7088: (follow-up) Remove script "type" attribute As per item 1 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:30:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:30:04 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89030|0 |1 is obsolete| | --- Comment #69 from Katrin Fischer --- Created attachment 89048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89048&action=edit Bug 7088: (follow-up) Set syspref default to off As per item 2 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:30:09 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89031|0 |1 is obsolete| | --- Comment #70 from Katrin Fischer --- Created attachment 89049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89049&action=edit Bug 7088: (follow-up) Default hold checkbox display As per item 4 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Now, the checkbox for renewing on hold items behaves the same way as the checkbox for renewing items that have reached their renew limit. It is necessary to check the re-labelled "Override renewal restrictions" checkbox before it is possible to select on-hold items for renewal. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:30:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:30:14 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89032|0 |1 is obsolete| | --- Comment #71 from Katrin Fischer --- Created attachment 89050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89050&action=edit Bug 7088: (follow-up) Add pref to checkbox As per commit #29 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c29 Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:30:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:30:19 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89033|0 |1 is obsolete| | --- Comment #72 from Katrin Fischer --- Created attachment 89051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89051&action=edit Bug 7088: (follow-up) AllowRenewalLimitOverride fix This patch causes the click event listener on the #override_limit to be created if EITHER the AllowRenewalOnHoldOverride OR AllowRenewalLimitOverride sysprefs are enabled. Previously, it would only be created if the AllowRenewalLimitOverride syspref was enabled, which would cause the checkbox to be displayed but do nothing. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:30:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:30:24 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89034|0 |1 is obsolete| | --- Comment #73 from Katrin Fischer --- Created attachment 89052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89052&action=edit Bug 7088: (follow-up) Modify checkbox enabling As described in comment #50, we need to only enable renewal on items that are disabled in line with which sysprefs are enabled. So we now only enable renewal of on hold items if the AllowRenewalOnHoldOverride syspref is on and we only enable renewal of all other limited items when the AllowRenewalLimitOverride syspref is on. NOTE: The test plan below has changed substantially from previous iterations Test plan (you might want to make a coffee first...): - Apply patch - Rebuild CSS - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - The patron also needs to have an item on loan that cannot be renewed for some other reason, say renewal limit has been reached => TEST: Observe that it is NOT possible to select either item for renewal - Enable the "AllowRenewalLimitOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, but not the item that is on hold - Disable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it is NOT possible to select the the item that has reached the renewal limit, but it IS possible to select the item on hold - Enable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, AND it IS possible to select the item on hold - Select the item that is on hold => TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item => TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" => TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" => TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" => TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" => TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit => TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" => TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:42:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:42:47 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #74 from Katrin Fischer --- Hi Andrew, it might be my messed up rebase (changes from 21757 caused a conflict), but now the hold due date never shows up. Test case: - Hold renewals allowed - Renewal limit overrides are not 2 items on my account, both are 'on hold' Check the checkbox - checkboxes unlock But: the date doesn't show up I am sorry, I'll give it another go tomorrow! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:45:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:45:20 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:59:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:59:14 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:59:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:59:18 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88850|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 89053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89053&action=edit Bug 22424: Add search by all lost statuses to item search This patch changes the item search form so that searching by lost status includes options for all lost authorised values instead of just "yes" or "no." To test you should have multiple authorized values for LOST. - Apply the patch and open the item search form. - Test searches which limit by lost status. Confirm that results are correctly limited. - Confirm that lost statuses are correctly displayed in the search results. - Confirm that in the search results table, the column header for "Lost" includes a dropdown menu for filtering by all available authorized values for lost. - Test the CSV export function and confirm that lost status is correctly exported. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:59:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:59:21 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89025|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 89054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89054&action=edit Bug 22424: (follow-up) Show blank value for empty status This patch updates the screen and CSV output of item searches so that if the item does not have a lost status a blank table cell is shown instead of "0." This patch also amends the table headers so that "Not for loan" statuses are explicitly labeled as such, and the "Lost" column has the header "Lost status." To test, apply the patch and perform an item search in the staff client which will return results with notforloan and lost items. Verify that the values display correctly in both onscreen and CSV output. Verify that the column headers look correct. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 21:59:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 19:59:51 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 --- Comment #7 from Katrin Fischer --- Thank you for the quick follow-up, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 22:01:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 20:01:29 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Michal Denar --- Hi Ere, I get error: Applying: Bug 22524: Fix publication date search with Elasticsearch Applying: Bug 22524: Fix publication date and year search with Elasticsearch Using index info to reconstruct a base tree... M Koha/SearchEngine/Elasticsearch/QueryBuilder.pm M admin/searchengine/elasticsearch/mappings.yaml M t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Auto-merging Koha/SearchEngine/Elasticsearch/QueryBuilder.pm CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm error: Failed to merge in the changes. Can you rebase it on the top of master. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 22:06:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 20:06:23 +0000 Subject: [Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 22:06:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 20:06:27 +0000 Subject: [Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89036|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 89055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89055&action=edit Bug 22357: Do not duplicate report rows if several reports exist At the moment every time you run runreport.pl with the --store-results option another line will appear for your report in the saved reports table. This is not a data, but a display problem as the report is still only stored once. 1) Create a report and note the report number 2) Run from command line (replace X by report number) : misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results 3) Go to saved reports table 4) Look at the table, each run of the cronjob will create a new row in the table instead of just updating the saved results column. 5) Apply patch 6) Veriy the table displays correctly again and there are no regressions QA: Run t/db_dependent/Reports/Guided.t Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 22:07:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 20:07:48 +0000 Subject: [Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 --- Comment #12 from Katrin Fischer --- Works for me, no regressions found (keyword search still works too!). Thx for the fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 22:22:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 20:22:47 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Ok, I did: - Apply the patch - restart_all - updatedatabase - dbic - restart_all Then I added 2 items to course reserves: 1) Leaving all unchanged - Everything shows up in the table correctly - OK - When editing, they all show "Leave unchanged" - OK - But: change all settings, they are not saved! - BOO! Logs show: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) [for Statement "UPDATE items SET itype=?,homebranch=?,holdingbranch=?,ccode=?,permanent_location=?,location=? WHERE itemnumber=?" with ParamValues: 0="", 1="", 2="", 3="", 4="", 5="", 6=14] at /home/vagrant/kohaclone/C4/Items.pm line 1811. ERROR in _koha_modify_item UPDATE items SET itype=?,homebranch=?,holdingbranch=?,ccode=?,permanent_location=?,location=? WHERE itemnumber=?: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at /home/vagrant/kohaclone/C4/Items.pm line 1814. 2) Change all values - The location is missing from the display summary table (empty) - BOO! - When editing, the home library shows as 'unchanged' - BOO! Sorry for the BOOs, but I think this still needs some work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 22:24:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 20:24:59 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- Do we have a choice? We decided on the move to the new namespace as a community... so I think we don't. I'll help where I can. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 22:28:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 20:28:12 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88758|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 22:28:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 20:28:28 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #14 from Katrin Fischer --- I thikn the first patch was not obsoleted - can you try again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 22:41:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 20:41:40 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 --- Comment #15 from Michal Denar --- Hi Katrin, still bad: pplying: Bug 22524: Fix publication date and year search with Elasticsearch Using index info to reconstruct a base tree... M Koha/SearchEngine/Elasticsearch/QueryBuilder.pm M admin/searchengine/elasticsearch/mappings.yaml M t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Auto-merging Koha/SearchEngine/Elasticsearch/QueryBuilder.pm CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm error: Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 22:46:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 20:46:44 +0000 Subject: [Koha-bugs] [Bug 22786] Can create new funds for locked budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |oleonard at myacpl.org --- Comment #1 from Jonathan Druart --- 1. It seems that there is an ergonomic issue, the link should not be there. I guess we should reuse the tooltip behavior we have on the patron's detail page. Other links are impacted as well. Owen, do you agree? 2. There is a business logic issue, we must raise an exception when we want to create a new fund for a budget that is locked (do we really want that?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 23:01:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 21:01:19 +0000 Subject: [Koha-bugs] [Bug 22797] ILS-DI: GetRecords doesn't work with documented parameter id_type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Works for me: /cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=42&id_type=cardnumber returns 51 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 23:11:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 21:11:34 +0000 Subject: [Koha-bugs] [Bug 22797] ILS-DI: GetRecords doesn't work with documented parameter id_type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22797 --- Comment #2 from Jonathan Druart --- And /cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=1+2+99999&id_type=item returns 1availableCenterville2availableCenterville99999unknownError: could not retrieve availability for this ID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 23:16:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 21:16:14 +0000 Subject: [Koha-bugs] [Bug 22797] ILS-DI: GetRecords doesn't work with documented parameter id_type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22797 --- Comment #3 from Jonathan Druart --- Scratch the last 2 comments, it was not GetRecords. It is in the POD since the first commit but has never been implemented. So either we implement it, or we remove it from POD and doc :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 23:30:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 21:30:55 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 --- Comment #10 from Liz Rea --- (In reply to Katrin Fischer from comment #9) > Ok, I did: > > - Apply the patch > - restart_all > - updatedatabase > - dbic > - restart_all > > > Then I added 2 items to course reserves: > > 1) Leaving all unchanged > - Everything shows up in the table correctly - OK > - When editing, they all show "Leave unchanged" - OK > - But: change all settings, they are not saved! - BOO! I just tested this again, and they were saved? > > Logs show: > > DBD::mysql::st execute failed: Cannot add or update a child row: a foreign > key constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_2` > FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE > CASCADE) [for Statement "UPDATE items SET > itype=?,homebranch=?,holdingbranch=?,ccode=?,permanent_location=?,location=? > WHERE itemnumber=?" with ParamValues: 0="", 1="", 2="", 3="", 4="", 5="", > 6=14] at /home/vagrant/kohaclone/C4/Items.pm line 1811. > ERROR in _koha_modify_item UPDATE items SET > itype=?,homebranch=?,holdingbranch=?,ccode=?,permanent_location=?,location=? > WHERE itemnumber=?: Cannot add or update a child row: a foreign key > constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN > KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) > at /home/vagrant/kohaclone/C4/Items.pm line 1814. I did not receive this message. > > 2) Change all values > - The location is missing from the display summary table (empty) - BOO! This appears on my screen, between collection and home library? > - When editing, the home library shows as 'unchanged' - BOO! Legit, I missed this. :( > > Sorry for the BOOs, but I think this still needs some work. It does, but possibly not as much as all of this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 23:38:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 21:38:44 +0000 Subject: [Koha-bugs] [Bug 22010] RecordedBooks and OverDrive should check preferences over passing variables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 23:38:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 21:38:47 +0000 Subject: [Koha-bugs] [Bug 22010] RecordedBooks and OverDrive should check preferences over passing variables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88775|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 89056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89056&action=edit Bug 22010: Check preferences for ebook integration To test: 1 - Enable OverDrive and RecordedBooks (you can put anything in the prefs) 2 - Search on the opac - verify you get results (or search error) on first page of results' 3 - Go to second page of results - OD and RB are not searched 4 - Apply patch 5 - Verify nothing has changed If you have valid credentials: 1 - Enable RB prefs 2 - Sign in with an account that has an email matching your registered account for recordedbooks 3 - Confirm you RB account loads on opac-user.pl Otherwise: Read the patches, verify it all makes sense Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 23:44:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 21:44:36 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88974|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 89057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89057&action=edit Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration Silly bug caused by: commit ef410fd62f279a10687636a4f26babb2c91ecadc Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber Constructors take a hashref! Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 23:48:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 21:48:13 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 23:52:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 21:52:35 +0000 Subject: [Koha-bugs] [Bug 22805] When borrowers.dateofbirth is set to a date matching '0YYY-MM-DD', memberentry.pl crashes on save. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Do you have a specific use case? :) Koha::DateUtils considers that years are formed by 4 digits, 986 is not correctly parsed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 29 23:55:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Apr 2019 21:55:46 +0000 Subject: [Koha-bugs] [Bug 22738] Software Error after LDAP Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 02:35:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 00:35:26 +0000 Subject: [Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 02:35:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 00:35:28 +0000 Subject: [Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83475|0 |1 is obsolete| | --- Comment #4 from Liz Rea --- Created attachment 89058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89058&action=edit Bug 22046: Simplify and unify the code for get_matches To test: 1 - Stage some records for import 2 - Manage the records 3 - Use several different matching rules and note the results 4 - Apply patch 5 - Try several matching rules again and note the results have not changed 6 - Try under both search engines (Zebra and ES) Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 02:42:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 00:42:40 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 02:42:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 00:42:43 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76099|0 |1 is obsolete| | Attachment #76100|0 |1 is obsolete| | --- Comment #9 from Liz Rea --- Created attachment 89059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89059&action=edit Bug 19288: [Alternate] Only show existence of item level hold unless waiting To test: 1 - Please a biblio level hold for one patron, and an item level hold for another on same record 2 - Note that you patron name for item lvel hold 3 - Apply patch 4 - You should now see 'There is a hold on this item' with no patron detail 5 - Confirm hold, patron detail should be visible Signed-off-by: Liz Rea I like the 2nd approach better. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 02:45:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 00:45:53 +0000 Subject: [Koha-bugs] [Bug 20971] additem Corrupted storable string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Needs Signoff |Failed QA --- Comment #5 from Liz Rea --- Hi, We can't test this without a plan, please provide one. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 02:47:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 00:47:59 +0000 Subject: [Koha-bugs] [Bug 21530] overdue_notices.pl aborting because error is not caught In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21530 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #3 from Liz Rea --- Hi Colin, I'm wondering if this situation will have been helped by the fix for bug 22679 - thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 02:50:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 00:50:07 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |wizzyrea at gmail.com --- Comment #214 from Liz Rea --- Hi, Failed QA until you respond to the questions in comment 213. Thanks! Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 02:52:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 00:52:12 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|david.bourgault at inlibro.com | |, | |francois.charbonnier at inlibr | |o.com, | |mehdi.hamidi at inlibro.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 03:26:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 01:26:55 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 --- Comment #59 from David Cook --- (In reply to Martin Renvoize from comment #57) > 1) The 'die' on fork failure isn't cleaning up after itself.. imagine a case > where we want to sporn 5 subprocesses, it we get to process 4 and then run > out of memory for example. The parent script will die and leave behind > zombie child processes. I don't think that this is an actual problem. I think that this happens all the time. The parent dies, the init process (ie 1) becomes the new parent, and it reaps the children when they complete. I don't even think they actually do become zombie child processes in this process. This is also the same process used to daemonize a process. Where you run into a problem with zombie child processes is when the parent lives, the child exits, and the parent doesn't reap the child, which means that you have zombie child processes filling up your process table. That's a real problem. > 2) It doesn't look like there's any form of signal handling here and as such > a CTRL+C for example could end up leaving zombie processes too. > You don't need any signal handling. If you do a CTRL+C on the parent process, it'll cascade down through the child processes, because they'll share the same process group ID. So a CTRL+C won't leave zombie child processes. Even if the CTRL+C just killed the parent and not the children (e.g. the children had set their own process group ID after forking), then they'd just be inherited by init and cleaned up anyway. > I'm also wrapping my head around the use of wait vs waitpid here.. I > remember tripping myself up using them before, but can't remember the > details well enough right now to be confident I've not missed something. > I think wait() and waitpid(-1) are roughly equivalent? They could probably be more rigorous in checking that the PID returned by wait() actually matches the child PIDs, but not the end of the world. Even if the parent forgot to wait and exited early, the child processes would be cleaned up once they completed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 03:35:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 01:35:21 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 --- Comment #60 from David Cook --- (In reply to Martin Renvoize from comment #57) > Finally, I'll be looking into the possibility of race conditions being > introduced with this. We had to introduce lock files for the zebra indexer > as overlapping runs of the script could cause problems, especially with the > query that got the list of bib/auths to index during each run. I'm vaguely > feeling that might also be a problem here, but I'm not entirely sure yet as > I'm still looking at how the iterator is being built. > I am also concerned about there not being a lock file. I suppose I'm less concerned about race conditions so much as accidentally running multiple indexing runs before the first has even completed. I was thinking about the scenario you mentioned where the parent process dies and there's multiple child processes. I would be concerned that the lock would be lost when the parent dies, although https://perldoc.perl.org/functions/flock.html says that locks are inherited across fork calls. In hindsight, I was thinking about the fork and exec (http://www.wumpus-cave.net/2014/04/21/underappreciated-perl-passing-file-descriptors/), but that shouldn't be an issue here. So yeah... I think adding a lock file would be trivial but very worthwhile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 03:51:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 01:51:05 +0000 Subject: [Koha-bugs] [Bug 22805] When borrowers.dateofbirth is set to a date matching '0YYY-MM-DD', memberentry.pl crashes on save. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22805 --- Comment #2 from Barton Chittenden --- (In reply to Jonathan Druart from comment #1) > Do you have a specific use case? :) > > Koha::DateUtils considers that years are formed by 4 digits, 986 is not > correctly parsed. Jonathan, If you enter the date date of birth as '02/26/0986' *in memberentry.pl* it gets saved as '0986-02-26' in the database. Somewhere in the process of loading that into Koha::DateUtils, the leading 0 is lost, which causes the crash -- '0986' is obviously a typo of '1986', and that's causing the crash. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:02:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:02:48 +0000 Subject: [Koha-bugs] [Bug 22807] New: Koha should use Skip to Main Content link for accessibility purposes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Bug ID: 22807 Summary: Koha should use Skip to Main Content link for accessibility purposes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: hayleymapley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Target Milestone: --- For keyboard only users, having a Skip to Main Content link at the beginning of the page that is visible only when on focus is useful for having to press tab or down a bunch of times to bypass the navigation bar and access the main content of the page. It would be good for Koha to have this functionality. Link describing what is meant in more detail: https://accessibility.oit.ncsu.edu/it-accessibility-at-nc-state/developers/accessibility-handbook/mouse-and-keyboard-events/skip-to-main-content/ For an example of this kind of link in action (use tab once page has loaded): https://webaim.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:39:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:39:39 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:39:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:39:44 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88961|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:39:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:39:48 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88962|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:39:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:39:53 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88963|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:39:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:39:57 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88964|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:40:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:40:00 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88965|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:40:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:40:04 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:40:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:40:11 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:40:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:40:07 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:40:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:40:15 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88958|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:40:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:40:18 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88959|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:44:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:44:25 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #60 from Agust?n Moyano --- Created attachment 89060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89060&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) run perl installer/data/mysql/updatedatabase.pl SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:44:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:44:30 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #61 from Agust?n Moyano --- Created attachment 89061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89061&action=edit Bug 22284: (follow-up) Add schema modifications Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:44:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:44:35 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #62 from Agust?n Moyano --- Created attachment 89062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89062&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:44:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:44:42 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #63 from Agust?n Moyano --- Created attachment 89063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89063&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:44:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:44:48 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #64 from Agust?n Moyano --- Created attachment 89064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89064&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:44:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:44:57 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #65 from Agust?n Moyano --- Created attachment 89065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89065&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:45:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:45:04 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #66 from Agust?n Moyano --- Created attachment 89066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89066&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:45:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:45:10 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #67 from Agust?n Moyano --- Created attachment 89067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89067&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:45:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:45:16 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #68 from Agust?n Moyano --- Created attachment 89068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89068&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:45:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:45:24 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #69 from Agust?n Moyano --- Created attachment 89069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89069&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:45:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:45:31 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #70 from Agust?n Moyano --- Created attachment 89070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89070&action=edit Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 04:45:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 02:45:39 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #71 from Agust?n Moyano --- Created attachment 89071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89071&action=edit Bug 22284: (follow-up) fixes after 15496 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 05:33:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 03:33:33 +0000 Subject: [Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 --- Comment #4 from Hayley Mapley --- (In reply to Jonathan Druart from comment #3) > Hi Hayley, > > It will work, but I am wondering if something like that would not be more > readable: > > my $borr = sprintf( "%s%s%s (%s)", > $data->{surname} || '', > $data->{firstname} && $data->{surname} ? ', ' : '', > $data->{firstname} || '', > $borrowernumber ); > > What do you think? Hi Jonathan, I'm happy to implement your solution, however it looks like maybe this error is not present on master anymore. Would you mind confirming this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 05:34:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 03:34:07 +0000 Subject: [Koha-bugs] [Bug 22804] OPAC Overdrive JavaScript contains untranslatable strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 06:38:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 04:38:11 +0000 Subject: [Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #1 from Hayley Mapley --- Hi Lucas, You are listed as the assignee but the bug status is not Assigned. Do you need someone else to take this or did you just forget to change the status? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:05:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:05:12 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89061|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:07:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:07:16 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #72 from Agust?n Moyano --- Created attachment 89072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89072&action=edit Bug 22284: (follow-up) fixes after 18936 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:07:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:07:58 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18936, 18930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 [Bug 18930] Move lost item refund rules to circulation_rules table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:07:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:07:58 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:07:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:07:58 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:11:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:11:19 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89060|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:11:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:11:25 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:11:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:11:28 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89063|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:11:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:11:36 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:11:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:11:40 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:11:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:11:44 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89066|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:11:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:11:50 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89067|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:11:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:11:57 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89068|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:12:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:12:03 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89069|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:12:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:12:08 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89070|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:12:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:12:12 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89071|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:12:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:12:16 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89072|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:13:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:13:37 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #74 from Agust?n Moyano --- Created attachment 89074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89074&action=edit Bug 22284: (follow-up) Add schema modifications Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:13:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:13:43 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #75 from Agust?n Moyano --- Created attachment 89075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89075&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:13:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:13:49 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #76 from Agust?n Moyano --- Created attachment 89076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89076&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:13:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:13:30 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #73 from Agust?n Moyano --- Created attachment 89073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89073&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:13:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:13:56 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #77 from Agust?n Moyano --- Created attachment 89077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89077&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:14:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:14:04 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #78 from Agust?n Moyano --- Created attachment 89078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89078&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:14:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:14:17 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #79 from Agust?n Moyano --- Created attachment 89079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89079&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:14:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:14:23 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #80 from Agust?n Moyano --- Created attachment 89080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89080&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:14:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:14:33 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #81 from Agust?n Moyano --- Created attachment 89081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89081&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:14:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:14:38 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #82 from Agust?n Moyano --- Created attachment 89082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89082&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:14:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:14:42 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #83 from Agust?n Moyano --- Created attachment 89083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89083&action=edit Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:14:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:14:47 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #84 from Agust?n Moyano --- Created attachment 89084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89084&action=edit Bug 22284: (follow-up) fixes after 15496 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:14:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:14:52 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #85 from Agust?n Moyano --- Created attachment 89085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89085&action=edit Bug 22284: (follow-up) fixes after 18936 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:35:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:35:09 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:44:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:44:24 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #75 from Katrin Fischer --- I guess I was too sleepy last night - the date field shows up once you actually click on a hold to renew. I think it might be debatable to show it with clicking the checkbox, but really no reason at all to fail this :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:45:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:45:27 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:45:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:45:37 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89045|0 |1 is obsolete| | --- Comment #77 from Katrin Fischer --- Created attachment 89087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89087&action=edit Bug 7088: Allow renew on hold items with due date This patch adds the ability for items that are on hold to be renewed with a due date specfied by the user. It is enabled by the new "AllowRenewalOnHoldOverride" syspref. It is manifested in two locations: 1. In the "Checkouts" table on the Patron Details screen. It is now possible to select on loan items that would otherwise fulfil a hold request to be renewed. When such an item is selected, an additional date selection box is displayed to allow the user to specify the due date for all on hold items that are to be renewed. 2. In the Circulation > Renew alert screen. When a barcode of an on loan item that would ordinarily fulfil a hold request is entered, the usual alert is displayed indicating that the item is on hold, it is still possible to override this, and renew, however it is now also possible to specify a due date. Test plan: - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it is NOT possible to select this item - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it IS possible to select this item - Select the item - TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item - TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" - TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" - TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" - TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" - TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit - TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" - TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:45:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:45:42 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89046|0 |1 is obsolete| | --- Comment #78 from Katrin Fischer --- Created attachment 89088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89088&action=edit Bug 7088: (follow-up) Fix renewal limit bug There was a bug in that altering the state of the "Override renewal limit" checkbox was altering the appearance of the per-item "On hold" checkbox. This is incorrect, the "Override renewal limit" checkbox is unconnected with this bug. Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:45:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:45:46 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89047|0 |1 is obsolete| | --- Comment #79 from Katrin Fischer --- Created attachment 89089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89089&action=edit Bug 7088: (follow-up) Remove script "type" attribute As per item 1 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:45:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:45:51 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89048|0 |1 is obsolete| | --- Comment #80 from Katrin Fischer --- Created attachment 89090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89090&action=edit Bug 7088: (follow-up) Set syspref default to off As per item 2 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:45:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:45:56 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89049|0 |1 is obsolete| | --- Comment #81 from Katrin Fischer --- Created attachment 89091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89091&action=edit Bug 7088: (follow-up) Default hold checkbox display As per item 4 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Now, the checkbox for renewing on hold items behaves the same way as the checkbox for renewing items that have reached their renew limit. It is necessary to check the re-labelled "Override renewal restrictions" checkbox before it is possible to select on-hold items for renewal. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:45:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:45:32 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89044|0 |1 is obsolete| | --- Comment #76 from Katrin Fischer --- Created attachment 89086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89086&action=edit Bug 7088: Add AllowRenewalOnHoldOverride syspref Enables the renewal of on hold items with specified due dates to be turned on/off Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:46:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:46:00 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89050|0 |1 is obsolete| | --- Comment #82 from Katrin Fischer --- Created attachment 89092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89092&action=edit Bug 7088: (follow-up) Add pref to checkbox As per commit #29 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c29 Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:46:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:46:05 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89051|0 |1 is obsolete| | --- Comment #83 from Katrin Fischer --- Created attachment 89093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89093&action=edit Bug 7088: (follow-up) AllowRenewalLimitOverride fix This patch causes the click event listener on the #override_limit to be created if EITHER the AllowRenewalOnHoldOverride OR AllowRenewalLimitOverride sysprefs are enabled. Previously, it would only be created if the AllowRenewalLimitOverride syspref was enabled, which would cause the checkbox to be displayed but do nothing. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:46:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:46:10 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89052|0 |1 is obsolete| | --- Comment #84 from Katrin Fischer --- Created attachment 89094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89094&action=edit Bug 7088: (follow-up) Modify checkbox enabling As described in comment #50, we need to only enable renewal on items that are disabled in line with which sysprefs are enabled. So we now only enable renewal of on hold items if the AllowRenewalOnHoldOverride syspref is on and we only enable renewal of all other limited items when the AllowRenewalLimitOverride syspref is on. NOTE: The test plan below has changed substantially from previous iterations Test plan (you might want to make a coffee first...): - Apply patch - Rebuild CSS - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - The patron also needs to have an item on loan that cannot be renewed for some other reason, say renewal limit has been reached => TEST: Observe that it is NOT possible to select either item for renewal - Enable the "AllowRenewalLimitOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, but not the item that is on hold - Disable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it is NOT possible to select the the item that has reached the renewal limit, but it IS possible to select the item on hold - Enable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, AND it IS possible to select the item on hold - Select the item that is on hold => TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item => TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" => TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" => TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" => TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" => TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit => TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" => TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:56:55 +0000 Subject: [Koha-bugs] [Bug 22652] Editing Course reserves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00, 18.11.05 |19.05.00, 18.11.05, released in| |18.05.12, 17.11.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:56:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:56:30 +0000 Subject: [Koha-bugs] [Bug 22652] Editing Course reserves is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 07:58:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 05:58:33 +0000 Subject: [Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #28 from Katrin Fischer --- (In reply to Jonathan Druart from comment #27) > Comment on attachment 88629 [details] [review] > Bug 22761: Add ability to use print version of ACCOUNT_CREDIT slip > > Review of attachment 88629 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt > @@ +19,5 @@ > > > >
    > > + > > +[% IF letter %] > > + [% letter.content | evaltt %] > > evaltt? I've found this: http://www.template-toolkit.org/docs/manual/Filters.html#section_eval_evaltt I assume that letter.content contains TT markup in that case? > ::: members/printfeercpt.pl > @@ +83,2 @@ > > > > $template->param( > > There are more parameters than before, I would expect less. > Is that correct? Should we move this to failed QA to get a quick answer from Kyle or can we continue here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 08:01:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 06:01:18 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #170 from Katrin Fischer --- I am back on this, but sadly it doesn't apply :( Please fix, I would have time tomorrow for testing. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11529: Add new fields to biblio table Applying: Bug 11529: Use new biblio fields whenever possible .git/rebase-apply/patch:390: trailing whitespace. count(DISTINCT reserves.borrowernumber) as reservecount, error: sha1 information is lacking or useless (C4/Biblio.pm). error: could not build fake ancestor Patch failed at 0001 Bug 11529: Use new biblio fields whenever possible The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11529-Use-new-biblio-fields-whenever-possible-TtxGN1.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 08:02:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 06:02:30 +0000 Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00, 18.11.05 |19.05.00, 18.11.05, released in| |18.05.12 CC| |fridolin.somers at biblibre.co | |m --- Comment #64 from Fridolin SOMERS --- Does not apply on 17.11.x. But since its nearly end of life we may let it like that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 08:03:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 06:03:49 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 08:06:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 06:06:03 +0000 Subject: [Koha-bugs] [Bug 19497] Translatability: Get rid of "Edit [% field.name |html %] field" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19497 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 08:10:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 06:10:03 +0000 Subject: [Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #10 from Fridolin SOMERS --- Looks like its not needed for 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 08:47:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 06:47:55 +0000 Subject: [Koha-bugs] [Bug 22738] Software Error after LDAP Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 morsch at iza.org changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 08:53:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 06:53:21 +0000 Subject: [Koha-bugs] [Bug 4833] Show acquisition information when ordering from suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 08:53:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 06:53:25 +0000 Subject: [Koha-bugs] [Bug 4833] Show acquisition information when ordering from suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88272|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 89095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89095&action=edit Bug 4833: Show acq information when selecting suggestion for order When adding an order line to a basket using the 'from a suggestion' feature, the list of accepted suggestions doesn't show any information from the acquisition are of the suggestions. This patch adds new columns to the list for: - library - fund - price - quantity - total To test: - Create several suggestions with - Empty acq values - A specific library, any library - Set acq values (fund, price, quantity) - Accept your suggestions - Create a new basket/order - Add an order line from accepted suggestions - Verify the list displays nicely with the new columns - Verify filters etc. still work ok Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:06:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:06:21 +0000 Subject: [Koha-bugs] [Bug 10945] Make Z39.50 work for queries that contain "Norwegian vowels" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10945 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Magnus Enger --- Norwegian vowels work against the new BIBSYS endpoint, so I am closing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:46:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:46:28 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88851|0 |1 is obsolete| | --- Comment #171 from Ere Maijala --- Created attachment 89096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89096&action=edit Bug 11529: Add new fields to biblio table Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:46:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:46:34 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88852|0 |1 is obsolete| | --- Comment #172 from Ere Maijala --- Created attachment 89097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89097&action=edit Bug 11529: Use new biblio fields whenever possible Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:46:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:46:39 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88853|0 |1 is obsolete| | --- Comment #173 from Ere Maijala --- Created attachment 89098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89098&action=edit Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:46:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:46:45 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88854|0 |1 is obsolete| | --- Comment #174 from Ere Maijala --- Created attachment 89099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89099&action=edit Bug 11529: Clean up subtitle usage Unify and clean up subtitle usage so that it's always used as a simple array and not the old hash structure. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:46:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:46:50 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88855|0 |1 is obsolete| | --- Comment #175 from Ere Maijala --- Created attachment 89100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89100&action=edit Bug 11529: Remove field mapping table and admin page Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:46:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:46:55 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88856|0 |1 is obsolete| | --- Comment #176 from Ere Maijala --- Created attachment 89101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89101&action=edit Bug 11529: DBIx schema changes Updates to Biblio schema and removal of FieldMapping schema. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:47:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:47:01 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88857|0 |1 is obsolete| | --- Comment #177 from Ere Maijala --- Created attachment 89102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89102&action=edit Bug 11529: Update kohafield in default framework only if not already set. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:47:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:47:06 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88858|0 |1 is obsolete| | --- Comment #178 from Ere Maijala --- Created attachment 89103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89103&action=edit Bug 11529: Replace bibliosubtitle with biblio in all framework sql's. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:47:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:47:12 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88859|0 |1 is obsolete| | --- Comment #179 from Ere Maijala --- Created attachment 89104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89104&action=edit Bug 11529: Remove duplicate column name from select query Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:47:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:47:17 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88860|0 |1 is obsolete| | --- Comment #180 from Ere Maijala --- Created attachment 89105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89105&action=edit Bug 11529: (follow-up) Remove manage_keywords2koha_mappings permission. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:47:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:47:23 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88861|0 |1 is obsolete| | --- Comment #181 from Ere Maijala --- Created attachment 89106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89106&action=edit Bug 11529: Add templates for biblio title display. Unify display. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:47:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:47:28 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88862|0 |1 is obsolete| | --- Comment #182 from Ere Maijala --- Created attachment 89107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89107&action=edit Bug 11529: (follow-up) Fix link on hold request page Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:48:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:48:02 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #183 from Ere Maijala --- Rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:48:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:48:51 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 --- Comment #16 from Ere Maijala --- Katrin, thanks for fixing my mess. The patch applies fine for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:48:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:48:32 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 09:50:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 07:50:59 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 --- Comment #61 from Ere Maijala --- With Elasticsearch the only race condition I can think of would be running indexing with -d while another indexing run is going. Otherwise it's just waste of resources. That said, adding a lock file makes sense. I'll do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 10:04:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 08:04:30 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #62 from Ere Maijala --- On a second thought, I'd leave lock file out. Unlike rebuild_zebra, there's normally only need to run rebuild_elasticsearch manually. If you need to e.g. cron it for some reason, an external locking mechanism can be used. Also, you may want to rebuild authorities and biblios side by side, and lock file would just complicate that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 10:07:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 08:07:37 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 --- Comment #63 from Ere Maijala --- ...and if you really feel that lock file should be added, let's make that a separate bug. It's not as simple as I first thought at least if you use the same mechanism as rebuild_zebra.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 10:49:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 08:49:35 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #184 from Katrin Fischer --- Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 10:51:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 08:51:54 +0000 Subject: [Koha-bugs] [Bug 22808] New: Move Cache.t to db_dependent Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22808 Bug ID: 22808 Summary: Move Cache.t to db_dependent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Cache.t fails during package build. Moving it to db_dependent fixes the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 10:53:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 08:53:21 +0000 Subject: [Koha-bugs] [Bug 22808] Move Cache.t to db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22808 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 10:55:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 08:55:06 +0000 Subject: [Koha-bugs] [Bug 9400] On a multi-arch debian system, parts of the INSTALL.debian fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9400 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #4 from Mirko Tietgen --- We dropped support for Debian Wheezy some time ago and we removed INSTALL.debian. Closing as invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 10:57:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 08:57:20 +0000 Subject: [Koha-bugs] [Bug 22808] Move Cache.t to db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22808 --- Comment #1 from Mirko Tietgen --- Created attachment 89108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89108&action=edit Bug 22808: Move Cache.t to db_dependent Cache.t fails during package build. Moving it to db_dependent fixes the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 10:57:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 08:57:34 +0000 Subject: [Koha-bugs] [Bug 22808] Move Cache.t to db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22808 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 11:02:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 09:02:32 +0000 Subject: [Koha-bugs] [Bug 7497] "kw, wrdl" and variants should be replaced by something more explicit in search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7497 seif changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |seif.nassor17 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 11:05:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 09:05:49 +0000 Subject: [Koha-bugs] [Bug 4833] Show acquisition information when ordering from suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 --- Comment #7 from Katrin Fischer --- Thx for QA! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 11:11:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 09:11:47 +0000 Subject: [Koha-bugs] [Bug 9400] On a multi-arch debian system, parts of the INSTALL.debian fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9400 --- Comment #5 from Katrin Fischer --- (In reply to Mirko Tietgen from comment #4) > We dropped support for Debian Wheezy some time ago and we removed > INSTALL.debian. > Closing as invalid. Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 11:28:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 09:28:06 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #64 from Martin Renvoize --- Hi Ere, Yeah, I've been digging further into this code and I'd entirely forgotten/overlooked that this script really is intended as a human interface and that the regular indexing is actually handled live rather than this script running as a daemon or under cron.. Don't worry about a lock file at all, apologies for my not realising that earlier (seems I still have more to learn about ES than I thought) Given the feedback I've had above I'm now confident that the issues have been thought through and appear to have been handled appropriately. I'm going to go ahead and PQA, thanks for all the efforts everyone and for the responses to queries. Great to see this one going through. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 11:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 09:31:13 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86053|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize --- Created attachment 89109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89109&action=edit Bug 21872: Add multiprocess support to Elasticsearch indexing utility Test plan: 1. Time execution without -p parameter 2. Time execution with -p 2 or -p3 or -p 4 depending on CPU core count Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 11:31:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 09:31:16 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86054|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize --- Created attachment 89110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89110&action=edit Bug 21872: Simplify conditions and exit on invalid combination of arguments Change to zero based indexing for slice index to simplify some conditions. Exit with error message if trying to combine processes and biblio numbers arguments. Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 11:31:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 09:31:20 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86055|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize --- Created attachment 89111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89111&action=edit Bug 21872: Remove duplicate modulo condition in authorities iterator Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 11:31:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 09:31:23 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86056|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize --- Created attachment 89112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89112&action=edit Bug 21872: Add support for -p parameter to koha-elasticsearch Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 11:31:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 09:31:27 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86057|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize --- Created attachment 89113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89113&action=edit Bug 21872: Fix name of rebuild_elasticsearch.pl Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 13:08:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 11:08:33 +0000 Subject: [Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #29 from Kyle M Hall --- (In reply to Katrin Fischer from comment #28) > (In reply to Jonathan Druart from comment #27) > > Comment on attachment 88629 [details] [review] [review] > > Bug 22761: Add ability to use print version of ACCOUNT_CREDIT slip > > > > Review of attachment 88629 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt > > @@ +19,5 @@ > > > > > >
    > > > + > > > +[% IF letter %] > > > + [% letter.content | evaltt %] > > > > evaltt? > > I've found this: > http://www.template-toolkit.org/docs/manual/Filters.html#section_eval_evaltt > > I assume that letter.content contains TT markup in that case? > > > > ::: members/printfeercpt.pl > > @@ +83,2 @@ > > > > > > $template->param( > > > > There are more parameters than before, I would expect less. > > Is that correct? > > Should we move this to failed QA to get a quick answer from Kyle or can we > continue here? There are more parameters because I made the slip compatible with the existing syntax for the ACCOUNT_PAYMENT/ACCOUNT_WRITEOFF slips. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 13:36:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 11:36:48 +0000 Subject: [Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com Component|Cataloging |Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 13:37:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 11:37:53 +0000 Subject: [Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #30 from Kyle M Hall --- > I've found this: > http://www.template-toolkit.org/docs/manual/Filters.html#section_eval_evaltt > > I assume that letter.content contains TT markup in that case? You are correct! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 13:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 11:40:57 +0000 Subject: [Koha-bugs] [Bug 22809] New: Move "INVOICE" from template to a slip Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 Bug ID: 22809 Summary: Move "INVOICE" from template to a slip Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Just as bug 22761 moves the "Fee receipt" to the ACCOUNT_CREDIT slip, we need to move the "INVOICE" to an ACCOUNT_DEBIT slip. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 13:41:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 11:41:02 +0000 Subject: [Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 13:54:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 11:54:28 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #70 from Nick Clemens --- Created attachment 89114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89114&action=edit Bug 14407: (RM follow-up) Add dependency for Net::CIDR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 13:55:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 11:55:09 +0000 Subject: [Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22761 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 [Bug 22761] Move "Fee receipt" from template to a slip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 13:55:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 11:55:09 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #71 from Nick Clemens --- Can I just get a thumbs up on adding the dep before pushing, I tried to get the version number in Jessie and use that for the minimum -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 13:55:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 11:55:09 +0000 Subject: [Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 [Bug 22809] Move "INVOICE" from template to a slip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 13:55:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 11:55:15 +0000 Subject: [Koha-bugs] [Bug 22807] Koha should use Skip to Main Content link for accessibility purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:01:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:01:48 +0000 Subject: [Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 --- Comment #1 from Kyle M Hall --- Created attachment 89115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89115&action=edit Bug 22809 - Move "INVOICE" from template to a slip Just as bug 22761 moves the "Fee receipt" to the ACCOUNT_CREDIT slip, we need to move the "INVOICE" to an ACCOUNT_DEBIT slip. Test Plan: 1) Apply this patch set 2) Restart all the things 3) Use the "print" button beside a *fee* 4) You should not see any difference from before the patches were applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:01:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:01:45 +0000 Subject: [Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:11:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:11:05 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |nick at bywatersolutions.com --- Comment #44 from Nick Clemens --- Needs a minor rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:11:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:11:43 +0000 Subject: [Koha-bugs] [Bug 22786] Can create new funds for locked budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786 --- Comment #2 from Owen Leonard --- (In reply to Jonathan Druart from comment #1) > Owen, do you agree? Yes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:13:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:13:31 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88848|0 |1 is obsolete| | Attachment #88848|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:13:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:13:35 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88847|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:14:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:14:07 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88848|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:16:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:16:37 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88848|0 |1 is patch| | Attachment #88848|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:16:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:16:07 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88847|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:20:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:20:34 +0000 Subject: [Koha-bugs] [Bug 21128] Replace JavaScript-driven authority hierarchy display with static version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21128 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX --- Comment #7 from Owen Leonard --- I'm going to close this, because my proposal doesn't seem to be robust enough for everyone's needs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:21:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:21:39 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:21:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:21:40 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 21948, which changed state. Bug 21948 Summary: Clean up style of item detail page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:22:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:22:17 +0000 Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:22:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:22:18 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Bug 21336 depends on bug 21998, which changed state. Bug 21998 Summary: Add pattern parameter in Koha::Token https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:22:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:22:33 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:22:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:22:34 +0000 Subject: [Koha-bugs] [Bug 22618] Tests in t/Acquisition.t are actually context dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618 Bug 22618 depends on bug 18736, which changed state. Bug 18736 Summary: Problems in order calculations (rounding errors) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:22:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:22:35 +0000 Subject: [Koha-bugs] [Bug 22791] Calculation differs on aqui-home/spent and ordered.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Bug 22791 depends on bug 18736, which changed state. Bug 18736 Summary: Problems in order calculations (rounding errors) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:27:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:27:56 +0000 Subject: [Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:09 +0000 Subject: [Koha-bugs] [Bug 19661] Add routes for funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:15 +0000 Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:15 +0000 Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 Bug 19774 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:16 +0000 Subject: [Koha-bugs] [Bug 22218] Make endpoints not in /public require privileged credentials [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218 Bug 22218 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:16 +0000 Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Bug 22206 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:20 +0000 Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items stripped in ModBiblioMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:27 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:42 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:43 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 21622, which changed state. Bug 21622 Summary: Incorrect GROUP BY clause in acqui/ scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:49 +0000 Subject: [Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::build_sample_biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:50 +0000 Subject: [Koha-bugs] [Bug 21816] [OMNIBUS] Ease the write of our tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21816 Bug 21816 depends on bug 21798, which changed state. Bug 21798 Summary: We need t::lib::TestBuilder::build_sample_biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:50 +0000 Subject: [Koha-bugs] [Bug 21971] TestBuilder::build_sample_item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Bug 21971 depends on bug 21798, which changed state. Bug 21798 Summary: We need t::lib::TestBuilder::build_sample_biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:54 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:58 +0000 Subject: [Koha-bugs] [Bug 21971] TestBuilder::build_sample_item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:58 +0000 Subject: [Koha-bugs] [Bug 21816] [OMNIBUS] Ease the write of our tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21816 Bug 21816 depends on bug 21971, which changed state. Bug 21971 Summary: TestBuilder::build_sample_item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:58 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Bug 21985 depends on bug 21971, which changed state. Bug 21971 Summary: TestBuilder::build_sample_item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:28:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:28:59 +0000 Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Bug 22140 depends on bug 21971, which changed state. Bug 21971 Summary: TestBuilder::build_sample_item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:29:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:29:02 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:29:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:29:00 +0000 Subject: [Koha-bugs] [Bug 22392] TestBuilder::build_sample_item should allow defining barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22392 Bug 22392 depends on bug 21971, which changed state. Bug 21971 Summary: TestBuilder::build_sample_item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:29:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:29:07 +0000 Subject: [Koha-bugs] [Bug 22069] Log viewer not displaying item renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:29:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:29:12 +0000 Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:29:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:29:17 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:31:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:31:37 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:31:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:31:38 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 Bug 20390 depends on bug 19575, which changed state. Bug 19575 Summary: Use canonical field names and resolve aliased fields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:31:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:31:39 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Bug 22495 depends on bug 19575, which changed state. Bug 19575 Summary: Use canonical field names and resolve aliased fields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:31:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:31:39 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Bug 22524 depends on bug 19575, which changed state. Bug 19575 Summary: Use canonical field names and resolve aliased fields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:43:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:43:53 +0000 Subject: [Koha-bugs] [Bug 22791] Calculation differs on aqui-home/spent and ordered.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:46:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:46:46 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #61 from Martin Renvoize --- Are we still hoping to move this along for 19.05? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:47:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:47:38 +0000 Subject: [Koha-bugs] [Bug 22263] Command line script to populate or update items.cn_sort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22263 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 14:51:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 12:51:20 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #62 from Alex Arnaud --- (In reply to Martin Renvoize from comment #61) > Are we still hoping to move this along for 19.05? We (Biblibre) will send some fixes very soon. Work in progress... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:00:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:00:22 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |The ability to release notes| |enable/disable plugins is | |added. This is particularly | |handy when testing new | |plugins or when plugins are | |not (yet) fully configured | |for production use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:13:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:13:04 +0000 Subject: [Koha-bugs] [Bug 22810] New: Item batch mod fails when itype description contains a comma Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22810 Bug ID: 22810 Summary: Item batch mod fails when itype description contains a comma Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- Confirmed this behavior in 18.05 and 18.11. To test: - Create an itype with a comma in its description - Create items without an itype - Put those items into item batch modification - Attempt to set items to your new itype - Koha will return "No items were modified" and the itype will remain null This only occurs when items have a null itype. Batch mod can correctly set an item to an itype with a comma in the description if that item is starting from a non-null itype. This only occurs in batch modification. Item creation and single item edits work correctly with itypes with a comma in the description. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:40:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:40:12 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |nick at bywatersolutions.com --- Comment #28 from Nick Clemens --- The updatedatabase fails for installations without plugins enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:41:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:41:53 +0000 Subject: [Koha-bugs] [Bug 21364] Allow closing basket from vendor search/view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:42:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:42:05 +0000 Subject: [Koha-bugs] [Bug 22010] RecordedBooks and OverDrive should check preferences over passing variables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:42:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:42:16 +0000 Subject: [Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #13 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:43:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:43:30 +0000 Subject: [Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 --- Comment #14 from Nick Clemens --- (In reply to Jonathan Druart from comment #9) > Or we could have 1 query to fetch the reports, then 1 query per report to > fetch the results (O(n), bad) I think this is not such a bad idea, but we would move the listing of saved reports to the specific report page (instead of listing them for all the reports on the main page) If you are saving a report regularly it will be taking a lot of screen eventually -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:43:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:43:47 +0000 Subject: [Koha-bugs] [Bug 22408] Subscription entry form cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:43:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:43:58 +0000 Subject: [Koha-bugs] [Bug 22424] Add search by all lost statuses to item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:44:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:44:11 +0000 Subject: [Koha-bugs] [Bug 22717] google oauth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:44:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:44:18 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This feature allows you to release notes| |link documents in your | |catalogue to OpenURL | |resolver and possibly | |enable your patrons to get | |full texts in digital form. Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:47:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:47:50 +0000 Subject: [Koha-bugs] [Bug 22717] Google OAuth auto registration error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22717 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|google oauth auto |Google OAuth auto |registration error |registration error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:48:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:48:16 +0000 Subject: [Koha-bugs] [Bug 22791] Calculation differs on aqui-home/spent and ordered.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 --- Comment #2 from Marcel de Rooy --- Thought we resolved these numbers :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:52:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:52:07 +0000 Subject: [Koha-bugs] [Bug 22791] Calculation differs on aqui-home/spent and ordered.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 --- Comment #3 from Nick Clemens --- (In reply to Marcel de Rooy from comment #2) > Thought we resolved these numbers :) Baby steps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:56:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:56:03 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 15:56:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 13:56:08 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #29 from Tom?s Cohen Arazi --- Created attachment 89116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89116&action=edit Bug 22053: (QA follow-up) Override enable_plugins configuration This patch makes the update script override the configured enable_plugins setting in koha-conf.xml. on testing the failure I wrote trivial tests on how Koha::Plugins->new({ enable_plugins => 1 }) should work. Adding them to this patch as well. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:19:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:19:01 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #63 from axel Amghar --- Created attachment 89117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89117&action=edit Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:19:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:19:50 +0000 Subject: [Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:20:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:20:38 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 axel Amghar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89117|0 |1 is obsolete| | --- Comment #64 from axel Amghar --- Created attachment 89118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89118&action=edit Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:20:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:20:55 +0000 Subject: [Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #2 from Lucas Gass --- Thanks Hayley, I'll take it, I forgot to change the status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:22:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:22:53 +0000 Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:22:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:22:56 +0000 Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #21 from Liz Rea --- Created attachment 89119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89119&action=edit Bug 21411: (QA follow-up) fix tests This patch removes erroneous shortcut_desc from the tests, which was left in accidentally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:37:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:37:33 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89073|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:37:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:37:37 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89074|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:37:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:37:45 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89075|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:37:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:37:51 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89076|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:37:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:37:56 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:38:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:38:01 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:38:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:38:06 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89079|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:38:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:38:13 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:38:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:38:19 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:38:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:38:24 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89082|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:38:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:38:28 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:38:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:38:33 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:38:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:38:38 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agust?n Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89085|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:38:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:38:44 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #141 from Tom?s Cohen Arazi --- Created attachment 89120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89120&action=edit Bug 8995: (QA follow-up) Mock required sysprefs in the tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:43:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:43:02 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 axel Amghar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axel.amghar at biblibre.com Attachment #89118|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:49:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:49:19 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Needs Signoff |Failed QA --- Comment #36 from Liz Rea --- Hi, There is something odd here - the Defaults row seems to always say (not set) even if the rules are propagated? Deleting the All-All rule from the main table seems to clear the default checkout, hold, and return policy values? Is that expected? You can re-set the checkout hold and return policy rules without having an All-All rule, but deleting it seems to delete both? Probably not going to go on testing the actual function until I get an answer on these things, sorry. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:52:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:52:03 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #65 from axel Amghar --- Created attachment 89121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89121&action=edit Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:53:57 +0000 Subject: [Koha-bugs] [Bug 8619] Remove hidelostitems syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8619 --- Comment #4 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #3) > I am not sure how hidelostitems is realized, but there are several > disadvantages to using OpacHiddenItems that keep some libraries from using > it (we also have a lot that do): > > 1) It works outside of Zebra, so there are holes in the search results and > you can end up with almost empty pages if you hide a lot of things > 2) Because of the holes, we have removed the numbering from the search > results when OpacHiddenItems is used, to make it less obvious > 3) It will need updating, as Owen points out Good point, Katrina. I'd say any move towards removing the syspref, should keep this behavior you describe from hidelostitems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:54:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:54:02 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 axel Amghar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:58:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:58:50 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #86 from Agust?n Moyano --- Created attachment 89122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89122&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:58:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:58:56 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #87 from Agust?n Moyano --- Created attachment 89123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89123&action=edit Bug 22284: (follow-up) Add schema modifications Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:59:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:59:02 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #88 from Agust?n Moyano --- Created attachment 89124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89124&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:59:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:59:07 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #89 from Agust?n Moyano --- Created attachment 89125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89125&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:59:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:59:13 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #90 from Agust?n Moyano --- Created attachment 89126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89126&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:59:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:59:27 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #92 from Agust?n Moyano --- Created attachment 89128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89128&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:59:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:59:33 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #93 from Agust?n Moyano --- Created attachment 89129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89129&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:59:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:59:39 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #94 from Agust?n Moyano --- Created attachment 89130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89130&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:59:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:59:45 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #95 from Agust?n Moyano --- Created attachment 89131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89131&action=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:59:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:59:20 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #91 from Agust?n Moyano --- Created attachment 89127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89127&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:59:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:59:51 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #96 from Agust?n Moyano --- Created attachment 89132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89132&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 16:59:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 14:59:57 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #97 from Agust?n Moyano --- Created attachment 89133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89133&action=edit Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:00:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:00:04 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #98 from Agust?n Moyano --- Created attachment 89134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89134&action=edit Bug 22284: (follow-up) fixes after 15496 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:00:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:00:05 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:00:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:00:06 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Bug 22284 depends on bug 15496, which changed state. Bug 15496 Summary: Delete bibliographic record after moving last item to another record(s) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:00:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:00:11 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #99 from Agust?n Moyano --- Created attachment 89135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89135&action=edit Bug 22284: (follow-up) fixes after 18936 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:07:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:07:20 +0000 Subject: [Koha-bugs] [Bug 22811] New: Add button to clear DataTables filtering Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Bug ID: 22811 Summary: Add button to clear DataTables filtering Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Created attachment 89136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89136&action=edit Screen grab showing clear button interaction I propose that we add a "Clear filter" button to the global DataTables configuration which will be displayed if the table has a search form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:17:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:17:43 +0000 Subject: [Koha-bugs] [Bug 22812] New: Cannot add new subscription Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Bug ID: 22812 Summary: Cannot add new subscription Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- I can't seem to add a new subscription without filling in every. single. box. As an example, I created a subscription with no vendor, a biblio, no special anything, and I got an error Can't call method "set_additional_fields" on an undefined value at /kohadevbox/koha/serials/subscription-add.pl line 401 there are also sql errors when you don't fill in various boxes: Incorrect integer value: '' for column 'aqbooksellerid' at row 1 if you don't give a vendor Incorrect integer value: '' for column 'innerloop1' at row 1 if you don't use a prediction pattern that fills all boxes x y z My version of sql is 5.5.62 and this was in a docker test setup. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:22:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:22:04 +0000 Subject: [Koha-bugs] [Bug 22813] New: searchResults queries the Koha::Patron object inside two nested loops Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Bug ID: 22813 Summary: searchResults queries the Koha::Patron object inside two nested loops Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- I haven't benchmarked this, but it seems really bad and easy to fix. To verify: Go to C4::Search:2119, notice the IF includes a query for a Koha::Patron object, and then for its related Koha::Patron::Category object. This is done for each item, on each record in the resultset WTF -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:22:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:22:10 +0000 Subject: [Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:29:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:29:35 +0000 Subject: [Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |josef.moravec at gmail.com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:36:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:36:11 +0000 Subject: [Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 89137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89137&action=edit Bug 22813: remove repetitive queries inside two nested loops in searchResults This patch moves a query on Koha::Patrons and then the related Koha::Patron::Category that needlessly happens inside two nested loops (all items of all MARC records in the resultset). The Koha::Patron and Koha::Patron::Category are always the same as it is fetched from C4::Context->userenv each time. To test: - Run: $ kshell k$ prove t/db_dependent/Search.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/db_dependent/Search.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:36:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:36:08 +0000 Subject: [Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:38:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:38:39 +0000 Subject: [Koha-bugs] [Bug 22811] Add button to clear DataTables filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 --- Comment #1 from Owen Leonard --- Created attachment 89138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89138&action=edit Bug 22811: Add button to clear DataTables filtering This patch adds a "clear filter" button to the global DataTables configuration. The button will appear if: - There is no custom DOM configuration applied to the DataTable instance. - The DataTable has the search form enabled. The new button should be disabled by default. Entering a search term in the form should enable it. To test, apply the patch and clear your browser cache if necessary. View various pages with various DataTables configurations and confirm that everything looks correct and the new "Clear filter" button doesn't appear when there is no DataTable search field. For example: - Administration -> Libraries - Administration -> Currencies - Reports -> Saved reports - Circulation -> Check out - Tools -> News -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:38:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:38:37 +0000 Subject: [Koha-bugs] [Bug 22811] Add button to clear DataTables filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:43:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:43:19 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #272 from Mirko Tietgen --- I applied the patches, created a request, tested it ok, submitted and then ? nothing happens. "OAI-PMH harvester offline" Is there something else I have to do? I can't choose "Record type: Authorities", is that intentional? I manually installed libpoe-perl and libpoe-component-jobqueue-perl. Are there other dependencies I mossed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:51:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:51:46 +0000 Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Devinim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83615|0 |1 is obsolete| | Attachment #83616|0 |1 is obsolete| | Attachment #83617|0 |1 is obsolete| | Attachment #84463|0 |1 is obsolete| | Attachment #84812|0 |1 is obsolete| | --- Comment #20 from Devinim --- Created attachment 89139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89139&action=edit Bug 5770: Email librarian when purchase suggestion made -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:54:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:54:44 +0000 Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #21 from Devinim --- Created attachment 89140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89140&action=edit Bug 5770: New system pref for new suggestion email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 17:57:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 15:57:17 +0000 Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #22 from Devinim --- Created attachment 89141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89141&action=edit Bug 5770: Unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 18:18:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 16:18:41 +0000 Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Devinim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 18:18:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 16:18:44 +0000 Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #23 from Devinim --- Created attachment 89142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89142&action=edit Bug 5770: Notify for new suggestion - sample notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 18:26:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 16:26:41 +0000 Subject: [Koha-bugs] [Bug 22814] New: Holds modal patron name display inconsistency Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814 Bug ID: 22814 Summary: Holds modal patron name display inconsistency Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: george at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- Bug 22203 changed the behavior on the hold-found2 modal that pops up when a hold is found so that whether or not the patron's name is displayed is now governed by the HidePatronName system preference. However, if a hold is confirmed and you check the item in a second time, the modal that pops up is hold-found1 and whether or not the patron's name is displayed in the hold-found1 modal is not governed by the HidePatronName system preference. For the sake of consistency, the display of the patron's name on hold-found2 and hold-found1 should both be governed by the HidePatronName system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 18:28:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 16:28:55 +0000 Subject: [Koha-bugs] [Bug 22812] Cannot add new subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |major CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- This is probably to do with strict mode, as KohaDevBox doesn't seem to manifest this behaviour. Off of blocker because most people have already turned off strict mode if they are using mysql, but it's still pretty major because we can't add subscriptions in strict mode and that seems wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 19:01:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 17:01:21 +0000 Subject: [Koha-bugs] [Bug 22811] Add button to clear DataTables filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89138|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 89143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89143&action=edit Bug 22811: Add button to clear DataTables filtering This patch adds a "clear filter" button to the global DataTables configuration. The button will appear if: - There is no custom DOM configuration applied to the DataTable instance. - The DataTable has the search form enabled. The new button should be disabled by default. Entering a search term in the form should enable it. To test, apply the patch and clear your browser cache if necessary. View various pages with various DataTables configurations and confirm that everything looks correct and the new "Clear filter" button doesn't appear when there is no DataTable search field. For example: - Administration -> Libraries - Administration -> Currencies - Reports -> Saved reports - Circulation -> Check out - Tools -> News Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 19:01:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 17:01:18 +0000 Subject: [Koha-bugs] [Bug 22811] Add button to clear DataTables filtering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 19:08:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 17:08:30 +0000 Subject: [Koha-bugs] [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 19:19:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 17:19:56 +0000 Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89139|0 |1 is obsolete| | Attachment #89140|0 |1 is obsolete| | Attachment #89141|0 |1 is obsolete| | Attachment #89142|0 |1 is obsolete| | --- Comment #24 from Liz Rea --- Created attachment 89144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89144&action=edit Bug 5770: Email librarian when purchase suggestion made Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 19:20:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 17:20:06 +0000 Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #25 from Liz Rea --- Created attachment 89145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89145&action=edit Bug 5770: New system pref for new suggestion email Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 19:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 17:20:10 +0000 Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #26 from Liz Rea --- Created attachment 89146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89146&action=edit Bug 5770: Unit test Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 19:20:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 17:20:14 +0000 Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #27 from Liz Rea --- Created attachment 89147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89147&action=edit Bug 5770: Notify for new suggestion - sample notices Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 19:35:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 17:35:37 +0000 Subject: [Koha-bugs] [Bug 22805] When borrowers.dateofbirth is set to a date matching '0YYY-MM-DD', memberentry.pl crashes on save. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22805 --- Comment #3 from Jonathan Druart --- Here it is not saved, the crash appears at Koha::Patron::get_age('Koha::Patron=HASH(0x55dfa6af0400)') called at /home/vagrant/kohaclone/members/memberentry.pl line 338 before the patron is stored (on line 434). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 19:54:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 17:54:54 +0000 Subject: [Koha-bugs] [Bug 22667] Framework cannot override syspref for cn_source when receiving serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22667 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 19:59:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 17:59:45 +0000 Subject: [Koha-bugs] [Bug 22667] Framework cannot override syspref for cn_source when receiving serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22667 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 19:59:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 17:59:47 +0000 Subject: [Koha-bugs] [Bug 22667] Framework cannot override syspref for cn_source when receiving serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22667 --- Comment #2 from Jonathan Druart --- Created attachment 89148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89148&action=edit Bug 22667: Pick default value from framework for cn_source If the cn_source has a default value defined in the framework it will not be used when ordering or receiving serials. Test plan: Set the pref DefaultClassificationSource to Library of congress Define a default value=ddc (for Dewey) for the ACQ and default framework Receive an order (AcqCreateItem=on ordering) and confirm that Dewey is selected by default (the default value from the ACQ framework is used) Receive a serial and confirm that Dewey is selected by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:00:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:00:53 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:00:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:00:56 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86040|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 89149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89149&action=edit Bug 22453: Make TestBuilder generates dates taking into account the timezone I have no idea why this only appears today but TestBuilder generates dates using DateTime->now, which does not take into account the timezone. It has been highlights by a failing test today on U18. Why today whereas this patch was pushed few weeks ago? Why U18 and not D9? The output of the test is: koha_1 | # Failed test 'With BorrowerLogs and TrackLastPatronActivity we should not spam the logs' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1421. koha_1 | # got: '2' koha_1 | # expected: '1' koha_1 | # Looks like you failed 1 test of 4. koha_1 | koha_1 | # Failed test 'BorrowersLog tests' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1422. koha_1 | # Looks like you failed 1 test of 33. koha_1 | [19:51:44] t/db_dependent/Koha/Patrons.t Actually there are 2 logs, one for the cardnumber that is expected, and on for updated_on: "updated_on" : { "after" : "2019-03-04 21:10:00", "before" : "2019-03-04 18:10:00" } Apart from the fact that we may want to remove this updated_on field from MODIFY, the before/after dates differ from 3 hours. Here it's currently 18:10 and in UTC-3 To prevent such behaviors in tests (create stuffs in the future...), we should use our Koha::DateUtils::dt_from_string method that takes care of the timezone used in other places of Koha. Test plan: prove t/db_dependent/Koha/Patrons.t May fail without this patch. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:01:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:01:31 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:02:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:02:50 +0000 Subject: [Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:02:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:02:53 +0000 Subject: [Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89137|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 89150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89150&action=edit Bug 22813: remove repetitive queries inside two nested loops in searchResults This patch moves a query on Koha::Patrons and then the related Koha::Patron::Category that needlessly happens inside two nested loops (all items of all MARC records in the resultset). The Koha::Patron and Koha::Patron::Category are always the same as it is fetched from C4::Context->userenv each time. To test: - Run: $ kshell k$ prove t/db_dependent/Search.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/db_dependent/Search.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:04:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:04:24 +0000 Subject: [Koha-bugs] [Bug 22108] Items generated through MARCItemFieldsToOrder do not receive values applied in Item Information and Default Accounting Details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22108 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |nick at bywatersolutions.com Version|18.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:21:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:21:53 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Needs Signoff |Failed QA --- Comment #66 from Liz Rea --- Hi, I've just tried to test this, and I don't see the row at the bottom to add new mappings on the search tab? Terribly sorry, I'm quite sure I restarted the things and did all of the prerequisites, but as usual not sure if it was something I'm doing wrong or if it's the code. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:29:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:29:02 +0000 Subject: [Koha-bugs] [Bug 22766] Tags cloud link in OPAC does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766 --- Comment #6 from Jonathan Druart --- (In reply to Claudio from comment #5) > Jonathan, bug 22420 solves the problem. I have just tested and all work fine. Please sign it off then :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:29:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:29:16 +0000 Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 --- Comment #8 from Jonathan Druart --- *** Bug 22766 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:29:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:29:16 +0000 Subject: [Koha-bugs] [Bug 22766] Tags cloud link in OPAC does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 22420 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:29:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:29:51 +0000 Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_05_candidate Severity|normal |major --- Comment #9 from Jonathan Druart --- Upping severity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 20:49:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 18:49:37 +0000 Subject: [Koha-bugs] [Bug 22813] searchResults queries the Koha::Patron object inside two nested loops In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22813 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 89151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89151&action=edit Bug 22813: (follow-up) Add missing condition This patch restores a missing condition. $patron gets renamed to make it obvious that it related to the logged in user. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 21:22:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 19:22:35 +0000 Subject: [Koha-bugs] [Bug 21946] Group circulation by item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #29 from Jonathan Druart --- Quick code review: 1. + my $child_types = Koha::ItemTypes->search( parent_type => $type ); search take a hashef! 2. + $parent_maxissueqty_rule = undef if $parent_maxissueqty_rule && $parent_maxissueqty_rule->itemtype eq '*'; Is that possible? IIRC we had NULL in DB to tell "all", not "*" 3. + if (C4::Context->preference('item-level_itypes')) { + $count_query .= q|SELECT COALESCE( SUM( IF(items.itype = '| .$type . q|',1,0) ), 0) as type_total, COUNT(*) AS total, COALESCE(SUM(onsite_checkout), 0) AS onsite_checkouts|; + } else{ + $count_query .= q|SELECT COALESCE(SUM( IF(biblioitems.itype = '| .$type . q|',1,0) ), 0) as type_total, COUNT(*) AS total, COALESCE(SUM(onsite_checkout), 0) AS onsite_checkouts| + } Please do not repeat, the only change is items vs biblioitems, so put it into a var then generate the query. 4. + while ( my $child = $children->next ){ + push @types, $child->itemtype; + } You need $children->get_column 5. -

    Add item type

    + ]

    Add item type

    6. The indentation fix should not be here, it will add unnecessary conflict with patches already in the queue (bug 15522 and deps for instance!). smart-rules.tt particularly 7. I am really not sure the comparisons with '*' in smart-rules.tt are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 21:33:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 19:33:02 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88999|0 |1 is obsolete| | Attachment #89000|0 |1 is obsolete| | --- Comment #17 from Liz Rea --- Created attachment 89152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89152&action=edit Bug 22524: Fix publication date and year search with Elasticsearch Also fixes the mappings.yaml to use correct field name (left over issue from bug 19575), so reset mappings and reindex before testing. Test plan: 1. Reset mappings and reindex biblios. 2. Check that tests in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t pass. 3. Try that all of the following year range type work in publication date search and year limit in advanced search: yyyy yyyy-yyyy -yyyy yyyy- Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 21:33:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 19:33:12 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 --- Comment #18 from Liz Rea --- Created attachment 89153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89153&action=edit Bug 22524: Fix date/time-last-modified search with Elasticsearch Avoid using slash in the field name since it would need to be escaped. Fix conversion of dtlm and any existing mapping. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 21:32:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 19:32:58 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 21:35:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 19:35:50 +0000 Subject: [Koha-bugs] [Bug 22808] Move Cache.t to db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22808 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 21:35:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 19:35:53 +0000 Subject: [Koha-bugs] [Bug 22808] Move Cache.t to db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22808 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89108|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 89154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89154&action=edit Bug 22808: Move Cache.t to db_dependent Cache.t fails during package build. Moving it to db_dependent fixes the problem. Signed-off-by: Liz Rea test passes in the new location, doesn't exist in the old one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 21:43:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 19:43:42 +0000 Subject: [Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89115|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 89155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89155&action=edit Bug 22809: Move "INVOICE" from template to a slip Just as bug 22761 moves the "Fee receipt" to the ACCOUNT_CREDIT slip, we need to move the "INVOICE" to an ACCOUNT_DEBIT slip. Test Plan: 1) Apply this patch set 2) Restart all the things 3) Use the "print" button beside a *fee* 4) You should not see any difference from before the patches were applied Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 21:43:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 19:43:50 +0000 Subject: [Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 --- Comment #3 from Liz Rea --- Created attachment 89156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89156&action=edit Bug 22809: (QA follow-up) add bug description to atomicupdate Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 21:43:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 19:43:39 +0000 Subject: [Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 21:44:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 19:44:19 +0000 Subject: [Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #4 from Liz Rea --- Also fixed your commit message to make the QA tools happy :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 21:58:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 19:58:37 +0000 Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Liz Rea --- Hi Arthur, Sorry to report this patch doesn't seem to apply: Applying: Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions error: sha1 information is lacking or useless (C4/Reserves.pm). error: could not build fake ancestor Patch failed at 0001 Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Please rebase on master and reattach, thanks very much for your contribution! Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 22:41:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 20:41:42 +0000 Subject: [Koha-bugs] [Bug 22807] Koha should use Skip to Main Content link for accessibility purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #1 from Hayley Mapley --- Hi Owen, Shall I change the status of this one to Assigned? Or do you want someone else to pick it up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 23:01:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 21:01:53 +0000 Subject: [Koha-bugs] [Bug 22815] New: Save item's homebranch in patron's fines list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22815 Bug ID: 22815 Summary: Save item's homebranch in patron's fines list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: lisetteslatah at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- bug 15136 added a column to the fines screen (boraccount.pl) that shows the item's home branch. If the item is deleted the branch information goes away. It would be helpful if that column was filled and the data saved so if the item is deleted the information is not lost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 23:02:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 21:02:05 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22815 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 23:02:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 21:02:05 +0000 Subject: [Koha-bugs] [Bug 22815] Save item's homebranch in patron's fines list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22815 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15136 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 30 23:42:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2019 21:42:49 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #100 from Agust?n Moyano --- (In reply to Agust?n Moyano from comment #86) > Created attachment 89122 [details] [review] > Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option > > In order to add groups for holds, this patch provides a new column in > library_groups to identify them. Also provides new enum option for > hold_fulfillment_policy column of default_branch_circ_rules, > default_circ_rules, default_branch_item_rules and branch_item_rules. > > To test: > 1) check that there is no ft_local_hold_group column in library_groups > and that there are no 'holdgroup' enum option in hold_fulfillment_policy > in default_branch_circ_rules, default_circ_rules, default_branch_item_rules > and branch_item_rules > 2) apply this patch > 3) perl installer/data/mysql/updatedatabase.pl && dbic > SUCCESS => !(step 1) ;-D > 4) Sign off > > Sponsored-by: VOKAL > > Signed-off-by: Tomas Cohen Arazi After bug 18936, omit from this test plan the 'holdgroup' enum columns -- You are receiving this mail because: You are watching all bug changes.