[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Apr 2 17:47:38 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

--- Comment #4 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 87327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87327&action=edit
Bug 22611: Correction for call to get create_item in EDI.pm

There was a typo in the addition of a call to
effective_create_items causing processing to abort after adding
a single copy.

This patch reverts to using the C4::Context call as used for the
first copy created, the intended call to effective_create_items
is a wrapper around that as the field in the basket is guaranteed
to be null (its not set when we call AddBasket). Being consistent
and explicit in what we call should guard against future changes
in dependencies exposing the logic flaw

Added some comments to make logical flow of code clearer

Signed-off-by: Liz Rea <wizzyrea at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list