[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Liz Rea <wizzyrea at gmail.com> ---
Hi David,

I got test failures too, as follows, have a look?

Liz

#   Failed test 'Bug 14101: Cannot renew, renewal is automatic (returned code
is auto_renew)'
#   at t/db_dependent/Circulation.t line 601.
#          got: 'auto_too_soon'
#     expected: 'auto_renew'

    #   Failed test 'Cannot renew, renew is automatic'
    #   at t/db_dependent/Circulation.t line 643.
    #          got: 'auto_too_soon'
    #     expected: 'auto_renew'

    #   Failed test 'Cannot renew, renew is automatic'
    #   at t/db_dependent/Circulation.t line 661.
    #          got: 'auto_too_soon'
    #     expected: 'auto_renew'
    # Looks like you failed 2 tests of 14.

#   Failed test 'too_late_renewal / no_auto_renewal_after'
#   at t/db_dependent/Circulation.t line 662.

    #   Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 5'
    #   at t/db_dependent/Circulation.t line 695.
    #          got: 'auto_too_soon'
    #     expected: 'auto_renew'

    #   Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 10'
    #   at t/db_dependent/Circulation.t line 708.
    #          got: 'auto_too_soon'
    #     expected: 'auto_renew'
    # Looks like you failed 2 tests of 6.
t/db_dependent/Circulation.t .. 60/125 
#   Failed test 'auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew'
#   at t/db_dependent/Circulation.t line 724.

    #   Failed test 'Can auto renew, patron is expired but
BlockExpiredPatronOpacActions=0'
    #   at t/db_dependent/Circulation.t line 750.
    #          got: 'auto_too_soon'
    #     expected: 'auto_renew'

    #   Failed test 'Can auto renew, BlockExpiredPatronOpacActions=1 but patron
is not expired'
    #   at t/db_dependent/Circulation.t line 774.
    #          got: 'auto_too_soon'
    #     expected: 'auto_renew'
    # Looks like you failed 2 tests of 6.

#   Failed test 'auto_account_expired | BlockExpiredPatronOpacActions'
#   at t/db_dependent/Circulation.t line 776.
t/db_dependent/Circulation.t .. 125/125 # Looks like you failed 4 tests of 125.
t/db_dependent/Circulation.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/125 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 1024 Tests: 125 Failed: 4)
  Failed tests:  58-61
  Non-zero exit status: 4
Files=1, Tests=125, 36 wallclock secs ( 0.11 usr  0.01 sys + 25.60 cusr  4.60
csys = 30.32 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.