[Koha-bugs] [Bug 19630] "Hold is suspended" message appears in barcode field in holds table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 87418
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87418
Bug 19630: Added Status column to Patron Holds table

Review of attachment 87418:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19630&attachment=87418)
-----------------------------------------------------------------

Hi Hayley,

found a small issue, see below. I don't really like the new message to be
honest - I feel it's too much to read. Could we go without?


Some examples:

Hold has been placed Item hasn't been transferred yet from Fairview
Hold has been placed Item is waiting here

::: koha-tmpl/intranet-tmpl/prog/js/holds.js
@@ +132,5 @@
> +                    {
> +                        "mDataProp": function( oObj ) {
> +                            var data = "";
> +                            if ( oObj.suspend != 1 && !oObj.itemtype_limit) {
> +                                data = _("Hold has been placed\n");

Strings in .js files are not picked up by our translation tools. That is the
reason the other messages are using variables that are replaced later.

-- 
You are receiving this mail because:
You are watching all bug changes.