[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Apr 8 17:20:31 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87337|0                           |1
        is obsolete|                            |
  Attachment #87338|0                           |1
        is obsolete|                            |

--- Comment #35 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 87528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87528&action=edit
Bug 18450: Only allow Override for renewals according to relevant sysprefs

This patch adds a conditional which refers to the system preferences
AllowRenewalIfOtherItemsAvailable and AllowRenewalLimitOverride to
control the display of the 'Override and renew' button, in addition to
the 'Continue without renewing', when renewing an item that has been
placed on hold.

Test plan:

--NOTE-- The following renewals must be completedd in Circulation->Renew

1) Apply the patch, and ensure the following steps work as described

2) In More->Administration->Global system preferences ensure that both
the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvailable
preferences are both set to 'Don't allow'

3) Item levelOnly one available item:
Try to renew an item (with item level hold on it) which belongs to a
biblio with only one item. Note the only button in the yellow alert
box displayed is 'Continue without renewing'

4) Record level/Only one available item:
Try to renew an item (this time with a 'Next Available' hold on the
record) which belongs to a biblio with only one item. Note the only
button in the yellow alert box displayed is 'Continue without
renewing'

5) Item level/Multiple available items:
Try to renew an item (with item level hold on it) which belongs to a
biblio with multiple available items of it in the catalogue. Note
only the 'Continue without renewing' button is displayed

6) Record level/Multiple available items:
Try to renew an item (with item level hold on it) which belongs to a
biblio with multiple available items of it in the catalogue. Note
only the 'Continue without renewing' button is displayed

7) Set both AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvailable system preferences to 'Allow'

8) Repeat step 3, and note only the 'Continue without renewing' button
is displayed in the yellow alert box

9) Repeat step 4, and note the only button in the yellow alert box
displayed is 'Continue without renewing'

10) Repeat step 5, not only the 'Continue without renewing' button is
displayed (because the hold is for that specific item)

11) Repeat step 6, note the item is immediately renewed and the yellow
alert box is not displayed

12) Set the AllowRenewalIfOtherItemsAvailable to 'Don't Allow' and
repeat steps 3-6, and note that only the 'Continue without renewing'
button is displayed

13) Set the AllowRenewalIfOtherItemsAvailable system preference back to
'Allow' and AllowRenewalLimitOverride syspref to 'Don't Allow', and
repeat steps 3-5 and note only the 'Continue without renewal' button is
displayed.

14) Repeat step 6 and note that the item is immediately renewed with no
yellow warning box.

Sponsored-by: Catalyst IT

Signed-off-by: Liz Rea <wizzyrea at gmail.com>
that is a well thorough test plan. All went as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list