[Koha-bugs] [Bug 22551] Stray "//" appears at bottom of opac-detail.tt

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Apr 9 00:59:27 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551

--- Comment #3 from Eric Phetteplace <ephetteplace at cca.edu> ---
I do see that other stray "//]]>" around line 1720 of opac-detail.tt but it is
not what's causing the text to display—inspect an opac-detail page in your web
browser, the segment I removed (just above an orphaned closing </script> tag
and the Twitter script) falls outside any <script> tags which is why the
browser renders it as a text node. That second stray "//]]>" is inside a very
long <script> tag with several functions (OpacHighlightedWords,
OPACShelfBrowser,IDreamBooksReviews, etc.) and thus not rendered as text.

In any case, I can re-submit a patch that removes both since that seems to be
the right thing to do. It's not actually clear to me what's wrong with my
commit message...I can be more descriptive but I thought I stated the bug
number/name in the subject and outlined the testing plan already.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list