[Koha-bugs] [Bug 18205] API interface to Koha::Logger

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK, to clarify..

Lari, can you state exactly what it is about MojoX::Log::Log4Perl that you wish
to use within the Mojo layer of Koha?  My understanding of the module is that
it in effect makes the the logger object act much like (but not exactly like)
Mojo::Log which would actually differ from Koha::Logger in use elsewhere.  For
all the basics however they act the same.

Personally I've prefer more documentation adding to Koha::Logger to state to
end user how we're expecting them to use the Logger object and then for
Koha::Logger to be used throughout the application (whether is be the Mojo side
or otherwise).

$app->log basically just returned a Log object anyway, so it may as well be a
standard Koha::Logger rather than 'yet another implementation'
Koha::Logger::Mojo which acts in a subtly different way.

Thoughts?  Unless you have a justifiable reason for introducing this additional
dependency and abstraction I'm happy to submit an alternative using just
Koha::Logger directly.

-- 
You are receiving this mail because:
You are watching all bug changes.