[Koha-bugs] [Bug 22069] Log viewer not displaying item renewals

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069

axel <axel.amghar at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |axel.amghar at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #3 from axel <axel.amghar at gmail.com> ---
Hello,
I tested the patch, and he doesn't work.
When I tested the different searches,
- Modules All - Actions All  works
- Modules All - Actions Renew return No log found 

- Modules All - Actions Renew  return No log found 
because you forgot parentheses around the grep:

if ( (grep { $_ eq 'CIRCULATION'} @modules) && (grep { $_ eq 'RENEW'} @actions)
) {
   push @actions, 'RENEWAL';     
}


But i tkink a better solution will be to change the value in the form:

In the actions label
replace <option value="RENEW">Renew</option>
by <option value="RENEWAL">Renew</option>

and the patch will work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.