[Koha-bugs] [Bug 22675] SCO broken on invalid barcodes

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Apr 9 22:54:10 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87672|0                           |1
        is obsolete|                            |

--- Comment #2 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 87684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87684&action=edit
Bug 22675: Fix SCO behaviour on non-existent barcodes

Bug 21206 replaced GetItem for Koha::Items->find, and introduced this
problem. This patch verifies $item is defined before attempting to use
its methods.

To test:
- Log into SCO
- Type an invalid barcode
=> FAIL: Things explode :-/
- Apply this patch, reload
- Type an invalid barcode
=> SUCCESS: A nice error message is displayed :-D
- Sign off :-D

Signed-off-by: Liz Rea <wizzyrea at gmail.com>
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.
100% that used to explode, and now does not. Excellent.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list