[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Apr 11 01:58:34 CEST 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #145 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Taking a first view here, starting with the QA script:
1) QA script failures:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-merge-rules.tt
FAIL filters
missing_filter at line 376 ( <input
type="checkbox" name="batchremove" value="[% rule.id %]"[% IF rule.removemarked
%] checked="checked"[% END %]/>)
missing_filter at line 364 ( <td>[% rule.filter
%]</td>)
missing_filter at line 372 ( <a
href="?op=remove&id=[% rule.id %]" title="Delete" class="btn btn-mini"><i
class="fa fa-trash"></i> Delete</a>)
missing_filter at line 317 (
<option value="[% module.id %]">[% module.name %]</option>)
missing_filter at line 373 ( <a
href="?op=edit&id=[% rule.id %]" title="Edit" class="btn btn-mini"><i class="fa
fa-pencil"></i> Edit</a>)
missing_filter at line 363 ( <td>[% rule.module
%]</td>)
missing_filter at line 308 ( <tr id="[% rule.id %]"
class="rule[% IF rule.edit %]-edit[% END %]">)
missing_filter at line 315 (
<option value="[% module.id %]" selected="selected">[% module.name %]</option>)
missing_filter at line 234 (<form action="[% script_name %]"
method="GET">)
missing_filter at line 328 ( <option
value="[% preset %]">[% preset %]</option>)
missing_filter at line 357 ( <button
class="btn btn-mini" title="Save" id="doedit" value="[% rule.id %]"><i
class="fa fa-check"></i> Save</button>)
missing_filter at line 323 ( <td><input
type="text" size="3" name="tag" value="[% rule.tag %]"/></td>)
wrong_html_filter at line 373 ( <a
href="?op=edit&id=[% rule.id %]" title="Edit" class="btn btn-mini"><i class="fa
fa-pencil"></i> Edit</a>)
missing_filter at line 5 (<link rel="stylesheet"
type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" />)
missing_filter at line 310 ( <td>[% rule.id
%]</td>)
missing_filter at line 385 (<form action="[% script_name %]"
method="post">)
missing_filter at line 365 ( <td>[% rule.tag
%]</td>)
missing_filter at line 241 (<form action="[% script_name %]"
method="POST" id="marc-merge-rules-form">)
wrong_html_filter at line 372 ( <a
href="?op=remove&id=[% rule.id %]" title="Delete" class="btn btn-mini"><i
class="fa fa-trash"></i> Delete</a>)
missing_filter at line 362 ( <td>[% rule.id
%]</td>)
missing_filter at line 263 ( <option
value="[% module.id %]">[% module.name %]</option>)
missing_filter at line 273 ( <option
value="[% preset %]">[% preset %]</option>)
missing_filter at line 322 ( <td><input
type="text" size="5" name="filter" value="[% rule.filter %]"/></td>)
FAIL forbidden patterns
forbidden pattern: Do *not* include full path to css files, use
the Asset TT plugin (bug 20538) (line 5)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 372)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 373)
forbidden pattern: Attribute type should not be used for script
tags (bug 20053) (line 14)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 357)
forbidden pattern: Attribute type should not be used for style
tags (bug 20054) (line 8)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 302)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 358)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 301)
OK git manipulation
FAIL js_in_body
A <script> tag found inside head, must be moved to the body
(see bug 17858)
OK spelling
FAIL tt_valid
lines 334, 335, 340, 341, 346, 347, 352, 353, 376
OK valid_template
FAIL Koha/MarcMergeRule.pm
OK critic
OK forbidden patterns
OK git manipulation
OK pod
FAIL pod coverage
POD is missing for 'store'
OK spelling
OK valid
FAIL Koha/MarcMergeRules.pm
OK critic
OK forbidden patterns
OK git manipulation
OK pod
FAIL pod coverage
POD is missing for delete
POD is missing for find_or_create
POD is missing for object_class
POD is missing for operations
POD is missing for update
POD is missing for validate
OK spelling
OK valid
FAIL Koha/MarcMergeRule.pm
OK critic
OK forbidden patterns
OK git manipulation
OK pod
FAIL pod coverage
POD is missing for 'store'
OK spelling
OK valid
FAIL Koha/MarcMergeRules.pm
OK critic
OK forbidden patterns
OK git manipulation
OK pod
FAIL pod coverage
POD is missing for delete
POD is missing for find_or_create
POD is missing for object_class
POD is missing for operations
POD is missing for update
POD is missing for validate
OK spelling
OK valid
2) Please merge your 3 atomic update SQL files into one .perl file. That will
make the RM happy.
3) There is no sign-off line on the patch?
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list