[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Hayley,

can you please fix a few things here?

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep6.tt
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 137)
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep8.tt
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 137)
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
   FAIL   filters
                missing_filter at line 136 (        <p><strong> Warning:
</strong> [% passwordwarning %]</p>)
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

If you are using kohadevbox you can run the qa test tools from koha-shell:
qa -c 6 -v 2 

There is also a complaint about the commit messages:

Processing additional checks

        * Commit title does not start with 'Bug XXXXX: ' - df4b236511
        * Commit title does not start with 'Bug XXXXX: ' - a1946b6a31

This can be fixed easiest with: git rebase -i HEAD~6 and then rewording the 2
at the beginning.

Let me know, if I can help more.

-- 
You are receiving this mail because:
You are watching all bug changes.