[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #92 from Ere Maijala <ere.maijala at helsinki.fi> ---
(In reply to Katrin Fischer from comment #82)
> Bad (blocker):
> - git grep bibliosubtitle.subtitle still shows several occurrences to be
> fixed

Fixed.

> - Can you explain the use of $raw on the subtitle in
> koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt and
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt

I suppose it's because of the html2text filter, but I just kept what there
already was. 

> Non-blocker notes:
> - Need to leave a note on Taiga/bug here that the Koha-to-keyword content
> needs to be removed from the manual

Can I access Taiga somewhere or is it better to just file a bug?

> - Will need extensive release notes notes.

I'll try to come up with something.

> Pre-existing:
> - GetHoldsQueueItems: biblioitems.publicationsyear is listed twice in the
> SQL query

Fixed here.

> - Why so many occurrences of [% subtitl %]?

I've kept as much of the code intact as possible. Since the old code used that,
I've kept it intact. Also, we concatenate multiple values in the database with
' | ', so splitting and handling them one by one allows one to customize the
display more. 

> - The ',' between subtitles will in opac-results.pl, opac-showreviews-rss.tt
> will look not work for MARC21 libraries using proper ISBD punctuation in
> their records.

I agree, but I believe that hasn't changed here. It could be handled as a
separate issue.

> II Questions:
> 
> - In the database update we don't check if libraries had already mapped the
> fields to other database columns. The remapping might leave data and reports
> orphaned. Should we check for this and at least print a warning?

Good point, check added.

> - What is our recommendation on how to populate the new db fields? Can we
> imagine something that works faster than touch_all_biblios.pl? SQL updates?  
> What's the difference between touch_all_biblios.pl and
> batchRebuildBiblioTables.pl?

batchRebuildBiblioTables.pl is recommended. touch_all_biblios.pl also indexes
all changes, which isn't necessary here.

> - Why was the -t test option removed from batchRebuildBiblioTables.pl?

It served no purpose. There was no useful output or anything that I could think
of to use it for. 

> - AFAIK UNIMARC doesn't have ISBD punctuation in the records. Do we need to
> introduce a separator for UNIMARC between title and subtitle?

That'd probably be nice, but I believe that could be done in a separate bug.
Since most of the existing templates didn't have that, I don't think it's
vital. Also, I believe the code in opac-detail could be improved if comma is
not the best separator.

-- 
You are receiving this mail because:
You are watching all bug changes.