[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Apr 14 23:17:04 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #39 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
(In reply to Katrin Fischer from comment #38)
> Hi Hayley,
> 
> can you please fix a few things here?
> 
>  FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep6.tt
>    OK	  filters
>    FAIL	  forbidden patterns
> 		forbidden pattern: Do *not* include full path to js files, use the Asset
> TT plugin (bug 20538) (line 137)
>    OK	  git manipulation
>    OK	  js_in_body
>    OK	  spelling
>    OK	  tt_valid
>    OK	  valid_template
> 
>  FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep8.tt
>    OK	  filters
>    FAIL	  forbidden patterns
> 		forbidden pattern: Do *not* include full path to js files, use the Asset
> TT plugin (bug 20538) (line 137)
>    OK	  git manipulation
>    OK	  js_in_body
>    OK	  spelling
>    OK	  tt_valid
>    OK	  valid_template
> 
>  FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>    FAIL	  filters
> 		missing_filter at line 136 (        <p><strong> Warning: </strong> [%
> passwordwarning %]</p>)
>    OK	  forbidden patterns
>    OK	  git manipulation
>    OK	  js_in_body
>    OK	  spelling
>    OK	  tt_valid
>    OK	  valid_template
> 
> If you are using kohadevbox you can run the qa test tools from koha-shell:
> qa -c 6 -v 2 
> 
> There is also a complaint about the commit messages:
> 
> Processing additional checks
> 
> 	* Commit title does not start with 'Bug XXXXX: ' - df4b236511
> 	* Commit title does not start with 'Bug XXXXX: ' - a1946b6a31
> 
> This can be fixed easiest with: git rebase -i HEAD~6 and then rewording the
> 2 at the beginning.
> 
> Let me know, if I can help more.

Hi Katrin,

The missing filter I can definitely add. I normally do run the QA tools before
attaching, I must have missed it this time though! Thanks for picking it up. 

The Asset plugin issue is trickier because it does not work with onboarding due
to how it retrieves Koha version from the database (or tries to before the
database is created). There is a patch that will solve this and allow for Asset
to be used in onboarding Bug 22451, but it is not yet pushed to Master, so the
full path js is all that can be done for now I think. 

I will reattach once I have reworded the commits and added the missing filter.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list