[Koha-bugs] [Bug 22551] Stray "//" appears at bottom of opac-detail.tt
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Apr 16 06:23:25 CEST 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551
--- Comment #6 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
(In reply to Hayley Mapley from comment #5)
> (In reply to Eric Phetteplace from comment #3)
>
> > In any case, I can re-submit a patch that removes both since that seems to
> > be the right thing to do. It's not actually clear to me what's wrong with my
> > commit message...I can be more descriptive but I thought I stated the bug
> > number/name in the subject and outlined the testing plan already.
>
> It doesn't look like the bug number or description is in the first line of
> your patches, it should be. Also the patch should be descriptive, the commit
> you attached was:
>
> 'patch'
>
> It should be:
> 'Bug 22551: Removed stray characters from opac-detail.tt
>
> There are stray characters, for the reasons outlined in the bug report. This
> patch fixes that.
>
> Test plan:
> 1) Note the extra characters on the template
> 2) Apply the patch
> 3) Verify the characters have disappeared'
>
> or something similar.
>
> Not a dig, just trying to make what Owen said clearer :) I will test this
> patch now
(In reply to Eric Phetteplace from comment #3)
> I do see that other stray "//]]>" around line 1720 of opac-detail.tt but it
> is not what's causing the text to display—inspect an opac-detail page in
> your web browser, the segment I removed (just above an orphaned closing
> </script> tag and the Twitter script) falls outside any <script> tags which
> is why the browser renders it as a text node. That second stray "//]]>" is
> inside a very long <script> tag with several functions
> (OpacHighlightedWords, OPACShelfBrowser,IDreamBooksReviews, etc.) and thus
> not rendered as text.
>
> In any case, I can re-submit a patch that removes both since that seems to
> be the right thing to do. It's not actually clear to me what's wrong with my
> commit message...I can be more descriptive but I thought I stated the bug
> number/name in the subject and outlined the testing plan already.
(In reply to Hayley Mapley from comment #5)
> (In reply to Eric Phetteplace from comment #3)
>
> > In any case, I can re-submit a patch that removes both since that seems to
> > be the right thing to do. It's not actually clear to me what's wrong with my
> > commit message...I can be more descriptive but I thought I stated the bug
> > number/name in the subject and outlined the testing plan already.
>
> It doesn't look like the bug number or description is in the first line of
> your patches, it should be. Also the patch should be descriptive, the commit
> you attached was:
>
> 'patch'
>
> It should be:
> 'Bug 22551: Removed stray characters from opac-detail.tt
>
> There are stray characters, for the reasons outlined in the bug report. This
> patch fixes that.
>
> Test plan:
> 1) Note the extra characters on the template
> 2) Apply the patch
> 3) Verify the characters have disappeared'
>
> or something similar.
>
> Not a dig, just trying to make what Owen said clearer :) I will test this
> patch now
Ahh I see. Did you remove the description when you attached the commit? I see
it now that I am amending to your commit that your commit message is perfect.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list