[Koha-bugs] [Bug 22683] Make issue and old_issue prefetchable from Koha::Account::Line

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22683

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Josef Moravec from comment #3)
> Comment on attachment 87751 [details] [review]
> Bug 22683: Allow prefetch with Koha::Account::Line->checkouts
> 
> Review of attachment 87751 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: Koha/Account/Line.pm
> @@ +68,4 @@
> >  
> > +    my $old_issue_rs = $self->_result->old_issue;
> > +    return Koha::Old::Checkout->_new_from_dbic( $old_issue_rs ) if $old_issue_rs;
> > +    return undef;
> 
> should be only 'return;' I think...

It should amount to the same thing.. but I think you're right that our linter
would complain about returning explicit undef.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.