[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Comment on attachment 88141
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88141
Bug 22284: New methods in Koha::Library::Groups and Koha::Library

Review of attachment 88141:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22284&attachment=88141)
-----------------------------------------------------------------

::: Koha/Library.pm
@@ +26,5 @@
>  use Koha::Database;
>  use Koha::StockRotationStages;
> +use Koha::Libraries;
> +
> +use Data::Dumper qw(Dumper);

I think this needs to be removed.

@@ +115,5 @@
> +    my @hold_libraries = $self->get_hold_libraries;
> +
> +    foreach (@hold_libraries) {
> +        my $hold_library = $_;
> +        my $cond = 1;

Variable name isn't very self explanatory. What condition?

::: t/db_dependent/LibraryGroups.t
@@ +9,5 @@
>  use t::lib::TestBuilder;
>  use Koha::Database;
>  
> +use Data::Dumper;
> +

I think this also needs to be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.