[Koha-bugs] [Bug 22759] Circulation rules for maxissueqty are applied per branch even for defaults

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22759

--- Comment #4 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 88540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88540&action=edit
Bug 22759: Fix wrong check of branch rule in C4::Circulation::TooMany

The condition in TooMany applied branch limits only if the rule didn't have a
branchcode, this was wrong

To test:
 1 - Find a title in the catalog, add 8 items, all of a single itemtype, 4 for
branch A, four for branch B
 2 - Remove any specific circ rules
 3 - Set a default circ rule for the itemtype used above, limiting the max
issue quantity to 3
 4 - Find a patron and checkout the items from branch A
 5 - You should be allowed to checkout 3, but the fourth should trigger 'too
many'
 6 - Now checkout the items from branch B, again you can checkout 3 and not
four
 7 - Apply this patch
 8 - Assuming you have 6 items out now, try one from either branch, you should
trigger 'too many' and have 6
 9 - Return two from branch B and one from branch A
10 - Now you have three items issued total
11 - An item from either branch should be refused now
12 - Test with different values of 'CircControl' and confirm your expectations
are met

Signed-off-by: Liz Rea <wizzyrea at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.