[Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist.

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Apr 23 20:57:18 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88551|0                           |1
        is obsolete|                            |

--- Comment #2 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 88555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88555&action=edit
Bug 22753: Fix hold priority adjustment, move to top

Since the holds table can be split we need to calculate the first priority for
each table. However, currently we use the firs tin the loop, not taking into
accoutn waiting status. This patchset sets the first_priority to the first
non-found hold

Additionally, some cleanmup is done to not display the alter priority arrows
for waiting holds

To test:
1 - Place several holds on a title
2 - Confirm one of the holds to be waiting
3 - Attempt to move the last hold to the top
4 - Nothing happens
5 - Apply patch
6 - Note that the waiting hold has no options to move in the list
7 - Attempt to move the last hold to the top
8 - It moves as expected!
9 - Split the holds queue by pickup library
10 - PLace some holds for pickup at another branch
11 - Confirm moving these holds works within their own table
12 - Unsplit the queue
13 - Ensure the holds end where you expect (moving in a split table didn't move
above holds form another table)

Signed-off-by: Liz Rea <wizzyrea at gmail.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list