[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Apr 24 17:39:31 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |josef.moravec at gmail.com
             Status|Signed Off                  |Failed QA

--- Comment #153 from Josef Moravec <josef.moravec at gmail.com> ---
Started QAing:

1) QA test tools have complains about missing filters

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
   FAIL   filters
                missing_filter at line 22 (     [% UNLESS ( I ) %][% IF (
othernames ) %]“[% othernames %]”[% END %])
                missing_filter at line 64 (    <li><span class="label">Card
number: </span>[% cardnumber %]</li>)
                missing_filter at line 65 (        <li><span
class="label">Borrowernumber: </span> [% borrowernumber %]</li>)
                missing_filter at line 66 (    <li><span
class="label">Category: </span>[% categoryname %] ([% categorycode %])</li>)
                missing_filter at line 66 (    <li><span
class="label">Category: </span>[% categoryname %] ([% categorycode %])</li>)


2) The database update is not consistent, in atomic file you add columns after
other columns then in kohastructure.sql

Also, you should use .perl atomic update here, to check for column existence
before adding it - see skeleton.perl for example

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list