[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928

--- Comment #25 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 86134
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86134
Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to
circulation_rules

Review of attachment 86134:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18928&attachment=86134)
-----------------------------------------------------------------

::: C4/Circulation.pm
@@ +1706,5 @@
> +
> +    # Search for rules!
> +    foreach my $rule_name (qw( holdallowed hold_fulfillment_policy returnbranch )) {
> +        foreach my $params (@params) {
> +            my $rule = Koha::CirculationRules->search(

Why do you use ->search instead of get_effective_rule?

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
@@ +720,4 @@
>                      <th>Return policy</th>
>                      <th> </th>
>                  </tr>
> +                [% FOREACH i IN itemtypeloop %]

There is something strange in displaying hold policy for itemtypes. When I have
set values in Default checkout, hold and return policy section, i see all item
types listed with the same value as set in Default section, even if i set some
itemtypes differently...

-- 
You are receiving this mail because:
You are watching all bug changes.