[Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Apr 30 05:33:33 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537

--- Comment #4 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #3)
> Hi Hayley,
> 
> It will work, but I am wondering if something like that would not be more
> readable:
> 
> my $borr = sprintf( "%s%s%s (%s)",
>     $data->{surname} || '',
>     $data->{firstname} && $data->{surname} ? ', ' : '',
>     $data->{firstname} || '',
>     $borrowernumber );
> 
> What do you think?

Hi Jonathan,

I'm happy to implement your solution, however it looks like maybe this error is
not present on master anymore. Would you mind confirming this?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list