From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 02:30:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 00:30:38 +0000 Subject: [Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 --- Comment #5 from Alex Buckley --- Created attachment 91901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91901&action=edit Bug 23352: Display Acquisition unitprice and replacementprice by default in serials/serials-edit.pl Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 02:53:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 00:53:44 +0000 Subject: [Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 --- Comment #6 from Alex Buckley --- Hi Katrin, You're quite right currently 952$h already behaves as I had described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 07:31:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 05:31:47 +0000 Subject: [Koha-bugs] [Bug 7534] Add an option on library level to indicate if a library can be chosen as pick-up location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New |Add an option on library |OPACAllowUserToChooseBranch |level to indicate if a |setting for only showing |library can be chosen as |libraries allowing holds |pick-up location --- Comment #97 from Katrin Fischer --- It looks like this development changed from the initial description, updating bug title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 11:37:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 09:37:24 +0000 Subject: [Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff and opac) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 11:37:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 09:37:11 +0000 Subject: [Koha-bugs] [Bug 23409] New: Show borrowernotes and opacnote's lines feeds (staff and opac) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Bug ID: 23409 Summary: Show borrowernotes and opacnote's lines feeds (staff and opac) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently, lines feeds typed in borrowernotes and opacnote are not visible in the interface. Patch is coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 11:42:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 09:42:48 +0000 Subject: [Koha-bugs] [Bug 12345] Can't Clear Reading History for Anonymous patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12345 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #5 from Magnus Enger --- (In reply to Jonathan Druart from comment #2) > Still valid. > But the behavior is the expected one: When you delete a checkout history you > actually anonymise the checkout history :) I would say this qualifies as a WONTFIX. :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 11:53:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 09:53:00 +0000 Subject: [Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show borrowernotes and |Show borrowernotes and |opacnote's lines feeds |opacnote's lines feeds |(staff and opac) |(staff) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 11:53:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 09:53:45 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #28 from Magnus Enger --- (In reply to Nick Clemens from comment #26) > (In reply to Jonathan Druart from comment #25) > > Maybe like: > > Purge statistics entries more than DAYS days old > > Purge catalog records deleted more then DAYS days ago > > Purge patrons deleted more than DAYS days ago > > Purge checkouts (old_issues) returned more than DAYS days ago > > Purge transfers completed more than DAYS day ago Fridolin: Any chance you can find the time to update the POD with these suggestions? We really need a way to clean up the data that these patches clean up. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:46:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 11:46:36 +0000 Subject: [Koha-bugs] [Bug 23408] Relatives' checkout table columns are not configured properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:46:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 11:46:39 +0000 Subject: [Koha-bugs] [Bug 23408] Relatives' checkout table columns are not configured properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408 --- Comment #1 from Nick Clemens --- Created attachment 91903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91903&action=edit Bug 23408: Move relatives-issues-table to an include TO test: 1 - Find and adult patron 2 - Add a child account 3 - Check out some things to the child 4 - View the adults account, click 'Relatives checkouts' 5 - Observe table is oddly formatted 6 - View on both the 'Check out' and 'Details' tabs 7 - Apply patch 8 - Tables are displayed correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:46:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 11:46:34 +0000 Subject: [Koha-bugs] [Bug 23410] New: Add submenus to system preferences sidebar menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23410 Bug ID: 23410 Summary: Add submenus to system preferences sidebar menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 91902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91902&action=edit Screenshot showing updated interface One of my proposed changes in Bug 20935 is the addition of submenu items in the sidebar menu of system preferences. I'm proposing this as a standalone enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:56:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 11:56:26 +0000 Subject: [Koha-bugs] [Bug 23408] Relatives' checkout table columns are not configured properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:58:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 11:58:34 +0000 Subject: [Koha-bugs] [Bug 22710] [18.11] Return to the last advanced search link not filtering correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Return to the last advanced |[18.11] Return to the last |search link not filtering |advanced search link not |correctly in 18.11.x |filtering correctly CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Confirmed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 13:59:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 11:59:24 +0000 Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items, we shouldn't pass them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:05:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 12:05:15 +0000 Subject: [Koha-bugs] [Bug 22710] [18.11] Return to the last advanced search link not filtering correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 --- Comment #7 from Katrin Fischer --- Created attachment 91904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91904&action=edit Bug 22710: [18.11.x] Return to the last advanced search link not filtering correctly in 18.11.x Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:05:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 12:05:12 +0000 Subject: [Koha-bugs] [Bug 22710] [18.11] Return to the last advanced search link not filtering correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:05:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 12:05:50 +0000 Subject: [Koha-bugs] [Bug 22710] [18.11] Return to the last advanced search link not filtering correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Katrin Fischer --- Applies perfectly on 18.11.x - moving straight to PQA, another one-line patch fixing a bad bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:51:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 12:51:13 +0000 Subject: [Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #1 from Alex Arnaud --- Created attachment 91905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91905&action=edit Bug 23409 - show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 14:51:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 12:51:40 +0000 Subject: [Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:03:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 13:03:01 +0000 Subject: [Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Alex, I think there is a nicer way to solve this using TT filters. I've seen them used in quite a few places already. http://www.template-toolkit.org/docs/manual/Filters.html#section_html_line_break -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:31:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 13:31:05 +0000 Subject: [Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91905|0 |1 is obsolete| | --- Comment #3 from Alex Arnaud --- Created attachment 91906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91906&action=edit Bug 23409 - show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:31:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 13:31:56 +0000 Subject: [Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 15:37:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 13:37:19 +0000 Subject: [Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #4 from Katrin Fischer --- Instead of: + [% FILTER html_line_break %] + [% patron.opacnote | html %] + [% END %] You can just do: [% patron.opacnote | html | html_line_break %] (I think we first want to espace, then make br so the br are not esacped) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 16:43:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 14:43:02 +0000 Subject: [Koha-bugs] [Bug 23411] New: SMS messages should not fall back to 'email' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 Bug ID: 23411 Summary: SMS messages should not fall back to 'email' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 15967 ensured that an email notice that falls back to print when the patron has no email will send a print notice using the email template if there is no print template. When SMS and fallback were added this means that an SMS message where there is no SMS template will use the email template - it shouldn't as SMS messages need to be shorter, we should instead fail sending SMS if no SMS template defined -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:02:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 15:02:38 +0000 Subject: [Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:02:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 15:02:40 +0000 Subject: [Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 --- Comment #1 from Nick Clemens --- Created attachment 91907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91907&action=edit Bug 23411 - SMS messages should not fall back to 'email' To test: 1 - Have a patron wiht an sms number, but no email 2 - Enable sms by setting SMSDriver syspref to Email 3 - Set Notice triggers to send an overdue via sms and email 4 - Ensure the selected notice is defined only for 'email' 5 - Checkout an overdue to the patron above You can set a specify a due date in the past 6 - perl misc/cronjobs/overdue_notices.pl -t 7 - Check the patron notices tab, they have a print notice and an SMS notice pending 8 - The SMS notice used the 'email' template 9 - Apply patch 10 - sudo koha-mysql kohadev 11 - DELETE * FROM message_queue WHERE borrowernumber={borrower as above}; 12 - Run the cron again 13 - Patron should have a print notice queued, no sms 14 - Define an SMS notice 15 - delete the message queue 16 - Run again 17 - The patron should have a print and an SMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:03:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 15:03:56 +0000 Subject: [Koha-bugs] [Bug 23411] SMS messages should not fall back to 'email' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:20:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 15:20:27 +0000 Subject: [Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23194 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:20:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 15:20:27 +0000 Subject: [Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23409 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:24:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 15:24:27 +0000 Subject: [Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #5 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #4) > Instead of: > > + [% FILTER html_line_break %] > + [% patron.opacnote | > html %] > + [% END %] > > You can just do: > > [% patron.opacnote | html | html_line_break %] > > (I think we first want to espace, then make br so the br are not esacped) Indeed, its much better ;) See existing : [% subscription.notes | html | html_line_break %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:30:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 15:30:23 +0000 Subject: [Koha-bugs] [Bug 23286] Improve style of hold confirmation modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 15:30:29 +0000 Subject: [Koha-bugs] [Bug 23286] Improve style of hold confirmation modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91856|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 91908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91908&action=edit Bug 23286: Improve style of hold confirmation modal This patch makes minor changes to the hold confirmation modal in the check-in template and adds some additional style. The goal is to make the information a little more readable. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check in items with the following hold statuses: - On hold for a patron at your library - On hold for a patron at another library - On hold and already marked 'Waiting' Confirm that the hold confirmation modal is clear and well-styled. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:33:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 15:33:14 +0000 Subject: [Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #6 from Fridolin SOMERS --- patron.opacnote exists in other places : koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc borrowernotes exists in a lot of other places. BTW html filter should always be used, not $raw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 15:39:07 +0000 Subject: [Koha-bugs] [Bug 23412] New: HTML should be allowed in MARC notes. (5xx fields) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Bug ID: 23412 Summary: HTML should be allowed in MARC notes. (5xx fields) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some librarians like to add HTML in the 5xx fields to display links, etc. We should allow $raw filters in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 17:39:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 15:39:27 +0000 Subject: [Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 18:19:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 16:19:41 +0000 Subject: [Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 18:19:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 16:19:44 +0000 Subject: [Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #1 from Lucas Gass --- Created attachment 91909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91909&action=edit Bug 23412: HTML should be allowed in MARC notes. (5xx fields) TEST PLAN 1. Add some HTML to one of the 5xx fields that displays in the OPAC: koha 2. Go to the record in the OPAC and look under the 'Title notes' tab. 3. See that the HTML displays literally. 4. Apply patch 5. Look at the 'Title notes' tab again. 6. HTML displays correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 18:37:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 16:37:40 +0000 Subject: [Koha-bugs] [Bug 23108] staffaccess permission can be easily circumvented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23108 Aguayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azucena.aguayo at uvu.edu --- Comment #2 from Aguayo --- Hi Jonathan, The ProtectSuperlibrarianPrivileges doesn't prevent the issue with either option set. If Patron A with only borrower permissions attempts to change the password using the "Change Password" button for Patron B, Patron A gets an error that they can't change the username/password of Patron B. Working as intended. However, Patron A can use the "Edit" button and change Patron B from Staff category to Adult category. Then after saving the account, Patron A can change the username/password of Patron B. At this point, Patron B is locked out of their account. In my case, Patron A has the following rights -(circulate) -(catalogue) -(borrowers) Patron A doesn't have -(permissions) -(staffaccess) (borrowers) is enough to allow the change from Staff to Adult. It seems that the settings protecting the Staff accounts don't look at the Edit rights of borrowers to prevent a category change. And ProtectSuperlibrarianPrivileges only prevents password changes for the Staff category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 19:07:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 17:07:57 +0000 Subject: [Koha-bugs] [Bug 23399] Reindent returns.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 19:08:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 17:08:11 +0000 Subject: [Koha-bugs] [Bug 23399] Reindent returns.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 --- Comment #4 from Kyle M Hall --- Created attachment 91911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91911&action=edit Bug 23399: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 19:08:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 17:08:00 +0000 Subject: [Koha-bugs] [Bug 23399] Reindent returns.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91877|0 |1 is obsolete| | Attachment #91878|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 91910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91910&action=edit Bug 23399: Reindent returns.tt This patch reindents circulation/returns.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but each must take their own journey. Test the checkin process to confirm that everything still works correctly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 19:38:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 17:38:47 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #46 from Liz Rea --- I suppose we ought to go back and test this again for 19.11 - did we ever fix the tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:10:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 18:10:58 +0000 Subject: [Koha-bugs] [Bug 23413] New: Add a holds routine to Koha::Items to fetch related holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Bug ID: 23413 Summary: Add a holds routine to Koha::Items to fetch related holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:12:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 18:12:08 +0000 Subject: [Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:12:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 18:12:10 +0000 Subject: [Koha-bugs] [Bug 23413] Add a holds routine to Koha::Items to fetch related holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23413 --- Comment #1 from Nick Clemens --- Created attachment 91912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91912&action=edit Bug 23413: Add a holds method to Koha::Items To test; 1 - prove -v t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:29:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 18:29:13 +0000 Subject: [Koha-bugs] [Bug 23414] New: Improve performance of C4/XSLT/buildKohaItemsNamespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Bug ID: 23414 Summary: Improve performance of C4/XSLT/buildKohaItemsNamespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There are some improvements we can make to this routine to improve the speed at which we return results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:29:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 18:29:17 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:37:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 18:37:42 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:37:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 18:37:45 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #1 from Nick Clemens --- Created attachment 91913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91913&action=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:37:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 18:37:48 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #2 from Nick Clemens --- Created attachment 91914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91914&action=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:37:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 18:37:50 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #3 from Nick Clemens --- Created attachment 91915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91915&action=edit Bug 23414: Prefetch reserves and use them for determining waiting This dependss on bug 23413 Same tests as before, you shouldn't see a hit with this change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:47:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 18:47:31 +0000 Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items, we shouldn't pass them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 --- Comment #2 from Nick Clemens --- Created attachment 91916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91916&action=edit Bug 23407: Don't process items for staff results either We also don't use the items here, same test plan but on staff cleint results, should see no change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 20:59:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 18:59:02 +0000 Subject: [Koha-bugs] [Bug 23410] Add submenus to system preferences sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23410 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette Scheer --- I think that would be very helpful! We have so many system preferences that sometime they can be hard to find if you don't know the specific pref to search for. Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 21:13:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 19:13:47 +0000 Subject: [Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com --- Comment #7 from Jessie Zairo --- I am also interested in a notice when staff cancels a hold manually. I agree, maybe an authorized value or standard reasons for cancelling a hold (lost / missing / withdrawn). The notice could included the reason the hold was cancelled. I like the idea of Patron Messaging Preferences including Hold cancelled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 21:25:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 19:25:41 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com --- Comment #3 from Jessie Zairo --- I think in addition to giving a delete permission, we should also had a merge patron permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 21:34:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 19:34:52 +0000 Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91880|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes --- Created attachment 91917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91917&action=edit Bug 23390: Introduce placeholder syntax for report column names This patch adds the ability to rename columns in MySQL reports using a syntax: [[column|alias]] To test: 1 - Write a report like: SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%9' 2 - Run report 3 - Note you can batch modify the patrons 4 - Update report: SELECT cardnumber AS library_barcode FROM borrowers WHERE cardnumber LIKE '%9' 5 - Run report 6 - Note batch options are no longer present 7 - Apply patch 8 - Run report, no change 9 - Update report like: SELECT [[cardnumber|library_barcode]] FROM borrowers WHERE cardnumber LIKE '%9' 10 - Run report 11 - Batch options work! 12 - Update report like: SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%9' 13 - Verify batch options still work 14 - Set report 'public' 15 - Verify report can be run via JSON URLs: http://kohadev.mydnsname.org:8080/cgi-bin/koha/svc/report?id=1 http://kohadev.mydnsname.org:8081/cgi-bin/koha/svc/report?id=1 Signed-off-by: George Williams Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 21:34:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 19:34:54 +0000 Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91882|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes --- Created attachment 91918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91918&action=edit Bug 23390: (QA follow-up) Don't redeclare variable Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 1 21:34:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Aug 2019 19:34:57 +0000 Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91888|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes --- Created attachment 91919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91919&action=edit Bug 23390: (follow-up) Quote aliases Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 07:54:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 05:54:23 +0000 Subject: [Koha-bugs] [Bug 23396] Rancor fails to load: insert_copyright is not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 --- Comment #4 from Katrin Fischer --- Should we add an update database entry to fix this for existing installations? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 07:56:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 05:56:52 +0000 Subject: [Koha-bugs] [Bug 23396] Rancor fails to load: insert_copyright is not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396 --- Comment #5 from Katrin Fischer --- (In reply to Katrin Fischer from comment #4) > Should we add an update database entry to fix this for existing > installations? I think we should. We already got people installing 19.05 for production use and we could just repeat the initial database update from introducing the feature with a check for data already being there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 09:42:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 07:42:06 +0000 Subject: [Koha-bugs] [Bug 23415] New: Notify patron fines when renewing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Bug ID: 23415 Summary: Notify patron fines when renewing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: emmi.takkinen at outlook.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. There should be alert to notify staff that patron has fines over limit and confirmation to renew. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 11:56:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 09:56:11 +0000 Subject: [Koha-bugs] [Bug 23402] Similar to #19706: Item search doesn't work with screen selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402 --- Comment #2 from Anke --- We had 18.11.03-1; just this morning we upgraded to 19.05, and the bug is still there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 12:09:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 10:09:32 +0000 Subject: [Koha-bugs] [Bug 23402] Similar to #19706: Item search doesn't work with screen selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major --- Comment #3 from Katrin Fischer --- Updating severity for now - getting some more attention to see if someone else can confirm the bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 13:00:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 11:00:34 +0000 Subject: [Koha-bugs] [Bug 23402] Similar to #19706: Item search doesn't work with screen selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- I ran a quick test on 19.05.02 and didn't get any error messages - I didn't specify a specific item, just got all the results. To test from /cgi-bin/catalogue/itemsearch.pl I didn't change any of the options pressed search button. A list of results appeared as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 13:07:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 11:07:15 +0000 Subject: [Koha-bugs] [Bug 23402] Similar to #19706: Item search doesn't work with screen selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402 --- Comment #5 from David Nind --- Tested on master as well, and no error messages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 13:09:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 11:09:22 +0000 Subject: [Koha-bugs] [Bug 23416] New: When a note to a specific issue upon receiving a serial, this note will appear in next issue received Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 Bug ID: 23416 Summary: When a note to a specific issue upon receiving a serial, this note will appear in next issue received Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Created attachment 91920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91920&action=edit serials receive A note added to a serial issue upon receipt in the Serials module will stay on each upcoming issue expected and needs to be removed when receiving the next. Libraries use this note to say something specific about the issue they are receiving, not a note that should appear on every issue they receive. Steps to reproduce: 1. Receive an issue in the Serials Module. 2. Add a note to this issue and change to Arrived. 3. See the next expected issue will show this same note from previously received issue. 4. Receive next issue, this note is still getting generated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 13:17:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 11:17:58 +0000 Subject: [Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Wondering if this could be related to the notes work on bug 11492? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 13:54:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 11:54:58 +0000 Subject: [Koha-bugs] [Bug 21180] Allow Talking Tech outbound script to limit based on patron home library branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21180 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 13:55:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 11:55:01 +0000 Subject: [Koha-bugs] [Bug 21180] Allow Talking Tech outbound script to limit based on patron home library branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21180 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81042|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 91921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91921&action=edit Bug 21180: Allow Talking Tech outbound script to limit based on patron home library branchcode A library system has requested the ability to limit which patrons are sent to Itivia for phone notices. Test Plan: 1) Enable phone notices for two patrons with overdues 2) Run the misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl with the new --patron-branchcode option 3) Note only the patron whose homebranch you specified is in the output file Signed-off-by: Kyle M Hall Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:21:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:21:01 +0000 Subject: [Koha-bugs] [Bug 23402] Similar to #19706: Item search doesn't work with screen selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402 --- Comment #6 from Anke --- Update: It seems to be a bug in the German interface; in the English it works well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:22:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:22:10 +0000 Subject: [Koha-bugs] [Bug 23402] Similar to #19706: Item search doesn't work with screen selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402 Anke changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |19.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:23:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:23:13 +0000 Subject: [Koha-bugs] [Bug 23402] Similar to #19706: Item search doesn't work with screen selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402 --- Comment #7 from Anke --- Just updated the version for this bug from 18.11 to 19.05 - hope this was OK. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:41:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:41:13 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:41:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:41:17 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71771|0 |1 is obsolete| | --- Comment #29 from Magnus Enger --- Created attachment 91922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91922&action=edit Bug 19008 - More database cleanups - statistics misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for statistics table. Test plan : - Count statistics : select count(*),date(datetime) from statistics group by date(datetime); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --statistics 30 - Recount statistics Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:41:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:41:36 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71773|0 |1 is obsolete| | --- Comment #31 from Magnus Enger --- Created attachment 91924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91924&action=edit Bug 19008 - More database cleanups - deleted patrons misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deletedborrowers table. Test plan : - Count : select count(*),date(updated_on) from deletedborrowers group by date(updated_on); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-patrons 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:41:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:41:43 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71774|0 |1 is obsolete| | --- Comment #32 from Magnus Enger --- Created attachment 91925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91925&action=edit Bug 19008 - More database cleanups - old issues misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_issues table. Test plan : - Count : select count(*),date(timestamp) from old_issues group by date(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-issues 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:41:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:41:50 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71775|0 |1 is obsolete| | --- Comment #33 from Magnus Enger --- Created attachment 91926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91926&action=edit Bug 19008 - More database cleanups - old reserves misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_reserves table. Test plan : - Count : select count(*),date(timestamp) from old_reserves group by date(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-reserves 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:41:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:41:58 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71776|0 |1 is obsolete| | --- Comment #34 from Magnus Enger --- Created attachment 91927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91927&action=edit Bug 19008 - More database cleanups - item transfers misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for branchtransfers table. Test plan : - Count : select count(*),datearrived from branchtransfers group by datearrived; - Run cleanup : misc/cronjobs/cleanup_database.pl -v --transfers 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:41:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:41:26 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71772|0 |1 is obsolete| | --- Comment #30 from Magnus Enger --- Created attachment 91923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91923&action=edit Bug 19008 - More database cleanups - deleted catalog misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deleted catalog tables. Note that deletedbiblio_metadata is managed by foreign key on biblionumber. Test plan : - Count : select count(*),year(timestamp) from deleteditems group by year(timestamp); select count(*),year(timestamp) from deletedbiblio group by year(timestamp); select count(*),year(timestamp) from deletedbiblioitems group by year(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-catalog 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:42:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:42:05 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #35 from Magnus Enger --- Created attachment 91928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91928&action=edit Bug 19008 - More database cleanups - QA followup This patch tries to change the POD as suggested in the QA process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 14:44:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 12:44:06 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #36 from Magnus Enger --- I have: - Resolved a pretty trivial conflict: $ git bz apply 19008 Bug 19008 - More database cleanups 71771 - Bug 19008 - More database cleanups - statistics 71772 - Bug 19008 - More database cleanups - deleted catalog 71773 - Bug 19008 - More database cleanups - deleted patrons 71774 - Bug 19008 - More database cleanups - old issues 71775 - Bug 19008 - More database cleanups - old reserves 71776 - Bug 19008 - More database cleanups - item transfers Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19008 - More database cleanups - statistics Using index info to reconstruct a base tree... M misc/cronjobs/cleanup_database.pl Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/cleanup_database.pl CONFLICT (content): Merge conflict in misc/cronjobs/cleanup_database.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 19008 - More database cleanups - statistics Use 'git am --show-current-patch' to see the failed patch - Tried to add POD as suggested by the fine QA folks Not sure if this should be Needs signoff or Signed off, setting it to the former. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 15:00:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 13:00:29 +0000 Subject: [Koha-bugs] [Bug 20917] Improve email functionality relating to ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Andrew Isherwood --- *** This bug has been marked as a duplicate of bug 22818 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 15:00:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 13:00:29 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #19 from Andrew Isherwood --- *** Bug 20917 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 15:00:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 13:00:30 +0000 Subject: [Koha-bugs] [Bug 20923] Merging backend status graph into main status graph incorrect use of grep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923 Bug 20923 depends on bug 20917, which changed state. Bug 20917 Summary: Improve email functionality relating to ILL requests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 15:27:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 13:27:00 +0000 Subject: [Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 15:27:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 13:27:12 +0000 Subject: [Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 15:27:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 13:27:02 +0000 Subject: [Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 --- Comment #2 from Nick Clemens --- Created attachment 91929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91929&action=edit Bug 23416: Add PreserveSerialNotes system preference Bug 11492 intended to pass routinglists forward. It also passed forward serial notes. This may or not me desired behvaiour, to avoid changing functionality twice I add a syspref to control this behaviour. To test: 1 - Have or create a subscription in the serials module 2 - Recieve an issue, making sure ot ad a note 3 - Go to receive again, note the note from the last serial is set for the expected issue 4 - Apply patch 5 - Update database, restart all the things 6 - Receive the issue leaving the note in place 7 - Note the next expected issue has the note 8 - Find the syspref PreserveSerialNotes 9 - Confirm it defaulted to Do 10 - Set it to 'Do not' 11 - Receive the expected serial leavign the note 12 - Note the newly generated expected serial has no note 13 - prove -v t/db_dependent/Serials.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 15:39:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 13:39:55 +0000 Subject: [Koha-bugs] [Bug 21518] Material type "three-dimensional artifact" displays as "visual material" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21518 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 15:39:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 13:39:58 +0000 Subject: [Koha-bugs] [Bug 21518] Material type "three-dimensional artifact" displays as "visual material" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21518 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91895|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 91930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91930&action=edit Bug 21518: Material type "three-dimensional artifact" displays as "visual material" This patch makes a few corrections to the staff client MARC21 XSLT so that the correct material type icons are displayed for pictures and realia. The more-specific material type handling has been adapted from the corresponding XSL files in the OPAC. To test you must have default XSLT enabled and the DisplayIconsXSLT and DisplayOPACiconsXSLT system preferences enabled. - Apply the patch and locate records with "type of record" specified in the leader as 'g', 'k', and 'r'. A sample MARC file will be attached to the bug report with one of each type of record. Import the records and search your catalog for "Bug_21518." - View the records in search results and their detail pages, both in the OPAC and the staff client. In all cases the correct material type icon should be displayed. Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 15:55:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 13:55:55 +0000 Subject: [Koha-bugs] [Bug 10492] Translation problems with TT directives in po files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 15:55:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 13:55:58 +0000 Subject: [Koha-bugs] [Bug 10492] Translation problems with TT directives in po files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91899|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 91931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91931&action=edit Bug 10492: Translation problems with TT directives in po files This patch implements the replacement of TTvariables '[%...%]' with normal placeholders '%s' for text inside HTML tags (eg. img, meta, input) The replacement is done in two files: * xgettext.pl, used on create/update, so TTvars are not found on the text to translate (msgid) * tmpl_proccess3.pl, used on install time, so the correct translation is found (msgstr) and the right TTvar is put on the translated text. To test: Before applying the patch 1) Update your favorite language cd misc/traslator perl translate update xx-YY 2) Build a list (ini.txt) of 'msgid' to do a comparison msgcat --no-wrap --use-first po/xx-YY-*po -o - | egrep "^msgid" | sort > ini.txt 3) Apply the patch 4) Update your favorite language, again cd misc/traslator perl translate update xx-YY 5) Build a final list (end.txt) of 'msgid' to do a comparison msgcat --no-wrap --use-first po/xx-YY-*po -o - | egrep "^msgid" | sort > end.txt 6) Compare both files, you must find (most) TTvars replaced by '%s' diff ini.txt end.txt for example: < msgid "Translate item type [% itemtype.itemtype | html %]" > msgid "Translate item type %s" < msgid "Holds on this item: [% item_loo.item_holds | html %] / Total holds on this record: [% item_loo.holds | html -%]" > msgid "Holds on this item: %s / Total holds on this record: %s" < msgid "tag_anchor_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]" > msgid "tag_anchor_%s_%s%s" < msgid "[% innerloo.tag_lib | html %] - Click to Expand this Tag" > msgid "%s - Click to Expand this Tag" 7) Translate one of the examples, with more than one variable if possible, for example this text in xx-YY-staff-prog.po > msgid "Holds on this item: %s / Total holds on this record: %s" Check it's not marked as 'fuzzy' 8) Apply the translation perl translate install xx-YY 9) Check the translated string has all variables in the right order edit koha-tmpl/intranet-tmpl/prog/es-ES/modules/tools/batchMod-edit.tt around line '187', first '[% item_loo.item_holds | html %]', then '[% item_loo.holds | html -%]' on this case, or use another example If approved this patch can be backported to current stable versions. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:00:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 14:00:20 +0000 Subject: [Koha-bugs] [Bug 11979] Display correct not for loan status description on course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu --- Comment #8 from Myka Kennedy Stephens --- I am noticing the effects of this bug, too. We would like to add items to courses while they are on order, before they have been received and cataloged. In 18.11, the status "Not for loan (Ordered)" shows as "Available" in the OPAC course reserves list view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 2 16:02:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Aug 2019 14:02:59 +0000 Subject: [Koha-bugs] [Bug 13693] On order items in course reserves show incorrect status in the OPAC In-Reply-To: References: