[Koha-bugs] [Bug 20307] Language overlay for authorized values

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, 

starting QA here - not only a RM priority, but one of mine as well. I will try
to come back at this as long as necessary:

1) QA test tools:

There are some about POD, but I think those are valid:

 FAIL   admin/authorised_values.pl
   FAIL   valid
                Can't locate Carp/Always.pm in @INC (you may need to install
the Carp::Always module) (@INC contains: /home/vagrant/kohaclone
/home/vagrant/qa-test-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1
/usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base
/var/lib/koha/kohadev/plugins) 

 FAIL   Koha/AuthorisedValues.pm

   FAIL   valid
                Name "Koha::Schema::Result::AuthorisedValue::LANGUAGE" used
only once: possible typo 

2) Code review

a) C4/Search.pm
+                                $facet_label_value = $av->count ?
$av->next->opac_translated_description : ''; # FIXME: Why are we displaying the
opac description for staff?

I believe you are right here - this is a bug. Could be fixed here or later. Why
are we not dealing with this in the templates?

b) Koha/AuthorisedValue.pm

opac_translated_description and tranlated_description seem to have a lot of
duplicated code. Coudl it make sense to merge them with an interface parameter?

+    my $descriptions = {
+        lib              => $av->translated_description,     # Rename with
opac_translated_description to avoid confusion
+        opac_description => $av->opac_translated_description # Same with
translated_description
+    };

Not sure what you meant with your comments here?

3) Testing

The admin page currently explodes:

Could not compile /home/vagrant/kohaclone/admin/authorised_values.pl: Can't
locate Carp/Always.pm in @INC (you may need to install the Carp::Always module)
(@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer
/home/vagrant/kohaclone/lib/installer /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1
/usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base
/var/lib/koha/kohadev/plugins) at
/home/vagrant/kohaclone/admin/authorised_values.pl line 27.
BEGIN failed--compilation aborted at
/home/vagrant/kohaclone/admin/authorised_values.pl line 27.
 at /usr/share/perl5/CGI/Compile.pm line 132


As I understand it, this is just the 'base' and then we will have to work
through the different AV categories... that about right?

-- 
You are receiving this mail because:
You are watching all bug changes.