[Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90868|0                           |1
        is obsolete|                            |

--- Comment #7 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 92250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92250&action=edit
Bug 23172: When returning items check issuingrules

When iterating over every reserve on a biblio when it is being returned
retrieve the issuingrule reserveallowed and holds_per_record values for
the reserves requester borrower category and returned item type.

If the issuingrule defines that reservesallowed or holds_per_record is
0 then skip allocating that item to the current bib-level reserve.

Test plan:
1. Find/make a biblio record with two items: one with item type of 'BK'
(book) and the other with the itemtype of 'CR' (Continuing Resource)

2. In Administration > Circulation and fine rules define 2 new rules:

Patron category: 'B' (Board)/ item type: 'BK'/ holds allowed (total): 0/
hold allowed (daily): 0 / holds per record: 0

Patron category: 'P' (Patron)/Item type: 'BK' / holds allowed (total):
1/ holds allowed (daily): 1 / holds per record 1

3. On the biblio record place a biblio-level hold for patron A (who has patron
category of 'B') and patron B (who has patron category of 'P')

4. Return the 'BK' item (item with item type of 'BK')

5. Notice a popup asking you to confirm the hold by patron A (even
though patrons of category 'B' cannot hold items of item type
'BK')

6. Apply patch and restart memcached and plack

7. Remove both holds on biblio

8. Repeat steps 3-5 but notice instead of a popup for patron A
appearing, a popup asking you to confirm patron B appears

i.e. patron A's bib-level hold is skipped as the issuingrules has been
checked when the item was returned and it has been found that they
cannot reserve an item with that specific itemtype

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.