[Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91301|0                           |1
        is obsolete|                            |

--- Comment #9 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 92252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92252&action=edit
Bug 23172: Fixes to failing Circulation.t and Reserves.t unit tests

This patch adds to the unit test coverage of the new
Koha::Hold->check_if_existing_hold_matches_issuingrules().

In patch two on bug 23172 I added unit test for directly testing the new
subroutine Koha::Hold->check_if_existing_hold_matches_issuingrules().

In this patch I fix the test failures in t/db_dependent/Circulation.t
and t/db_dependent/Reserves.t and add a test to confirm
C4::Circulation->AddReturn() works correctly with
Koha::Hold->check_if_existing_hold_matches_issuingrules().

This is because when an item is returned C4::Circulation->AddReturn() calls
C4::Reserves->CheckReserves()
which in turn calls the aforementioned new subroutine.

So the additional unit tests in this patch check all these subroutines
work correctly together.

Test plan:
1. Apply first two patches and follow their respective test plans

2. Enter Koha shell: sudo koha-shell <instancename>

3. Run (from your koha home directory):
prove t/db_dependent/Circulation.t

Confirm it fails

4. Run:
prove t/db_dependent/Reserves.t

Confirm it fails

5. Apply this patch

6. Repeat steps 3 and 4 and confirm the tests pass

6. Confirm t/db_dependent/Holds.t still passes by repeating step 2 and
then running:
prove t/db_dependent/Holds.t

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.