From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 08:01:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 07:01:51 +0000 Subject: [Koha-bugs] [Bug 24139] I do not know how to obtain or set credentials that will let me log in to use webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Christos, bugzilla is used for bug reporting and documenting enhancement wishes, but as this is a support request, I am closing invalid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 08:04:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 07:04:45 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_24140=5D_I_can=E2=80=99t_clear/dele?= =?utf-8?q?te_holds=2E?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24140 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Kelly, this could be a bug, but it could also be related to your setup. You might want to try the mailing list to help you nail down the problem a bit more first. Some things you could check: - What is the specific error behind the "Internal server error"? You will find the full message in your Plack error logs on the server. - What is the exact version of Koha you are using? - How has it been installed? - And a last idea to check: Do your items have itemtypes set? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 08:07:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 07:07:03 +0000 Subject: [Koha-bugs] [Bug 7711] clear holds statuses and workflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7711 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |nick at bywatersolutions.com Blocks|7065 | --- Comment #1 from Katrin Fischer --- Hi Nick and Kyle, I believe this dates back to a spec from Ian - is development still planned or should we close this? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 [Bug 7065] reserves table needs a primary key -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 08:07:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 07:07:03 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7711 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7711 [Bug 7711] clear holds statuses and workflow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 08:08:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 07:08:41 +0000 Subject: [Koha-bugs] [Bug 24140] I can't clear/delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24140 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|I can’t clear/delete holds. |I can't clear/delete holds Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 10:23:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 09:23:22 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95890|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 95893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95893&action=edit Bug 23974: Add POD for hours_between Add a bit of missing POD whilst we're working in here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 10:23:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 09:23:25 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95891|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 95894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95894&action=edit Bug 23974: Test Notes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 10:23:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 09:23:28 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #23 from Martin Renvoize --- Created attachment 95895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95895&action=edit Bug 23974: Add tests for issue on closed day -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 10:23:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 09:23:31 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #24 from Martin Renvoize --- Created attachment 95896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95896&action=edit Bug 23974: Add test descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 10:23:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 09:23:55 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:14:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 10:14:50 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for other language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:14:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 10:14:54 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for other language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 --- Comment #3 from Jonathan Druart --- Created attachment 95897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95897&action=edit Bug 24137: Fix biblio frameworks install for ru-Ru and uk-UA They both failed with Column 'hidden' cannot be null Test plan: Make sure the 2 sql files can be inserted without errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:15:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 10:15:09 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for other language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:15:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 10:15:13 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for other language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:15:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 10:15:55 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Marc21 bibliographic fails |Marc21 bibliographic fails |to install for other |to install for ru-Ru and |language |uk-UA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:20:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 10:20:50 +0000 Subject: [Koha-bugs] [Bug 24107] Returns.pl fetches the same item from the database multiple times In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24107 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23463 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 11:20:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 10:20:50 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24107 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24107 [Bug 24107] Returns.pl fetches the same item from the database multiple times -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 12:02:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 11:02:40 +0000 Subject: [Koha-bugs] [Bug 24141] New: Can we become an OpanBadges issuer? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24141 Bug ID: 24141 Summary: Can we become an OpanBadges issuer? Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All URL: https://openbadges.org/about/participating-issuers/ OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Release tools Assignee: jonathan.druart at bugs.koha-community.org Reporter: martin.renvoize at ptfs-europe.com I'm contemplating various approaching to trying to encourage some new contributors for Koha. What do people think about the idea of creating a few open badges to reward people for their contributions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 12:19:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 11:19:57 +0000 Subject: [Koha-bugs] [Bug 24127] Using the dropdown option of Shelving Location as a search choice retrieves no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #3 from Nick Clemens --- Hi Myka, The reason we looked towards removal is because we didn't see this as the usual way to search for shelving locations and shouldn't be the standard. While the search does work under ES, it also works via ccl, so even without the patch one can search for "location:GEN" and achieve the same results. In general, however, the item search allows for a very specific search like this and would be the preference I think. Let me know if that sounds reasonable to you. -Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 12:27:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 11:27:51 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Nick Clemens --- Hi Myka, This is due to the 'QueryAutoTruncate' system preference. This adds a wildcard to all searches if enabled. Under ES if this is not enabled then partial word searches don't work - i.e. rain <> raining, so in general we do enable this If you perform the search as a phrase you can workaround the truncation: biblionumber:"19" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 12:39:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 11:39:59 +0000 Subject: [Koha-bugs] [Bug 24107] returns.pl fetches the same item from the database multiple times In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24107 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Returns.pl fetches the same |returns.pl fetches the same |item from the database |item from the database |multiple times |multiple times CC| |tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 12:48:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 11:48:19 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 12:48:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 11:48:33 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 12:48:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 11:48:36 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89059|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 95898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95898&action=edit Bug 19288: Don't show patron info for item level holds on details.pl unless hold is waiting This persists after bug 20948 - we can still display patron information even if this patron is not the one who will receive the item upon checkin. The holds tab can give an overview of holds and information - I think on the details page the only info we need is whether there might be a item level hold, not who it is for To test: 1 - Place an item level hold for delivery at a branch not matching home branch of item 2 - Place a record level hold for delivery at homebranch of item placed on hold above 3 - Enable LocalHoldsPriority with 'pickup library' matches the item's 'home library' 4 - View the details for the page, it says the item has a hold for the patron with an item level hold 5 - Check in the item, the hold triggered is for the next available patron, ignore the hold 6 - Apply patch 7 - Check details page, 'There is an item-level hold (priority=1)' with no patron info 8 - Check in, next available hold is still the one triggered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 12:54:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 11:54:26 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 12:54:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 11:54:43 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #14 from Nick Clemens --- Sorry, forgot to obsolete a patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:10 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:13 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #5 from Jonathan Druart --- Created attachment 95899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95899&action=edit Bug 23463: Replace SearchItemsByField by SearchItems The subroutine SearchItemsByField is only called once and can be replaced easily with SearchItems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:16 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #6 from Jonathan Druart --- Created attachment 95900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95900&action=edit Bug 23463: Remove uneeded SearchItemsByField subroutine It is no longer used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:19 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #7 from Jonathan Druart --- Created attachment 95901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95901&action=edit Bug 23463: fix for testbuilder - set default value items.damaged=0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:24 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #8 from Jonathan Druart --- Created attachment 95902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95902&action=edit Bug 23463: Replace AddItem calls with Koha::Item->store -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:28 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #9 from Jonathan Druart --- Created attachment 95903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95903&action=edit Bug 23463: Remove _set_defaults_for_add _set_defaults_for_add is no longer needed as it is handled by dbic and koha::object->store -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:31 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #10 from Jonathan Druart --- Created attachment 95904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95904&action=edit Bug 23463: Replace _set_derived_columns_for_add Remove the unique call to _set_derived_columns_for_add Even if design to deal with other values it only dealts with cn_sort -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:34 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #11 from Jonathan Druart --- Created attachment 95905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95905&action=edit Bug 23463: AddItem removing We are done with AddItem, only need to log and index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:38 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #12 from Jonathan Druart --- Created attachment 95906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95906&action=edit Bug 23463: Replace ModItem with Koha::Item->store Starting to replace the ModItem calls with Koha::Item->store -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:42 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #13 from Jonathan Druart --- Created attachment 95907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95907&action=edit Bug 23463: remove trivial UpdateHoldingbranch sub We do not need this subroutine, moving it where it is used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:46 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #14 from Jonathan Druart --- Created attachment 95908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95908&action=edit Bug 23463: Move plugin hook >From C4::Items to Koha::Item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:50 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #15 from Jonathan Druart --- Created attachment 95909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95909&action=edit Bug 23463: _set_derived_columns_for_mod was only used for cn_sort Same as _set_defaults_for_add -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:53 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #16 from Jonathan Druart --- Created attachment 95910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95910&action=edit Bug 23463: _do_column_fixes_for_mod dealt with integer location and timestamp moved That's done in Koha::Item->store, and Koha::Object->store for integers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:04:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:04:56 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #17 from Jonathan Druart --- Created attachment 95911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95911&action=edit Bug 23463: Remove _mod_item_dates We did not do anything useful here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:00 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #18 from Jonathan Druart --- Created attachment 95912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95912&action=edit Bug 23463: Remove ModItem There should not be any calls left -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:04 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #19 from Jonathan Druart --- Created attachment 95913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95913&action=edit Bug 23463: Remove DelItem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:08 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #20 from Jonathan Druart --- Created attachment 95914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95914&action=edit Bug 23463: Remove DelItemCheck and ItemSafeToDelete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:12 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #21 from Jonathan Druart --- Created attachment 95915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95915&action=edit Bug 23463: Remove no longer needed subs related to default values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:15 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #22 from Jonathan Druart --- Created attachment 95916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95916&action=edit Bug 23463: Fix CancelReceipt.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:18 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #23 from Jonathan Druart --- Created attachment 95917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95917&action=edit Bug 23463: Fix failing tests And adding a FIXME about discard_changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:22 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #24 from Jonathan Druart --- Created attachment 95918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95918&action=edit Bug 23463: Getting less item-level_itypes warnings (?) So, we get less warnings. I do not really understand why... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:27 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #25 from Jonathan Druart --- Created attachment 95919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95919&action=edit Bug 23463: Fix AutomaticItemModificationByAge.t We do not want to log if nothing changed How could we do that better? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:30 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #26 from Jonathan Druart --- Created attachment 95920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95920&action=edit Bug 23463: update permanent_location if location has been updated This change to Koha::Item->store seems correct here, but tests from /db_dependent/Items.t is failing now. Adjusting them to make them pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:34 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #27 from Jonathan Druart --- Created attachment 95921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95921&action=edit Bug 23463: Fix items.cn_source vs cn_source -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:37 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #28 from Jonathan Druart --- Created attachment 95922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95922&action=edit Bug 23463: build cn_sort only if needed No need to calculate cn_sort if not dirty when we store -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:05:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:05:41 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #29 from Jonathan Druart --- Created attachment 95923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95923&action=edit Bug 23463: Replace recently added occurrences Few occurrences have been added since this patchset has been originaly written -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:08:12 +0000 Subject: [Koha-bugs] [Bug 24141] Can we become an OpanBadges issuer? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24141 --- Comment #1 from Martin Renvoize --- https://badgr.io/public/badges/8d5x9P7dR4atTnQ9VH3zdA is an example of one I just setup as a little test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:17:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:17:41 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #30 from Katrin Fischer --- Comment on attachment 95922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95922 Bug 23463: build cn_sort only if needed Review of attachment 95922: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23463&attachment=95922) ----------------------------------------------------------------- ::: Koha/Item.pm @@ +74,5 @@ > $self->itype($self->biblio->biblioitem->itemtype); > } > > + my %updated_columns = $self->_result->get_dirty_columns; > + if ( exists $updated_columns{itemcallnumber} ) { We should also update the cn_sort if cn_source was changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:55:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:55:10 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 --- Comment #18 from Marcel de Rooy --- Nick, does it depend on 20948 now ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:56:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:56:37 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20948 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:56:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:56:37 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 [Bug 19288] Holds placed on a specific item after a next available hold will show varied results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 13:57:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 12:57:03 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 --- Comment #19 from Nick Clemens --- (In reply to Marcel de Rooy from comment #18) > Nick, does it depend on 20948 now ? Yes :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:27:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 13:27:16 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:27:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 13:27:20 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #2 from Jonathan Druart --- Created attachment 95924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95924&action=edit Bug 24008: Display a warning message when deleting a patron with outstanding credits So far nothing is displayed if a librarian removes patron with outstanding credits. Note that outstanding debits blocks the deletion. Test plan: - Create a patron with outstanding credit - Create a patron with outstanding debits - Delete the 2 patrons => With credit - You get a warning but do not block the deletion => With debits - You get a warning message that blocks the deletion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:32:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 13:32:33 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #31 from Jonathan Druart --- Created attachment 95925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95925&action=edit Bug 23463: cn_sort needs to be updated if cn_source changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:32:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 13:32:48 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #32 from Jonathan Druart --- (In reply to Katrin Fischer from comment #30) > Comment on attachment 95922 [details] [review] > Bug 23463: build cn_sort only if needed > > Review of attachment 95922 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Item.pm > @@ +74,5 @@ > > $self->itype($self->biblio->biblioitem->itemtype); > > } > > > > + my %updated_columns = $self->_result->get_dirty_columns; > > + if ( exists $updated_columns{itemcallnumber} ) { > > We should also update the cn_sort if cn_source was changed. Indeed, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:33:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 13:33:30 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 14:36:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 13:36:40 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #21 from Katrin Fischer --- Can this PLEASE be finally backported to 18.11 too? This bug means the serials module is unsable for everyone not speaking/using English. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 14:08:04 +0000 Subject: [Koha-bugs] [Bug 24142] New: Count of search results does not match displayed records. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24142 Bug ID: 24142 Summary: Count of search results does not match displayed records. Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: rogan.hamby at gmail.com QA Contact: testopia at bugs.koha-community.org My apologies if this is a duplicate but after searching I could not find it already in bugzilla. When doing a standard search the search results count does not match the number of records shown if a record is hidden due to preferences. For example, I have 5 records that return with a keyword search of 'Hobbit'. One has no items. If I had an item to the item-less record with a CCODE set to be hidden with OpacHiddenItems the record is now correctly hidden but the search count continues to say "Your search returned 5 results." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 15:46:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 14:46:02 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Nick Clemens --- With this patch I can save the subscription, however, if I enter 'f' then the number of issues is NULLed, so I can have a subscription with no length or end date, which should be impossible. I think we must have some validation of the form to prevent non-numeric values entered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:01:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 15:01:14 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #4 from Liz Rea --- It appears that this can cause Koha to hang looking for all the null barcode items when processing holds, enough retries and all of the plack processes get eaten up. It doesn't happen for every library, however, so it must be related to a system preference, which I have not tracked down (yet). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:12:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 15:12:19 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:17:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 15:17:44 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 15:17:46 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 --- Comment #2 from Owen Leonard --- Created attachment 95926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95926&action=edit Bug 24124: Cannot select authorities in batch deletion tool in Chrome This patch adds some inline CSS to force clearing on some elements in the forms for batch record modification and deletion. The problem with selecting the "Authorities" radio button stemmed from the fact that non-clearing floats caused elements to invisibly overlap in the form. To test, apply the patch and test both batch record modification and batch record deletion. Upon selecting the "Authorities" radio button in each case the "Select a list of records" tab should disappear. Selecting the "Biblios" option should re-display the tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:28:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 15:28:00 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 --- Comment #12 from Owen Leonard --- It works for me if I change the input type to "number." I wouldn't have expected that to be necessary, but it's not an incorrect change to make. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:51:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 15:51:02 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- Pedro this patch looks good and I'm ready so sign off on it, but it needs a good commit message. Please look at the guidelines here: https://wiki.koha-community.org/wiki/Commit_messages Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:54:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 15:54:14 +0000 Subject: [Koha-bugs] [Bug 16700] Quick spine label creator: Make css configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16700 --- Comment #1 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:56:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 15:56:49 +0000 Subject: [Koha-bugs] [Bug 17768] spinelabel.css should be user editable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17768 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Marjorie Barry-Vila --- *** This bug has been marked as a duplicate of bug 16700 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 16:56:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 15:56:49 +0000 Subject: [Koha-bugs] [Bug 16700] Quick spine label creator: Make css configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16700 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #2 from Marjorie Barry-Vila --- *** Bug 17768 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:06:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:06:11 +0000 Subject: [Koha-bugs] [Bug 24143] New: buildQuery should disable Query* on identifier search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143 Bug ID: 24143 Summary: buildQuery should disable Query* on identifier search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org Currently, QueryWeightFields, QueryFuzzy, QueryStemming, QueryAutoTruncate are disabled in buildQuery in several cases: - Date of Publication - Date of Acquisition - ISBN,ISSN,Standard Number Those modifiers should also be disabled when searching on identifiers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:07:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:07:15 +0000 Subject: [Koha-bugs] [Bug 24141] Can we become an OpanBadges issuer? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24141 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:08:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:08:06 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org --- Comment #3 from AspenCat Team --- This would be helpful for AspenCat libraries as well. They currently have to manually calculate and add back in the fine total. - Bob Bennhoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:08:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:08:21 +0000 Subject: [Koha-bugs] [Bug 24143] buildQuery should disable Query* on identifier search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143 --- Comment #1 from Matthias Meusburger --- Created attachment 95927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95927&action=edit Bug 24143: Disable QueryXXX when searching on a identifier. Using the ident or identifier-standard index should not involve any of the following features: - QueryAutoTruncate - QueryFuzzy - QueryStemming - QueryWeightFields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:08:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:08:37 +0000 Subject: [Koha-bugs] [Bug 24143] buildQuery should disable Query* on identifier search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:08:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:08:48 +0000 Subject: [Koha-bugs] [Bug 24143] buildQuery should disable Query* on identifier search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:11:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:11:55 +0000 Subject: [Koha-bugs] [Bug 24144] New: regressions.t tests have not been updated after bug 23836 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Bug ID: 24144 Summary: regressions.t tests have not been updated after bug 23836 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 23836 t/db_dependent/www/regressions.t .. # Failed test '302 for biblionumber with matching URI' # at t/db_dependent/www/regressions.t line 105. # got: '404' # expected: '302' # Failed test '302 for itemnumber with matching URI' # at t/db_dependent/www/regressions.t line 109. # got: '404' # expected: '302' # Failed test '302 for biblionumber with matching URI' # at t/db_dependent/www/regressions.t line 120. # got: '404' # expected: '302' # Failed test '302 for itemnumber with matching URI' # at t/db_dependent/www/regressions.t line 124. # got: '404' # expected: '302' # Failed test '302 for biblionumber with matching URI' # at t/db_dependent/www/regressions.t line 135. # got: '404' # expected: '302' # Failed test '302 for itemnumber with matching URI' # at t/db_dependent/www/regressions.t line 139. # got: '404' # expected: '302' # Looks like you failed 6 tests of 36. t/db_dependent/www/regressions.t .. 1/1 # Failed test 'open redirection vulnerabilities in tracklinks' # at t/db_dependent/www/regressions.t line 141. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:13:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:13:55 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:13:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:13:58 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 --- Comment #1 from Jonathan Druart --- Created attachment 95928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95928&action=edit Bug 24144: (bug 23836 follow-up) Fix regressions.t tests Bug 24144 changes the behavior for tracklinks.pl but did not adjust the tests. We must then expect 404 if the pref is turned off. Also mock_preference cannot work (we are hitting the web server and so need to set the value in DB and flush the L1 caches) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:23:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:23:27 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95928|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 95929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95929&action=edit Bug 24144: (bug 23836 follow-up) Fix regressions.t tests Bug 23836 changes the behavior for tracklinks.pl but did not adjust the tests. We must then expect 404 if the pref is turned off. Also mock_preference cannot work (we are hitting the web server and so need to set the value in DB and flush the L1 caches) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:23:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:23:54 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Thanks for the quick fix Jonathan, Passing QA and Pushing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:24:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:24:02 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:28:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:28:29 +0000 Subject: [Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:50:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:50:31 +0000 Subject: [Koha-bugs] [Bug 24145] New: Auth.t is failing because of wrong mocked ->param Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Bug ID: 24145 Summary: Auth.t is failing because of wrong mocked ->param Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org t/db_dependent/Auth.t .. 1/22 Un-mocked method 'url()' called at /kohadevbox/koha/C4/Auth.pm line 1223. Un-mocked method 'redirect()' called at /kohadevbox/koha/C4/Auth.pm line 1227. A context appears to have been destroyed without first calling release(). Based on $@ it does not look like an exception was thrown (this is not always a reliable test) This is a problem because the global error variables ($!, $@, and $?) will not be restored. In addition some release callbacks will not work properly from inside a DESTROY method. Here are the context creation details, just in case a tool forgot to call release(): File: t/db_dependent/Auth.t Line: 74 Tool: Test::More::subtest Cleaning up the CONTEXT stack... # Test ended with extra hubs on the stack! # Looks like you planned 22 tests but ran 1. t/db_dependent/Auth.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 21/22 subtests Test Summary Report ------------------- t/db_dependent/Auth.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 22 tests but ran 1. Files=1, Tests=1, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.54 cusr 0.24 csys = 1.80 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:50:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:50:38 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22543 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:52:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:52:34 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:52:38 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 --- Comment #1 from Jonathan Druart --- Created attachment 95930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95930&action=edit Bug 24145: (bug 22543 follow-up) Fix Auth.t Auth.t is failing because of: 1. recent changes from bug 22543 and 2. wrong mocked CGI->param in tests Without this patch we hit the exit statement that breaks the tests with the following error: t/db_dependent/Auth.t .. 1/22 Un-mocked method 'url()' called at /kohadevbox/koha/C4/Auth.pm line 1223. Un-mocked method 'redirect()' called at /kohadevbox/koha/C4/Auth.pm line 1227. A context appears to have been destroyed without first calling release(). Based on $@ it does not look like an exception was thrown (this is not always a reliable test) This is a problem because the global error variables ($!, $@, and $?) will not be restored. In addition some release callbacks will not work properly from inside a DESTROY method. Here are the context creation details, just in case a tool forgot to call release(): File: t/db_dependent/Auth.t Line: 74 Tool: Test::More::subtest Cleaning up the CONTEXT stack... # Looks like you planned 22 tests but ran 1. t/db_dependent/Auth.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 21/22 subtests Test Summary Report ------------------- t/db_dependent/Auth.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 22 tests but ran 1. Files=1, Tests=1, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.54 cusr 0.24 csys = 1.80 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:55:36 +0000 Subject: [Koha-bugs] [Bug 23783] Show languages from MARC21 field 041 in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 17:55:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 16:55:39 +0000 Subject: [Koha-bugs] [Bug 23783] Show languages from MARC21 field 041 in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94965|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 95931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95931&action=edit Bug 23783: Show languages from MARC21 field 041 in OPAC This copies the changes made in bug 20364 for the staff interface to the OPAC. Some slight changes have been made in comparison: - OPAC uses the class "separator" for the characters that are used between repeatable tags. "sep" as used in the original patch set has some CSS rules attached to it that break display, so it makes double sense to change it. - We revently removed ending . from the display in OPAC - so it's done here too. To test: 1) Apply patch 2) Do a search in the OPAC and check the results look correct 3) Check some biblio detail pages and verify that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 18:02:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 17:02:03 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95930|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 95932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95932&action=edit Bug 24145: (bug 22543 follow-up) Fix Auth.t Auth.t is failing because of: 1. recent changes from bug 22543 and 2. wrong mocked CGI->param in tests Without this patch we hit the exit statement that breaks the tests with the following error: t/db_dependent/Auth.t .. 1/22 Un-mocked method 'url()' called at /kohadevbox/koha/C4/Auth.pm line 1223. Un-mocked method 'redirect()' called at /kohadevbox/koha/C4/Auth.pm line 1227. A context appears to have been destroyed without first calling release(). Based on $@ it does not look like an exception was thrown (this is not always a reliable test) This is a problem because the global error variables ($!, $@, and $?) will not be restored. In addition some release callbacks will not work properly from inside a DESTROY method. Here are the context creation details, just in case a tool forgot to call release(): File: t/db_dependent/Auth.t Line: 74 Tool: Test::More::subtest Cleaning up the CONTEXT stack... # Looks like you planned 22 tests but ran 1. t/db_dependent/Auth.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 21/22 subtests Test Summary Report ------------------- t/db_dependent/Auth.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 22 tests but ran 1. Files=1, Tests=1, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.54 cusr 0.24 csys = 1.80 CPU) Result: FAIL Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 18:03:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 17:03:00 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Thanks for the quick fix Jonathan, Passing QA and Pushing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 18:03:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 17:03:05 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 18:07:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 17:07:39 +0000 Subject: [Koha-bugs] [Bug 24139] I do not know how to obtain or set credentials that will let me log in to use webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24139 --- Comment #2 from Owen Leonard --- Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 18:19:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 17:19:32 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 18:19:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 17:19:33 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 18:19:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 17:19:35 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 18:19:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 17:19:37 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 19:30:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 18:30:31 +0000 Subject: [Koha-bugs] [Bug 7012] Limit to available does not exclude in-transit items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012 --- Comment #5 from Daniel Gaghan --- It looks like this issue is also listing items that are on hold as available in addition to in-transit. Does anyone know if this was a recent change or did it originally include on hold items? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 19:30:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 18:30:54 +0000 Subject: [Koha-bugs] [Bug 24109] Elasticsearch - Advanced search limit by shelving location uses AND instead of OR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 19:33:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 18:33:19 +0000 Subject: [Koha-bugs] [Bug 24109] Elasticsearch - Advanced search limit by shelving location uses AND instead of OR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 19:44:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 18:44:36 +0000 Subject: [Koha-bugs] [Bug 24146] New: Paying Accruing Fines prior to return causes another accruing fine when returned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Bug ID: 24146 Summary: Paying Accruing Fines prior to return causes another accruing fine when returned Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: nick at bywatersolutions.com In 19.05, when an accruing fine is paid prior to checking in the item, the fine will get re-accessed when the item is returned. This is caused by bug 22521 looking at the diff to this bug Lines 520-565 sub UpdateFine { it looks like we have changed the way Koha is checking for these fines and therefore reassessing a fine as there isn't one there anymore, as it has been paid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 19:44:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 18:44:45 +0000 Subject: [Koha-bugs] [Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 --- Comment #5 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 20:22:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 19:22:36 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #1 from Nick Clemens --- Specifically: 538 "SELECT * FROM accountlines 539 WHERE borrowernumber=? AND 540 (( accounttype IN ('F','M') AND amountoutstanding<>0 ) OR 541 accounttype = 'FU' )" 542 ); To: 523 my $overdues = Koha::Account::Lines->search( 524 { 525 borrowernumber => $borrowernumber, 526 accounttype => [ 'OVERDUE', 'M' ], 527 amountoutstanding => { '<>' => 0 } 528 } In the first it is a closed fine more than 0 OR an accruing fine After the patch it must be greater than 0, so if someone pays off an accruing fine it will not be found. Could we possibly just search by issue_id? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 20:35:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 19:35:07 +0000 Subject: [Koha-bugs] [Bug 21917] Payment type should not show on Write off selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21917 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:10:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:10:45 +0000 Subject: [Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134 Carlos Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clopez at dml.vic.edu.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:12:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:12:06 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Carlos Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clopez at dml.vic.edu.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:52:18 +0000 Subject: [Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:52:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:52:27 +0000 Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:52:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:52:52 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |andreas.jonsson at kreablo.se |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:53:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:53:18 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:53:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:53:36 +0000 Subject: [Koha-bugs] [Bug 23029] OPAC Authorities Search. Internal Server Error. Free-floating subdivisions imported from LOC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23029 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:53:59 +0000 Subject: [Koha-bugs] [Bug 24117] Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |pjamorim91 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:55:36 +0000 Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |ian at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:55:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:55:48 +0000 Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when --itemtypes are specified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |liz at bywatersolutions.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:55:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:55:59 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:56:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:56:09 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:56:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:56:27 +0000 Subject: [Koha-bugs] [Bug 23344] Branch Transfer Limits - Warn if sysprefs are not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23344 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at hypern |ity.org |ova.fi CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:56:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:56:43 +0000 Subject: [Koha-bugs] [Bug 23343] Koha::Library->selected() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23343 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at hypern |ity.org |ova.fi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:56:55 +0000 Subject: [Koha-bugs] [Bug 23342] Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at hypern |ity.org |ova.fi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:57:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:57:06 +0000 Subject: [Koha-bugs] [Bug 22684] Make Acquisition::Basket->bookseller match the code guidlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22684 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:57:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:57:17 +0000 Subject: [Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:57:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:57:31 +0000 Subject: [Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to ReservesControlBranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:57:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:57:52 +0000 Subject: [Koha-bugs] [Bug 15729] SIP server allows checkin of reserved item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bc at interleaf.ie |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:58:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:58:32 +0000 Subject: [Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |italo.barbosa.brasileiro at gm |ity.org |ail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:59:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:59:40 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 2 23:59:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Dec 2019 22:59:54 +0000 Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 01:32:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 00:32:10 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Nightly Build Bot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90319|0 |1 is obsolete| | --- Comment #18 from Nightly Build Bot --- Created attachment 95933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95933&action=edit Bug 17108- Automatic debian/control updates (stable/19.05.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 02:10:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 01:10:36 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #10 from Arthur Suzuki --- Created attachment 95934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95934&action=edit Bug 23732: Renamed TODOs and added translation capabilities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 02:11:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 01:11:03 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 02:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 01:20:10 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Attachment #92774|1 |0 is patch| | Attachment #92774|0 |1 is obsolete| | --- Comment #77 from Arthur Suzuki --- Comment on attachment 92774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92774 Bug 7376 Transfer limits should be checked at check-in Hi Olivier, Hope if it's ok if I obsolete your patch since Lari has provided a newer version with some correction? That way it makes it easier to test by anyone using sandboxes :) Arthur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 03:02:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 02:02:42 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #78 from Arthur Suzuki --- last patch still doesn't apply anyway... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 06:58:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 05:58:32 +0000 Subject: [Koha-bugs] [Bug 21375] NCIP service for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21375 --- Comment #1 from Amit Gupta --- Sponsored by RapidRadio Solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 08:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 07:08:12 +0000 Subject: [Koha-bugs] [Bug 21375] NCIP service for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21375 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- Is this related to https://github.com/ranginui/ncip-server-chris ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 08:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 07:13:57 +0000 Subject: [Koha-bugs] [Bug 21375] NCIP service for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21375 --- Comment #3 from Amit Gupta --- (In reply to David Cook from comment #2) > Is this related to https://github.com/ranginui/ncip-server-chris ? Yes, I have used the base code of Bywater (https://github.com/bywatersolutions/ncip-server) and created some more messages supported by the NCIP protocol with the help of RapidRadio one of the RFID vendor. Soon will submit the patch to Kyle hall/Bywater (NCIP Git hub). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 09:39:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 08:39:11 +0000 Subject: [Koha-bugs] [Bug 23029] OPAC Authorities Search. Internal Server Error. Free-floating subdivisions imported from LOC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 09:39:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 08:39:18 +0000 Subject: [Koha-bugs] [Bug 23029] OPAC Authorities Search. Internal Server Error. Free-floating subdivisions imported from LOC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 09:39:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 08:39:37 +0000 Subject: [Koha-bugs] [Bug 23029] OPAC Authorities Search. Internal Server Error. Free-floating subdivisions imported from LOC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23029 --- Comment #2 from Jonathan Druart --- Comment on attachment 95354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95354 Bug 23029: Remove "Truncated incorrect DOUBLE value: '01e'" from marcrecord2csv.t Wrong bug report, that was for bug 24029. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 09:57:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 08:57:25 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 --- Comment #6 from Jonathan Druart --- Hi Nick, Since we are using Koha::Subscription for adding a subscription I guess the problem already exists (bug 22812). I would consider it out of the scope of this bug. Form validation is not perfect in Koha and the effort is much bigger. See also bug 24010 that is trying to deal with enforcing integer validation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 10:00:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 09:00:19 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 --- Comment #13 from Jonathan Druart --- Does it block the form submission? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 10:00:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 09:00:45 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95847|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 95935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95935&action=edit Bug 24010: Enforce integer values for staffdisplaycount and opacdisplaycount (second try) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 10:11:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 09:11:19 +0000 Subject: [Koha-bugs] [Bug 23066] Add foreign key for issues tables to branches table for branchcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23066 --- Comment #8 from David Cook --- (In reply to Marcel de Rooy from comment #7) > Please send a mail to the list asking for further feedback from the > community before adding this constraint. It is obvious at first sight, but > why didn't we add it years ago then? Anything to do with keeping the old > branchcode in old issue records or so? A search of git suggests it might have just been an oversight? In master kohastructure.sql we see the following for the branchcode column: `branchcode` varchar(10) default NULL, -- foreign key, linking to the branches table for the location the item was checked out However, there is no foreign key. It appears the comment was added by commit 91b5a09c6ce (Sun Aug 2011) but even then there was no foreign key there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:11:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:11:35 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:11:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:11:39 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #24 from Jonathan Druart --- Created attachment 95936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95936&action=edit Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:11:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:11:43 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #25 from Jonathan Druart --- Created attachment 95937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95937&action=edit Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 Confirm the holds (to mark them waiting) 1/ Use the 5 items and delete them in a batch. => delete of item from B1 is blocked on first screen => delete of items from B2 is *not* blocked on first screen => delete of item from B3 is blocked on first screen => delete of item from B4 is *not* blocked Note that you can only select items from B2 and B4 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:11:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:11:46 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #26 from Jonathan Druart --- Created attachment 95938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95938&action=edit Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:11:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:11:50 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #27 from Jonathan Druart --- Created attachment 95939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95939&action=edit Bug 8132: Adding message when deleting from the UI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:13:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:13:03 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23463 URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_8132 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #28 from Jonathan Druart --- Here is a try to fix this long standing issue. It is based on top of bug 23463. A remote branch is available for testing on my gitlab repop: https://gitlab.com/joubu/Koha/commits/bug_8132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:13:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:13:03 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 [Bug 8132] Batch delete tool deletes items with holds on them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:50:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:50:47 +0000 Subject: [Koha-bugs] [Bug 24117] Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |Failed QA --- Comment #3 from Jonathan Druart --- Hi Pedro, As _debar_user_on_return is only called once I would suggest you to pass $item instead of $item_unblessed. It will avoid to pass yet another parameter to this subroutine. Also you will need to provide a test plan in the commit message, as well as a better commit title https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:52:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:52:50 +0000 Subject: [Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:52:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:52:53 +0000 Subject: [Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #2 from Devinim --- Created attachment 95940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95940&action=edit Bug 22774: New systempreferences for suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:54:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:54:05 +0000 Subject: [Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #3 from Devinim --- Created attachment 95941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95941&action=edit Bug 22774: Limit Purchase Suggestion in a specified Time period Test plan: 1- Apply this patch 2- Run updatedatabase.pl 3- By default you may have max. 3 suggestions in last 30 days. 4- Go to purchase suggestion page from OPAC 5- If you exceed limits of suggestions in step 3 you will not able to add new suggestions. 6- If you want to change the limits go to systempreferences and change MaxTotalSuggestions and NumberOfSuggestionDays parameters. 7- Test again from step 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:57:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:57:44 +0000 Subject: [Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 11:57:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 10:57:47 +0000 Subject: [Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41033|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 95942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95942&action=edit Bug 14543: Order lines updated that have a tax rate not in gist will have tax rate set to 0! If the tax rate for a given order line has been removed from the system preference gist, that tax rate will show in the pulldown as 0. If a librarian then saves the order line the original tax rate will be overwritten with 0%! Test Plan: 1) Find an order line 2) Remove the tax rate set for that order line from the syspref gist 3) Edit the order line 4) Note the tax rate is 0 5) Apply this patch 6) Edit the order line 7) Note the tax rate now displays with a warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:00:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 11:00:39 +0000 Subject: [Koha-bugs] [Bug 23388] Make system preferences links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart --- What's next? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:09:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 11:09:12 +0000 Subject: [Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |Failed QA --- Comment #8 from Jonathan Druart --- Please adjust the tests. t/db_dependent/Members/IssueSlip.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:10:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 11:10:31 +0000 Subject: [Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:12:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 11:12:48 +0000 Subject: [Koha-bugs] [Bug 18414] Allow to use other select criteria with delete_patrons.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:21:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 11:21:47 +0000 Subject: [Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95942|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 95943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95943&action=edit Bug 14543: Order lines updated that have a tax rate not in gist will have tax rate set to 0! If the tax rate for a given order line has been removed from the system preference gist, that tax rate will show in the pulldown as 0. If a librarian then saves the order line the original tax rate will be overwritten with 0%! Test Plan: 1) Find an order line 2) Remove the tax rate set for that order line from the syspref gist 3) Edit the order line 4) Note the tax rate is 0 5) Apply this patch 6) Edit the order line 7) Note the tax rate now displays with a warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 12:39:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 11:39:24 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #4 from Hugo Agud --- I am checking the patch and it is working fine, BUT I have realized that fines only applies if Fine grace period is applied... it is mandatory add a value, independtl of the syspref of grace period. from my point of view it is logical that you need to add a value, but as it is not a mandatory field perhaps it creates confussion? On the other hand I do not know if this issue is related with this bug or not, I am ready to sign it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:01:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 12:01:30 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #22 from Katrin Fischer --- (In reply to Katrin Fischer from comment #21) > Can this PLEASE be finally backported to 18.11 too? This bug means the > serials module is unsable for everyone not speaking/using English. I am sorry, but is caused by changes for Mana - but there is no Mana in 18.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:41:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 12:41:02 +0000 Subject: [Koha-bugs] [Bug 21818] Don't use AutoCommit flag in stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21818 --- Comment #1 from Fridolin SOMERS --- Still valid with 19.11.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:41:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 12:41:40 +0000 Subject: [Koha-bugs] [Bug 22481] Koha::Uploader does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22481 --- Comment #3 from Fridolin SOMERS --- Still valid with 19.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:55:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 12:55:23 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #12 from Katrin Fischer --- Created attachment 95944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95944&action=edit Bug 23181: [18.11] Extend unit tests Run t/db_dependent/Accounts.t Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:55:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 12:55:53 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #13 from Katrin Fischer --- Had to change the tests slightly to make them pass on 18.11 - attaching patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:58:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 12:58:49 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Katrin Fischer --- Found it in 18.11.10: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=0b9bd169194476a8a33ef61e1ee82b2f0839c34a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 13:59:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 12:59:04 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00,19.05.03 |19.11.00,19.05.03,18.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 14:17:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 13:17:05 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #5 from Jonathan Druart --- Hugo, this patch is only affecting suspension duration for patrons (debarment). It should not affect the calculation of fines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:22:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 14:22:45 +0000 Subject: [Koha-bugs] [Bug 24147] New: Objects.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24147 Bug ID: 24147 Summary: Objects.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Not confirmed yet, bug on the newly created job Koha_Master_D9_MDB_Latest, there is the following failure (run 2): koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' koha_1 | # at t/db_dependent/Koha/Objects.t line 145. koha_1 | # got: 'dxdYyUDoA' koha_1 | # expected: 'hJnosHQGlA' koha_1 | koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' koha_1 | # at t/db_dependent/Koha/Objects.t line 146. koha_1 | # got: 'hJnosHQGlA' koha_1 | # expected: 'dxdYyUDoA' koha_1 | koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' koha_1 | # at t/db_dependent/Koha/Objects.t line 151. koha_1 | # got: 'dxdYyUDoA' koha_1 | # expected: 'hJnosHQGlA' koha_1 | koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' koha_1 | # at t/db_dependent/Koha/Objects.t line 152. koha_1 | # got: 'hJnosHQGlA' koha_1 | # expected: 'dxdYyUDoA' koha_1 | # Looks like you failed 4 tests of 8. koha_1 | koha_1 | # Failed test 'search_related' koha_1 | # at t/db_dependent/Koha/Objects.t line 153. koha_1 | # Looks like you failed 1 test of 17. koha_1 | [19:23:01] t/db_dependent/Koha/Objects.t I do not recreate it locally, even after several restart of the db container. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:25:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 14:25:53 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #11 from Arthur Suzuki --- When backporting on 18.11 I got this error (when only circulation used): Template process failed: undef error - Can't call method "description" on an undefined value at /home/koha/src/Koha/Template/Plugin/Categories.pm line 33. To debug with : https://wiki.koha-community.org/wiki/User:Victor_Grousset_-_tuxayo:Debugging#print_a_stack_backtrace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:43:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 14:43:19 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95886|0 |1 is obsolete| | --- Comment #6 from Hugo Agud --- Created attachment 95945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95945&action=edit Bug 24138: Move the calculation out of the sub No changes expected here. For the next patch we are going to need to add test and calculate the new debarment date. To ease the writing of these tests the calculation is moved out of the existing subroutine. Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:43:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 14:43:22 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95887|0 |1 is obsolete| | --- Comment #7 from Hugo Agud --- Created attachment 95946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95946&action=edit Bug 24138: Fix calculation of suspension days when a limit is set If there is a limit for the number of suspension days (maxsuspensiondays), the calculation is wrong. We are reducing the number of days before taking into account the suspension charging interval. For instance, a checkin is 1 year late and the circ rules are defined to charge 7 days every 15 days. It results in 365 * 7 / 15 days of suspension => 170 days Before this patch the calculation was: 365 * 7 limited to 333, 333 / 15 => 22 days Test plan: Given the examples in the commit messages and the description of the bug report, setup complex circulation rules and confirm that the debarment dates are calculated correctly Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 15:43:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 14:43:38 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:03:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:03:31 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:03:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:03:35 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90914|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 95947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95947&action=edit Bug 21761: Call set + store as update Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:06:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:06:50 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > To investigate: > > + $itemtype = $builder->build_object( { class => 'Koha::ItemTypes' }); > + $itemtype->update({ notforloan => "" }); > > These two lines will warn "Argument "" isn't numeric in numeric eq (==)" I did not manage to remove this warning. However it highlights a misuse: setting a string to an integer field. As we are going to deal in ->store I think that's fine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:23:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:23:34 +0000 Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #10 from Cori Lynn Arnold --- Created attachment 95948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95948&action=edit Bug 17268: Advanced cataloging editor - rancor - macros are lost when browser storage cleared First pass at api code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:29:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:29:11 +0000 Subject: [Koha-bugs] [Bug 24148] New: black magic in Circulation/Returns. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148 Bug ID: 24148 Summary: black magic in Circulation/Returns. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org On the newly created job Koha_Master_D9_MDB_Latest: koha_1 | # Looks like you planned 2 tests but ran 1. koha_1 | koha_1 | # Failed test 'AddReturn logging on statistics table (item-level_itypes=0)' koha_1 | # at t/db_dependent/Circulation/Returns.t line 249. koha_1 | Can't call method "itemtype" on an undefined value at t/db_dependent/Circulation/Returns.t line 247. I recreate locally with this configuration (latest MariaDB version), and tried to debug: modified: t/db_dependent/Circulation/Returns.t @ Returns.t:245 @ subtest "AddReturn logging on statistics table (item-level_itypes=0)" => sub { branch => $branch, type => 'return', itemnumber => $item_without_itemtype->{ itemnumber } - }, { order_by => { -asc => 'datetime' } })->next(); + }, { order_by => { -asc => 'datetime' } }); + warn $stat->count; + $stat = $stat->next; is( $stat->itemtype, $blevel_itemtype, "biblio-level itype recorded on statistics for return"); }; subtest 'Handle ids duplication' => sub { Guess what? ->count returns 1 but ->next returns undef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:30:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:30:02 +0000 Subject: [Koha-bugs] [Bug 24148] black magic in Circulation/Returns.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|black magic in |black magic in |Circulation/Returns. |Circulation/Returns.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:41:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:41:40 +0000 Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702 --- Comment #20 from delaye --- Created attachment 95949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95949&action=edit Intranet xslt result new version   change with   -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:43:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:43:32 +0000 Subject: [Koha-bugs] [Bug 24149] New: Add new Koha::Statistic[s] classes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149 Bug ID: 24149 Summary: Add new Koha::Statistic[s] classes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:45:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:45:04 +0000 Subject: [Koha-bugs] [Bug 24150] New: Add missing Koha::Old::*[s] classes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Bug ID: 24150 Summary: Add missing Koha::Old::*[s] classes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org This bug report will add new classes for: * Koha::Old::Patron[s] * Koha::Old::Biblio[s] * Koha::Old::Item[s] * Koha::Old::Biblioitem[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:46:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:46:42 +0000 Subject: [Koha-bugs] [Bug 24151] New: Add a pseudonymization process for patrons and transactions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Bug ID: 24151 Summary: Add a pseudonymization process for patrons and transactions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:48:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:48:17 +0000 Subject: [Koha-bugs] [Bug 24152] New: Add the ability to purge pseudonymized data Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Bug ID: 24152 Summary: Add the ability to purge pseudonymized data Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:49:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:49:26 +0000 Subject: [Koha-bugs] [Bug 24153] New: Add a confirm flag to the cleanup_database.pl cronjob Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 Bug ID: 24153 Summary: Add a confirm flag to the cleanup_database.pl cronjob Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz That will allow to make it run in dry-run mode with a useful verbose output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:49:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:49:42 +0000 Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:49:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:49:48 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:49:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:49:53 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:49:58 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 16:50:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 15:50:02 +0000 Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:03:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:03:49 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:03:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:03:52 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94220|0 |1 is obsolete| | Attachment #94221|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 95950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95950&action=edit Bug 21944: Test for Circulation.pm Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:04:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:04:03 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #28 from Kyle M Hall --- Created attachment 95951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95951&action=edit Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:04:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:04:06 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #29 from Kyle M Hall --- Created attachment 95952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95952&action=edit Bug 21944: Improve efficiency of code Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:10:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:10:28 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24149, 24150, 20443 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 [Bug 20443] Move C4::Members::Attributes to Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149 [Bug 24149] Add new Koha::Statistic[s] classes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 [Bug 24150] Add missing Koha::Old::*[s] classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:10:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:10:28 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24151 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 [Bug 24151] Add a pseudonymization process for patrons and transactions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:10:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:10:28 +0000 Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24151 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 [Bug 24151] Add a pseudonymization process for patrons and transactions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:10:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:10:28 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24151 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 [Bug 24151] Add a pseudonymization process for patrons and transactions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:11:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:11:04 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19008, 24151 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 [Bug 19008] More database cleanups https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 [Bug 24151] Add a pseudonymization process for patrons and transactions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:11:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:11:04 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24152 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 [Bug 24152] Add the ability to purge pseudonymized data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:11:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:11:04 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24152 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 [Bug 24152] Add the ability to purge pseudonymized data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:11:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:11:25 +0000 Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24114, 24152 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 [Bug 24114] Remove warn statements from Koha::Patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 [Bug 24152] Add the ability to purge pseudonymized data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:11:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:11:25 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24153 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:11:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:11:25 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24153 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:17:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:17:19 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95846|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 95953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95953&action=edit Bug 24128: Add alias for biblionumber search To test: 1 - In staff or OPAC using ES, search for "biblionumber:3" or any existing biblionumber 2 - No results 3 - Apply patch, restart all the things 4 - Search again 5 - You go to the biblionumber Signed-off-by: Bob Bennhoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:17:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:17:37 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:31:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:31:16 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:31:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:31:20 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #1 from Jonathan Druart --- Created attachment 95954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95954&action=edit Bug 24150: Add Koha::Old::*[s] This bug report will add new classes for: * Koha::Old::Patron[s] * Koha::Old::Biblio[s] * Koha::Old::Item[s] * Koha::Old::Biblioitem[s] Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:31:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:31:36 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #2 from Jonathan Druart --- Created attachment 95955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95955&action=edit Bug 24150: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:32:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:32:40 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #3 from Jonathan Druart --- Those classes will be used directly from bug 25151. Adding them on a separate bug report in case someone else needs them. There is no useful test plan apart from proving the new tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:41:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:41:32 +0000 Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:41:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:41:35 +0000 Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149 --- Comment #1 from Jonathan Druart --- Created attachment 95956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95956&action=edit Bug 24149: Add Koha::Statistic[s] classes Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:41:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:41:49 +0000 Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149 --- Comment #2 from Jonathan Druart --- Created attachment 95957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95957&action=edit Bug 24149: Add Koha::Statistic->item Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:42:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:42:03 +0000 Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149 --- Comment #3 from Jonathan Druart --- Created attachment 95958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95958&action=edit Bug 24149: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 17:43:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 16:43:51 +0000 Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149 --- Comment #4 from Jonathan Druart --- We are just adding new Koha::Statistic[s] classes (with tests) in case someone would need them. They will be used by bug 24151. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:58:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 17:58:59 +0000 Subject: [Koha-bugs] [Bug 24154] New: No indication that Default checkout, hold and return policy are set if values are blank Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24154 Bug ID: 24154 Summary: No indication that Default checkout, hold and return policy are set if values are blank Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1 - Visit Admin->Circulation rules 2 - Go to a specific branch 3 - Clear all the boxes in Default checkout, hold and return policy and save 4 - No visible indication that anything is set 5 - Check the DB, (SELECT * FROM circulation_rules WHERE branchcode='BRANCH') 6 - Note there are rules 7 - Unset the rules, no visible change 8 - Check the D, rules are cleared -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 18:59:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 17:59:41 +0000 Subject: [Koha-bugs] [Bug 24154] No indication that Default checkout, hold and return policy are set if values are blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24154 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:04 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:07 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #1 from Jonathan Druart --- Created attachment 95959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95959&action=edit Bug 24151: DB Changes Add tables anonymized_borrowers and anonymized_transactions Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:11 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #2 from Jonathan Druart --- Created attachment 95960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95960&action=edit Bug 24151: Add sysprefs 3 new sysprefs: * Pseudonymization * PseudonymizationPatronFields * PseudonymizationTransactionFields Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:14 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #3 from Jonathan Druart --- Created attachment 95961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95961&action=edit Bug 24151: Copy info to the pseudonymized table when a patron is modified This is the commit where you will find useful information about this development. The goal of this neww feature is to add a way to pseudonymize patron's data, in a way they could not be personally identifiable. https://en.wikipedia.org/wiki/Pseudonymization There are different existing way to anonymize patron's information in Koha, but we loose the ability to make useful report. This development proposes to have 3 different tables: * 1 for patrons' data (anonymized_borrowers) * 1 for transactions (anonymized_transactions) * 1 for patrons' attributes (anonymized_borrower_attributes) Entries to anonymized_borrowers are added when a new patron is added or modified, to anonymized_transactions when a new transaction (checkout, checkin, renew, on-site checkout) is done, and anonymized_borrower_attributes when attributes are added or modified. That way we are maintaining up-to-date informations in 3 different tables. To make those informations not identifiable to a patron, we are having a hashed_borrowernumber column in each of the 3 tables. This hash will be generated (Blowfish-based crypt) using a key stored in the Koha configuration. To make things configurable, we are adding 3 sysprefs and 1 new DB column: * syspref Pseudonymization to turn on/off the whole feature * syspref PseudonymizationPatronFields to list the informations of the patrons to sync * syspref PseudonymizationTransactionFields to list the informations of the transactions to copy * DB column borrower_attribute_types.keep_for_anonymized that is a boolean to enable/disable the copy of a given patron's attribute type. Test plan: 1/ Turn on Pseudonymization 2/ Define in PseudonymizationPatronFields and PseudonymizationTransactionFields the different fields you want to copy 3/ Go to the about page => You will see a warning about a missing config entry 4/ You need to generate a key and put it in the koha-conf.xml file. The following command will generate one: % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' Then edit $KOHA_CONF and add it before of the end of the config section ($2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2 5/ Restart memcached then plack (alias restart_all) => Everything is setup! 6/ Create a new patron => Confirm that a new entry has been added to anonymized_borrowers with the data you expect to be copied 7/ Modify an existing patron (ie. that does not have a corresponding entry in anonymized_borrowers) => Confirm that a new entry has been added to anonymized_borrowers with the data you expect to be copied 8/ Add some transactions (checkout, checkin, renew, on-site checkout) for patron that existed before you turned the pref Pseudonymization on and for newly created/modified patrons => Confirm that new entries have been added to anonymized_transactions with the data you expect 9/ Edit some patron attribute types and tick "Keep for pseudonymization" 10/ Edit or create patrons and add data for those patron attributes => Confirm that new entries have been added to anonymized_borrower_attributese 11/ Delete the patrons => Confirm that the entries still exist in the anonymized_* tables 12/ Purge the patrons (ie. use cleanup_database.pl to remove them from the deleted_borrowers table) => Confirm that the entries still exist in the anonymized_* tables See bug 24152 to remove data from the anonymized_* tables Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:17 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #4 from Jonathan Druart --- Created attachment 95962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95962&action=edit Bug 24151: Add tests Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:20 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #5 from Jonathan Druart --- Created attachment 95963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95963&action=edit Bug 24151: Pseudonymize transactions on the fly Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:23 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #6 from Jonathan Druart --- Created attachment 95964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95964&action=edit Bug 24151: Add tests for transactions Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:27 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #7 from Jonathan Druart --- Created attachment 95965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95965&action=edit Bug 24151: Move get_hash to Koha::Anonymized To avoid duplicated code. Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:30 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #8 from Jonathan Druart --- Created attachment 95966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95966&action=edit Bug 24151: Add tests - if config does not exist Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:33 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #9 from Jonathan Druart --- Created attachment 95967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95967&action=edit Bug 24151: Add warning to the about page if key is missing in the config Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:37 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #10 from Jonathan Druart --- Created attachment 95968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95968&action=edit Bug 24151: Add key to the config Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:40 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #11 from Jonathan Druart --- Created attachment 95969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95969&action=edit Bug 24151: Handle case where the setting is turned on later Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:44 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #12 from Jonathan Druart --- Created attachment 95970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95970&action=edit Bug 24151: DB changes - anonymized_borrower_attributes Add a new DB table anonymized_borrower_attributes Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:47 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #13 from Jonathan Druart --- Created attachment 95971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95971&action=edit Bug 24151: Add new column borrower_attribute_types.keep_for_anonymized Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:51 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #14 from Jonathan Druart --- Created attachment 95972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95972&action=edit Bug 24151: Adding keep_for_anonymized to the UI Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:54 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #15 from Jonathan Druart --- Created attachment 95973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95973&action=edit Bug 24151: Add Koha::Anonymized::Patron::Attribute[s] classes Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:11:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:11:58 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #16 from Jonathan Druart --- Created attachment 95974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95974&action=edit Bug 24151: Sync patron's attributes Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:12:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:12:01 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #17 from Jonathan Druart --- Created attachment 95975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95975&action=edit Bug 24151: DBIC Changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:12:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:12:05 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #18 from Jonathan Druart --- Created attachment 95976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95976&action=edit Bug 24151: Add boolean flag for has_cardnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:12:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:12:39 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:12:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:12:42 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 --- Comment #1 from Jonathan Druart --- Created attachment 95977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95977&action=edit Bug 24152: Add method Koha::Objects->filter_by_last_update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:12:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:12:45 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 --- Comment #2 from Jonathan Druart --- Created attachment 95978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95978&action=edit Bug 24152: Add a warning about the delete of statistics's table entries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:12:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:12:48 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 --- Comment #3 from Jonathan Druart --- Created attachment 95979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95979&action=edit Bug 24152: Add the ability to purge pseudonymized tables anonymized_* tables have been added by bug 24151, this patch adds the usual way to purge data from them. The cleanup_database.pl script has been adjusted to take new parameters that will help to delete pseudonymized data. Test plan: Call the scrip with the new parameter to remove pseudonymized data * --pseudo-patrons DAYS will remove entries from anonymized_borrowers older than DAYS day * --pseudo-patrons can be used without the parameter DAYS but with -- pseudo-patrons-from and/or --pseudo-patrons-to instead, to provide a range of date Same for --pseudo-transactions, see the POD of the script. You can use the patch from bug 24153 to make the tests easier, data will not be deleted if the new --confirm flag is not passed. Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:13:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:13:15 +0000 Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:13:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:13:20 +0000 Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 --- Comment #1 from Jonathan Druart --- Created attachment 95980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95980&action=edit Bug 24153: Add a confirm flag to cleanup_database How handy this will be, right? This patch will change the behavior of this script as the --confirm flag will now be required for effective changes. Without --confirm and with --verbose you will see what could have done the script in non dry-run mode. Test plan: Use different options of the script without the --confirm flag and have a look at the output. It now tells you what would have been deleted if the flag was passed. Now use the --confirm flag and confirm that the changes are now effective. Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:14:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:14:19 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:14:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:14:21 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #24 from Chris Nighswonger --- Created attachment 95981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95981&action=edit Bug 24001: Cannot edit card template Change hardcoded default value of profile_id to 0 rather than null. Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:14:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:14:56 +0000 Subject: [Koha-bugs] [Bug 24155] New: Weights should be applied to Advanced search if no indexes have been selected Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Bug ID: 24155 Summary: Weights should be applied to Advanced search if no indexes have been selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com When searching Keywords via the advanced search we should apply the weights to indexes. This would allow users to use the limits on the advanced search and still get more relevant results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:15:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:15:59 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_24151 --- Comment #19 from Jonathan Druart --- The whole patch stack of this feature has been pushed to a remote branch (https://gitlab.com/joubu/Koha/commits/bug_24151) It includes the tree dependency of bug 24153 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:18:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:18:32 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #25 from Chris Nighswonger --- Test plan: 1. Using the fresh install, with all the sample data. 2. Go to Home › Tools › Patron card creator › Templates 3. New > Card template 4. Save 5. Edit 6. Save Note either of the two errors in the error log. Apply the attached patch. 1. Go to Home › Tools › Patron card creator › Templates 2. Select the previously created template 3. Delete it 4. New > Card template 5. Save 6. Edit 7. Save Note the absence of either of the two errors in error log. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 19:32:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 18:32:48 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #26 from Chris Nighswonger --- This actually fixes both issues described in this bug. To test this, re-run the above procedure with strict_sql_modes set to the opposite value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:19:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:19:41 +0000 Subject: [Koha-bugs] [Bug 24095] Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |agustinmoyano at theke.io CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:33:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:33:43 +0000 Subject: [Koha-bugs] [Bug 24156] New: Basket - Make sort order and number of items to display configurable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Bug ID: 24156 Summary: Basket - Make sort order and number of items to display configurable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Add a mechanism so users can determine: * The default sort order of items in basket view * The default number of items to display in basket view To achieve this we will add new options to "Additional Parameters > Column Settings". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:34:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:34:23 +0000 Subject: [Koha-bugs] [Bug 24157] New: Additional acquisitions permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Bug ID: 24157 Summary: Additional acquisitions permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Add separate permissions allowing selected users to: * Reopen a closed invoice * Edit an invoice * Delete a basket * Delete an invoice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:35:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:35:43 +0000 Subject: [Koha-bugs] [Bug 24158] New: Receive items in multiple currencies Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Bug ID: 24158 Summary: Receive items in multiple currencies Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org When receiving items, add a currency dropdown to the Actual Cost field in the Accounting Details panel. The currency dropdown will list all currencies on the system that have an exchange rate specified. When a currency is selected a conversion will be made from the selected currency to the currency marked as active at the exchange rate specified at the point of receipt. The converted amount will be shown in the Accounting Details panel and written to the database when the form is submitted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:37:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:37:16 +0000 Subject: [Koha-bugs] [Bug 24070] koha_es killed, missing RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24070 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Tomás Cohen Arazi --- We have asked BWS to raise the amount of available RAM for that node. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:37:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:37:19 +0000 Subject: [Koha-bugs] [Bug 24159] New: Short loan collection issues on a day marked as closed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Bug ID: 24159 Summary: Short loan collection issues on a day marked as closed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Scenario: * The library has a 4wk loan item type and a 1hr loan item type. * The library would like 1hr loan item types to be issued and returned on a day marked as closed in the circ calendar, but only allow 4wk loan types to be returned on an open day. Currently, if a 1hr loan is issued on a closed day, the due date is pushed back to the next open day, overriding the duration of the loan. If the usedaysmode syspref is set to "Circulation rules only" due dates for 1hr loan items are calculated at 1hr later as defined in the circ rules, however 4wk loan due dates can potentially be set to closed days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:40:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:40:12 +0000 Subject: [Koha-bugs] [Bug 24160] New: Short loan collection holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24160 Bug ID: 24160 Summary: Short loan collection holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Scenario: * The library has 3 items - two with item type "general shelves", one with type "desk reserve". * Circ rules are set to not allow holds on "desk reserve" items in default holds policy by item type. * OPACHoldsIfAvailableAtPickup is set to "Don't allow" to prevent patrons reserving an item which is available at the specified pickup library. A patron wants to place a hold on one of the “general shelves” items which are both on loan. If this is done by a member of staff in the staff client there is no problem. If the patron tries to place a hold in the opac it is denied because the "desk reserve" item status is available, even though circ rules specify "desk reserve" item types are not holdable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:41:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:41:58 +0000 Subject: [Koha-bugs] [Bug 24161] New: Late orders improvements - keeping track of claims Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Bug ID: 24161 Summary: Late orders improvements - keeping track of claims Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org * Allow multiple claim dates to be associated with an individual order line * Show multiple claim dates against an order line in the late orders page * Show multiple claim dates against an order line in the basket page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:42:42 +0000 Subject: [Koha-bugs] [Bug 24162] New: Late orders improvements - display new columns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Bug ID: 24162 Summary: Late orders improvements - display new columns Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org * Add note column to late orders table * Add ISBN column to late orders table * Add quantity column to late orders table * Add order number column to late orders table (with link to basket) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:42:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:42:56 +0000 Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 [Bug 24161] Late orders improvements - keeping track of claims -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:42:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:42:56 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 [Bug 24162] Late orders improvements - display new columns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:44:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:44:15 +0000 Subject: [Koha-bugs] [Bug 24163] New: Ability to define a CSV profile for late orders export Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163 Bug ID: 24163 Summary: Ability to define a CSV profile for late orders export Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 24162 Add the ability to create a CSV profile for the late orders export. Will allow the inclusion of Title, Author, Date of publication, ISBN, and quantity columns. Multiple claim dates will also be included (from bug 24162) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 [Bug 24162] Late orders improvements - display new columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:44:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:44:15 +0000 Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24163 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163 [Bug 24163] Ability to define a CSV profile for late orders export -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:47:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:47:41 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |mark.gavillet at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:47:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:47:52 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |mark.gavillet at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:48:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:48:00 +0000 Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mark.gavillet at ptfs-europe.c | |om Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:48:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:48:04 +0000 Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day marked as closed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |mark.gavillet at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:48:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:48:10 +0000 Subject: [Koha-bugs] [Bug 24160] Short loan collection holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |mark.gavillet at ptfs-europe.c | |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:48:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:48:23 +0000 Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mark.gavillet at ptfs-europe.c | |om Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:48:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:48:46 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |mark.gavillet at ptfs-europe.c | |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:48:56 +0000 Subject: [Koha-bugs] [Bug 24160] Short loan collection holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:49:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:49:12 +0000 Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:49:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:49:28 +0000 Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mark.gavillet at ptfs-europe.c | |om Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:53:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:53:15 +0000 Subject: [Koha-bugs] [Bug 24164] New: Patron emailer cronjob is not generating unique content for notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Bug ID: 24164 Summary: Patron emailer cronjob is not generating unique content for notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The content is being copied from one patron to all notices - it is because we are nesting a hashref so end up with a pointer instead of a new copy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:53:57 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC|robin at catalyst.net.nz |andrew at bywatersolutions.com | |, | |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:59:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:59:16 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:59:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:59:19 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 --- Comment #1 from Nick Clemens --- Created attachment 95982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95982&action=edit Bug 24164: Unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 20:59:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 19:59:21 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 --- Comment #2 from Nick Clemens --- Created attachment 95983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95983&action=edit Bug 24164: Copy the letter for each email To test: 1 - Set or have two patrons with emails - note thier borrowernumber for the report 2 - Create a report - note the report id SELECT borrowernumber, surname, firstname WHERE borrowernumber IN (##,##); 3 - Create a notice in circulation with code TESTEMAIL 4 - The content should be "[% surname %]" 5 - perl misc/cronjobs/patron_emailer.pl --report ## --notice TESTEMAIL --module circulation --from anyone at anywhere.com --verbose 6 - Note that the emails both have the same surname 7 - Apply patch 8 - Repeat 5 9 - Emails now have correct content -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 21:16:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 20:16:44 +0000 Subject: [Koha-bugs] [Bug 24165] New: Add ability to send any item field in a library chosen SIP field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24165 Bug ID: 24165 Summary: Add ability to send any item field in a library chosen SIP field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Some SIP devices need access to item fields that are not sent as item information in the checkin, checkout and item information responses. It makes sense to allow these fields to be sent in an arbitrary and configurable way, rather than hard code in each special case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 21:21:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 20:21:15 +0000 Subject: [Koha-bugs] [Bug 24165] Add ability to send any item field in a library chosen SIP field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 21:21:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 20:21:18 +0000 Subject: [Koha-bugs] [Bug 24165] Add ability to send any item field in a library chosen SIP field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24165 --- Comment #1 from Kyle M Hall --- Created attachment 95984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95984&action=edit Bug 24165: Add ability to send any item field in a library chosen SIP field Some SIP devices need access to item fields that are not sent as item information in the checkin, checkout and item information responses. It makes sense to allow these fields to be sent in an arbitrary and configurable way, rather than hard code in each special case. Test Plan: 1) Apply this patch 2) Edit your SIP2 config file, add the following within the login stanza: where and are item table columns of your choosing 3) Using the sip cli emulator, run checkout, checkin and item information messages using that item. 4) Note the values you set for the item columns are sent in the corrosponding fields! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 21:21:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 20:21:27 +0000 Subject: [Koha-bugs] [Bug 24165] Add ability to send any item field in a library chosen SIP field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 21:21:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 20:21:31 +0000 Subject: [Koha-bugs] [Bug 24165] Add ability to send any item field in a library chosen SIP field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17826 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 21:21:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 20:21:31 +0000 Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24165 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 22:23:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 21:23:30 +0000 Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 --- Comment #21 from Martha Fuerst --- Any chance this will get backported to 19.05? Thanks, Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 3 23:07:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 22:07:31 +0000 Subject: [Koha-bugs] [Bug 24166] New: Barcode removal breaks circulation.pl/moremember.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24166 Bug ID: 24166 Summary: Barcode removal breaks circulation.pl/moremember.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If an item is checked out, and the barcode is removed from that item, it is impossible to show checked out items on circulation.pl or moremember.pl. The loading of the table is broken by the missing barcodes. And yes, it is a possible scenario. Apparently we have a library that will check damaged items out to an internal account while it is under repairs, and they will remove the barcode if the item is going to be replaced, and put a new barcode in place when the item is in. I know this isn't the best procedure, but you can be sure it will happen to someone else if this hole isn't plugged. We need to either have Koha not allow the removal of a barcode once it is in place, without being replaced with something else, or an item should not be allowed to have an item barcode changed while checked out, or the table needs to load whether the item has a barcode or not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 00:38:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 23:38:28 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 00:38:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 23:38:32 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95926|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 95985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95985&action=edit Bug 24124: Cannot select authorities in batch deletion tool in Chrome This patch adds some inline CSS to force clearing on some elements in the forms for batch record modification and deletion. The problem with selecting the "Authorities" radio button stemmed from the fact that non-clearing floats caused elements to invisibly overlap in the form. To test, apply the patch and test both batch record modification and batch record deletion. Upon selecting the "Authorities" radio button in each case the "Select a list of records" tab should disappear. Selecting the "Biblios" option should re-display the tab. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 00:39:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Dec 2019 23:39:22 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass --- Good easy fix, thanks Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 01:52:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 00:52:37 +0000 Subject: [Koha-bugs] [Bug 23907] Advanced Editor: Make AdditionalFieldsInZ3950ResultSearch work for Adv. Editor Search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23907 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Cori Lynn Arnold --- Found duplicate bug 22492 :) *** This bug has been marked as a duplicate of bug 22492 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 01:52:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 00:52:37 +0000 Subject: [Koha-bugs] [Bug 22492] Advanced editor - Rancor - AdditionalFieldsInZ3950ResultSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22492 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold at dgiinc.com --- Comment #1 from Cori Lynn Arnold --- *** Bug 23907 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 08:56:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 07:56:33 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- (In reply to Nick Clemens from comment #1) > > Could we possibly just search by issue_id? It's a little more complicated than that :(. We need to walk through all fines on the users account so we may honour `MaxFine`. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 08:58:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 07:58:55 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #3 from Martin Renvoize --- The fix does appear to be trivial, but I think I'm going to submit a series of tests first to ensure I'm understanding the problem fully, bare with me whilst I write those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 09:08:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 08:08:40 +0000 Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 09:08:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 08:08:51 +0000 Subject: [Koha-bugs] [Bug 22788] Wrong accruing Overdue Amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22788 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- I agree with Nick, this is almost certainly MaxFine coming into play. Overdues will work through overdue items one by one calculating and updating the fine for each one. Part of that calculation is to look at all pre-existing fines on he users account (including any added within this loop) and sum the amountoutstandings to ensure we're not going to exceed the MaxFine cap when adding this fines next increment. As nick has said, it look like you have a MaxFine of 100 set. So, when the overdues job looped over the first item it calculated a fine of 33 and added it unscathed. However, when it hit the second item it calculated a fine of 33, then compared the total outstanding (33 + 33 + 33 = 99) to the would be total outstanding if it added the full fine was added here (99 + 33 = 132) and spotted that it would exceed the MaxFine of 100.. As such it reduced the increment to $1 instead of $33. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 09:39:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 08:39:45 +0000 Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 --- Comment #11 from Fridolin SOMERS --- Created attachment 95986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95986&action=edit Bug 23204: (follow-up) also sort by marc field Test plan : Launching script several times and see that marc field is alway ordered increasing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 09:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 08:53:57 +0000 Subject: [Koha-bugs] [Bug 23799] Mojolicious::Plugin::OpenAPI missing in Debian 10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Mojolicious::Plugin::OpenAP |Mojolicious::Plugin::OpenAP |I missing |I missing in Debian 10 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Hello Dimitrios, Koha is not compatible with Debian 10 yet. We are going to work on it this release! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 09:54:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 08:54:12 +0000 Subject: [Koha-bugs] [Bug 23799] Mojolicious::Plugin::OpenAPI missing in Debian 10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 11:15:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 10:15:10 +0000 Subject: [Koha-bugs] [Bug 24167] New: We should support installation on Debian 10 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Bug ID: 24167 Summary: We should support installation on Debian 10 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net Debian 10 has been stable for a little while now, and Debian 8 is nearing end of life. We really should be supporting Debian 10 now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 11:16:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 10:16:51 +0000 Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23799 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23799 [Bug 23799] Mojolicious::Plugin::OpenAPI missing in Debian 10 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 11:16:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 10:16:51 +0000 Subject: [Koha-bugs] [Bug 23799] Mojolicious::Plugin::OpenAPI missing in Debian 10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 [Bug 24167] We should support installation on Debian 10 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 11:47:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 10:47:50 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 11:47:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 10:47:53 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95840|0 |1 is obsolete| | --- Comment #15 from Séverine Queune --- Created attachment 95987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95987&action=edit Bug 23767: Include child funds in total spent and ordered on acqui-home To test: 1 - Have three funds, two parents and one child 2 - Open a basket and add an order to each fund 3 - View acqui-home.pl 4 - Note that ordered values are only added from the two parent funds 5 - Complete these orders (close basket, receive) 6 - Note the spent only includes parent funds 7 - Place three more orders, one from each fund 8 - Now you can see both spent and ordered are incorrect 9 - Apply patch 10 - Reload, all should add correctly Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 11:47:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 10:47:56 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95841|0 |1 is obsolete| | --- Comment #16 from Séverine Queune --- Created attachment 95988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95988&action=edit Bug 23767: Don't calculate 'Total available' The acqui-home page is meant to be a simple view of the budgets. For details you should lok at aqbudgets.pl ( i.e. click on a budget) The total available column isn't easy to calculate - it depends on child funds - trying to calculate what a top level fund has left depends on the values of the child funds. When searching the table and limiting rows you lose the values form the children. On acqbudgets.pl we solve this with the Base-level/Total available columns, and we don't total base-level on that page at all. 'Total available' on acqui-home equals the 'Base level' on the other page. Removing a recalculated total is the simplest answer here, otherwise we must add complexity to this view. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 11:56:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 10:56:34 +0000 Subject: [Koha-bugs] [Bug 24168] New: Errors with use of CanItemBeReserved return value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Bug ID: 24168 Summary: Errors with use of CanItemBeReserved return value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 15524 changed CanItemBeReserved to return a hashref with status inside. Looks like But 23116 was intruced with previous behavior. So now there a uses of CanItemBeReserved return value as a string : if ( $can_item_be_reserved eq 'OK' || ( $can_item_be_reserved ne 'itemAlreadyOnHold' && $can_override ) ) { use git grep can_item_be_reserved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 11:59:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 10:59:14 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:01:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:01:49 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:04:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:04:05 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a configurable value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #1 from Cori Lynn Arnold --- Created attachment 95989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95989&action=edit Bug 24108: Advanced Editor: Save .mrc save with a configurable value Creates a new systempref "SaveRecordbyControlNumber" which is initially set to 0 (off/no). By default saving .mrc (and .xml) will be saved by the biblionumber. To test: Apply the patches. 1. Open a record in the advanced editor 2. Save the record using the drop down box selecting "Save as MARC (.mrc) file. 3. Note that the file saved is the same as the biblionumber at the top of the Advanced Editor interface. 4. Update the database: update systempreferences set value = '1' where variable = 'SaveRecordbyControlNumber'; 5. Restart Koha 6. Verify that there is not a 001 field in the record (delete it if there is) Repeat steps 1, 2, & 3 for both .mrc and .xml options (the file should still be saved as the biblionumber if there is no control field) 7. Add a 001 field to the record such as "001 abc00012345" Repeat steps 1, 2 for both .mrc and .xml Verify that the files saved are named abc00012345.mrc and abc00012345.xml -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:04:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:04:42 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a configurable value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Cori Lynn Arnold --- To test: Apply the patches. 1. Open a record in the advanced editor 2. Save the record using the drop down box selecting "Save as MARC (.mrc) file. 3. Note that the file saved is the same as the biblionumber at the top of the Advanced Editor interface. 4. Update the database: update systempreferences set value = '1' where variable = 'SaveRecordbyControlNumber'; 5. Restart Koha 6. Verify that there is not a 001 field in the record (delete it if there is) Repeat steps 1, 2, & 3 for both .mrc and .xml options (the file should still be saved as the biblionumber if there is no control field) 7. Add a 001 field to the record such as "001 abc00012345" Repeat steps 1, 2 for both .mrc and .xml Verify that the files saved are named abc00012345.mrc and abc00012345.xml -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:06:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:06:01 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 --- Comment #1 from Fridolin SOMERS --- Also impact on Bug 22330 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:06:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:06:14 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 [Bug 15524] Set limit on maximum possible holds per patron by category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:06:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:06:14 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 [Bug 24168] Errors with use of CanItemBeReserved return value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:06:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:06:29 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22330 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:06:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:06:29 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24168 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:06:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:06:40 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23116 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:06:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:06:40 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24168 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:07:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:07:35 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24168 --- Comment #15 from Jonathan Druart --- Please test patches guys Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 [Bug 24168] Errors with use of CanItemBeReserved return value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:07:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:07:35 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23116 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 [Bug 23116] Cannot place overridden holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:07:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:07:42 +0000 Subject: [Koha-bugs] [Bug 23116] Cannot place overridden holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24168 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:07:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:07:42 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23116 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:07:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:07:47 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala at helsinki.fi --- Comment #2 from Joonas Kylmälä --- Jonathan, please put in the patch title what the patch does instead of what the problem is (https://wiki.koha-community.org/wiki/Commit_messages#Examples). Maybe like "Bug 23970: Make search with "Publication date" field work at any position", and in the body explain the problem and the fix in more detail. Btw, on top of that same wiki page the "Good commit" message has the same problem that it doesn't state what the commit does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:14:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:14:30 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #10 from Séverine Queune --- (In reply to Andrew Isherwood from comment #8) > Katrin and Séverine - I agree that basket reopening would be a useful thing > to log, but it is outside of the scope of the requirements for this bug. > There are many Acq actions that could be logged, I'm hoping these will be > added in time. I will open a new bug to add this action. > Revised test plan: > > - Modify a basket > => TEST: Observe that an Acquisitions action log has been created containing: > => Basket number > => Borrowernumber of the user who modified the basket, this is stored in > "info" as a left padded 10 digit number which can be joined on to the > borrowers table 3 things about this MODIFY_BASKET log : - as the borrowernumber is saved in the 'user' field, why duplicating it in the 'info' field ? - in this 'info' field, we usually have the details of the action made by the user. To me, the information displays for now in not really usefull. - I only get log when I modify the "Managing library" but not when I update the managers of the basket, not when I edit the basket. Is that the expected behaviour ? > - Approve a basket via EDI > => TEST: Observe that an Acquisitions action log has been created containing: > => Basket number > => Borrowernumber of the user who approved the basket, this is stored in > "info" as a left padded 10 digit number which can be joined on to the > borrowers table I tried several EDI settings but it still doesn't work so one mode ime, I didn't test this part (would be happy if someone could help !). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:27:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:27:16 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 --- Comment #2 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #1) > Also impact on Bug 22330 Oups sorry no its correct : my $canitembereserved = C4::Reserves::CanItemBeReserved( $borrowernumber, $itemnumber, $branch )->{status}; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:27:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:27:30 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22330 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:27:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:27:30 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24168 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:51:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:51:47 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:51:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:51:50 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95787|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 95990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95990&action=edit Bug 23970: Make search with "Publication date" field work at any position The changes made in the following commit: commit 0d2e83bca5b91376e9262b6cb0b993f09b919018 Bug 14636: Item search - fix search and sort by publication date for MARC21 was put at the wrong place. It was inside a "if $i == 1" test that impacts the first field only. Test plan: 0/ Use a MARC21 installation 1/ Search items by publication date, use twice the field using different values. For instance: publication date: 2005 OR publication date: 2006 => Without this patch you only get results for 2005 => With this patch applied you get results for both years. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 12:52:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 11:52:10 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 --- Comment #4 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #2) > Jonathan, please put in the patch title what the patch does instead of what > the problem is > (https://wiki.koha-community.org/wiki/Commit_messages#Examples). Maybe like > "Bug 23970: Make search with "Publication date" field work at any position", > and in the body explain the problem and the fix in more detail. > > Btw, on top of that same wiki page the "Good commit" message has the same > problem that it doesn't state what the commit does. I wrote that, thanks for catching me! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:15:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 12:15:26 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:15:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 12:15:29 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95990|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä --- Created attachment 95991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95991&action=edit Bug 23970: Make search with "Publication date" field work at any position The changes made in the following commit: commit 0d2e83bca5b91376e9262b6cb0b993f09b919018 Bug 14636: Item search - fix search and sort by publication date for MARC21 was put at the wrong place. It was inside a "if $i == 1" test that impacts the first field only. Test plan: 0/ Use a MARC21 installation 1/ Search items by publication date, use twice the field using different values. For instance: publication date: 2005 OR publication date: 2006 => Without this patch you only get results for 2005 => With this patch applied you get results for both years. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:19:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 12:19:29 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:33:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 12:33:25 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #15 from Joonas Kylmälä --- (In reply to David Cook from comment #8) > (In reply to Jonathan Druart from comment #7) > > It should be done for every connection I'd say, to make sure it's always > > up-to-date. > > Do you know how long-lived the connections are? My concern is that the > duration of a connection might be longer than we want an update window to > be. IMHO, this question (and the test plan) still needs be addressed before the patch can be applied. Using only L2 cache would be a correct way to do this at least. If the session where a librarian returns hundreds or thousands of books through SIP I think the sysprefs should be updated during that time also to SIP server because the process might take hours and depending on the SIP server settings I think one connection can be alive all that time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:38:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 12:38:43 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:44:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 12:44:50 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #16 from Joonas Kylmälä --- I checked the patch now and I see the flushing change is inside process_request() subroutine and that name suggests that the flushing might happen everytime a new individual request like "check-in item" comes to the SIP server, so maybe the solution is absolutely correct? Anyways the test plan is needed to confirm this so keeping the status still as "Failed QA". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:55:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 12:55:44 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|jonathan.druart at bugs.koha-c |dcook at prosentient.com.au |ommunity.org | --- Comment #17 from Jonathan Druart --- Waiting for David to provide a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 13:57:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 12:57:12 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #18 from Katrin Fischer --- Maybe something like this could serve as a test plan: - Check out an item through SIP, note due date - Change the calendar, add closing days between now and the due date - Check out another item through SIP, note due date is still the same as before - Apply patch - Verify that the due date changes immediately without requiring a restart of the SIP server Could this help? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:54:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 13:54:15 +0000 Subject: [Koha-bugs] [Bug 24169] New: Advanced editor: icons/buttons for sorting the search results are missing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Bug ID: 24169 Summary: Advanced editor: icons/buttons for sorting the search results are missing Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: carnold at dgiinc.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl After 19.11 the sorting icons for the search results disappeared. The search still works if you click on the header of the column, but the icons are gone. 19.05: https://paste.pics/8694b71e22504d77439b877166ca5e77 19.11: https://paste.pics/301f28373f9fc57756e401855fcb063b -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 14:54:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 13:54:48 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:26:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 14:26:50 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #4 from Martin Renvoize --- Created attachment 95992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95992&action=edit Bug 24146: Add test cases This patch adds test cases for both checking amountoutstanding values are handled correctly and also that the paid down accruing fines do not add additional fines on increment. Test plan: Read the changeset and asses whether the changes/additional tests are correct as per the expected behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:28:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 14:28:48 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 14:31:13 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Depends on| |23013 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Caused by bug 23013. cateditor-ui.inc is using .sorting_asc and .sorting_desc that were define in datatables.css Now the CSS definitions are more precise (table.dataTable thead .sorting_asc) and are no longer applied to the th. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 [Bug 23013] Upgrade DataTables in the staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 14:31:13 +0000 Subject: [Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:37:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 14:37:15 +0000 Subject: [Koha-bugs] [Bug 20833] Feature request: Better copy/paste for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:44:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 14:44:47 +0000 Subject: [Koha-bugs] [Bug 24170] New: sysprefs search result does not have a consistent order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Bug ID: 24170 Summary: sysprefs search result does not have a consistent order Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The same sysprefs search will not always return the results in the same order. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:47:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 14:47:33 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:47:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 14:47:36 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 --- Comment #1 from Jonathan Druart --- Created attachment 95993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95993&action=edit Bug 24170: Fix sysprefs search result order The same sysprefs search will not always return the results in the same order. If you search for 'd' in the "search system preferences" box /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=d you will see that the modules are not ordered consistently. This patch makes them display alphabetically Test plan: Search the same string several times in the syspref list. The search result should always be ordered the same way -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 15:52:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 14:52:34 +0000 Subject: [Koha-bugs] [Bug 24171] New: Cannot do on-site checkouts/automatic renewal with Itemfallbacksearch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Bug ID: 24171 Summary: Cannot do on-site checkouts/automatic renewal with Itemfallbacksearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When using Itemfallbacksearch for checking out items without barcode, the checkboxes for automatic-renewal and on-site checkout are ignored. To test: - Turn on OnSiteCheckouts and Itemfallbacksearch - Open a patron account - Check the checkboxes for automatic-renewal and on-site checkout - Search for a title keyword in the checkout input box - Verify that the item checked out is not checked out as on-site and no auto-renewal flag was set -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:02:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 15:02:54 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose --- Hi All, I confirm this is still the case. Test plan: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:07:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 15:07:51 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:07:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 15:07:54 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 --- Comment #3 from Jonathan Druart --- Created attachment 95994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95994&action=edit Bug 24168: (bug 23116 follow-up) AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold This patch actually fixes the issue described on bug 23116. Test plan: See bug 23116. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:08:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 15:08:21 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:23:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 15:23:37 +0000 Subject: [Koha-bugs] [Bug 24172] New: Locale is ignored when saving season/month/day name in the database Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Bug ID: 24172 Summary: Locale is ignored when saving season/month/day name in the database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Hi All, it seems the locale is completely ignored when creating numbering with season/month/day names. What I'm getting on master is that the season name is saved in English in the database, ignoring the locale completely, and depending on the page, the season name will be translated or not for display purposes in the staff interface language. (Steps 1-4 of the test plan are related to bug #20511, but I feel they are related since both have to do with locale being ignored.) Here's what I did : 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else Navigating through different pages, here's what I noticed: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db I think the locale should be used when saving the season name in the db ensuring all displays are the same and in accordance with the option specified when creating the subscription. P.S. I'm not sure it has anything to do with it, but I noticed when choosing "French" as locale, the value saved in the db (subscription.locale) is "fre" and not "fr-FR" or "fr-CA". Would that have to do with Koha not being able to find the right translations? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:43:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 15:43:50 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95993|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 95995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95995&action=edit Bug 24170: Fix sysprefs search result order The same sysprefs search will not always return the results in the same order. If you search for 'd' in the "search system preferences" box /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=d you will see that the modules are not ordered consistently. This patch makes them display alphabetically Test plan: Search the same string several times in the syspref list. The search result should always be ordered the same way Signed-off-by: cori -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:44:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 15:44:11 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |carnold at dgiinc.com --- Comment #3 from Cori Lynn Arnold --- Works as advertised! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:44:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 15:44:29 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #5 from Kyle M Hall --- (In reply to Martin Renvoize from comment #4) > Created attachment 95992 [details] [review] > Bug 24146: Add test cases > > This patch adds test cases for both checking amountoutstanding values > are handled correctly and also that the paid down accruing fines do not > add additional fines on increment. > > Test plan: > Read the changeset and asses whether the changes/additional tests are > correct as per the expected behaviour. Do we need to take renewals into account? We already have the issue id, do we need the renewal iteration as well to ensure we target the correct paid fine? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:44:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 15:44:44 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Locale is ignored when |Locale is ignored when |saving season/month/day |saving season name in the |name in the database |database -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:45:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 15:45:30 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #1 from Caroline Cyr La Rose --- I hadn't noticed, but everything works a-ok for month and day names. The problem happens only when using season names. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 16:56:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 15:56:12 +0000 Subject: [Koha-bugs] [Bug 24155] Weights should be applied to Advanced search if no indexes have been selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org --- Comment #1 from AspenCat Team --- This would be very helpful for our libraries that are accustomed to using the advanced search. - Bob Bennhoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 17:22:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 16:22:47 +0000 Subject: [Koha-bugs] [Bug 5671] Add a column of custom HTML to "my summary" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5671 ksenia changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |18.11 OS|All |Windows CC| |todotusoft at gmail.com Hardware|All |PC -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:43:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 17:43:20 +0000 Subject: [Koha-bugs] [Bug 24173] New: Advanced Editor: Show subtitle & published date on the search page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 Bug ID: 24173 Summary: Advanced Editor: Show subtitle & published date on the search page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: carnold at dgiinc.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Add Subtitle (all parts) and date published to the results that come up for the Advanced Editor Search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 18:46:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 17:46:47 +0000 Subject: [Koha-bugs] [Bug 24174] New: OPAC patron self registration requirements conflict with patron modifications (updates) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24174 Bug ID: 24174 Summary: OPAC patron self registration requirements conflict with patron modifications (updates) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Fields that a library would require a patron to fill out on registration should not also be the same as patron modifications. Modifications are bound by the PatronSelfRegistrationBorrowerMandatoryField. Some libraries want to require the surname and firstname on registration, but don't want patrons changing their names on a whim. We can hide the fields via jquery, but it would be preferable that modifications have their own set of mandatory fields. I would suggest PatronSelfModificationBorrowerMandatoryField. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 19:07:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 18:07:20 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #2 from Blou --- Created attachment 95996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95996&action=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are not handled by locales. Those generated are stored in English in the database, and the display in serials-collection.tt is translating them. But once you click on "Edit serials" or if you go straight to the subscription's display, those are displayed as in the database: in English. This patch reproduces the same trick as in serial-collection.tt and allow for the display to be translated. NOTE: this patch's testing require knowledge of translation tools. Reproducing Caroline's test: 0- Make sure you have at least one language other than English installed 1- With staff interface in English, create a subscription with a seasonal numbering pattern and frequency, with locale in your other language 2- Check the prediction pattern, note that the season names are in English not the locale language 3- Change the staff interface to other language, redo the prediction pattern test with locale in other language, note that the season names are in other language 4- Save the subscription 5- Receive an issue, note that the season name in the "Numbered" column on serials-edit.pl is in English 6- Save your issue 7- Switch interface in other language 8- Note that the season name on serials-collection is in other language 9- If you check the database, you will see the season name is in English, even though the subscription.locale is something else 10- validate the different pages: - serials-collection.pl: display is translated - serials-edit.pl: name pulled directly from db - subscription-detail.pl: name pulled directly from db - detail.pl: name pulled directly from db - opac-detail.pl: name pulled directly from db 11- APPLY THE PATCH 12- translate the string a) ./translate update b) find the strings, translate them c) ./translate install 13- restart Plack ? 14- validate the pages again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 19:40:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 18:40:17 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #29 from Kelly McElligott --- I did not see the message that is indicated in step 2. " Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process" . This would be an extremely helpful message. I received a message that 2 items were deleted. Yes, they were the correct items to be deleted and left the item with the hold along. I am not sure with this test plan, if this message that you note in step 2 should be see. See my screenshot. Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 19:40:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 18:40:49 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #30 from Kelly McElligott --- Created attachment 95997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95997&action=edit delete message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 19:46:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 18:46:28 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #3 from Blou --- Created attachment 95998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95998&action=edit Bug 24172: Allow translation of seasons in details.tt and opac-details.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 19:49:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 18:49:22 +0000 Subject: [Koha-bugs] [Bug 24175] New: Cannot cancel holds - wrong parameter passed for itemnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Bug ID: 24175 Summary: Cannot cancel holds - wrong parameter passed for itemnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When searching holds we pass $self->{item}->id, which is the barcode, as the itemnumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 19:54:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 18:54:39 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 19:54:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 18:54:41 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #1 from Nick Clemens --- Created attachment 95999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95999&action=edit Bug 24175: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 19:54:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 18:54:44 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #2 from Nick Clemens --- Created attachment 96000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96000&action=edit Bug 24175: Use itemnumber when searching for holds in SIP drop_hold To test: 1 - place a hold for a patron 2 - Get SIP running https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-' 4 - Attempt to cancel hold 5 - It fails 6 - Apply patch 7 - Try again 8 - It succeeds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 19:55:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 18:55:08 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 20:07:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 19:07:33 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |minor CC| |philippe.blouin at inlibro.com Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch --- Comment #4 from Blou --- Applied it on 19.05 for our customer, it works in French. Sponsored By: Collecto (formely known as CCSR) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 21:17:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 20:17:15 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 21:18:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 20:18:50 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 21:28:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 20:28:07 +0000 Subject: [Koha-bugs] [Bug 5671] Add a column of custom HTML to "my summary" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5671 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Windows |All CC|jwagner at ptfs.com, | |nengard at gmail.com, | |todotusoft at gmail.com | Version|18.11 |unspecified Hardware|PC |All -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 4 23:48:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 22:48:16 +0000 Subject: [Koha-bugs] [Bug 24176] New: Make datelastborrowed a configurable column in holdings_table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24176 Bug ID: 24176 Summary: Make datelastborrowed a configurable column in holdings_table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some librarians would find it hand if datelastborrowed would show in the holdings_table as a configurable column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 00:17:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 23:17:34 +0000 Subject: [Koha-bugs] [Bug 24176] Make datelastborrowed a column in holdings_table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24176 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make datelastborrowed a |Make datelastborrowed a |configurable column in |column in holdings_table |holdings_table | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 00:31:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 23:31:06 +0000 Subject: [Koha-bugs] [Bug 24176] Make datelastborrowed a column in holdings_table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24176 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 00:31:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 23:31:09 +0000 Subject: [Koha-bugs] [Bug 24176] Make datelastborrowed a column in holdings_table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24176 --- Comment #1 from Lucas Gass --- Created attachment 96001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96001&action=edit Bug 24176: add datelastborrowed column TEST PLAN: 1. Find an item with a datelastborrowed 2. Go to the details page on the staff client and look at the holdings table, no date last borrowed. 3. Apply patch 4. See the datelastborrowed column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 00:52:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 23:52:09 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 00:52:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Dec 2019 23:52:13 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95241|0 |1 is obsolete| | --- Comment #11 from Lucas Gass --- Created attachment 96002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96002&action=edit Bug 22381: Change wording on Calendar-related system TEST PLAN: 1. Apply Patch 2. Look at the 5 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay, SuspensionsCalendar) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 04:22:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 03:22:43 +0000 Subject: [Koha-bugs] [Bug 24177] New: Internal Server error when clicking cash register(Report) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Bug ID: 24177 Summary: Internal Server error when clicking cash register(Report) Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: librarian at sageuniversity.in QA Contact: testopia at bugs.koha-community.org Created attachment 96003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96003&action=edit error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 04:26:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 03:26:40 +0000 Subject: [Koha-bugs] [Bug 24178] New: New Arrivals books not Display in Opac Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24178 Bug ID: 24178 Summary: New Arrivals books not Display in Opac Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: librarian at sageuniversity.in QA Contact: testopia at bugs.koha-community.org Created attachment 96004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96004&action=edit Not Display in Proper(koha Plugin) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 04:31:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 03:31:11 +0000 Subject: [Koha-bugs] [Bug 24178] New Arrivals books not Display in Opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24178 Govind Basedia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |librarian at sageuniversity.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 04:31:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 03:31:46 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register(Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Govind Basedia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |librarian at sageuniversity.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 07:05:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 06:05:58 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #19 from David Cook --- (In reply to Katrin Fischer from comment #18) > Maybe something like this could serve as a test plan: > > - Check out an item through SIP, note due date > - Change the calendar, add closing days between now and the due date > - Check out another item through SIP, note due date is still the same as > before > - Apply patch > - Verify that the due date changes immediately without requiring a restart > of the SIP server > > Could this help? Sounds good to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 07:09:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 06:09:11 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #20 from David Cook --- (In reply to Jonathan Druart from comment #17) > Waiting for David to provide a test plan. 1. Enable IssueLog 2. Start SIP server 3. Issue book via SIP 4. Check action_logs for "CIRCULATION ISSUE " line 5. Disable IssueLog 6. Issue another book via SIP 7. Check action_logs With the bug, there would be a new line in action_logs for #7. Without the bug, there would not be a new line in action_logs for #7. -- Of course, if this test plan fails, it could be that the L2 cache isn't been cleared properly either. I suppose to be more thorough in the testing, you could clear memcached after step #5 Disable IssueLog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 07:58:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 06:58:37 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Katrin Fischer --- > Katrin and Séverine - I agree that basket reopening would be a useful thing > to log, but it is outside of the scope of the requirements for this bug. > There are many Acq actions that could be logged, I'm hoping these will be > added in time. I am sorry... but I'd like to at least try to explain my point of view a bit more. This bug states to add logging for basket related actions and of all the basket related actions one is missing. I don't feel this is out of scope at all. I've thought about why this is bothering me so much. I think it comes down to this: One of the biggest challenges we face is to develop Koha to be consistent and intuitive, to work as one piece of software, for everyone using it. When I have a feeling that something will cause question marks, and have me say: 'I know that doesn't make sense' to a library later, I feel I have to point it out. > Katrin - I have put the logging behind an AcqLog syspref, thanks for > highlighting this. Thank you. I am wondering if we should make the pref description a bit more specific to not lead to false expectations for now. Easy to change the text when coverage is extended beyond baskets. Switching to FQA because of Severine's comment#10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 08:05:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 07:05:35 +0000 Subject: [Koha-bugs] [Bug 20833] Better copy/paste for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20833 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Feature request: Better |Better copy/paste for |copy/paste for system |system preferences |preferences | Component|Staff Client |System Administration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 08:06:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 07:06:34 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 08:06:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 07:06:34 +0000 Subject: [Koha-bugs] [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 [Bug 20511] Seasonal prediction just in the staff language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 09:42:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 08:42:51 +0000 Subject: [Koha-bugs] [Bug 16655] Date due error with SIP2 checkouts and holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16655 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- I am also seeing this problem now, on 18.11.03: - Days around xmas are closed. - useDaysMode = Calculate the due date using [the calendar to push the due date to the next open day] Loans issued through SIP2 sometimes get the unaltered 21 day loan time, with a return date on a date that is closed according to the calendar. Sometimes the loans get the proper return date, on the first day the library is open after the holidays. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 09:43:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 08:43:23 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|dcook at prosentient.com.au |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #21 from Jonathan Druart --- Thanks Katrin and David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 10:20:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 09:20:22 +0000 Subject: [Koha-bugs] [Bug 16655] Date due error with SIP2 checkouts and holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16655 --- Comment #3 from Katrin Fischer --- Could this be bug 23640? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 10:34:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 09:34:13 +0000 Subject: [Koha-bugs] [Bug 16655] Date due error with SIP2 checkouts and holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16655 --- Comment #4 from Magnus Enger --- (In reply to Katrin Fischer from comment #3) > Could this be bug 23640? Possibly. But it does seem strange that the wrong return dates are kind of random, sometimes it happens and sometimes it doesn't. And there is no pattern related to item types or patron categories, that I can see. I have restarted SIP2 and we will see what happens. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 10:53:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 09:53:34 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95992|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 96005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96005&action=edit Bug 24146: Add test cases This patch adds test cases for both checking amountoutstanding values are handled correctly and also that the paid down accruing fines do not add additional fines on increment. Test plan: Read the changeset and asses whether the changes/additional tests are correct as per the expected behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 11:17:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 10:17:14 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #7 from Martin Renvoize --- Created attachment 96006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96006&action=edit Bug 24146: Increment existing fine We should increment an existing fine even if it has been fully paid off whilst it is still incrementing and not create a new fine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 11:17:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 10:17:32 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 11:19:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 10:19:33 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #8 from Martin Renvoize --- Right, I've commented the tests a bit further and I think it shows we're testing the renewal case. The second patch fixes the error reported here, but the enhanced tests still do not fully pass... but I'm not entirely sure the tests are correct. The question is how should MaxFine act in the case of partially paid fines. Setting to NSO to get some more eyes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 11:28:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 10:28:38 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #30 from Jonathan Druart --- Created attachment 96007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96007&action=edit Bug 22844: (follow-up) Make the attribute mandatory when editing a patron Previous patch forgot the most important, adding the required attribute to the select/textarea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 11:29:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 10:29:01 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #31 from Jonathan Druart --- I think this is ready for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 11:44:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 10:44:36 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #13 from Jonathan Druart --- It's not clear with 2 tabs. Sorry to insist but: 1. Do not select anything, click "close selected invoices" => You get a warning "nothing selected" Now tick an open invoice, and click "open selected invoices" => You do not get the warning 2. Click "Show only subscriptions" label does not select the checkbox. Missing id. 3. You can select subscriptions from the 2 tabs then click "Merge selected invoices". It's expected but as the button is inside the tab (so 2 buttons) it's not obvious. Not blocker as other QAers agreed with the tab, but insufficient for me to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 11:49:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 10:49:01 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 --- Comment #9 from Jonathan Druart --- Comment on attachment 95326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95326 Bug 22393: (follow-up) Handle deleted items Review of attachment 95326: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22393&attachment=95326) ----------------------------------------------------------------- ::: members/maninvoice.pl @@ +103,5 @@ > $item_id = $item->itemnumber; > } > else { > + my $old_itemnumber = $dbh->selectrow_array( > + "SELECT itemnumber FROM deleted_items WHERE barcode=?", deleted_items? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 11:50:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 10:50:42 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |lari.taskula at hypernova.fi |ommunity.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 11:54:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 10:54:00 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:01:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:01:47 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:01:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:01:51 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95953|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 96008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96008&action=edit Bug 24128: Add alias for biblionumber search To test: 1 - In staff or OPAC using ES, search for "biblionumber:3" or any existing biblionumber 2 - No results 3 - Apply patch, restart all the things 4 - Search again 5 - You go to the biblionumber Signed-off-by: Bob Bennhoff Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:02:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:02:13 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Would be great to see this area covered by tests a bit more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:05:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:05:40 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- I also find this strange - I don't think we should ever delete from deleted_items? And why select by barcode? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:06:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:06:41 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:06:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:06:44 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95985|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 96009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96009&action=edit Bug 24124: Cannot select authorities in batch deletion tool in Chrome This patch adds some inline CSS to force clearing on some elements in the forms for batch record modification and deletion. The problem with selecting the "Authorities" radio button stemmed from the fact that non-clearing floats caused elements to invisibly overlap in the form. To test, apply the patch and test both batch record modification and batch record deletion. Upon selecting the "Authorities" radio button in each case the "Select a list of records" tab should disappear. Selecting the "Biblios" option should re-display the tab. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:13:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:13:38 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:13:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:13:41 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95817|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 96010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96010&action=edit Bug 13806: No input sanitization where creating Reports subgroup This patch adds validation of report group and subgroup inputs so that the user can't enter data into only one half of the group code/name pair. To test, apply the patch and go to Reports -> Use saved. - Create or edit a report which doesn't have a group or subgroup assigned. - Under "Report group," select the "or create" radio button. - Click the "Update SQL" button to submit the form without entering a group code or name. The form should require taht you enter data into both fields. - Enter data into the report group code and name fields. Add data to either the code or data field under "Report subgroup." You should not be able to submit the form without populating both. - Start over editing a report which doesn't have a group or subgroup assigned. - Select an existing group under "Report group." - Under "Report subgroup," select the "or create" option. - You should not be able to submit the form without adding data in both the code and name fields for the report subgroup. Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:22:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:22:42 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- Sorry, trying to make this moving forward but it's confusing me. I am also expecting to see "Make an Interlibrary loan request" even if "suggestions" is turned off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:24:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:24:35 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com --- Comment #11 from Jonathan Druart --- Andrew, can you give your opinion on this one please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:30:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:30:46 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #30 from Jonathan Druart --- Christopher, could you add your stamp on Kyle's follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:35:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:35:35 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:35:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:35:40 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95760|0 |1 is obsolete| | Attachment #95761|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 96011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96011&action=edit Bug 17831: Remove non-existig bibliosubject.subject mapping from frameworks This patch removes the assignment of non-existent koha field 'bibliosubject.subject' to MARC subject fields in the installer data for koha To test: You'll want a new fresh db 1 - Apply patch 2 - Run websintaller 3 - Ensure that thigns go smoothly 4 - Add/delete/edit some records and ensure that things are working with the installed frameworks Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:35:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:35:43 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #11 from Jonathan Druart --- Created attachment 96012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96012&action=edit Bug 17831: Database update - Tidy up frameworks in existing installations The mapped table and column doesn't exist, so we should also remove it from existing installations. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:39:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:39:50 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:40:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:40:03 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:46:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:46:17 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96009|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 96013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96013&action=edit Bug 24124: Fix authorities selection in batch deletion tool in Chrome This patch adds some inline CSS to force clearing on some elements in the forms for batch record modification and deletion. The problem with selecting the "Authorities" radio button stemmed from the fact that non-clearing floats caused elements to invisibly overlap in the form. To test, apply the patch and test both batch record modification and batch record deletion. Upon selecting the "Authorities" radio button in each case the "Select a list of records" tab should disappear. Selecting the "Biblios" option should re-display the tab. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:47:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:47:11 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96010|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 96014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96014&action=edit Bug 13806: Sanitize inputs where creating Reports subgroup This patch adds validation of report group and subgroup inputs so that the user can't enter data into only one half of the group code/name pair. To test, apply the patch and go to Reports -> Use saved. - Create or edit a report which doesn't have a group or subgroup assigned. - Under "Report group," select the "or create" radio button. - Click the "Update SQL" button to submit the form without entering a group code or name. The form should require taht you enter data into both fields. - Enter data into the report group code and name fields. Add data to either the code or data field under "Report subgroup." You should not be able to submit the form without populating both. - Start over editing a report which doesn't have a group or subgroup assigned. - Select an existing group under "Report group." - Under "Report subgroup," select the "or create" option. - You should not be able to submit the form without adding data in both the code and name fields for the report subgroup. Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 12:48:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 11:48:59 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- I am not sure which is the best fix here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:05:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:05:48 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:05:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:05:51 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88539|0 |1 is obsolete| | Attachment #88541|0 |1 is obsolete| | Attachment #88542|0 |1 is obsolete| | Attachment #88543|0 |1 is obsolete| | Attachment #88544|0 |1 is obsolete| | Attachment #88545|0 |1 is obsolete| | Attachment #88546|0 |1 is obsolete| | Attachment #88547|0 |1 is obsolete| | Attachment #88702|0 |1 is obsolete| | Attachment #88703|0 |1 is obsolete| | Attachment #88704|0 |1 is obsolete| | Attachment #88705|0 |1 is obsolete| | Attachment #88935|0 |1 is obsolete| | Attachment #88936|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall --- Created attachment 96015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96015&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:06:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:06:12 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #12 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > Sorry, trying to make this moving forward but it's confusing me. > > I am also expecting to see "Make an Interlibrary loan request" even if > "suggestions" is turned off. If we all agree on that, I am going to provide a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:06:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:06:24 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96015|0 |1 is obsolete| | --- Comment #45 from Kyle M Hall --- Created attachment 96016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96016&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:06:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:06:33 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #46 from Kyle M Hall --- Created attachment 96017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96017&action=edit Bug 20256: Add new permission to editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:06:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:06:37 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #47 from Kyle M Hall --- Created attachment 96018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96018&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:06:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:06:41 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #48 from Kyle M Hall --- Created attachment 96019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96019&action=edit Bug 20256: Add new methods for checking item editing permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:06:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:06:44 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #49 from Kyle M Hall --- Created attachment 96020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96020&action=edit Bug 20256: Update Schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:06:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:06:48 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #50 from Kyle M Hall --- Created attachment 96021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96021&action=edit Bug 20256: Update groups editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:06:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:06:52 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #51 from Kyle M Hall --- Created attachment 96022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96022&action=edit Bug 20256: Use new methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:06:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:06:55 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #52 from Kyle M Hall --- Created attachment 96023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96023&action=edit Bug 20256: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:06:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:06:58 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #53 from Kyle M Hall --- Created attachment 96024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96024&action=edit Bug 20256: (QA follow-up) Remove double negative from code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:07:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:07:02 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #54 from Kyle M Hall --- Created attachment 96025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96025&action=edit Bug 20256: (QA follow-up) Change meaning should change code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:07:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:07:05 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #55 from Kyle M Hall --- Created attachment 96026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96026&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:07:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:07:08 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #56 from Kyle M Hall --- Created attachment 96027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96027&action=edit Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:07:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:07:11 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #57 from Kyle M Hall --- Created attachment 96028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96028&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:07:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:07:15 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #58 from Kyle M Hall --- Created attachment 96029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96029&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:07:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:07:18 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #59 from Kyle M Hall --- Created attachment 96030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96030&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:07:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:07:21 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #60 from Kyle M Hall --- Created attachment 96031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96031&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:07:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:07:24 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #61 from Kyle M Hall --- Created attachment 96032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96032&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:07:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:07:25 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #13 from Andrew Isherwood --- Sounds reasonable to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:07:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:07:27 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #62 from Kyle M Hall --- Created attachment 96033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96033&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:11:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:11:44 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #14 from Nick Clemens --- (In reply to Jonathan Druart from comment #12) > (In reply to Jonathan Druart from comment #10) > > Sorry, trying to make this moving forward but it's confusing me. > > > > I am also expecting to see "Make an Interlibrary loan request" even if > > "suggestions" is turned off. > > If we all agree on that, I am going to provide a patch. I agree and Katrin seems to agree above, I think this works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:12:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:12:42 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- That makes it untranslatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:20:10 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 --- Comment #8 from Katrin Fischer --- (In reply to Jonathan Druart from comment #7) > That makes it untranslatable. Can you explain? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:20:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:20:54 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:20:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:20:58 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #15 from Jonathan Druart --- Created attachment 96034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96034&action=edit Bug 21270: Display "Make an Interlibrary loan request" even if "suggestions" is turned off Test plan: - Turn off "suggestions" - Enable ILLModule When logged in you should see the "Make an Interlibrary loan request" on the opac search result if not result is displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:24:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:24:55 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|philippe.blouin at inlibro.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:29:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:29:46 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95807|0 |1 is obsolete| | --- Comment #16 from Andrew Isherwood --- Created attachment 96035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96035&action=edit Bug 21270: "Not finding what you're looking for" displaying uselessly When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled. Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user. Just taunting them... TEST: 0) Set IllModule to true, AnonSuggestions to false. 1) Without login, just to an OPAC search. At the bottom will be a nice string laughing at your failed search 2) Apply the patch. 3) Problem at 1) is fixed. 4) Login to validate that ILL link now appear. 5) Modify combination of IllModule and AnonSuggestions to validate links appearing. Patch applies and functions as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:29:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:29:49 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96034|0 |1 is obsolete| | --- Comment #17 from Andrew Isherwood --- Created attachment 96036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96036&action=edit Bug 21270: Display "Make an Interlibrary loan request" even if "suggestions" is turned off Test plan: - Turn off "suggestions" - Enable ILLModule When logged in you should see the "Make an Interlibrary loan request" on the opac search result if not result is displayed Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:30:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:30:53 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:30:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:30:57 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96036|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 96037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96037&action=edit Bug 21270: Display "Make an Interlibrary loan request" even if "suggestions" is turned off Test plan: - Turn off "suggestions" - Turn on "ILLModule" => When logged in you should see the "Make an Interlibrary loan request" - Turn on "suggestions" - Turn off "ILLModule" => When logged in you should see the "Make a purchase suggestion" - Turn on "suggestions" - Turn on "ILLModule" => When logged in you should see both links. - Turn off "suggestions" - Turn off "ILLModule" => You should not see the "Not finding what you're looking for?" block - Turn on "suggestions" - Turn on AnonSuggestions => You should see the "Make a purchase suggestion" even when logged out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:31:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:31:45 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Not finding what you're |"Not finding what you're |looking for displaying |looking" display needs to |uselessly |be fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:32:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:32:44 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #19 from Andrew Isherwood --- I was a bit premature with my signoff, sorry! I'll obsolete my signoff patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:33:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:33:45 +0000 Subject: [Koha-bugs] [Bug 16655] Date due error with SIP2 checkouts and holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16655 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Magnus Enger --- Looks like a restart solved the problem. Marking this as a duplicate of bug 23640. *** This bug has been marked as a duplicate of bug 23640 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:33:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:33:45 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hblancoca at gmail.com --- Comment #22 from Magnus Enger --- *** Bug 16655 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:35:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:35:30 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 --- Comment #9 from Jonathan Druart --- The strings in the template are: """ You already have at least one [% bibitemloo.forced_hold_level %] level hold on this title. All further holds must be [% bibitemloo.forced_hold_level %] level. """ With forced_hold_level == "item" or "biblio". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:41:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:41:59 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:42:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:42:02 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94773|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 96038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96038&action=edit Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Signed-off-by: Jessica Zairo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 13:43:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 12:43:14 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Note: I did not test this patch, trusting author and tester. Nick, it is better to use "logged_in_user" instead of other loggedin* variables, which should be remove in the future. Not blocker however, and did not want to amend a patch I am not able to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 13:08:12 +0000 Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #41 from Koha Team University Lyon 3 --- I have just verified on a master version and all this fields are available when you enter a new suggestion : publicationyear, place, collectiontitle. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:16:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 13:16:44 +0000 Subject: [Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #42 from Koha Team University Lyon 3 --- Sorry, I have misunderstood the bug. When you add an order from a suggestion, in the order, you have the publicationyear but not the place and the collectiontitle. And this information are not in the biblio notice created from the order. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:26:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 13:26:31 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from Andrew Isherwood --- I just retested with the full test plan and all is fine, so I have kept my sign off patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 14:58:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 13:58:10 +0000 Subject: [Koha-bugs] [Bug 24070] koha_es killed, missing RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24070 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #5 from Tomás Cohen Arazi --- RAM has been added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:05:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:05:01 +0000 Subject: [Koha-bugs] [Bug 24179] New: Preserve subfield order when linking authority Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24179 Bug ID: 24179 Summary: Preserve subfield order when linking authority Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To test: - Creste an authority with values in the 150$a, 150$z, and 150$v - In your authority, order the subfields $a, $z, $v - Create a new bib in the basic cataloging interface - manually link your bib to your authority - note that the bib reorders the subfields to $a, $v, $z Tested on 18.11 and master. Advanced editor doesn't do this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:05:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:05:16 +0000 Subject: [Koha-bugs] [Bug 24179] Preserve subfield order when linking authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24179 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:10:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:10:20 +0000 Subject: [Koha-bugs] [Bug 24180] New: maintain separate repeated subfields when linking authority in advanced catalog editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24180 Bug ID: 24180 Summary: maintain separate repeated subfields when linking authority in advanced catalog editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To test: - create an authority record with two 150$z fields - create a new bib in the advanced editor - link your bib to your authority - note your two $z subfields have been concatenated Tested this on master with specifically a topical term authority linking to a 650, though I don't suspect those details will make a difference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:10:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:10:32 +0000 Subject: [Koha-bugs] [Bug 24180] maintain separate repeated subfields when linking authority in advanced catalog editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24180 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:16:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:16:37 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #63 from Jonathan Druart --- Hi Kyle, I am not able to test: Can't call method "libraries_where_can_edit_items" on an undefined value at /kohadevbox/koha/cataloguing/additem.pl line 178 Also, do not you think "edit_any_items" description should refer to "libraries in the same group" and not only "home library"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:25:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:25:43 +0000 Subject: [Koha-bugs] [Bug 23783] Show languages from MARC21 field 041 in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:25:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:25:48 +0000 Subject: [Koha-bugs] [Bug 23783] Show languages from MARC21 field 041 in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95931|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 96039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96039&action=edit Bug 23783: Show languages from MARC21 field 041 in OPAC This copies the changes made in bug 20364 for the staff interface to the OPAC. Some slight changes have been made in comparison: - OPAC uses the class "separator" for the characters that are used between repeatable tags. "sep" as used in the original patch set has some CSS rules attached to it that break display, so it makes double sense to change it. - We revently removed ending . from the display in OPAC - so it's done here too. To test: 1) Apply patch 2) Do a search in the OPAC and check the results look correct 3) Check some biblio detail pages and verify that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:26:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:26:02 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95983|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 96040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96040&action=edit Bug 24164: Copy the letter for each email To test: 1 - Set or have two patrons with emails - note thier borrowernumber for the report 2 - Create a report - note the report id SELECT borrowernumber, surname, firstname WHERE borrowernumber IN (##,##); 3 - Create a notice in circulation with code TESTEMAIL 4 - The content should be "[% surname %]" 5 - perl misc/cronjobs/patron_emailer.pl --report ## --notice TESTEMAIL --module circulation --from anyone at anywhere.com --verbose 6 - Note that the emails both have the same surname 7 - Apply patch 8 - Repeat 5 9 - Emails now have correct content Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:26:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:26:55 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 --- Comment #2 from Matthias Meusburger --- Created attachment 96041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96041&action=edit Bug 21520: More complex OAI sets mappings Currently, the rules used to create OAI sets are processed with the 'or' boolean operator between each rule. This patch allows to use 'or' or 'and' between the rules. The evaluation of the rules is done according to the boolean operators precedence: AND has a higher precedence than OR. For example: A and B or C and D will be evaluated as follow: (A and B) or (C and D) Test plan: - Apply the patch - Apply the atomicupdate - Prove t/db_dependant/OAI/AndSets.t - Check that existing mappings still work - Try modifying existing mappings - Try creating new mappings - Check that the boolean operators precedence is correctly taken into account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:27:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:27:22 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:39:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:39:38 +0000 Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:39:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:39:42 +0000 Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95892|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 96042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96042&action=edit Bug 11500: Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) This patch modifies the cataloging plugin dateaccessioned.pl so that it triggers the addition of a datepicker widget to fields it is linked with. Despite its name the plugin can be used on any item field which requires a date. To test, apply the patch and make sure you have one or more item subfields linked to the dateaccessioned.pl plugin. For instance, in MARC21: - Administration -> MARC bibliographic framework -> MARC structure -> 952 -> Edit subfields: - subfields d ("Date acquired") and w ("Price effective from"): - Other options -> Plugin -> dateaccessioned.pl - Go to cataloging and add or edit an item on a bibliographic record - The "Date acquired" and "Price effective from" fields should be styled as datepickers. - Clicking in these fields should populate the field with today's date and trigger the datepicker popup. - Test that all the datepicker features work correctly. - Test that manual entry of a date works. - With the AcqCreateItem system preference set to "placing an order," go to Acquisitions -> Vendor -> Add to basket. - Add a title to your basket using your preferred method. - In the "New order" form, find the section for adding an item. - Test the "Date acquired" and "Price effective from" fields, which should behave just like they did in the cataloging module. Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:48:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:48:45 +0000 Subject: [Koha-bugs] [Bug 24059] Remove unused Greybox assets from detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |21891 --- Comment #2 from Jonathan Druart --- Usage removed by bug 21891. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 [Bug 21891] Remove non-XSLT detail view in the staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:48:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:48:45 +0000 Subject: [Koha-bugs] [Bug 21891] Remove non-XSLT detail view in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24059 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 [Bug 24059] Remove unused Greybox assets from detail.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:49:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:49:35 +0000 Subject: [Koha-bugs] [Bug 24059] Remove unused Greybox assets from detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 15:49:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 14:49:38 +0000 Subject: [Koha-bugs] [Bug 24059] Remove unused Greybox assets from detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95522|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 96043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96043&action=edit Bug 24059: Remove unused Greybox assets from detail.tt This patch removes reference to the Greybox include file because it is unused. To test, apply the patch and view the bibliographic details page. Test various JavaScript-driven interactions to make sure no functionality has been broken: Menus, tabs, table filters, MARC Preview, etc. Searching for "gb-" or "GB_" should return no results in any files related to the details page. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:27:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 15:27:33 +0000 Subject: [Koha-bugs] [Bug 24181] New: Make our datepicker inputs sexy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Bug ID: 24181 Summary: Make our datepicker inputs sexy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:29:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 15:29:49 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:29:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 15:29:52 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #1 from Jonathan Druart --- Created attachment 96044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96044&action=edit Bug 24181: Make our datepicker inputs sexy They are skinny and different from others. Not that a problem, I am too. But I do not think it is what they need. Test plan: Edit a patron and take a look at the input for "Date of birth" => Before this patch they are not looking great => After this patch they are beautiful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:33:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 15:33:19 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #2 from Jonathan Druart --- Created attachment 96045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96045&action=edit Bug 24181: Move the icon back into the input -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:34:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 15:34:50 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #3 from Jonathan Druart --- Before: https://snipboard.io/zOPV4F.jpg After: https://snipboard.io/U4xVrq.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:42:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 15:42:19 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #27 from Jonathan Druart --- The patch fixes the creation with strict_sql_modes on (comment 1), but not the edition from comment 0 Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 16:42:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 15:42:26 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:01:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 16:01:31 +0000 Subject: [Koha-bugs] [Bug 19465] Allow choosing Elasticsearch server on instance creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:01:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 16:01:34 +0000 Subject: [Koha-bugs] [Bug 19465] Allow choosing Elasticsearch server on instance creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80748|0 |1 is obsolete| | Attachment #90074|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 96046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96046&action=edit Bug 19465: Add --elasticsearch-server option to koha-create This patch adds the --elasticsearch-server option switch to koha-create. It allows choosing a different Elasticsearch configuration. It defaults to the current 'localhost:9200' value. To test: - Apply this patches - Run: $ reset_all $ man koha-create => SUCCESS: The man page shows correct information about the added option switch - Run: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml contains the default value (i.e. the current behaviour is kept) - Run: $ sudo koha-create --create-db --elasticsearch-server tomas:1234 test2 => SUCCESS: /etc/koha/sites/test2/koha-conf.xml contains the passed value in the section. - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:01:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 16:01:38 +0000 Subject: [Koha-bugs] [Bug 19465] Allow choosing Elasticsearch server on instance creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 --- Comment #11 from Jonathan Druart --- Created attachment 96047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96047&action=edit Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi Signed-off-by: Bouzid Fergani Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:11:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 16:11:30 +0000 Subject: [Koha-bugs] [Bug 23783] Show languages from MARC21 field 041 in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 --- Comment #4 from Katrin Fischer --- Thanks Joubu and Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:12:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 16:12:07 +0000 Subject: [Koha-bugs] [Bug 24182] New: Cancelling a hold floods the logs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24182 Bug ID: 24182 Summary: Cancelling a hold floods the logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com 382 C4::Log::logaction( 'HOLDS', 'CANCEL', $self->reserve_id, Dumper($self->unblessed) ) 383 if C4::Context->preference('HoldsLog'); This ends up loggining a date time object for the cancellation date: 357 $self->cancellationdate( dt_from_string->strftime( '%Y-%m-%d %H:%M:%S' ) ); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:15:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 16:15:37 +0000 Subject: [Koha-bugs] [Bug 24182] Cancelling a hold floods the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24182 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 23219 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:15:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 16:15:37 +0000 Subject: [Koha-bugs] [Bug 23219] Show a warning about cancelling their holds before a patron is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23219 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #18 from Nick Clemens --- *** Bug 24182 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 17:18:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 16:18:43 +0000 Subject: [Koha-bugs] [Bug 24182] Cancelling a hold floods the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24182 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |19.05 Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #2 from Nick Clemens --- Actually, we may want to cherry-pick the fix for this for stable versions: $self->cancellationdate(dt_from_string); to $self->cancellationdate( dt_from_string->strftime( '%Y-%m-%d %H:%M:%S' ) ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 18:12:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 17:12:16 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 --- Comment #7 from Martin Renvoize --- I was waiting on proper support for Debian 10 before announcing the deprecation of D8 (and U16). But, I think this has dragged on long enough.. I'll have a go at drafting something tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 18:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 17:29:06 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass --- Hey Jonathan, I applied this patch and ran yarn build, it looks sexy in Chrome but not in FF as the calendar icon is doubling up. FireFox: https://snipboard.io/jxb7z6.jpg Chrome: https://snipboard.io/R6bjuS.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 18:41:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 17:41:58 +0000 Subject: [Koha-bugs] [Bug 24183] New: Introduce `before_send_messages` hook Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183 Bug ID: 24183 Summary: Introduce `before_send_messages` hook Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org It would be beneficial to have a hook inside process_message_queue.pl to allow plugins the option of taking pre-processing actions on the messages in the message queue before they are sent. An example of where this would be beneficial is the Recalls plugin, where currently one has take serverside actions to configure additional cronjobs as part of setting the plugin up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 18:42:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 17:42:06 +0000 Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 18:45:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 17:45:55 +0000 Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183 --- Comment #1 from Martin Renvoize --- Created attachment 96048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96048&action=edit Bug 24183: Add before_send_messages hook This patch adds a simple hook to the process_message_queue cronjob to allow plugins to pre-process messages in the messaging queue before they are sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 18:46:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 17:46:10 +0000 Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 18:46:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 17:46:31 +0000 Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 18:46:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 17:46:36 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95456|0 |1 is obsolete| | --- Comment #14 from ByWater Sandboxes --- Created attachment 96049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96049&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure renewals are allowed in circ rules 4. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row Signed-off-by: tgoat Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 18:07:43 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96049|0 |1 is obsolete| | --- Comment #15 from ByWater Sandboxes --- Created attachment 96050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96050&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure renewals are allowed in circ rules 4. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row Signed-off-by: tgoat Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:10:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 18:10:45 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Monique changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |monique.prive at northernvermo | |nt.edu --- Comment #2 from Monique --- This would be a great addition. Often I physically receive all the items in my basket and have to go through several steps in order to receive just one item. It takes up a lot of time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 19:17:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 18:17:18 +0000 Subject: [Koha-bugs] [Bug 23818] Acquisitions receipt created when an item or invoice is received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23818 Monique changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |monique.prive at northernvermo | |nt.edu --- Comment #6 from Monique --- This would save a lot of writing all this information on a slip. It would be nice to have the Biblio # on the slip. It would be nice if we could choose the information we wanted displayed at the top of the slip. We don't use Branches or Holds on new material. Fund information would be nice as well as the internal notes in our Basket line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:38:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 19:38:14 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 19:44:03 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #5 from Blou --- Created attachment 96051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96051&action=edit Bug 24172: Allow translation of seasons in details.tt and opac-details.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:47:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 19:47:00 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 20:52:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 19:52:43 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com, | |kyle at bywatersolutions.com, | |lucas at bywatersolutions.com, | |nick at bywatersolutions.com Keywords| |rel_19_05_candidate, | |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 21:00:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 20:00:13 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com, | |kyle at bywatersolutions.com, | |lucas at bywatersolutions.com, | |nick at bywatersolutions.com Keywords| |rel_19_05_candidate, | |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 21:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 20:53:33 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Michal Denar --- Hello Mathias, thank you for patch. I tested it but if I add AND operator, whole updated set gone from OAI: vagrant at kohadevbox:kohaclone(bug_21520)$ sudo koha-foreach --enabled /usr/share/koha/bin/migration_tools/build_oai_sets.pl -i -r Summary: Set 'test': 303 biblios Set 'NKP': 303 biblios Updating database... done. vagrant at kohadevbox:kohaclone(bug_21520)$ sudo koha-foreach --enabled /usr/share/koha/bin/migration_tools/build_oai_sets.pl -i -r Summary: Set 'NKP': 303 biblios Updating database... done. Can you review code? Thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 21:56:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 20:56:37 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Michal Denar --- Sorry, my fault. Wrong boolean operators. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:02:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 21:02:09 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:02:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 21:02:12 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96041|0 |1 is obsolete| | --- Comment #5 from Michal Denar --- Created attachment 96052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96052&action=edit Bug 21520: More complex OAI sets mappings Currently, the rules used to create OAI sets are processed with the 'or' boolean operator between each rule. This patch allows to use 'or' or 'and' between the rules. The evaluation of the rules is done according to the boolean operators precedence: AND has a higher precedence than OR. For example: A and B or C and D will be evaluated as follow: (A and B) or (C and D) Test plan: - Apply the patch - Apply the atomicupdate - Prove t/db_dependant/OAI/AndSets.t - Check that existing mappings still work - Try modifying existing mappings - Try creating new mappings - Check that the boolean operators precedence is correctly taken into account Great work! Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:17:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 21:17:12 +0000 Subject: [Koha-bugs] [Bug 24184] New: Reword FallbackToSMSIfNoEmail syspref text Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Bug ID: 24184 Summary: Reword FallbackToSMSIfNoEmail syspref text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This syspref was added in Bug 16149 and allows purchase suggestion notices to send via SMS if no email is present. As far as I know, the syspref only applies to purchase suggestion notices. The wording on the syspref is "(Disable/Enable) Send messages by SMS if no patron email is defined." Without the context gained by reading Bug 16149, this system preference very much suggest that it applies to *all* notices. I suggest changing this to "(Disable/Enable) Send purchase suggestion messages by SMS if no patron email is defined." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:34:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 21:34:06 +0000 Subject: [Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in hold confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Lucas Gass --- Owen, I can no longer cleanly apply this patch to master. If you can rebase it, I will attempt to sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:39:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 21:39:10 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 --- Comment #1 from Andrew Fuerste-Henry --- Whoops, but the wrong bug number in my description above. This syspref comes from bug 21241. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:42:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 21:42:43 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:54:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 21:54:15 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:54:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 21:54:18 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 --- Comment #2 from Lucas Gass --- Created attachment 96053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96053&action=edit Bug 24184: Reword FallbackToSMSIfNoEmail syspref text TEST PLAN: 1. Apply patch 2. Confirm new wording looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:55:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 21:55:52 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|andrew at bywatersolutions.com |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:57:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 21:57:40 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96053|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 96054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96054&action=edit Bug 24184: Reword FallbackToSMSIfNoEmail syspref text Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 22:58:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 21:58:01 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:12:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 22:12:31 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:12:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 22:12:35 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 --- Comment #1 from Agustín Moyano --- Created attachment 96055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96055&action=edit Bug 23571: [DO NOT PUSH] crash condition builder This patch adds t/db_dependent/bug_23571_crash_condition_builder.t file This file is not intended to be part of Koha, but it's used to emulate crash conditions. It will create 5000 users, 5000 biblios with 2 items each, and each item issued to a user. It really takes a lot of time, so please be zen about it ;) To use it execute prove t/db_dependent/bug_23571_crash_condition_builder.t Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:12:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 22:12:38 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 --- Comment #2 from Agustín Moyano --- Created attachment 96056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96056&action=edit Bug 23571: Add flock to fines.pl This patch adds a lock file for fines.pl. To test: 1. Apply this patch 2. In two separate consoles run misc/cronjobs/fines.pl SUCCESS => The first one runs normally, but the second one fails with a message flock failed for the lock file. 3. Sign off. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 5 23:13:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Dec 2019 22:13:54 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 08:16:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 07:16:48 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 --- Comment #20 from Marcel de Rooy --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL filters missing_filter at line 367 ( There is an item level hold on this item (priority = [% hold.priority %]).) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 08:18:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 07:18:28 +0000 Subject: [Koha-bugs] [Bug 18105] Should we restart koha-indexer differently i.e. like koha-plack? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18105 --- Comment #4 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #3) > I'm taking this one, as I'll be revisiting all the daemon handling scripts > as part of the containerization effort. Great! I am all for containerization. Did I miss something on this "containerization effort" ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 08:21:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 07:21:28 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #16 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 08:36:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 07:36:52 +0000 Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #5 from Marcel de Rooy --- I almost added similar comments on 21761 until I spotted this one. Obviously, implementing update on a larger resultset by looping and storing individually will be a performance thing. Wouldnt it be beneficial to pass to DBIx if there is no specific store method in the corresponding Koha object ? -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 09:35:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 08:35:28 +0000 Subject: [Koha-bugs] [Bug 23696] build_oai_sets.pl should take biblios from deletedbiblio_metadata too In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23696 --- Comment #5 from Josef Moravec --- (In reply to Katrin Fischer from comment #4) > This patch appears pretty straight-forward and it works for me, but I am > having trouble with rerunning the script: > > 1) On running the script a second time, I get a lot of errors: > DBD::mysql::st execute failed: Duplicate entry '50-1' for key 'PRIMARY' [for > Statement " > INSERT INTO oai_sets_biblios (set_id, biblionumber) > VALUES (?,?) > " with ParamValues: 0='1', 1=50] at > /home/vagrant/kohaclone/C4/OAI/Sets.pm line 597. > DBD::mysql::st execute failed: Duplicate entry '52-1' for key 'PRIMARY' [for > Statement " > INSERT INTO oai_sets_biblios (set_id, biblionumber) > VALUES (?,?) > " with ParamValues: 0='1', 1=52] at > /home/vagrant/kohaclone/C4/OAI/Sets.pm line 597. Hi Katrin, thanks for testing! when you are running this script more than once, you need to add -r parameter - it will clean the table before generating it again. > > 2) Also the links for Metadata and Set don't appear to work in our HTML > representation of the OAI-Server: > > /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc&set=TEST Can you add more details to this question? > > 3) Even without the patch and after rerunning the script reporting 45 > records (instead of the 46 it should have), I still can see a deleted record > in the web output of the set. The access to records are not limited by set, you can use OAI without set parameter in Koha. And it is OK, because set is optional by standard: http://www.openarchives.org/OAI/openarchivesprotocol.html#Set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:12:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:12:20 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #17 from Marcel de Rooy --- Patrons.t fails on set_password set_password contains an update (which was formerly DBIx, and now no longer), so it is now routed back to sub store which starts another txn_do store contains a get_from_storage for the password, and here we end up in some transaction problem with wrong data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:16:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:16:24 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:16:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:16:27 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96054|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 96057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96057&action=edit Bug 24184: Reword FallbackToSMSIfNoEmail syspref text Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:16:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:16:46 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- We might consider renaming the pref here ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:19:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:19:09 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:19:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:19:11 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95995|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 96058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96058&action=edit Bug 24170: Fix sysprefs search result order The same sysprefs search will not always return the results in the same order. If you search for 'd' in the "search system preferences" box /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=d you will see that the modules are not ordered consistently. This patch makes them display alphabetically Test plan: Search the same string several times in the syspref list. The search result should always be ordered the same way Signed-off-by: cori Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:19:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:19:31 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:19:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:19:41 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:19:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:19:54 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:27:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:27:46 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #21 from Marcel de Rooy --- QAing Intrigued, cant we do this simpler? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:46:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:46:48 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:46:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:46:52 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96035|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy --- Created attachment 96059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96059&action=edit Bug 21270: "Not finding what you're looking for" displaying uselessly When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled. Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user. Just taunting them... TEST: 0) Set IllModule to true, AnonSuggestions to false. 1) Without login, just to an OPAC search. At the bottom will be a nice string laughing at your failed search 2) Apply the patch. 3) Problem at 1) is fixed. 4) Login to validate that ILL link now appear. 5) Modify combination of IllModule and AnonSuggestions to validate links appearing. Patch applies and functions as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Andrew Isherwood Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:46:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:46:57 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96037|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy --- Created attachment 96060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96060&action=edit Bug 21270: Display "Make an Interlibrary loan request" even if "suggestions" is turned off Test plan: - Turn off "suggestions" - Turn on "ILLModule" => When logged in you should see the "Make an Interlibrary loan request" - Turn on "suggestions" - Turn off "ILLModule" => When logged in you should see the "Make a purchase suggestion" - Turn on "suggestions" - Turn on "ILLModule" => When logged in you should see both links. - Turn off "suggestions" - Turn off "ILLModule" => You should not see the "Not finding what you're looking for?" block - Turn on "suggestions" - Turn on AnonSuggestions => You should see the "Make a purchase suggestion" even when logged out Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:47:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:47:25 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #24 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #21) > QAing Intrigued, cant we do this simpler? Probably only marginal ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:47:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:47:33 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:48:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:48:33 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #9 from Katrin Fischer --- We found this in 18.11 - please backport! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:50:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:50:38 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:50:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:50:41 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95991|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 96061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96061&action=edit Bug 23970: Make search with "Publication date" field work at any position The changes made in the following commit: commit 0d2e83bca5b91376e9262b6cb0b993f09b919018 Bug 14636: Item search - fix search and sort by publication date for MARC21 was put at the wrong place. It was inside a "if $i == 1" test that impacts the first field only. Test plan: 0/ Use a MARC21 installation 1/ Search items by publication date, use twice the field using different values. For instance: publication date: 2005 OR publication date: 2006 => Without this patch you only get results for 2005 => With this patch applied you get results for both years. Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:50:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:50:51 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:56:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:56:51 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:56:55 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95882|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 96062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96062&action=edit Bug 24136: Update sponsors for 19.11 cycle Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 10:57:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 09:57:11 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 11:01:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 10:01:25 +0000 Subject: [Koha-bugs] [Bug 24185] New: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Bug ID: 24185 Summary: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nugged at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest" called many times with hundred of items and "on shelf holds" parameter set to "If all unavailable" for these items+patron, it goes very slow. This happens because in subloop there are re-checking if all other item unavailable so it is O(n^2) and it re-checks each time a lot of the same info for each item with repeating DB/data requests, these three: - GetBranchItemRule (per item type) - IsItemOnHoldAndFound (per item) - notforloan (per item) Proposed fix: I created patch to have in-variable cache in upper-level subroutine before entering the first "items" loop and passing that hash reference down into subs to cache these three values by keys per-item and per-item-type. It is simplest way to make it fast without re-thinking pretty complicated whole algorithm and business logic, and, when tested by speed it gave big improvement in execution time. How to reproduce: 1) on fresh installed kohadevbox create/import one book, record that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", so that rule will match above book items/libary/patron, check that rule to have non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create direct link by yourself, for example in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time. I tested on my computer in VirtualBox for this page generation times, (stats below is for many runs and smallest value taken from similar in a repetition), last one block eith times with that in-var-cache solution I am proposing: "On shelf holds allowed" != "If all unavailable": for 100 items: 5 seconds, for 200 items: 10 seconds, for 300 items: 11 seconds, "On shelf holds allowed" == "If all unavailable": for 100 items: 50 seconds, for 200 items: 3.1 minutes, for 300 items: 7.0 minutes, "On shelf holds allowed" == "If all unavailable" with cache: for 100 items: 7 seconds, for 200 items: 20 seconds, for 300 items: 38 seconds, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 11:01:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 10:01:50 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |nugged at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 11:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 10:20:10 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Hmm. I actually do not see the difference this patch makes. Looks to me if nothing really changes here. Before we tested $var->{status} eq 'OK' and now we put status into $var and test $var eq 'OK'. Where is the bug that we should solve ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 11:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 10:31:21 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #12 from Andrew Isherwood --- Created attachment 96063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96063&action=edit Bug 23961: (follow-up) Remove data duplication In response to Séverine observations in comment #10, this patch removes the duplicate logging of the borrowernumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 11:32:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 10:32:43 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #13 from Andrew Isherwood --- (In reply to Séverine Queune from comment #10) > 3 things about this MODIFY_BASKET log : > - as the borrowernumber is saved in the 'user' field, why duplicating it > in the 'info' field ? Thanks for point this out, I have attached a patch that removes this duplication. > - in this 'info' field, we usually have the details of the action made by > the user. To me, the information displays for now in not really usefull. The idea is that we're logging the minimal amount of information in the action logs but, through a report, it would be possible to obtain additional information about the related objects as required, such as basket, borrower etc. This logging is very much a starting point, I'll be elaborating on this point in response to Katrin's message. > - I only get log when I modify the "Managing library" but not when I > update the managers of the basket, not when I edit the basket. Is that the > expected behaviour ? Again, this logging is a starting point > > > - Approve a basket via EDI > > => TEST: Observe that an Acquisitions action log has been created containing: > > => Basket number > > => Borrowernumber of the user who approved the basket, this is stored in > > "info" as a left padded 10 digit number which can be joined on to the > > borrowers table > I tried several EDI settings but it still doesn't work so one mode ime, I > didn't test this part (would be happy if someone could help !). Thanks, I'll do some testing and fix any problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 11:57:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 10:57:11 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #14 from Andrew Isherwood --- (In reply to Katrin Fischer from comment #11) > I am sorry... but I'd like to at least try to explain my point of view a bit > more. This bug states to add logging for basket related actions and of all > the basket related actions one is missing. I don't feel this is out of scope > at all. I've thought about why this is bothering me so much. I think it > comes down to this: One of the biggest challenges we face is to develop Koha > to be consistent and intuitive, to work as one piece of software, for > everyone using it. When I have a feeling that something will cause question > marks, and have me say: 'I know that doesn't make sense' to a library later, > I feel I have to point it out. Hi Katrin Thanks for your comments :) Firstly, I *completely* understand what you're saying and agree with everything. The challenge I face is that we have very specific requirements from the customer who is sponsoring this work and the patches that I have created address those requirements. So my comment about additional logging being out of scope meant that it was out of scope of those requirements. You're right, it is not out of scope of basket logging. There are many actions that can be performed on a basket, Séverine highlighted this by pointing out that logging did not occur when a basket manager is changed. Our requirement was to add logging of basket modification in the context of modifying the basket contents. Ideally, this bug would log every possible action on a basket, but that would significantly increase development time. I feel that this work is a foundation which will facilitate the addition of further logging. That said, I am about to create a patch to add basket reopening and basket header modification logging since those were specifically mentioned by yourself and Séverine. It's also worth me pointing out that I am about to embark on a further Acq logging development that is being sponsored by another customer, this will add substantial logging to other areas of Acq and will hopefully partly address some of your concerns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:12:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:12:40 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:15:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:15:06 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #8 from Marcel de Rooy --- my $suspension_days = $deltadays * $finedays; finedays is a number, deltadays is not ? and then: floor( $suspension_days->in_units('days') etc suspension_days is just a number not a duration? Does not look good to me. Why do the tests pass ? Do we need more tests ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:15:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:15:56 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |m.de.rooy at rijksmuseum.nl |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:17:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:17:02 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #15 from Katrin Fischer --- (In reply to Andrew Isherwood from comment #14) > (In reply to Katrin Fischer from comment #11) > > > I am sorry... but I'd like to at least try to explain my point of view a bit > > more. This bug states to add logging for basket related actions and of all > > the basket related actions one is missing. I don't feel this is out of scope > > at all. I've thought about why this is bothering me so much. I think it > > comes down to this: One of the biggest challenges we face is to develop Koha > > to be consistent and intuitive, to work as one piece of software, for > > everyone using it. When I have a feeling that something will cause question > > marks, and have me say: 'I know that doesn't make sense' to a library later, > > I feel I have to point it out. > > Hi Katrin > > Thanks for your comments :) Firstly, I *completely* understand what you're > saying and agree with everything. The challenge I face is that we have very > specific requirements from the customer who is sponsoring this work and the > patches that I have created address those requirements. So my comment about > additional logging being out of scope meant that it was out of scope of > those requirements. You're right, it is not out of scope of basket logging. > > There are many actions that can be performed on a basket, Séverine > highlighted this by pointing out that logging did not occur when a basket > manager is changed. Our requirement was to add logging of basket > modification in the context of modifying the basket contents. Ideally, this > bug would log every possible action on a basket, but that would > significantly increase development time. I feel that this work is a > foundation which will facilitate the addition of further logging. > > That said, I am about to create a patch to add basket reopening and basket > header modification logging since those were specifically mentioned by > yourself and Séverine. > > It's also worth me pointing out that I am about to embark on a further Acq > logging development that is being sponsored by another customer, this will > add substantial logging to other areas of Acq and will hopefully partly > address some of your concerns. Thx Andrew for not getting this wrong most of all :) Also for considering an additon - you are right, Severine made a good point about the basket users. I am not going to block this and secretly hope the path of logging might lead you in direction of funds and budgetes - I know this was often wished for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:18:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:18:58 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #9 from Marcel de Rooy --- Why do we need a fine charging interval and a suspension interval btw ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:22:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:22:18 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #16 from Andrew Isherwood --- (In reply to Katrin Fischer from comment #15) > [..] I am not going to block this and secretly hope the > path of logging might lead you in direction of funds and budgetes - I know > this was often wished for. Well, you will hopefully be pleased. These are the requirements for the next work I am doing: 1. Order line cancellations This would show order line details including who made the cancellation and when the cancellation was made 2. Order line creations This would show order line details including who created the order line, when it was created, the fund, and amount 3. Invoice adjustment additions This would show the adjustment details, who added the adjustment, when it was added, the fund, and amount 4. Invoice adjustment amendments This would show the adjustment details, who amended the adjustment, when it was amended, the fund, and amount 5. Invoice adjustment deletions This would show the adjustment details, who deleted the adjustment, when it was deleted, the fund, and amount 6. Order line receipts against an invoice This would show the order line details, who received the order line, when it was received, the fund, and amount 7. Budget Adjustments This would show amounts added or removed from a budget (excluding spent), who, when, and amount 8. Fund adjustments This is essentially a bank statement. It would show additions and subtractions to a fund (excluding spent), who, when, amount, previous total, new total 9. Order release date (1) This would show individual order lines from an EDI message, when they were sent, who sent it, fund, and amount 10. Order release date (2) This would show individual order lines from a basket, when it was closed, who closed it, fund, and amount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:23:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:23:19 +0000 Subject: [Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- CC| |katrin.fischer at bsz-bw.de --- Comment #40 from Katrin Fischer --- This was "RESOLVED FIXED" as part of the automatic clean-up after release - I am reopening it because of Christopher's comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:23:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:23:20 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Bug 23091 depends on bug 22877, which changed state. Bug 22877 Summary: Returning a lost item not marked as returned can generate additional overdue fines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:23:21 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #10 from Hugo Agud --- because some libraries doesn't suspend 1 day a patron for every day delayed, as the same way that not all libraries charge 1 usd per every day delayed. In fact I guess that the majority has "x" suspension days for every "y" delayed days, at least in Spain, I am not sure how it works in other countries.. it gives more flexibility to circulation rules hope it helps! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:23:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:23:25 +0000 Subject: [Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:23:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:23:36 +0000 Subject: [Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:23:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:23:43 +0000 Subject: [Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:24:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:24:04 +0000 Subject: [Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:24:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:24:12 +0000 Subject: [Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:25:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:25:52 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #11 from Marcel de Rooy --- (In reply to Hugo Agud from comment #10) > because some libraries doesn't suspend 1 day a patron for every day delayed, > as the same way that not all libraries charge 1 usd per every day delayed. > > In fact I guess that the majority has "x" suspension days for every "y" > delayed days, at least in Spain, I am not sure how it works in other > countries.. it gives more flexibility to circulation rules > > hope it helps! Hi Hugo My question is about the two intervals. Why would you charge 1 usd per 2 days and 2 suspension days per another interval ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:27:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:27:00 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #12 from Marcel de Rooy --- But is not really relevant to ask :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:36:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:36:50 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #17 from Andrew Isherwood --- Created attachment 96064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96064&action=edit Bug 23971: (follow-up) Add additional basket logging This patch adds additional basket logging as discussed in comment #14 - Basket reopening - Basket users (manager) modification - Basket header modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 12:54:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 11:54:00 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Andrew Isherwood --- I can't find any problems with the EDI approval basket closure. I'm going to set this back to "Needs Signoff" as I think I've addressed the additional requirements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 13:53:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 12:53:40 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #1 from Magnus Enger --- This is getting to be a real problem for some of our more ILL-active libraries. One solution could be to just have a syspref that takes a list of statuses that should be hidden by default, perhaps? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 14:04:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 13:04:40 +0000 Subject: [Koha-bugs] [Bug 23541] Duplicate Hold Notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23541 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24106, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24085 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 14:04:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 13:04:40 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23541 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 14:04:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 13:04:40 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23541 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 14:08:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 13:08:06 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #13 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #8) > my $suspension_days = $deltadays * $finedays; > finedays is a number, deltadays is not ? > > and then: > floor( $suspension_days->in_units('days') etc > > suspension_days is just a number not a duration? I am not sure I understand your concern here. perl -MDateTime::Duration -e 'my $dur = DateTime::Duration->new( days => 3 ); $dur *= 3; print $dur->in_units("days")' This is valid and will display 9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 14:09:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 13:09:12 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #14 from Jonathan Druart --- Also note that I am not modifying anything here, just moving up a code that is not at the correct place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 14:10:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 13:10:47 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 --- Comment #5 from Jonathan Druart --- Take a look at the file and search for "can_item_be_reserved". There is another occurrence. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:13:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 15:13:00 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96005|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 96065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96065&action=edit Bug 24146: Add test cases This patch adds test cases for both checking amountoutstanding values are handled correctly and also that the paid down accruing fines do not add additional fines on increment. Test plan: Read the changeset and asses whether the changes/additional tests are correct as per the expected behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:13:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 15:13:03 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96006|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 96066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96066&action=edit Bug 24146: Increment existing fine We should increment an existing fine even if it has been fully paid off whilst it is still incrementing and not create a new fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:13:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 15:13:06 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #11 from Martin Renvoize --- Created attachment 96067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96067&action=edit Bug 24146: Corrections to UpdateFine logic concerning maxFine The `maxFine` system preference actually refers to the amount of outsanding debt (in fines) a patron may have at a given time. This patch corrects the functionality of UpdateFine such that it properly respects that counter given the payment of accruing fines scenario. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:35:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 15:35:47 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 --- Comment #12 from Nick Clemens --- Created attachment 96068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96068&action=edit Bug 24146: Illustrate increasing and decreasing fine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 10:51:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 09:51:33 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 09:00:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 08:00:29 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 --- Comment #2 from Josef Moravec --- Created attachment 96132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96132&action=edit Bug 24177: Import Koha::Account::CreditTypes to cash_register_stats.pl Test plan: 0) Do not apply the patch 1) Confirm the bug - go to Reports -> Cash register --> You will see ISE 2) Apply the patch, and restart_all 3) Confirm the ISE is gone and you see the form for Cash register report -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:18:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:18:14 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #33 from Jonathan Druart --- (In reply to Kelly McElligott from comment #29) > I did not see the message that is indicated in step 2. " Nothing happened > and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process" . > > This would be an extremely helpful message. I received a message that 2 > items were deleted. Yes, they were the correct items to be deleted and left > the item with the hold along. I am not sure with this test plan, if this > message that you note in step 2 should be see. > > See my screenshot. > > Kelly There is something wrong indeed, working on it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 14:18:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 13:18:18 +0000 Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 10:51:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 09:51:37 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #18 from Jonathan Druart --- Created attachment 96136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96136&action=edit Bug 21761: Do not call $self->store in ->set_password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 09:00:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 08:00:47 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|19.11 |master CC| |josef.moravec at gmail.com Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 14:20:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 13:20:20 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #21 from Marcel de Rooy --- (In reply to Joonas Kylmälä from comment #19) > The latest patch is not signed-off yet so marking this as "Needs Signoff". Hi Joonas: Please check the assigned QA contact and if there was recent activity as was here. In that case you can pick another? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 14:27:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 13:27:33 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #22 from Joonas Kylmälä --- (In reply to Marcel de Rooy from comment #21) > Hi Joonas: Please check the assigned QA contact and if there was recent > activity as was here. In that case you can pick another? Thanks, I didn't realize I could check that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:35:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:35:41 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #7 from Jonathan Druart --- Created attachment 96144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96144&action=edit Bug 24181: Move the icon back into the input -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:36:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:36:34 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23956 --- Comment #8 from Jonathan Druart --- (In reply to Lucas Gass from comment #4) > Hey Jonathan, > > I applied this patch and ran yarn build, it looks sexy in Chrome but not in > FF as the calendar icon is doubling up. > > > FireFox: https://snipboard.io/jxb7z6.jpg > Chrome: https://snipboard.io/R6bjuS.jpg Hi Lucas, I did not recreate, I am using Firefox. Maybe a cache issue? (In reply to Owen Leonard from comment #5) > Jonathan did you see Bug 23956? I do like the "After" screenshot. I did not! Rebased on top of it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:35:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:35:38 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96044|0 |1 is obsolete| | Attachment #96045|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 96143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96143&action=edit Bug 24181: Make our datepicker inputs sexy They are skinny and different from others. Not that a problem, I am too. But I do not think it is what they need. Test plan: Edit a patron and take a look at the input for "Date of birth" => Before this patch they are not looking great => After this patch they are beautiful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:36:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:36:34 +0000 Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24181 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 [Bug 24181] Make our datepicker inputs sexy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 14:33:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 13:33:34 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 14:33:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 13:33:37 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95947|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy --- Created attachment 96154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96154&action=edit Bug 21761: Call set + store as update Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Removed a double comma. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 14:33:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 13:33:42 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96136|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy --- Created attachment 96155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96155&action=edit Bug 21761: Do not call $self->store in ->set_password Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:25:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:25:01 +0000 Subject: [Koha-bugs] [Bug 24199] New: t/Auth_with_shibboleth.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Bug ID: 24199 Summary: t/Auth_with_shibboleth.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 23042 # at t/Auth_with_shibboleth.t line 140. # got: 'https://testopac.com/Shibboleth.sso/Login?target=https://testopac.com/cgi-bin/koha/opac-user.pl%3Fparam%3D%22heh%E2%9D%A4%22%26language%3Den-GB' # expected: 'https://testopac.com/Shibboleth.sso/Login?target=https://testopac.com/cgi-bin/koha/opac-user.pl%3Flanguage%3Den-GB%26param%3D%22heh%E2%9D%A4%22' CGI->url_param does not always return the parameters in the same order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 12:02:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 11:02:08 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which library can edit a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to limit which |Add ability to limit which |branch can edit a |library can edit a |bibliographic record |bibliographic record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:40:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:40:28 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #25 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 16:16:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2019 15:16:33 +0000 Subject: [Koha-bugs] [Bug 6154] Default sorting by title doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6154 KohaGeekWien changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |team at gelinger.at -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 06:37:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 05:37:58 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #3 from Alex Buckley --- Created attachment 96125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96125&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set an email in KohaAdminEmailAddress and notice there is no syspref named RedirectAddressForFailedOverdueNotices 2. Set some invalid email addresses in patron records then checkout items to those patrons making the due date in the past 3. Manually run overdue_notices.pl 4. Check the message_queue database table and notice the patrons with invalid email addresses are in an email starting with the content: 'These messages were not sent directly to the patrons.' 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the KohaAdminEmailAddress syspref. 7. Repeat steps 2-4 and notice that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:45:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 13:45:46 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #17 from Marcel de Rooy --- Using in_units from Duration is not entirely without risk btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:23:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 16:23:34 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96068|0 |1 is obsolete| | --- Comment #16 from Nick Clemens --- Created attachment 96072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96072&action=edit Bug 24146: Illustrate increasing and decreasing fine Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 22:17:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 21:17:50 +0000 Subject: [Koha-bugs] [Bug 24196] New: Advanced editor - Save silently fails on session timeout Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24196 Bug ID: 24196 Summary: Advanced editor - Save silently fails on session timeout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: carnold at dgiinc.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When a cataloger is cataloging a record in the Advanced Editor, but the session has timed out and they hit "save" the button turns to a spin and back to a static button, but no message pops up reporting an error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:41:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:41:19 +0000 Subject: [Koha-bugs] [Bug 20799] Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20799 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:24:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:24:44 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:23:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 16:23:26 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96065|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 96069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96069&action=edit Bug 24146: Add test cases This patch adds test cases for both checking amountoutstanding values are handled correctly and also that the paid down accruing fines do not add additional fines on increment. Test plan: Read the changeset and asses whether the changes/additional tests are correct as per the expected behaviour. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 18:35:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 17:35:42 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 12:25:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 11:25:28 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24162 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:29:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:29:22 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 [Bug 24190] Add additional Acquisition logging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 20:19:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 19:19:07 +0000 Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS, HTML, and YAML system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #1 from Owen Leonard --- This patch is too large to attach to Bugzilla so I've put a remote branch here: https://gitlab.com/koha-dev/koha-dev/commits/bug-24193-codemirror-linting Alternatively, a patch for download: https://zivotdesign.com/download/bug-24193-codemirror-linting.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 11:30:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 10:30:01 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 09:49:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 08:49:11 +0000 Subject: [Koha-bugs] [Bug 22833] Don't let users cancel holds connected with ILLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 10:22:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 09:22:45 +0000 Subject: [Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95842|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 96077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96077&action=edit Bug 24127: Remove 'Shelving location' from search dropdown To test: 1 - In staff client enable IntranetCatalogSearchPulldown 2 - Click on the 'Search the catalog' tab 3 - Note 'Shelving location' option in dropdown 4 - Search for code or description of a locatio, no results 5 - Repeat on advanced search 6 - Apply patch 7 - Note option is now removed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:40:57 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #26 from Martin Renvoize --- Thanks for catching that Jonathan.. you beat me to it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 10:08:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 09:08:17 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register(Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 --- Comment #1 from Katrin Fischer --- Confirmed on master - marking blocker as this breaks a major feature in our new stable release: Can't locate object method "search" via package "Koha::Account::CreditTypes" (perhaps you forgot to load "Koha::Account::CreditTypes"?) at /home/vagrant/kohaclone/reports/cash_register_stats.pl line 61 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:29:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 13:29:38 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #16 from Marcel de Rooy --- This could be out of scope: But isnt it strange that calculating chargeable units does not look at FinesIncludeGracePeriod ? I would expect fine and suspension period should follow the same algorithm. But the 'test' $deltadays->subtract($grace)->is_positive() removes the grace days from the suspension calculation.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:40:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:40:38 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 18:46:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 17:46:41 +0000 Subject: [Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 06:37:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 05:37:29 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 11:56:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 10:56:17 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- (In reply to Jonathan Druart from comment #14) > Created attachment 95935 [details] [review] > Bug 24010: Enforce integer values for staffdisplaycount and opacdisplaycount > (second try) Should this be NSO? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 10:22:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 09:22:42 +0000 Subject: [Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:38:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:38:11 +0000 Subject: [Koha-bugs] [Bug 24185] Make holds page fast when 'on shelf holds' set to 'If all unavailable' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'If all unavailable' state |Make holds page fast when |for 'on shelf holds' makes |'on shelf holds' set to 'If |holds page very slow if |all unavailable' |there's a lot of items | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:11:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 13:11:00 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #15 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #13) > (In reply to Marcel de Rooy from comment #8) > > my $suspension_days = $deltadays * $finedays; > > finedays is a number, deltadays is not ? > > > > and then: > > floor( $suspension_days->in_units('days') etc > > > > suspension_days is just a number not a duration? > > I am not sure I understand your concern here. > > perl -MDateTime::Duration -e 'my $dur = DateTime::Duration->new( days => 3 > ); $dur *= 3; print $dur->in_units("days")' > > This is valid and will display 9 Which might be a bit confusing too, but okay. There must still be something wrong somewhere, my test does not work? Will have another look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:46:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 13:46:22 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #18 from Marcel de Rooy --- The main confusion must have been the grace subtraction. So I will pass qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 02:19:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 01:19:53 +0000 Subject: [Koha-bugs] [Bug 24178] New Arrivals books not Display in Opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24178 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- I think your problem is with ByWater's Cover Flow plugin. If that is correct, the issue should be reported on the GitHub page for that plugin: https://github.com/bywatersolutions/koha-plugin-coverflow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:25:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:25:07 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 18:33:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 17:33:28 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 --- Comment #6 from Lucas Gass --- Marcel, FallbackToSMSIfNoEmailForPurchaseSuggestions? Seems long. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 18:35:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 17:35:45 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95725|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 96075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96075&action=edit Bug 24090: Subfield text in red when mandatory in record edition In biblio or autority record edition, color subfield text in red when mandatory. Like patron fields in patron edition form. Test plan : 1) Edit a biblio record 2) See that mandatory subield text is red (#C00) 3) Same in autority record edition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 10:07:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 09:07:39 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register(Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 12:25:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 11:25:28 +0000 Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12502 CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Jonathan, there is a slight overlap with the SO patch for bug 12502 (ISBN, order number) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:23:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 16:23:29 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96066|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 96070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96070&action=edit Bug 24146: Increment existing fine We should increment an existing fine even if it has been fully paid off whilst it is still incrementing and not create a new fine. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:23:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 16:23:32 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96067|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 96071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96071&action=edit Bug 24146: Corrections to UpdateFine logic concerning maxFine The `maxFine` system preference actually refers to the amount of outsanding debt (in fines) a patron may have at a given time. This patch corrects the functionality of UpdateFine such that it properly respects that counter given the payment of accruing fines scenario. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:29:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:29:22 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 [Bug 23971] Add logging for basket related actions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 09:07:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 08:07:48 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96117|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 96133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96133&action=edit Bug 24191: Regression tests This patch adds missing tests for calling objects.search with non-existent column names for sorting, that should be mapped using to_model for that matter. Tests should fail as there's no current use of to_model for building the order_by portion of the query. Sponsored-by: ByWater Solutions Signed-off-by: Owen Leonard Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 18:45:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 17:45:02 +0000 Subject: [Koha-bugs] [Bug 20211] Guarantor/Guarantee and payments ideas [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20211 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:36:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:36:55 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96080|0 |1 is obsolete| | --- Comment #4 from Andrew Nugged --- Created attachment 96151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96151&action=edit Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all unavailable' When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest" called many times with hundred of items and "on shelf holds" parameter set to "If all unavailable" for these items+patron, it goes very slow. This happens because in subloop there are re-checking if all other item unavailable so it is O(n^2) and it re-checks each time a lot of the same info for each item with repeating DB/data requests, these three: - GetBranchItemRule (per item type) - IsItemOnHoldAndFound (per item) - notforloan (per item) Fix: Use in-variable cache in upper-level subroutine before entering the first "items" loop and passing that hash reference down into subs to cache these three values by keys per-item and per-item-type. It is simplest way to make it fast without re-thinking pretty complicated whole algorithm and business logic, and, when tested by speed it gave big improvement in execution time. Also "$can_item_be_reserved->{status} eq 'OK'" moved in "&&" before IsAvailableForItemLevelRequest call to cut away if it false before calling to subroutine. How to reproduce: 1) on fresh installed kohadevbox create/import one book, record that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", so that rule will match above book items/library/patron, check that rule to have non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create direct link by yourself, for example in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time. I tested on my computer in VirtualBox for this page generation times, (stats below is for many runs and smallest value taken from similar in a repetition) (NOT buggy clause, just example how it fast when it not enters that "subloop"): *** "On shelf holds allowed" != "If all unavailable": 100 items: 5 seconds, 200 items: 10 seconds, 300 items: 11 seconds, (buggy clause): *** "On shelf holds allowed" == "If all unavailable": 100 items: 50 seconds, 200 items: 3.1 minutes, 300 items: 7.0 minutes, (same as above clause but fixed with caching in hash): *** "On shelf holds allowed" == "If all unavailable" with cache: 100 items: 7 seconds, 200 items: 20 seconds, 300 items: 38 seconds, Upper last one block with times with this in-var-cache solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:10:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:10:09 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #32 from Jonathan Druart --- Update test plan: > 0/ Setup > Create Biblio B1 with 1 item > Create Biblio B2 with 2 items > Create Biblio B3 with 1+ item > Create Biblio B4 with 1+ item > Place a biblio-level hold on B1 and B2 > Place an item-level hold on B3 > Confirm the holds (to mark them waiting) Read: Confirm the item-level hold, the one placed on B3 only. > 1/ Use the 5 items and delete them in a batch. > => delete of item from B1 is blocked on first screen > => delete of items from B2 is *not* blocked on first screen > => delete of item from B3 is blocked on first screen > => delete of item from B4 is *not* blocked > > Note that you can only select items from B2 and B4 > > 2/ Select them and confirm the deletion > => Nothing happened and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process > > 3/ Remove the biblio-level hold > 4/ Repeat 1 > => The deletion has been effective! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 16:29:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2019 15:29:15 +0000 Subject: [Koha-bugs] [Bug 24188] New: Sorting AZ does not work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24188 Bug ID: 24188 Summary: Sorting AZ does not work Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: team at gelinger.at QA Contact: testopia at bugs.koha-community.org Our client has the latest 19.11 Koha Installed. After search is done, and you change sorting to the Title A-Z or Z-A , it does not work. It's just random. The same applies to the Sorting by Author. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 09:50:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 08:50:48 +0000 Subject: [Koha-bugs] [Bug 22833] Don't let users cancel holds connected with ILLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #1 from Magnus Enger --- Third option: 3. Detect when a hold is related to an ILL request and don't display Suspend/Cancel for these holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 12:31:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2019 11:31:10 +0000 Subject: [Koha-bugs] [Bug 24187] New: Vertically centre the holding details in each table rows in Cataloguing (staff client) and OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24187 Bug ID: 24187 Summary: Vertically centre the holding details in each table rows in Cataloguing (staff client) and OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: iming at rosewoodfarm.com.au QA Contact: testopia at bugs.koha-community.org Vertically centre the holding details in a row to match checkbox and "Edit" button (staff client). Similar issue found in OPAC Holdings as well. Also noticed that catalogue details are not algined with field labels in "Normal" view (staff client). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 09:07:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 08:07:52 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96118|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 96134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96134&action=edit Bug 24191: Add to_model param to _build_order_atom and dbic_merge_sorting This patch adds a to_model parameter to dbic_merge_sorting so it is passed when used (for example from objects.search). The to_model param is passed along to the _build_order_atom method where it is finally used. In the process I wrote tests that reflected some problems in the current code: - Mojolicious automatically returns a scalar if a query parameter only happens once on a request. The code expected an arrayref in every case. - There's a design issue that forced me to use some hacky code in _build_order_atom. The first issue is dealth with, by using Scalar::Util::reftype as the Perl docs recommend. The second issue, I don't plan to clean it here, as there's ongoing work on a Koha::Objects->search_from_api method that will obsolete this code most probably (see bug 23893 for a better picture of where the mappings will be living soon). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass!! 3. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Owen Leonard Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:08:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:08:21 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:38:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:38:24 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- (In reply to Jonathan Druart from comment #5) > > Signed-off-by: cori > > Do not you want your real name appears in the release notes? I'll likely just add 'cori' as an alias for her full name in the release-tools. But.. it's always nice to have it done right in the commit message in the first place too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:23:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 16:23:23 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:26:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:26:44 +0000 Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:37:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:37:23 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #5 from Joonas Kylmälä --- I'm working on this as my first QA review task. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 14:40:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 13:40:11 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 14:40:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 13:40:14 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 --- Comment #7 from Owen Leonard --- Created attachment 96156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96156&action=edit Bug 23957: (follow-up) Disable both place hold buttons This follow-up adds the correct markup to the second of two "Place hold" buttons so that it is disabled when the first is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:26:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:26:20 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #7 from Pedro Amorim --- Created attachment 96146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96146&action=edit Bug 24121 - Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio Please let me know if this looks good, Owen. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:47:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:47:22 +0000 Subject: [Koha-bugs] [Bug 23542] SRU import encoding issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #8 from Fridolin SOMERS --- (In reply to Marcel de Rooy from comment #7) > > Also please provide more feedback as to your statement: "This is used in > some other places of code, its a trick." > What kind of trick is this? Please give the other code locations? Indeed I cant find it now. And I think this issue also exists with SRU for authorities. Needs work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:47:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:47:47 +0000 Subject: [Koha-bugs] [Bug 23542] SRU import encoding issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93588|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 14:46:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 13:46:46 +0000 Subject: [Koha-bugs] [Bug 24148] black magic in Circulation/Returns.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148 --- Comment #2 from Jonathan Druart --- Recreated from the MariaDB CLI. MariaDB [koha_kohadev]> SELECT itemnumber, `type`, borrowernumber from statistics WHERE ( `itemnumber` = 1087 AND `type` = 'return' ); +------------+--------+----------------+ | itemnumber | type | borrowernumber | +------------+--------+----------------+ | 1087 | return | 122 | +------------+--------+----------------+ 1 row in set (0.00 sec) MariaDB [koha_kohadev]> SELECT itemnumber, borrowernumber, datetime from statistics WHERE ( `itemnumber` = 1087 AND `type` = 'return' ) ORDER BY `datetime` ASC; +------------+----------------+---------------------+ | itemnumber | borrowernumber | datetime | +------------+----------------+---------------------+ | 1087 | 122 | 2019-12-10 13:35:55 | +------------+----------------+---------------------+ 1 row in set (0.00 sec) MariaDB [koha_kohadev]> SELECT itemnumber, borrowernumber, datetime, type from statistics WHERE ( `itemnumber` = 1087 AND `type` = 'return' ) ORDER BY `datetime` ASC; +------------+----------------+---------------------+--------+ | itemnumber | borrowernumber | datetime | type | +------------+----------------+---------------------+--------+ | 1087 | 122 | 2019-12-10 13:35:55 | return | +------------+----------------+---------------------+--------+ 1 row in set (0.00 sec) MariaDB [koha_kohadev]> SELECT * from statistics WHERE ( `itemnumber` = 1087 AND `type` = 'return' ) ORDER BY `datetime` ASC; Empty set (0.00 sec) MariaDB [koha_kohadev]> SELECT * from statistics WHERE ( `itemnumber` = 1087 AND `type` = 'return' ) ORDER BY `itemnumber` ASC; +---------------------+-----------+--------+--------+-------+------------+----------+----------+----------------+----------------------------------------------------------------------------------+ | datetime | branch | value | type | other | itemnumber | itemtype | location | borrowernumber | ccode | +---------------------+-----------+--------+--------+-------+------------+----------+----------+----------------+----------------------------------------------------------------------------------+ | 2019-12-10 13:35:55 | iObbbKovf | 0.0000 | return | | 1087 | SgqzzzD | NULL | 122 | vghO1ljHGphe13fp_LDxGDhsYFQqTSEMJ3S2aQXYyK2gMVlo1Q3b3rpn_FQCEPKqlIgCv0iSHpc1tRdy | +---------------------+-----------+--------+--------+-------+------------+----------+----------+----------------+----------------------------------------------------------------------------------+ 1 row in set (0.00 sec) MariaDB [koha_kohadev]> SELECT * from statistics WHERE ( `itemnumber` = 1087 AND `type` = 'return' ) ORDER BY `datetime` ASC; Empty set (0.00 sec) MariaDB [koha_kohadev]> SELECT itemnumber, borrowernumber from statistics WHERE ( `itemnumber` = 1087 AND `type` = 'return' ) ORDER BY `datetime` ASC; +------------+----------------+ | itemnumber | borrowernumber | +------------+----------------+ | 1087 | 122 | +------------+----------------+ 1 row in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 14:51:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 13:51:26 +0000 Subject: [Koha-bugs] [Bug 24148] black magic in Circulation/Returns.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148 --- Comment #3 from Jonathan Druart --- MariaDB [koha_kohadev]> SELECT `type`, `itemnumber` FROM `statistics` WHERE ( ( `branch` = 'iObbbKovf' AND `itemnumber` = 1087 AND `type` = 'return' ) ) ORDER BY `datetime` ASC; +--------+------------+ | type | itemnumber | +--------+------------+ | return | 1087 | +--------+------------+ 1 row in set (0.00 sec) MariaDB [koha_kohadev]> SELECT `type`, `itemnumber`, `other` FROM `statistics` WHERE ( ( `branch` = 'iObbbKovf' AND `itemnumber` = 1087 AND `type` = 'return' ) ) ORDER BY `datetime` ASC; Empty set (0.00 sec) MariaDB [koha_kohadev]> SELECT `type`, `itemnumber`, `borrowernumber` FROM `statistics` WHERE ( ( `branch` = 'iObbbKovf' AND `itemnumber` = 1087 AND `type` = 'return' ) ) ORDER BY `datetime` ASC; +--------+------------+----------------+ | type | itemnumber | borrowernumber | +--------+------------+----------------+ | return | 1087 | 122 | +--------+------------+----------------+ 1 row in set (0.00 sec) MariaDB [koha_kohadev]> SELECT `type`, `itemnumber`, `itemtype` FROM `statistics` WHERE ( ( `branch` = 'iObbbKovf' AND `itemnumber` = 1087 AND `type` = 'return' ) ) ORDER BY `datetime` ASC; +--------+------------+----------+ | type | itemnumber | itemtype | +--------+------------+----------+ | return | 1087 | SgqzzzD | +--------+------------+----------+ 1 row in set (0.00 sec) MariaDB [koha_kohadev]> SELECT `type`, `itemnumber`, `other` FROM `statistics` WHERE ( ( `branch` = 'iObbbKovf' AND `itemnumber` = 1087 AND `type` = 'return' ) ) ORDER BY `itemnumber` ASC; +--------+------------+-------+ | type | itemnumber | other | +--------+------------+-------+ | return | 1087 | | +--------+------------+-------+ 1 row in set (0.00 sec) MariaDB [koha_kohadev]> SELECT `type`, `itemnumber`, `other` FROM `statistics` WHERE ( ( `branch` = 'iObbbKovf' AND `itemnumber` = 1087 AND `type` = 'return' ) ) ORDER BY `borrowernumber` ASC; Empty set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 21:51:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 20:51:03 +0000 Subject: [Koha-bugs] [Bug 24195] New: edit_borrowers permission and patron contact information Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24195 Bug ID: 24195 Summary: edit_borrowers permission and patron contact information Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: george at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently if a staff member does not have edit_borrowers permission, and HidePersonalPatronDetailOnCirculation is set to hide, that staff member cannot see patron contact information on moremember.pl. However, they can still see contact information in the search results on circulation.pl if the columns are configured to show address and phone number information. Staff members without edit_borrowers permission should be blocked from seeing the address and phone number columns on circulation.pl without having to disable those columns for staff who do have edit_borrowers permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:55:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 16:55:24 +0000 Subject: [Koha-bugs] [Bug 24186] maxFine can break fine reductions in updateFine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24186 --- Comment #2 from Martin Renvoize --- Created attachment 96074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96074&action=edit Add Debugging -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 20:28:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 19:28:36 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96114|0 |1 is obsolete| | Attachment #96115|0 |1 is obsolete| | Attachment #96116|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 96117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96117&action=edit Bug 24191: Regression tests This patch adds missing tests for calling objects.search with non-existent column names for sorting, that should be mapped using to_model for that matter. Tests should fail as there's no current use of to_model for building the order_by portion of the query. Sponsored-by: ByWater Solutions Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:19:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:19:44 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 13:43:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 12:43:37 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 --- Comment #1 from Andrew Nugged --- Created attachment 96079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96079&action=edit Bug 24185: 'If all unavailable' for 'on shelf holds' makes holds page slow When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest" called many times with hundred of items and "on shelf holds" parameter set to "If all unavailable" for these items+patron, it goes very slow. This happens because in subloop there are re-checking if all other item unavailable so it is O(n^2) and it re-checks each time a lot of the same info for each item with repeating DB/data requests, these three: - GetBranchItemRule (per item type) - IsItemOnHoldAndFound (per item) - notforloan (per item) Proposed fix: I created patch to have in-variable cache in upper-level subroutine before entering the first "items" loop and passing that hash reference down into subs to cache these three values by keys per-item and per-item-type. It is simplest way to make it fast without re-thinking pretty complicated whole algorithm and business logic, and, when tested by speed it gave big improvement in execution time. How to reproduce: 1) on fresh installed kohadevbox create/import one book, record that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", so that rule will match above book items/library/patron, check that rule to have non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create direct link by yourself, for example in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time. I tested on my computer in VirtualBox for this page generation times, (stats below is for many runs and smallest value taken from similar in a repetition) *** "On shelf holds allowed" != "If all unavailable": 100 items: 5 seconds, 200 items: 10 seconds, 300 items: 11 seconds, *** "On shelf holds allowed" == "If all unavailable": 100 items: 50 seconds, 200 items: 3.1 minutes, 300 items: 7.0 minutes, *** "On shelf holds allowed" == "If all unavailable" with cache: 100 items: 7 seconds, 200 items: 20 seconds, 300 items: 38 seconds, Upper last one block with times with this in-var-cache solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:37:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:37:33 +0000 Subject: [Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96106|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 96113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96113&action=edit Bug 24134: Add placeholder for 2 digit years to allow autogeneration of dates in 008 This patch modifies the code for parsing MARC framework configurations so that the placeholder "<>" translates to a two-year date. To test, apply the patch and modify a framework to include placeholders. For example, in MARC21: - Administration -> MARC structure -> 952 -> Edit subfields -> d - Expand "Advanced constraints" and add a default value: <> <> <> <
> <> - Save your configuration and go to Cataloging. - Go to the add/edit items page for a record which uses the framework you edited. - In the "Add item" form, in the "Date aquired" field, you should see the correct values. For example: '2019 19 12 03 Leonard' Perform the same test when adding an item during the Acquisitions process (depending on your AcqCreateItem setting). Note that acqui/neworderempty.pl has been modified because the placeholder-replacement code is repeated there, but I couldn't discover how to test it (if it is used at all?) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 12:58:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 11:58:10 +0000 Subject: [Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |Passed QA --- Comment #4 from Marcel de Rooy --- Straight thru QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 02:28:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 01:28:44 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #1 from Alex Buckley --- Created attachment 96123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96123&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set an email in KohaAdminEmailAddress and notice there is no syspref named RedirectAddressForFailedOverdueNotices 2. Set some invalid email addresses in patron records then checkout items to those patrons making the due date in the past 3. Manually run overdue_notices.pl 4. Check the message_queue database table and notice the patrons with invalid email addresses are in an email starting with the content: 'These messages were not sent directly to the patrons.' 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the KohaAdminEmailAddress syspref. 7. Repeat steps 2-4 and notice that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:49:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:49:53 +0000 Subject: [Koha-bugs] [Bug 20799] Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20799 --- Comment #4 from Magnus Enger --- Created attachment 96105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96105&action=edit Bug 20799 - Add link from biblio to ILL detail view Some ILL systems (e.g. Libris in Sweden) require a link between a biblio and an ILL request. When such a link exists it is nice to display an actual link from the biblio detail view to the ILL request detail view. This patch adds such a link. For users without ILL privileges, the requests should still show, but not be clickable links. To test: - Make sure you have a couple of ILL requests created with the FreeForm backend. (FreeForm does not let you tie a request to a biblio through the UI, but we will add connections directly in the database.) Lets assume these have illrequest_id's a and b. - Make sure you have a record, let's call the biblionumber x. - Apply the patch and make sure there are no changes in the biblio detail view of biblionumber x. - Log into the database and connect the biblio to the first request: UPDATE illrequests SET biblio_id = x where illrequest_id = a; - Check that the biblio detail view now says this: "ILL requests: Request a" - Verify that the "Request a" part is a working link to the detail view of ILL request a. - Do this in the database: UPDATE illrequests SET biblio_id = x where illrequest_id = b; - Check that the biblio detail view now says this: "ILL requests: Request a, Request b" - Verify the links work as expected. - Log in as a staff user and check that the requests are still listed, but not displayed as clickable links. - Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 16:41:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 15:41:54 +0000 Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap menu button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- Owen, This is by far better than the old form! I have two comments: 1. When you pull up the new dropdown I think the .dropdown-header classes look a bit off. Can the text be bold and can we include a margin-left so the text isn't right up against the dropdown. 2. On smaller mobile screens #toolbar disappears entirely eliminating the ability to sort from a phone or small screen size. (This is at 600px and below). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:51:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:51:12 +0000 Subject: [Koha-bugs] [Bug 20799] Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20799 --- Comment #5 from Magnus Enger --- This patch uses the recommendations from Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:11:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:11:54 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 --- Comment #8 from Jonathan Druart --- Created attachment 96140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96140&action=edit Bug 24137: Fix biblio frameworks install for ru-Ru and uk-UA (repeatable) Replace repeatable='' with repeatable=0 perl -p -i -e "s/^\s\('', '(\d+)', (\d), '', / ('', '\1', \2, 0, /" installer/data/mysql/ru-RU/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql installer/data/mysql/uk-UA/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:28:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:28:58 +0000 Subject: [Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:37:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:37:29 +0000 Subject: [Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 20:28:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 19:28:41 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 --- Comment #7 from Owen Leonard --- Created attachment 96119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96119&action=edit Bug 24191: Make objects.search pass to_model to dbic_merge_sorting This patch makes objects.search pass the to_mode method reference so it can be used to map API attributes to column names when building the sorting portion of the query. To test: 1. Apply the regression tests on this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail! 3. Apply the rest of the patchset 4. Run: k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! changes to the methods work as expected! 5. Run: k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 6. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:35:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 16:35:16 +0000 Subject: [Koha-bugs] [Bug 24186] maxFine can break fine reductions in updateFine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24186 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 09:58:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 08:58:04 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 --- Comment #10 from Katrin Fischer --- Argh, thx for catching that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 13:43:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 12:43:56 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 10:18:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 09:18:56 +0000 Subject: [Koha-bugs] [Bug 8266] remove location from pull down on search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24127 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 17:55:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 16:55:21 +0000 Subject: [Koha-bugs] [Bug 24186] maxFine can break fine reductions in updateFine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24186 --- Comment #1 from Martin Renvoize --- Created attachment 96073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96073&action=edit Bug 24186: Add Tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 02:15:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 01:15:56 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #5 from Owen Leonard --- Jonathan did you see Bug 23956? I do like the "After" screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 21:46:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 20:46:05 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to hide expiration date options for reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 --- Comment #1 from Aleisha Amohia --- Created attachment 96120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96120&action=edit Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves To test: 1) Update database 2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field. 3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option. 4) In a third tab, open the intranet and set HideReserveExpiration system preference to 'Hide' 5) Refresh the hold request page in the intranet. Confirm the expiration date field disappears. 6) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears. Sponsored-by: Horowhenua Library Trust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:11:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:11:58 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 --- Comment #9 from Jonathan Druart --- Created attachment 96141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96141&action=edit Bug 24137: Manual replacement for hidden Arbitrary set to -6 when was NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 12:57:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 11:57:32 +0000 Subject: [Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95251|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 96083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96083&action=edit Bug 23785: Fix call get_coins on undef value in opac-search.pl If the search engine index returns a record that is no longer in the DB, an OPAC search will explode with: Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 02:29:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 01:29:04 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 20:28:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 19:28:38 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 --- Comment #6 from Owen Leonard --- Created attachment 96118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96118&action=edit Bug 24191: Add to_model param to _build_order_atom and dbic_merge_sorting This patch adds a to_model parameter to dbic_merge_sorting so it is passed when used (for example from objects.search). The to_model param is passed along to the _build_order_atom method where it is finally used. In the process I wrote tests that reflected some problems in the current code: - Mojolicious automatically returns a scalar if a query parameter only happens once on a request. The code expected an arrayref in every case. - There's a design issue that forced me to use some hacky code in _build_order_atom. The first issue is dealth with, by using Scalar::Util::reftype as the Perl docs recommend. The second issue, I don't plan to clean it here, as there's ongoing work on a Koha::Objects->search_from_api method that will obsolete this code most probably (see bug 23893 for a better picture of where the mappings will be living soon). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass!! 3. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 20:13:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 19:13:38 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 karen.fellows at citruslibraries.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karen.fellows at citruslibrari | |es.org --- Comment #4 from karen.fellows at citruslibraries.org --- This would be a great enhancement. Being able to receive multiple items using check-boxes would make it so much more efficient and would be a time saver. For example, if I receive a basket from Amazon, my invoice # is the same as my basket #, so I would love to see the items from the basket prepopulate in my invoice, have a "receive all" option or just have check boxes to select the ones I have and close the invoice. If more items come in on a different day, I could reopen the invoice and check off those items (it would be date stamped with the day of receipt). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 22:41:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 21:41:57 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to hide expiration date options for reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 21:46:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 20:46:02 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to hide expiration date options for reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:49:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:49:50 +0000 Subject: [Koha-bugs] [Bug 20799] Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20799 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 06:32:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 05:32:25 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #2 from Alex Buckley --- Created attachment 96124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96124&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set an email in KohaAdminEmailAddress and notice there is no syspref named RedirectAddressForFailedOverdueNotices 2. Set some invalid email addresses in patron records then checkout items to those patrons making the due date in the past 3. Manually run overdue_notices.pl 4. Check the message_queue database table and notice the patrons with invalid email addresses are in an email starting with the content: 'These messages were not sent directly to the patrons.' 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the KohaAdminEmailAddress syspref. 7. Repeat steps 2-4 and notice that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 11:28:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 10:28:23 +0000 Subject: [Koha-bugs] [Bug 23029] OPAC Authorities Search. Internal Server Error. Free-floating subdivisions imported from LOC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23029 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95354|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 12:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 11:57:29 +0000 Subject: [Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:00:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:00:34 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23805 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:00:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:00:34 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 [Bug 24177] Internal Server error when clicking cash register (Report) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:32:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:32:50 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #36 from Jonathan Druart --- Created attachment 96149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96149&action=edit Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:46:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:46:31 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make holds page fast when |'If all unavailable' state |'on shelf holds' set to 'If |for 'on shelf holds' makes |all unavailable' |holds page very slow if | |there's a lot of items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:32:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:32:46 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #35 from Jonathan Druart --- Created attachment 96148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96148&action=edit Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:42:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:42:02 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91146|0 |1 is obsolete| | Attachment #91147|0 |1 is obsolete| | Attachment #91148|0 |1 is obsolete| | Attachment #91149|0 |1 is obsolete| | --- Comment #20 from Nick Clemens --- Created attachment 96152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96152&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 7 - Try placing a multihold with either record above and a holdable record, message should end "...cannot place holds on some of these titles' items" 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:46:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:46:32 +0000 Subject: [Koha-bugs] [Bug 24148] black magic in Circulation/Returns.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148 --- Comment #1 from Jonathan Druart --- Created attachment 96153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96153&action=edit Bug 24148: Using some black magic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:32:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:32:53 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #37 from Jonathan Druart --- Created attachment 96150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96150&action=edit Bug 8132: Adding message when deleting from the UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:32:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:32:42 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95936|0 |1 is obsolete| | Attachment #95937|0 |1 is obsolete| | Attachment #95938|0 |1 is obsolete| | Attachment #95939|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 96147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96147&action=edit Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:41:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:41:59 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:32:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:32:38 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:11:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:11:50 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96078|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 96139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96139&action=edit Bug 24137: Fix biblio frameworks install for ru-Ru and uk-UA (mandatory) Replace mandatory='' with mandatory=0 perl -p -i -e "s/^\s\('', '(\d+)', '', / ('', '\1', 0, /" installer/data/mysql/ru-RU/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql installer/data/mysql/uk-UA/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 13:33:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 12:33:53 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #38 from Jonathan Druart --- I have adjusted the test plan and updated the patch (remote branch is still up-to-date). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:02:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:02:00 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:02:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:02:03 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96132|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 96157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96157&action=edit Bug 24177: Import Koha::Account::CreditTypes to cash_register_stats.pl Test plan: 0) Do not apply the patch 1) Confirm the bug - go to Reports -> Cash register --> You will see ISE 2) Apply the patch, and restart_all 3) Confirm the ISE is gone and you see the form for Cash register report Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:04:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:04:55 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Hold requests |Circulation CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:04:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:04:59 +0000 Subject: [Koha-bugs] [Bug 24189] Can't login to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24189 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Which exact version of Koha are you using? Does the problem appear after an upgrade? Or is it a fresh installation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:05:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:05:10 +0000 Subject: [Koha-bugs] [Bug 24201] New: Attach desk to intranet session Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Bug ID: 24201 Summary: Attach desk to intranet session Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nicolas.legrand at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, severine.queune at bulac.fr Depends on: 13881 Blocks: 14654 Last step before attaching a waiting hold to a desk: attach the current desk to the librarians session. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 [Bug 13881] Add desk management https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 [Bug 14654] Add desk filter in Holds awaiting pickup list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:05:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:05:10 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 [Bug 24201] Attach desk to intranet session -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:05:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:05:10 +0000 Subject: [Koha-bugs] [Bug 14654] Add desk filter in Holds awaiting pickup list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 [Bug 24201] Attach desk to intranet session -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:58:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:58:39 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #33 from Jonathan Druart --- Created attachment 96145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96145&action=edit Bug 23463: (follow-up) Remove DelItemCheck and ItemSafeToDelete Wrong replacement in additem.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:07:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:07:13 +0000 Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:07:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:07:16 +0000 Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #1 from Nicolas Legrand --- Created attachment 96158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96158&action=edit Bug 24201: Attach desk to intranet session When Desks are defined, a librarian can attach a desk to its session. Test plan: 1. apply 13881 and create some desks 2. you should see “NO DESK SET” in the intranet header 3. go to circulation > Set desk 4. you should see your desk name in the header, whatever the page 5. you can also set desk with the header menu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:07:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:07:45 +0000 Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|critical |major --- Comment #7 from Jonathan Druart --- Lowering severity, this does not sound like a critical bug to me. Isn't it a new enhancement finally? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:08:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:08:45 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #106 from Nick Clemens --- Created attachment 96090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96090&action=edit Bug 15326: (follow-up) Code review fixes Addresses the following issues: b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:08:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:08:31 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #103 from Nick Clemens --- Created attachment 96087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96087&action=edit Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 20:28:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 19:28:33 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 10:18:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 09:18:56 +0000 Subject: [Koha-bugs] [Bug 24127] Using the dropdown option of Shelving Location as a search choice retrieves no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8266 CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- This is consistent with the change made to the OPAC on bug 8266. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:19:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:19:42 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:08:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:08:59 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #109 from Nick Clemens --- Created attachment 96093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96093&action=edit Bug 15326: (follow-up) Redindent new CMS page templates This patch is an opinionated reindent of new and changed templates related to the CMS feature. I think it would be nice for these templates to start out with good indentation. To test, apply the patch and test the CMS feature. There should be no visible change to the way it looks or the way it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:55:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:55:09 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:50:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 13:50:54 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 --- Comment #8 from Andrew Fuerste-Henry --- I'm inclined to push this patch as-is and address the syspref name in a new bug when and if someone thinks of a good option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 19:44:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 18:44:57 +0000 Subject: [Koha-bugs] [Bug 12566] Duplicate checks for self registered patrons (other than email) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12566 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:00:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:00:46 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #20 from Owen Leonard --- Created attachment 96111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96111&action=edit Bug 20930: Make line and column number alert translatable To test: 1. Apply patch 2. Store invalid YAML syntax into OpacHiddenItems preference 3. Observe error 4. You should also see line and column number of where the error occured Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:55:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 15:55:24 +0000 Subject: [Koha-bugs] [Bug 24186] maxFine can break fine reductions in updateFine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24186 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24146 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:18:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:18:20 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 10:16:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 09:16:02 +0000 Subject: [Koha-bugs] [Bug 24140] I can't clear/delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24140 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Katrin Fischer --- One likely problem is 'duplicate id' - please check your About page / system information tab for information. Marking WORKSFORME for now, until we have more information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:09:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:09:04 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #110 from Nick Clemens --- Created attachment 96094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96094&action=edit Bug 15326: (follow-up) Corrections to staff client templates This patch makes some corrections to the staff client's CMS-related templates: - Add missing Template Toolkit filters. - Remove JavaScript from tools-menu.inc. This must have crept in during a rebase. - Add navigation link highlighting to tools-menu.js instead. - Convert tools/cmspages.tt to Bootstrap grid. - Correct toolbar button class. - Move some column sorting configuration out of JS and into table markup. - Move "Select all" / "Clear all" links to the top of the table to match similar interfaces. - Change the Action menu's "Intranet" and "OPAC" links to be "View" and "View in OPAC." The OPAC view now opens a new window. To test, apply the patches and test the Pages feature in the staff client: Adding, editing, deleting, viewing. For each view, test that the page layout adjusts to various browser widths. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:08:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:08:21 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #101 from Nick Clemens --- Created attachment 96085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96085&action=edit Bug 15326: (follow-up) Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 08:52:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 07:52:41 +0000 Subject: [Koha-bugs] [Bug 15860] Alias missing for /plugin on packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:00:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:00:34 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 16:20:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2019 15:20:41 +0000 Subject: [Koha-bugs] [Bug 6154] Default sorting by title doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6154 KohaGeekWien changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|CLOSED |REOPENED --- Comment #4 from KohaGeekWien --- I have a very latest Koha , and the sorting via Title is not working http://bp.reserveabooklibrary.com/cgi-bin/koha/catalogue/search.pl?idx=kw&q=ar&offset=100&sort_by=title_az Here you can see After B comes T Then C ... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 20:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 19:08:12 +0000 Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS, HTML, and YAML system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 16:01:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 15:01:44 +0000 Subject: [Koha-bugs] [Bug 20799] Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20799 --- Comment #3 from Owen Leonard --- Created attachment 96103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96103&action=edit Suggested interface alternative I think it would be confusing to use the same styling for these links as for the holds count. We use that style for a link which expresses a count of things and links to a list of those things. My suggestion is to use plain links, separated by a comma if there are multiple, and to label the links so that it is more clear what the number means. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 20:11:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 19:11:43 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 --- Comment #4 from Tomás Cohen Arazi --- @RM I set this to major as it is a blocker for serious uses of the API pagination and sorting. Please feel free to set it back to normal! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 09:07:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 08:07:56 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96119|0 |1 is obsolete| | --- Comment #10 from Josef Moravec --- Created attachment 96135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96135&action=edit Bug 24191: Make objects.search pass to_model to dbic_merge_sorting This patch makes objects.search pass the to_mode method reference so it can be used to map API attributes to column names when building the sorting portion of the query. To test: 1. Apply the regression tests on this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail! 3. Apply the rest of the patchset 4. Run: k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! changes to the methods work as expected! 5. Run: k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 6. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Owen Leonard Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 19:33:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 18:33:57 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Chris Curcio changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christopher.curcio at colorado | |college.edu --- Comment #3 from Chris Curcio --- I would love to have this capability to batch receive big orders like YBP or Worldwide. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 07:33:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 06:33:24 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95314|0 |1 is obsolete| | --- Comment #13 from Josef Moravec --- Created attachment 96129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96129&action=edit Bug 23893: Use in /cities This patch makes the cities controller use the new methods from Koha::Object. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 11:23:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 10:23:32 +0000 Subject: [Koha-bugs] [Bug 17787] Suppressed items included in count of search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rogan.hamby at gmail.com --- Comment #3 from Katrin Fischer --- *** Bug 24142 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 8 23:13:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Dec 2019 22:13:22 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:21:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:21:06 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #115 from Nick Clemens --- I did what I could to move this along, rebased, cleared QA errors, fixed filters Issues I had: 1 - The content field is hidden when I try to make a new page 2 - I cannot add a page under strict mode - the call to update_or_create doesn't like id as '' - if i try ot make it undef when not set, then the dbix gets upset about using key primary with no values It appears that title_link is enforced as unique in the module, though not in the table. If we do enforce this we can add a new constraint on that and use if for update/create but it requires more work https://metacpan.org/pod/DBIx::Class::ResultSet#update_or_create Note: Take care when using update_or_create with a table having columns with default values that you intend to be automatically supplied by the database (e.g. an auto_increment primary key column). In normal usage, the value of such columns should NOT be included at all in the call to update_or_create, even when set to undef. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 08:03:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 07:03:56 +0000 Subject: [Koha-bugs] [Bug 24198] itemtype image not displayed in search results anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24198 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 09:30:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 08:30:41 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:37 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #23 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:49 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 10:19:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 09:19:40 +0000 Subject: [Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Using the dropdown option |Remove dropdown option of |of Shelving Location as a |shelving location from |search choice retrieves no |advanced search in staff |results | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 11:42:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 10:42:09 +0000 Subject: [Koha-bugs] [Bug 8937] Translation process removes CDATA in RSS XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel --- (In reply to Victor Grousset/tuxayo from comment #5) > From what I understand, it turns out that regardless of 15395, the main > translation system will still process the file and remove the CDATA. > > So I don't know what would be a decent way to fix this. If one takes a look at the translated file, not all CDATA entries are removed. In EN 'opac-opensearch.tt' for example there are two lines near the begining, $ egrep -n CDATA opac-opensearch.tt 25: <![CDATA[.(removed).]]> 28: In the translated version of the same file we have 25: <![CDATA[[.(removed).]]> 28: .(removed). CDATA is removed but in 'description', not in 'title'! Why one and not the other? Because of C4::TTParser, based on HTML::Parser. treats some tags differently (script, style, xmp, iframe, title, textarea and plaintext), see https://metacpan.org/pod/HTML::Parser Anyway, the important thing is that ANY text inside CDATA block is IGNORED by the translation process, whichever the tag, and I was not aware of this. To verify this: go to misc/translator, edit a new file 'test.tt' and put inside the lines <![CDATA[ Title ]]> then create a translation file form it ./tmpl_process3.pl create -i ./ -f test.tt -s test.po 'test.po' will have nothing to translate! Change the contents of 'test.po' to Title Description and repeat, rm test.po; ./tmpl_process3.pl create -i ./ -f test.tt -s test.po 'test.po' has now strings to translate. Other rss files, 'opac-news-rss.tt' for example, do not use CDATA at all. Question: Can we remove CDATA blocks from this files? It's the only 'fix' that I can think of. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 21:23:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 20:23:41 +0000 Subject: [Koha-bugs] [Bug 24194] New: Add system preference to hide expiration date options for reserves Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Bug ID: 24194 Summary: Add system preference to hide expiration date options for reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries do not need to set expiration dates for reserves (this functionality is used). Add the ability to hide these options when placing reserves in staff client and OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 11:23:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 10:23:32 +0000 Subject: [Koha-bugs] [Bug 24142] Count of search results does not match displayed records with OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24142 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Summary|Count of search results |Count of search results |does not match displayed |does not match displayed |records. |records with | |OpacHiddenItems Version|19.11 |master CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Rogan, found it: bug 17787 *** This bug has been marked as a duplicate of bug 17787 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:44:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:44:52 +0000 Subject: [Koha-bugs] [Bug 20799] Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20799 --- Comment #2 from Magnus Enger --- Created attachment 96102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96102&action=edit Screenshot - proposed display for links to ILL request(s) Normaly there will only be one ILL request connected to a bibliographic record. The screenshot shows the proposed way of displaying one or more links to connected ILL requests: as linked ILL request IDs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:45 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 12:12:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 11:12:37 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 04:05:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 03:05:01 +0000 Subject: [Koha-bugs] [Bug 24189] New: Can't login to SIP2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24189 Bug ID: 24189 Summary: Can't login to SIP2 Change sponsored?: --- Product: Koha Version: 18.11 Hardware: HP OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: hamsiah at interxs.com.my QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Created attachment 96081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96081&action=edit Sip testing tool return value '0' which indicate as login failure This problem occurred when we trying to shut down the server. But then after we start up the server, the SIP2 connection was failed. This is the log from the selfcheck machine after start the server. It's showing that the connection is connected but the login seems failed because of the status indicate as '0'. Please refer attachment for clearer view. 21/11/2019 05:00:05 ILSport Error - The attempt to connect timed out 21/11/2019 05:00:26 ILSport Error - The attempt to connect timed out 21/11/2019 05:00:47 ILSport Error - The attempt to connect timed out 21/11/2019 05:01:08 ILSport Error - The attempt to connect timed out 21/11/2019 05:01:44 ILSport Connected 21/11/2019 05:01:44 To-->ILS 9300CNselfcheckp1|COS3lfch3ckp1|CP20000|AY0AZF1A5 21/11/2019 05:01:45 From <---- ILS 940AY0AZFDFE 21/11/2019 05:01:45 To-->ILS 9901002.00AY1AZFCA7 21/11/2019 05:01:46 ILSport Disconnected by remote host 21/11/2019 05:03:44 ILSport Connected 21/11/2019 05:03:44 To-->ILS 9300CNselfcheckp1|COS3lfch3ckp1|CP20000|AY5AZF1A0 21/11/2019 05:03:45 From <---- ILS 940AY5AZFDF 21/11/2019 05:03:45 To-->ILS 9901002.00AY6AZFCA2 21/11/2019 05:03:46 ILSport Disconnected by remote host 21/11/2019 05:05:44 ILSport Connected 21/11/2019 05:05:44 To-->ILS 9300CNselfcheckp1|COS3lfch3ckp1|CP20000|AY0AZF1A5 21/11/2019 05:05:45 From <---- ILS 940AY0AZFDFE 21/11/2019 05:05:45 To-->ILS 9901002.00AY1AZFCA7 21/11/2019 05:05:46 ILSport Disconnected by remote host 21/11/2019 05:08:05 ILSport Error - The attempt to connect timed out 21/11/2019 05:08:26 ILSport Error - The attempt to connect timed out 21/11/2019 05:08:35 ILSport Error - Connection is forcefully rejected 21/11/2019 05:08:36 ILSport Connected 21/11/2019 05:08:36 To-->ILS 9300CNselfcheckp1|COS3lfch3ckp1|CP20000|AY5AZF1A0 21/11/2019 05:08:38 From <---- ILS 940AY5AZFDF9 21/11/2019 05:08:38 To-->ILS 9901002.00AY6AZFCA2 21/11/2019 05:08:38 ILSport Disconnected by remote host 21/11/2019 05:09:44 ILSport Connected 21/11/2019 05:09:44 To-->ILS 9300CNselfcheckp1|COS3lfch3ckp1|CP20000|AY0AZF1A5 21/11/2019 05:09:45 From <---- ILS 940AY0AZFDFE 21/11/2019 05:09:45 To-->ILS 9901002.00AY1AZFCA7 21/11/2019 05:09:46 ILSport Disconnected by remote host 21/11/2019 05:11:44 ILSport Connected 21/11/2019 05:11:44 To-->ILS 9300CNselfcheckp1|COS3lfch3ckp1|CP20000|AY5AZF1A0 21/11/2019 05:11:45 From <---- ILS 940AY5AZFDF9 21/11/2019 05:11:45 To-->ILS 9901002.00AY6AZFCA2 21/11/2019 05:11:46 ILSport Disconnected by remote host 21/11/2019 05:13:44 ILSport Connected 21/11/2019 05:13:44 To-->ILS 9300CNselfcheckp1|COS3lfch3ckp1|CP20000|AY0AZF1A5 21/11/2019 05:13:45 From <---- ILS 940AY0AZFDFE 21/11/2019 05:13:45 To-->ILS 9901002.00AY1AZFCA7 21/11/2019 05:13:46 ILSport Disconnected by remote host 21/11/2019 05:15:44 ILSport Connected 21/11/2019 05:15:44 To-->ILS 9300CNselfcheckp1|COS3lfch3ckp1|CP20000|AY5AZF1A0 21/11/2019 05:15:45 From <---- ILS 940AY5AZFDF9 21/11/2019 05:15:45 To-->ILS 9901002.00AY6AZFCA2 21/11/2019 05:15:46 ILSport Disconnected by remote host 21/11/2019 05:17:44 ILSport Connected 21/11/2019 05:17:44 To-->ILS 9300CNselfcheckp1|COS3lfch3ckp1|CP20000|AY0AZF1A5 21/11/2019 05:17:45 From <---- ILS 940AY0AZFDFE 21/11/2019 05:17:45 To-->ILS 9901002.00AY1AZFCA7 21/11/2019 05:17:46 ILSport Disconnected by remote host 21/11/2019 05:19:44 ILSport Connected 21/11/2019 05:19:44 To-->ILS 9300CNselfcheckp1|COS3lfch3ckp1|CP20000|AY5AZF1A0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 10:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 09:57:29 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |joonas.kylmala at helsinki.fi --- Comment #19 from Joonas Kylmälä --- The latest patch is not signed-off yet so marking this as "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 07:33:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 06:33:16 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95312|0 |1 is obsolete| | --- Comment #11 from Josef Moravec --- Created attachment 96127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96127&action=edit Bug 23893: Implement Koha::Object->from_api_mapping This patch implements the from_api_mapping method, that calculates (and caches) the reserve mapping from the to_api_mapping method. A generic to_api_mapping is added to simplify things a bit in the generic to_api method and so the mappings are reusable in the way they are in from_api_mapping. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:18:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:18:03 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #24 from Jonathan Druart --- Created attachment 96137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96137&action=edit Bug 20948: Add missing html filter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:54 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:56 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:55:36 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:00:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:00:49 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #21 from Owen Leonard --- Created attachment 96112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96112&action=edit Bug 20930: (follow-up) Improve formatting of error message This patch makes a few changes to system preferences JavaScript so that the error message for invalid YAML is output on one line. CSS has been modified to improve the readability of multiple error messages. The order of CSS files loaded by preferences.tt has been changed to ensure that CSS in preferences.css overrides plugin-related CSS. Unrelated: An incorrect ";" has been replaced with ":" in preferences.tt. To test, apply the patch and repeat the previous test plan. Confirm that the error messages appear as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:08:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:08:26 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #102 from Nick Clemens --- Created attachment 96086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96086&action=edit Bug 15326: (follow-up) utf8 to utf8mb4 Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:17:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:17:59 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 18:59:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 17:59:19 +0000 Subject: [Koha-bugs] [Bug 23950] Replace MARC21xslt materialtype PNG icons with Font Awesome in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Lucas Gass --- Owen is correct, it is difficult to find FA icons for all the differetn sprites used in MARC21slim2OPACDetail and MARC21slim2OPACResults -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:47:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 13:47:52 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:56:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:56:58 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #12 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:55:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 15:55:24 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24186 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24186 [Bug 24186] maxFine can break fine reductions in updateFine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:08:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:08:41 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #105 from Nick Clemens --- Created attachment 96089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96089&action=edit Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 08:52:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 07:52:10 +0000 Subject: [Koha-bugs] [Bug 15860] Alias missing for /plugin on packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860 --- Comment #2 from Josef Moravec --- Created attachment 96082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96082&action=edit Bug 15860: Add alias /plugin to apache template for debian package installs Test plan: 1) Apply the patch 2) Create new instance with koha-create 3) Enable plugins on this instance 4) Install libmarc-lint-perl package 5) Install the MARC checker plugin (https://github.com/bywatersolutions/koha-plugin-marc-checker) 6) Run the plugin 7) You should see the image at top -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:08:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:08:36 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #104 from Nick Clemens --- Created attachment 96088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96088&action=edit Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:58 +0000 Subject: [Koha-bugs] [Bug 24057] Hea is not an acronym In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 08:35:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 07:35:20 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 --- Comment #7 from Marcel de Rooy --- (In reply to Lucas Gass from comment #6) > Marcel, > > FallbackToSMSIfNoEmailForPurchaseSuggestions? Seems long. Yeah. Too long. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:43 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 07:34:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 06:34:05 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:08:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:08:55 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #108 from Nick Clemens --- Created attachment 96092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96092&action=edit Bug 15326: (follow-up) Pages navigation fixes This is the best I've managed to do with the navigation. Would be happy for someone else to give it a go because I'm aware that some parent links repeat. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:52 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:59 +0000 Subject: [Koha-bugs] [Bug 24057] Hea is not an acronym In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:47:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 13:47:55 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95945|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy --- Created attachment 96100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96100&action=edit Bug 24138: Move the calculation out of the sub No changes expected here. For the next patch we are going to need to add test and calculate the new debarment date. To ease the writing of these tests the calculation is moved out of the existing subroutine. Signed-off-by: Hugo Agud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 16:54:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 15:54:58 +0000 Subject: [Koha-bugs] [Bug 24186] New: maxFine can break fine reductions in updateFine Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24186 Bug ID: 24186 Summary: maxFine can break fine reductions in updateFine Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org If maxFine is enabled and the user has hit their maxFine limit, then in a backdated return situation where a fine may need discounting via updateFine, the discount will not be applied as the current code will short circuit before calling adjust due it assuming all calls to updateFine are increases. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:17:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:17:25 +0000 Subject: [Koha-bugs] [Bug 24190] New: Add additional Acquisition logging Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Bug ID: 24190 Summary: Add additional Acquisition logging Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org A start was made on adding logging for Acquisitions in bug 23971. This bug will extend this as detailed below (note, some of the information detailed here will be derived via reporting and not explicitly logged): 1. Order line cancellations Details including who made the cancellation and when the cancellation was made 2. Order line creations Details including who created the order line, when it was created, the fund, and amount 3. Invoice adjustment additions Details including who added the adjustment, when it was added, the fund, and amount 4. Invoice adjustment amendments Details including who amended the adjustment, when it was amended, the fund, and amount 5. Invoice adjustment deletions Details including who deleted the adjustment, when it was deleted, the fund, and amount 6. Order line receipts against an invoice Details including who received the order line, when it was received, the fund, and amount 7. Budget Adjustments This would show amounts added or removed from a budget (excluding spent), who, when, and amount (In Koha the actual amount is edited rather than typing in the amount to change) 8. Fund adjustments This is essentially a bank statement. It would show additions and subtractions to a fund (excluding spent), who, when, amount, previous total, new total 9. Order release date (1) This would show individual order lines from an EDI message, when they were sent, who sent it, fund, and amount 10. Order release date (2) This would show individual order lines from a basket, when it was closed, who closed it, fund, and amount -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 11:17:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 10:17:06 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- Functionally this works well, but I wonder if we could improve the text a bit: Patron has 1 hold(s). Deleting patron cancels all their holds. Are you sure you want to delete the patron Nicole Schneider? This cannot be undone. Patron has a -9.00 credit. So now we have one warning on top (holds) an done below. I think that's not ideal for usability. It would be nicer to display them all together, maybe as a list? Also, should we remove the minus? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:00:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:00:37 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91861|0 |1 is obsolete| | Attachment #91862|0 |1 is obsolete| | Attachment #94412|0 |1 is obsolete| | Attachment #94413|0 |1 is obsolete| | --- Comment #17 from Owen Leonard --- Created attachment 96108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96108&action=edit Bug 20930: Dump and load system preferences of YAML/JSON type Currently, C4::Context->preference('YAMLpref') returns a string that needs to be parsed by any code using the preference. My suggestion is to return a parsed version instead (a hash/array ref or a string) and using the syspref cache with the parsed value. Like this, we could: - centralize parsing of YAML system preferences - optimize use of system preference cache by caching the parsed version instead. Parse once and store in cache; no need to re-parse on each call! We can centralize this functionality into Koha::Config::SysPref->value() (used by C4::Context->preference). Use database column systempreferences.type with value of "YAML" to trigger this functionality in "value()"-method. To test: 1. Make sure memcached is available 2. Run tests with caching enabled, e.g.: MEMCACHED_SERVERS=localhost:11211 prove t/db_dependent/Context.t 3. Make sure all tests pass and none were skipped Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 6 21:00:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Dec 2019 20:00:24 +0000 Subject: [Koha-bugs] [Bug 8937] Translation process removes CDATA in RSS XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 96076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96076&action=edit Bug 8937: Translation process removes xml prolog This patch fix the missing xml prolog in translated files, xml ot TT. Is fixed teaching C4::TTParse not to ignore constructs, then teaching xgettext.pl to ignore those strings. Net result is that they are copied in the translated file. To test: 1) Update & install your preferred language, (cd misc/translator/; perl translate update xx-YY; perl translate install xx-YY ) 2) Compare the first lines (head -2) of: koha-tmpl/opac-tmpl/bootstrap/en/xslt/compact.xsl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/intranet-tmpl/prog/en/xslt/plainMARC.xsl and koha-tmpl/opac-tmpl/bootstrap/xx-YY/xslt/compact.xsl koha-tmpl/opac-tmpl/bootstrap/xx-YY/modules/opac-opensearch.tt koha-tmpl/intranet-tmpl/prog/xx-YY/xslt/plainMARC.xsl Check the missing prolog 3) Install this patch, repeat 1 and 2, now the prolog is present on translated files. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 07:33:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 06:33:27 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95315|0 |1 is obsolete| | --- Comment #14 from Josef Moravec --- Created attachment 96130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96130&action=edit Bug 23893: Use in /patrons This patch makes the patrons endpoint use the new methods from Koha::Object. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:57:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:57:00 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:48:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 13:48:00 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95946|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy --- Created attachment 96101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96101&action=edit Bug 24138: Fix calculation of suspension days when a limit is set If there is a limit for the number of suspension days (maxsuspensiondays), the calculation is wrong. We are reducing the number of days before taking into account the suspension charging interval. For instance, a checkin is 1 year late and the circ rules are defined to charge 7 days every 15 days. It results in 365 * 7 / 15 days of suspension => 170 days Before this patch the calculation was: 365 * 7 limited to 333, 333 / 15 => 22 days Test plan: Given the examples in the commit messages and the description of the bug report, setup complex circulation rules and confirm that the debarment dates are calculated correctly Signed-off-by: Hugo Agud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:57:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:57:01 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:28:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:28:54 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #5 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > Functionally this works well, but I wonder if we could improve the text a > bit: > > Patron has 1 hold(s). Deleting patron cancels all their holds. > > Are you sure you want to delete the patron Nicole Schneider? This cannot be > undone. > Patron has a -9.00 credit. > > So now we have one warning on top (holds) an done below. I think that's not > ideal for usability. It would be nicer to display them all together, maybe > as a list? Done. > Also, should we remove the minus? Maybe, no idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 22:41:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 21:41:41 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to hide expiration date options for reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96120|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 96121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96121&action=edit Bug 24194: Add HideReserveExpiration system preference to hide expiration date options for reserves To test: 1) Update database 2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field. 3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option. 4) In a third tab, open the intranet and set HideReserveExpiration system preference to 'Hide' 5) Refresh the hold request page in the intranet. Confirm the expiration date field disappears. 6) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears. Sponsored-by: Horowhenua Library Trust Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:39 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 12:29:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 11:29:55 +0000 Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929 --- Comment #1 from Katrin Fischer --- Not sure if this is not a bug instead of an enh? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:31:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:31:58 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #20 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #19) > The latest patch is not signed-off yet so marking this as "Needs Signoff". When the first patch has been already signed off we do not necessarily ask for a second signoff. In this case I am expecting a ping pong with Marcel and so do not need to involve another tester. However another eyeball/thoughts from QA is more than welcome :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 20:10:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 19:10:45 +0000 Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS, HTML, and YAML system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 08:03:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 07:03:58 +0000 Subject: [Koha-bugs] [Bug 24198] itemtype image not displayed in search results anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24198 --- Comment #1 from Fridolin SOMERS --- Created attachment 96131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96131&action=edit Bug 24198: itemtype image not displayed in search results anymore In staff interface, itemtype image not displayed in search results anymore. This depends on system preference noItemTypeImages when itemtype is at biblio level. Looks like its a consequence of Bug 14385 Test plan : 1) On a catalog with itemtype is at biblio level 2) Set preference noItemTypeImages to "yes" 3) Check there are icons on itemtypes 4) Go to staff interface 5) Perform a search 6) Check you see icon in search results table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:41 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #26 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:00:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:00:43 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #19 from Owen Leonard --- Created attachment 96110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96110&action=edit Bug 20930: Display human readable errors in preferences page Displays human readable error when YAML/JSON preference has invalid syntax. If multiple preferences are modified at the same time, notifies librarian of the preferences that were saved and the ones that had errors. To test: 1. Apply patches 2. Write invalid YAML syntax to OpacHiddenItems system preference 3. Observe "Error; Preference OpacHiddenItems has invalid syntax" error You should also receive a hint on line and column numbers of where the error occured. 4. Write valid YAML syntax to OpacHiddenItems system preference 5. Observe "Saved preference OpacHiddenItems" message 6. Test steps 2-5 for both single preference modification and together with other system preferences. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:09:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:09:10 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #111 from Nick Clemens --- Created attachment 96095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96095&action=edit Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters Previous versions of this patch set adds a LESS file to the OPAC, which is now obsolete. It should be removed. In addition, the change made to opac.less contained CSS which didn't apply to any existing markup, so it need not be added to opac.scss. The patch also adds missing Template Toolkit filters to template files. None of these changes should be visible in testing. OPAC CMS pages should function as usual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 12:28:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 11:28:23 +0000 Subject: [Koha-bugs] [Bug 24166] Barcode removal breaks circulation.pl/moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 08:02:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 07:02:17 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at helsinki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:41:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:41:15 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #31 from Jonathan Druart --- (In reply to Kelly McElligott from comment #29) > I did not see the message that is indicated in step 2. " Nothing happened > and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process" . > > This would be an extremely helpful message. I received a message that 2 > items were deleted. Yes, they were the correct items to be deleted and left > the item with the hold along. I am not sure with this test plan, if this > message that you note in step 2 should be see. > > See my screenshot. > > Kelly Hi Kelly, thanks for testing. Can you confirm the holds were "found"? So far we prevent deletion if reserves.found is W or T. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:27:43 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:00:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:00:40 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #18 from Owen Leonard --- Created attachment 96109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96109&action=edit Bug 20930: First example - Change OpacHiddenItems to type YAML To test: 1. prove t/db_dependent/Items.t 2. Check that desired items are still hidden in OPAC by using OpacHiddenItems as documented here: https://wiki.koha-community.org/wiki/OpacHiddenItems Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 12:12:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 11:12:40 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95897|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 96078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96078&action=edit Bug 24137: Fix biblio frameworks install for ru-Ru and uk-UA They both failed with Column 'hidden' cannot be null Test plan: Make sure the 2 sql files can be inserted without errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:08:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:08:50 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #107 from Nick Clemens --- Created attachment 96091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96091&action=edit Bug 15326: (follow-up) Interface fixes This patch addresses the following: a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:55:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:55:12 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95994|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 96099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96099&action=edit Bug 24168: (bug 23116 follow-up) AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold This patch actually fixes the issue described on bug 23116. Test plan: See bug 23116. Signed-off-by: Marcel de Rooy See also comment5. Important to note that the later comparison with itemAlreadyOnHold assumes that the variable is a string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:56:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:56:08 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #5) > Take a look at the file and search for "can_item_be_reserved". > There is another occurrence. OK Thats the point. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:51 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 21:23:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 20:23:59 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to hide expiration date options for reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 09:08:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 08:08:14 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 11:23:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 10:23:01 +0000 Subject: [Koha-bugs] [Bug 17787] Suppressed items included in count of search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suppressed items seem to be |Suppressed items included |included in count of search |in count of search results |results | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 10:13:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 09:13:28 +0000 Subject: [Koha-bugs] [Bug 24140] I can't clear/delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24140 --- Comment #2 from Katrin Fischer --- Tested on master - cancelling holds from OPAC and patron account worked ok for me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:36:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:36:01 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:08:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:08:15 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87494|0 |1 is obsolete| | Attachment #87495|0 |1 is obsolete| | Attachment #87496|0 |1 is obsolete| | Attachment #87497|0 |1 is obsolete| | Attachment #87498|0 |1 is obsolete| | Attachment #87499|0 |1 is obsolete| | Attachment #87500|0 |1 is obsolete| | Attachment #87501|0 |1 is obsolete| | Attachment #87502|0 |1 is obsolete| | Attachment #87503|0 |1 is obsolete| | Attachment #87608|0 |1 is obsolete| | Attachment #87609|0 |1 is obsolete| | Attachment #87617|0 |1 is obsolete| | --- Comment #100 from Nick Clemens --- Created attachment 96084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96084&action=edit Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 10:14:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 09:14:56 +0000 Subject: [Koha-bugs] [Bug 24141] Can we become an OpanBadges issuer? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24141 --- Comment #2 from Katrin Fischer --- I have no experience with OpenBadges, but I like the idea in general! How does the issuing of the badges work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:35 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 11:43:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 10:43:43 +0000 Subject: [Koha-bugs] [Bug 8937] Translation process removes CDATA in RSS XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 --- Comment #8 from Bernardo Gonzalez Kriegel --- > > Change the contents of 'test.po' to > It's 'test.tt', sorry. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:09:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:09:20 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #113 from Nick Clemens --- Created attachment 96097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96097&action=edit Bug 15326: Fix QA errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 01:18:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 00:18:36 +0000 Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating a new language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 14:04:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 13:04:18 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96079|0 |1 is obsolete| | --- Comment #2 from Andrew Nugged --- Created attachment 96080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96080&action=edit Bug 24185: 'If all unavailable' for 'on shelf holds' makes holds page slow When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest" called many times with hundred of items and "on shelf holds" parameter set to "If all unavailable" for these items+patron, it goes very slow. This happens because in subloop there are re-checking if all other item unavailable so it is O(n^2) and it re-checks each time a lot of the same info for each item with repeating DB/data requests, these three: - GetBranchItemRule (per item type) - IsItemOnHoldAndFound (per item) - notforloan (per item) Fix: Use in-variable cache in upper-level subroutine before entering the first "items" loop and passing that hash reference down into subs to cache these three values by keys per-item and per-item-type. It is simplest way to make it fast without re-thinking pretty complicated whole algorithm and business logic, and, when tested by speed it gave big improvement in execution time. Also "$can_item_be_reserved->{status} eq 'OK'" moved in "&&" before IsAvailableForItemLevelRequest call to cut away if it false before calling to subroutine. How to reproduce: 1) on fresh installed kohadevbox create/import one book, record that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", so that rule will match above book items/library/patron, check that rule to have non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create direct link by yourself, for example in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time. I tested on my computer in VirtualBox for this page generation times, (stats below is for many runs and smallest value taken from similar in a repetition) *** "On shelf holds allowed" != "If all unavailable": 100 items: 5 seconds, 200 items: 10 seconds, 300 items: 11 seconds, *** "On shelf holds allowed" == "If all unavailable": 100 items: 50 seconds, 200 items: 3.1 minutes, 300 items: 7.0 minutes, *** "On shelf holds allowed" == "If all unavailable" with cache: 100 items: 7 seconds, 200 items: 20 seconds, 300 items: 38 seconds, Upper last one block with times with this in-var-cache solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:35:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:35:47 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:36:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:36:04 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:27:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:27:46 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #4 from Jonathan Druart --- Created attachment 96142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96142&action=edit Bug 24008: Display warnings in a list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 01:17:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 00:17:16 +0000 Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating a new language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 96122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96122&action=edit Bug 18688: Warnings about UTF-8 charset when creating a new language This patch removes some warnings when creating new languages, those related with uft8 and two not related. Tipical messages are: >Warning: Can't determine original templates' charset, defaulting to UTF-8 >Warning: Charset Out defaulting to UTF-8 >... >Removing empty file /../xx-YY-marc-NORMARC.po >I UTF-8 O UTF-8 at /../kohaclone/misc/translator/tmpl_process3.pl line 365. >Use of uninitialized value $pref_name in concatenation (.) or string at /.../misc/translator/LangInstaller.pm line 197. >Created /../misc/translator/po/xx-YY-messages.po. First four are 'normal' messages The fifth one correspond to an unquoted preference string The sixth one is a normal output message from msgint command We will hide them unless verbose '-v' option is selected, and fix the error. To test: 1) Go to misc/translator 2) Create new language files $ perl translate create xx-YY 3) Check warnings and messages 4) Apply the patch 5) Remove created files, and create them again Ther must be no messages 6) Repeat 5) with verbose option '-v', check old messages 7) BONUS: without the patch update a language, for example de-DE: $ perl translate update de-DE Note (git status) a new file, po/de-DE-messages.po~ This is a backup file from msgmerge command With the patch this backup is removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:09:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:09:15 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #112 from Nick Clemens --- Created attachment 96096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96096&action=edit Bug 15326: Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 06:31:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 05:31:40 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96123|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 07:33:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 06:33:12 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95311|0 |1 is obsolete| | --- Comment #10 from Josef Moravec --- Created attachment 96126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96126&action=edit Bug 23893: Unit tests This patch introduces tests for the implemented methods. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 09:39:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 08:39:35 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 07:33:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 06:33:20 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95313|0 |1 is obsolete| | --- Comment #12 from Josef Moravec --- Created attachment 96128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96128&action=edit Bug 23893: Add new_from_api and set_from_api to Koha::Object This patch introduces the following methods to the Koha::Object class: - set_from_api - new_from_api This methods are going to be used when writing API controllers that map to the attributes to the DB schema ones. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 13:09:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 12:09:25 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #114 from Nick Clemens --- Created attachment 96098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96098&action=edit Bug 15326: Fix filters and adjust tiny_mce assets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:56:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:56:56 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 7 11:32:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Dec 2019 10:32:50 +0000 Subject: [Koha-bugs] [Bug 23029] Add authority type GEN_SUBDIV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23029 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC Authorities Search. |Add authority type |Internal Server Error. |GEN_SUBDIV |Free-floating subdivisions | |imported from LOC | Severity|normal |enhancement Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:11:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:11:33 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24193 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 23:31:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 22:31:25 +0000 Subject: [Koha-bugs] [Bug 24197] New: Custom destination for failed overdue notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Bug ID: 24197 Summary: Custom destination for failed overdue notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Notices Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Currently failed overdue notices are sent to the branch email , or when that is not set to the KohaAdminEmailAddress syspref. Several of our clients have requested a seperate email address for failed overdue notices to be sent to. This email address will be defined in the: RedirectAddressForFailedOverdueNotices syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 09:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 08:17:46 +0000 Subject: [Koha-bugs] [Bug 24198] itemtype image not displayed in search results anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24198 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 24121 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 18:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 17:49:51 +0000 Subject: [Koha-bugs] [Bug 21565] SCO checkout confirm language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21565 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:50:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:50:40 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 96116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96116&action=edit Bug 24191: Make objects.search pass to_model to dbic_merge_sorting This patch makes objects.search pass the to_mode method reference so it can be used to map API attributes to column names when building the sorting portion of the query. To test: 1. Apply the regression tests on this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail! 3. Apply the rest of the patchset 4. Run: k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! changes to the methods work as expected! 5. Run: k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 6. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:51:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:51:31 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 09:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 08:17:46 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Jonathan Druart --- *** Bug 24198 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 18:49:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 17:49:32 +0000 Subject: [Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 01:16:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 00:16:10 +0000 Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating a new language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:56:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:56:48 +0000 Subject: [Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134 --- Comment #2 from Owen Leonard --- Created attachment 96106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96106&action=edit Bug 24134: Add placeholder for 2 digit years to allow autogeneration of dates in 008 This patch modifies the code for parsing MARC framework configurations so that the placeholder "<>" translates to a two-year date. To test, apply the patch and modify a framework to include placeholders. For example, in MARC21: - Administration -> MARC structure -> 952 -> Edit subfields -> d - Expand "Advanced constraints" and add a default value: <> <> <> <
> <> - Save your configuration and go to Cataloging. - Go to the add/edit items page for a record which uses the framework you edited. - In the "Add item" form, in the "Date aquired" field, you should see the correct values. For example: '2019 19 12 03 Leonard' Perform the same test when adding an item during the Acquisitions process (depending on your AcqCreateItem setting). Note that acqui/neworderempty.pl has been modified because the placeholder-replacement code is repeated there, but I couldn't discover how to test it (if it is used at all?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:50:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:50:37 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 96115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96115&action=edit Bug 24191: Add to_model param to _build_order_atom and dbic_merge_sorting This patch adds a to_model parameter to dbic_merge_sorting so it is passed when used (for example from objects.search). The to_model param is passed along to the _build_order_atom method where it is finally used. In the process I wrote tests that reflected some problems in the current code: - Mojolicious automatically returns a scalar if a query parameter only happens once on a request. The code expected an arrayref in every case. - There's a design issue that forced me to use some hacky code in _build_order_atom. The first issue is dealth with, by using Scalar::Util::reftype as the Perl docs recommend. The second issue, I don't plan to clean it here, as there's ongoing work on a Koha::Objects->search_from_api method that will obsolete this code most probably (see bug 23893 for a better picture of where the mappings will be living soon). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass!! 3. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:15:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:15:43 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 02:58:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 01:58:48 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:46:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:46:50 +0000 Subject: [Koha-bugs] [Bug 24200] New: Borrower_PrevCheckout.t failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200 Bug ID: 24200 Summary: Borrower_PrevCheckout.t failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Cannot recreate this one locally, it's failing on Koha_Master_D9_MDB_Latest (run 5) koha_1 | DBIC result _type isn't of the _type BiblioMetadata at /kohadevbox/koha/Koha/Patron.pm line 618. koha_1 | # Looks like your test exited with 11 just after 58. koha_1 | [15:56:22] t/db_dependent/Patron/Borrower_PrevCheckout.t Certainly a problem of missing data in tests. A guess, the following line should use build_sample_item: 248 my $item_d = $builder->build({source => 'Item'}) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:23:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:23:56 +0000 Subject: [Koha-bugs] [Bug 24191] New: Sorting doesn't use to_model Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Bug ID: 24191 Summary: Sorting doesn't use to_model Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com There are no tests for sorting the results from objects.search (there are unit test for the query building code only) and it is not working as expected, as objects.search is not using to_model to map the attribute names. To reproduce: - Perform the following with your favourite tool: GET http://kohadev-intra.myDNSname.org:8081/api/v1/cities?_order_by=+name => FAIL: You get a DBIC error about 'name' not being a valid column name -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:14:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:14:12 +0000 Subject: [Koha-bugs] [Bug 24192] Show host record items in basket/shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24192 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 14:58:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 13:58:16 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 --- Comment #9 from Marcel de Rooy --- (In reply to Andrew Fuerste-Henry from comment #8) > I'm inclined to push this patch as-is and address the syspref name in a new > bug when and if someone thinks of a good option. Yeah my idea too. Since it is in PQA now, the RM may do it.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 07:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 06:57:29 +0000 Subject: [Koha-bugs] [Bug 24198] itemtype image not displayed in search results anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24198 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:24:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:24:01 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 07:57:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 06:57:16 +0000 Subject: [Koha-bugs] [Bug 24198] New: itemtype image not displayed in search results anymore Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24198 Bug ID: 24198 Summary: itemtype image not displayed in search results anymore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In staff interface, itemtype image not displayed in search results anymore. This depends on system preference noItemTypeImages when itemtype is at biblio level. Looks like its a consequence of Bug 14385 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 07:57:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 06:57:42 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24198 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24198 [Bug 24198] itemtype image not displayed in search results anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:15:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:15:53 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:11:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:11:33 +0000 Subject: [Koha-bugs] [Bug 24193] New: Add CodeMirror linting of JavaScript, CSS, HTML, and YAML system preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193 Bug ID: 24193 Summary: Add CodeMirror linting of JavaScript, CSS, HTML, and YAML system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com CodeMirror offers linting plugins for JavaScript, CSS, HTML, and YAML. We should incorporate these into the system preferences editor. Note: The proposed patch can coexist with Bug 20930. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:14:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:14:02 +0000 Subject: [Koha-bugs] [Bug 24192] Show host record items in basket/shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24192 --- Comment #1 from Julian Maurice --- Created attachment 96104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96104&action=edit Bug 24192: Show host record items in basket/shelves If EasyAnalyticalRecords is enabled, and if record has no items, display host record items in baskets and lists (staff interface only) Also, show items.enumchron in both pages Test plan: 0. Login to staff interface 1. Set EasyAnalyticalRecords to "Display" 2. Create a biblio record without items 3. On the biblio record detail page, click in the menu Edit > Link to host item, and enter a valid barcode 4. Add the biblio record to your cart 5. Open your cart and verify that the linked item is displayed 6. Add the biblio record to a list 7. Open the list and verify that the linked item is displayed 8. Edit the linked item and enter something that will be saved in items.enumchron (check the biblio framework mappings, add a new item field if needed) 9. Re-open your cart and list and verify that the enumchron is shown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:25:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:25:36 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 10:55:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 09:55:50 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 --- Comment #5 from Jonathan Druart --- > Signed-off-by: cori Do not you want your real name appears in the release notes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 18:49:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 17:49:55 +0000 Subject: [Koha-bugs] [Bug 21565] SCO checkout confirm language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21565 --- Comment #4 from Lucas Gass --- Created attachment 96107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96107&action=edit Bug 21565: Turn SCO receipt promt into modal This patch adds a Bootstrap modal to sco-main.tt and updates the javascript in that file to act accordingly. TEST PLAN: 1. Enable SCO and go to /cgi-bin/koha/sco/sco-main.pl. Make sure SelfCheckReceiptPrompt is set to 'show' 2. Login and click 'Finish' to see the old print alert box. 3. Apply patch and repeat steps 1 and 2. 4. Make sure the modal works for confirming and denying a receipt. Checkout some items and make sure everything still functions the same. 5. Set SelfCheckReceiptPrompt to 'Don't show' and confirm behavior is acceptable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 07:57:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 06:57:42 +0000 Subject: [Koha-bugs] [Bug 24198] itemtype image not displayed in search results anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24198 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14385 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:13:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:13:26 +0000 Subject: [Koha-bugs] [Bug 24192] New: Show host record items in basket/shelves Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24192 Bug ID: 24192 Summary: Show host record items in basket/shelves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If EasyAnalyticalRecords is enabled, and if record has no items, display host record items in baskets and lists (staff interface only) Also, show items.enumchron in both pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:51:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:51:23 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 17:56:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 16:56:45 +0000 Subject: [Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:24:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:24:36 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |josef.moravec at gmail.com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 19:50:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 18:50:34 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 96114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96114&action=edit Bug 24191: Regression tests This patch adds missing tests for calling objects.search with non-existent column names for sorting, that should be mapped using to_model for that matter. Tests should fail as there's no current use of to_model for building the order_by portion of the query. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 16:16:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 15:16:38 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 15:25:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 14:25:33 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 9 16:16:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Dec 2019 15:16:17 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:17:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:17:35 +0000 Subject: [Koha-bugs] [Bug 20493] SIP2 sending blank Title Identifier and Due date while Renew the books through Selfcheck In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20493 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Marked as duplicate, please reopen if still valid. *** This bug has been marked as a duplicate of bug 21486 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:17:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:17:35 +0000 Subject: [Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aniltiwari86 at hotmail.com --- Comment #26 from Jonathan Druart --- *** Bug 20493 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:18:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:18:39 +0000 Subject: [Koha-bugs] [Bug 22923] Items edition does not take care of independent branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22923 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20256 | Resolution|--- |DUPLICATE --- Comment #9 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 20256 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:18:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:18:39 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22923 | CC| |fridolin.somers at biblibre.co | |m --- Comment #64 from Jonathan Druart --- *** Bug 22923 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:20:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:20:56 +0000 Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #6 from Jonathan Druart --- Kyle, Colin, Can you have a look at that patch please? I am stuck at debugging it and founding what's wrong with it. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:25:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:25:01 +0000 Subject: [Koha-bugs] [Bug 24187] Vertically centre the holding details in each table rows in Cataloguing (staff client) and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24187 --- Comment #1 from Owen Leonard --- Created attachment 96159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96159&action=edit Search results with vertical centering I may be misunderstanding this request but if you're talking about the staff client search results, the reason for not vertically centering the title information is that when you have a lot of items it causes the title information to be strangely distant from the previous row in the table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:25:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:25:11 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't let users cancel |Block suspend and cancel on |holds connected with ILLs |holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:18:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:18:36 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org --- Comment #16 from Jonathan Druart --- No, it does not work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:43:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:43:48 +0000 Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:43:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:43:46 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #27 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:43:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:43:07 +0000 Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:43:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:43:49 +0000 Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 --- Comment #3 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:56:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:56:35 +0000 Subject: [Koha-bugs] [Bug 24117] Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 --- Comment #4 from Pedro Amorim --- Hi Jonathan, Thank you so much for your feedback. In the past, the $item parameter was changed to $item_unblessed, by this commit https://github.com/Koha-Community/Koha/commit/31c29fd31f557306233e6a2936148a5bb10b89a1#diff-932a11a39c3f8c7127afb9c9a44318e7L2008 I opted to leave the code as it was previously written and add the parameter I needed, precisely because the function is only called once. I did not have the opportunity to test the behaviour of _GetCircControlBranch when $item is being used instead of $item_unblessed but I'll try test it soon and follow your instructions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 12:11:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 11:11:45 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:42:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:42:24 +0000 Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- Thanks Jonathan.. that's the fix I was literally just testing locally as an RM followup.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:43:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:43:12 +0000 Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:29:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:29:41 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |tomascohen at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:30:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:30:24 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96157|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:26:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:26:47 +0000 Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 --- Comment #1 from Jonathan Druart --- Created attachment 96138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96138&action=edit Bug 24199: (bug 23042 follow-up) Prevent t/Auth_with_shibboleth.t to fail randomly CGI->url_param does not always return the parameters in the same order. Test plan: 0/ Recreate the random failure, does not apply the patch and run t/Auth_with_shibboleth.t several times. You will notice that it fails inconsistenly 1/ Apply the patch and confirm that it now passes 100% of the time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 09:53:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 08:53:54 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Joonas Kylmälä --- With MariaDB this works but inserting the file still fails with MySQL version 5.7.28-0ubuntu0.18.04.4: > $ koha-mysql kohadev < installer/data/mysql/ru-RU/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql > ERROR 1366 (HY000) at line 9: Incorrect integer value: '' for column 'repeatable' at row 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 07:52:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 06:52:31 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Internal Server error when |Internal Server error when |clicking cash |clicking cash register |register(Report) |(Report) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 11:10:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 10:10:57 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |joonas.kylmala at helsinki.fi --- Comment #3 from Joonas Kylmälä --- Thanks. Unfortunately, the patch doesn't apply, please rebase. Also the title "'If all unavailable' for 'on shelf holds' makes holds page slow" describes the problem instead what the commit does. So the commit title should be something like "Make holds page fast when/if/with setting ..." (https://wiki.koha-community.org/wiki/Commit_messages#Examples) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:32:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:32:14 +0000 Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:32:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:32:18 +0000 Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123 --- Comment #3 from Jonathan Druart --- Created attachment 96160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96160&action=edit Bug 24123: Fix import of UTF-8 encoded MARC21 MARCXML using bulkmarcimport (elastic only) If elastic is used as search engine, the bulkmarcimport.pl will not handle correctly UTF-8 encoded MARCXML Koha::SearchEngine::Search->new uses a require statement to load the correct Search module. This is done l.257 of bulkmarcimport.pl: 257 my $searcher = Koha::SearchEngine::Search->new Koha::SearchEngine::Elasticsearch::Search will `use MARC::File::XML`, and so resets the arguments set before: 216 $MARC::File::XML::_load_args{BinaryEncoding} = 'utf-8'; 220 $MARC::File::XML::_load_args{RecordFormat} = $recordformat; An easy (but dirty) fix could be to move the declaration of my $searcher before in the script. The tricky (but correct) fix would be to remove the long standing "ugly hack follows" comment. This patch is the easy, and dirty, fix Test plan: Use the command line tool to import MARXCML records that contains unicode characters into Koha Something like `misc/migration_tools/bulkmarcimport.pl -biblios -file record.marcxml -m=MARCXML` Without this patch you will notice that unicode characters will not be displayed correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:32:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:32:28 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23309 --- Comment #10 from Joonas Kylmälä --- It looks like this bug was caused by the change in Bug 23309. And it seems like the change in Bug 23309 also broke the koha database upgrades for installations that used Russian or Ukranian MARC frameworks. (when running the db upgrade in bug 23309 I get "ERROR 1265 (01000): Data truncated for column 'hidden' at row 2") Jonathan, any idea what the NULL meant before for the visibility? Now you propose -6 which means showing the field in OPAC and Intranet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:32:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:32:28 +0000 Subject: [Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24137 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:32:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:32:35 +0000 Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:35:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:35:06 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 96161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96161&action=edit Bug 24177: Import Koha::Account::CreditTypes to cash_register_stats.pl Test plan: 0) Do not apply the patch 1) Confirm the bug - go to Reports -> Cash register --> You will see ISE 2) Apply the patch, and restart_all 3) Confirm the ISE is gone and you see the form for Cash register report Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:35:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:35:36 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:39:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:39:58 +0000 Subject: [Koha-bugs] [Bug 23934] Item level holds not checked for LocalHoldsPriority in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry --- Test plan: - Set LocalHoldsPriority to "Give priority for filling holds to patrons whose pickup library matches the item's holding library" - set yourself at Library A - find at item at Library A - place an item-level hold (Hold 1) for item for pickup at Library B - set an item-level hold (Hold 2) for item for pickup at Library A - Confirm Hold 1 shows priority=1 - Check in item - confirm item would be captured for Hold 2, ignore hold - run holds queue - check item in - confirm item is captured for Hold 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:41:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:41:12 +0000 Subject: [Koha-bugs] [Bug 24202] New: Option to receive multiple orders in Acquisitions - Standing Order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24202 Bug ID: 24202 Summary: Option to receive multiple orders in Acquisitions - Standing Order Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jzairo at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org With Bug 21467 - Allow several receipts for a given subscription, a user can receive multiple orders from a subscription. This would be a great option to have with Standing orders. Often a title will have multiple copies or orders that come throughout various times in the year while the basket it open. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:41:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:41:51 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 --- Comment #11 from Jonathan Druart --- All NULL from this patch should be compared with the .sql we have in 'en'. But I cannot find time for that. Maybe 8 is better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:45:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:45:00 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 96162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96162&action=edit Bug 24177: (QA follow-up) Fix warning Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:48:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:48:25 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:48:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:48:47 +0000 Subject: [Koha-bugs] [Bug 10450] Editing serials predicts wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10450 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- Cannot recreate, internal ticket was marked resolved and problem not replicable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:25 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:27 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95968|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:30 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95969|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:33 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95970|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:35 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95971|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:38 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95972|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:40 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95973|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:42 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:45 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:48 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:51 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95959|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:53 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:55 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95961|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:51:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:51:58 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95962|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:52:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:52:00 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95963|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:52:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:52:03 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95964|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:52:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:52:05 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95965|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:52:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:52:08 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95966|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:52:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:52:13 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95967|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 15:57:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 14:57:20 +0000 Subject: [Koha-bugs] [Bug 15483] in a weekly serial subscription, the second planned issue corresponds to third publisheddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15483 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens --- Cannot recreate, please add details of numbering pattern used if this issue recurs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:10:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 15:10:15 +0000 Subject: [Koha-bugs] [Bug 23934] Item level holds not checked for LocalHoldsPriority in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94930|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes --- Created attachment 96163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96163&action=edit Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:10:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 15:10:43 +0000 Subject: [Koha-bugs] [Bug 23934] Item level holds not checked for LocalHoldsPriority in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:11:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 15:11:05 +0000 Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96158|0 |1 is obsolete| | --- Comment #2 from Nicolas Legrand --- Created attachment 96164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96164&action=edit Bug 24201: Attach desk to intranet session When Desks are defined, a librarian can attach a desk to its session. Test plan: 1. apply 13881 and create some desks 2. you should see “NO DESK SET” in the intranet header 3. go to circulation > Set desk 4. you should see your desk name in the header, whatever the page 5. you can also set desk with the header menu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:53:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 15:53:36 +0000 Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96164|0 |1 is obsolete| | --- Comment #3 from Nicolas Legrand --- Created attachment 96165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96165&action=edit Bug 24201: Attach desk to intranet session When Desks are defined, a librarian can attach a desk to its session. Test plan: 1. apply 13881 and create some desks 2. you should see “NO DESK SET” in the intranet header 3. go to circulation > Set desk 4. you should see your desk name in the header, whatever the page 5. you can also set desk with the header menu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 16:58:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 15:58:31 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- You beat me to it, yeay.. go team :).. It's been a day of that.. every bug on my list has been done just before I get to it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:06:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:06:35 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #39 from Kelly McElligott --- Jonathan, Two issues that I have with this: In this step: 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process This does block the whole process! So all the item that could be deleted - don't get deleted, the button to return to Batch Item Deletion, results in having to re-enter all the items that could have been deleted but weren't because of 1 item. Could the return to deletion button bring back the screen prior to this. This is just a lot of extra work. In this step: 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! Koha is deleting both items on Bib4 - one of which had an item level hold (not triggered). The hold does not get orphaned, because it too is deleted. Is this what you would like to see happen, a library can delete an item with an item level hold if it isn't triggered? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:10:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:10:22 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #25 from Martin Renvoize --- Really glad to see this one move, thanks to all involved... The code is looking polished and good now, Pushing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:18:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:18:13 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:18:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:18:15 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #26 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:18:17 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:18:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:18:19 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:18:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:18:21 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:18:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:18:23 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #21 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:18:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:18:25 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:18:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:18:27 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:18:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:18:29 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:18:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:18:31 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:26:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:26:39 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #40 from Jonathan Druart --- (In reply to Kelly McElligott from comment #39) > Jonathan, > Two issues that I have with this: > > In this step: > > 2/ Select them and confirm the deletion > => Nothing happened and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process > > This does block the whole process! So all the item that could be deleted - > don't get deleted, the button to return to Batch Item Deletion, results in > having to re-enter all the items that could have been deleted but weren't > because of 1 item. Could the return to deletion button bring back the > screen prior to this. This is just a lot of extra work. I will see what I can do. But yes, I do expect the whole process to be blocked. If something is wrong, the whole transaction is rolled back. > In this step: > 3/ Remove the biblio-level hold > 4/ Repeat 1 > => The deletion has been effective! > > Koha is deleting both items on Bib4 - one of which had an item level hold > (not triggered). The hold does not get orphaned, because it too is deleted. > Is this what you would like to see happen, a library can delete an item with > an item level hold if it isn't triggered? It is how it works so far. That's why I added a note in the commit message about this behavior. The hold has to be found (waiting or in transfer) to see the deletion blocked. I guess it's how it works as well in the cataloguing module. It's not a behavior's change I want to introduce with this patchset, if we decide to modify it we should do it on its own bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:34:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:34:22 +0000 Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96165|0 |1 is obsolete| | --- Comment #4 from Nicolas Legrand --- Created attachment 96166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96166&action=edit Bug 24201: Attach desk to intranet session When Desks are defined, a librarian can attach a desk to its session. Test plan: 1. apply 13881 and create some desks 2. you should see “NO DESK SET” in the intranet header 3. go to circulation > Set desk 4. you should see your desk name in the header, whatever the page 5. you can also set desk with the header menu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:41:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:41:52 +0000 Subject: [Koha-bugs] [Bug 24203] New: overduerules.pl does not work with bug 20436 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 Bug ID: 24203 Summary: overduerules.pl does not work with bug 20436 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Bug 20436 allows for customization of when itemtypes switch to long overdue. However, overduerules.pl sets fixed lengths of time for each type of notice. Overduerules.pl needs to be set according to how you are using the new feature. Either the interface needs to change so we can mirror when items go long overdue, or better yet, we should change overduerules.pl to both do what bug 20436 does and define when the notices are triggered, all in one. It doesn't make sense to have them work differently, or have to set these rules in two different locations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:42:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:42:18 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- It's still valid. Selecting 'stable' or '19.11' those packages are not found. Using oldstable yes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 17:55:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 16:55:44 +0000 Subject: [Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- There's a broader issue here in that overdue notice and the long overdue process are fundamentally unconnected. We're just trying to line them up in a way that can get pretty messy. See also Bug 18064. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:05:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:05:54 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28880|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 96167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96167&action=edit Bug 12430 - Truncation disables relevance ranking when not using QueryParser The system preference "QueryWeightFields" is mutually exclusive with the system preference "QueryAutoTruncate" and the * truncation modifier, when not using QueryParser. If you use truncation, relevance won't work anymore. (N.B. Relevance doesn't work probably when using QueryParser, but for a very different reason beyond the current scope of this bug.) This patch adds relevance ranking when using truncation (or basically when QueryWeightFields is disabled). _TEST PLAN_ 1) Turn on "QueryWeightFields" and "QueryAutoTruncate" 2) Turn off "TryQueryParser" 3) Do a keyword search in the OPAC 4) Note that the results are ordered by biblionumber ascending 5) Apply patch 6) Do the same keyword search in the OPAC 7) Note that the results are never ordered differently (presumably in relevance order :P) If you're a stickler, throw in some warns so that you can see what CCL query is being sent to Zebra. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:06:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:06:47 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|In Discussion |Needs Signoff --- Comment #16 from Martin Renvoize --- I've attempted a rebase of the patch.. it's not an area I'm all that familiar with so testing is required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:10:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:10:15 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maxime Dufresne changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.dufresne at inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:19:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:19:58 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96143|0 |1 is obsolete| | --- Comment #9 from Lucas Gass --- Created attachment 96168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96168&action=edit Bug 24181: Make our datepicker inputs sexy They are skinny and different from others. Not that a problem, I am too. But I do not think it is what they need. Test plan: Edit a patron and take a look at the input for "Date of birth" => Before this patch they are not looking great => After this patch they are beautiful Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:20:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:20:13 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96144|0 |1 is obsolete| | --- Comment #10 from Lucas Gass --- Created attachment 96169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96169&action=edit Bug 24181: Move the icon back into the input Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:22:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:22:14 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Lucas Gass --- Not sure if it was a caching issue or not, but when I applied both patches and ran yarn build everything looks great so I am signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:39:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:39:44 +0000 Subject: [Koha-bugs] [Bug 24148] black magic in Circulation/Returns.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:42:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:42:48 +0000 Subject: [Koha-bugs] [Bug 17774] Acquisitions module getting internal server error when adding orders to basket - a case of barcode not autoincrementing (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17774 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- Is this still happening? Or was it resolved? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:43:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:43:54 +0000 Subject: [Koha-bugs] [Bug 24204] New: Talking Tech i-tiva is now illion Digital Tech Solutions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24204 Bug ID: 24204 Summary: Talking Tech i-tiva is now illion Digital Tech Solutions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org The third-party service Tallking Tech i-tiva was acquired by illion Digital Tech Solutions in 2018 (https://www.linkedin.com/company/talkingtech/?originalSubdomain=nz). Updates are required to reflect this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:45:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:45:07 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:45:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:45:10 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92913|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 96170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96170&action=edit Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:45:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:45:13 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 --- Comment #9 from Owen Leonard --- Created attachment 96171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96171&action=edit Bug 23512: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 18:46:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 17:46:34 +0000 Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96171|0 |1 is obsolete| | --- Comment #10 from Owen Leonard --- Created attachment 96172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96172&action=edit Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 19:05:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 18:05:18 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 19:25:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 18:25:49 +0000 Subject: [Koha-bugs] [Bug 24204] Talking Tech i-tiva is now illion Digital Tech Solutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24204 --- Comment #1 from David Nind --- Link to information about the service: https://www.illiondts.com/solutions/i-tiva-for-libraries/ Are system preference names and other things updated when thinks like this happen? (In the process of updating the documentation to update the link to the site.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 19:34:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 18:34:00 +0000 Subject: [Koha-bugs] [Bug 24205] New: Advanced editor - Save to .mrc hangs when 00X fields have delimeters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24205 Bug ID: 24205 Summary: Advanced editor - Save to .mrc hangs when 00X fields have delimeters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: carnold at dgiinc.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Although the cataloger was able to accidentally save her MARC record to the catalog with an invalid 007 value (note the delimiter not allowed in 00X fields): 007 ‡ad fungnnmmned Attempting to save the file as a .mrc causes Koha to hang. Steps to reproduce: Open a record in the catalog Add the following 007 field: 007 ‡ad fungnnmmned Save the record to the catalog Click the down arrow on the Save button and select "Save as MARC (.mrc)" Result: Web page hangs Expected Result: Error presented to the user that the record has invalid syntax -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 19:49:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 18:49:56 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Owen Leonard --- Séverine I wasn't able to reproduce either of these problems. Could you test again and see if luck shines on me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:21:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:21:24 +0000 Subject: [Koha-bugs] [Bug 7385] Enrich OPAC with wikipedia content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7385 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24206 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:21:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:21:24 +0000 Subject: [Koha-bugs] [Bug 24206] New: Change URLs for default options in OPACSearchForTitleIn Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Bug ID: 24206 Summary: Change URLs for default options in OPACSearchForTitleIn Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org URLs are not correct for the default values in the OPACSearchForTitleIn system peference: - Worldcat: now https - BookFinder: now https - OpenLibrary: URL search pattern changed These still work as the sites redirect to the https version, and the new URL pattern for the OpenLibrary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:24:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:24:21 +0000 Subject: [Koha-bugs] [Bug 24207] New: Preferences to select what check in messages need to be displayed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24207 Bug ID: 24207 Summary: Preferences to select what check in messages need to be displayed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We would sure like an option to turn on/off each check in message that is displayed. We don't necessarily need to see certain ones, like if the shelving location was changed, or local use is recorded, or that it is not checked out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:24:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:24:28 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:24:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:24:46 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:25:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:25:01 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)|19.11.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:25:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:25:11 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:26:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:26:27 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:26:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:26:45 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:27:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:27:01 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|bugs.koha-community.org |Fines and fees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:27:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:27:35 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:28:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:28:10 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:28:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:28:19 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:28:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:28:28 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:28:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:28:37 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:28:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:28:46 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:28:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:28:56 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:29:06 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:29:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:29:14 +0000 Subject: [Koha-bugs] [Bug 24057] Hea is not an acronym In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:29:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:29:23 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:29:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:29:34 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:29:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:29:46 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:29:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:29:55 +0000 Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:33:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:33:48 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:39:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:39:57 +0000 Subject: [Koha-bugs] [Bug 24208] New: Remove change calculation for writeoffs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Bug ID: 24208 Summary: Remove change calculation for writeoffs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: maryse.simard at inlibro.com QA Contact: testopia at bugs.koha-community.org Bug 11373 added change calculation to the payment page. This doesn't work very well when using the "Writeoff selected" button: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:41:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:41:14 +0000 Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 --- Comment #1 from Maryse Simard --- Created attachment 96173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96173&action=edit Bug 24208: Remove change calculation for writeoffs Bug 11373 added change calculation to the payment page. This doesn't work very well in the case of writeoffs: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath. This patch removes these unwanted fields and use the "Writeoff amount" label on the right input. Test plan: 1) Choose a patron who has fees. You can add a manual invoice if necessary. 2) Go to Accounting > Make a payment. 3) Select some fines and click "Write off selected". 4) Note the form has a lot of inputs, not all are necessary for a writeoff. 5) Make a partial writeoff by entering a different amount in the "Writeoff amount" field. => The amount written off is the amount entered in the "Amount paid" field. 6) Apply patch. 7) Repeat steps 1-3. 8) Notice the form only has "Amount outstanding", "Writeoff amount" and "Note" fields, which are enough for a writeoff. 9) Entering any amount lower than or equal to the amount outstanding in the "Writeoff amount" field should create a writeoff of the selected amount. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:41:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:41:48 +0000 Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Depends on| |11373 Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |maryse.simard at inlibro.com |ity.org | CC| |maryse.simard at inlibro.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:41:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:41:48 +0000 Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the fine payment forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 [Bug 24208] Remove change calculation for writeoffs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:55:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:55:47 +0000 Subject: [Koha-bugs] [Bug 24088] Add link to item search in staff client main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #3 from Liz Rea --- This search is already on every page, in the header under "search" I agree the search is useful, but I think this is cluttering. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 20:58:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 19:58:27 +0000 Subject: [Koha-bugs] [Bug 24088] Add link to item search in staff client main page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #4 from Owen Leonard --- One could also add a link to the header menu using the IntranetNav system preference if you wanted to avoid that click:
  • Item search
  • In my opinion we don't need such a prominent link on the home page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:03:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 20:03:10 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:13:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 20:13:03 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 --- Comment #5 from Joy Nelson --- Pushed to stable 19.11.01 Thanks everyone!!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:16:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 20:16:30 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | --- Comment #9 from Joy Nelson --- Pushed to stable 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:17:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 20:17:12 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Joy Nelson --- Pushed to stable 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:18:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 20:18:18 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #5 from Joy Nelson --- Pushed to stable 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:24:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 20:24:20 +0000 Subject: [Koha-bugs] [Bug 24209] New: Need Display status with timestamp on items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24209 Bug ID: 24209 Summary: Need Display status with timestamp on items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Adding a Display status field with timestamp would allow staff to easily change an item to show that it is on display. An associated timestamp would allow staff to easily make automatic modifcations to this status through the Automatic item modifications by age tool. This status would need to be shown when the item is checked in. This status should have its own LOC table, like DIS_LOC, where different display locations can be defined. The status location would need to appear in search results and on records, like: "Currently on display at: Front Entrance" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:31:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 20:31:01 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 21:39:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 20:39:45 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:02:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:02:43 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:02:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:02:54 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:06:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:06:11 +0000 Subject: [Koha-bugs] [Bug 23522] Show "Actual price" in basket when available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #16 from Lucas Gass --- enhancement will not be backported to 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:27:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:27:35 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:32:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:32:04 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:32:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:32:16 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:34:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:34:59 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- this feature is not broken for me in 19.05.x, not backporting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:49:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:49:03 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:49:13 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:50:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:50:20 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #33 from Lucas Gass --- enhancement won't be backported to 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:51:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:51:08 +0000 Subject: [Koha-bugs] [Bug 23024] Limit number of items displayed on detail pages in staff (MaxItemsToDisplay) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23024 b.pastern4k at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit mumber of items |Limit number of items |displayed on detail pages |displayed on detail pages |in staff |in staff |(MaxItemsToDisplay) |(MaxItemsToDisplay) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:51:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:51:48 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|CLOSED |REOPENED Resolution|INVALID |--- --- Comment #6 from Katrin Fischer --- (In reply to Bernardo Gonzalez Kriegel from comment #5) > It's still valid. > > Selecting 'stable' or '19.11' those packages are not found. > Using oldstable yes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:54:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:54:39 +0000 Subject: [Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- small enhancement choosing to backport to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 10 23:54:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 22:54:49 +0000 Subject: [Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:13:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 23:13:51 +0000 Subject: [Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:14:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 23:14:33 +0000 Subject: [Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:16:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 23:16:30 +0000 Subject: [Koha-bugs] [Bug 24210] New: Export biblio returns empty file after update Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 Bug ID: 24210 Summary: Export biblio returns empty file after update Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: b.pastern4k at gmail.com QA Contact: testopia at bugs.koha-community.org I have 17.11 Koha with UNIMARC and it does not export items, only record info. I tried updating to 18.11 and 19.11 hoping that this issue wont happen in newer releases. Instead export stopped working at all. The generated file is empty with no records. However, if I create a fresh instance on 18.11 or 19.11 export works fine and with items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:20:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 23:20:47 +0000 Subject: [Koha-bugs] [Bug 24141] Can we become an OpenBadges issuer? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24141 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can we become an OpanBadges |Can we become an OpenBadges |issuer? |issuer? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:21:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 23:21:24 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:21:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 23:21:37 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 00:47:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Dec 2019 23:47:23 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 --- Comment #7 from Bernardo Gonzalez Kriegel --- > > Selecting 'stable' or '19.11' those packages are not found. > > Using oldstable yes. My workaround was to configure 'olstable' first and install, then configure 'stable' or '19.11' and upgrade. I suppose those files are missing on the new 'stable' repo. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 01:00:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 00:00:04 +0000 Subject: [Koha-bugs] [Bug 24211] New: Compress/uncompress translation files Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Bug ID: 24211 Summary: Compress/uncompress translation files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation files takes some space in an installed system, ~350 MB. It's not too much with current drives, but it's a space that can be saved on container images. Compressing them it's easy and can be made transparently, using only ~50 MB. Perhaps this enhancement could be used when generating packages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 01:01:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 00:01:25 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 01:18:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 00:18:50 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 96174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96174&action=edit Bug 24211: Compress/uncompress translation files This patch adds the ability to compress/uncompress translations files. On update/install the files are uncompressed first The only gain is to use less space. To test: 1) Apply the patch 2) Go to misc/translator 3) Try it $ ./translate compress fr-FR (check po/*.gz) $ ./translate uncompress fr-FR ( check normal files) 4) Try again with verbose mode $ ./translate compress fr-FR -v (list compressed files) $ ./translate uncompress fr-FR -v (list uncompressed files) 5) Try update compressed files $ ./translate compress fr-FR $ ./translate update fr-FR (result is uncompressed) 6) Try install compressed files $ ./translate compress fr-FR $ ./translate install fr-FR 7) Try compress all $ ./translate compress (add '-v' for verbose output) 8) Try uncompress all $ ./translate uncompress (add '-v' for verbose output) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 01:20:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 00:20:02 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 04:11:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 03:11:58 +0000 Subject: [Koha-bugs] [Bug 24212] New: OPAC send list dialog opens too small in IE Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 Bug ID: 24212 Summary: OPAC send list dialog opens too small in IE Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org When sending an email list from OPAC in IE, the dialog box that appears is not big enough, nor can it's size be changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 04:12:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 03:12:32 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 --- Comment #1 from Aleisha Amohia --- Created attachment 96175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96175&action=edit Screenshot showing dialog box too small to see contents of window -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 04:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 03:12:41 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 05:30:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 04:30:28 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 06:10:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 05:10:29 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 06:10:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 05:10:32 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 --- Comment #2 from Aleisha Amohia --- Created attachment 96176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96176&action=edit Bug 24212: Increase size of OPAC 'send list' dialog box for IE To test: 1) Create a list and view it in the OPAC (ensure you are using Internet Explorer as a browser) 2) Click Send list 3) Notice the dialog box cuts off the content in the window 4) Close the popup, apply the patch 5) Click Send list again 6) Confirm the dialog box shows the entire window Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 07:55:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 06:55:12 +0000 Subject: [Koha-bugs] [Bug 10994] Allow use of branch/kohaAdmin e-mail address for sending claim notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement --- Comment #12 from Jonathan Druart --- Switching from major to new enhancement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:03:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:03:27 +0000 Subject: [Koha-bugs] [Bug 24187] Vertically centre the holding details in each table rows in Cataloguing (staff client) and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I agree with Owen that the current behaviour is better. Can you post screenshots for the other points? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:05:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:05:10 +0000 Subject: [Koha-bugs] [Bug 24188] Sorting AZ does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Autor sorts by 100, but as Koha displays more the results may seem strange sometimes. How many results do you have in your result list? There is a high limit on where Zebra stops sorting in the configuration. Can you maybe post a screenshot of a sorted unsorted result list? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:05:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:05:29 +0000 Subject: [Koha-bugs] [Bug 24188] Sorting AZ does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:08:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:08:57 +0000 Subject: [Koha-bugs] [Bug 24189] Can't login to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24189 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Did you set up your SIP user with circulate permissions in Koha and the conf file correctly? (https://koha-community.org/manual/19.11/en/html/apis_protocols.html#sip2) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:10:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:10:58 +0000 Subject: [Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:10:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:10:58 +0000 Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 [Bug 18086] overduerules table is lacking foreign key constraints -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:12:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:12:52 +0000 Subject: [Koha-bugs] [Bug 24192] Show host record items in basket/shelves in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24192 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show host record items in |Show host record items in |basket/shelves |basket/shelves in staff CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I think it might have been nice to split the enumchron into a separate bug - this way it would show up in the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:22:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:22:04 +0000 Subject: [Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Can you explain this with an example maybe? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:26:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:26:01 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- You need to uncheck all item related filters in the export tool (especially branches/libraries at the top). Then you will be able to export items. The GUI will be changed in newer versions to make this easier to see: See bug 23184. *** This bug has been marked as a duplicate of bug 23184 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:26:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:26:01 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |b.pastern4k at gmail.com --- Comment #10 from Katrin Fischer --- *** Bug 24210 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:27:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:27:24 +0000 Subject: [Koha-bugs] [Bug 6154] Default sorting by title doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|REOPENED |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:27:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:27:31 +0000 Subject: [Koha-bugs] [Bug 6154] Default sorting by title doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:28:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:28:13 +0000 Subject: [Koha-bugs] [Bug 6154] Default sorting by title doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6154 --- Comment #5 from Katrin Fischer --- Re-closing this bug as a new bug has already been filed - please share a link to your OPAC there or a screenshot, we can't access your staff interface. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:28:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:28:40 +0000 Subject: [Koha-bugs] [Bug 6154] Default sorting by title doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6154 --- Comment #6 from Katrin Fischer --- (In reply to Katrin Fischer from comment #5) > Re-closing this bug as a new bug has already been filed - please share a > link to your OPAC there or a screenshot, we can't access your staff > interface. bug 24188 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 08:35:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 07:35:18 +0000 Subject: [Koha-bugs] [Bug 21901] Improve performance for serial registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:16:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:16:29 +0000 Subject: [Koha-bugs] [Bug 24187] Vertically centre the holding details in each table rows in Cataloguing (staff client) and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24187 --- Comment #3 from Iming Chan --- Created attachment 96177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96177&action=edit OPAC Holdings See the red line where details are aligned to the top instead of centre. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:18:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:18:58 +0000 Subject: [Koha-bugs] [Bug 24187] Vertically centre the holding details in each table rows in Cataloguing (staff client) and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24187 --- Comment #4 from Iming Chan --- Created attachment 96178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96178&action=edit Staff client catalogue record normal view Red lines (not all are marked) showing where field labels and field details are not quite aligned on the same level. As well, the holdings details are aligned more towards the top than centre vertically (like OPAC holding details). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:21:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:21:16 +0000 Subject: [Koha-bugs] [Bug 24187] Vertically centre the holding details in each table rows in Cataloguing (staff client) and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24187 --- Comment #5 from Iming Chan --- Sorry for the confusion, but I'm actually referring to Holdings found within each catalogue record, not the search result list. See screen shots attached (for staff client and OPAC). Like Owen, I agreed that the current behaviour is the best. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:22:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:22:41 +0000 Subject: [Koha-bugs] [Bug 24213] New: Koha::Object->get_from_storage should return undef if the object has been deleted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Bug ID: 24213 Summary: Koha::Object->get_from_storage should return undef if the object has been deleted Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org It currently explodes with something like: DBIC result _type isn't of the _type Subscription at t/db_dependent/Biblio.t line 627. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:32:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:32:32 +0000 Subject: [Koha-bugs] [Bug 21901] Improve performance for serial registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:32:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:32:32 +0000 Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21901 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 [Bug 21901] Improve performance for serial registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:32:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:32:46 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:33:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:33:18 +0000 Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target, | |RM_priority -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:41:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:41:06 +0000 Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:41:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:41:09 +0000 Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 --- Comment #1 from Jonathan Druart --- Created attachment 96179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96179&action=edit Bug 24213: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:41:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:41:12 +0000 Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 --- Comment #2 from Jonathan Druart --- Created attachment 96180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96180&action=edit Bug 24213: Fix Koha::Object->get_from_storage if the object has been deleted Without this patch it fails with something like: DBIC result _type isn't of the _type Subscription at t/db_dependent/Biblio.t line 627. Test plan: - Apply the first patch (Add tests) - Confirm that they fail - Apply this patch - Confirm that the tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:42:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:42:24 +0000 Subject: [Koha-bugs] [Bug 21901] Improve performance for serial registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:42:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:42:24 +0000 Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should return undef if the object has been deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21901 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 [Bug 21901] Improve performance for serial registration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:42:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:42:28 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:42:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:42:40 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |19.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:42:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:42:46 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:43:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:43:18 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 --- Comment #8 from Martin Renvoize --- Any chance you might be able to take a look at this one Mason.. I'm still struggling to get hold of Mirko at the moment.. hope he's OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:47:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:47:31 +0000 Subject: [Koha-bugs] [Bug 21901] Improve performance for serial registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:47:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:47:34 +0000 Subject: [Koha-bugs] [Bug 21901] Improve performance for serial registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 --- Comment #1 from Jonathan Druart --- Created attachment 96181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96181&action=edit Bug 21901: Add FK on subscription and serial tables In order to improve performance in the serial modules and add DB constraints, this patch is going to add missing foreign key on the following columns: * serial.biblionumber * serial.subscription * subscriptionhistory.biblionumber * subscriptionhistory.subscriptionid * subscription.biblionumber Once done, some code can be removed from the Del* subroutines, as the ON CASCASE clause will make the RDBMS handles the deletions. Test plan: 0/ It would be useful to test the update DB entry on a big and old production DB, to make sure the constraints will be added correctly. We could remove the entries before creating the constraints, but it can be unecessary 1/ Make sure you can recreate a fresh install with the kohastructure.sql from this patch 2/ Make sure you can upgrade from a master install 3/ Create a subscription, serial, etc. and delete the biblio => The subscription/serials should have been deleted from the DB 4/ Create a subscription, serial, etc. and delete the subscription => The serials should have been deleted from the DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:47:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:47:56 +0000 Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and subscriptions tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve performance for |Foreign keys are missing on |serial registration |the serials and | |subscriptions tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:53:33 +0000 Subject: [Koha-bugs] [Bug 19789] Remove some indirect DBIx calls from updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart --- I think we are good for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:55:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:55:54 +0000 Subject: [Koha-bugs] [Bug 23187] Koha::Objects supports find_or_create without passing through the Koha::Object store method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23187 --- Comment #1 from Jonathan Druart --- Should we remove Koha::Objects->find_or_create? There are very few occurrences so far. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:57:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:57:57 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Jonathan Druart --- Switching back to NSO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:58:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:58:36 +0000 Subject: [Koha-bugs] [Bug 23709] Can't add new subfields to bibliographic frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #6 from Jonathan Druart --- No answer, closing. Please reopen if still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:58:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:58:37 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 23709, which changed state. Bug 23709 Summary: Can't add new subfields to bibliographic frameworks https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:59:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:59:15 +0000 Subject: [Koha-bugs] [Bug 5161] patron attributes clearing if duplicate warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20443 | Assignee|kyle.m.hall at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |20443 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 [Bug 20443] Move C4::Members::Attributes to Koha namespace -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 09:59:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 08:59:15 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5161 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5161 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161 [Bug 5161] patron attributes clearing if duplicate warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:03:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:03:58 +0000 Subject: [Koha-bugs] [Bug 23187] Koha::Objects supports find_or_create without passing through the Koha::Object store method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23187 --- Comment #2 from Martin Renvoize --- (In reply to Jonathan Druart from comment #1) > Should we remove Koha::Objects->find_or_create? > There are very few occurrences so far. I reckon that's the most pragmatic approach.. it won't be too onerous to split the calls in two.. that's what happens behind the scenes in dbic land anyway. However.. do we use any of the create_related or multi-create functionality of dbic? That uses the internal find_or_create behind te scenes inside dbic. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:04:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:04:09 +0000 Subject: [Koha-bugs] [Bug 24187] Vertically centre the holding details in each table rows in Cataloguing (staff client) and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24187 --- Comment #6 from Katrin Fischer --- Ah, yes, I think it would make sense to have a look at that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:04:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:04:24 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 b.pastern4k at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #2 from b.pastern4k at gmail.com --- I did uncheck all filters but the result is still the same - empty file with no data at all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:05:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:05:15 +0000 Subject: [Koha-bugs] [Bug 24187] Vertically centre the holding details in each table rows in Cataloguing (staff client) and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24187 --- Comment #7 from Katrin Fischer --- (In reply to Katrin Fischer from comment #6) > Ah, yes, I think it would make sense to have a look at that. = Detail page For the holdings I am not sure. We have libraries with quit a lot of text in the note fields so it would have the same effect we saw on Owen's screenshot for the catalog results. I am happy there with the top alignment right now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:10:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:10:07 +0000 Subject: [Koha-bugs] [Bug 23709] Can't add new subfields to bibliographic frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709 --- Comment #7 from Corinne Hayet --- Sorry for being late. For me, it still doesn't work in 18.11.11 despite we applied the patch. First installation was made with standard koha source (no migration) SQL query : SELECT COUNT(*) FROM authorised_value_categories WHERE category_name=""; give 1 as result. After applying the patch, we can add a subfield but we cannot update framework using import function. Corinne -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:11:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:11:03 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|REOPENED |RESOLVED --- Comment #3 from Katrin Fischer --- I know it's working fine in our 17.11 installations - please refer to the mailing list for help on this one. In addition, 17.11 is no longer maintained - there will be no bug fixes for this version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:18:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:18:09 +0000 Subject: [Koha-bugs] [Bug 24188] Sorting AZ does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24188 --- Comment #2 from KohaGeekWien --- Hi Katrin, The same thing is also in regard to sorting by Title. http://bp.reserveabooklibrary.com/cgi-bin/koha/catalogue/search.pl?idx=kw&q=ar&offset=100&sort_by=title_az Here you can see After B comes T Then C ... Can we increase that number of sorting for zebra? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:20:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:20:06 +0000 Subject: [Koha-bugs] [Bug 8959] Self checkout timeout is JavaScript-dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8959 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- (In reply to Martin Renvoize from comment #1) > Is this still true? Yes of course it is. (In reply to Jerwyn from comment #2) > Hi Owen, > > I noticed also when printing in SCO v19.5 it redirects to OPAC log-in page. > > Do you experience the same? > > Or this bug came back again > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 It is not related to this bug report. I have tried on both master and 19.05.x and I am not able to recreate this issue. Please ask the mailing list for support https://wiki.koha-community.org/wiki/Mailing_lists -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:21:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:21:34 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 b.pastern4k at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |--- Status|RESOLVED |REOPENED --- Comment #4 from b.pastern4k at gmail.com --- Items are not exported in 17.11. After I updated to 19.11 nothing is exported, I get blank files. Question is not about 17.11, it's about broken export after Koha update. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:25:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:25:55 +0000 Subject: [Koha-bugs] [Bug 23709] Can't add new subfields to bibliographic frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709 --- Comment #8 from Jonathan Druart --- (In reply to Corinne Hayet from comment #7) > After applying the patch, we can add a subfield but we cannot update > framework using import function. Bonjour Corinne, So it sounds like something else. Can you detail the steps behind "using import function"? See also bug 23398, which may be related ("Export to XML" is broken basically). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:31:21 +0000 Subject: [Koha-bugs] [Bug 24154] No indication that Default checkout, hold and return policy are set if values are blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Nick, they ("" or nothing in DB) means the same, right? If so we should not save them if "". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:34:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:34:55 +0000 Subject: [Koha-bugs] [Bug 17774] Acquisitions module getting internal server error when adding orders to basket - a case of barcode not autoincrementing (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart --- No answered, and worked for me. Closing, Eugene please reopen if still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:36:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:36:09 +0000 Subject: [Koha-bugs] [Bug 24188] Sorting AZ does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24188 --- Comment #3 from Katrin Fischer --- Your link requires a login. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:36:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:36:56 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 --- Comment #5 from Katrin Fischer --- Please attach a screenshot of the options you selected on the export form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:37:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:37:27 +0000 Subject: [Koha-bugs] [Bug 4503] Javascript files in js directory are not translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4503 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 21156 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:37:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:37:27 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 --- Comment #5 from Jonathan Druart --- *** Bug 4503 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:37:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:37:28 +0000 Subject: [Koha-bugs] [Bug 4048] CSS and JS libs must be outside of translated paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4048 Bug 4048 depends on bug 4503, which changed state. Bug 4503 Summary: Javascript files in js directory are not translated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4503 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:37:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:37:28 +0000 Subject: [Koha-bugs] [Bug 6073] string missing for translation in acq.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 Bug 6073 depends on bug 4503, which changed state. Bug 4503 Summary: Javascript files in js directory are not translated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4503 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:37:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:37:54 +0000 Subject: [Koha-bugs] [Bug 22490] Some strings in javascript files are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21156 --- Comment #4 from Jonathan Druart --- Won't be a problem with bug 21156. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:37:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:37:55 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22490 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:38:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:38:17 +0000 Subject: [Koha-bugs] [Bug 22490] Some strings in javascript files are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #5 from Jonathan Druart --- Lowering severity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:40:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:40:42 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|andrew.isherwood at ptfs-europ |lucas at bywatersolutions.com |e.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:42:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:42:19 +0000 Subject: [Koha-bugs] [Bug 24188] Sorting AZ does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24188 --- Comment #4 from KohaGeekWien --- Created attachment 96182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96182&action=edit Search Part 1 Search part1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:42:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:42:41 +0000 Subject: [Koha-bugs] [Bug 24188] Sorting AZ does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24188 --- Comment #5 from KohaGeekWien --- Created attachment 96183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96183&action=edit Search Part 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:42:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:42:41 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas at bywatersolutions.com |andrew.isherwood at ptfs-europ | |e.com CC| |hayleymapley at catalyst.net.n | |z --- Comment #5 from Jonathan Druart --- Andrew, Rmaint for 18.11 is no longer Lucas. I suggest you to provide the revert commits here with a test plan, and follow the usual workflow for integration. Better than letting the RMaint dealing with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:43:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:43:33 +0000 Subject: [Koha-bugs] [Bug 24188] Sorting AZ does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24188 --- Comment #6 from KohaGeekWien --- Katrin, as you see the result is 1433 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:47:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:47:40 +0000 Subject: [Koha-bugs] [Bug 19355] Import patrons removes circulation notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19355 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Jonathan Druart --- I still do not recreate this one. Closing. Barry, please reopen and provide more information if still valid. What I tried: Create a circ note for patron 1 Create a CSV with same cardnumber as patron 1 The CSV does not contain "borrowernotes" in the header => patron 1 still has the borrowernotes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:53:29 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 --- Comment #6 from b.pastern4k at gmail.com --- Created attachment 96184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96184&action=edit export options I tried with and without biblionumbers, with owned items checkbox active and without. The output is still empty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:55:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:55:12 +0000 Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does not update last seen date for check-ins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21494 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 10:55:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 09:55:12 +0000 Subject: [Koha-bugs] [Bug 21494] No checkin notice created for offline circulation checkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15751 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 11:21:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 10:21:16 +0000 Subject: [Koha-bugs] [Bug 20099] Filtering by Library returns incorrect results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20099 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | Component|Searching |Searching - Zebra --- Comment #3 from Jonathan Druart --- This is Zebra only (works ok with elastic) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 11:49:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 10:49:30 +0000 Subject: [Koha-bugs] [Bug 20099] Filtering by Library returns incorrect results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20099 --- Comment #4 from Jonathan Druart --- Created attachment 96185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96185&action=edit Bug 20099: Try exact search for facets -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 11:50:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 10:50:26 +0000 Subject: [Koha-bugs] [Bug 20099] Filtering by Library returns incorrect results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20099 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #5 from Jonathan Druart --- So this patch does not work as "ext" is not supported if ICU is enabled. The only thing is then to either use elastic, or modify the branchcodes :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 11:52:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 10:52:30 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95466|0 |1 is obsolete| | --- Comment #26 from Andrew Isherwood --- Created attachment 96186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96186&action=edit Bug 23838: Add 'renewals' API route This patch adds a /patrons/x/renewals API GET route which returns a patron's renewals, optionally filtered by item_id. Tests are also included Sponsored-by: Loughborough University Signed-off-by: Myka Kennedy Stephens Signed-off-by: Owen Leonard Signed-off-by: Bouzid Fergani Signed-off-by: Ben Veasey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 11:52:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 10:52:34 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95467|0 |1 is obsolete| | --- Comment #27 from Andrew Isherwood --- Created attachment 96187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96187&action=edit Bug 23838: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals that have logs associated with them. Clicking the link opens the modal that displays the logged renewals. Signed-off-by: Myka Kennedy Stephens Signed-off-by: Owen Leonard Signed-off-by: Bouzid Fergani Signed-off-by: Ben Veasey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 11:52:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 10:52:37 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95468|0 |1 is obsolete| | --- Comment #28 from Andrew Isherwood --- Created attachment 96188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96188&action=edit Bug 23838: (follow-up) Fix QA tool failures Remove those pesky tabs as requested by Owen in comment #7 Signed-off-by: Owen Leonard Signed-off-by: Bouzid Fergani Signed-off-by: Ben Veasey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 11:52:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 10:52:40 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95469|0 |1 is obsolete| | --- Comment #29 from Andrew Isherwood --- Created attachment 96189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96189&action=edit Bug 23838: (follow-up) Fix JS strings As requested by Owen in comment #7 Owen, I have modified the "x out y renewals have been logged" formation as you suggested. The "Renewed on x by y" string is harder because it contains markup and I suspected the strings file should contain such things. I have however very slightly reworded it which will hopefully mean it's structure is suitable for other languages too. Signed-off-by: Owen Leonard Signed-off-by: Bouzid Fergani Signed-off-by: Ben Veasey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 11:52:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 10:52:44 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95470|0 |1 is obsolete| | --- Comment #30 from Andrew Isherwood --- Created attachment 96190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96190&action=edit Bug 23838: (follow-up) Rephrase log message As suggested by Owen in comment #10 Thanks Owen, I went for the second option Signed-off-by: Owen Leonard Signed-off-by: Bouzid Fergani Signed-off-by: Ben Veasey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 11:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 10:53:59 +0000 Subject: [Koha-bugs] [Bug 18428] move of holds to old_reserves is not handled correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18428 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Jonathan Druart --- This is now fixed, see wiki page for more info: https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Tables still not merged however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 11:58:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 10:58:46 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 --- Comment #6 from Andrew Isherwood --- Thanks for the heads up Jonathan, I'd actually forgotten about this as Lucas said he would revert, I guess he never got a chance. "...follow the usual workflow for integration." - what would that be, apart from me creating the revert patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:02:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:02:43 +0000 Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not enforced after item is captured for hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14695 Status|NEW |In Discussion CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- It seems that it is the expected behavior. C4/Circulation.pm, in CanItemBeReserved: 394 found => undef, # Found holds don't count against a patron's holds limit Should not it be? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:02:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:02:43 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20567 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 [Bug 20567] "Holds per record (count)" limit is not enforced after item is captured for hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:02:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:02:55 +0000 Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not enforced after item is captured for hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:10:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:10:58 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95112|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:11:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:11:32 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 --- Comment #7 from Andrew Isherwood --- Created attachment 96191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96191&action=edit Revert "Bug 23229: (QA follow-up) Fix indentation" This reverts commit d4676ff4532f41abec87ba2d1128e3f219d9c920. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:11:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:11:35 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 --- Comment #8 from Andrew Isherwood --- Created attachment 96192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96192&action=edit Revert "Bug 23229: Only load ILL table JS when needed" This reverts commit f95749a66bb5dad53fa2cf00224fc38f52c1e788. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:12:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:12:20 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Andrew Isherwood --- Test plan: - Do not apply the patches - Go to /cgi-bin/koha/ill/ill-requests.pl => TEST: Observe that you receive the error: "Template process failed: file error - ill-list-table-strings.inc: not found at ..." - Apply the patches - Refresh the page => TEST: Observe that you no longer receive the error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:14:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:14:37 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #8 from Fridolin SOMERS --- (In reply to Pedro Amorim from comment #7) > Created attachment 96146 [details] [review] > Bug 24121 - Item types icons in intra search results are requesting icons > from opac images path if item-level_itypes syspref is set to biblio > > Please let me know if this looks good, Owen. Thank you. Not yet, commit message must start with : "Bug 24121: " And message is too long, I propose you remove "if item-level_itypes syspref is set to biblio" it is in description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:15:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:15:22 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 --- Comment #10 from Jonathan Druart --- (In reply to Andrew Isherwood from comment #6) > "...follow the usual workflow for integration." - what would that be, apart > from me creating the revert patches? Patch, submit, SO, ... pushed! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:16:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:16:42 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 --- Comment #11 from Andrew Isherwood --- Riiiiight, I assumed there was more to it for cases like this :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:20:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:20:39 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item types icons in intra |Item types icons in intra |search results are |search results are |requesting icons from opac |requesting icons from opac |images path if |images path |item-level_itypes syspref | |is set to biblio | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:20:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:20:41 +0000 Subject: [Koha-bugs] [Bug 24214] New: due date displayed in iso format (when sticky) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214 Bug ID: 24214 Summary: due date displayed in iso format (when sticky) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:25:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:25:41 +0000 Subject: [Koha-bugs] [Bug 24214] due date displayed in iso format (when sticky) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:25:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:25:45 +0000 Subject: [Koha-bugs] [Bug 24214] due date displayed in iso format (when sticky) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214 --- Comment #1 from Jonathan Druart --- Created attachment 96193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96193&action=edit Bug 24214: Fix due date formatting when sticky When checking out and sticky due date is selected, on the next screen the due date is displayed iso-formatted, instead of following the dateformat syspref Test plan: 0/ Do not apply the patch 1/ Check an item out, with a selected due date. Tick "Remember for session" 2/ Next screen you see the date like YYYY-MM-DD HH:MM regarless the value of the dateformat syspref 3/ Apply this patch 4/ Reload the page => The date is correctly formatted 5/ Check an item out => Due date is correctly set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:27:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:27:18 +0000 Subject: [Koha-bugs] [Bug 10391] specify due date remaining even if not selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #5 from Jonathan Druart --- Nick, not sure what you described is a bug. If the form is not submitted I would not expect the value to be modified. I am lowering severity here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:28:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:28:02 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 --- Comment #7 from Katrin Fischer --- Please try using MARC instead of XML as format. Also verify that you have biblionumbers in the range given (1-500) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:29:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:29:35 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95827|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:29:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:29:49 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96146|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:30:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:30:53 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #9 from Pedro Amorim --- Created attachment 96194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96194&action=edit Bug 24121 - Item types icons in intra search results are requesting icons from opac images path Hello Fridolin, thank you for your time. Let me know if it's okay now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:33:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:33:25 +0000 Subject: [Koha-bugs] [Bug 24215] New: Warnings about guarantor relationships show ARRAY errors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Bug ID: 24215 Summary: Warnings about guarantor relationships show ARRAY errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Depends on: 14570 Bug 14570 introduced a warning to the about page to catch and display data inconsistencies with respect to guarantor relationships matching te system preference values. However, the warning code is incorrect and therefore instead of the missing values being displayed in a list we get a nasty perl ARRAY(0x55f2846812d0) error. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:33:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:33:25 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24215 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 [Bug 24215] Warnings about guarantor relationships show ARRAY errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:33:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:33:32 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:36:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:36:36 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 --- Comment #1 from Martin Renvoize --- Created attachment 96195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96195&action=edit Bug 24215: Correct display of guarantor relationship errors Test plan: 1) Add some bad data to your borrower_relationships table. ( add or update a relationship such that the 'relationship' field contains a value not listed in the corresponding system preference. 2) Go to the about system information page and note the nasty display of ARRAY(whatever) 3) Apply the patch 4) Repeat step 2 and note that a list of bad values is now displayed instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:37:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:37:01 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:39:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:39:52 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:39:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:39:55 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #2 from Magnus Enger --- Created attachment 96196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96196&action=edit Bug 22833 - Schema update, DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:40:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:40:05 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #3 from Magnus Enger --- Created attachment 96197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96197&action=edit Bug 22833 - Flag booleans in Itemtype.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:40:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:40:09 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #4 from Magnus Enger --- Created attachment 96198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96198&action=edit Bug 22833 - Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:48:56 +0000 Subject: [Koha-bugs] [Bug 24216] New: kohastructure.sql uses BOOLEANs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24216 Bug ID: 24216 Summary: kohastructure.sql uses BOOLEANs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org kohastructure.sql uses both BOOLEAN and tinyint(1) for boolean values. The existing booleans should be converted to tinyints, as per the coding guidelines https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:51:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:51:25 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:53:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:53:46 +0000 Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:53:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:53:49 +0000 Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674 --- Comment #1 from Jonathan Druart --- Created attachment 96199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96199&action=edit Bug 21674: DB changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:53:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:53:52 +0000 Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674 --- Comment #2 from Jonathan Druart --- Created attachment 96200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96200&action=edit Bug 21674: Prevent to insert twice the same library in a group You can create hierarchical groups of libraries you are not allowed to add several times the same library to a given group/subgroup. The libraries that are part of the group is not displayed on the interface, to prevent the user to select it. However this restriction is only done template-side, the controller and module does not handle it. To prevent that this patchset enforces the constraint at DB level, and display a message to the end user. Test plan: - Go to Home › Administration › Library groups - Add a group - Add a library - reload the page several times => Without this patch the same library appears several times in the group => With this patch applied you will see a friendly error message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:54:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:54:15 +0000 Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:55:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:55:51 +0000 Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does not update last seen date for check-ins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751 --- Comment #2 from Martin Renvoize --- Created attachment 96201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96201&action=edit Bug 15751: Add ModDateLastSeen to ProcessOfflineReturn Test plan: 1) Before the patch when one checks in something using the KOCT the last seen date is not updated. 2) After the patch when one checks in something using the KOCT the last seen date is updated. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:56:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:56:08 +0000 Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does not update last seen date for check-ins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|major |normal CC| |martin.renvoize at ptfs-europe | |.com Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 12:56:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 11:56:57 +0000 Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does not update last seen date for check-ins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751 --- Comment #3 from Martin Renvoize --- The reason for two subs is that a KOCT transaction cannot deal with the error cases that AddReturn can throw.. as such we perform the actual return regardless of any normal error cases. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:02:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:02:02 +0000 Subject: [Koha-bugs] [Bug 24217] New: use Modern::Perl for modules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Bug ID: 24217 Summary: use Modern::Perl for modules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org This is not done yet! We need that for modules (at least) ASAP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:04:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:04:44 +0000 Subject: [Koha-bugs] [Bug 24217] use Modern::Perl for modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:04:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:04:47 +0000 Subject: [Koha-bugs] [Bug 24217] use Modern::Perl for modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 --- Comment #1 from Jonathan Druart --- Created attachment 96202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96202&action=edit Bug 24217: use Modern::Perl for modules We absolutely need that for modules. Test plan: git grep 2505 **/*.pm should not return any results And let's see later what needs to be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:05:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:05:10 +0000 Subject: [Koha-bugs] [Bug 24217] use Modern::Perl for modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 --- Comment #2 from Jonathan Druart --- RMaints, I do not think you should backport this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:05:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:05:34 +0000 Subject: [Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24217 --- Comment #31 from Jonathan Druart --- After bug 24217, this will no longer be a major. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 [Bug 24217] use Modern::Perl for modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:05:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:05:34 +0000 Subject: [Koha-bugs] [Bug 24217] use Modern::Perl for modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:11:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:11:01 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|major |normal See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15522 --- Comment #14 from Jonathan Druart --- Lowering severity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:11:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:11:01 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8366 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:14:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:14:48 +0000 Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does not update last seen date for check-ins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96201|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 96203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96203&action=edit Bug 15751: Add ModDateLastSeen to ProcessOfflineReturn Test plan: 1) Before the patch when one checks in something using the KOCT the last seen date is not updated. 2) After the patch when one checks in something using the KOCT the last seen date is updated. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:17:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:17:11 +0000 Subject: [Koha-bugs] [Bug 7107] 'used in' column on analytics not populating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7107 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15851 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:17:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:17:11 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7107 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:28:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:28:17 +0000 Subject: [Koha-bugs] [Bug 24217] use Modern::Perl for modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- I think we missed a few ;) I used `grep -IRiL "Modern::Perl" **/*.pm` to check and came up with this list after your patch C4/AuthoritiesMarc.pm C4/Auth.pm C4/Auth_with_cas.pm C4/Barcodes.pm C4/Bookseller.pm C4/Boolean.pm C4/Breeding.pm C4/Calendar.pm C4/Charset.pm C4/ClassSortRoutine.pm C4/ClassSource.pm C4/Creators.pm C4/Debug.pm C4/HoldsQueue.pm C4/HTML5Media.pm C4/Images.pm C4/ImportBatch.pm C4/ImportExportFramework.pm C4/ItemCirculationAlertPreference.pm C4/Labels.pm C4/Languages.pm C4/Linker.pm C4/Log.pm C4/Message.pm C4/Patroncards.pm C4/Scrubber.pm C4/Service.pm C4/ShelfBrowser.pm C4/SMS.pm C4/Stats.pm C4/Tags.pm C4/Templates.pm C4/TmplToken.pm C4/TTParser.pm Koha/Cache.pm Koha/Calendar.pm Koha/Edifact.pm Koha/EDI.pm Koha/Schema.pm Koha/SuggestionEngine.pm OpenILS/QueryParser.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:29:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:29:39 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #41 from Jonathan Druart --- (In reply to Kelly McElligott from comment #39) > Jonathan, > Two issues that I have with this: > > In this step: > > 2/ Select them and confirm the deletion > => Nothing happened and you get a message saying that one of the 2 items > from B2 is blocking the whole deletion process > > This does block the whole process! So all the item that could be deleted - > don't get deleted, the button to return to Batch Item Deletion, results in > having to re-enter all the items that could have been deleted but weren't > because of 1 item. Could the return to deletion button bring back the > screen prior to this. This is just a lot of extra work. Browser back button will do the job correctly, it will even keep the selection. Isn't it enough? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:33:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:33:02 +0000 Subject: [Koha-bugs] [Bug 24217] use Modern::Perl for modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:33:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:33:05 +0000 Subject: [Koha-bugs] [Bug 24217] use Modern::Perl for modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96202|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 96204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96204&action=edit Bug 24217: use Modern::Perl for modules when strict is missing We absolutely need that for modules. We are enabling strict by using Modern::Perl. Note that other modules from C4 use strict and warnings, instead of Modern::Perl Test plan: git grep 2505 **/*.pm should not return any results And let's see later what needs to be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:33:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:33:38 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|use Modern::Perl for |use strict for all modules |modules | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:46:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:46:42 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 --- Comment #8 from b.pastern4k at gmail.com --- Both MARC and XML give the same result. Biblionumbers in that range exist. But i cannot open them in Koha anymore. I get the following error No biblioitemnumber tag for framework "BOOK" at /usr/share/koha/lib/C4/Biblio.pm line 2779. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:56:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:56:06 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced Editor: Save .mrc save with a configurable value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |carnold at dgiinc.com |ity.org | --- Comment #3 from Cori Lynn Arnold --- Adding me as assignee -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 13:56:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 12:56:25 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- (In reply to Aleisha Amohia from comment #0) > nor can it's size be changed. I think if we're going to change the default size of the popup we should also set resizable to "yes." I would go ahead and set scrollbars to "yes" as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:02:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:02:01 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 --- Comment #5 from Martin Renvoize --- Created attachment 96205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96205&action=edit Bug 24217: use Modern::Perl for modules We absolutely need that for modules. Test plan: git grep 2505 **/*.pm should not return any results And let's see later what needs to be fixed. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:02:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:02:33 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96205|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:04:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:04:50 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96204|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 96206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96206&action=edit Bug 24217: use Modern::Perl for modules when strict is missing We absolutely need that for modules. We are enabling strict by using Modern::Perl. Note that other modules from C4 use strict and warnings, instead of Modern::Perl Test plan: git grep 2505 **/*.pm should not return any results And let's see later what needs to be fixed. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:05:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:05:32 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- Agreed, Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:06:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:06:58 +0000 Subject: [Koha-bugs] [Bug 24218] New: We should consistently `use Modern::Perl` in all modules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24218 Bug ID: 24218 Summary: We should consistently `use Modern::Perl` in all modules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org grep -IRiL "Modern::Perl" **/*.pm The above currently lists a set of file which do not call Modern::Perl.. we should fix that for consistency. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:07:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:07:24 +0000 Subject: [Koha-bugs] [Bug 24218] We should consistently `use Modern::Perl` in all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24218 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 [Bug 24217] use strict for all modules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:07:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:07:24 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24218 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24218 [Bug 24218] We should consistently `use Modern::Perl` in all modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:32:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:32:42 +0000 Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96198|0 |1 is obsolete| | --- Comment #5 from Magnus Enger --- Created attachment 96207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96207&action=edit Bug 22833 - Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:39:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:39:24 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:39:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:39:26 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96195|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 96208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96208&action=edit Bug 24215: Correct display of guarantor relationship errors Test plan: 1) Add some bad data to your borrower_relationships table. ( add or update a relationship such that the 'relationship' field contains a value not listed in the corresponding system preference. 2) Go to the about system information page and note the nasty display of ARRAY(whatever) 3) Apply the patch 4) Repeat step 2 and note that a list of bad values is now displayed instead. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:45:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:45:14 +0000 Subject: [Koha-bugs] [Bug 21842] always test Koha::ItemType in defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21842 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #14 from Jonathan Druart --- Marking as won't fix regarding to comment 12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:47:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:47:04 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 14:47:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 13:47:07 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #22 from Owen Leonard --- Created attachment 96209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96209&action=edit Bug 22880: (follow-up) Use global language variable for news language This patch removes news-specific code for defining the language of news items queried for the OPAC home page. An identical language variable is already defined globally. Previous to this patch an 'opacheader' news item would only appear on the OPAC home page. Now it should appear on all OPAC pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:36:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 14:36:58 +0000 Subject: [Koha-bugs] [Bug 22427] Serials - Frequency units should allow for issues published on specific days of the week In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22427 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Frequency Units do not |Serials - Frequency units |accommodate a 2x a week |should allow for issues |frequency |published on specific days | |of the week Version|18.05 |master --- Comment #2 from Nick Clemens --- The issue here is a serial published on Tuesdays and Thursdays. There is no way to indicate that issues are expected on specific days of the week. Would also be helpful for a serial published every other Thursday or similar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:54:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 14:54:10 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:54:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 14:54:21 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:55:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 14:55:12 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #29 from Jonathan Druart --- Date formatting is enforced template-side. This is certainly no longer valid. Closing, please reopen if still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:59:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 14:59:29 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15492 CC| |lari.taskula at hypernova.fi Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 [Bug 15492] Stand alone self check-in tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 15:59:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 14:59:29 +0000 Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22322 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 16:42:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 15:42:46 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 16:42:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 15:42:48 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #23 from Owen Leonard --- Created attachment 96210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96210&action=edit Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. This patch makes a number of improvements and ties up some loose ends where the old system preference usage wasn't getting replaced. - Removes news-specific code for defining the language of news items queried for the OPAC home page. An identical language variable is already defined globally. Previous to this patch an 'opacheader' news item would only appear on the OPAC home page. Now it should appear on all OPAC pages. - Changes the database update so that 'opacheader' news items will be inserted with a default title, matching the interface's requirement that the title field be populated. - The database update will also now insert the old opacheader system preference contents into the news item for all active languages as defined in the 'opaclanguages' system preference. This helps match the previous behavior in which the opacheader contents were the same for all languages. - Adds support for the new opacheader news item to the self checkout, self check-in, and OPAC maintenance pages. - Updates sysprefs.t which was using the opacheader preference to test on. I've changed it to use URLLinkText instead. - Removes the addition of the opacheader system preference from the installation SQL file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 16:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 15:47:24 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #24 from Owen Leonard --- (In reply to Marcel de Rooy from comment #21) > Leaving the title blank somehow is not a good idea. The revised db update fixes this by inserting some default text in the title (which isn't displayed anyway). > Opacheader shows more text than anticipated: I had this in the pref >

    TEST

    But the contents of another news item (location All) is shown > too. Probably not wanted. I can't reproduce this problem. Can you please test again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 16:52:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 15:52:02 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 --- Comment #9 from Katrin Fischer --- (In reply to b.pastern4k from comment #8) > Both MARC and XML give the same result. > Biblionumbers in that range exist. > But i cannot open them in Koha anymore. > I get the following error > No biblioitemnumber tag for framework "BOOK" at > /usr/share/koha/lib/C4/Biblio.pm line 2779. It looks like you have an issue with your data there. Did you remove or change the tag for biblioitemnumber in your frameowrk? In MARC21 this would be 999, it could be something different in UNIMARC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:19:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 16:19:22 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #10 from Katrin Fischer --- I really think this woudl be better on the mailing list - here it's only me and I am reaching the end of my knowledge. We know it does work in 17.11 as we are using it without issues, so we need to pin down why it's not working in your instance. I highly suspect a setup/configuration/data issue at this point, as you are not able to access the records in your installation either. For example you could also try it in Biblibre's demo, which is using UNIMARC: https://koha-community.org/demo/ I've just tested it there and it works pefectly including the item information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:37:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 16:37:21 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #25 from Owen Leonard --- > > Opacheader shows more text than anticipated: I had this in the pref > >

    TEST

    But the contents of another news item (location All) is shown > > too. I think I've discovered at least one way this can happen: My opaclanguages preference contained a language which wasn't actually installed and enabled. The DB update trusted the value for opaclanguages and inserted a news item using that location. Upon edit, the Koha news interface tries to pre-select the location declared in the news item. Because the translation doesn't actually exist on the system it is unable to pre-select the right value. With no pre-selected option it defaults to blank. If you don't notice this, upon saving your news item the location is set to blank and thus appears in all news-related locations. The disconnect between what is in opaclanguages and what is really installed is probably a product of running a test environment. Is it an issue which need to be addressed in this bug? Is there a reason to offer an "All" option for news items? I think the option probably hasn't been relevant since we added the "Slip" option for news items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 17:59:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 16:59:21 +0000 Subject: [Koha-bugs] [Bug 24057] Hea is not an acronym In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #5 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 18:27:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 17:27:47 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Margaret changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 19.05.06 released in| | CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:19:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 18:19:12 +0000 Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Carl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ctodd at hcc.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:55:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 18:55:58 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high CC| |wizzyrea at gmail.com Severity|normal |blocker --- Comment #4 from Liz Rea --- Potential for the wrong data to be sent to borrowers, upping the severity/priority. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 19:57:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 18:57:22 +0000 Subject: [Koha-bugs] [Bug 24219] New: Elasticsearch needs to remember sort preference when returning to result list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Bug ID: 24219 Summary: Elasticsearch needs to remember sort preference when returning to result list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: mkstephens at lancasterseminary.edu At the present, the sort preference applied to a list of results in the staff client is not remembered when the user returns to the result list after viewing a record. Ideally, clicking on the button to return to the result list should remember the sort preference selected prior to viewing a record. Steps to replicate: 1. Have Elasticsearch enabled 2. Perform a search in the staff client 3. Change the sort order to something different (try Author A-Z) 4. Click on a result to view the record 5. Click on "Results" button on left side to return to result list 6. Note that the result list is sorted by relevancy again and not call number Note: On master, the OPAC remembers sort order in both the "browse results" and "back to results" link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:13:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:13:54 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:16:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:16:09 +0000 Subject: [Koha-bugs] [Bug 24220] New: Convert OpacMoreSearches system preference to news block Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Bug ID: 24220 Summary: Convert OpacMoreSearches system preference to news block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 22880 Building on 22318, the OpacMoreSearches system preference should be converted to a Koha news block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 [Bug 22880] Convert opacheader system preference to news block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:16:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:16:09 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24220 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 [Bug 24220] Convert OpacMoreSearches system preference to news block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:16:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:16:58 +0000 Subject: [Koha-bugs] [Bug 24221] New: Convert OPACMySummaryNote system preference to news block Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Bug ID: 24221 Summary: Convert OPACMySummaryNote system preference to news block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 22880 Building on 22318, the OPACMySummaryNote system preference should be converted to a Koha news block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 [Bug 22880] Convert opacheader system preference to news block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:16:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:16:58 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24221 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 [Bug 24221] Convert OPACMySummaryNote system preference to news block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:17:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:17:23 +0000 Subject: [Koha-bugs] [Bug 24222] New: Simplify interface for adding/changing mappings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24222 Bug ID: 24222 Summary: Simplify interface for adding/changing mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: mkstephens at lancasterseminary.edu All search fields are in a single group and are not marked as being strictly for authorities or bibliographic records. On the search engine configuration page, when adding mappings to either the bibliographic records tab or the authorities tab, all search fields are available from the drop down menu at the bottom of the page. It would be really nice if there was a way to distinguish between the two groups of search fields so that these drop down menus would only show the fields for that record type. An alternative might be to reconfigure the way this page displays. Show the tables in a collapsed view based on search field. Expand a search field to see its mappings along with an empty field with "+ Add". This solution would allow a user to add mappings under the appropriate search field without having to manually select the field from a drop down.This would also make it easier to double-check to make sure you're entering the correct mapping since you'd be entering it in context, instead of at the bottom of a long list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:17:53 +0000 Subject: [Koha-bugs] [Bug 24223] New: Convert OpacNav system preference to news block Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Bug ID: 24223 Summary: Convert OpacNav system preference to news block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 22880 Building on 22318, the OpacNav system preference should be converted to a Koha news block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 [Bug 22880] Convert opacheader system preference to news block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:17:53 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 [Bug 24223] Convert OpacNav system preference to news block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:19:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:19:06 +0000 Subject: [Koha-bugs] [Bug 24224] New: Convert OpacNavBottom system preference to news block Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Bug ID: 24224 Summary: Convert OpacNavBottom system preference to news block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 22880 Building on 22318, the OpacNavBottom system preference should be converted to a Koha news block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 [Bug 22880] Convert opacheader system preference to news block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:19:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:19:06 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 [Bug 24224] Convert OpacNavBottom system preference to news block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:24:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:24:14 +0000 Subject: [Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:39:07 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96040|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes --- Created attachment 96211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96211&action=edit Bug 24164: Copy the letter for each email To test: 1 - Set or have two patrons with emails - note thier borrowernumber for the report 2 - Create a report - note the report id SELECT borrowernumber, surname, firstname WHERE borrowernumber IN (##,##); 3 - Create a notice in circulation with code TESTEMAIL 4 - The content should be "[% surname %]" 5 - perl misc/cronjobs/patron_emailer.pl --report ## --notice TESTEMAIL --module circulation --from anyone at anywhere.com --verbose 6 - Note that the emails both have the same surname 7 - Apply patch 8 - Repeat 5 9 - Emails now have correct content Signed-off-by: Kelly McElligott Signed-off-by: Jessica Zairo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:41:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:41:20 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 --- Comment #6 from Jessie Zairo --- Anyone else who tests, make sure to also set the following: In step 2 (make sure you add email to the SELECT statement and add a FROM statement - Create a report - note the report id SELECT borrowernumber, surname, firstname, email FROM borrowers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:41:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:41:35 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:50:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:50:30 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- + my $wrong_relationships = [ grep { !$valid_relationships{ $_->[0] } } @{$existing_relationships} ]; + if ( $wrong_relationships or $bad_relationships_count ) { I am expecting this condition to be always true (ARRAYREF) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:52:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:52:32 +0000 Subject: [Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:52:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:52:32 +0000 Subject: [Koha-bugs] [Bug 23584] Add public API routes to change privacy settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Bug 23584 depends on bug 20691, which changed state. Bug 20691 Summary: Add ability for guarantors to view guarantee's fines in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:52:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:52:33 +0000 Subject: [Koha-bugs] [Bug 23623] Use the new API and remove /svc scripts for privacy settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623 Bug 23623 depends on bug 20691, which changed state. Bug 20691 Summary: Add ability for guarantors to view guarantee's fines in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:52:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:52:33 +0000 Subject: [Koha-bugs] [Bug 20211] Guarantor/Guarantee and payments ideas [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20211 Bug 20211 depends on bug 20691, which changed state. Bug 20691 Summary: Add ability for guarantors to view guarantee's fines in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 20:52:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 19:52:33 +0000 Subject: [Koha-bugs] [Bug 23214] Add ability to pay guarantees fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Bug 23214 depends on bug 20691, which changed state. Bug 20691 Summary: Add ability for guarantors to view guarantee's fines in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:03:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:03:52 +0000 Subject: [Koha-bugs] [Bug 24225] New: Add Koha::Objects->search_from_api method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24225 Bug ID: 24225 Summary: Add Koha::Objects->search_from_api method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Bug 23843 introduced the Koha::Object(s)->to_api method and the attribute mappings on the Koha::Object classes. Bug 23893 will introduce the reverse mapping along with the Koha::Object->new_from_api and Koha::Object->set_from_api methods. So all the pieces are set so we can properly build a Koha::Objects->search_from_api method that does something similar to the objects.search helper, but uses the classes' mappings instead of requiring the to_api and to_model methods to be passed. This will ultimately help clean all the controllers and (hopefully) improve productivity re: adding endpoints, because of the removal of that intrinsic complexity both on controllers, and tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:03:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:03:58 +0000 Subject: [Koha-bugs] [Bug 24225] Add Koha::Objects->search_from_api method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24225 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:04:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:04:19 +0000 Subject: [Koha-bugs] [Bug 24225] Add Koha::Objects->search_from_api method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24225 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23843, 23893 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:04:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:04:19 +0000 Subject: [Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24225 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24225 [Bug 24225] Add Koha::Objects->search_from_api method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:04:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:04:19 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24225 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24225 [Bug 24225] Add Koha::Objects->search_from_api method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:08:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:08:45 +0000 Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 --- Comment #12 from Nick Clemens --- Question: Should we only load/export the mappings for the marc_type of the instance? Including the normarc and unimarc for marc21 makes the file harder to read. Same the other way round to :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:09:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:09:58 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:10:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:10:31 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:10:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:10:34 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96176|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 96212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96212&action=edit Bug 24212: Increase size of OPAC 'send list' dialog box for IE To test: 1) Create a list and view it in the OPAC (ensure you are using Internet Explorer as a browser) 2) Click Send list 3) Notice the dialog box cuts off the content in the window 4) Close the popup, apply the patch 5) Click Send list again 6) Confirm the dialog box shows the entire window 7) Confirm the box is resizable and has scrollbars Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:17:46 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | --- Comment #5 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:28:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:28:52 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #10 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:36:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:36:08 +0000 Subject: [Koha-bugs] [Bug 11964] make AcqItemSetSubfieldsWhenReceived vendor specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11964 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 21:46:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 20:46:15 +0000 Subject: [Koha-bugs] [Bug 23828] Elasticsearch - ES - Authority record results not ordered correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23828 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu --- Comment #1 from Myka Kennedy Stephens --- Part of this issue is resolved by tweaking the mappings for authorities in ES. The current community authority mappings are indexing MARC fields and subfields as strings. Example: 110(abcdefghjklnpqstvxyz) is mapped to Heading. When "Catholic Church" is used for "Search main heading," the result list looks like this (subfields added for clarity): - $a Catholic Church $x Clergy $v Biography - $a Catholic Church $z Italy $x Clergy $v Biography - $a Catholic Church $x Doctrines - $a Catholic Church $x Fiction - $a Catholic Church $v Pastoral letters and charges - $a Catholic Church $x Adult Education $v Periodicals It is ordering them this way because they are indexed with the subfields in alphabetical order -- despite the fact that the subfields do not appear in alphabetical order in the record. When 110 is mapped to Heading, without the (abcd...), the result list looks like this: - Catholic Church Adult Education Periodicals - Catholic Church Adult Education United States - Catholic Church Clergy Biography - Catholic Church Doctrines - Catholic Church Fiction - Catholic Church Italy Clergy Biography WHAT IS STILL A BUG > If a heading has a period in it, it will still appear after all the headings without a period. In the Catholic Church example, some authority records use a period: Catholic Church. Archdiocese of San Salvador (El Salvador). Archbishop (1977-1980 : Romero) That particular heading and all others that follow a similar format will not appear in the results list alphabetically. It appears at the end after all "Catholic Church" headings that do not use a period. We should probably be escaping punctuation when searching and/or indexing authorities. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 23:14:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 22:14:03 +0000 Subject: [Koha-bugs] [Bug 13901] sort1 and sort2 not on self registration form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13901 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry --- Looks like this patch no longer applies. I just had a library ask me about this. Would be great to see a new patch. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 11 23:32:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 22:32:02 +0000 Subject: [Koha-bugs] [Bug 21224] Relator term in 100$e should not be used with Authority linker script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21224 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu --- Comment #1 from Myka Kennedy Stephens --- With Elasticsearch enabled, I am finding that the linker is now successfully ignoring $e and matches to an existing authority record. I've been testing on master. The linker does have other issues, but I don't think this is an issue anymore -- at least not when Elasticsearch is enabled. Would someone check with Zebra and then update the status? I hesitate to change the status of this bug in case it is still a problem with the linker + Zebra. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 00:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 23:28:49 +0000 Subject: [Koha-bugs] [Bug 24189] Can't login to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24189 --- Comment #3 from ciarebaha --- (In reply to Jonathan Druart from comment #1) > Which exact version of Koha are you using? > > Does the problem appear after an upgrade? Or is it a fresh installation? We are using koha version 18.11 It never been upgrade since May 2019 The SIP already running smoothly since September 2019. However after the event that I mention in 1st post somehow made the SIP failed to operate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 00:31:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 23:31:37 +0000 Subject: [Koha-bugs] [Bug 24189] Can't login to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24189 --- Comment #4 from ciarebaha --- (In reply to Katrin Fischer from comment #2) > Did you set up your SIP user with circulate permissions in Koha and the conf > file correctly? > (https://koha-community.org/manual/19.11/en/html/apis_protocols.html#sip2) Yes, since this SIP already running since September 2019 & working fine before this, all the login id,password,permission already set up in koha patron & SIPconfig.xml. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 00:55:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Dec 2019 23:55:13 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 --- Comment #1 from Myka Kennedy Stephens --- Donna, Would you clarify which search engine you have enabled when you're seeing this behavior? I am doing some extensive testing with authorities on Elasticsearch and am not seeing this problem with the linker. I also have broader_headings enabled under LinkerOptions. My experience is that the linker is correctly matching x00 headings with a relator term present *only* when the x00 heading has only $a and $e present. For headings that also include dates ($d) or any other subfields, the linker will not find a match. I'm thinking this is a different bug and will be submitting it after I do some more tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 01:00:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 00:00:22 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 01:00:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 00:00:35 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 01:05:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 00:05:40 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 01:05:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 00:05:52 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 01:10:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 00:10:28 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 01:10:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 00:10:36 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 01:14:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 00:14:52 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 01:15:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 00:15:06 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 01:16:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 00:16:26 +0000 Subject: [Koha-bugs] [Bug 24226] New: Advanced editor - drops subfields/punctuation when manually linking authority records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24226 Bug ID: 24226 Summary: Advanced editor - drops subfields/punctuation when manually linking authority records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: mkstephens at lancasterseminary.edu QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In the basic editor, it is possible to manually search for an authority record and link to it while preserving the original punctuation in the bibliographic record. It is also possible to search for and link to a broader heading and the additional subfields will remain intact in the bibliographic record. If you try to do either one of these things in the advanced editor using ctrl+shift+L to get to the authority search, once you link to the authority record that you select the MARC field you are editing will be rewritten to match the corresponding field in the authority record. It would be very nice if the advanced cataloging editor would simply append the authid in $9 and leave the rest of the MARC field alone. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 02:58:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 01:58:59 +0000 Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 08:23:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 07:23:22 +0000 Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #12 from Katrin Fischer --- Lowering severity here as this can be easily avoided by updating your configuration (setting fields to mandatory). Would still be a nice addition to our sample data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 08:23:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 07:23:42 +0000 Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|software error when |Set main headings to |choosing authority via |mandatory in authority |plugin |frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 08:30:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 07:30:00 +0000 Subject: [Koha-bugs] [Bug 12477] We need better ways to manage and update MARC Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|We need better ways to |We need better ways to |manage MARC Frameworks |manage and update MARC | |Frameworks Severity|major |normal --- Comment #20 from Katrin Fischer --- Tbh, I have not read all comments to the end, but this appears to be a discussion on how to: - better store our frameworks - update the existing frameworks in an installation to changes in the standard. While both are great goals, I don't think this warrants a 'major'. Might even be categorized as enh? Lowering severity to normal for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 08:31:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 07:31:42 +0000 Subject: [Koha-bugs] [Bug 21250] Auto-self-checkout not fully compatible with two-branch library setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21250 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #16 from Katrin Fischer --- As we found a workaround, I am lowering severity to 'normal' - might be bordering on enh at this point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 08:33:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 07:33:57 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Lowering severity here - all bugs but one has been fixed and the remaining bug is marked major itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 08:38:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 07:38:44 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #26 from Marcel de Rooy --- (In reply to Owen Leonard from comment #25) > The disconnect between what is in opaclanguages and what is really installed > is probably a product of running a test environment. Is it an issue which > need to be addressed in this bug? Could we have similar problems when a language is disabled on the system at a certain point (while having news items connected to it)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 08:38:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 07:38:48 +0000 Subject: [Koha-bugs] [Bug 18097] It is possible to create unusable category codes (ccode) due to field length mismatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18097 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- It looks like we fixed this elsewhere: items.ccode is 80 chars now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 09:22:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 08:22:48 +0000 Subject: [Koha-bugs] [Bug 18097] It is possible to create unusable category codes (ccode) due to field length mismatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18097 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |DUPLICATE --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > It looks like we fixed this elsewhere: items.ccode is 80 chars now. Maybe ccode, but what I tried to address (av columns) with my patch is not fixed. *** This bug has been marked as a duplicate of bug 5458 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 09:22:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 08:22:48 +0000 Subject: [Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #23 from Jonathan Druart --- *** Bug 18097 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 09:59:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 08:59:47 +0000 Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:18:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:18:42 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:18:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:18:48 +0000 Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:18:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:18:52 +0000 Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 --- Comment #13 from Jonathan Druart --- Created attachment 96213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96213&action=edit Bug 13775: Set main headings to mandatory in authority frameworks For MARC21 we need to set the following tags as mandatory: CHRON_TERM => 148 CORPO_NAME => 110 GENRE/FORM => 155 GEOGR_NAME => 151 MEETI_NAME => 111 PERSO_NAME => 100 TOPIC_TERM => 150 UNIF_TITLE => 130 Note that it also fixes an error on the UI, which was initially reported on bug 13775. Test plan: - Create a fresh install in the language of your choice. - Confirm that when you create a new authority you cannot save without entering a value for the main heading - Edit marc record's field 648 -> chronological term - Try to add there one by clicking a link on the left side of the field. >From there it opens me to a new window, click "Create a new authority" Click on the authority creating fields randomly, save. => Without this patch an error occurred "Can't call method "subfields" on an undefined value at authorities/blinddetail-biblio-search.pl line 88." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:18:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:18:56 +0000 Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 --- Comment #14 from Jonathan Druart --- Created attachment 96214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96214&action=edit Bug 13775: Set main headings to mandatory in authority frameworks (UNIMARC) Same as previously, for UNNIMARC For unimarc_complet: CLASS => 245 CO => 210 CO_UNI_TI => 235 EXP => 232 FAM => 220 GENRE/FORM => 280 NAME_COL => 245 NP => 200 NTEXP => 242 NTWORK => 241 PA => 260 PERS => 223 PUB => 217 SAUTTIT => 240 SNC => 250 SNG => 215 TM => 216 TU => 230 WORK => 231 For unimarc_lecture_pub: CO => 210 NP => 200 SAUT => 200 SAUTTIT => 240 SCO => 210 SNC => 250 SNG => 215 STU => 230 TU => 230 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:18:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:18:59 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:19:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:19:12 +0000 Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:19:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:19:14 +0000 Subject: [Koha-bugs] [Bug 13775] Set main headings to mandatory in authority frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 --- Comment #15 from Jonathan Druart --- (In reply to Katrin Fischer from comment #12) > Lowering severity here as this can be easily avoided by updating your > configuration (setting fields to mandatory). Would still be a nice addition > to our sample data. It was on my list for today :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:34:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:34:59 +0000 Subject: [Koha-bugs] [Bug 13125] Total Holds does not tally holds / items.reserves is not populated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13125 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:37:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:37:00 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching |Searching - Zebra CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #22 from Jonathan Druart --- Seems to be working fine with elastic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:51:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:51:17 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23953 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:51:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:51:17 +0000 Subject: [Koha-bugs] [Bug 23953] Cancelling hold does not work if checkout not completed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17798 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:51:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:51:30 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|philippe.blouin at inlibro.com |koha-bugs at lists.koha-commun | |ity.org Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:55:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:55:13 +0000 Subject: [Koha-bugs] [Bug 22204] Leading spaces in barcode should not allowed in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Hi Frido, do you plan to provide a patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 10:58:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 09:58:03 +0000 Subject: [Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific fine loop when balance is used up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Hi Tomas, do you plan to work on this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:14:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 10:14:52 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:14:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 10:14:56 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 --- Comment #5 from Jonathan Druart --- Created attachment 96215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96215&action=edit Bug 23243: Adjust previous patch -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:16:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 10:16:33 +0000 Subject: [Koha-bugs] [Bug 12452] Check subscription expiration doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12452 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #5 from Jonathan Druart --- I do not understand this bug report so I am suggesting to move to the new bug 23243. It would be helpful to get the patch tested there. *** This bug has been marked as a duplicate of bug 23243 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:16:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 10:16:33 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #6 from Jonathan Druart --- *** Bug 12452 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:20:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 10:20:59 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- (In reply to j.kylmala from comment #5) > (In reply to Lucio Moraes from comment #4) > > Hi Joonas, > > if you have a staged file to test, could you share with me? > > Thank you > > Unfortunately I don't have one. And now I'm thinking if the patch I supplied > here is obsolete because this might only apply for the > https://github.com/KohaSuomi/kohasuomi version of Koha. I'll change the > status to "In Discussion" for now. Does it mean the original issue you reported is not valid for the community version? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:54:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 10:54:15 +0000 Subject: [Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific fine loop when balance is used up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #3) > Hi Tomas, do you plan to work on this one? Not in a short term. Ask Martin, as he was working on replacement methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 11:56:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 10:56:00 +0000 Subject: [Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific fine loop when balance is used up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876 --- Comment #5 from Tomás Cohen Arazi --- In the described case, the API for adding credits against a list of debit lines could be used, and it wouldn't suffer from this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:33:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 12:33:14 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #6 from Martin Renvoize --- I think it's clearer as a positive amount personally.. it's a 'credit' so it's already identified as such in the sentence rather than needing to state the sign. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:38:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 12:38:12 +0000 Subject: [Koha-bugs] [Bug 8959] Self checkout timeout is JavaScript-dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8959 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 12:40:57 +0000 Subject: [Koha-bugs] [Bug 24227] New: System Preference: EmailPurchaseSuggestion missing from the 19.05 manual Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24227 Bug ID: 24227 Summary: System Preference: EmailPurchaseSuggestion missing from the 19.05 manual Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The system preference, EmailPurchaseSuggestion is missing from the 19.05 (and 19.11) manual. Here is the information needed for this system preference There are two new system preferences that work together on this new feature: EmailPurchaseSuggestions &EmailAddressForSuggestions There are a few options for the first system preference, EmailPurchaseSuggestion. The email can be sent: -None -Email Address of Branch (found in the Libraries section of Admin) -Email address for Suggestions - which if chosen, then the next system preference will be used -Koha Admin Email Address- which is an email in the system preference, KohaAdminEmail. If a library would like to use an email separate from either the Email Address of the Branch ore the Koha Admin Email Address, then the next system preference, EmailAddressforSuggestions, should be filled in. If a library does not want to be emailed when a purchase suggestion has been made, a library would choose None (which will be set as the default on an upgrade). There is a new notice that is called New_Suggestion for this email. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:48:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 12:48:32 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #42 from Kelly McElligott --- Let me test again, using the back button did not save my barcodes in the Batch Item Deletion tool. I will attempt this again. I understand what you mean with the non-triggered holds and agree that this would be different than other Koha procedures. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:54:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 12:54:59 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:55:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 12:55:01 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96212|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 96216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96216&action=edit Bug 24212: Increase size of OPAC 'send list' dialog box for IE To test: 1) Create a list and view it in the OPAC (ensure you are using Internet Explorer as a browser) 2) Click Send list 3) Notice the dialog box cuts off the content in the window 4) Close the popup, apply the patch 5) Click Send list again 6) Confirm the dialog box shows the entire window 7) Confirm the box is resizable and has scrollbars Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 13:56:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 12:56:08 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #4 from Martin Renvoize --- Created attachment 96217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96217&action=edit Bug 23091: Work In Progress -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:02:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:02:17 +0000 Subject: [Koha-bugs] [Bug 24228] New: Add a parameter to recursively embed objects in Koha::Object(s)->to_api Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Bug ID: 24228 Summary: Add a parameter to recursively embed objects in Koha::Object(s)->to_api Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Using a syntax similar to MongoDB's dot notation, we need a way to specify which relations should be followed for recursively embedding objects. For example: $patron->to_api({ embed => { checkouts => { 'pickup_location' => 1 }, credits => 1 } }) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:02:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:02:22 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:02:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:02:22 +0000 Subject: [Koha-bugs] [Bug 23843] Make existing endpoints use Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:02:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:02:29 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:03:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:03:40 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |kyle at bywatersolutions.com, | |lari.taskula at hypernova.fi, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:03:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:03:56 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #90 from Martin Renvoize --- This all scans well, if you get a chance it would be great to have a final SO/QA by January as it's one I'm targetting for an early push. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:04:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:04:07 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #42 from Martin Renvoize --- This all scans well, if you get a chance it would be great to have a final SO/QA by January as it's one I'm targetting for an early push. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:08:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:08:29 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #27 from Owen Leonard --- (In reply to Marcel de Rooy from comment #26) > Could we have similar problems when a language is disabled on the system at > a certain point (while having news items connected to it)? The news interface offers the ability to add items in any translation which is present, not just enabled. So in order for the problem to repeat I think you'd have to: 1. Delete a translation without disabling it in the OPAC first. 2. Run this database update. 3. Try to edit a news item in the previously-enabled language. There is also the disconnect between languages enabled in the staff client and those enabled in the OPAC. It sounds like the db update should try to take into account installed languages rather than enabled languages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:10:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:10:42 +0000 Subject: [Koha-bugs] [Bug 24229] New: /items API tests fail on Ubuntu 18.04 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229 Bug ID: 24229 Summary: /items API tests fail on Ubuntu 18.04 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Tests fail in a weird way: kohadev-koha at 7369d4443675:/kohadevbox/koha$ prove t/db_dependent/api/v1/items.t t/db_dependent/api/v1/items.t .. # Inactivity timeout # Failed test 'GET //RTrSH14TLmPlTAsO1RAR9x8MhJtMO7XJS5IKOwBKfwcFnpzHSGSEPM7k:thePassword123@/api/v1/items' # at t/db_dependent/api/v1/items.t line 75. # Failed test 'SWAGGER3.2.2' # at t/db_dependent/api/v1/items.t line 75. # got: undef # expected: '200' # Looks like you planned 12 tests but ran 5. # Looks like you failed 2 tests of 5 run. t/db_dependent/api/v1/items.t .. 1/2 # Failed test 'list() tests' # at t/db_dependent/api/v1/items.t line 95. Can't use an undefined value as an ARRAY reference at t/db_dependent/api/v1/items.t line 79. # Looks like your test exited with 255 just after 1. t/db_dependent/api/v1/items.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests It happens almost randomly (I reproduced the first time I started koha-testing-docker with the master-bionic image, but then it wouldn't reproduce). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:12:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:12:22 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:12:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:12:46 +0000 Subject: [Koha-bugs] [Bug 24229] /items API tests fail on Ubuntu 18.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16825 Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 [Bug 16825] Add API route for getting an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:12:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:12:46 +0000 Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24229 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229 [Bug 24229] /items API tests fail on Ubuntu 18.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:13:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:13:17 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:13:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:13:27 +0000 Subject: [Koha-bugs] [Bug 23953] Cancelling hold does not work if checkout not completed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:24:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:24:07 +0000 Subject: [Koha-bugs] [Bug 24230] New: intranet_js plugin hook is after body Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Bug ID: 24230 Summary: intranet_js plugin hook is after body Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org The plugin hook intranet_js is after body tag in intranet-bottom.inc : [% KohaPlugins.get_plugins_intranet_js | $raw %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:26:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:26:59 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:28:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:28:36 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81317|0 |1 is obsolete| | Attachment #81318|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 96218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96218&action=edit Bug 21684: Fix delete methods and add more tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:29:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:29:24 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #9 from Jonathan Druart --- I think we should follow this path. If you all agree I will provide a follow-up to fix the different calls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:32:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:32:33 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:33:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:33:50 +0000 Subject: [Koha-bugs] [Bug 22880] Convert opacheader system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 --- Comment #28 from Owen Leonard --- Created attachment 96219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96219&action=edit Bug 22880: (follow-up) Process all installed languages, not just enabled This patch changes the database update so that the system preference is copied to news items in all installed languages, not just those enabled in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:39:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:39:57 +0000 Subject: [Koha-bugs] [Bug 24097] Don't show claims tab in patron account, when there are no claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24097 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:39:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:39:57 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24097 [Bug 24097] Don't show claims tab in patron account, when there are no claims -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:43:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:43:31 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16149 QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 [Bug 16149] Generate and send custom notices based on report output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:43:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:43:31 +0000 Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on report output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24164 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 [Bug 24164] Patron emailer cronjob is not generating unique content for notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:50:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:50:21 +0000 Subject: [Koha-bugs] [Bug 24097] Don't show claims tab in patron account, when there are no claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24097 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:53:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:53:27 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:53:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:53:30 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95982|0 |1 is obsolete| | Attachment #96211|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 96220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96220&action=edit Bug 24164: Unit test Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 14:53:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 13:53:34 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 --- Comment #8 from Jonathan Druart --- Created attachment 96221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96221&action=edit Bug 24164: Copy the letter for each email To test: 1 - Set or have two patrons with emails - note thier borrowernumber for the report 2 - Create a report - note the report id ($REPORT_ID) SELECT borrowernumber, surname, firstname, email FROM borrowers WHERE borrowernumber IN (##,##); 3 - Create a notice in circulation with code TESTEMAIL 4 - The content should be "[% surname %]" 5 - perl misc/cronjobs/patron_emailer.pl --report $REPORT_ID --notice TESTEMAIL --module circulation --from anyone at anywhere.com --verbose 6 - Note that the emails both have the same surname 7 - Apply patch 8 - Repeat 5 9 - Emails now have correct content Signed-off-by: Kelly McElligott Signed-off-by: Jessica Zairo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:11:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 14:11:14 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 --- Comment #2 from Donna --- (In reply to Myka Kennedy Stephens from comment #1) > Donna, > Would you clarify which search engine you have enabled when you're seeing > this behavior? I am doing some extensive testing with authorities on > Elasticsearch and am not seeing this problem with the linker. I also have > broader_headings enabled under LinkerOptions. > My experience is that the linker is correctly matching x00 headings with a > relator term present *only* when the x00 heading has only $a and $e present. > For headings that also include dates ($d) or any other subfields, the linker > will not find a match. I'm thinking this is a different bug and will be > submitting it after I do some more tests. This is on Zebra, Myka. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:18:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 14:18:56 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:18:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 14:18:59 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #2 from Magnus Enger --- Created attachment 96222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96222&action=edit Bug 23391 - Hide finished ILL requests Currently, the main table of ILL requests will display all ILL requests in the database, regardless of their status. For libraries with active ILL this quickly leads to a lot of requests being displayed, and the main page of the ILL module taking a long time to load. This patch proposes to fix this by introducing the ILLHiddenRequestStatuses syspref, which can take a pipe-separated list of ILL statuses that will be hidden from view in the ILL module. This means that the only way to find a hidden request will be through a report. To test: - Apply the patch and make sure the atomic database update is run - Make sure you have a few ILL requests, with at least two different statuses - Check that all requests are still displayed in the main table of ILL requests - Add one of the statuses* you have in your database to the ILLHiddenRequestStatuses syspref, reload the ILL module frontpage and verify that requests with the given status are not displayed - Change the syspref to another status and verify requests with that status are now hidden - Change the syspref to hold both statuses, separated by the pipe symbol (e.g.: A|B). Verify that no requests with the given statuses are now displayed - Run the ILL REST API tests, e.g.: $ sudo koha-shell -c "prove t/db_dependent/api/v1/illrequests.t" kohadev * = The ILLHiddenRequestStatuses syspref should hold status codes, like "REQ" and "NEW", not their human readable counterparts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:21:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 14:21:28 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #3 from Magnus Enger --- One point that should be considered: I take the string from the syspref and try to clean it up a bit with this syspref: $hidden_statuses_string =~ s/[^0-9A-Za-z_|]//g; This means that status code will only be able to contain numbers, lower and upper ascii letters and underscore. This is perhaps too strict? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:30:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 14:30:00 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart --- (In reply to Martin Renvoize from comment #16) > I've attempted a rebase of the patch.. it's not an area I'm all that > familiar with so testing is required. Reading previous comments it seems that this patch will introduce regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:30:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 14:30:12 +0000 Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching |Searching - Zebra QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:32:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 14:32:24 +0000 Subject: [Koha-bugs] [Bug 24097] Don't show claims tab in patron account, when there are no claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24097 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:40:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 14:40:45 +0000 Subject: [Koha-bugs] [Bug 11353] Searches with QueryParser activated are broken if an Uppercase is used in the index name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11353 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- IIRC QueryParser was not finished/polished and usable in production, lowering severity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 15:51:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 14:51:10 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Confirmed. To recreate: Do nothing, go to about.pl. You see: https://snipboard.io/83ID0r.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 16:18:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 15:18:32 +0000 Subject: [Koha-bugs] [Bug 24049] Limit for Consecutive Hold Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24049 --- Comment #2 from Christopher Brannon --- Let's say you place a hold on item A. You set the preference to not allow consecutive holds on the same item for 30 days. You would therefore not be able to place a hold on item A until 30 days has passed. This would give other people a chance to queue up and prevent you from constantly keeping the item on hold. It would also give the item a chance to sit on the shelf for people to see. This is definitely different than the daily hold limit. That just limits the holds in general. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 16:22:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 15:22:39 +0000 Subject: [Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 --- Comment #3 from Christopher Brannon --- (In reply to Katrin Fischer from comment #2) > Can you explain this with an example maybe? Itemtype A could go long overdue after 28 days. Itemtype B could go long overdue after 14 days. Itemtype C could go long overdue after 7 days. How can you set overdue notices to coincide with those overdue times? You can't. Right now, to cover everything, you would have to set the trigger time to be 28 days to accurately cover everything. Except there would be a delay on the notices for the itemtypes that go overdue 7 or 14 days. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 16:32:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 15:32:19 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #31 from Christopher Brannon --- (In reply to Jonathan Druart from comment #30) > Christopher, could you add your stamp on Kyle's follow-up? I tested master without the patch, and the hold is routed properly. Something has changed. I don't know if it is Owen's work on the modal, but it seems to be working properly without the patch. Can anyone confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 16:41:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 15:41:04 +0000 Subject: [Koha-bugs] [Bug 24231] New: Create classes to the message that was created with sys pref UpdateItemLocationOnCheckin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24231 Bug ID: 24231 Summary: Create classes to the message that was created with sys pref UpdateItemLocationOnCheckin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With the introduction of this new system preference UpdateItemLocationOnCheckin, the cart to shelf system preference was removed and rolled into this one. However, the alert that comes along with this new system preference is not a welcome addition to the libraries that are using Cart to Shelf functionality. Prior to this, cart to shelf functionality was a backend process that would (without staff interaction) take an item that was checked in, move it to the cart. Now, when an item is checked in (at the system preference UpdateItemLocationOnCheckin has the value _ALL: CART - each time an item is checked in, the staff get a large yellow message box and an alert. If we add a class to this message or even 2 classes this would allow these alert/audio to be turned off for those libraries that don't wish to receive this yellow alert box with every checkin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 17:13:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 16:13:32 +0000 Subject: [Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 --- Comment #4 from Katrin Fischer --- (In reply to Christopher Brannon from comment #3) > (In reply to Katrin Fischer from comment #2) > > Can you explain this with an example maybe? > > Itemtype A could go long overdue after 28 days. > Itemtype B could go long overdue after 14 days. > Itemtype C could go long overdue after 7 days. > > How can you set overdue notices to coincide with those overdue times? You > can't. Right now, to cover everything, you would have to set the trigger > time to be 28 days to accurately cover everything. Except there would be a > delay on the notices for the itemtypes that go overdue 7 or 14 days. Hi Christopher, we don't use the longoverdue process ourselves, I was not aware that it's used in combination with the overdue notices. This is really interesting. For our libraries the major concern is that it should be timed with the creating of fines, which is usually happening in a weekly interval here. I wonder if it could make sense to not tie it overdue notices but to their own set of notices by itemtype? Both could live on the same configuration page tho. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 17:13:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 16:13:41 +0000 Subject: [Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable --- Comment #10 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 17:13:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 16:13:47 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 17:14:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 16:14:26 +0000 Subject: [Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 17:30:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 16:30:39 +0000 Subject: [Koha-bugs] [Bug 7907] PDF printing of lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7907 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 17:37:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 16:37:10 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 Bohdan changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #11 from Bohdan --- It appears the problem was in the default framework. It did not have item field and biblioitemnumber defined there. After I added those export worked. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:10:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:10:07 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:10:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:10:10 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #1 from Jonathan Druart --- Created attachment 96223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96223&action=edit Bug 24156: DB changes Add a new table tables_settings to store default_display_length and default_sort_order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:10:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:10:13 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #2 from Jonathan Druart --- Created attachment 96224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96224&action=edit Bug 24156: DBIC changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:10:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:10:16 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #3 from Jonathan Druart --- Created attachment 96225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96225&action=edit Bug 24156: move ColumnsSettings to TablesSettings We are preparing the ground with this patch. As the "Columns settings" page will now add the ability to modify settings for the whole table, it makes sense to rename the file and the variables. Note that the controller script (admin/columns_settings.pl) and the yml (admin/columns_settings.yml) files have not been moved to not break shortcuts and abits people could have. But if QA decides, it could be easy to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:10:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:10:20 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #4 from Jonathan Druart --- Created attachment 96226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96226&action=edit Bug 24156: Add columns_settings.yml changes Modification of the structure of the yml file. It was table: - column list It now becomes table: default_display_length: X default_sort_order: Y columns: - column list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:10:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:10:23 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #5 from Jonathan Druart --- Created attachment 96227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96227&action=edit Bug 24156: Add missing columns to yml There were 2 columns missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:10:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:10:26 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #6 from Jonathan Druart --- Created attachment 96228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96228&action=edit Bug 24156: Make sort order and number of items to display configurable (basket page) This patch is the main patch of this patchset, you will find the description and the test plan. The idea of this new enhancement is to add the ability to define the default sort order and the default number of rows displayed on the acquisition basket page. The existing "columns settings" feature was replaced by a "tables settings" feature. To prepare the ground, there were some works that were needed: * rename variables and files * Modify the structure of the yml files * Create a new DB table to store the tables settings Test plan: 0) a. Execute the update DB entry to create the new table b. Restart all (to get a new version of the yml file, that is cached by memcached) c. Create several orders for a given basket 1) Go to the basket view page => The default values are the same than without this patchset, the number of entries to display is set to "20" and the table is sorted by basket number (first column) 2) Go to the "Columns settings" page 3) Unfold the "Acquisition" tab => Notice the 2 dropdown lists at the bottom of the basket table 4) Select different values for "Default display length" and "Default sort order" 5) Refresh the basket view page => Notice that the default settings are now effective on the table QA note: We can decide to replace the different occurrences of "Columns settings" by "Tables settings" if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:10:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:10:29 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #7 from Jonathan Druart --- Created attachment 96229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96229&action=edit Bug 24156: Adjust other tables in the yml file To match the new structure, we adjust the other tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:12:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:12:30 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96228|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 96230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96230&action=edit Bug 24156: Make sort order and number of items to display configurable (basket page) This patch is the main patch of this patchset, you will find the description and the test plan. The idea of this new enhancement is to add the ability to define the default sort order and the default number of rows displayed on the acquisition basket page. The existing "columns settings" feature was replaced by a "tables settings" feature. To prepare the ground, there were some works that were needed: * rename variables and files * Modify the structure of the yml files * Create a new DB table to store the tables settings Test plan: 0) a. Execute the update DB entry to create the new table b. Restart all (to get a new version of the yml file, that is cached by memcached) c. Create several orders for a given basket 1) Go to the basket view page => The default values are the same than without this patchset, the number of entries to display is set to "20" and the table is sorted by basket number (first column) 2) Go to the "Columns settings" page 3) Unfold the "Acquisition" tab => Notice the 2 dropdown lists at the bottom of the basket table 4) Select different values for "Default display length" and "Default sort order" 5) Refresh the basket view page => Notice that the default settings are now effective on the table QA note: We can decide to replace the different occurrences of "Columns settings" by "Tables settings" if needed. Sponsored-by: Institute of Technology Tallaght -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:12:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:12:46 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored-by: Institute of release notes| |Technology Tallaght -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:38:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:38:52 +0000 Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95514|0 |1 is obsolete| | --- Comment #3 from Maryse Simard --- Created attachment 96231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96231&action=edit Bug 24046: Untranslatable 'Activate filters' Bug 9573 moved the code for the table filters activation to it's own javascript file. The strings contained in this file are not translatable. This patch moves the strings to the datatables include file since the filters are related to datatables. Test plan: Visit the catalogue/detail.pl and reports/itemslost.pl and test that the 'Activate/Deactivate filters' option still work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 18:41:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 17:41:29 +0000 Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 --- Comment #4 from Maryse Simard --- (In reply to Jonathan Druart from comment #2) > I would suggest to have those strings defined in datatables.inc instead, as > they are related to dataTable This makes sense. I amended the patch to move the strings to this file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 19:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 18:17:53 +0000 Subject: [Koha-bugs] [Bug 24232] New: Deleting a bib record after attaching the last item to another bib Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Bug ID: 24232 Summary: Deleting a bib record after attaching the last item to another bib Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: tomascohen at gmail.com Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Bug 15496 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Now gives the ability to delete the bib if the item you are attaching to another bib is the last item on the record. The code states that the permission needed is Edit Catalogue, however, when this process is done, the API is making a call and not getting the right signal (or something). Upon working on this, it seems that a librarian would need to have the Overarching Permission in the Admin module to perform this action. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 19:25:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 18:25:15 +0000 Subject: [Koha-bugs] [Bug 24233] New: Library branches editor doesn't allow email addresses with a name Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24233 Bug ID: 24233 Summary: Library branches editor doesn't allow email addresses with a name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org So, when we send email via koha, we set the from field to just the branch email address ( e.g. "us at library.org" ). Some libraries would like to be able to have the library name as part of the email address ( e.g. "Your Library " ). The problem is that this does not pass validation in the branches editor. We know this format works because some libraries set this email format before the syntax validation was implemented. We should update the validation algorithm to allow for the latter format in addition to the former. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 20:19:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 19:19:50 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 20:26:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 19:26:05 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94504|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes --- Created attachment 96232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96232&action=edit Bug 23673: Add "Time status changed" column to patron's notices This patch adds "Time status changed" column to patron's notices tab. It also adds logic to C4::Letters to update time_status_changed column when status is changed, and leaves time_queued with message creation time. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Time status changed" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" and no "time status changed" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "time status changed" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and time status changed updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 22:09:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 21:09:47 +0000 Subject: [Koha-bugs] [Bug 24234] New: Spacing of availability note in intranet search results unclear Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234 Bug ID: 24234 Summary: Spacing of availability note in intranet search results unclear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 96233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96233&action=edit results list In search results on the Intranet, Koha lists available copies then unavailable copies, with a note about why they're unavailable. See attached screenshot. The spacing of this information makes the unavailable note ("1 unavailable:" or "1 on loan:") end up closer to the item above than the item below, giving the impression that the note applies to the first item rather than the second. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 22:34:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 21:34:34 +0000 Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660 Michael Spagnuolo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspagnuolo at nrhtx.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 22:49:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 21:49:20 +0000 Subject: [Koha-bugs] [Bug 24210] Export biblio returns empty file after update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24210 --- Comment #12 from Katrin Fischer --- (In reply to Bohdan from comment #11) > It appears the problem was in the default framework. > It did not have item field and biblioitemnumber defined there. > After I added those export worked. Thx for the feedback! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 23:51:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 22:51:00 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 23:51:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 22:51:10 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 23:54:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 22:54:54 +0000 Subject: [Koha-bugs] [Bug 24235] New: /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Bug ID: 24235 Summary: /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org Advanced notices DUEDGST does NOT send sms, just e-mail. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 23:56:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 22:56:56 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |black23 at gmail.com, | |josef.moravec at gmail.com, | |magnus at libriotech.no, | |martin.renvoize at ptfs-europe | |.com, rbit at rbit.cz Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 12 23:57:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 22:57:55 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 00:05:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 23:05:00 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #1 from Radek Šiman (R-Bit Technology, s.r.o.) --- Function send_digests contains hard-coded value "advance_notice" in messge_name (line 552 of advance_notice.pl), but it should be passed-in as a parameter, because it's called for Advance_Notice as well as for Item_Due message attributes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 00:10:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 23:10:05 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #2 from Radek Šiman (R-Bit Technology, s.r.o.) --- To reproduce this bug, please turn OFF sms PREDUEDGST, but have sms DUEDGST turned ON for a given borrower. Sms version of DUEDGST is never generated into the message queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 00:17:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Dec 2019 23:17:08 +0000 Subject: [Koha-bugs] [Bug 24236] New: Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236 Bug ID: 24236 Summary: Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: tgoatley at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When you do a search that has multiple page results in cataloging, if you do that search in quotations it will not allow you to advance the page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:13:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 01:13:23 +0000 Subject: [Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:13:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 01:13:27 +0000 Subject: [Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 --- Comment #3 from Agustín Moyano --- Created attachment 96234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96234&action=edit Bug 23223: Add AllowItemsOnHoldCheckoutSIP preference This patch adds a new systempreference for behavior for AllowItemsOnHoldCheckout may difer between intranet, SCO and SIP To test: 1. apply this patch 2. perl installer/data/mysql/updatedatabase.pl SUCCESS => There is a new syspref called AllowItemsOnHoldCheckoutSIP 3. configure and start SIPServer 4. with misc/sip_cli_emulator.pl try to checkout an item with a hold CHECK => checkout is not allowed 5. set AllowItemsOnHoldCheckoutSIP to Allow 6. restart SIPServer 7. repeat step 4 SUCCESS => checkout is allowed 8. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 02:13:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 01:13:31 +0000 Subject: [Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 --- Comment #4 from Agustín Moyano --- Created attachment 96235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96235&action=edit Bug 23223: Disable syspref cache in SIPServer When a syspref is modified, SIPServer doesn't update it's cached value until restarted. This patch disables syspref cache for SIPServer. To test: 1. set AllowItemsOnHoldCheckoutSIP preference to Don't allow 2. configure and start sipserver 3. with misc/sip_cli_emulator.pl try to checkout an item that has a hold CHECK => checkout is not allowed 4. set AllowItemsOnHoldCheckoutSIP preference to Allow 5. repeat step 3 CHECK => checkout is still not allowed 6. apply this patch and restart_all 7. repeat steps 1 to 5 SUCCESS => checkout is allowed / disallowed according to AllowItemsOnHoldCheckoutSIP preference value and no SIPServer restart is needed 8. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 07:05:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 06:05:43 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|intranet_js plugin hook is |intranet_js plugin hook is |after body |after body end tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 07:06:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 06:06:36 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 07:06:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 06:06:39 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 --- Comment #1 from Fridolin SOMERS --- Created attachment 96236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96236&action=edit Bug 24230: fix intranet_js plugin hook before body end tag The plugin hook intranet_js is after body tag in intranet-bottom.inc : [% KohaPlugins.get_plugins_intranet_js | $raw %] It must be before like in opac-bottom.inc Test plan : 1) Install a Koha plugin with intranet_js hook, like KitechenSink 2) Go to an intranet page 3) Look at source of the page to see plugin code is before body end tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:04:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 07:04:00 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #10 from Marcel de Rooy --- Distracted by: warn "Deleted $count patrons\n" if $params->{verbose}; in Koha/Patrons.pm ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:10:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 07:10:00 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #11 from Marcel de Rooy --- Not sure if this works: + ok( ref($r_us) && ref($r_them), + 'Successful delete should return the object ' ); Note that it depends on the storage backend: "The return value is a pass through of what the underlying storage backend returned, and may vary." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:20:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 07:20:50 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:20:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 07:20:52 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96075|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 96237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96237&action=edit Bug 24090: Subfield text in red when mandatory in record edition In biblio or autority record edition, color subfield text in red when mandatory. Like patron fields in patron edition form. Test plan : 1) Edit a biblio record 2) See that mandatory subield text is red (#C00) 3) Same in autority record edition Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:21:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 07:21:04 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:40:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 07:40:26 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #12 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 08:47:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 07:47:45 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:20:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 08:20:12 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #3 from Josef Moravec --- Created attachment 96238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96238&action=edit Bug 24235: Do not use hardcoded message_name Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:20:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 08:20:39 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:26:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 08:26:23 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:26:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 08:26:26 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96236|0 |1 is obsolete| | --- Comment #2 from Nicolas Legrand --- Created attachment 96239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96239&action=edit Bug 24230: fix intranet_js plugin hook before body end tag The plugin hook intranet_js is after body tag in intranet-bottom.inc : [% KohaPlugins.get_plugins_intranet_js | $raw %] It must be before like in opac-bottom.inc Test plan : 1) Install a Koha plugin with intranet_js hook, like KitechenSink 2) Go to an intranet page 3) Look at source of the page to see plugin code is before body end tag Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:28:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 08:28:05 +0000 Subject: [Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #6 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #5) > I think we should use html_line_break filter like it used to be : to allow > HTML and also present simple multi-lines text. > > Patch must cover staff and basket on MARCNOTES and notes. > > I'm on a patch and a nice test plan. Oups this is an old statement. I have no patch nor test plan. We should also fix staff interface no ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:30:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 08:30:51 +0000 Subject: [Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #7 from Katrin Fischer --- I am still not sure we should bend the standard like that... especially as it will break things like the sample below with the <> as part of the text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:44:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 08:44:59 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 09:45:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 08:45:02 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96238|0 |1 is obsolete| | --- Comment #4 from Michal Denar --- Created attachment 96240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96240&action=edit Bug 24235: Do not use hardcoded message_name Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:15:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:15:28 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target --- Comment #12 from Martin Renvoize --- I'm on board with this one.. we should be consistent in our handling of object return values. For consistency with DBIx::Class (which underpins our objects) we should stick to exceptions for failure cases. If you are able to continue this work Jonathan, that would be great :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:17:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:17:34 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #13 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #11) > Not sure if this works: > + ok( ref($r_us) && ref($r_them), > + 'Successful delete should return the object ' ); > > Note that it depends on the storage backend: > "The return value is a pass through of what the underlying storage backend > returned, and may vary." Hmm, well at the present time we only support MySQL and MariaDB as our backends and I believe those are consistent with one another in this regard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:26:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:26:53 +0000 Subject: [Koha-bugs] [Bug 21685] Name our exceptions consistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21685 --- Comment #2 from Martin Renvoize --- Agreed it would be nice to build a consistent pattern and add a guideline to help work towards that... we also don't always subclass and so exceptions are hard to find sometimes which I think is what leads to the nearly duplicate ones you have discovered. I'd even go so far as to ask the question of whether it's worth us starting to take on a more consistent approach with our objects in general.. We already actually have Moo as a dependency, we could start using some of its recommendations today if we wanted to for type checking etc. We're also doing a poor mans version of method signatures in a few cases now.. perhaps we should start advocating something there too? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:30:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:30:58 +0000 Subject: [Koha-bugs] [Bug 21685] Name our exceptions consistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21685 --- Comment #3 from Martin Renvoize --- (In reply to Martin Renvoize from comment #2) > I'd even go so far as to ask the question of whether it's worth us starting > to take on a more consistent approach with our objects in general.. We > already actually have Moo as a dependency, we could start using some of its > recommendations today if we wanted to for type checking etc. We're also > doing a poor mans version of method signatures in a few cases now.. perhaps > we should start advocating something there too? To clarify that a bit.. I'm thinking of something along the lines of Function::Parameters + Type::Tiny -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:35:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:35:12 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #25 from Martin Renvoize --- How are we doing here? I think this is close to ready now.. we're well tested for the existing functionality and I think the notes are actually helpful as they for future reference and we can tidy them up as and when we come to needing to implement changes.. the pragmatic side of me wants to push this sooner rather than later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:38:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:38:53 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #34 from Martin Renvoize --- This is on my list for early January -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:47:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:47:47 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Radek Šiman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #5 from Radek Šiman (R-Bit Technology, s.r.o.) --- Please add missing parameters to all 4 calls of "send_digests". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:52:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:52:24 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:52:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:52:56 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:53:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:53:13 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #13 from Marcel de Rooy --- IN code part $filecontent eq 'itemid_file', this does not work: @existing_items = map { my $barcode = $_; grep { $_->{barcode} eq $barcode ? $_ : () } @existing_items } @contentlist; Here you should compare with itemnumbers ! Resolved in follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:53:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:53:30 +0000 Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return causes another accruing fine when returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:53:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:53:38 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:53:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:53:41 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95659|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 96241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96241&action=edit Bug 23800: Does not order items by barcode in batch item modification They must be displayed in the same order they have been scanned (or they appear in the file) This is an alternative patch. Same behavior for barcodes or itemnumbers, as well as if a file has been used or items scanned. Code is duplicated, but refactoring is out of the scope. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:53:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:53:46 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #15 from Marcel de Rooy --- Created attachment 96242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96242&action=edit Bug 23800: (QA follow-up) Fix item case, reduce code The solution for items does not work, since it compares barcodes. Instead of a grep in a map, we could do simpler. Test plan: Try barcode file, order not by itemnumber. Toggle with case. Add wrong code. Try same via barcode list text area. Try an itemnumber file, reorder again. Add wrong number. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:54:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:54:47 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #16 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > Code is duplicated, but refactoring is out of the scope. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 10:58:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 09:58:39 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #17 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #15) > The solution for items does not work, since it compares barcodes. items => itemnumbers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:02:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:02:15 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #18 from Marcel de Rooy --- + my @barcodes = grep { exists $itemdata{lc $_} } @contentlist; THis line is even useless? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:04:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:04:25 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #19 from Marcel de Rooy --- Created attachment 96243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96243&action=edit Bug 23800: (QA follow-up) Remove useless line The lines with my @barcodes makes no sense anymore. Test plan: Test with a barcode file. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:04:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:04:38 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #6 from Jonathan Druart --- Are you sure about this patch? It sounds like a duplicate of bug 24072. I setup: https://snipboard.io/NfnZeG.jpg Then run advance_notices.pl Withtout this patch: MariaDB [koha_kohadev]> select * from message_queue\G *************************** 1. row *************************** message_id: 33 borrowernumber: 5 subject: Item Due Reminder content: You have 1 items due metadata: letter_code: DUEDGST message_transport_type: email status: pending time_queued: 2019-12-13 10:02:38 to_address: NULL from_address: root at localhost content_type: NULL *************************** 2. row *************************** message_id: 34 borrowernumber: 5 subject: duegst content: duedgst sms metadata: letter_code: DUEDGST message_transport_type: sms status: pending time_queued: 2019-12-13 10:02:38 to_address: NULL from_address: root at localhost content_type: NULL 2 rows in set (0.00 sec) With this patch: nothing is generated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:08:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:08:50 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #8 from Martin Renvoize --- Tomas, are you still aiming to get to this one, or should we unassign it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:21:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:21:02 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:21:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:21:05 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96239|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 96244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96244&action=edit Bug 24230: fix intranet_js plugin hook before body end tag The plugin hook intranet_js is after body tag in intranet-bottom.inc : [% KohaPlugins.get_plugins_intranet_js | $raw %] It must be before like in opac-bottom.inc Test plan : 1) Install a Koha plugin with intranet_js hook, like KitechenSink 2) Go to an intranet page 3) Look at source of the page to see plugin code is before body end tag Signed-off-by: Nicolas Legrand Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:21:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:21:21 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:37:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:37:05 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #21 from Marcel de Rooy --- Missing this one now: 12/06/2019 10:54 Marcel Dev (51) Catalog Add Biblio 474 biblio intranet Getting only item changes. I am not sure if I really understand "deal with ergonomic somewhere else" argument. What we do now, is: Toggle item / biblio. While we want both. I think we should adjust the query on this report. Does not seem to be a large change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:38:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:38:58 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #25 from Marcel de Rooy --- This needs feedback from the author. See previous question of Jonathan. Changing status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:51:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:51:25 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #26 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #24) > I do not understand the following change: > > +++ b/Koha/Item.pm > @@ -382,7 +382,7 @@ This method checks the tmp_holdsqueue to see if this > item has been selected for > sub has_pending_hold { > my ( $self ) = @_; > my $pending_hold = $self->_result->tmp_holdsqueues; > - return !C4::Context->preference('AllowItemsOnHoldCheckout') && > $pending_hold->count ? 1: 0; > + return $pending_hold->count ? 1: 0; > } > > > I also do not understand what it meant originally. This was explained in more detail in the comment number 3. I'm switching this back to Signed Off, OK? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:53:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:53:28 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #49 from Marcel de Rooy --- It would be nice if some of the people involved earlier could add a comment on the last signed off patch. It is actually the third try to solve this, if I am reading well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 11:59:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 10:59:43 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 --- Comment #22 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #21) > I think we should adjust the query on this report. Does not seem to be a > large change. If you are volunteering I am all good with doing it here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 12:05:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 11:05:29 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 --- Comment #23 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #22) > (In reply to Marcel de Rooy from comment #21) > > I think we should adjust the query on this report. Does not seem to be a > > large change. > > If you are volunteering I am all good with doing it here :) QA / conflict of interests ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 12:45:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 11:45:31 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 12:45:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 11:45:35 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89357|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 96245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96245&action=edit Bug 21232: Add a client-side check on biblionumber when creating a subscription This patch adds an AJAX call to the REST API (/api/v1/biblios/) to retrieve and display the biblio's title. On clicking the "next" button a check is done to make sure the title exists, which means the biblionumber we manually entered is valid (can we assume a title is mandatory?) Test plan: - Create or edit a new subscription - Enter an invalid biblionumber in the input => A friendly note is telling you that the biblio does not exist - Try to switch to the next screen => You get an alert - Enter a valid biblionumber in the input => The title is displayed => Try to switch to the next screen => It works! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 12:46:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 11:46:41 +0000 Subject: [Koha-bugs] [Bug 23677] Add API route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21232 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #23 from Jonathan Druart --- I used this new route on bug 21232. I am if it is ok to request the accept in the header (by default it is */*). Should not we default to application/json? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 12:46:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 11:46:41 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23677 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 12:47:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 11:47:21 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 12:47:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 11:47:54 +0000 Subject: [Koha-bugs] [Bug 23677] Add API route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 --- Comment #24 from Martin Renvoize --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:02:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 12:02:08 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #27 from Joonas Kylmälä --- Jonathan confirmed on IRC that it is clear now so QA please review this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:19:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 12:19:52 +0000 Subject: [Koha-bugs] [Bug 24237] New: The 406 response on the biblios end point should be more discoverable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24237 Bug ID: 24237 Summary: The 406 response on the biblios end point should be more discoverable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com Other endpoints default to an application/json response by default regardless of the Accept headers in the request. For consistency, we should do the same on the biblios endpoint.. I'm thinking a 406 still, but with a JSON encoded error message in the body explaining the available Accept headers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:26:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 12:26:29 +0000 Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- Using double quotes, subsequent pages were 'blank'. Singles quotes did not break the paging, but did make the reservoir search come up empty. https://monosnap.com/file/H3n9b1Xncd7UAGhTrkcOzv0XgSc2sH -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:30:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 12:30:54 +0000 Subject: [Koha-bugs] [Bug 23677] Add API route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 --- Comment #25 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #23) > I used this new route on bug 21232. I am if it is ok to request the accept > in the header (by default it is */*). > Should not we default to application/json? I didn't implement it like that, because I had plans of making HTML the default (i.e. the normal, tt based view). But it's a fair request. I can do it if you file a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:55:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 12:55:49 +0000 Subject: [Koha-bugs] [Bug 23677] Add API route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 --- Comment #26 from Jonathan Druart --- It seems that other routes (all? I did not check) are already defaulting to json. Is it correct? If so it would make sense to continue that way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:57:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 12:57:06 +0000 Subject: [Koha-bugs] [Bug 24238] New: GET /biblios does not default to accept:application/json Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24238 Bug ID: 24238 Summary: GET /biblios does not default to accept:application/json Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org Depends on: 23677 The accept header value has to be set, it does not default to application/json like the other routes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 [Bug 23677] Add API route to get a bibliographic record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 13:57:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 12:57:06 +0000 Subject: [Koha-bugs] [Bug 23677] Add API route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24238 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24238 [Bug 24238] GET /biblios does not default to accept:application/json -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 14:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 13:47:24 +0000 Subject: [Koha-bugs] [Bug 24239] New: Let the ILL module set ad hoc hard due dates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Bug ID: 24239 Summary: Let the ILL module set ad hoc hard due dates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: magnus at libriotech.no Reporter: magnus at libriotech.no Scenario: A member of staff has gotten an ILL loan with a date due 1 year into the future. The person handling the ILL request knows this, but needs a way to tell Koha to use the given hard due date when the loan is issued at the front desk, where noone knows about the special due date for this loan. The Swedish Libris ILL backend lets librarians store a specific due date when an ILL loan is received. This is stored as a ILL request attribute. This patch adds a syspref that can take the name of the illrequestattribute used to store the specific date. If the syspref is set, and if an item is connected to an ILL request, the due date will be taken from the illrequestattribute, instead of being calculated in the regular way, based on patroncategory and itemtype. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:06:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:06:57 +0000 Subject: [Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:06:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:06:59 +0000 Subject: [Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:00 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:02 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:04 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:24 +0000 Subject: [Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:28 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:31 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:33 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:35 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:37 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:39 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:41 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:07:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:07:42 +0000 Subject: [Koha-bugs] [Bug 24170] sysprefs search result does not have a consistent order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24170 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:13:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:13:54 +0000 Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:13:57 +0000 Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 --- Comment #1 from Magnus Enger --- Created attachment 96246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96246&action=edit Bug 24239 - Let the ILL module set ad hoc hard due dates The Swedish Libris ILL backend lets librarians store a specific due date when an ILL loan is received. This is stored as a ILL request attribute. This patch adds a syspref that can take the name of the illrequestattribute used to store the specific date. If the syspref is set, and if an item is connected to an ILL request, the due date will be taken from the illrequestattribute, instead of being calculated in the regular way, based on patroncategory and itemtype. To test: - Apply the patch and make sure the atomic database update is run - Use the FreeForm backend to add one ILL request. Take note of the illrequest_id of the request you created. We refer to this as "x" below. - Connect a biblio (with biblionumber y), that has an item with a barcode, to the ILL request directly in the database: UPADTE illrequests SET biblio_id = y WHERE illrequest_id = x; - Add an attribute to the ILL request directly in the database: INSERT INTO illrequestattributes SET illrequest_id = x, type = 'illduedate', value = '2023-01-01'; - Enter 'illduedate' as a value for the ILLUseExactDueDate syspref. - Go to circulation and issue the barcode of the item to the patron associated with the FreeForm ILL request. Verify that the loan gets a due date of 2023-01-01. - Ideally: return the item and issue it again through SIP2 and SCO, and verify that the due date is still 2023-01-01. (I don't think the REST API supports issuing yet?) - Verify that there are no regressions, so that regular calculation of due dates still work, if ILLUseExactDueDate is empty or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:24:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:24:10 +0000 Subject: [Koha-bugs] [Bug 24240] New: List on opac missing close form tag under some conditions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 Bug ID: 24240 Summary: List on opac missing close form tag under some conditions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The myform form on opac-shelves.tt only gets a closing tag if the user can manage the list or remove items. For public lists this is often not the case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:25:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:25:19 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:25:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:25:22 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94526|0 |1 is obsolete| | Attachment #94527|0 |1 is obsolete| | Attachment #94528|0 |1 is obsolete| | Attachment #94556|0 |1 is obsolete| | Attachment #94557|0 |1 is obsolete| | Attachment #94558|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 96247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96247&action=edit Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only The system preference AllowItemsOnHoldCheckout only affects SIP based checkouts. I believe we should rename it AllowItemsOnHoldCheckoutSIP so it matches AllowItemsOnHoldCheckoutSCO. We should also update the description as well. As far as I know AllowItemsOnHoldCheckout has never affected anything except SIP traffic. That does not preclude the addition of another AllowItemsOnHoldCheckout syspref that would affect the staff interface, but that would be an enhancement and is outside the scope of this bug report. Test Plan: 1) Test AllowItemsOnHoldCheckout via SIP 2) Apply this patch 3) Test AllowItemsOnHoldCheckoutSIP via SIP 4) Note there is no difference! 5) Note the syspref description has been update to mention SIP Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:25:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:25:26 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #29 from Jonathan Druart --- Created attachment 96248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96248&action=edit Bug 23233: Remove use of AllowItemsOnHoldCheckout from Koha::Item::has_pending_hold, it can cause false data to be returned Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:25:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:25:30 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #30 from Jonathan Druart --- Created attachment 96249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96249&action=edit Bug 23233: Remove use of AllowItemsOnHoldCheckout from C4::Items::GetItemsInfo Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:25:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:25:34 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #31 from Jonathan Druart --- Created attachment 96250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96250&action=edit Bug 23233: (follow-up) Remove accidentally left comment The line t::lib::Mocks::mock_preference( 'AllowItemsOnHoldCheckout', 0 ); was removed from below this comment line but the comment explaining what it does was forgotten. Signed-off-by: Lari Taskula Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:25:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:25:37 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #32 from Jonathan Druart --- Created attachment 96251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96251&action=edit Bug 23233: (follow-up) Add description to atomic upgrade Signed-off-by: Lari Taskula Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:25:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:25:41 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #33 from Jonathan Druart --- Created attachment 96252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96252&action=edit Bug 23233: (follow-up) Correct test description AllowItemsOnHoldCheckout is not checked anymore but instead only whether the tmp_holdsqueue is empty or not. Signed-off-by: Lari Taskula Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:25:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:25:57 +0000 Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:26:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:26:00 +0000 Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 --- Comment #1 from Nick Clemens --- Created attachment 96253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96253&action=edit Bug 24240: Move form closing tag outside of conditional To test: 1 - Create a public list 2 - View the list as a user not signed in 3 - Validate the HTML, note the div closed with open elements, and a form tag unclosed 4 - Apply patch 5 - Those errors are fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:26:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:26:19 +0000 Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:28:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:28:04 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #34 from Jonathan Druart --- I did not test deeply this patchset but the changes make sense to me. A quick note: Koha::Item->has_pending_hold should be replaced by Koha::Item->pending_holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 15:51:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 14:51:15 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #12 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #11) > All NULL from this patch should be compared with the .sql we have in 'en'. > But I cannot find time for that. > Checked it out 027_2 not present 048_c not present 091_bcdefgi not present 094 not present 097 not present 777 Ok 786 Ok 810_q not present 811_mor not present 830_qu not present By 'no present' I mean not in MARC21 and/or not in 'en' version. Ok is the same as 'en' Most of the lines in the last patch should be to remove the entries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:02:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:02:22 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:02:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:02:25 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #14 from Jonathan Druart --- Created attachment 96254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96254&action=edit Bug 21684: Adjust some tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:03:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:03:02 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24150 --- Comment #15 from Jonathan Druart --- Actually it seems that the only occurrence is:members/deletemem.pl but actually it is an improvement, so could be done on a separate bug report I did not find any others delete statement where the return value where useful, but I may be wrong here! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 [Bug 24150] Add missing Koha::Old::*[s] classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:03:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:03:02 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:06:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:06:22 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 --- Comment #13 from Jonathan Druart --- Gracias Bernardo! Do you mean we should remove the inserts? I would not do that, how can we know those guys don't use them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:18:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:18:01 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:18:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:18:06 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94301|0 |1 is obsolete| | Attachment #94302|0 |1 is obsolete| | Attachment #94303|0 |1 is obsolete| | Attachment #94304|0 |1 is obsolete| | Attachment #95113|0 |1 is obsolete| | Attachment #95114|0 |1 is obsolete| | Attachment #95517|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart --- Created attachment 96255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96255&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing Signed-off-by: Nicole Engard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:18:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:18:10 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #48 from Jonathan Druart --- Created attachment 96256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96256&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:18:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:18:15 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #49 from Jonathan Druart --- Created attachment 96257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96257&action=edit Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:18:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:18:19 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #50 from Jonathan Druart --- Created attachment 96258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96258&action=edit Bug 14973: Remove double textarea for notes Certainly a bad merge conflict resolution (I am certainly the one to blame). However I do not understand where this "note" variable come from. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:18:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:18:24 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #51 from Jonathan Druart --- Created attachment 96259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96259&action=edit Bug 14973: Remove double declaration of suggestions_loop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:18:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:18:29 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #52 from Jonathan Druart --- Created attachment 96260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96260&action=edit Bug 14973: Add missing filters in templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:18:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:18:33 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #53 from Jonathan Druart --- Created attachment 96261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96261&action=edit Bug 14973: Fix edit a suggestion and dup found The find duplicate call must only be done when the suggestion is new. It does not make sense to search for a duplicate when the suggestion already exists. This patch also fixes a side-effect: - Create a suggestion using an existing biblio title - Ignore the warning and save - Edit again and save => BOOM on date Template process failed: undef error - The given date (18/11/2019) does not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 168 The dates are not processed and so badly formatted when sent to the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:20:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:20:00 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:20:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:20:04 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96002|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 96262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96262&action=edit Bug 22381: Change wording on Calendar-related system TEST PLAN: 1. Apply Patch 2. Look at the 5 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay, SuspensionsCalendar) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. Signed-off-by: Bernardo Gonzalez Kriegel Fixed double 'when' on line 740 No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:21:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:21:18 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:31:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:31:45 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:31:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:31:46 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:31:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:31:48 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:31:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:31:50 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 --- Comment #25 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:31:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:31:52 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:31:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:31:54 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #20 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:31:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:31:55 +0000 Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:31:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:31:56 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:31:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:31:58 +0000 Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 --- Comment #1 from Jonathan Druart --- Created attachment 96263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96263&action=edit Bug 24158: Convert actual cost in an other currency when receiving This patch adds a currency dropdown list to the Actual cost field when receiving items in the acquisition module. The idea is to let the librarian entered a price in a foreign currency that will automatically be converted in the local currency ('active'). This converted value will be use as the actual cost once the form is submitted. Test plan: - Create several currencies with different rates - Create an order, close the basket and receive - On the receipt page you will notice a new "change currency" checkbox right close to the 'Actual cost' input. - Check it => The 'Actual cost' input is readonly and a new line appears at the bottom. - Enter a number and select a currency => The 'Actual cost' input is automatically filled with the converted value - Save => The converted Actual cost has been inserted in the database. Sponsored-by: Athlone Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:31:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:31:58 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:32:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:32:00 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:32:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:32:02 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:33:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:33:48 +0000 Subject: [Koha-bugs] [Bug 24158] Receive items in multiple currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored-by: Athlone release notes| |Institute of Technology --- Comment #2 from Jonathan Druart --- The implementation differs a bit from what was specified originally. I have tried several versions of this and ended up with this one, which seems the more ergonomic and intuitive in my opinion. https://snipboard.io/FhkwAS.jpg https://snipboard.io/GqrsVE.jpg https://snipboard.io/GhRLav.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 16:43:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 15:43:59 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 --- Comment #14 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #13) > Gracias Bernardo! No hay de qué, Jonathan! > Do you mean we should remove the inserts? > I would not do that, how can we know those guys don't use them? We can't know unfortunately. I agree that we can't remove the inserts, for now each language dir has it's own maintainer (or none), just fixing the files it's Ok As for '-6' for visibility, represents 'hidden', it's the value that I choose as default when inserting new fields/subfields, I think it's Ok too If there are interest, I can setup entries for ru and uk in https://translate.koha-community.org/projects/marc21/, then get updated frameworks from https://translate.koha-community.org/files/, and replace these files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:12:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:12:39 +0000 Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:12:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:12:42 +0000 Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236 --- Comment #2 from Nick Clemens --- Created attachment 96264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96264&action=edit Bug 24236: Fix pagination to use query_cgi This is still wrong, we should use page-numbers.inc, but that is a larger refactoring This patch fixes non-QueryParser searches by simple getting an using the escaped query (query_cgi) For QueryParser, we do what the QP code does, just uri escape the query - the way that SimpleSearch does the query parsing instead of the usual buildQuery suggest to me that we should probably switch all of this to use the general Zebra search. The issues with reservoir should be their own bug To test: 1 - Search for cat in cataloging search 2 - Get results and see you can paginate 3 - Search for "cat" 4 - Get results but subsequent pages empty 5 - Apply patch 6 - Repeat search for "cat" 7 - You can paginate 8 - Enable UseQueryParser syspref (don't worry about installing) 9 - Confirm can still search with quotes and paginate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:12:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:12:58 +0000 Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Version|19.05 |master Severity|major |normal CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:13:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:13:07 +0000 Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:21:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:21:25 +0000 Subject: [Koha-bugs] [Bug 24160] Short loan collection holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:21:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:21:28 +0000 Subject: [Koha-bugs] [Bug 24160] Short loan collection holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24160 --- Comment #1 from Jonathan Druart --- Created attachment 96265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96265&action=edit Bug 24160: Fix OPACHoldsIfAvailableAtPickup to follow holds policy Bug 17453 added the ability to restrict the pick up location for items, if at least one item was available at this location. It assumed that an available item was an item that was not checked out, not lost and not damaged. But actually we should follow holds policy, defined in the circulation rules. An item that is not checked out but on which no hold can be placed on, it should be considered as not available. Test plan: 0/ Setting up the problematic situation Considering a bibliographic record with 3 items I1, I2, and I3: I1, I2 and I3 have the same location (say Centerville) I1 and I2 have the item type 'Book' and are checked out I3 is a "Computer Files" "Computer Files" has a "No holds allowed" hold policy (bottom of the circulation rules view) Turn on off (Don't allow) OPACHoldsIfAvailableAtPickup 1/ At the OPAC place a hold on this bibliographic record (biblio or item-level hold), open the "Pick up location" dropdown list => Without this patch you cannot select "Centerville" => With this patch applied you can select it 2/ Confirm the hold => The hold as been correctly placed on the item and the pickup location is correct. 3/ Cancel the hold 4/ Check I1 in 5/ Repeat 1/ => Without and with this patch you cannot select "Centerville" 6/ Open the HTML inspector in the browser, select the dropdown list and remove the 'disabled="disabled"' attribute of the CPL option 7/ Select (force) Centerville 8/ Confirm the hold => Nothing happened! You tried to cheat and place a hold to pickup at an invalid location. Note for QA: I have tried to move that code to a module but it's not trivial at all. The availability needs to be indexed in the search engine to make all of this much more easy. Sponsored-by: Educampus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:40:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:40:38 +0000 Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:48:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:48:26 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:48:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:48:29 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95954|0 |1 is obsolete| | Attachment #95955|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 96266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96266&action=edit Bug 24150: Add Koha::Old::*[s] This bug report will add new classes for: * Koha::Old::Patron[s] * Koha::Old::Biblio[s] * Koha::Old::Item[s] * Koha::Old::Biblioitem[s] Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:48:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:48:32 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #5 from Nick Clemens --- Created attachment 96267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96267&action=edit Bug 24150: Add tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:48:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:48:34 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #6 from Nick Clemens --- Created attachment 96268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96268&action=edit Bug 24150: fix wrong semicolon Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:50:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:50:37 +0000 Subject: [Koha-bugs] [Bug 24241] New: Description missing for subpermission manage_accounts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 Bug ID: 24241 Summary: Description missing for subpermission manage_accounts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 23049 It's not in permissions.inc Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:50:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:50:37 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 [Bug 24241] Description missing for subpermission manage_accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:50:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:50:43 +0000 Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission manage_accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:52:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:52:27 +0000 Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission manage_accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:52:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:52:30 +0000 Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission manage_accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 --- Comment #1 from Jonathan Druart --- Created attachment 96269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96269&action=edit Bug 24241: (bug 23049 follow-up) Add description for manage_accounts Test plan: Edit permissions for a patron Unfold "Manage Koha system settings (Administration panel)" => Without this patch a checkbox appears without description => With this patch you see the description for manage_accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:53:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:53:03 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:53:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:53:06 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90937|0 |1 is obsolete| | Attachment #96218|0 |1 is obsolete| | Attachment #96254|0 |1 is obsolete| | --- Comment #16 from Nick Clemens --- Created attachment 96270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96270&action=edit Bug 21684: Add tests to show some of the discrepancies Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:53:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:53:09 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #17 from Nick Clemens --- Created attachment 96271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96271&action=edit Bug 21684: Fix delete methods and add more tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:53:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:53:11 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #18 from Nick Clemens --- Created attachment 96272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96272&action=edit Bug 21684: Adjust some tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:59:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:59:36 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #5 from Lucas Gass --- backported to 19.11.x for 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 17:59:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 16:59:55 +0000 Subject: [Koha-bugs] [Bug 24144] regressions.t tests have not been updated after bug 23836 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24144 --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:07:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:07:40 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:10:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:10:09 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:10:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:10:10 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 --- Comment #24 from Nick Clemens --- Created attachment 96273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96273&action=edit Bug 10352: Get add operations too When an add for biblio or item is recorded there is no space in the info field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:10:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:10:12 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 --- Comment #1 from Jonathan Druart --- Created attachment 96274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96274&action=edit Bug 24157: New permission - reopen_closed_invoices New permission to reopen a closed invoice. Test plan: - Remove the new permission "reopen_closed_invoices" for a given patron, use it to log in into Koha - Create an invoice, close it => You are not able to reopen the invoice - Add the permission => You are able to reopen the invoice Sponsored-by: Galway-Mayo Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:10:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:10:15 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 --- Comment #2 from Jonathan Druart --- Created attachment 96275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96275&action=edit Bug 24157: New permission - edit_invoices Add a new permission to edit invoices Test plan: - Remove the new permission "edit_invoices" for a given patron, use it to log in into Koha - Create an invoice, edit it (click "detail") => You can see the detail of the invoice, but cannot edit it. It's a read-only view. - Add the permission => The form is back and you can modify the invoices and save the changes. Also, you are able to create adjustments. Sponsored-by: Galway-Mayo Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:10:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:10:18 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 --- Comment #3 from Jonathan Druart --- Created attachment 96276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96276&action=edit Bug 24157: Add new method Acq::Invoice::Adjustement->fund Moving to its own commit in case we want to cherry-pick or move it to its own bug report. Sponsored-by: Galway-Mayo Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:10:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:10:22 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 --- Comment #4 from Jonathan Druart --- Created attachment 96277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96277&action=edit Bug 24157: New permission - delete_invoices Add a new permission to delete invoices Test plan: - Remove the new permission "delete_invoices" for a given patron, use it to log in into Koha - Create an invoice, try to delete it => There is no way to delete it - Add the permission => Now you can delete the invoice Sponsored-by: Galway-Mayo Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:10:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:10:25 +0000 Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 --- Comment #5 from Jonathan Druart --- Created attachment 96278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96278&action=edit Bug 24157: New permission - delete_baskets Add a new permission to delete acquisition baskets Test plan: - Remove the new permission "delete_basket" for a given patron, use it to log in into Koha - Create basket, try to delete it => There is no way to delete it - Add the permission => Now you can delete the basket Sponsored-by: Galway-Mayo Institute of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:11:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:11:37 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #25 from Nick Clemens --- This does alleviate the specific missing line that Marcel highlighted, it did point out to me though that item deletions are not going to be picked up here - we need Koha::Old::Items to get the deleted numbers to check the logs. I think this one has pointed out we have more work to do, but doe offer improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:39:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:39:01 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Paris Finley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pfinley at marian.org --- Comment #9 from Paris Finley --- As of 12/13/2019, this bug (20808) is keeping me from completing a new installation of "stable" on Ubuntu 18.04 LTS (Bionic Beaver). I am new to installing Koha; is the best solution to modify the source to an older version, then get *just* the missing dependencies, and then re-modify the source back to "stable"? What file and location contains the source info? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:41:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:41:42 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Radek Šiman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:41:45 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Radek Šiman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96240|0 |1 is obsolete| | --- Comment #7 from Radek Šiman (R-Bit Technology, s.r.o.) --- Created attachment 96279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96279&action=edit Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off DUEDGST notice required PREDUEDGST to be on, but both messages have to be generated independently Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:55:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:55:53 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96139|0 |1 is obsolete| | --- Comment #15 from Bernardo Gonzalez Kriegel --- Created attachment 96280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96280&action=edit Bug 24137: Fix biblio frameworks install for ru-Ru and uk-UA (mandatory) Replace mandatory='' with mandatory=0 perl -p -i -e "s/^\s\('', '(\d+)', '', / ('', '\1', 0, /" installer/data/mysql/ru-RU/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql installer/data/mysql/uk-UA/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:55:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:55:57 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96140|0 |1 is obsolete| | --- Comment #16 from Bernardo Gonzalez Kriegel --- Created attachment 96281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96281&action=edit Bug 24137: Fix biblio frameworks install for ru-Ru and uk-UA (repeatable) Replace repeatable='' with repeatable=0 perl -p -i -e "s/^\s\('', '(\d+)', (\d), '', / ('', '\1', \2, 0, /" installer/data/mysql/ru-RU/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql installer/data/mysql/uk-UA/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:56:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:56:01 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96141|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel --- Created attachment 96282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96282&action=edit Bug 24137: Manual replacement for hidden Arbitrary set to -6 when was NULL Signed-off-by: Bernardo Gonzalez Kriegel Fixed 991 in uk-UA marc21_bibliographic_DEFAULT_local.sql All files load without errors, mandatory and optional -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 18:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 17:56:55 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 19:04:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 18:04:25 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 --- Comment #10 from Paris Finley --- For the record, changing the source does allow updating and installing the missing files, but the installation of "stable" will still not proceed. I have installed oldstable successfully and will try to update that, as suggested above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 19:12:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 18:12:59 +0000 Subject: [Koha-bugs] [Bug 24242] New: Funds with no library assigned do not appear on edit suggestions page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Bug ID: 24242 Summary: Funds with no library assigned do not appear on edit suggestions page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org bug 18743 made $branchfilter use the logged in user branch by default, however, branchfilter is also used in the call to GetBudgets, now funds with no library associated do not appear in the dropdown when editing suggestions or in the 'Acquisition information' filters To recreate: 1 - Create a new fund with no library in an active budget 2 - Browse to Acquisitions->Suggestions 3 - Click 'Acquisition information' to expand the filters 4 - The fund does not appear 5 - Edit a suggestion 6 - Cannot set fund to your new fund, it does not appear 7 - Set the fund to your library 8 - Now it appears in suggestions management -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 19:15:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 18:15:13 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #8 from Michal Denar --- Jonathan, plase follow test plan: - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower On your screenshot is PREDUEDGST ON. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 19:17:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 18:17:15 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 19:17:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 18:17:18 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96279|0 |1 is obsolete| | --- Comment #9 from Michal Denar --- Created attachment 96283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96283&action=edit Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off DUEDGST notice required PREDUEDGST to be on, but both messages have to be generated independently Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 19:30:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 18:30:08 +0000 Subject: [Koha-bugs] [Bug 24243] New: Bad characters in AMRC cause internal server error when searching catalog Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Bug ID: 24243 Summary: Bad characters in AMRC cause internal server error when searching catalog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Koha::Biblio::Metadata::record can throw an exception, it must always be caught If CoinsInOpac is enabled we call 'get_coins' on the search results - get_coins calls for the record. On the staff details page this exception is handled but not in opac results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 19:30:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 18:30:18 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bad characters in AMRC |Bad characters in MARC |cause internal server error |cause internal server error |when searching catalog |when searching catalog -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 19:30:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 18:30:39 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle at bywatersolutions.c | |om, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |liz at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 19:35:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 18:35:49 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 --- Comment #11 from Bernardo Gonzalez Kriegel --- On a clean (vagrant) Ubuntu 18.04 I did (as root) wget -O- http://debian.koha-community.org/koha/gpg.asc | sudo apt-key add - echo deb http://debian.koha-community.org/koha oldstable main | sudo tee /etc/apt/sources.list.d/koha.list apt update apt install koha-deps koha-perldeps echo deb http://debian.koha-community.org/koha stable main | sudo tee /etc/apt/sources.list.d/koha.list apt update apt install koha koha-deps koha-perldeps and finished with (dpkg -l | egrep koha) ii koha 19.11.00-1 all integrated (physical) library management system ii koha-common 19.11.00-1 all integrated (physical) library management system ii koha-deps 19.11.00-1 all Other dep. for koha ii koha-perldeps 19.11.00-1 all Perl dep. for koha Searching for missing modules gives PERL5LIB=/usr/share/koha/lib perl koha_perl_deps.pl -m -u Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- HTTPD::Bench::ApacheBench 0 * 0.73 No Net::OAuth2::AuthorizationServer 0 * 0.16 No Selenium::Remote::Driver 0 * 1.27 No Test::DBIx::Class 0 * 0.42 No Text::CSV::Unicode 0 * 0.40 No -------------------------------------------------------------------------------------------- Total modules reported: 5 * Module is missing or requires an upgrade So seems to be Ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 20:53:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 19:53:23 +0000 Subject: [Koha-bugs] [Bug 20439] SMS provider sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439 Chris Bloomfield changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stlit at vermontel.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 20:56:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 19:56:37 +0000 Subject: [Koha-bugs] [Bug 24244] New: Cannot create suggestion with branch set to 'Any' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Bug ID: 24244 Summary: Cannot create suggestion with branch set to 'Any' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There is a foreign key constraint, we get an internal server error when trying to save branchcode 'Any' = '' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 21:01:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 20:01:32 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 21:01:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 20:01:34 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #1 from Nick Clemens --- Created attachment 96284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96284&action=edit Bug 24244: Send null instead of empty string if branch not set -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 21:01:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 20:01:52 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 21:02:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 20:02:03 +0000 Subject: [Koha-bugs] [Bug 24242] Funds with no library assigned do not appear on edit suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18743 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 [Bug 18743] Filter suggestion lists correctly for IndependentBranches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 21:02:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 20:02:03 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24242 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 [Bug 24242] Funds with no library assigned do not appear on edit suggestions page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 21:06:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 20:06:25 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #32 from Nick Clemens --- The unit tests still fail without the patches, possibly we are handling something in the templates to work around this, but we should still correct the underlying issues. Would you be willing to test with the patches Christopher to ensure they do not break anything? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 21:34:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 20:34:13 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 23:55:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 22:55:48 +0000 Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 13 23:55:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 22:55:52 +0000 Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96231|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 96285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96285&action=edit Bug 24046: Untranslatable 'Activate filters' Bug 9573 moved the code for the table filters activation to it's own javascript file. The strings contained in this file are not translatable. This patch moves the strings to the datatables include file since the filters are related to datatables. Test plan: Visit the catalogue/detail.pl and reports/itemslost.pl and test that the 'Activate/Deactivate filters' option still work correctly. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 00:03:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 23:03:59 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 00:04:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 23:04:03 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95708|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 96286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96286&action=edit Bug 24085: Make print and cancel-hold buttons instead of submit To test: 1 - Place a hold on an item 2 - Check in the item to trigger the hold 3 - Test both the print and cancel buttons to make sure all looks correct Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 00:08:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 23:08:52 +0000 Subject: [Koha-bugs] [Bug 7907] PDF printing of lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7907 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org --- Comment #6 from Owen Leonard --- Macs and Windows 10 have built-in printing to PDF, and earlier versions of Windows have applications like CutePDF Writer which can print to PDF. I don't think this is functionality which should be built into Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 00:17:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 23:17:14 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #1 from Owen Leonard --- > - Worldcat: now https > - BookFinder: now https I know we can update the installation SQL, but I'm assuming there's not a good way to update existing installations since the library could have customized this preference with their own options? > - OpenLibrary: URL search pattern changed The current pattern looks correct to me: https://openlibrary.org/search/?author=({AUTHOR})&title=({TITLE}) ...translates to: https://openlibrary.org/search?author=(Heinlein%2C%20Robert%20A.)&title=(Stranger%20in%20a%20strange%20land) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 00:46:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 23:46:29 +0000 Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 00:46:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 23:46:50 +0000 Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 00:46:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Dec 2019 23:46:53 +0000 Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 --- Comment #4 from Owen Leonard --- Created attachment 96287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96287&action=edit Bug 10469: Display more when editing subfields in frameworks This patch removes the accordion feature from the MARC subfields structure editor. The form is not long, and I think in this case the accordion makes the process more difficult to navigate. To test, apply the patch and go to Administration -> MARC frameworks -> Framework structure -> Subfield structure -> Edit. Choose a tag with multiple subfields to best test the changes. The whole form should apppear, and tabs functionality should work correctly. Test that making changes under multiple tabs works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 01:52:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Dec 2019 00:52:17 +0000 Subject: [Koha-bugs] [Bug 24245] New: opac-registration-confirmation.tt has incorrect HTML body id Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 Bug ID: 24245 Summary: opac-registration-confirmation.tt has incorrect HTML body id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The of self register confirm page is opac-main. It should be opac-registration-confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 01:59:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Dec 2019 00:59:40 +0000 Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 01:59:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Dec 2019 00:59:42 +0000 Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 --- Comment #1 from Lucas Gass --- Created attachment 96288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96288&action=edit Bug 24245: rename self reg confirm page body id test plan: apply the patch look at the self registration confirmation page and the HTML body id should be opac-registration-confirmation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 02:10:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Dec 2019 01:10:24 +0000 Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 10:08:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Dec 2019 09:08:27 +0000 Subject: [Koha-bugs] [Bug 24246] New: email id and mobile number field is not accepting inputs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24246 Bug ID: 24246 Summary: email id and mobile number field is not accepting inputs Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: PC URL: https://www.redbus.in/ OS: Windows Status: UNCONFIRMED Severity: blocker Priority: P2 Component: Bugzilla Assignee: tarikul.ewu at gmail.com Reporter: tarikul.ewu at gmail.com Deadline: 2019-12-18 Created attachment 96289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96289&action=edit redbus email id issue 1. Open any browser 2. insert url as https://www.redbus.in/ 3. Type some data in mail id or phone number textbox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 10:36:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Dec 2019 09:36:53 +0000 Subject: [Koha-bugs] [Bug 24246] email id and mobile number field is not accepting inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- This is the bug tracker for the Koha library management software. Closing your report as invalid because it's not about Koha - please recheck where to correctly direct your problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 21:29:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Dec 2019 20:29:33 +0000 Subject: [Koha-bugs] [Bug 24234] Spacing of availability note in intranet search results unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 21:29:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Dec 2019 20:29:36 +0000 Subject: [Koha-bugs] [Bug 24234] Spacing of availability note in intranet search results unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234 --- Comment #1 from Lucas Gass --- Created attachment 96290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96290&action=edit Bug 24234: fix css in staff search results A simple CSS change to make “x on loan:” and “x unavailable:” heading bold. It also confines the width/weight of img so it can never push the headings out to the right. TEST PLAN: 1 - search for a record with at least 3 items. Check one out, make another one damaged, and keep one available. 2. Search for the record 3. See unclear results in the availability section. 4. Apply patch and regenerate css (yarn build) 5. restart_all and clear cache. 6. view new, easier to read availability section -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 14 21:32:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Dec 2019 20:32:05 +0000 Subject: [Koha-bugs] [Bug 24234] Spacing of availability note in intranet search results unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:14:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:14:06 +0000 Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:14:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:14:09 +0000 Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96285|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 96291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96291&action=edit Bug 24046: Untranslatable 'Activate filters' Bug 9573 moved the code for the table filters activation to it's own javascript file. The strings contained in this file are not translatable. This patch moves the strings to the datatables include file since the filters are related to datatables. Test plan: Visit the catalogue/detail.pl and reports/itemslost.pl and test that the 'Activate/Deactivate filters' option still work correctly. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:35:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:35:59 +0000 Subject: [Koha-bugs] [Bug 24242] Funds with no library assigned do not appear on edit suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:36:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:36:02 +0000 Subject: [Koha-bugs] [Bug 24242] Funds with no library assigned do not appear on edit suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 --- Comment #1 from Jonathan Druart --- Created attachment 96292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96292&action=edit Bug 24242: Display funds that the logged in user can access - suggestions The design of this script is pretty bad and any modifications is a challenge. Here we are trying to display to display the funds available for the logged in user. I did not understand previous code, as we are doing a limit using CanUserUseBudget, I do not think it makes sense to retrieve funds for a given library. Also, I am wondering if the dropdown list in the filters has ever been populated: budgetid_loop in the template *never* appeared in the history of suggestion.pl (??) Test plan: Search for suggestions Add/edit suggestions => The funds in the dropdown list should be the ones the logged in user can use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:36:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:36:51 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:37:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:37:06 +0000 Subject: [Koha-bugs] [Bug 24242] Funds with no library assigned do not appear on edit suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:37:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:37:21 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |nick at bywatersolutions.com |ommunity.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:45:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:45:36 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:45:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:45:39 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96284|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 96293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96293&action=edit Bug 24244: Add test Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:45:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:45:42 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #3 from Jonathan Druart --- Created attachment 96294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96294&action=edit Bug 24244: Send null instead of empty string if branch not set Fix NewSuggestion if branchcode is passed with an empty string. Error was "Broken FK constraint" Test plan: Create a new suggestion, select "any" for the library. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:46:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:46:18 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22907 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 [Bug 22907] Cannot add new suggestion with strict SQL modes turned on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:46:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:46:18 +0000 Subject: [Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 [Bug 24244] Cannot create suggestion with branch set to 'Any' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:46:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:46:31 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:53:59 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23846 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:53:59 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24243 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:58:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:58:26 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 12:58:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 11:58:29 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #1 from Jonathan Druart --- Created attachment 96295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96295&action=edit Bug 24243: Do not explode if invalid metadata when searching catalogue If the bibliographic record metadata cannot be decoded, the get_coins call should catch the exception raised by Koha::Biblio::Metadata->record to not explode Error is: "Invalid data, cannot decode objec" Test plan: 0/ Do not apply the patch 1/ Search for record at the OPAC 2/ Note one of the biblionumber from the first page result 3/ Set to empty string the biblio_metadata to make the error appears: update biblio_metadata set metadata="" where biblionumber=42; 4/ Try the same search => You get an internal server error 5/ Apply the patch, restart plack and try again => It now works, ie. it does not explode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 21:09:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 20:09:15 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 22:29:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 21:29:58 +0000 Subject: [Koha-bugs] [Bug 24226] Advanced editor - drops subfields/punctuation when manually linking authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24226 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 22:32:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 21:32:48 +0000 Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 22:32:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 21:32:53 +0000 Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96288|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 96296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96296&action=edit Bug 24245: rename self reg confirm page body id Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 22:43:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 21:43:52 +0000 Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission manage_accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 22:43:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 21:43:58 +0000 Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission manage_accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96269|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 96297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96297&action=edit Bug 24241: (bug 23049 follow-up) Add description for manage_accounts Test plan: Edit permissions for a patron Unfold "Manage Koha system settings (Administration panel)" => Without this patch a checkbox appears without description => With this patch you see the description for manage_accounts Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 22:51:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 21:51:21 +0000 Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 22:51:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 21:51:27 +0000 Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96253|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 96298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96298&action=edit Bug 24240: Move form closing tag outside of conditional To test: 1 - Create a public list 2 - View the list as a user not signed in 3 - Validate the HTML, note the div closed with open elements, and a form tag unclosed 4 - Apply patch 5 - Those errors are fixed Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 15 23:02:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Dec 2019 22:02:16 +0000 Subject: [Koha-bugs] [Bug 24247] New: Button fixes for OPAC lists pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247 Bug ID: 24247 Summary: Button fixes for OPAC lists pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org There are some style issues with some buttons on the OPAC lists pages: Share link missing an icon, edit and delete button unstyled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 01:40:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 00:40:21 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #12 from Mason James --- (In reply to Paul from comment #0) > Hello, > > I am installing Koha on Ubuntu 18.04 LTS Bionic Beaver (Fresh Installation). > However, I have experienced the following error when I run "sudo apt-get > install koha-common" > > The following packages have unmet dependencies: > koha-common : Depends: libmarc-charset-perl but it is not installable > Depends: libmarc-xml-perl but it is not installable > E: Unable to correct problems, you have held broken packages. > hi folks i've fixed this issue on the new 19.11 branch run 'sudo apt update' to pull the new changes some further info from a fresh Ubuntu 18.04.3 system below... --------------------------- # cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=18.04 DISTRIB_CODENAME=bionic DISTRIB_DESCRIPTION="Ubuntu 18.04.3 LTS" # cat /etc/apt/sources.list.d/koha.list deb http://debian.koha-community.org/koha stable main # apt-cache policy koha-common koha-common: Installed: (none) Candidate: 19.11.00-1 Version table: *** 19.11.00-1 500 500 http://debian.koha-community.org/koha stable/main amd64 Packages 100 /var/lib/dpkg/status # apt-cache policy libmarc-charset-perl libmarc-charset-perl: Installed: (none) Candidate: 1.35-2~koha+1 Version table: 1.35-2~koha+1 500 500 http://debian.koha-community.org/koha stable/main amd64 Packages # apt-cache policy libmarc-xml-perl libmarc-xml-perl: Installed: (none) Candidate: 1.0.3-1~koha+1 Version table: 1.0.3-1~koha+1 500 500 http://debian.koha-community.org/koha stable/main amd64 Packages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 06:39:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 05:39:03 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #50 from David Cook --- (In reply to Marcel de Rooy from comment #49) > It would be nice if some of the people involved earlier could add a comment > on the last signed off patch. It is actually the third try to solve this, if > I am reading well. The code looks good to me. I give it a thumbs up/+1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 07:33:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 06:33:32 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|josef.moravec at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 09:49:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 08:49:16 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|In Discussion |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #20 from Jonathan Druart --- This has been fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 09:53:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 08:53:45 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Joonas Kylmälä --- This still doesn't fix the *_local.sql files insertion for russian or ukranian: > koha-mysql kohadev < installer/data/mysql/uk-UA/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_local.sql > ERROR 1366 (HY000) at line 4: Incorrect integer value: '' for column 'mandatory' at row 1 Only *_general.sql is fixed completely. For the *_local.sql files only the hidden column is fixed so the installer would fail here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 10:02:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 09:02:27 +0000 Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating a new language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 10:02:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 09:02:30 +0000 Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating a new language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96122|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 96305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96305&action=edit Bug 18688: Warnings about UTF-8 charset when creating a new language This patch removes some warnings when creating new languages, those related with uft8 and two not related. Tipical messages are: >Warning: Can't determine original templates' charset, defaulting to UTF-8 >Warning: Charset Out defaulting to UTF-8 >... >Removing empty file /../xx-YY-marc-NORMARC.po >I UTF-8 O UTF-8 at /../kohaclone/misc/translator/tmpl_process3.pl line 365. >Use of uninitialized value $pref_name in concatenation (.) or string at /.../misc/translator/LangInstaller.pm line 197. >Created /../misc/translator/po/xx-YY-messages.po. First four are 'normal' messages The fifth one correspond to an unquoted preference string The sixth one is a normal output message from msgint command We will hide them unless verbose '-v' option is selected, and fix the error. To test: 1) Go to misc/translator 2) Create new language files $ perl translate create xx-YY 3) Check warnings and messages 4) Apply the patch 5) Remove created files, and create them again Ther must be no messages 6) Repeat 5) with verbose option '-v', check old messages 7) BONUS: without the patch update a language, for example de-DE: $ perl translate update de-DE Note (git status) a new file, po/de-DE-messages.po~ This is a backup file from msgmerge command With the patch this backup is removed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 10:09:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 09:09:58 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- Hola Bernado, I like the idea, but not XML, neither the MySQL only limitation. Why not write our own stuff, yml-based? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 10:26:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 09:26:14 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #10 from Martin Renvoize --- This looks good. My only slight concern is whether it ties us more strictly to MySQL or in particular a particular MySQL version. (I'm not sure how widely supported the MySQL XML dump format is.. do they change the format when new feature are introduced for example and does MariaDB support it natively too). Perhaps we could use the well supported and maintained SQL::Translator to produce something similar in XML, YAML or JSON as our middle format ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 10:34:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 09:34:50 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 10:34:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 09:34:53 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 --- Comment #19 from Jonathan Druart --- Created attachment 96306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96306&action=edit Bug 24137: Same fixes for *_local.sql files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 10:50:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 09:50:22 +0000 Subject: [Koha-bugs] [Bug 11200] Adding subfield without field in addbiblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11200 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|major |normal --- Comment #5 from Jonathan Druart --- Lowering severity as we do not have a test plan to recreate the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 10:54:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 09:54:54 +0000 Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission manage_accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96297|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 96307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96307&action=edit Bug 24241: (bug 23049 follow-up) Add description for manage_accounts Test plan: Edit permissions for a patron Unfold "Manage Koha system settings (Administration panel)" => Without this patch a checkbox appears without description => With this patch you see the description for manage_accounts Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 10:55:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 09:55:32 +0000 Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does not update last seen date for check-ins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751 --- Comment #5 from Jonathan Druart --- I am wondering if the fix is not to use AddReturn instead of MarkIssueReturned. See also bug 21494 and https://lists.koha-community.org/pipermail/koha-devel/2019-December/045432.html -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 10:55:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 09:55:46 +0000 Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission manage_accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Thanks for the quick fix here Jonatha, I think i must have lost the change during a rebase action :( Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:08:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:08:10 +0000 Subject: [Koha-bugs] [Bug 10066] updating biblio return undefined error if linked authority does not exist in db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10066 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Jonathan Druart --- 1. link an authority to biblio 2. manually delete authority from db 3. update the biblio from staff client => No crash Closing, please reopen with updated steps to recreate the problem if still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:08:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:08:47 +0000 Subject: [Koha-bugs] [Bug 11440] Duplicate authorities when edit a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11440 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:13:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:13:53 +0000 Subject: [Koha-bugs] [Bug 17160] Foreign key constraint for message_transports is too loose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #5 from Jonathan Druart --- message_transports_ibfk_3 has been removed on bug 17762. *** This bug has been marked as a duplicate of bug 17762 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:13:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:13:53 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #61 from Jonathan Druart --- *** Bug 17160 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:13:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:13:54 +0000 Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Bug 5334 depends on bug 17160, which changed state. Bug 17160 Summary: Foreign key constraint for message_transports is too loose https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:17:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:17:58 +0000 Subject: [Koha-bugs] [Bug 23001] When the whole authority record is searched, search always returns all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Looks ok for me on master. http://pro.kohadev.org/cgi-bin/koha/authorities/authorities-home.pl?op=do_search&type=intranet&marclist=all&and_or=and&operator=is&value=biography&orderby=HeadingAsc https://snipboard.io/kzbClj.jpg http://pro.kohadev.org/cgi-bin/koha/authorities/authorities-home.pl?op=do_search&type=intranet&marclist=all&and_or=and&operator=is&value=pouet&orderby=HeadingAsc https://snipboard.io/x1SFc5.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:31:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:31:55 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:34:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:34:33 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 --- Comment #20 from Joonas Kylmälä --- Bernardo, can you sign-off also the last patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:39:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:39:17 +0000 Subject: [Koha-bugs] [Bug 12814] Authority cataloging problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12814 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |FIXED --- Comment #2 from Jonathan Druart --- I do not longer recreate the problem. I am closing it for now, please reopen if it is still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:55:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:55:56 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:55:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:55:59 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96283|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 96308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96308&action=edit Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off DUEDGST notice required PREDUEDGST to be on, but both messages have to be generated independently Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed Signed-off-by: Michal Denar Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 11:56:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 10:56:24 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |rbit at rbit.cz |ity.org | QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:03:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:03:27 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:03:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:03:30 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72639|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 96309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96309&action=edit Bug 7047: Storing subscription renewal note in suggestion to be displayed on the suggestion page. Additionally I have added a library input field in case the librarian wants to set a library branch whilst renewing a subscription. With the use case being they may have ommitted to set the branchcode whilst creating the subscription. Test plan: 1. Create a subscription (if one does not already exist) 2. Set the RenewSerialAddsSuggestion syspref to 'Add' 3. Renew the item making sure to write in a value into the note field 3. Visit the suggestions page and notice that the note is not displayed for the newly created suggestion 4. Apply patch 5. Repeat step 3. Notice that there is now a new branchcode dropdown box. Select one of your libraries and write in the value into the note field 6. Visit suggestions and notice there is now a 'Suggestion note' column in the table containing the note. Also note that the suggestion has the correct branchcode associated with it Sponsored-By: Catalyst IT Signed-off-by: Maksim Sen Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:03:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:03:34 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #10 from Jonathan Druart --- Created attachment 96310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96310&action=edit Bug 7047: Change ReNewSubscription prototype - use hashref It also removes a warn statement. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:03:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:03:38 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #11 from Jonathan Druart --- Created attachment 96311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96311&action=edit Bug 7047: Revert changes relative to the new column on suggestion list We should move that to its own bug report if needed, not sure we will all agree on that new column. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:03:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:03:52 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |24244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 [Bug 24244] Cannot create suggestion with branch set to 'Any' -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:03:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:03:52 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 [Bug 7047] Renewing serials note not visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:05:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:05:03 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:05:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:05:05 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96206|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 96312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96312&action=edit Bug 24217: use Modern::Perl for modules when strict is missing We absolutely need that for modules. We are enabling strict by using Modern::Perl. Note that other modules from C4 use strict and warnings, instead of Modern::Perl Test plan: git grep 2505 **/*.pm should not return any results And let's see later what needs to be fixed. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:07:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:07:04 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:07:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:07:06 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #35 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:07:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:07:08 +0000 Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission manage_accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:07:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:07:10 +0000 Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission manage_accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:08:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:08:22 +0000 Subject: [Koha-bugs] [Bug 16688] RenewSerialAddsSuggestion - suggestions not showing up, note not saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #0) > When renewing a serial subscription with RenewSerialAddsSuggestion set to > active, an entry is added to the suggestions table in Koha. The status is > "ASKED" and the biblionumber is column is set to the existing record. > > But the suggestion isn't shown in the acquisition module - it cannot be > found using the search options in suggestions, it doesn't show in the > pending tab. It is now shown in the pending tab. Could you please confirm that bug 7047 fixes the problems from this bug report? *** This bug has been marked as a duplicate of bug 7047 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:08:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:08:22 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #12 from Jonathan Druart --- *** Bug 16688 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:09:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:09:01 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > *** Bug 16688 has been marked as a duplicate of this bug. *** Adjusting severity, setting to major. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:17:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:17:58 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:18:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:18:02 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96286|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 96313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96313&action=edit Bug 24085: Make print and cancel-hold buttons instead of submit To test: 1 - Place a hold on an item 2 - Check in the item to trigger the hold 3 - Test both the print and cancel buttons to make sure all looks correct Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:22:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:22:12 +0000 Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:22:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:22:15 +0000 Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96298|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 96314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96314&action=edit Bug 24240: Move form closing tag outside of conditional To test: 1 - Create a public list 2 - View the list as a user not signed in 3 - Validate the HTML, note the div closed with open elements, and a form tag unclosed 4 - Apply patch 5 - Those errors are fixed Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:25:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:25:56 +0000 Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:26:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:26:00 +0000 Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96296|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 96315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96315&action=edit Bug 24245: rename self reg confirm page body id Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:30:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:30:05 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:30:09 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96262|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 96316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96316&action=edit Bug 22381: Change wording on Calendar-related system TEST PLAN: 1. Apply Patch 2. Look at the 5 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay, SuspensionsCalendar) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. Signed-off-by: Bernardo Gonzalez Kriegel Fixed double 'when' on line 740 No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:31:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:31:37 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #14 from Jonathan Druart --- We have a quick long option now, may be problematic for translated interface (?) https://snipboard.io/4cwWXl.jpg Passing QA anyway, not blocker (hopefully) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:47:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:47:09 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:47:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:47:12 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96309|0 |1 is obsolete| | Attachment #96310|0 |1 is obsolete| | Attachment #96311|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 96317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96317&action=edit Bug 7047: Storing subscription renewal note in suggestion to be displayed on the suggestion page. Additionally I have added a library input field in case the librarian wants to set a library branch whilst renewing a subscription. With the use case being they may have ommitted to set the branchcode whilst creating the subscription. Test plan: 1. Create a subscription (if one does not already exist) 2. Set the RenewSerialAddsSuggestion syspref to 'Add' 3. Renew the item making sure to write in a value into the note field 3. Visit the suggestions page and notice that the note is not displayed for the newly created suggestion 4. Apply patch 5. Repeat step 3. Notice that there is now a new branchcode dropdown box. Select one of your libraries and write in the value into the note field 6. Visit suggestions and notice there is now a 'Suggestion note' column in the table containing the note. Also note that the suggestion has the correct branchcode associated with it Sponsored-By: Catalyst IT Signed-off-by: Maksim Sen Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:47:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:47:15 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #15 from Nick Clemens --- Created attachment 96318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96318&action=edit Bug 7047: Change ReNewSubscription prototype - use hashref It also removes a warn statement. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:47:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:47:18 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #16 from Nick Clemens --- Created attachment 96319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96319&action=edit Bug 7047: Revert changes relative to the new column on suggestion list We should move that to its own bug report if needed, not sure we will all agree on that new column. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:47:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:47:21 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #17 from Nick Clemens --- Created attachment 96320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96320&action=edit Bug 7047: (QA follow-up) Add missing filters Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 12:47:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 11:47:25 +0000 Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #18 from Nick Clemens --- Created attachment 96321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96321&action=edit Bug 7047: (QA follow-up) Fix tests Tests fail on biblionumber constraint for suggestions if 'RenewSerialAddsSuggestion' is enabled Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:02:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:02:23 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:02:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:02:23 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22359 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 [Bug 22359] Improve usability of 'change calculation' (bug 11373) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:04:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:04:18 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:04:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:04:18 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22359 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 [Bug 22359] Improve usability of 'change calculation' (bug 11373) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:04:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:04:54 +0000 Subject: [Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:04:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:04:54 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23228 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 [Bug 23228] Add option to automatically display payment receipt for printing after making a payment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:05:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:05:17 +0000 Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the fine payment forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:05:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:05:17 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11373 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:06:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:06:25 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:06:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:06:25 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22359 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 [Bug 22359] Improve usability of 'change calculation' (bug 11373) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:12:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:12:58 +0000 Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 --- Comment #2 from Martin Renvoize --- Comment on attachment 96173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96173 Bug 24208: Remove change calculation for writeoffs Review of attachment 96173: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24208&attachment=96173) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ +230,5 @@ > [% total | format('%.2f') %] > >
  • > + [% IF type == 'WRITEOFF' %] > + You probably still need the trailing space here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:15:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:15:08 +0000 Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- This looks good at a quick glance.. but perhaps we could improve it further whilst we're here. It looks me like the form title is still 'Pay an amount toward selected fines'.. we could add a switch for this too `Writeoff an amount toward selected fines` perhaps? We also still show the 'Payment types' selection dropdown unless I'm mistaken.. that could also go on a writeoff action I imagine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:17:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:17:04 +0000 Subject: [Koha-bugs] [Bug 23376] Cleanup order receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:19:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:19:17 +0000 Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:23:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:23:45 +0000 Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #8 from Magnus Enger --- Just adding a quick note that another way to set the sort bin could be to let plugins do it - that would allow for even more dynamic rules etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:40:57 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:41:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:41:00 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95205|0 |1 is obsolete| | Attachment #95206|0 |1 is obsolete| | Attachment #95207|0 |1 is obsolete| | --- Comment #24 from Nick Clemens --- Created attachment 96322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96322&action=edit Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:41:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:41:03 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #25 from Nick Clemens --- Created attachment 96323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96323&action=edit Bug 14963: Set status=ORDERED for suggestions created from existing record Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:41:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:41:05 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #26 from Nick Clemens --- Created attachment 96324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96324&action=edit Bug 14963: Fix ergonomic issue on small screen Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:41:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:41:49 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:41:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:41:53 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96255|0 |1 is obsolete| | --- Comment #54 from Nick Clemens --- Created attachment 96325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96325&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing Signed-off-by: Nicole Engard Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:41:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:41:57 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96256|0 |1 is obsolete| | --- Comment #55 from Nick Clemens --- Created attachment 96326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96326&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:42:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:42:01 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96257|0 |1 is obsolete| | --- Comment #56 from Nick Clemens --- Created attachment 96327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96327&action=edit Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:42:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:42:06 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96258|0 |1 is obsolete| | --- Comment #57 from Nick Clemens --- Created attachment 96328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96328&action=edit Bug 14973: Remove double textarea for notes Certainly a bad merge conflict resolution (I am certainly the one to blame). However I do not understand where this "note" variable come from. Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:42:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:42:10 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96259|0 |1 is obsolete| | --- Comment #58 from Nick Clemens --- Created attachment 96329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96329&action=edit Bug 14973: Remove double declaration of suggestions_loop Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:42:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:42:14 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96260|0 |1 is obsolete| | --- Comment #59 from Nick Clemens --- Created attachment 96330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96330&action=edit Bug 14973: Add missing filters in templates Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 13:42:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 12:42:18 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96261|0 |1 is obsolete| | --- Comment #60 from Nick Clemens --- Created attachment 96331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96331&action=edit Bug 14973: Fix edit a suggestion and dup found The find duplicate call must only be done when the suggestion is new. It does not make sense to search for a duplicate when the suggestion already exists. This patch also fixes a side-effect: - Create a suggestion using an existing biblio title - Ignore the warning and save - Edit again and save => BOOM on date Template process failed: undef error - The given date (18/11/2019) does not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 168 The dates are not processed and so badly formatted when sent to the template. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 14:23:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 13:23:05 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95793|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 96332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96332&action=edit Bug 24080: Payout account debit type -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 14:23:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 13:23:09 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95794|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 96333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96333&action=edit Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 14:23:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 13:23:12 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95795|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 96334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96334&action=edit Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 14:23:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 13:23:15 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95796|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 96335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96335&action=edit Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 14:24:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 13:24:25 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #19 from Martin Renvoize --- Question.. should we prevent staff from paying out to themselves as a security measure? -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 14:32:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 13:32:57 +0000 Subject: [Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22426 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 14:32:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 13:32:57 +0000 Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24127 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 14:35:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 13:35:10 +0000 Subject: [Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #6 from Jonathan Druart --- I understand why we removed it from the OPAC, it does not mean anything for a regular users. But, staff-side, how could we know we are not doing to break someone's workflow? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 14:43:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 13:43:05 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea --- this happens in the record exporter as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 14:47:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 13:47:23 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96273|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 96336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96336&action=edit Bug 10352: Get add operations too When an add for biblio or item is recorded there is no space in the info field Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 14:55:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 13:55:46 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:04:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:04:45 +0000 Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- What I see is different from what you advertised: https://snipboard.io/X4UwbT.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:06:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:06:57 +0000 Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > What I see is different from what you advertised: > https://snipboard.io/X4UwbT.jpg Hum ignore that, I got an error on `yarn build` that I did not see! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:12:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:12:10 +0000 Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:12:13 +0000 Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94977|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 96337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96337&action=edit Bug 23889: Improve style of menu header in advanced cataloging editor This patch updates the style of dropdown menu headers to make it apply more globally and changes the advanced cataloging editor template so that the correct class is applied to the menu header. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test the interfaces where these kinds of menu headers can be found: - Catalog search results: The "Sort" menu (Popularity, Author, etc. headings). - Saved report results: Run a report which returns a column of biblionumbers or itemnumbers. Check the "Batch operations" menu (Bibliographic records or item records headings). - Advanced cataloging editor: The settings menu (Change framework header). Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:12:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:12:17 +0000 Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 --- Comment #6 from Jonathan Druart --- Created attachment 96338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96338&action=edit Bug 23889: Use same css class on the basic editor view Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:12:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:12:45 +0000 Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #6) > Created attachment 96338 [details] [review] > Bug 23889: Use same css class on the basic editor view > > Signed-off-by: Jonathan Druart Owen, can you confirm you agree with this patch please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:13:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:13:33 +0000 Subject: [Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > I understand why we removed it from the OPAC, it does not mean anything for > a regular users. But, staff-side, how could we know we are not doing to > break someone's workflow? The only scenario it works under is ES, which is a limited user set at this point so the likelihood is small. The working result is reproducible under the advanced search as well, without requiring user to know the codes for itemtypes. The search will still work via direct-query, JS can be added to restore the option if a user needs it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:18:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:18:37 +0000 Subject: [Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #8 from Myka Kennedy Stephens --- I share your concern, Jonathan. I recently needed to use the drop-down in the staff client to perform a search across two shelving locations because the limit by shelving location option is currently compiling the query statement with AND instead of OR (see bug #24109). Even though searches using ccl will continue to work without the drop-down, as Nick pointed out, having the drop-down as an option makes it easier to build these queries, which I think most library staff appreciate. What would it take to make this search index work in Zebra? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:23:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:23:01 +0000 Subject: [Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:23:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:23:04 +0000 Subject: [Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94975|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 96339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96339&action=edit Bug 23913: Use a single menu to sort lists in the OPAC This patch modifies the sorting form on the OPAC list contents view so that the two menus (sort field and direction) are combined into one. This makes it consistent with the sort menu on the search results page. To test, apply the patch and view a list with multiple titles on it. Test the "Sort by" menu, trying all the various options. Confirm that the pre-selected item in the sorting menu is correct after each re-sort. Edit the list to change the default sorting and verify that the "Sort by" menu reflects your selection. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:23:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:23:42 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:23:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:23:44 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96295|0 |1 is obsolete| | --- Comment #3 from Liz Rea --- Created attachment 96340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96340&action=edit Bug 24243: Do not explode if invalid metadata when searching catalogue If the bibliographic record metadata cannot be decoded, the get_coins call should catch the exception raised by Koha::Biblio::Metadata->record to not explode Error is: "Invalid data, cannot decode objec" Test plan: 0/ Do not apply the patch 1/ Search for record at the OPAC 2/ Note one of the biblionumber from the first page result 3/ Set to empty string the biblio_metadata to make the error appears: update biblio_metadata set metadata="" where biblionumber=42; 4/ Try the same search => You get an internal server error 5/ Apply the patch, restart plack and try again => It now works, ie. it does not explode Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:24:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:24:35 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #4 from Nick Clemens --- Shouldn't we log the error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:27:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:27:06 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Jonathan Druart --- (In reply to Nick Clemens from comment #22) > (In reply to Jonathan Druart from comment #19) > > + [% NEXT IF display_name.length == 5 %] > > > > Hum?? > Ah, the indents in the file were adding 5 spaces - I didn't know where they > had come from but found that solution. Improved now. + [% NEXT IF display_name.length == 5 %] Still there? Also there are debug statements in the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:28:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:28:44 +0000 Subject: [Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |joonas.kylmala at helsinki.fi --- Comment #23 from Joonas Kylmälä --- The description "By default, only current checkout are returned, when this is true, all checkouts (current and checked in) are returned as result." is not true, only checked in checkouts are returned. The description should be the same as for /checkouts endpoint: "By default, current checkouts are returned, when this is true then checked in checkouts are returned as result." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:32:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:32:21 +0000 Subject: [Koha-bugs] [Bug 24248] New: The maximum allowable reduction of an accountline should use the combined refunded value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24248 Bug ID: 24248 Summary: The maximum allowable reduction of an accountline should use the combined refunded value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Bug 23442 introduces a method of applying a discount/refund to an accountline debt and it enforces that a refund may not exceed the original amount owed on the accountline. However, there's nothing to prevent multiple refunds/discounts being applied to the same line and as such the combined total for all refund against that line should be used to prevent refunding more than the original owed amount instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:32:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:32:31 +0000 Subject: [Koha-bugs] [Bug 24248] The maximum allowable reduction of an accountline should use the combined refunded value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:32:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:32:31 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24248 [Bug 24248] The maximum allowable reduction of an accountline should use the combined refunded value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:35:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:35:47 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74828|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:36:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:36:17 +0000 Subject: [Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 --- Comment #24 from Tomás Cohen Arazi --- (In reply to Joonas Kylmälä from comment #23) > The description > > "By default, only current checkout are returned, when this is true, all > checkouts (current and checked in) are returned as result." > > is not true, only checked in checkouts are returned. The description should > be the same as for /checkouts endpoint: > > "By default, current checkouts are returned, when this is true then checked > in checkouts are returned as result." We should really merge the f* tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:41:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:41:11 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:41:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:41:15 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74828|0 |1 is obsolete| | Attachment #94891|0 |1 is obsolete| | Attachment #94892|0 |1 is obsolete| | --- Comment #35 from Nick Clemens --- Created attachment 96341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96341&action=edit Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Kelly Signed-off-by: Maxime Dufresne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:41:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:41:18 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #36 from Nick Clemens --- Created attachment 96342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96342&action=edit Bug 17374: (follow-up) Remove spaces from include file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:41:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:41:21 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #37 from Nick Clemens --- Created attachment 96343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96343&action=edit Bug 17374: (follow-up) Unit tests and remove warns Signed-off-by: Maxime Dufresne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:43:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:43:07 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #49 from Jonathan Druart --- This is working great! 2 smalls things: - required fields (the subfield's lib) are red https://snipboard.io/CMuDYp.jpg Is that expected? - Do we really need the sort icon for each subfield? And, not blocker for this bug report (regarding its age), but we could remove the "sortable" option for fields that cannot be duplicated for instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:43:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:43:34 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #38 from Nick Clemens --- (In reply to Jonathan Druart from comment #34) > (In reply to Nick Clemens from comment #22) > > (In reply to Jonathan Druart from comment #19) > > > + [% NEXT IF display_name.length == 5 %] > > > > > > Hum?? > > Ah, the indents in the file were adding 5 spaces - I didn't know where they > > had come from but found that solution. Improved now. > > > + [% NEXT IF display_name.length == 5 %] > > Still there? > > Also there are debug statements in the last patch. Looks like something happened in a rebase, patches restored and cleaned up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:47:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:47:18 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #50 from Jonathan Druart --- (In reply to Jonathan Druart from comment #49) > This is working great! > > 2 smalls things: > - required fields (the subfield's lib) are red > https://snipboard.io/CMuDYp.jpg > Is that expected? Sorry, that is coming from bug 24090. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:50:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:50:18 +0000 Subject: [Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 --- Comment #25 from Joonas Kylmälä --- Also, would we be able to do this without having to duplicate the endpoint definition by using the existing definition for /checkouts endpoint by replacing > "$ref": "paths/checkouts.json#/~1patrons~1{patron_id}~1checkouts" with > $ref": "paths/checkouts.json#/~1checkouts~1{patron_id} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:51:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:51:56 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #5 from Jonathan Druart --- (In reply to Nick Clemens from comment #4) > Shouldn't we log the error? There is a check in search_for_data_inconsistencies.pl, so I'd say it's not needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:58:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:58:18 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 15:58:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 14:58:31 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94837|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart --- Created attachment 96344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96344&action=edit Bug 7882: Add ability to move and reorder fields in MARC editor Use jQueryUI sortable to make fields and subfields moveable in the MARC editor for both records and authorities. This patch convert items from div's to ul's and consequently alter css and js to match. It also replace the up arrow with a more adapted icon (from font awesome). Primary authorship by Elliott Davis. To Test: 1. Add or edit a record in cataloguing module. 2. You should be able to move the fields and subfields around. - You can click on any part of the element to drag it, the move icon to the left of the item is a good place to do it. => You can only change the order of fields of the same tag. 3. Make sure all of the javascript driven fonctionnality still work : - Duplicate fields/subfields - Remove fields/subfields - Using the tag editor for control fields or to link authorities - etc 4. Reorder some fields/subfields and save the record. 5. Edit the record again. 6. The order in the editor should match the changes which were saved. - Empty subfields should appear after the ones with content. 7. Repeat steps 1-6 with the authority editor. Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:00:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:00:06 +0000 Subject: [Koha-bugs] [Bug 2124] Change sequence of MARC fields when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED --- Comment #5 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 7882 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:00:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:00:06 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #52 from Jonathan Druart --- *** Bug 2124 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:06:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:06:27 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #36 from Jonathan Druart --- Created attachment 96345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96345&action=edit Bug 23233: Fix UsageStats.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:25:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:25:33 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94463|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:26:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:26:17 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94464|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:26:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:26:38 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:26:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:26:51 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94466|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:27:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:27:08 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94467|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:27:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:27:29 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94468|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:29:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:29:00 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88394|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:30:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:30:00 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88394|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:31:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:31:15 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88395|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:31:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:31:24 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88396|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:31:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:31:37 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88397|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:31:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:31:46 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88398|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:31:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:31:55 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88399|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:32:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:32:11 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88400|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:35:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:35:19 +0000 Subject: [Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 --- Comment #26 from Tomás Cohen Arazi --- (In reply to Joonas Kylmälä from comment #25) > Also, would we be able to do this without having to duplicate the endpoint > definition by using the existing definition for /checkouts endpoint by > replacing > > > "$ref": "paths/checkouts.json#/~1patrons~1{patron_id}~1checkouts" > > with > > > $ref": "paths/checkouts.json#/~1checkouts~1{patron_id} As-is, the patch looks correct and what Martin and I have been saying. I haven't tried or run the tests to verify it is functional, but it looks exactly as what we would've expected when saying 'alias'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:36:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:36:45 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #31 from Tomás Cohen Arazi --- Andrew, I think we will need to adapt this one to the new idea of putting the mapping on the Koha::Object level. We can chat about it whenever you want/need to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 16:58:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 15:58:52 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #6 from Liz Rea --- >From a troubleshooting point of view, that would be nice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:05:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:05:17 +0000 Subject: [Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream, and fudge flavors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com --- Comment #6 from Jessie Zairo --- Chocolate and Peanut Butter Chip Cookies 3/4 cup HERSHEY'S Cocoa REESE'S Peanut Butter Chips (10-oz. pkg.) 2 1/2 sticks butter, softened 2 eggs 2 cups sugar 2 teaspoons vanilla extract 2 cups all-purpose flour 1 teaspoon baking soda 1/2 teaspoon salt Directions Heat oven to 350°F. Stir together flour, cocoa, baking soda, and salt; set aside. Beat butter and sugar in large bowl with mixer until fluffy. Add eggs and vanilla; beat well. Gradually add flour mixture, beating well. Stir in peanut butter chips. Use a scooper and roll dough in hands to form a ball and place on cookie sheet. Bake 8 to 9 minutes. Cool and move from cookie sheet to wire rack. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:08:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:08:37 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94503|0 |1 is obsolete| | Attachment #96232|0 |1 is obsolete| | --- Comment #6 from Agustín Moyano --- Created attachment 96346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96346&action=edit Bug 23673: change db structure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:08:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:08:40 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #7 from Agustín Moyano --- Created attachment 96347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96347&action=edit Bug 23673: Add "Time status changed" column to patron's notices This patch adds "Time status changed" column to patron's notices tab. It also adds logic to C4::Letters to update time_status_changed column when status is changed, and leaves time_queued with message creation time. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Time status changed" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" and no "time status changed" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "time status changed" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and time status changed updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:09:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:09:01 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:11:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:11:53 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #8 from Agustín Moyano --- Fixed atomic update file. I missed in line 6 when it checked if column exists it said 'time_sent' instead of 'time_status_changed' as it should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:24:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:24:38 +0000 Subject: [Koha-bugs] [Bug 24234] Spacing of availability note in intranet search results unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Andrew Fuerste-Henry --- Had to install yarn to get it to work on a sandbox, but otherwise looks good! Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:37:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:37:32 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | --- Comment #8 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:41:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:41:05 +0000 Subject: [Koha-bugs] [Bug 24249] New: OPAC lists page should require login for login-dependent operations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Bug ID: 24249 Summary: OPAC lists page should require login for login-dependent operations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Currently the OPAC lists page doesn't require a login to access pages like the list-creation form. It would be a more seamless process for users if they were prompted to log in before reaching those forms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:41:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:41:50 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | --- Comment #6 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:45:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:45:07 +0000 Subject: [Koha-bugs] [Bug 24234] Spacing of availability note in intranet search results unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96290|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 96348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96348&action=edit Bug 24234: fix css in staff search results Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:50:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:50:37 +0000 Subject: [Koha-bugs] [Bug 24234] Spacing of availability note in intranet search results unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96348|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 96349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96349&action=edit Bug 24234: fix css in staff search results Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:51:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:51:51 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:51:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:51:54 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 --- Comment #1 from Owen Leonard --- Created attachment 96350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96350&action=edit Bug 24249: OPAC lists page should require login for login-dependent operations This patch modifies opac-shelves.pl so that login is required if the requested operation is anything but "view" and "list." To test, apply the patch and go to the lists page in the OPAC while not logged in. - Click the "Log in to create a new list" link. - Log in. - You should be taken to the "Create a new list" form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:56:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:56:56 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247 [Bug 24247] Button fixes for OPAC lists pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:56:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:56:56 +0000 Subject: [Koha-bugs] [Bug 24247] Button fixes for OPAC lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 [Bug 24249] OPAC lists page should require login for login-dependent operations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 18:58:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 17:58:13 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #7 from Jonathan Druart --- There will be a warning on the detail page of the problematic record anyway (from bug 23846) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 19:00:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 18:00:14 +0000 Subject: [Koha-bugs] [Bug 24226] Advanced editor - drops subfields/punctuation when manually linking authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24226 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 19:24:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 18:24:53 +0000 Subject: [Koha-bugs] [Bug 24247] Button fixes for OPAC lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 19:24:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 18:24:56 +0000 Subject: [Koha-bugs] [Bug 24247] Button fixes for OPAC lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247 --- Comment #1 from Owen Leonard --- Created attachment 96351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96351&action=edit Bug 24247: Button fixes for OPAC lists pages This patch makes minor markup changes to the OPAC lists page so that link and form controls are styled consistently. To test you should have virtualshelves and OpacAllowSharingPrivateLists enabled. - Apply the patch and log in to the OPAC. - Create a new private list. - When you view the list of your private lists, the "Share" link should have a Font Awesome icon. - View the contents of your list. The "Share" link in the list toolbar should have the same icon. The "New list" link should have a + icon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 19:31:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 18:31:51 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 20:02:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 19:02:37 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #53 from Owen Leonard --- When I test this I am able to drag a tag but when I drop it it returns to its original position. Dragging subfields works to re-order them, but after I save the record the order is back to where it was before. Tested in Firefox and Chrome on Windows 10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 20:13:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 19:13:36 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #54 from Owen Leonard --- Created attachment 96352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96352&action=edit Bug 7882: (follow-up) Update sorting interaction This follow-up modifies the CSS for the sortable fields so that a different icon is used. Elsewhere in Koha (stock rotation stage sorting) we use the "bars" icon to indicate a sortable element. I think it would be good to continue to use this. The cursor is now styled as a "Move" cursor. The configuration of the sortable function in the script has been updated in two ways: 1. The movement of the element is constrained along the y-axis, and 2. The movement of the element is contstrained to the container within which it can be moved (for the tag, the tab, and for the subfield, the tag). To test, apply the patch and edit a MARC record in the basic cataloging editor. Confirm that the new icon is used, and that the "Move" cursor shows when you hover over the icon. Confirm that a tag can be dragged up and down within the constraints of the visible section. A subfield should be only movable within its parent tag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 20:14:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 19:14:48 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #55 from Owen Leonard --- I've added a minor follow-up even though this isn't working correctly for me (comment 53). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 20:21:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 19:21:19 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #11 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #9) > Hola Bernado, > I like the idea, but not XML, neither the MySQL only limitation. Salut Jonathan, I don't like XML either, nor the MySQL only. Just remember that I was thinking in translations, and xml support it's included right now. But yaml can be handled. > Why not write our own stuff, yml-based? No problem, I'll write a POC patch, but have a question: Do you think the sequence a) Read YAML > Write $tmp/out.sql > DBIx_::RunSQL->run_sql_file($tmp/out.sql) is a valid approach, or b) Read YAML > Insert into DB somehow it's better? I suppose b) is slower. (In reply to Martin Renvoize from comment #10) > This looks good. My only slight concern is whether it ties us more strictly > to MySQL or in particular a particular MySQL version. (I'm not sure how > widely supported the MySQL XML dump format is.. do they change the format > when new feature are introduced for example and does MariaDB support it > natively too). > > Perhaps we could use the well supported and maintained SQL::Translator to > produce something similar in XML, YAML or JSON as our middle format ? Hi Martin, SQL::Translator documentation states: "Presently only the definition parts of SQL are handled (CREATE, ALTER), not the manipulation of data (INSERT, UPDATE, DELETE)." And this files normally do INSERTs, don't know if it's useful in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 20:37:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 19:37:16 +0000 Subject: [Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold at dgiinc.com --- Comment #2 from Cori Lynn Arnold --- +1 this feature. Having a lot of issues on a time-sensitive cataloging job where multiple catalogers are trying to update the same record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 20:53:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 19:53:52 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 20:53:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 19:53:55 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96306|0 |1 is obsolete| | --- Comment #21 from Bernardo Gonzalez Kriegel --- Created attachment 96353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96353&action=edit Bug 24137: Same fixes for *_local.sql files Signed-off-by: Bernardo Gonzalez Kriegel tested using $ export L=uk-UA (and ru-RU) $ for o in mandatory optional; do for a in installer/data/mysql/$L/marcflavour/marc21/$o/*.sql; do mysql kohatest < $a; done; done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:02:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:02:54 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy at bywatersolutions.com --- Comment #27 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:08:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:08:00 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:08:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:08:02 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #15 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:08:04 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:08:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:08:06 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:08:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:08:08 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:08:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:08:10 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:08:12 +0000 Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:08:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:08:14 +0000 Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:08:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:08:16 +0000 Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:08:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:08:17 +0000 Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:26:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:26:32 +0000 Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:26:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:26:45 +0000 Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:28:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:28:11 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96151|0 |1 is obsolete| | --- Comment #5 from Andrew Nugged --- Created attachment 96354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96354&action=edit Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all unavailable' When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest" called many times with hundred of items and "on shelf holds" parameter set to "If all unavailable" for these items + patron, it goes slow. It happens because in subloop there is checking if all items available so it is O(n^2) and it re-checks each time the same info for each item with repeating DB/data requests. Fix: The inner loop 1:1 picked out from another loop and put before that items processing loop, 'items_any_available' variable precalculated, this variable passed to IsAvailableForItemLevelRequest to be used inside as the precalculated result. On tests it gave a drastic improvement in execution time. Also "$can_item_be_reserved->{status} eq 'OK'" moved in "&&" before IsAvailableForItemLevelRequest call to cut away if it false before calling to subroutine. How to reproduce: 1) on freshly installed kohadevbox create/import one book, remember that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up a single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", that rule should match above book items/library/patron, check that rule to have a non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create a direct link by yourself, for example, in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time on old code, densely increasing for every hundred items added. In the case of this solution, it's fast, and time increases a little only, linear. I tested on my computer in VirtualBox for page generation times, did 3-5 runs for same case to check if results are stable, and got such values: (old code): 100 items: 38 seconds 200 items: 2.5 minutes 300 items: 5.4 minutes (version with fix): 100 items: 3.7 seconds 200 items: 6.4 seconds 300 items: 8.7 seconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:32:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:32:57 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #12 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:33:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:33:06 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:41:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:41:27 +0000 Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #4 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:45:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:45:22 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:45:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:45:34 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 22:50:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 21:50:31 +0000 Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 23:08:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 22:08:41 +0000 Subject: [Koha-bugs] [Bug 23427] Better sorting of previous checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 23:08:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 22:08:51 +0000 Subject: [Koha-bugs] [Bug 23427] Better sorting of previous checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 16 23:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Dec 2019 22:12:41 +0000 Subject: [Koha-bugs] [Bug 23806] FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23806 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #5 from Lucas Gass --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 02:16:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 01:16:01 +0000 Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley at catalyst.net.n | |z Version(s)|20.05.00, 19.11.01 |20.05.00, 19.11.01, released in| |18.11.12 --- Comment #6 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 02:16:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 01:16:39 +0000 Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley at catalyst.net.n | |z Version(s)|20.05.00, 19.11.01 |20.05.00, 19.11.01, released in| |18.11.12 --- Comment #7 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 02:17:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 01:17:12 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | --- Comment #10 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 02:17:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 01:17:45 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley at catalyst.net.n | |z --- Comment #11 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 02:31:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 01:31:32 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 --- Comment #18 from Nick Clemens --- Created attachment 96355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96355&action=edit Bug 14419: [19.05.x] (squashed) Expanding facets (Show more) performs a new search This patch removes the constraint of only passing 5 facets to the template unless the list is expanded, in fact, it removes the 'expanded' attribute from Search.pm Now that all facets are passed to page it adds a 'show more' link at the bottom of lists and allows user to expand or collapse any facet set without reloading page. Updated tests included. To test: 1 - Perform an OPAC search that returns more than 5 of any given facet type 2 - Click the "Show more" link on the facets and see that the search is reloaded 3 - Apply patch 4 - Repeat search 5 - Note that you can click "Show more" without reloading page 6 - Test that page load is not greatly affected 7 - Ensure that all facet links function normally 8 - Ensure that facets are the same a prior to patch 9 - Repeat for staff client 10 - Prove t/Search.t NOTE: This patch makes it much easier to see that there is an existing issue with marking the "active" facet. Ending punctuation seems to confuse the matcher. Signed-off-by: Michal Denar Signed-off-by: Josef Moravec Bug 14419: (QA follow-up) Restore the link styling Test plan: Look at Show more/less links in facets, in opac and staff client --> without this patch they are pure text, no styling, no hand cursor --> with this patch it is link, but continues to work as before Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 02:46:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 01:46:35 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | CC| |hayleymapley at catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 03:08:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 02:08:15 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96038|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 96356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96356&action=edit Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Signed-off-by: Jessica Zairo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 03:08:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 02:08:18 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 --- Comment #7 from Nick Clemens --- Created attachment 96357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96357&action=edit Bug 23261: (follow-up) Use logged_in_user and move test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 03:26:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 02:26:52 +0000 Subject: [Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | CC| |hayleymapley at catalyst.net.n | |z --- Comment #11 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 03:29:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 02:29:12 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Sally from comment #7) > I've just seen: > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 - do those > changes resolve this bug? That one only deals with priority. Question: what permissions would you require for changing the pickup location? Don't think in terms of the current UI, maybe we can add modify_holds_pickup_location for example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 03:30:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 02:30:47 +0000 Subject: [Koha-bugs] [Bug 24250] New: SIP2 returns debarred comment twice in patron screen message AF field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250 Bug ID: 24250 Summary: SIP2 returns debarred comment twice in patron screen message AF field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To recreate: 1 - Setup SIP in your testing environment https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2 - Set a patron to have a restriction 3 - Send a patron status request or patron information command via the SIP cli emulator (see link above) 4 - Note the comment on the restriction is sent twice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 04:14:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 03:14:19 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #6 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 04:46:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 03:46:28 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley at catalyst.net.n | |z --- Comment #6 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 05:31:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 04:31:38 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | CC| |hayleymapley at catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Hayley Mapley --- Backported 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 06:22:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 05:22:56 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | --- Comment #10 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 07:35:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 06:35:11 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #12 from David Cook --- (In reply to Bernardo Gonzalez Kriegel from comment #11) > Do you think the sequence > a) Read YAML > Write $tmp/out.sql > > DBIx_::RunSQL->run_sql_file($tmp/out.sql) > is a valid approach, or > b) Read YAML > Insert into DB somehow > it's better? > I suppose b) is slower. > Since this is installer data, I don't think it necessarily has to be fast? I figure the most important part is to make it easy to read and update? Actually, I don't know if we necessarily need to change C4/Installer.pm? We could use YAML as a declarative format for the database data, and then the Release Manager/Release Maintainer could run a tool to compile it into a SQL script. If we only do that compilation at release time, it would also be easier to audit and find bugs in the final result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 07:37:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 06:37:42 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #13 from David Cook --- (In reply to David Cook from comment #12) > We could use YAML as a declarative format for the database data, and then > the Release Manager/Release Maintainer could run a tool to compile it into a > SQL script. > This could also be used to add support for different databases, especially in terms of optimizing bulk data loading. https://dev.mysql.com/doc/refman/5.6/en/optimizing-innodb-bulk-data-loading.html https://www.postgresql.org/docs/9.1/ecpg-sql-set-autocommit.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 07:42:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 06:42:06 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #14 from David Cook --- While we're on this topic, perhaps it's worthwhile talking about something like this: https://metacpan.org/pod/DBIx::Class::Schema::Versioned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 07:44:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 06:44:54 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #12 from Katrin Fischer --- Thx Lucas and Hayley :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 07:46:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 06:46:24 +0000 Subject: [Koha-bugs] [Bug 23839] Several dead links on community web site In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23839 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 08:01:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 07:01:27 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #15 from Katrin Fischer --- I am not sure if XML is really easier to read here, but enabling translation would be great. :) I'd vote against 'compiling at release time'. If we still need to create SQL files and store them, we should do so continously like we do for CSS etc. as this needs to be testable with current data all the time. Please keep in mind when changing the web installer, that it's currently possible to add additional SQL files to the installer that will be picked up - it would be nice to keep that feature. There is also the option to have a syspref.sql for some additional settings (see de-DE installer) that not all languages have made use of. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 09:39:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 08:39:57 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Joonas Kylmälä --- Thanks! Couple issues: 1) you copy & paste the code inside the loop instead of abstracting it to a subroutine. Please fix this so the code is in a subroutine and performance problems like this can be prevented by seeing the problems immediately. This is important also for testability. 2) There should be one logical change per commit, leave "$can_item_be_reserved eq 'OK'" change in the && statement to another commit, and also leave "my $on_shelf_holds = Koha:: [...]" to another commit, plus any other changes I missed not related to fixing the O(n^2) issue here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 09:57:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 08:57:24 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #16 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #11) > (In reply to Jonathan Druart from comment #9) > > Hola Bernado, > > I like the idea, but not XML, neither the MySQL only limitation. > > Salut Jonathan, > I don't like XML either, nor the MySQL only. > Just remember that I was thinking in translations, and xml support it's > included right now. > But yaml can be handled. > > > Why not write our own stuff, yml-based? > > No problem, I'll write a POC patch, but have a question: > > Do you think the sequence > a) Read YAML > Write $tmp/out.sql > > DBIx_::RunSQL->run_sql_file($tmp/out.sql) > is a valid approach, or > b) Read YAML > Insert into DB somehow > it's better? > I suppose b) is slower. I would: - Retrieve and parse the whole YAML file - Generate the SQL queries (like 1 per table) - Execute the INSERT statements (using DBIx::RunSQL->run_sql) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 09:59:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 08:59:51 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #17 from Martin Renvoize --- Sorry Bernardo, I didn't mean to knock this one off the rails so much :(. Hmm, it's a shame SQL::Translator only handles definition... I must have misremembered... it's SQL::Abstract ( the the various DBIx::Class extensions) that does the rest. SQL::Abstract is Perl script however so may not be especially helpful here? As for DBIx::Class::Schema::Versioned, I'm really not sure I understand what that would win for us (especially as the general recommendation in DBIx::Class land now is not to use it, but rather use DeploymentHandler instead). Koha's installer is actually pretty powerful as it is in my opinion and this is just one minor area we can improve.. please highlight some problems you feel such a move would resolve? Going back to the actual problem this patchset is trying to resolve.. can you remind me what it is about the SQL format files in the first place means we can't easily support translating them without moving to some intermediary file format? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:03:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:03:02 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #18 from Katrin Fischer --- > Going back to the actual problem this patchset is trying to resolve.. can > you remind me what it is about the SQL format files in the first place means > we can't easily support translating them without moving to some intermediary > file format? I think the problem is that you can't 'mark' what needs translation. You only want to translate a small bit of the SQL files, the descriptions while preventing people to translate values that should not be changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:07:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:07:25 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #19 from Jonathan Druart --- (In reply to Martin Renvoize from comment #17) > Going back to the actual problem this patchset is trying to resolve.. can > you remind me what it is about the SQL format files in the first place means > we can't easily support translating them without moving to some intermediary > file format? .sql files are not following the usual translation workflow. There is 1 file per language (in the term of language in installer/data/mysql/, so not so much compared to the number of languages we really support (POs). If you want to translate a sql file, you need to open a bug report, patch it, wait for someone to SO/QA/push. Also it's painful to support (dev POV), as if you want to add an AV, you have to edit X .sql files, test them, (rebase), etc. With only 1 sql file, at the root of installer dir (installer/data/mysq) the translation will be done using the usual workflow (after a change to our translator tool as we still do not support YAML file, but we do support .pref which are YAML, so should not be too hard) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:09:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:09:13 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #37 from Martin Renvoize --- Created attachment 96358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96358&action=edit Bug 23233: (RM follow-up) Rename syspref in test The AllowItemsOnHoldCheckout system preference was renamed to AllowItemsOnHoldCheckoutSIP to clarify it's use, but one case was missed in the test suit. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:09:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:09:31 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #38 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:12:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:12:38 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #39 from Martin Renvoize --- Ooops. Totally missed that you had also provided that exact same followup Jonathan :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:16:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:16:57 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #20 from Martin Renvoize --- Sorry.. I don't think my question was clear.. I'm totally onboard with wanting to replace the workflow we have and having one update file which then followed the standard translations workflow we have elsewhere.. What I wasn't fully understanding is why we needed to move from a lots of SQL files to one YAML/XML/Whatever file instead of a single SQL file which gets translated via the tools. Sounds like SQL is just too hard to parse as is for the existing translation tools.. that's the answer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:20:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:20:17 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #56 from Jonathan Druart --- (In reply to Owen Leonard from comment #53) > When I test this I am able to drag a tag but when I drop it it returns to > its original position. Dragging subfields works to re-order them, but after > I save the record the order is back to where it was before. Tested in > Firefox and Chrome on Windows 10. Hi Owen, The important bit is " => You can only change the order of fields of the same tag." That is always why I suggested to remove the sortable thing for those fields. For instance unique fields cannot be moved. > Dragging subfields works to re-order them, but after I save the record the order is back to where it was befor I do not see this issue. I can sort subfields, save, edit again => the subfields order is kept. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:23:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:23:51 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:25:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:25:55 +0000 Subject: [Koha-bugs] [Bug 24251] New: Patron modification logs should be ordered most recent first Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24251 Bug ID: 24251 Summary: Patron modification logs should be ordered most recent first Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The ordering of the patron modification logs seems wrong, surely one is most interested in the most recent modifications and working backwards through the logs? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:27:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:27:46 +0000 Subject: [Koha-bugs] [Bug 24189] Can't login to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24189 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal --- Comment #5 from Jonathan Druart --- (In reply to ciarebaha from comment #4) > (In reply to Katrin Fischer from comment #2) > > Did you set up your SIP user with circulate permissions in Koha and the conf > > file correctly? > > (https://koha-community.org/manual/19.11/en/html/apis_protocols.html#sip2) > > Yes, since this SIP already running since September 2019 & working fine > before this, all the login id,password,permission already set up in koha > patron & SIPconfig.xml. So my guess is that the SIP server is not running, try to start it with: % koha-sip --start $INSTANCE With $INSTANCE the name of you Koha installation. Lowering severity. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:38:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:38:16 +0000 Subject: [Koha-bugs] [Bug 24188] Sorting AZ does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24188 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- All looks correct to me, as Katrin said previously, "the" is a stopword and is ignored on sorting. "Business" is followed by "The call", which is start with 'c', not 't'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:40:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:40:47 +0000 Subject: [Koha-bugs] [Bug 24188] Sorting AZ does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24188 --- Comment #8 from Katrin Fischer --- I didn't but Jonathan is correct. Check the indicators of 245 - this is an intended behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:41:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:41:01 +0000 Subject: [Koha-bugs] [Bug 24188] Sorting AZ does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:45:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:45:30 +0000 Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:46:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:46:29 +0000 Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching - Elasticsearch |Searching QA Contact| |testopia at bugs.koha-communit | |y.org --- Comment #1 from Jonathan Druart --- This impacts both Zebra and Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:48:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:48:33 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Fines and fees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:49:51 +0000 Subject: [Koha-bugs] [Bug 24252] New: Add credit_offsets and debit_offsets relationship to Koha::Account::Line Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Bug ID: 24252 Summary: Add credit_offsets and debit_offsets relationship to Koha::Account::Line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Add the Koha::Objects expansion of the credit and debit offset relationships to the Koha::Account::Line class. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:49:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:49:55 +0000 Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:49:58 +0000 Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 --- Comment #2 from Jonathan Druart --- Created attachment 96359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96359&action=edit Bug 24219: Preserve sort order when returning to result list There is a mismatch between sort_cgi, sort and sort_by variables. * sort_cgi I did not find relevant occurrences of sort_cgi in the git log of both search.pl and results.tt. So it seems that it never worked correctly. * sort It is the JS variable use in browser.js * sort_by is the search.pl parameter to set the sort_by option Test plan: 1. Perform a search in the staff client 2. Change the sort order to something different (try Author A-Z) 3. Click on a result to view the record 4. Click on "Results" button on left side to return to result list => Without this patch the result list is sorted by relevancy => With this patch applied the Author A-Z is kept -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:50:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:50:30 +0000 Subject: [Koha-bugs] [Bug 24252] Add credit_offsets and debit_offsets relationship to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:50:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:50:30 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 [Bug 24252] Add credit_offsets and debit_offsets relationship to Koha::Account::Line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:54:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:54:29 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #10 from Sally --- (In reply to Tomás Cohen Arazi from comment #9) > (In reply to Sally from comment #7) > > I've just seen: > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 - do those > > changes resolve this bug? > > That one only deals with priority. Question: what permissions would you > require for changing the pickup location? Don't think in terms of the > current UI, maybe we can add modify_holds_pickup_location for example. Ah, thanks Tomas - yes, a new modify_holds_pickup_location would work for us. The key part for us is separating the permissions between modifying the pickup location and modifying the hold priority, so that suggestion works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:59:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:59:53 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15496 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|minor |normal Version|19.05 |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 [Bug 15496] Delete bibliographic record after moving last item to another record(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 10:59:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 09:59:53 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24232 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 [Bug 24232] Deleting a bib record after attaching the last item to another bib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 11:05:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 10:05:58 +0000 Subject: [Koha-bugs] [Bug 24233] Library branches editor doesn't allow email addresses with a name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24233 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Instead should not we have the ability to add the library name when the notices are sent? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 11:33:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 10:33:03 +0000 Subject: [Koha-bugs] [Bug 24250] SIP2 returns debarred comment twice in patron screen message AF field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 11:33:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 10:33:05 +0000 Subject: [Koha-bugs] [Bug 24250] SIP2 returns debarred comment twice in patron screen message AF field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250 --- Comment #1 from Jonathan Druart --- Created attachment 96360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96360&action=edit Bug 24250: Do not duplicate debarred comment in patron screen message AF field Caused by commit bddfed75913a2302c19c00b00a6fe86538af6f9f Bug 19933: Remove patronflags - tricky ones Test plan: 1 - Setup SIP in your testing environment https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2 - Set a patron to have a restriction 3 - Send a patron status request or patron information command via the SIP cli emulator (see link above) 4 - Note the comment on the restriction is sent only once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 11:33:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 10:33:12 +0000 Subject: [Koha-bugs] [Bug 24250] SIP2 returns debarred comment twice in patron screen message AF field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 11:39:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 10:39:40 +0000 Subject: [Koha-bugs] [Bug 24252] Add credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add credit_offsets and |Add credit_offsets and |debit_offsets relationship |debit_offsets relationships |to Koha::Account::Line |to Koha::Account::Line -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 11:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 10:42:42 +0000 Subject: [Koha-bugs] [Bug 24216] kohastructure.sql uses BOOLEANs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24216 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 21294 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 11:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 10:42:42 +0000 Subject: [Koha-bugs] [Bug 21294] Indentify boolean fields on the DB structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21294 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at koha-suomi.fi --- Comment #2 from Jonathan Druart --- *** Bug 24216 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 11:49:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 10:49:03 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #32 from Andrew Isherwood --- Hi Tomás I'm not sure what you mean when you say "putting the mapping on the Koha::Object level", could you please elaborate? Do you mean add a "to_api" method into the Koha::ActionLog object rather than having it in Koha/REST/V1/Patrons/Renewals.pm Thanks, Andrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 11:50:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 10:50:43 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Templates Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 12:11:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 11:11:41 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Summary|Cannot do on-site |Cannot do automatic renewal |checkouts/automatic renewal |with |with Itemfallbacksearch |itemBarcodeFallbackSearch --- Comment #1 from Jonathan Druart --- on-site checkout works for me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 12:13:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 11:13:24 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 12:13:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 11:13:28 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 --- Comment #2 from Jonathan Druart --- Created attachment 96361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96361&action=edit Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on OnSiteCheckouts and Itemfallbacksearch - Open a patron account - Check the checkboxes for automatic-renewal and on-site checkout - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 12:14:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 11:14:10 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96361|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 96362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96362&action=edit Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on itemBarcodeFallbackSearch - Open a patron account - Check the checkboxes for automatic-renewal - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 12:31:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 11:31:06 +0000 Subject: [Koha-bugs] [Bug 24125] Deleting an authority clears the record heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24125 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- We are restricting the deletion on the detail of the authority record, so it would make sense to not allow the deletion using the batch tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 12:35:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 11:35:44 +0000 Subject: [Koha-bugs] [Bug 24252] Add credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 --- Comment #1 from Martin Renvoize --- Created attachment 96363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96363&action=edit Bug 24252: Add relations to Koha::Account::Line This patch adds two new relationships to the Koha::Account::Line object. * credit_offsets - returns all credit type Koha::Account::Offsets related to this Koha::Account::Line. * debit_offsets - returns all debit type Koha::Account::Offsets related to this Koha::Account::Line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 12:36:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 11:36:00 +0000 Subject: [Koha-bugs] [Bug 24252] Add credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 12:36:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 11:36:04 +0000 Subject: [Koha-bugs] [Bug 24252] Add credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 12:36:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 11:36:16 +0000 Subject: [Koha-bugs] [Bug 24252] Add credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 12:45:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 11:45:50 +0000 Subject: [Koha-bugs] [Bug 24253] New: process_message_queue.pl fail if not to address is defined Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24253 Bug ID: 24253 Summary: process_message_queue.pl fail if not to address is defined Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org Koha 18.11.x the cronjob process_message_queue.pl fails if any notice has not to_email_address. Test plan: Set up a user without email address configure notes for item check in and item checkout (or any other notice) you won't receive any email because there is no to_address possible solution a default address if no email defined at user account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 12:47:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 11:47:12 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #1 from Andrew Isherwood --- Created attachment 96364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96364&action=edit Bug 24190 - Add acquisition logging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 13:21:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 12:21:01 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 --- Comment #4 from Katrin Fischer --- Might be a version thing - thx Joubu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 13:21:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 12:21:42 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 13:21:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 12:21:46 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96280|0 |1 is obsolete| | --- Comment #22 from Joonas Kylmälä --- Created attachment 96365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96365&action=edit Bug 24137: Fix biblio frameworks install for ru-Ru and uk-UA (mandatory) Replace mandatory='' with mandatory=0 perl -p -i -e "s/^\s\('', '(\d+)', '', / ('', '\1', 0, /" installer/data/mysql/ru-RU/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql installer/data/mysql/uk-UA/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 13:21:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 12:21:49 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96281|0 |1 is obsolete| | --- Comment #23 from Joonas Kylmälä --- Created attachment 96366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96366&action=edit Bug 24137: Fix biblio frameworks install for ru-Ru and uk-UA (repeatable) Replace repeatable='' with repeatable=0 perl -p -i -e "s/^\s\('', '(\d+)', (\d), '', / ('', '\1', \2, 0, /" installer/data/mysql/ru-RU/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql installer/data/mysql/uk-UA/marcflavour/marc21/mandatory/marc21_bibliographic_DEFAULT_general.sql Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 13:21:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 12:21:53 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96282|0 |1 is obsolete| | --- Comment #24 from Joonas Kylmälä --- Created attachment 96367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96367&action=edit Bug 24137: Manual replacement for hidden Arbitrary set to -6 when was NULL Signed-off-by: Bernardo Gonzalez Kriegel Fixed 991 in uk-UA marc21_bibliographic_DEFAULT_local.sql All files load without errors, mandatory and optional Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 13:21:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 12:21:57 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96353|0 |1 is obsolete| | --- Comment #25 from Joonas Kylmälä --- Created attachment 96368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96368&action=edit Bug 24137: Same fixes for *_local.sql files Signed-off-by: Bernardo Gonzalez Kriegel tested using $ export L=uk-UA (and ru-RU) $ for o in mandatory optional; do for a in installer/data/mysql/$L/marcflavour/marc21/$o/*.sql; do mysql kohatest < $a; done; done Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 13:41:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 12:41:43 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96364|0 |1 is obsolete| | --- Comment #2 from Andrew Isherwood --- Created attachment 96369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96369&action=edit Bug 24190 - Add acquisition logging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 13:41:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 12:41:55 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #3 from Andrew Isherwood --- Associated reports: 1. Order line cancellations SELECT o.ordernumber AS 'Order number', ba.basketname AS 'Basket', f.budget_name AS 'Fund', CONCAT(b.firstname, ' ', b.surname) AS 'Cancelled by', a.timestamp AS 'Cancelled timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqorders o ON a.object = o.ordernumber INNER JOIN aqbasket ba ON o.basketno = ba.basketno LEFT JOIN aqbudgets f ON o.budget_id = f.budget_id WHERE a.module='ACQUISITIONS' AND a.action = 'CANCEL_ORDER' AND date(a.timestamp) BETWEEN <> AND <> 2. Order line creations SELECT o.ordernumber AS 'Order number', ba.basketname AS 'Basket', f.budget_name AS 'Fund', CONCAT(b.firstname, ' ', b.surname) AS 'Created by', a.timestamp AS 'Created timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqorders o ON a.object = o.ordernumber INNER JOIN aqbasket ba ON o.basketno = ba.basketno LEFT JOIN aqbudgets f ON o.budget_id = f.budget_id WHERE a.module='ACQUISITIONS' AND a.action = 'CREATE_ORDER' AND date(a.timestamp) BETWEEN <> AND <> 3. Invoice adjustment additions SELECT f.budget_name AS 'Fund', i.invoicenumber, FORMAT(SUBSTRING(a.info, 1, 10), 2) AS 'Amount', ia.note AS 'Note', CASE WHEN SUBSTRING(a.info, 101, 10) = 0 THEN 'No' ELSE 'Yes' END AS 'Encumber open', av.lib AS 'Reason', CONCAT(b.firstname, ' ', b.surname) AS 'Created by', a.timestamp AS 'Created timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqinvoice_adjustments ia ON a.object = ia.adjustment_id INNER JOIN aqinvoices i ON i.invoiceid = ia.invoiceid LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 91, 10) = f.budget_id LEFT JOIN authorised_values av ON av.category = 'ADJ_REASON' AND av.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 11, 80)) WHERE a.module='ACQUISITIONS' AND a.action = 'CREATE_INVOICE_ADJUSTMENT' AND date(a.timestamp) BETWEEN <> AND <> 4. Invoice adjustment amendments SELECT i.invoicenumber AS 'Invoice number', f_before.budget_name AS 'Fund before', f_after.budget_name AS 'Fund after', FORMAT(SUBSTRING(a.info, 131, 10), 2) AS 'Amount before', FORMAT(SUBSTRING(a.info, 1, 10), 2) AS 'Amount after', ia.note AS 'Note', CASE WHEN SUBSTRING(a.info, 121, 10) = 0 THEN 'No' ELSE 'Yes' END AS 'Encumber open before', CASE WHEN SUBSTRING(a.info, 101, 10) = 0 THEN 'No' ELSE 'Yes' END AS 'Encumber open after', av_before.lib AS 'Reason before', av_after.lib AS 'Reason after', CONCAT(b.firstname, ' ', b.surname) AS 'Created by', a.timestamp AS 'Created timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqinvoice_adjustments ia ON a.object = ia.adjustment_id INNER JOIN aqinvoices i ON i.invoiceid = ia.invoiceid LEFT JOIN aqbudgets f_before ON SUBSTRING(a.info, 111, 10) = f_before.budget_id LEFT JOIN aqbudgets f_after ON SUBSTRING(a.info, 91, 10) = f_after.budget_id LEFT JOIN authorised_values av_before ON av_before.category = 'ADJ_REASON' AND av_before.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 141, 80)) LEFT JOIN authorised_values av_after ON av_after.category = 'ADJ_REASON' AND av_after.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 11, 80)) WHERE a.module='ACQUISITIONS' AND a.action = 'UPDATE_INVOICE_ADJUSTMENT' AND date(a.timestamp) BETWEEN <> AND <> 5. Invoice adjustment deletions SELECT i.invoicenumber AS 'Invoice number', f.budget_name AS 'Fund', FORMAT(SUBSTRING(a.info, 31, 10), 2) AS 'Amount', CASE WHEN SUBSTRING(a.info, 21, 10) = 0 THEN 'No' ELSE 'Yes' END AS 'Encumber open', av.lib AS 'Reason', CONCAT(b.firstname, ' ', b.surname) AS 'Deleted by', a.timestamp AS 'Deleted timestamp', SUBSTRING(a.info, 31, 10) FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqinvoices i ON i.invoiceid = SUBSTRING(a.info, 1, 10) LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 11, 10) = f.budget_id LEFT JOIN authorised_values av ON av.category = 'ADJ_REASON' AND av.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 41, 80)) WHERE a.module='ACQUISITIONS' AND a.action = 'DELETE_INVOICE_ADJUSTMENT' AND date(a.timestamp) BETWEEN <> AND <> 6. Order line receipts against an invoice SELECT o.ordernumber AS 'Order number', FORMAT(SUBSTRING(a.info, 1, 10), 0) AS 'Quantity received', f.budget_name AS 'Fund', FORMAT(SUBSTRING(a.info, 21, 10), 2) AS 'Tax rate', FORMAT(SUBSTRING(a.info, 31, 10), 2) AS 'Replacement price', FORMAT(SUBSTRING(a.info, 41, 10), 2) AS 'Actual cost', CONCAT(b.firstname, ' ', b.surname) AS 'Received by', a.timestamp AS 'Received timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqorders o ON a.object = o.ordernumber LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 11, 10) = f.budget_id WHERE a.module='ACQUISITIONS' AND a.action = 'RECEIVE_ORDER' AND date(a.timestamp) BETWEEN <> AND <> 7. Budget Adjustments SELECT SUBSTR(a.info, 31, 10) AS 'Budget start before', SUBSTR(a.info, 1, 10) AS 'Budget start after', SUBSTR(a.info, 41, 10) AS 'Budget end before', SUBSTR(a.info, 11, 10) AS 'Budget end after', FORMAT(SUBSTR(a.info, 51, 10), 2) AS 'Total amount before', FORMAT(SUBSTR(a.info, 21, 10), 2) AS 'Total amount after', FORMAT(SUBSTR(a.info, 61, 10), 2) AS 'Difference', CONCAT(b.firstname, ' ', b.surname) AS 'Modified by', a.timestamp AS 'Modified timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber WHERE a.module='ACQUISITIONS' AND a.action = 'MODIFY_BUDGET' AND date(a.timestamp) BETWEEN <> AND <> 8. Fund adjustments SELECT a.object AS 'Fund ID', FORMAT(SUBSTR(a.info, 31, 10), 2) AS 'Amount before', FORMAT(SUBSTR(a.info, 1, 10) ,2 ) AS 'Amount after', FORMAT(SUBSTR(a.info, 41, 10), 2) AS 'Warn at % before', FORMAT(SUBSTR(a.info, 11, 10), 2) AS 'Warn at % after', FORMAT(SUBSTR(a.info, 51, 10), 2) AS 'Warn at amount before', FORMAT(SUBSTR(a.info, 21, 10), 2) AS 'Warn at amount after', FORMAT(SUBSTR(a.info, 61, 10), 2) AS 'Difference', CONCAT(b.firstname, ' ', b.surname) AS 'Modified by', a.timestamp AS 'Modified timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber WHERE a.module='ACQUISITIONS' AND a.action = 'MODIFY_FUND' AND date(a.timestamp) BETWEEN <> AND <> 9. Order release date (1) SELECT ba.basketname AS "Basket name", bs.name AS "Vendor name", bi.title AS 'Title', bi.author AS 'Author', o.quantity AS 'Quantity', FORMAT(o.listprice, 2) AS 'Vendor price', FORMAT(o.rrp, 2) AS 'Retail price', FORMAT(o.ecost, 2) AS 'Budgeted cost', FORMAT(o.unitprice, 2) AS 'Actual cost', bu.budget_name AS 'Fund', CONCAT(b.firstname, ' ', b.surname) AS 'Basket closed by', a.timestamp AS 'Basket closed timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqbasket ba ON a.object = ba.basketno INNER JOIN aqorders o ON o.basketno = ba.basketno INNER JOIN aqbooksellers bs ON ba.booksellerid = bs.id LEFT JOIN aqbudgets bu ON bu.budget_id = o.budget_id LEFT JOIN biblio bi ON bi.biblionumber = o.biblionumber WHERE a.module='ACQUISITIONS' AND a.action = 'CLOSE_BASKET' AND date(a.timestamp) BETWEEN <> AND <> AND a.object = <> 10. Order release date (2) SELECT o.ordernumber AS 'Order number', b.basketname AS 'Basket', bu.budget_name AS 'Fund', bi.title AS 'Title', bi.author AS 'Author', CONCAT(bo.firstname, ' ', bo.surname) AS 'Sent by', e.transfer_date AS 'Sent date' FROM edifact_messages e LEFT JOIN aqbasket b ON e.basketno = b.basketno LEFT JOIN aqorders o ON o.basketno = b.basketno LEFT JOIN action_logs a ON e.basketno = a.object LEFT JOIN biblio bi ON o.biblionumber = bi.biblionumber LEFT JOIN borrowers bo ON a.user = bo.borrowernumber INNER JOIN aqbudgets bu ON o.budget_id = bu.budget_id WHERE e.message_type='ORDER' AND e.status = 'Sent' AND a.module = 'ACQUISITIONS' AND a.action = 'APPROVE_BASKET' AND date(e.transfer_date) BETWEEN <> AND <> AND e.basketno = <> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 13:47:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 12:47:23 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #57 from Owen Leonard --- (In reply to Owen Leonard from comment #55) > even though this isn't working correctly for me You're right Jonathan, tester error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:21:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:21:46 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #21 from Bernardo Gonzalez Kriegel --- Created attachment 96370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96370&action=edit Bug 13897: Use YAML files for installer data This patch modifies C4/Installer.pm to add support for loading YAML files into database. As an example of the functionality, optional auth_val.sql file is replaced by auth_val.yml The rationale behind this feature is to enable the translation of the data that is loaded into the database. That will be addressed in another bug. But taking into account that goal, translatable values are declared in the YAML files, to ease identification by translate script. To test: 0) Do a clean install with all optional data, then dump authorised_values table, reserve. 1) Apply the patch 2) Do a clean install in English (marc21/unimarc) 3) On optional data check for description of auth_val "Some basic default authorised values for ..." 4) Select all optional data 5) Finish installation 6) Dump again authorised_values table and compare with that of point '0'. Expected differences: most rows now have 'lib_opac' field with the same value as 'lib' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:23:21 +0000 Subject: [Koha-bugs] [Bug 24252] Add credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96363|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 96371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96371&action=edit Bug 24252: Add relations to Koha::Account::Line This patch adds two new relationships to the Koha::Account::Line object. * credit_offsets - returns all credit type Koha::Account::Offsets related to this Koha::Account::Line. * debit_offsets - returns all debit type Koha::Account::Offsets related to this Koha::Account::Line. * credits - returns all credits related to this Koha::Account::Line. * debits - returns all debits related to this Koha::Account::Line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:24:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:24:27 +0000 Subject: [Koha-bugs] [Bug 24254] New: Add Koha::Biblio get_visible_items method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Bug ID: 24254 Summary: Add Koha::Biblio get_visible_items method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be nice to be able to fetch items excluding opac hidden items in one DB call rather than having to loop through items and compare to the rules for each. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:24:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:24:34 +0000 Subject: [Koha-bugs] [Bug 24252] Add credits, debits, credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add credit_offsets and |Add credits, debits, |debit_offsets relationships |credit_offsets and |to Koha::Account::Line |debit_offsets relationships | |to Koha::Account::Line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:26:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:26:17 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #3 from Jonathan Druart --- Created attachment 96372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96372&action=edit Bug 24175: Take advantage of Koha::Item->holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:28:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:28:36 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Biblio get_visible_items method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #1 from Nick Clemens --- Created attachment 96373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96373&action=edit Bug 24254: Add get_visible_items method -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:29:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:29:59 +0000 Subject: [Koha-bugs] [Bug 23840] Overlap of top menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:38:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:38:14 +0000 Subject: [Koha-bugs] [Bug 23883] sip_cli_emulator.pl - typo in parameter name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:38:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:38:17 +0000 Subject: [Koha-bugs] [Bug 23883] sip_cli_emulator.pl - typo in parameter name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23883 --- Comment #1 from Jonathan Druart --- Created attachment 96374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96374&action=edit Bug 23883: SIP - Fix typo in parameter name The options of the script have hypens whereas the hash keys have underscore. In my understanding the problem only occurs on display purpose. Test plan: Try a sip command like % perl misc/sip_cli_emulator.pl -a localhost -su term1 -sp term1 -l CPL -m fee_paid Without this patch you will see: fee_amount is required for fee_paid With this patch the correct option is listed: fee-amount is required for fee_paid -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:40:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:40:21 +0000 Subject: [Koha-bugs] [Bug 23883] sip_cli_emulator.pl - typo in parameter name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:51:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:51:38 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #22 from Bernardo Gonzalez Kriegel --- Great to have so many comment :) (In reply to David Cook from comment #12) > > Since this is installer data, I don't think it necessarily has to be fast? I > figure the most important part is to make it easy to read and update? Agreed, I think it's worth it > Actually, I don't know if we necessarily need to change C4/Installer.pm? > > We could use YAML as a declarative format for the database data, and then > the Release Manager/Release Maintainer could run a tool to compile it into a > SQL script. I think, as Katrin and Jonathan, that it's better not to compile sql, just use the files, then a change in C4/Installer.pm is needed. (In reply to Jonathan Druart from comment #16) > > > Why not write our own stuff, yml-based? > ... > I would: > - Retrieve and parse the whole YAML file > - Generate the SQL queries (like 1 per table) > - Execute the INSERT statements (using DBIx::RunSQL->run_sql) In the new patch I'm inserting directly. We can try to measure the delay, if any (In reply to Katrin Fischer from comment #18) > > Going back to the actual problem this patchset is trying to resolve.. can > > you remind me what it is about the SQL format files in the first place means > > we can't easily support translating them without moving to some intermediary > > file format? > > I think the problem is that you can't 'mark' what needs translation. You > only want to translate a small bit of the SQL files, the descriptions while > preventing people to translate values that should not be changed. Katrin is right, I couldn't find a general way to parse sql files to extract/replace strings. There are too many variations. The only one I'd made is the one used to generate translated frameworks, in translation server, that has different functions to extract/replace strings with 1,2,6,15,16 commas (,); and that after massaging EN frameworks sql files so they are exactly as expected. (In reply to Martin Renvoize from comment #20) > What I wasn't fully understanding is why we needed to move from a lots of > SQL files to one YAML/XML/Whatever file instead of a single SQL file which > gets translated via the tools. > > Sounds like SQL is just too hard to parse as is for the existing translation > tools.. that's the answer. It is hard, at last for me :( Thank you all! If you can, please take a look at the second patch. It uses YAML instead of XML, it's easier to read. I tried it and works. Do not install the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:58:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:58:36 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:58:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:58:39 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95999|0 |1 is obsolete| | Attachment #96000|0 |1 is obsolete| | Attachment #96372|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 96375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96375&action=edit Bug 24175: Unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:58:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:58:43 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #5 from Jonathan Druart --- Created attachment 96376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96376&action=edit Bug 24175: Use itemnumber when searching for holds in SIP drop_hold To test: 1 - place a hold for a patron 2 - Get SIP running https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-' 4 - Attempt to cancel hold 5 - It fails 6 - Apply patch 7 - Try again 8 - It succeeds Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:58:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:58:46 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #6 from Jonathan Druart --- Created attachment 96377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96377&action=edit Bug 24175: Take advantage of Koha::Item->holds Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 14:58:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 13:58:49 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #7 from Jonathan Druart --- Created attachment 96378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96378&action=edit Bug 24175: Simplify tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:07:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:07:59 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #4 from Andrew Isherwood --- 1. Order line cancellations: ---------------------------- SELECT o.ordernumber AS 'Order number', bi.title AS 'Title', bi.author AS 'Author', ba.basketname AS 'Basket', f.budget_name AS 'Fund', CONCAT(b.firstname, ' ', b.surname) AS 'Cancelled by', a.timestamp AS 'Cancelled timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqorders o ON a.object = o.ordernumber INNER JOIN aqbasket ba ON o.basketno = ba.basketno LEFT JOIN aqbudgets f ON o.budget_id = f.budget_id LEFT JOIN biblio bi ON o.biblionumber = bi.biblionumber WHERE a.module='ACQUISITIONS' AND a.action = 'CANCEL_ORDER' AND date(a.timestamp) BETWEEN <> AND <> Order line creations: --------------------- SELECT o.ordernumber AS 'Order number', ba.basketname AS 'Basket', bi.title AS 'Title', bi.author AS 'Author', f.budget_name AS 'Fund', CONCAT(b.firstname, ' ', b.surname) AS 'Created by', a.timestamp AS 'Created timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqorders o ON a.object = o.ordernumber INNER JOIN aqbasket ba ON o.basketno = ba.basketno LEFT JOIN aqbudgets f ON o.budget_id = f.budget_id LEFT JOIN biblio bi ON o.biblionumber = bi.biblionumber WHERE a.module='ACQUISITIONS' AND a.action = 'CREATE_ORDER' AND date(a.timestamp) BETWEEN <> AND <> 3. Invoice adjustment additions: -------------------------------- SELECT f.budget_name AS 'Fund', i.invoicenumber, FORMAT(SUBSTRING(a.info, 1, 10), 2) AS 'Amount', ia.note AS 'Note', CASE WHEN SUBSTRING(a.info, 101, 10) = 0 THEN 'No' ELSE 'Yes' END AS 'Encumber open', av.lib AS 'Reason', CONCAT(b.firstname, ' ', b.surname) AS 'Created by', a.timestamp AS 'Created timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqinvoice_adjustments ia ON a.object = ia.adjustment_id INNER JOIN aqinvoices i ON i.invoiceid = ia.invoiceid LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 91, 10) = f.budget_id LEFT JOIN authorised_values av ON av.category = 'ADJ_REASON' AND av.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 11, 80)) WHERE a.module='ACQUISITIONS' AND a.action = 'CREATE_INVOICE_ADJUSTMENT' AND date(a.timestamp) BETWEEN <> AND <> 4. Invoice adjustment amendments: --------------------------------- SELECT i.invoicenumber AS 'Invoice number', f_before.budget_name AS 'Fund before', f_after.budget_name AS 'Fund after', FORMAT(SUBSTRING(a.info, 131, 10), 2) AS 'Amount before', FORMAT(SUBSTRING(a.info, 1, 10), 2) AS 'Amount after', ia.note AS 'Note', CASE WHEN SUBSTRING(a.info, 121, 10) = 0 THEN 'No' ELSE 'Yes' END AS 'Encumber open before', CASE WHEN SUBSTRING(a.info, 101, 10) = 0 THEN 'No' ELSE 'Yes' END AS 'Encumber open after', av_before.lib AS 'Reason before', av_after.lib AS 'Reason after', CONCAT(b.firstname, ' ', b.surname) AS 'Created by', a.timestamp AS 'Created timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqinvoice_adjustments ia ON a.object = ia.adjustment_id INNER JOIN aqinvoices i ON i.invoiceid = ia.invoiceid LEFT JOIN aqbudgets f_before ON SUBSTRING(a.info, 111, 10) = f_before.budget_id LEFT JOIN aqbudgets f_after ON SUBSTRING(a.info, 91, 10) = f_after.budget_id LEFT JOIN authorised_values av_before ON av_before.category = 'ADJ_REASON' AND av_before.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 141, 80)) LEFT JOIN authorised_values av_after ON av_after.category = 'ADJ_REASON' AND av_after.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 11, 80)) WHERE a.module='ACQUISITIONS' AND a.action = 'UPDATE_INVOICE_ADJUSTMENT' AND date(a.timestamp) BETWEEN <> AND <> 5. Invoice adjustment deletions: -------------------------------- SELECT i.invoicenumber AS 'Invoice number', f.budget_name AS 'Fund', FORMAT(SUBSTRING(a.info, 31, 10), 2) AS 'Amount', CASE WHEN SUBSTRING(a.info, 21, 10) = 0 THEN 'No' ELSE 'Yes' END AS 'Encumber open', av.lib AS 'Reason', CONCAT(b.firstname, ' ', b.surname) AS 'Deleted by', a.timestamp AS 'Deleted timestamp', SUBSTRING(a.info, 31, 10) FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqinvoices i ON i.invoiceid = SUBSTRING(a.info, 1, 10) LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 11, 10) = f.budget_id LEFT JOIN authorised_values av ON av.category = 'ADJ_REASON' AND av.authorised_value = TRIM(LEADING ' ' FROM SUBSTRING(a.info, 41, 80)) WHERE a.module='ACQUISITIONS' AND a.action = 'DELETE_INVOICE_ADJUSTMENT' AND date(a.timestamp) BETWEEN <> AND <> 6. Order line receipts against an invoice: ----------------------------------------- SELECT o.ordernumber AS 'Order number', FORMAT(SUBSTRING(a.info, 1, 10), 0) AS 'Quantity received', f.budget_name AS 'Fund', FORMAT(SUBSTRING(a.info, 21, 10), 2) AS 'Tax rate', FORMAT(SUBSTRING(a.info, 31, 10), 2) AS 'Replacement price', FORMAT(SUBSTRING(a.info, 41, 10), 2) AS 'Actual cost', CONCAT(b.firstname, ' ', b.surname) AS 'Received by', a.timestamp AS 'Received timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqorders o ON a.object = o.ordernumber LEFT JOIN aqbudgets f ON SUBSTRING(a.info, 11, 10) = f.budget_id WHERE a.module='ACQUISITIONS' AND a.action = 'RECEIVE_ORDER' AND date(a.timestamp) BETWEEN <> AND <> 7. Budget Adjustments: ---------------------- SELECT SUBSTR(a.info, 31, 10) AS 'Budget start before', SUBSTR(a.info, 1, 10) AS 'Budget start after', SUBSTR(a.info, 41, 10) AS 'Budget end before', SUBSTR(a.info, 11, 10) AS 'Budget end after', FORMAT(SUBSTR(a.info, 51, 10), 2) AS 'Total amount before', FORMAT(SUBSTR(a.info, 21, 10), 2) AS 'Total amount after', FORMAT(SUBSTR(a.info, 61, 10), 2) AS 'Difference', CONCAT(b.firstname, ' ', b.surname) AS 'Modified by', a.timestamp AS 'Modified timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber WHERE a.module='ACQUISITIONS' AND a.action = 'MODIFY_BUDGET' AND date(a.timestamp) BETWEEN <> AND <> 8. Fund adjustments: -------------------- SELECT a.object AS 'Fund ID', FORMAT(SUBSTR(a.info, 31, 10), 2) AS 'Amount before', FORMAT(SUBSTR(a.info, 1, 10) ,2 ) AS 'Amount after', FORMAT(SUBSTR(a.info, 41, 10), 2) AS 'Warn at % before', FORMAT(SUBSTR(a.info, 11, 10), 2) AS 'Warn at % after', FORMAT(SUBSTR(a.info, 51, 10), 2) AS 'Warn at amount before', FORMAT(SUBSTR(a.info, 21, 10), 2) AS 'Warn at amount after', FORMAT(SUBSTR(a.info, 61, 10), 2) AS 'Difference', CONCAT(b.firstname, ' ', b.surname) AS 'Modified by', a.timestamp AS 'Modified timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber WHERE a.module='ACQUISITIONS' AND a.action = 'MODIFY_FUND' AND date(a.timestamp) BETWEEN <> AND <> 9. Order release date (1): -------------------------- SELECT ba.basketname AS "Basket name", bs.name AS "Vendor name", bi.title AS 'Title', bi.author AS 'Author', o.quantity AS 'Quantity', FORMAT(o.listprice, 2) AS 'Vendor price', FORMAT(o.rrp, 2) AS 'Retail price', FORMAT(o.ecost, 2) AS 'Budgeted cost', FORMAT(o.unitprice, 2) AS 'Actual cost', bu.budget_name AS 'Fund', CONCAT(b.firstname, ' ', b.surname) AS 'Basket closed by', a.timestamp AS 'Basket closed timestamp' FROM action_logs a INNER JOIN borrowers b ON a.user = b.borrowernumber INNER JOIN aqbasket ba ON a.object = ba.basketno INNER JOIN aqorders o ON o.basketno = ba.basketno INNER JOIN aqbooksellers bs ON ba.booksellerid = bs.id LEFT JOIN aqbudgets bu ON bu.budget_id = o.budget_id LEFT JOIN biblio bi ON bi.biblionumber = o.biblionumber WHERE a.module='ACQUISITIONS' AND a.action = 'CLOSE_BASKET' AND date(a.timestamp) BETWEEN <> AND <> AND a.object = <> 10. Order release date (2): --------------------------- SELECT o.ordernumber AS 'Order number', b.basketname AS 'Basket', bu.budget_name AS 'Fund', bi.title AS 'Title', bi.author AS 'Author', CONCAT(bo.firstname, ' ', bo.surname) AS 'Sent by', e.transfer_date AS 'Sent date' FROM edifact_messages e LEFT JOIN aqbasket b ON e.basketno = b.basketno LEFT JOIN aqorders o ON o.basketno = b.basketno LEFT JOIN action_logs a ON e.basketno = a.object LEFT JOIN biblio bi ON o.biblionumber = bi.biblionumber LEFT JOIN borrowers bo ON a.user = bo.borrowernumber INNER JOIN aqbudgets bu ON o.budget_id = bu.budget_id WHERE e.message_type='ORDER' AND e.status = 'Sent' AND a.module = 'ACQUISITIONS' AND a.action = 'APPROVE_BASKET' AND date(e.transfer_date) BETWEEN <> AND <> AND e.basketno = <> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:08:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:08:34 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Andrew Isherwood --- Test plan: Setup: 1. Apply patch and run database update if necessary Order line cancellations: 1. Go to "Aquisitions", find an open basket with at least one order 2. Cancel the order and confirm the cancellation 3. From the staff main page, go to "Reports > Create from SQL" 4. Name the report "Order line cancellations" 5. In the SQL box, enter the report labelled "Order line cancellations" in comment #4 above 6. Save the report, the run it, choosing a start and end date 7. TEST => Observe that the order cancellation you just carried out is listed Order line creations: 1. Go to "Aquisitions", find or create an open basket 2. Create a new order in the basket 3. From the staff main page, go to "Reports > Create from SQL" 4. Name the report "Order line creations" 5. In the SQL box, enter the report labelled "Order line creations" in comment #4 above 6. Save the report, the run it, choosing a start and end date 7. TEST => Observe that the order creation you just carried out is listed Invoice adjustment additions: 1. Go to "Aquisitions", find or create an invoice 2. Click "Add an adjustment" 3. Fill in the details of the adjustment, then click "Update adjustments" 4. From the staff main page, go to "Reports > Create from SQL" 5. Name the report "Invoice adjustment additions" 6. In the SQL box, enter the report labelled "Invoice adjustment additions" in comment #4 above 7. Save the report, the run it, choosing a start and end date 8. TEST => Observe that the adjustment creation you just carried out is listed Invoice adjustment amendments: 1. Go to "Aquisitions", find the invoice from the previous steps 2. Find the adjustment you added and modify it 3. Click "Update adjustments" 4. From the staff main page, go to "Reports > Create from SQL" 5. Name the report "Invoice adjustment amendments" 6. In the SQL box, enter the report labelled "Invoice adjustment amendments" in comment #4 above 7. Save the report, the run it, choosing a start and end date 8. TEST => Observe that the adjustment amendment you just carried out is listed Invoice adjustment deletions: 1. Go to "Aquisitions", find the invoice from the previous steps 2. Find the adjustment you added and delete it 3. From the staff main page, go to "Reports > Create from SQL" 4. Name the report "Invoice adjustment deletions" 5. In the SQL box, enter the report labelled "Invoice adjustment deletions" in comment #4 above 6. Save the report, the run it, choosing a start and end date 7. TEST => Observe that the adjustment deletion you just carried out is listed Order line receipts against an invoice: 1. Go to "Aquisitions", find an open invoice with unreceived items 2. Go to the "Receipt summary" page 3. Click "Receive" for an item 4. Fill in the data as appropriate, then click "Save" 5. From the staff main page, go to "Reports > Create from SQL" 6. Name the report "Order line receipts against an invoice" 7. In the SQL box, enter the report labelled "Order line receipts against an invoice" in comment #4 above 8. Save the report, the run it, choosing a start and end date 9. TEST => Observe that the receipt you just carried out is listed Budget adjustments: 1. Go to "Aquisitions", find a budget 2. Click "Actions" > "Edit" 3. Modify some properties of the budget 4. Click "Save" 5. From the staff main page, go to "Reports > Create from SQL" 6. Name the report "Budget adjustments" 7. In the SQL box, enter the report labelled "Budget adjustments" in comment #4 above 8. Save the report, the run it, choosing a start and end date 9. TEST => Observe that the adjustment you just carried out is listed, including details of the "before" and "after" values Fund adjustments: 1. Go to "Aquisitions", find a fund 2. Click "Actions" > "Edit" 3. Modify some properties of the fund 4. Click "Submit" 5. From the staff main page, go to "Reports > Create from SQL" 6. Name the report "Fund adjustments" 7. In the SQL box, enter the report labelled "Fund adjustments" in comment #4 above 8. Save the report, the run it, choosing a start and end date 9. TEST => Observe that the adjustment you just carried out is listed, including details of the "before" and "after" values Order release date (1): 1. Go to "Aquisitions", find an open basket 2. Close the basket, noting it's ID 3. From the staff main page, go to "Reports > Create from SQL" 4. Name the report "Order release date (1)" 5. In the SQL box, enter the report labelled "Order release date (1)" in comment #4 above 6. Save the report, the run it, choosing a start and end date and basket ID 7. TEST => Observe that the details of the closed basket are listed Order release date (2): 1. Release a basket via an EDI message, resulting in a row in edifact_messages table 3. From the staff main page, go to "Reports > Create from SQL" 4. Name the report "Order release date (2)" 5. In the SQL box, enter the report labelled "Order release date (2)" in comment #4 above 6. Save the report, the run it, choosing a start and end date and basket ID 7. TEST => Observe that the details of the released orders are listed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:14:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:14:40 +0000 Subject: [Koha-bugs] [Bug 24255] New: Add totals methods Koha::Account::Lines Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255 Bug ID: 24255 Summary: Add totals methods Koha::Account::Lines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: kyle at bywatersolutions.com, testopia at bugs.koha-community.org, tomascohen at gmail.com Blocks: 23442 Add missing summation methods to the Koha::Account::Lines class. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:14:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:14:40 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255 [Bug 24255] Add totals methods Koha::Account::Lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:14:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:14:48 +0000 Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:14:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:14:54 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:14:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:14:57 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95461|0 |1 is obsolete| | --- Comment #10 from Joonas Kylmälä --- Created attachment 96379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96379&action=edit Bug 24016: Add a failing test for overwrite-able manager_id in Koha::Patron::Message To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe failure t/db_dependent/Koha/Patron/Messages.t .. 2/12 Failed test 'Manager id should be overwrite-able even if defined in userenv' at t/db_dependent/Koha/Patron/Messages.t line 90. got: '1100' expected: '1101' Looks like you failed 1 test of 12. t/db_dependent/Koha/Patron/Messages.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/12 subtests Sponsored-by: Koha-Suomi Oy Signed-off-by: Maryse Simard Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:15:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:15:00 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95462|0 |1 is obsolete| | --- Comment #11 from Joonas Kylmälä --- Created attachment 96380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96380&action=edit Bug 24016: manager_id in Koha::Patron::Message->store should not depend on userenv alone Koha::Patron::Message->store has this my $userenv = C4::Context->userenv; $self->manager_id( $userenv ? $userenv->{number} : undef); This breaks in REST API when userenv is not set. Let API user pass manager_id without relying on C4::Context->userenv. To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe success Sponsored-by: Koha-Suomi Oy Signed-off-by: Maryse Simard Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:15:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:15:03 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 --- Comment #12 from Joonas Kylmälä --- Created attachment 96381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96381&action=edit Bug 24016: (QA follow-up) Format code to adhere to perltidy format Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:21:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:21:22 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #23 from Jonathan Druart --- Looks great to me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:23:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:23:04 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at helsinki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:45:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:45:09 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:49:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:49:42 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:55:33 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14826 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 [Bug 14826] Store account offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:55:33 +0000 Subject: [Koha-bugs] [Bug 14826] Store account offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 [Bug 15985] Include transacting library in fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:55:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:55:49 +0000 Subject: [Koha-bugs] [Bug 23883] sip_cli_emulator.pl - typo in parameter name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23883 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:55:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:55:51 +0000 Subject: [Koha-bugs] [Bug 23883] sip_cli_emulator.pl - typo in parameter name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23883 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96374|0 |1 is obsolete| | --- Comment #2 from Andrew Isherwood --- Created attachment 96382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96382&action=edit Bug 23883: SIP - Fix typo in parameter name The options of the script have hypens whereas the hash keys have underscore. In my understanding the problem only occurs on display purpose. Test plan: Try a sip command like % perl misc/sip_cli_emulator.pl -a localhost -su term1 -sp term1 -l CPL -m fee_paid Without this patch you will see: fee_amount is required for fee_paid With this patch the correct option is listed: fee-amount is required for fee_paid Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 15:59:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 14:59:28 +0000 Subject: [Koha-bugs] [Bug 21627] System preference for recipient emails of gather_print_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21627 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #6 from Magnus Enger --- (In reply to Danielle Elder from comment #5) > I would love to see the email address default to the branches.branchemail > when the --split parameter is used.Otherwise I have to set up additional > crons to send the individual notices to each branch e-mail. How do you do that? If you do --split and several --email, does not all the files get sent to all the addresses? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 16:02:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 15:02:55 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 --- Comment #11 from Martin Renvoize --- (In reply to Katrin Fischer from comment #10) > I also find this strange - I don't think we should ever delete from > deleted_items? And why select by barcode? We're not deleting from deleted_items.. we're looking up the item deleted_items using barcode if and only if we can't find the item already in items. It's to maintain a relationship between the accountline and a possible deleted item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 16:03:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 15:03:02 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 --- Comment #12 from Martin Renvoize --- (In reply to Katrin Fischer from comment #10) > I also find this strange - I don't think we should ever delete from > deleted_items? And why select by barcode? We're not deleting from deleted_items.. we're looking up the item deleted_items using barcode if and only if we can't find the item already in items. It's to maintain a relationship between the accountline and a possible deleted item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 16:07:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 15:07:38 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #24 from Martin Renvoize --- OK, that's lovely.. super simple to understand and write.. nice work Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 16:14:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 15:14:48 +0000 Subject: [Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838 --- Comment #1 from Arthur Suzuki --- Created attachment 96383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96383&action=edit Bug 22838: Remove MIME header warnings from runreports.pl Test plan: - create a savedsql report - run misc/cronjob/runreport.pl with options --format set to html and --to any email - check plack errors log, you should get a warning - apply patch - repeat runreport.pl step - check plack errors log, no additional warning there should be -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 16:15:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 15:15:10 +0000 Subject: [Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 16:23:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 15:23:53 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #58 from Owen Leonard --- Created attachment 96384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96384&action=edit Bug 7882: (follow-up) Only show sortable icon for sortable tags Only tags which can be repeated can be sorted, so the "bars" icon should not display by these tags. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 16:39:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 15:39:26 +0000 Subject: [Koha-bugs] [Bug 24256] New: Free Form : Move email to Tools > Notices and slips Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24256 Bug ID: 24256 Summary: Free Form : Move email to Tools > Notices and slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com I'm testing the ILL module with the Free form backend. I noticed the email to partner libraries is hardcoded in the pm file. This means that it doesn't work in multilingual environments. I think it should use the letters in Notices & slips. That way, we can make the letters mutilingual and send the right language according to the partner library preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 16:50:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 15:50:30 +0000 Subject: [Koha-bugs] [Bug 24257] New: item-transfer-modal does not initiate transfer when 'yes, print slip' is selected Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257 Bug ID: 24257 Summary: item-transfer-modal does not initiate transfer when 'yes, print slip' is selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a item-transfer-modal is prompted by returns.tt and the option "Yes, print slip" is selected the transfer is not initiated and the modal does not disappear. To recreate: 1. set AutomaticItemReturn to "don't" 2. Check out an item and attempt to check it in at a branch it doesn't belong to. 3. When the popup modal appears select 'Yes, print slip'. 4. Observe that the transfer does not initiate and the modal does not close. 5. In FF this also produces the following console error (this.form.print_slip is undefined) Choosing 'Yes' works as excepted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 16:57:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 15:57:16 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 16:57:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 15:57:19 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #2 from Owen Leonard --- Created attachment 96385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96385&action=edit Bug 24169: Advanced editor: icons/buttons for sorting the search results are missing This patch "manually" adds the "dataTable" class to the table of search results in the advanced cataloging editor. This allows the correct styles to get picked up from existing CSS. To test, go to Cataloging and open the advanced editor. Perform a search using the sidebar search form. In the table of results, confirm that table sorting indicators look correct and that sorting works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:08:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:08:34 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96385|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 96386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96386&action=edit Bug 24169: Advanced editor: icons/buttons for sorting the search results are missing This patch "manually" adds the "dataTable" class to the table of search results in the advanced cataloging editor. This allows the correct styles to get picked up from existing CSS. To test, go to Cataloging and open the advanced editor. Perform a search using the sidebar search form. In the table of results, confirm that table sorting indicators look correct and that sorting works correctly. Signed-off-by: Cori Lynn Arnold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:09:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:09:13 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Cori Lynn Arnold --- Works great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:13:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:13:16 +0000 Subject: [Koha-bugs] [Bug 24258] New: Sending partner request doesn't fall back to KohaAdminEmailAddress Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24258 Bug ID: 24258 Summary: Sending partner request doesn't fall back to KohaAdminEmailAddress Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com The code only looks for the branchemail, and if there is none, it doesn't fall back to KohaAdminEmailAddress. To reproduce : - If your branches have emails, remove them - Make sure KohaAdminEmailAddress is filled - Go to ILL module - Create a request - Click on 'Place request with partners' - Click 'Send email' I get an error message 'Your library has no usable email address. Please set it.' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:21:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:21:21 +0000 Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255 --- Comment #1 from Martin Renvoize --- Created attachment 96387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96387&action=edit Bug 24255: Add summation methods to Koha::Account::Lines This patch adds a number of summation methods to Koha::Account::Lines giving quick access to overall total, total credits and total debits. Test plan 1) Run the included tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:21:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:21:50 +0000 Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 [Bug 24252] Add credits, debits, credit_offsets and debit_offsets relationships to Koha::Account::Line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:21:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:21:50 +0000 Subject: [Koha-bugs] [Bug 24252] Add credits, debits, credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255 [Bug 24255] Add totals methods Koha::Account::Lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:22:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:22:16 +0000 Subject: [Koha-bugs] [Bug 24252] Add credits, debits, credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:22:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:22:16 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 [Bug 24252] Add credits, debits, credit_offsets and debit_offsets relationships to Koha::Account::Line -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:23:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:23:03 +0000 Subject: [Koha-bugs] [Bug 24252] Add credits, debits, credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23442 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:23:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:23:03 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24252 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 [Bug 24252] Add credits, debits, credit_offsets and debit_offsets relationships to Koha::Account::Line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:23:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:23:32 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23442 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:23:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:23:32 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24080 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:24:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:24:33 +0000 Subject: [Koha-bugs] [Bug 24248] The maximum allowable reduction of an accountline should use the combined refunded value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Martin Renvoize --- Folded into bug 23442 submission.. marking as duplicate. *** This bug has been marked as a duplicate of bug 23442 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:24:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:24:33 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 --- Comment #8 from Martin Renvoize --- *** Bug 24248 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:24:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:24:39 +0000 Subject: [Koha-bugs] [Bug 24248] The maximum allowable reduction of an accountline should use the combined refunded value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23442 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:24:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:24:39 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24248 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24248 [Bug 24248] The maximum allowable reduction of an accountline should use the combined refunded value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 17:25:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 16:25:03 +0000 Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 18:46:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 17:46:15 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 96388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96388&action=edit Bug 24232: Regression tests This patch enhances the tests for the DELETE /biblios/:biblio_id endpoint so more fine grained permissions are tested. It highlights the fact that the required permissions defined on the spec are not correcttly defined. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail because the user (that now has subpermissions only) does not have enough permissions for a non-existent subpermission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 18:46:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 17:46:18 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 96389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96389&action=edit Bug 24232: Fix required permissions in DELETE /biblios/:biblio_id This patch fixes the required permissions defined on the spec for the mentioned endpoint. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail due to badly defined permissions 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Notice parameters: edit_catelogue didn't exist 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 18:46:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 17:46:58 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 18:50:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 17:50:05 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #3 from Tomás Cohen Arazi --- (In reply to Kelly McElligott from comment #0) > Bug 15496 > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 > Now gives the ability to delete the bib if the item you are attaching to > another bib is the last item on the record. The code states that the > permission needed is Edit Catalogue, however, when this process is done, the > API is making a call and not getting the right signal (or something). > > Upon working on this, it seems that a librarian would need to have the > Overarching Permission in the Admin module to perform this action. Thanks for reporting it Kelly, it wasn't straightforward to detect the error! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 19:02:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 18:02:44 +0000 Subject: [Koha-bugs] [Bug 24209] Need Display status with timestamp on items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24209 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 19:11:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 18:11:04 +0000 Subject: [Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 19:11:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 18:11:48 +0000 Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96359|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 96390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96390&action=edit Bug 24219: Preserve sort order when returning to result list There is a mismatch between sort_cgi, sort and sort_by variables. * sort_cgi I did not find relevant occurrences of sort_cgi in the git log of both search.pl and results.tt. So it seems that it never worked correctly. * sort It is the JS variable use in browser.js * sort_by is the search.pl parameter to set the sort_by option Test plan: 1. Perform a search in the staff client 2. Change the sort order to something different (try Author A-Z) 3. Click on a result to view the record 4. Click on "Results" button on left side to return to result list => Without this patch the result list is sorted by relevancy => With this patch applied the Author A-Z is kept Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 19:12:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 18:12:26 +0000 Subject: [Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 19:44:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 18:44:57 +0000 Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- It looks like this patch tries to switch to using the Koha patron object for items, but during the checkout we are getting a SIP/ILS patron object, we can't call borrowernumber on that (yet) I think in general we should stick to the SIP object to avoid confusion and just extend that object to have all the tools it needs (add borrowernumber to the object)- perhaps if the id is unpopulated we can fall back, or we can just always use the borrowernumber internally as a more standard id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 20:35:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 19:35:07 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #9 from Kelly McElligott --- Created attachment 96391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96391&action=edit success -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 20:37:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 19:37:26 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96347|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes --- Created attachment 96392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96392&action=edit Bug 23673: Add "Time status changed" column to patron's notices This patch adds "Time status changed" column to patron's notices tab. It also adds logic to C4::Letters to update time_status_changed column when status is changed, and leaves time_queued with message creation time. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Time status changed" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" and no "time status changed" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "time status changed" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and time status changed updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 20:53:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 19:53:40 +0000 Subject: [Koha-bugs] [Bug 9131] Improve usability when linking to guarantor from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9131 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Owen Leonard --- This interface is now much clearer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 20:56:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 19:56:09 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #4 from Kelly McElligott --- Can the test plan be more simplistic for users? 1. Have a staff member with Edit Catalog permissions (Edit catalog (Modify bibliographic/holdings data) (edit_catalogue)) and within the Edit Catalog permissions, Edit Items. 2. Find a bib record with 1 item. 3. Attach that 1 item to another bib record. 4. Koha gives an error when staff tries to delete the record. 5. Apply patch 6. Go through steps 1-3. 7. Success. Staff can attach an item to a record and successfully delete the itemless bib in the same step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 21:16:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 20:16:08 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96389|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes --- Created attachment 96393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96393&action=edit Bug 24232: Fix required permissions in DELETE /biblios/:biblio_id This patch fixes the required permissions defined on the spec for the mentioned endpoint. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail due to badly defined permissions 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Notice parameters: edit_catelogue didn't exist 5. Sign off :-D Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 22:41:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 21:41:31 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 22:41:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 21:41:34 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95619|0 |1 is obsolete| | --- Comment #11 from Michal Denar --- Created attachment 96394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96394&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 22:56:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 21:56:03 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 17 23:31:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Dec 2019 22:31:48 +0000 Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | CC| |hayleymapley at catalyst.net.n | |z --- Comment #11 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 01:43:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 00:43:33 +0000 Subject: [Koha-bugs] [Bug 24073] Allow suggestion management page to default to all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24073 magsk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maggie.wong at yccece.edu.hk --- Comment #2 from magsk --- It would be great if there is a setting to show suggestions from 'Any' library . For us, we were quite puzzled at first when we saw 2 suggestions pending but there was no data after clicking into the suggestions. We couldn't figure out where the suggestions were and later learnt that the suggestions were in ACQ Info where we need to run a search with 'Any' Library. It is quite troublesome to have to check suggestions like this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 04:33:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 03:33:11 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #25 from David Cook --- That looks a lot nicer! Since you're going with this approach, perhaps it would be worth turning off AutoCommit, running the INSERTs, and then COMMITing? According to the MySQL documentation, that should be higher performance. Probably easier to handle exceptions that way too. I wonder if we should add more error-handling in the eval{} block as well. I suppose any errors will be caught during $loadyaml->execute(), so maybe that's unnecessary. (Due to my nitpicker nature, I'd suggest $loadyaml be $load_sth instead, but that's really just nitpicking, so feel free to ignore it.) +1 Bernardo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 05:24:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 04:24:22 +0000 Subject: [Koha-bugs] [Bug 24259] New: Circulation fails of no circ rule defined but rental fee for itemtype if override confirmed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 Bug ID: 24259 Summary: Circulation fails of no circ rule defined but rental fee for itemtype if override confirmed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Can't call method "lengthunit" on an undefined value at /usr/share/koha/lib/Koha/Charges/Fees.pm line 101. TO recreate: 1 - Remove all/all rule form circulation rules 2 - Define a rental fee per day for an itemtype 3 - Checkout an item of this type ot patron 4 - Should get note of no circ rule defined 5 - Confirm the checkout, internal server error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 05:32:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 04:32:58 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails of no circ rule defined but rental fee for itemtype if override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 --- Comment #1 from Nick Clemens --- Note, you don't have to have a rental charge defined - the checkout triggers the error as we always check the rental charge to see if there is one or not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 05:34:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 04:34:28 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails of no circ rule defined but rental fee for itemtype if override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 05:34:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 04:34:52 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails of no circ rule defined but checkout override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Circulation fails of no |Circulation fails of no |circ rule defined but |circ rule defined but |rental fee for itemtype if |checkout override confirmed |override confirmed | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 05:35:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 04:35:01 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Circulation fails of no |Circulation fails if no |circ rule defined but |circ rule defined but |checkout override confirmed |checkout override confirmed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 08:16:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 07:16:00 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- As this is affecting new 19.11 installations and has come up on the mailing list already, it would be nice to have it fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:05:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:05:20 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:05:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:05:23 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96208|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 96395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96395&action=edit Bug 24215: Correct display of guarantor relationship errors Test plan: 1) Add some bad data to your borrower_relationships table. ( add or update a relationship such that the 'relationship' field contains a value not listed in the corresponding system preference. 2) Go to the about system information page and note the nasty display of ARRAY(whatever) 3) Apply the patch 4) Repeat step 2 and note that a list of bad values is now displayed instead. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:05:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:05:27 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 --- Comment #7 from Jonathan Druart --- Created attachment 96396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96396&action=edit Bug 24215: Do not always display an empty entry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:07:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:07:51 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 --- Comment #8 from Jonathan Druart --- This second patch fixes the following: on a fresh install we do not display anything on the about page (see screenshot on comment 4). However there is still something wrong, but not sure it comes from this patch. When you create a new patron, its relationship field is populated with an empty string, and it seems we are expecting NULL. So we should include "" in this patch, and/or fix the original issue (ie. insert NULL instead of empty string, and update the existing occurrences in DB). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:27:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:27:51 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #26 from Jonathan Druart --- Bernardo, I am all good with it, we could improve (performance) later (like one INSERT per file) if needed. Another improvement would be to move the .txt file into the YAML. I would like to see the translator tool ready before we push this one. Did you investigate already the work that needs to be done? I think we should move the already translated strings into a new .po (one .po for all installer files?) I can have a look if you did not already, but prefer to avoid duplication of work :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:28:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:28:44 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #27 from Jonathan Druart --- Created attachment 96397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96397&action=edit Bug 13897: Catch the error and warn it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:28:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:28:58 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use XML files for installer |Use YAML files for |data |installer data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:29:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:29:08 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95884|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:37:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:37:55 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #5 from Jonathan Druart --- Owen, does not it sound more correct to copy the CSS definitions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:44:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:44:19 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #6 from Jonathan Druart --- Tomas, Kelly, The script moveitem.pl requires editcatalogue => 'edit_items', the deletion of a biblio editcatalogue => edit_catalogue. Even if weird I guess we could have a librarian with edit_items but edit_catalogue. I think we should show delete-biblio-btn if CAN_user_editcatalogue_edit_catalogue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:48:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:48:01 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #7 from Jonathan Druart --- Created attachment 96398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96398&action=edit Bug 24232: Hide the "Delete biblio" if permission edit_catalogue not set The script moveitem.pl requires editcatalogue => 'edit_items', the deletion of a biblio editcatalogue => edit_catalogue. Even if weird I guess we could have a librarian with edit_items but edit_catalogue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:48:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:48:36 +0000 Subject: [Koha-bugs] [Bug 13736] Enable EDS Plugin Patch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13736 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- > The EDS plugin requires 2 files to be patched. Actual version of EDS plugin 17.11 no longer requires those patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:50:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:50:07 +0000 Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96387|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 96399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96399&action=edit Bug 24255: Add summation methods to Koha::Account::Lines This patch adds a number of summation methods to Koha::Account::Lines giving quick access to overall total, total credits and total debits. Test plan 1) Run the included tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:52:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:52:48 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95674|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 96400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96400&action=edit Bug 23442: Add account credit types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:52:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:52:51 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95675|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 96401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96401&action=edit Bug 23442: Add 'reduce' method to Koha::Account::Line This enhancement adds a 'reduce' method to Koha::Account::Line which can be used to reduce a charge/debit by adding a credit to offset against the amount outstanding. It may be used to apply a discount whilst retaining the original debit amounts or to apply a full or partial refund for example when a lost item is found and returned. The created credit will be immediately applied against the debit unless the debit has already been paid, in which case a 'zero' offset will be added to maintain a link to the debit but the outstanding credit will be left so it may be applied to other debts. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:52:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:52:54 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95676|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 96402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96402&action=edit Bug 23442: Add refund permission Add a new subpermission called 'refund' to the 'updatecharges' permission group which will allow/prevent refund actions to be performed by staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:52:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:52:57 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95677|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 96403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96403&action=edit Bug 23442: Add refund option to patron account page This enhancement adds a refined workflow to allow librarians to refund payments to patrons and record these refunds on the patrons account. The use case is that a patron has paid for something before then performing an action that may require some level of refund to be actioned. Perhaps they are returning a lost and paid for book. Test plan: 1) Undertake a series of transactions that result in a debit accountline being partially or fully paid off. 2) Note that a new 'Issue refund' button appears next to a debit (but only if your user has the refund permission or is a superlibrarian) 3) Click the 'Issue refund' button and a modal should appear pre-populated with the amount - amountoutstanding. 4) You should be able to edit the amount you wish to refund, record the refund or cancel. 5) Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:53:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:53:10 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #8 from Jonathan Druart --- Note that the message is meaningless: "The record has X attached items" is only displayed when X=0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 09:54:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 08:54:21 +0000 Subject: [Koha-bugs] [Bug 15496] Delete bibliographic record after moving last item to another record(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #58 from Jonathan Druart --- >From bug 24232 comment 8: Note that the message is meaningless: "The record has X attached items" is only displayed when X=0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:17:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:17:44 +0000 Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95703|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 96404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96404&action=edit Bug 23403: Remove cardnumber from SIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:20:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:20:06 +0000 Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |Needs Signoff --- Comment #9 from Jonathan Druart --- Thanks Nick, that helped a lot! I think this patch is ready for testing, however I am not sure how it could be tested to cover all the changes. Someone with a good knowledge in this script could review it, then test could be potentially broken. I think the following SIP commands would be a good test plan: checkin, checkout, renew, place a hold on an item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:33:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:33:08 +0000 Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate transfer when 'yes, print slip' is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |21346 --- Comment #1 from Jonathan Druart --- Maybe caused by bug 21346. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 [Bug 21346] Clean up dialogs in returns.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:33:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:33:08 +0000 Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24257 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257 [Bug 24257] item-transfer-modal does not initiate transfer when 'yes, print slip' is selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:35:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:35:01 +0000 Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96399|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 96405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96405&action=edit Bug 24255: Add summation methods to Koha::Account::Lines This patch adds a number of summation methods to Koha::Account::Lines giving quick access to overall total, total credits and total debits. Test plan 1) Run the included tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:39:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:39:22 +0000 Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate transfer when 'yes, print slip' is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:39:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:39:25 +0000 Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate transfer when 'yes, print slip' is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257 --- Comment #2 from Jonathan Druart --- Created attachment 96406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96406&action=edit Bug 24257: Fix close of modal on 'Yes, print slip' When a item-transfer-modal is prompted by returns.tt and the option "Yes, print slip" is selected the transfer is not initiated and the modal does not disappear. The print_slip hidden input must be in the same form as the submit/button .print, otherwise the browser logs this.form.print_slip is undefined Test plan: 1. set AutomaticItemReturn to "don't" 2. Check out an item and attempt to check it in at a branch it doesn't belong to. 3. When the popup modal appears select 'Yes, print slip'. => Observe that the transfer does initiate and the modal closes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:40:57 +0000 Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate transfer when 'yes, print slip' is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:50:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:50:36 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |20912 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 [Bug 20912] Rental fees based on time period -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:50:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:50:36 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24259 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:51:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:51:55 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:51:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:51:59 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 --- Comment #2 from Jonathan Druart --- Created attachment 96407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96407&action=edit Bug 24259: Handle non existing default circ rule in Charges::Fees Can't call method "lengthunit" on an undefined value at /usr/share/koha/lib/Koha/Charges/Fees.pm line 101. Test plan: 1 - Remove all/all rule form circulation rules 2 - Define a rental fee per day for an itemtype 3 - Checkout an item of this type ot patron 4 - Should get note of no circ rule defined 5 - Confirm the checkout => item is checked out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:53:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:53:03 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96407|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 96408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96408&action=edit Bug 24259: Handle non existing default circ rule in Charges::Fees Can't call method "lengthunit" on an undefined value at /usr/share/koha/lib/Koha/Charges/Fees.pm line 101. Test plan: 1 - Remove all/all rule form circulation rules 2 - Define a rental fee per day for an itemtype 3 - Checkout an item of this type ot patron 4 - Should get note of no circ rule defined 5 - Confirm the checkout => item is checked out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 10:55:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 09:55:56 +0000 Subject: [Koha-bugs] [Bug 24148] black magic in Circulation/Returns.t (mariadb:latest - 10.4.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|black magic in |black magic in |Circulation/Returns.t |Circulation/Returns.t | |(mariadb:latest - 10.4.11) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 11:02:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 10:02:05 +0000 Subject: [Koha-bugs] [Bug 24148] black magic in Circulation/Returns.t (mariadb:latest - 10.4.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart --- This has been fixed in our CI between run 7 (Dec 10) and 8 (Dec 11) I do no longer recreate in a docker container with stretch and MariaDB 10.4.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 11:04:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 10:04:19 +0000 Subject: [Koha-bugs] [Bug 24148] black magic in Circulation/Returns.t (mariadb:latest - < 10.4.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|black magic in |black magic in |Circulation/Returns.t |Circulation/Returns.t |(mariadb:latest - 10.4.11) |(mariadb:latest - < | |10.4.11) --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > This has been fixed in our CI between run 7 (Dec 10) and 8 (Dec 11) > > I do no longer recreate in a docker container with stretch and MariaDB > 10.4.11 Note that 10.4.11 has been released on Dec 11! https://mariadb.com/kb/en/library/mariadb-10411-release-notes/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 11:18:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 10:18:18 +0000 Subject: [Koha-bugs] [Bug 24166] Barcode removal breaks circulation.pl/moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 11:18:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 10:18:21 +0000 Subject: [Koha-bugs] [Bug 24166] Barcode removal breaks circulation.pl/moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24166 --- Comment #1 from Jonathan Druart --- Created attachment 96409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96409&action=edit Bug 24166: Do not hang when displaying checkout list if barcode is not set If a barcode is not set, there is a JS error in the log: TypeError: oObj.barcode is null We should not call escapeHtml() on it if not barcode is set for a given item. Test plan: Check an item out Remove its barcode Load the checkout list => Without this patch you get the "loading" popup and the table is never displayed => With this patch applied you see the checkout list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 11:50:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 10:50:03 +0000 Subject: [Koha-bugs] [Bug 24260] New: REST Self Registration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24260 Bug ID: 24260 Summary: REST Self Registration Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi Support self registration via REST API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 11:50:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 10:50:17 +0000 Subject: [Koha-bugs] [Bug 24260] REST Self Registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24260 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:05:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:05:40 +0000 Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a symbol after amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:05:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:05:43 +0000 Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a symbol after amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #2 from Jonathan Druart --- Created attachment 96410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96410&action=edit Bug 20352: DB changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:05:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:05:47 +0000 Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a symbol after amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #3 from Jonathan Druart --- Created attachment 96411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96411&action=edit Bug 20352: Schema changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:05:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:05:51 +0000 Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a symbol after amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #4 from Jonathan Druart --- Created attachment 96412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96412&action=edit Bug 20352: Add the ability to chose the position of the currency This patch mimicks what has been done for p_sep_by_space to add a space separation between the symbol and the value. Here we are adding p_cs_precedes to display the symbol before or after the value. Note that so far the symbol is only displayed in one place at the OPAC (opac-main) Test plan: - Create a manual invoice for a patron - Edit the active currency, select 'Before' (should be the default here) - Use the charged patron to login at the OPAC => On the mainpage you should see the charges displayed, with the symbol before the value - Edit the active currency, select 'After' => The symbol is now positionned after the value QA note: >From https://www.gnu.org/software/libc/manual/html_node/Currency-Symbol.html p_cs_precedes is only used for positive amount, n_cs_precedes should be used for negative. Here we are assuming that positive and negative amounts are displayed the same way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:06:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:06:16 +0000 Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a symbol after amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #5 from Jonathan Druart --- Just showing how easy it can be to make things configurable at currency level. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:06:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:06:58 +0000 Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a symbol after amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20353 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:06:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:06:58 +0000 Subject: [Koha-bugs] [Bug 20353] Get rid of CurrencyFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20353 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20352 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:24:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:24:08 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #197 from Jonathan Druart --- >From this commit 70651422a7517338a68e22321d9918757746ef33 Bug 14385: (QA follow-up) Additional changes and fixes @ Biblio.pm:1551 @ sub GetAuthorisedValueDesc { #---- branch if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "branches" ) { - return Koha::Libraries->find($value)->branchname; + my $branch = Koha::Libraries->find($value); + return $branch? $branch->branchname: q{}; } We are actually hiding a data inconsistency. I would recommend to revert that change and fix the failing test properly instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:35:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:35:25 +0000 Subject: [Koha-bugs] [Bug 24261] New: Google openID Authethication drops requested url Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24261 Bug ID: 24261 Summary: Google openID Authethication drops requested url Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: mihai.bojonca at tcmi.edu QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Hi everyone, i think this is a bug, we have setup access to catalog after login, we use 2 authentication methods, username and password or google openid, when a patron opens a direct link to an item and authenticates with username and password they get to the item itself however with openid they get redirected to the opac main page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:44:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:44:47 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > Tomas, Kelly, > > The script moveitem.pl requires editcatalogue => 'edit_items', the deletion > of a biblio editcatalogue => edit_catalogue. Even if weird I guess we could > have a librarian with edit_items but edit_catalogue. It is not that weird. It happens in academic institutions where there's central cataloguing and the rest of the branches just add their items. > I think we should show delete-biblio-btn if > CAN_user_editcatalogue_edit_catalogue. Good idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:46:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:46:14 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Kelly McElligott from comment #4) > Can the test plan be more simplistic for users? > > 1. Have a staff member with Edit Catalog permissions (Edit catalog (Modify > bibliographic/holdings data) (edit_catalogue)) and within the Edit Catalog > permissions, Edit Items. > > 2. Find a bib record with 1 item. > > 3. Attach that 1 item to another bib record. > > 4. Koha gives an error when staff tries to delete the record. > > 5. Apply patch > > 6. Go through steps 1-3. > > 7. Success. Staff can attach an item to a record and successfully delete > the itemless bib in the same step. Thanks for that, Kelly. Can you retest with Jonathan's follow-up? When submitting the signed patches to Bugzilla, please specify that it is 3 patches! (see the attachments block here) and don't forget to mark it Signed Off. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:46:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:46:51 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #11 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #8) > Note that the message is meaningless: "The record has X attached items" is > only displayed when X=0. Can you file a separate bug with that? I was dealing with wrong API permissions here! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 12:47:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 11:47:31 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 13:07:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 12:07:58 +0000 Subject: [Koha-bugs] [Bug 24166] Barcode removal breaks circulation.pl/moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24166 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 13:08:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 12:08:01 +0000 Subject: [Koha-bugs] [Bug 24166] Barcode removal breaks circulation.pl/moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24166 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96409|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 96413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96413&action=edit Bug 24166: Do not hang when displaying checkout list if barcode is not set If a barcode is not set, there is a JS error in the log: TypeError: oObj.barcode is null We should not call escapeHtml() on it if not barcode is set for a given item. Test plan: Check an item out Remove its barcode Load the checkout list => Without this patch you get the "loading" popup and the table is never displayed => With this patch applied you see the checkout list Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 13:30:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 12:30:22 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 --- Comment #9 from Martin Renvoize --- Thanks for the followup Jonathan.. I've been struggling to keep up the last few days. An interesting note about NULL vs ""... as you say, feels like that should be fixed at a lower level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 13:37:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 12:37:00 +0000 Subject: [Koha-bugs] [Bug 24262] New: Translate installer data in YAML format Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Bug ID: 24262 Summary: Translate installer data in YAML format Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr This complements Bug 13897, adding ability to translate YAML files in installer dirs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 13:37:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 12:37:49 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Depends on| |13897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 13:37:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 12:37:49 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 13:40:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 12:40:28 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96400|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 96414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96414&action=edit Bug 23442: Add account credit types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 13:40:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 12:40:31 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96401|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 96415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96415&action=edit Bug 23442: Add 'reduce' method to Koha::Account::Line This enhancement adds a 'reduce' method to Koha::Account::Line which can be used to reduce a charge/debit by adding a credit to offset against the amount outstanding. It may be used to apply a discount whilst retaining the original debit amounts or to apply a full or partial refund for example when a lost item is found and returned. The created credit will be immediately applied against the debit unless the debit has already been paid, in which case a 'zero' offset will be added to maintain a link to the debit but the outstanding credit will be left so it may be applied to other debts. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 13:40:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 12:40:34 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96402|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 96416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96416&action=edit Bug 23442: Add refund permission Add a new subpermission called 'refund' to the 'updatecharges' permission group which will allow/prevent refund actions to be performed by staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 13:40:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 12:40:37 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96403|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 96417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96417&action=edit Bug 23442: Add refund option to patron account page This enhancement adds a refined workflow to allow librarians to refund payments to patrons and record these refunds on the patrons account. The use case is that a patron has paid for something before then performing an action that may require some level of refund to be actioned. Perhaps they are returning a lost and paid for book. Test plan: 1) Undertake a series of transactions that result in a debit accountline being partially or fully paid off. 2) Note that a new 'Issue refund' button appears next to a debit (but only if your user has the refund permission or is a superlibrarian) 3) Click the 'Issue refund' button and a modal should appear pre-populated with the amount - amountoutstanding. 4) You should be able to edit the amount you wish to refund, record the refund or cancel. 5) Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 13:45:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 12:45:51 +0000 Subject: [Koha-bugs] [Bug 24166] Barcode removal breaks circulation.pl/moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:03:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:03:37 +0000 Subject: [Koha-bugs] [Bug 24263] New: borrowers.relationship should not contain an empty string Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Bug ID: 24263 Summary: borrowers.relationship should not contain an empty string Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org It should be set to NULL if not relationship exist. Otherwise the about page will display a warning about a missing/wrong relationship in data (that is not in the syspref) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:03:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:03:58 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24263 --- Comment #10 from Jonathan Druart --- (In reply to Martin Renvoize from comment #9) > An interesting note about NULL vs ""... as you say, feels like that should > be fixed at a lower level See bug 24263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:03:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:03:58 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24215 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:04:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:04:07 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:04:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:04:07 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24263 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 [Bug 24263] borrowers.relationship should not contain an empty string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:12:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:12:37 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:12:41 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #1 from Jonathan Druart --- Created attachment 96418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96418&action=edit Bug 24263: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:12:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:12:44 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #2 from Jonathan Druart --- Created attachment 96419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96419&action=edit Bug 24263: DB changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:12:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:12:47 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #3 from Jonathan Druart --- Created attachment 96420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96420&action=edit Bug 24263: Replace borrowers.relationship with NULL when was empty string When you create a new patron, its relationship field is populated with an empty string when we are expecting NULL. Otherwise the about page will display a warning about a missing/wrong relationship in data (that is not in the syspref) Test plan: 0/ Do not apply the patches from this bug report 1/ Create a new patron (child) 2/ Notice that relationship column in DB is set to an empty string 3/ Go to the about page, notice the invalid warning about relationship values not in the syspref 4/ Apply DB changes and tests 5/ Execute the update DB entry => The value in DB is now NULL when was "" 6/ Execute the tests => It fails 7/ Apply the last patch 8/ Add and edit a patron (child) => relationship is set to NULL in DB 9/ Execute the tests => They pass! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:13:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:13:12 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24215 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24215 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 [Bug 24215] Warnings about guarantor relationships show ARRAY errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:13:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:13:12 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24263 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24263 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 [Bug 24263] borrowers.relationship should not contain an empty string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:13:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:13:46 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #4 from Jonathan Druart --- Upping severity, it should follow the integration of bug 24215 in stable branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:34:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:34:47 +0000 Subject: [Koha-bugs] [Bug 24238] GET /biblios does not default to accept:application/json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24238 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|NEW |In Discussion --- Comment #1 from Tomás Cohen Arazi --- I've been thinking o trying to make the default be HTML using the current TT for detailed view. That's why I left it like that. Otherwise people would start using it without setting the Accept header and it would be a breaking change. But you are right the other ones don't require. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:41:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:41:22 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #19 from Jonathan Druart --- Nick, tests are failing on 18.11.x t/Koha/SearchEngine/Elasticsearch.t .. 3/4 # Looks like you planned 51 tests but ran 10. # Failed test 'Koha::SearchEngine::Elasticsearch::marc_records_to_documents () tests' # at t/Koha/SearchEngine/Elasticsearch.t line 518. Not a HASH reference at t/Koha/SearchEngine/Elasticsearch.t line 335. # Looks like your test exited with 255 just after 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:43:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:43:25 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 --- Comment #20 from Jonathan Druart --- This patchset has been pushed to 19.05.05 and 18.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:48:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:48:30 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #28 from Bernardo Gonzalez Kriegel --- Jonathan, thanks to change Bug description, planned to do it today :) (In reply to Jonathan Druart from comment #26) > I am all good with it, we could improve (performance) later (like one INSERT > per file) if needed. Ok > Another improvement would be to move the .txt file into the YAML. I thought about that too, which would allow it to be translated as well. I will add the content in a description field. > I would like to see the translator tool ready before we push this one. Did > you investigate already the work that needs to be done? Yes... for xml :) I will work on this in Bug 24262 > I think we should move the already translated strings into a new .po (one > .po for all installer files?) I agree, perhaps 'xx-YY-installer.po' for common files, and append marcflavor content for MARC21/UNIMARC/NORMARC to existing files, or add new ones. > I can have a look if you did not already, but prefer to avoid duplication of > work :) Thanks! I'll try to solve this and let you know. Now some questions: 1) Bug 22824 - This patch can work indistinctly with YAML, YAML::Syck or YAML::XS, no problem with that. 2) YAML format: I'm using --- table: translatable: { A: 1 } rows: - A: 1 B: 2 - A: 3 B: 4 With this format we have only one table per file, and all rows must have the same number of values ( required by prepare($query) ) If we define things like --- - firstTable: translatable: { A: 1 } rows: - A1: 1 B1: 2 - A2: 1 B2: 2 - firstTable: translatable: { A: 1 } rows: - A: 1 B: 2 C: 3 - A: 4 B: 5 C: 6 - secondTable: translatable: { G: 1 } rows: - F: 1 G: 2 - F: 3 G: 4 we can have entries for the same table with different number of values, and also entries for different tables inserted in order. (BTW, of current installer sql files: 30 just one table, 9 more than one table; common+en files ) A change in format needs a simple revision of the code, but I would like some opinions about the format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:48:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:48:38 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #11 from Tomás Cohen Arazi --- (In reply to Sally from comment #10) > (In reply to Tomás Cohen Arazi from comment #9) > > (In reply to Sally from comment #7) > > > I've just seen: > > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 - do those > > > changes resolve this bug? > > > > That one only deals with priority. Question: what permissions would you > > require for changing the pickup location? Don't think in terms of the > > current UI, maybe we can add modify_holds_pickup_location for example. > > Ah, thanks Tomas - yes, a new modify_holds_pickup_location would work for > us. > > The key part for us is separating the permissions between modifying the > pickup location and modifying the hold priority, so that suggestion works. Thinking of an upgrade path, would you agree users with modify_holds_priority should inherit the new modify_holds_pickup_location permission? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:52:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:52:11 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #43 from Jonathan Druart --- Why $class->_resultset->search instead of $self->search? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:55:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:55:08 +0000 Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 --- Comment #27 from Joonas Kylmälä --- I will start reworking the patches so that they show more clearly the logical differences between SIP and SCO checkout and that the code is the all in the CanBookBeIssued subroutine but now it can be just controlled with parameters. This way the deprecation discussion can be had separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 14:55:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 13:55:57 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #44 from Jonathan Druart --- Also, I find Koha::Item::LastPatrons->anonymise_items_last_borrower quite hard to read (its name, not its content) and guess what is suppose to do the method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:00:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:00:51 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #45 from Jonathan Druart --- Basically I do not think this table deserves its own modules. We could handle that from Koha::Patron I'd say. I guess it's late now as it's PQA. Letting RM decide. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:09:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:09:10 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #29 from Jonathan Druart --- What about the following structure: table_name: translatable: [ A, B ] fields [ A, B, C, D ] rows: - A: 1 B: 2 - A: 1 C: 2 D: 4 - A: 5 - B: 6 - C: 7 - D: 8 I do not think we should force to have the same number of fields. What if you want the default value for instance? That's not a big deal but I would prefer to get rid of this limitation since the beginning :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:11:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:11:46 +0000 Subject: [Koha-bugs] [Bug 24264] New: Cannot search for genre/form authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Bug ID: 24264 Summary: Cannot search for genre/form authorities Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com When search with an authtype in ES we are using the term filter to limit to a type. This filter is analyzed and the forward slash in genre/form seems to be problematic bug 20589 fixed this incidentally to other changes, however, 19.05 still has this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:12:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:12:11 +0000 Subject: [Koha-bugs] [Bug 24264] Elasticsearch - Cannot search for genre/form authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot search for |Elasticsearch - Cannot |genre/form authorities |search for genre/form | |authorities Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:14:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:14:53 +0000 Subject: [Koha-bugs] [Bug 24264] Elasticsearch - Cannot search for genre/form authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:14:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:14:56 +0000 Subject: [Koha-bugs] [Bug 24264] Elasticsearch - Cannot search for genre/form authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 --- Comment #1 from Nick Clemens --- Created attachment 96421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96421&action=edit Bug 24264: Use raw field when limiting by authtype To test: 1 - Have a genre form record in your authorities file 2 - Search authorities for 'Default' 3 - The result is returned 4 - Set the dropdown to 'Genre/Form' and search matchign term 5 - No results 6 - Apply patch 7 - Restart all the things 8 - Repeat search for 'Genre/Form' and search matching term 9 - Record is returned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:22:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:22:26 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:22:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:22:50 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:39:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:39:45 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #21 from Lucas Gass --- This is not in 19.05.05. It has been backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:39:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:39:51 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #46 from Agustín Moyano --- (In reply to Jonathan Druart from comment #43) > Why $class->_resultset->search instead of $self->search? I believe that's a question only you can reply (bug 16966 - https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60705&action=diff#a/Koha/Patrons.pm_sec1) ;P on a firt attempt, I copied what search_patron_to_anonymize does, but then in follow-up removed it from Patrons and placed it in LastPatrons without $class->_resultset->search. Cheers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:39:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:39:56 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:46:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:46:06 +0000 Subject: [Koha-bugs] [Bug 24265] New: Create a cron job to delete Label Batches after time period Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24265 Bug ID: 24265 Summary: Create a cron job to delete Label Batches after time period Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Label batches can be deleted manually, but it would also be helpful if the batches could be cleaned up automatically after X days- possibly through a cron job. Currently, there is not a way to bulk delete label batches, see bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 15:57:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 14:57:45 +0000 Subject: [Koha-bugs] [Bug 24266] New: Noisy error in reconcile_balances.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 Bug ID: 24266 Summary: Noisy error in reconcile_balances.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Cron $KOHA_CRON_PATH/reconcile_balances.pl --verbose Gives this message when run: SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: SQL::Abstract before v1.75 used to generate incorrect SQL when the -IN operator was given an undef-containing list: !!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based version of SQL::Abstract will emit the logically correct SQL instead of raising this exception) at /usr/share/koha/lib/Koha/Objects.pm line 209 It would be nice if this wouldn't happen, so that cron doesn't send mails about this error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:01:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:01:10 +0000 Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate transfer when 'yes, print slip' is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:01:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:01:12 +0000 Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate transfer when 'yes, print slip' is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96406|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 96422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96422&action=edit Bug 24257: Fix close of modal on 'Yes, print slip' When a item-transfer-modal is prompted by returns.tt and the option "Yes, print slip" is selected the transfer is not initiated and the modal does not disappear. The print_slip hidden input must be in the same form as the submit/button .print, otherwise the browser logs this.form.print_slip is undefined Test plan: 1. set AutomaticItemReturn to "don't" 2. Check out an item and attempt to check it in at a branch it doesn't belong to. 3. When the popup modal appears select 'Yes, print slip'. => Observe that the transfer does initiate and the modal closes Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:01:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:01:53 +0000 Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate transfer when 'yes, print slip' is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257 --- Comment #4 from Lucas Gass --- Thank you for the quick patch Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:02:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:02:13 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 --- Comment #22 from Nick Clemens --- Created attachment 96423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96423&action=edit Bug 23089: [18.11.x] fix tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:12:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:12:39 +0000 Subject: [Koha-bugs] [Bug 22273] Column article_requests.created_on should not be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:12:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:12:42 +0000 Subject: [Koha-bugs] [Bug 22273] Column article_requests.created_on should not be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273 --- Comment #1 from Marcel de Rooy --- Created attachment 96424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96424&action=edit Bug 22273: Replace typo opan by opac in POD Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:12:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:12:47 +0000 Subject: [Koha-bugs] [Bug 22273] Column article_requests.created_on should not be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273 --- Comment #2 from Marcel de Rooy --- Created attachment 96425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96425&action=edit Bug 22273: Database revision for table article_requests Column created_on should not be updated. It is filled once by the store method of Koha::ArticleRequest. Column updated_on should be a timestamp, updated by the database. Note: Although higher versions of MySQL and MariaDB support two timestamps (NOT NULL) in one table, I kept on the safe side by allowing NULL on the created_on column. @RM: Don't forget to run DBIx update. Test plan: Run new install or upgrade. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:12:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:12:51 +0000 Subject: [Koha-bugs] [Bug 22273] Column article_requests.created_on should not be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273 --- Comment #3 from Marcel de Rooy --- Created attachment 96426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96426&action=edit Bug 22273: Modify Koha::ArticleRequest->store to fill created_on For a new record, store should fill created_on. The database will always update the timestamp updated_on. Since open also calls SUPER::store, we do not need to call it twice. Test plan: [1] Run t/db_dependent/ArticleRequests.t [2] In the interface, add two article requests. Change the status of one to PROCESSING. Check created_on and updated_on in the article_requests table. The changed request should have updated_on > created_on. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:13:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:13:04 +0000 Subject: [Koha-bugs] [Bug 22273] Column article_requests.created_on should not be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22273 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:40:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:40:19 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #30 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #29) > What about the following structure: > ... > > I do not think we should force to have the same number of fields. What if > you want the default value for instance? That's not a big deal but I would > prefer to get rid of this limitation since the beginning :) Maybe I'm wrong but to do that we'll need to do a prepare/execute for each row, because we won't know which columns are necessary; and this could be slower ( https://docstore.mik.ua/orelly/linux/dbi/ch05_05.htm ) Columns must be absent on insert statement for them to use default values. It'll be equivalent to a $dbh->do() for each row. Or we can fill missing values with empty/NULL my @values = map { $row->{$_} ? $row->{$_} : NULL } @columns; for example, if we are going to use all column names in one prepare(). (do not like this) What about entries for many tables in a file? Note: I like your idea, simply don't know how to solve it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:50:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:50:36 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target, | |RM_priority -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 16:59:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 15:59:16 +0000 Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt increase the original quantity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667 Diane Westerfield changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 CC| |diane.westerfield at coloradoc | |ollege.edu Hardware|All |PC Version|unspecified |19.05 --- Comment #1 from Diane Westerfield --- Have run into this bug when I accidentally received the same title twice on one invoice, then tried to cancel/unreceive the duplicate. Very frustrating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:02:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:02:55 +0000 Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt increase the original quantity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667 --- Comment #2 from Diane Westerfield --- Created attachment 96427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96427&action=edit Example -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:06:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:06:30 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:06:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:06:32 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 --- Comment #26 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:06:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:06:34 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:06:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:06:36 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:08:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:08:49 +0000 Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:08:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:08:49 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 [Bug 24208] Remove change calculation for writeoffs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:19:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:19:52 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96266|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 96428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96428&action=edit Bug 24150: Add Koha::Old::*[s] This bug report will add new classes for: * Koha::Old::Patron[s] * Koha::Old::Biblio[s] * Koha::Old::Item[s] * Koha::Old::Biblioitem[s] Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:20:10 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #96268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:20:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:20:18 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96267|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:20:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:20:30 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Squashed and Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:22:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:22:28 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96270|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 96429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96429&action=edit Bug 21684: Add tests to show some of the discrepancies Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:22:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:22:31 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96271|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 96430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96430&action=edit Bug 21684: Fix delete methods and add more tests Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:22:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:22:34 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96272|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 96431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96431&action=edit Bug 21684: Adjust some tests Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:23:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:23:00 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize --- Thanks Jonathan, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:23:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:23:06 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:48:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:48:52 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88395|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:49:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:49:06 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88396|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:49:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:49:22 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88397|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:49:44 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88398|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:49:58 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88399|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:50:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:50:11 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88400|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:54:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:54:41 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 17:54:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 16:54:45 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #176 from Bin Wen --- Created attachment 96432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96432&action=edit Bug 11879 - Add a new field to patron record: main contact method Fixed the problem mentioned above. Test plan is same as before: 0) Apply patch 1) updatedatabase.pl 2) In the staff client, edit a patron's contact info. There should be a new dropdown select to choose the main contact method 3) In the opac page, edit the personal details.There should be a new dropdown select to choose the main contact method. 4) Save the form. It should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:07:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:07:54 +0000 Subject: [Koha-bugs] [Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22566 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 [Bug 22566] Stock rotation cronjob reporting has issues -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:07:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:07:54 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23432 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432 [Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:13:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:13:01 +0000 Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt increase the original quantity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:13:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:13:04 +0000 Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt increase the original quantity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667 --- Comment #3 from Jonathan Druart --- Created attachment 96433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96433&action=edit Bug 17667: Do not modify quantity of the original standing order when a receipt is cancelled When cancelling a receipt, the quantity of the original order is increased. Test plan: Create a basket, mark is as "standing orders" Create an order receive it cancel the receipt => Without this patch the quantity of the original order is 2 => With this patch applied the quantity it always 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:14:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:14:35 +0000 Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt increase the original quantity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Severity|normal |major Version|19.05 |master --- Comment #4 from Jonathan Druart --- It surprises me that this bug did not get attention earlier. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:32:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:32:21 +0000 Subject: [Koha-bugs] [Bug 24265] Create a cron job to delete Label Batches after time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24265 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- Seems like something that would make sense to work into cleanup_database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:32:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:32:54 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96388|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes --- Created attachment 96434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96434&action=edit Bug 24232: Regression tests This patch enhances the tests for the DELETE /biblios/:biblio_id endpoint so more fine grained permissions are tested. It highlights the fact that the required permissions defined on the spec are not correcttly defined. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail because the user (that now has subpermissions only) does not have enough permissions for a non-existent subpermission Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:32:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:32:56 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96393|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes --- Created attachment 96435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96435&action=edit Bug 24232: Fix required permissions in DELETE /biblios/:biblio_id This patch fixes the required permissions defined on the spec for the mentioned endpoint. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail due to badly defined permissions 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Notice parameters: edit_catelogue didn't exist 5. Sign off :-D Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:32:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:32:58 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96398|0 |1 is obsolete| | --- Comment #14 from ByWater Sandboxes --- Created attachment 96436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96436&action=edit Bug 24232: Hide the "Delete biblio" if permission edit_catalogue not set The script moveitem.pl requires editcatalogue => 'edit_items', the deletion of a biblio editcatalogue => edit_catalogue. Even if weird I guess we could have a librarian with edit_items but edit_catalogue. Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:35:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:35:27 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #15 from Kelly McElligott --- Permissions: If staff member has Edit Catalog and Edit Items, this process can be done. If a staff member has Edit Items but not Edit Catalog, they can still attach the item, however the option to delete is not given. If a staff member has only Edit Catalog (and not Edit Items), the option is not there to Attach an Item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:55:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:55:44 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:56:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:56:53 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94483|0 |1 is obsolete| | Attachment #94484|0 |1 is obsolete| | Attachment #94485|0 |1 is obsolete| | Attachment #94486|0 |1 is obsolete| | Attachment #94487|0 |1 is obsolete| | Attachment #94488|0 |1 is obsolete| | Attachment #94489|0 |1 is obsolete| | Attachment #94490|0 |1 is obsolete| | Attachment #94491|0 |1 is obsolete| | Attachment #94492|0 |1 is obsolete| | Attachment #94493|0 |1 is obsolete| | Attachment #94494|0 |1 is obsolete| | Attachment #94495|0 |1 is obsolete| | --- Comment #258 from Agustín Moyano --- Created attachment 96437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96437&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:57:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:57:05 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #259 from Agustín Moyano --- Created attachment 96438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96438&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:57:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:57:17 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #260 from Agustín Moyano --- Created attachment 96439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96439&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:57:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:57:30 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #261 from Agustín Moyano --- Created attachment 96440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96440&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:57:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:57:42 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #262 from Agustín Moyano --- Created attachment 96441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96441&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:57:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:57:53 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #263 from Agustín Moyano --- Created attachment 96442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96442&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:58:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:58:03 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #264 from Agustín Moyano --- Created attachment 96443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96443&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:58:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:58:17 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #265 from Agustín Moyano --- Created attachment 96444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96444&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:58:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:58:26 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #266 from Agustín Moyano --- Created attachment 96445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96445&action=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:58:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:58:35 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #267 from Agustín Moyano --- Created attachment 96446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96446&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 15496 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 18936 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:58:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:58:45 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #268 from Agustín Moyano --- Created attachment 96447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96447&action=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:58:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:58:55 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #269 from Agustín Moyano --- Created attachment 96448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96448&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix tests Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typo in request.tt Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Filter pickup on specific item click Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:59:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:59:03 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #270 from Agustín Moyano --- Created attachment 96449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96449&action=edit Bug 22284: (Do not push) Schema update Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 18:59:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 17:59:12 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #271 from Agustín Moyano --- Created attachment 96450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96450&action=edit Bug 22284: (follow-up) Anotate boolean values in Koha::Schema::Result::LibraryGroup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:09:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:09:02 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:09:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:09:06 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96346|0 |1 is obsolete| | Attachment #96392|0 |1 is obsolete| | --- Comment #11 from Agustín Moyano --- Created attachment 96451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96451&action=edit Bug 23673: change db structure Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:09:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:09:10 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #12 from Agustín Moyano --- Created attachment 96452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96452&action=edit Bug 23673: Add "Time status changed" column to patron's notices This patch adds "Time status changed" column to patron's notices tab. It also adds logic to C4::Letters to update time_status_changed column when status is changed, and leaves time_queued with message creation time. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Time status changed" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" and no "time status changed" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "time status changed" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and time status changed updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:12:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:12:10 +0000 Subject: [Koha-bugs] [Bug 24267] New: C4::Breeding::ImportBreedingAuth is ineffective Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Bug ID: 24267 Summary: C4::Breeding::ImportBreedingAuth is ineffective Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org git grep ImportBreedingAuth - there is only one call to this routine from SearchZ3950Auth We pass it a MARC record, '2' for overwrite_auth We then check for this record in the DB and get the breeding id, however, when overwrite_auth is 2 we always add the auth to the batch and return the new breeding id. We don't actually use any of the other parameters returned here either To recreate: 1 - Browse to Authorities 2 - Select New form Z3950 3 - Perform a search that returns results 4 - SELECT COUNT(*) FROM import_auths 5 - Repeat the search 6 - SELECT COUNT(*) FROM import_auths 7 - There are 20 more records 8 - SELECT * FROM import_auths - note the repeated rows -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:12:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:12:33 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:27:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:27:52 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:27:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:27:54 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #1 from Nick Clemens --- Created attachment 96453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96453&action=edit Bug 24267: Improve ImportBreedingAuth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:29:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:29:17 +0000 Subject: [Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 --- Comment #1 from Cori Lynn Arnold --- Created attachment 96454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96454&action=edit Bug 24173: Advanced Editor: Show subtitle & published date on the search page To test: Prior to patch: 1/Verify that EnableAdvancedCatalogingEditor syspref is set to "enable" 2/Go to Cataloging 3/Click on "Advanced Editor" button 4/In left hand box put "specious" under Keywords and hit "enter" 5/verify that "Library of Congress" (or some other server) Z39.50 is checked 6/Verify that there are no headings for "Subtitle" and "Published" Apply Patch 1/Go to Administration->Koha to MARC mapping 2/Add or verify that there are entries for "biblio.subtitle" and "biblio.copyrightdate" 3/Go to Cataloging 4/Click on "Advanced Editor" button 5/In left hand box put "specious" under Keywords and hit "enter" 6/verify that "Library of Congress" (or some other server) Z39.50 is checked 7/Verify that there are headings for "Subtitle" and "Published" and the data matches with the fields from Koha to MARC mapping when you click on "View MARC" link for that record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:31:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:31:25 +0000 Subject: [Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Cori Lynn Arnold --- Patch adds "Subtitle" and "Published" (date) field to the Advanced Editor search overlay. To test: Prior to patch: 1/Verify that EnableAdvancedCatalogingEditor syspref is set to "enable" 2/Go to Cataloging 3/Click on "Advanced Editor" button 4/In left hand box put "specious" under Keywords and hit "enter" 5/verify that "Library of Congress" (or some other server) Z39.50 is checked 6/Verify that there are no headings for "Subtitle" and "Published" Apply Patch 1/Go to Administration->Koha to MARC mapping 2/Add or verify that there are entries for "biblio.subtitle" and "biblio.copyrightdate" 3/Go to Cataloging 4/Click on "Advanced Editor" button 5/In left hand box put "specious" under Keywords and hit "enter" 6/verify that "Library of Congress" (or some other server) Z39.50 is checked 7/Verify that there are headings for "Subtitle" and "Published" and the data matches with the fields from Koha to MARC mapping when you click on "View MARC" link for that record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:33:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:33:55 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:33:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:33:59 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96434|0 |1 is obsolete| | Attachment #96435|0 |1 is obsolete| | Attachment #96436|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 96455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96455&action=edit Bug 24232: Regression tests This patch enhances the tests for the DELETE /biblios/:biblio_id endpoint so more fine grained permissions are tested. It highlights the fact that the required permissions defined on the spec are not correcttly defined. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail because the user (that now has subpermissions only) does not have enough permissions for a non-existent subpermission Signed-off-by: Kelly McElligott Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:34:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:34:02 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #17 from Jonathan Druart --- Created attachment 96456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96456&action=edit Bug 24232: Fix required permissions in DELETE /biblios/:biblio_id This patch fixes the required permissions defined on the spec for the mentioned endpoint. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail due to badly defined permissions 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Notice parameters: edit_catelogue didn't exist 5. Sign off :-D Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:34:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:34:06 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #18 from Jonathan Druart --- Created attachment 96457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96457&action=edit Bug 24232: Hide the "Delete biblio" if permission edit_catalogue not set The script moveitem.pl requires editcatalogue => 'edit_items', the deletion of a biblio editcatalogue => edit_catalogue. Even if weird I guess we could have a librarian with edit_items but edit_catalogue. Signed-off-by: Kelly McElligott Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:39:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:39:47 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_21667=5D_Advanced_Editor_-_advanced?= =?utf-8?q?_search_-_result_set_is_lost_after_repeated_clicks_on_=E2=80=9C?= =?utf-8?q?next=E2=80=9D_button?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21667 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #1 from Cori Lynn Arnold --- Verified this is still happening, and consistently on the second pressing of "Next" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:52:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:52:31 +0000 Subject: [Koha-bugs] [Bug 24268] New: advance_notices.pl dies on undefined letter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Bug ID: 24268 Summary: advance_notices.pl dies on undefined letter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 20478 changed the assignment/warn in advance_notices - it seems that new we either assign a letter, or the value of the warn (1) to the letter. This causes: Can't use string ("1") as a HASH ref while "strict refs" in use at advance_notices.pl line 589. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:53:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:53:35 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 --- Comment #1 from Nick Clemens --- Created attachment 96458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96458&action=edit Bug 24268: Break assignment and warn into separate actions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:54:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:54:28 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20478 CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 [Bug 20478] Advance notices: send separate digest messages per branch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:54:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:54:28 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 [Bug 24268] advance_notices.pl dies on undefined letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:55:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:55:34 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 --- Comment #2 from Nick Clemens --- This should probably be covered by tests, shoudl be able to recreate the situation by having a patron request messages in a transport not defined in a digest message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 19:58:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 18:58:18 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle at bywatersolutions.c | |om, | |liz at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 20:02:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 19:02:42 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 20:02:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 19:02:44 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 --- Comment #3 from Nick Clemens --- Created attachment 96459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96459&action=edit Bug 24268: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 20:37:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 19:37:10 +0000 Subject: [Koha-bugs] [Bug 11858] RFID for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 20:38:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 19:38:26 +0000 Subject: [Koha-bugs] [Bug 7999] Send test notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7999 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 20:39:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 19:39:23 +0000 Subject: [Koha-bugs] [Bug 21309] Enforce password change on login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21309 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 20:39:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 19:39:59 +0000 Subject: [Koha-bugs] [Bug 24269] New: Authority matching in Elasticsearch is broken when authority has subdivisions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Bug ID: 24269 Summary: Authority matching in Elasticsearch is broken when authority has subdivisions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com In C4/Heading/MARC21.pm when we call _get_search_heading we look at the heading and turn some subfields into terms so: 150 $aChess$xOpenings becomes 'Chess generalsubdiv openings' 126 my %subdivisions = ( 127 'v' => 'formsubdiv', 128 'x' => 'generalsubdiv', 129 'y' => 'chronologicalsubdiv', 130 'z' => 'geographicsubdiv', 131 ); 267 $heading .= " $subdivisions{$code} $value"; We don't do this when indexing into ES so we will never find matches for these records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 20:40:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 19:40:32 +0000 Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com, | |ere.maijala at helsinki.fi, | |glasklas at gmail.com, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 20:47:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 19:47:53 +0000 Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 21:01:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 20:01:56 +0000 Subject: [Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- CC| |mkstephens at lancasterseminar | |y.edu Status|RESOLVED |REOPENED --- Comment #15 from Myka Kennedy Stephens --- I have noticed a typo that I think is related to this bug. In course reserves, when a course is inactive, the normal item type is lacking a closing parentheses in the item table. To Test: 1) Create a course in course reserves, make it inactive 2) Add an item to it, changing item type and location 3) Note that the normal item type is in bold with an opening parentheses but no closing parentheses; Note that the normal location is in bold with both opening and closing parentheses. 4) Make the course active 5) Note that the normal item type is no longer bold and has both opening and closing parentheses; Note that the normal location is also not bold and has both opening and closing parentheses. Please fix to add closing parentheses to the normal item type when a course is inactive. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 21:03:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 20:03:57 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96354|0 |1 is obsolete| | --- Comment #7 from Andrew Nugged --- Created attachment 96460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96460&action=edit Bug 24185: Make holds page faster - improved "if" `$can_item_be_reserved eq 'OK'` moved in `&&` before `IsAvailableForItemLevelRequest` to cut away with static known values before calling to more resource consuming subroutine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 21:04:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 20:04:13 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 --- Comment #8 from Andrew Nugged --- Created attachment 96461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96461&action=edit Bug 24185: Make holds page faster - call to subroutine moved below "if" `$on_shelf_holds` was assigned before "return .. if" but not used in that code piece, so sometimes it was useless. Moved assignment after "return .. if". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 21:22:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 20:22:44 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 21:22:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 20:22:47 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96458|0 |1 is obsolete| | --- Comment #4 from Liz Rea --- Created attachment 96462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96462&action=edit Bug 24268: Break assignment and warn into separate actions Signed-off-by: Liz Rea -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 21:22:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 20:22:58 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96459|0 |1 is obsolete| | --- Comment #5 from Liz Rea --- Created attachment 96463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96463&action=edit Bug 24268: Unit tests Signed-off-by: Liz Rea -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 21:40:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 20:40:24 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry --- Hi all! Giving this old bug a bump. I talk to lots of libraries that would like to be able to define something like "050ab, 090ab" so that Koha will first check the 050 and use that call number if present, but, if no 050 is found, will then check the 090 and use that call number instead. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 21:41:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 20:41:15 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 21:43:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 20:43:14 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 21:47:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 20:47:33 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 --- Comment #9 from Andrew Nugged --- Created attachment 96464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96464&action=edit Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all unavailable' When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest" called many times with hundred of items and "on shelf holds" parameter set to "If all unavailable" for these items + patron, it goes slow. It happens because in subloop there is checking if all items available so it is O(n^2) and it re-checks each time the same info for each item with repeating DB/data requests. Fix: The inner loop 1:1 picked out from another loop and put before that items processing loop, 'items_any_available' variable precalculated, this variable passed to IsAvailableForItemLevelRequest to be used inside as the precalculated result. On tests it gave a drastic improvement in execution time. How to reproduce: 1) on freshly installed kohadevbox create/import one book, remember that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up a single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", that rule should match above book items/library/patron, check that rule to have a non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create a direct link by yourself, for example, in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time on old code, densely increasing for every hundred items added. In the case of this solution, it's fast, and time increases a little only, linear. I tested on my computer in VirtualBox for page generation times, did 3-5 runs for same case to check if results are stable, and got such values: (old code): 100 items: 38 seconds 200 items: 2.5 minutes 300 items: 5.4 minutes (version with fix): 100 items: 3.7 seconds 200 items: 6.4 seconds 300 items: 8.7 seconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 22:03:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 21:03:43 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com --- Comment #6 from Jessie Zairo --- I can confirm, this is something we get requests from libraries pretty frequently. This would be a helpful enhancement to be able to define multiple call numbers to check. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 22:30:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 21:30:35 +0000 Subject: [Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665 --- Comment #3 from Cori Lynn Arnold --- Created attachment 96465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96465&action=edit Bug 21665: Advanced editor - double clicking on value brings subfield code as well To test, apply patch: 0/Verify that the advanced editor is enabled by going to "Administration" and searching for "EnableAdvancedCatalogingEditor" 1/Set it to "Enable" if it isn't already. 2/Go to "Cataloging", click on "Advanced editor" 3/Search for a record by entering "specious" in the keyword box and hitting enter 4/Click "import" on a record 5/For any subfield (maybe specifically the text in an 020 field) double click on the text 6/Hit CNTRL-V into your favorite text editor, verify that the subfield code was not pasted with the text from the subfield. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 22:31:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 21:31:26 +0000 Subject: [Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Cori Lynn Arnold --- To test, apply patch: 0/Verify that the advanced editor is enabled by going to "Administration" and searching for "EnableAdvancedCatalogingEditor" 1/Set it to "Enable" if it isn't already. 2/Go to "Cataloging", click on "Advanced editor" 3/Search for a record by entering "specious" in the keyword box and hitting enter 4/Click "import" on a record 5/For any subfield (maybe specifically the text in an 020 field) double click on the text 6/Hit CNTRL-V into your favorite text editor, verify that the subfield code was not pasted with the text from the subfield. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 22:39:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 21:39:22 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #23 from Hayley Mapley --- This patchset has not been pushed to 18.11.11, rather it has been pushed to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 23:10:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 22:10:21 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #12 from Katrin Fischer --- > Thinking of an upgrade path, would you agree users with > modify_holds_priority should inherit the new modify_holds_pickup_location > permission? I think I would even make it simpler and use reserve_for_others or place_holds. As Kyle wrote it's already possible to change the pickup location without the modify_holds_priority permission - just from another page. The API way to do things was added later - so people have probably been doing the other way for a long time with the lower permission. Short: I'd match what the holds page for the record has. And if we add a new permission we should probably change it there as well? comment#0 >A librarian can update a hold's pickup library from the record details page, >but not from the patron details or checkout pages unless he or she has the >"modify_holds_priority". If the librarian does not, an error is displayed >instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 18 23:31:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 22:31:33 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 davidm at ranchomiragelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |davidm at ranchomiragelibrary. | |org --- Comment #16 from davidm at ranchomiragelibrary.org --- We have recently started receiving complaints about the individual emails for auto-renewals. It would be great to see this development happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 00:34:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 23:34:50 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #17 from Tomás Cohen Arazi --- (In reply to David Murguia from comment #16) > We have recently started receiving complaints about the individual emails > for auto-renewals. It would be great to see this development happen. It would help if you tested it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 00:47:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Dec 2019 23:47:57 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #31 from David Cook --- Couldn't we just use the DEFAULT keyword to specify a default value? (I haven't tried it so just a suggestion.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 01:39:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 00:39:04 +0000 Subject: [Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 01:39:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 00:39:06 +0000 Subject: [Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96454|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 96466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96466&action=edit Bug 24173: Advanced Editor: Show subtitle & published date on the search page To test: Prior to patch: 1/Verify that EnableAdvancedCatalogingEditor syspref is set to "enable" 2/Go to Cataloging 3/Click on "Advanced Editor" button 4/In left hand box put "specious" under Keywords and hit "enter" 5/verify that "Library of Congress" (or some other server) Z39.50 is checked 6/Verify that there are no headings for "Subtitle" and "Published" Apply Patch 1/Go to Administration->Koha to MARC mapping 2/Add or verify that there are entries for "biblio.subtitle" and "biblio.copyrightdate" 3/Go to Cataloging 4/Click on "Advanced Editor" button 5/In left hand box put "specious" under Keywords and hit "enter" 6/verify that "Library of Congress" (or some other server) Z39.50 is checked 7/Verify that there are headings for "Subtitle" and "Published" and the data matches with the fields from Koha to MARC mapping when you click on "View MARC" link for that record. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 01:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 00:49:13 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #6 from Owen Leonard --- (In reply to Jonathan Druart from comment #5) > Owen, does not it sound more correct to copy the CSS definitions? It would be more correct, but I think the satisfaction of being technically correct would be outweighed by the effort. I think a pragmatic fix is better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 02:16:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 01:16:39 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #9 from Owen Leonard --- I notice the choices offered under "Default sort order" include columns which are configured in the individual DataTable configuration to be unsortable. I wonder if we need to move those settings into columns_settings.yml too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 04:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 03:20:05 +0000 Subject: [Koha-bugs] [Bug 24272] New: Add a command line script to compare the syspref cache to the database Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272 Bug ID: 24272 Summary: Add a command line script to compare the syspref cache to the database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: nick at bywatersolutions.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 04:20:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 03:20:55 +0000 Subject: [Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 04:20:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 03:20:58 +0000 Subject: [Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272 --- Comment #1 from Nick Clemens --- Created attachment 96467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96467&action=edit Bug 24272: add check_sysprefs_cache.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 05:15:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 04:15:39 +0000 Subject: [Koha-bugs] [Bug 24273] New: It is possible to incorporate IIIF compatibility in Koha Bibliographic catalog Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24273 Bug ID: 24273 Summary: It is possible to incorporate IIIF compatibility in Koha Bibliographic catalog Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: urrape at gmail.com QA Contact: testopia at bugs.koha-community.org IIIF is becoming a "de facto" standard for image interoperability. Many libraries and other institutions are aligning to the IIIF framework for image visualization. It will very usefull If we can incorporate to the OPAC bibliographic record, the visualization of images representing the documents using IIIF manifests or using images served in IIIF compatible image servers. Today you can upload images linked to bibliographic records and you can visualize those images as part of the bibliographic record detailed view. With IIIF compatibility, that option can be very open interoperating with images collections that represent the bibliographic record. That will give KOHA a natural connection with digital representations of documents in a descentralized and interoperable way. There are client side solutions as openseadragon and others. The digital representations of documents in images can be in any IIIF images server and collections of images can be linked trough the manifest standarized in the IIIF presentation API. Other LIS are incorporating IIIF interoperability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 06:39:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 05:39:14 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 06:39:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 05:39:17 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 --- Comment #7 from Nick Clemens --- Created attachment 96468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96468&action=edit Bug 3426: Allow for multiple fields in itemcallnumber syspref Note that we change both cataloguing/additem.pl and C4/Items->PrepareItemrecordfordisplay I can find no code that uses callnumber from the C4/Items sub, except for the itemrecorddisplay script which is not called with an itemnumber from Koha and should be deprecated for REST or ILSDI or OAI (imho) To test: 1 - Define itemcallnumber syspref as "082ab,092ab,9520,245a" 2 - Find a record with no items 3 - Ensure it has no 082 field, but an 092 field 4 - Go to add an item - itemcallnumber is empty 5 - Apply patch 6 - Go to add item, itemcallnumber should be the 092ab fields 7 - Delete the 092 field 8 - Go to add item, itemcallnumber should be the 245a 9 - Edit the callnumber to be "testing" and save item 10 - For should now show itemcallnumber="testing" as default 11 - Browse to http://localhost:8081/cgi-bin/koha/services/itemrecorddisplay.pl?itemnumber=## subbing the correct itemnumber 12 - Ensure the callnumber is defaulting to testing 13 - delete the item you created 14 - browse to URL above - callnumber should now be 245 again 15 - Add an 092 field to record and ensure it is now default callnumber 16 - Add an 082 field, it should now be default -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 06:39:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 05:39:50 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:27:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:27:38 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #10 from Jonathan Druart --- (In reply to Owen Leonard from comment #9) > I notice the choices offered under "Default sort order" include columns > which are configured in the individual DataTable configuration to be > unsortable. I wonder if we need to move those settings into > columns_settings.yml too? Hi Owen, Thanks for taking a look at this. The "default sort order" dropdown list includes all the columns of the table, indeed. That could lead to inconsistencies but dealing with that on this page will add much more complexity. Moving the sortable bit to this config page is a good idea, if we agree on such move I think it should be done for all the tables in one go, which can be quite hard to do. I keep that in mind and will think about it to see what could be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:41:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:41:34 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:41:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:41:37 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96386|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 96469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96469&action=edit Bug 24169: Advanced editor: icons/buttons for sorting the search results are missing This patch "manually" adds the "dataTable" class to the table of search results in the advanced cataloging editor. This allows the correct styles to get picked up from existing CSS. To test, go to Cataloging and open the advanced editor. Perform a search using the sidebar search form. In the table of results, confirm that table sorting indicators look correct and that sorting works correctly. Signed-off-by: Cori Lynn Arnold Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:41:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:41:41 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #8 from Jonathan Druart --- Created attachment 96470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96470&action=edit Bug 24169: Add a comment to clarify the use of the dataTable class Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:44:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:44:37 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #9 from Jonathan Druart --- (In reply to Owen Leonard from comment #6) > (In reply to Jonathan Druart from comment #5) > > Owen, does not it sound more correct to copy the CSS definitions? > > It would be more correct, but I think the satisfaction of being technically > correct would be outweighed by the effort. I think a pragmatic fix is better. It seemed easy to copy the 5 lines, and I was going to propose an alternative patch. But then I realised that we may also want the other .dataTable definitions as well. I guess that why you thought the effort was consequent, I did not think about that at first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:53:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:53:09 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94658|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 96471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96471&action=edit Bug 22569: Add a 'Transfers to send' report This patch adds a 'Transfers to send' report to the circulation page which displays items which have been triggered for transfer by the stock rotation subsystem. Caveats: 1) It is currently limited to transfers prompted by stockrotation 2) There is no way to differentiate between a transfer that has been requested and a transfer than has been actually sent. (but we do filter out transfers that have been marked as received) 3) Both 'Advance' and 'Repatriate' actions will be listed and the 'Advance' listings should have the option to set the item as 'In demand' at the current branch and thus cancel the transfer and make the item wait an additional stage period before being automatically set to transfer again. I believe we should enhance the transfers system as a whole to allow this report to be more meaningful and include transfer initiated via other means (along with appropriate actions to be taken upon them) Test plan 1) Setup a rotation plan and add some items to it as per the manual 2) Run the stockrotation cronjob with the --execute flag 3) Check that the expected items appears in the new 'Transfers to send' page. It does not yet catch items that are due for transfer by any other means as at this time we do not store that sort of detail for other mechanisms. See bug 23092 for one proposed resolution to that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:53:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:53:12 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94659|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 96472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96472&action=edit Bug 22569: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:53:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:53:15 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #16 from Martin Renvoize --- Created attachment 96473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96473&action=edit Reverse transferstosend controller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:53:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:53:18 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #17 from Martin Renvoize --- Created attachment 96474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96474&action=edit Add inbound_transfers to Koha::Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:53:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:53:21 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #18 from Martin Renvoize --- Created attachment 96475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96475&action=edit Use inbound_transfers in transferstosend template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:53:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:53:28 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #26 from Jonathan Druart --- There is something terribly wrong with this test file, the cronjob script is run outside the transaction and so changes are effective. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:57:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:57:40 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:57:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:57:44 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96462|0 |1 is obsolete| | Attachment #96463|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 96476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96476&action=edit Bug 24268: Unit tests Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 07:57:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 06:57:47 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 --- Comment #7 from Jonathan Druart --- Created attachment 96477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96477&action=edit Bug 24268: Break assignment and warn into separate actions Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 08:07:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 07:07:32 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 08:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 07:07:43 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96471|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 08:07:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 07:07:51 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96472|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 08:08:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 07:08:00 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96473|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 08:08:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 07:08:10 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96474|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 08:09:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 07:09:02 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #19 from Martin Renvoize --- Created attachment 96478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96478&action=edit Bug 22569: Add a 'Transfers to send' report This patch adds a 'Transfers to send' report to the circulation page which displays items which have been triggered for transfer by the stock rotation subsystem. Caveats: 1) It is currently limited to transfers prompted by stockrotation 2) There is no way to differentiate between a transfer that has been requested and a transfer than has been actually sent. (but we do filter out transfers that have been marked as received) 3) Both 'Advance' and 'Repatriate' actions will be listed and the 'Advance' listings should have the option to set the item as 'In demand' at the current branch and thus cancel the transfer and make the item wait an additional stage period before being automatically set to transfer again. I believe we should enhance the transfers system as a whole to allow this report to be more meaningful and include transfer initiated via other means (along with appropriate actions to be taken upon them) Test plan 1) Setup a rotation plan and add some items to it as per the manual 2) Run the stockrotation cronjob with the --execute flag 3) Check that the expected items appears in the new 'Transfers to send' page. It does not yet catch items that are due for transfer by any other means as at this time we do not store that sort of detail for other mechanisms. See bug 23092 for one proposed resolution to that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 08:09:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 07:09:05 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #20 from Martin Renvoize --- Created attachment 96479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96479&action=edit Bug 22569: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 08:29:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 07:29:45 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #47 from Jonathan Druart --- (In reply to Agustín Moyano from comment #46) > (In reply to Jonathan Druart from comment #43) > > Why $class->_resultset->search instead of $self->search? > > I believe that's a question only you can reply (bug 16966 - > https://bugs.koha-community.org/bugzilla3/attachment. > cgi?id=60705&action=diff#a/Koha/Patrons.pm_sec1) ;P > > on a firt attempt, I copied what search_patron_to_anonymize does, but then > in follow-up removed it from Patrons and placed it in LastPatrons without > $class->_resultset->search. Heh ok, fair enough. I do not think it's correct (not incorrect either). We should return $class->search(), as you did then! I am still not happy with that new module. I do not think it really makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 08:32:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 07:32:33 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #2 from Marcel de Rooy --- Looks good at first glance. You add: +# warn Data::Dumper::Dumper( $query ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 08:37:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 07:37:39 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #48 from Jonathan Druart --- FYI On bug 24152 I provide a flexible way to remove Koha::Object-based objects depending on date range. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 09:05:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 08:05:52 +0000 Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |21915 --- Comment #1 from Jonathan Druart --- Hi Liz, I do not recreate. How do you? I tried the 2 situations: - patron has one accountline with amountoutstanding < 0 - nothing in the accountlines table My understanding of the error is that 92 my $patrons = Koha::Patrons->search({ borrowernumber => { -in => \@patron_ids } }); is called with @patron_ids = ( undef ); Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 [Bug 21915] Add a way to automatically reconcile balance for patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 09:05:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 08:05:52 +0000 Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|19.05 |--- Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24266 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 [Bug 24266] Noisy error in reconcile_balances.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 09:41:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 08:41:06 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #2 from David Nind --- There is no / between search and the question mark for the query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 11:35:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 10:35:58 +0000 Subject: [Koha-bugs] [Bug 24274] New: New installations should not contain field 01e Coded field error (RLIN) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 Bug ID: 24274 Summary: New installations should not contain field 01e Coded field error (RLIN) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Field 01e comes from the RLIN utility. It is not a standard MARC21 field. Previously, it triggered the warning (in addbiblio.pl) Argument "01e" isn't numeric in numeric ne (!=) This warning was addressed on bug 21172. It is the only non-numeric field tag in Koha; and it does not belong there. We should remove it. This report only deals with new installations. So it fixes the SQL installer files. It does NOT include a database revision for existing installations. You never know if someone used the field somehow ;) See also (question of Magnus in 2009! goto 09:55 hours): http://irc.koha-community.org/koha/2009-06-18 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 11:39:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 10:39:22 +0000 Subject: [Koha-bugs] [Bug 24274] New installations should not contain field 01e Coded field error (RLIN) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 11:39:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 10:39:25 +0000 Subject: [Koha-bugs] [Bug 24274] New installations should not contain field 01e Coded field error (RLIN) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 --- Comment #1 from Marcel de Rooy --- Created attachment 96480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96480&action=edit Bug 24274: Remove field 01e from sql installer files Field 01e comes from an older utility (RLIN) and does not belong here. Test plan: Run a new install and check the bibliographic frameworks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 11:40:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 10:40:15 +0000 Subject: [Koha-bugs] [Bug 24274] New installations should not contain field 01e Coded field error (RLIN) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | CC| |magnus at libriotech.no Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 11:40:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 10:40:39 +0000 Subject: [Koha-bugs] [Bug 24274] New installations should not contain field 01e Coded field error (RLIN) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21172 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 11:40:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 10:40:39 +0000 Subject: [Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24274 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 11:41:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 10:41:32 +0000 Subject: [Koha-bugs] [Bug 21172] Warning in addbiblio.pl - Argument "01e" isn't numeric in numeric ne (!=) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21172 --- Comment #14 from Marcel de Rooy --- (In reply to David Cook from comment #4) > It seems that technically 01e is a violation of the MARC standard. > > Maybe it is time to remove 01e from the frameworks... See bug 24274 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 11:56:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 10:56:04 +0000 Subject: [Koha-bugs] [Bug 24274] New installations should not contain field 01e Coded field error (RLIN) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96480|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 96481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96481&action=edit Bug 24274: Remove field 01e from sql installer files Field 01e comes from an older utility (RLIN) and does not belong here. Note: It is the only non-numeric field tag in Koha. And it seems to be an violation of the MARC standard. Test plan: Run a new install and check the bibliographic frameworks. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 11:56:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 10:56:43 +0000 Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #2 from Tomás Cohen Arazi --- I cannot reproduce either, but I agree the code needs to be fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 12:18:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 11:18:48 +0000 Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 --- Comment #3 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #2) > I cannot reproduce either, but I agree the code needs to be fixed. It's not. It should never be (undef) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 13:30:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 12:30:33 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96453|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 96482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96482&action=edit Bug 24267: Improve ImportBreedingAuth -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 13:31:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 12:31:14 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #4 from Nick Clemens --- (In reply to Marcel de Rooy from comment #2) > Looks good at first glance. > > You add: > +# warn Data::Dumper::Dumper( $query ); Heh, bum for bug 24103 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 13:46:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 12:46:34 +0000 Subject: [Koha-bugs] [Bug 24274] New installations should not contain field 01e Coded field error (RLIN) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 13:46:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 12:46:37 +0000 Subject: [Koha-bugs] [Bug 24274] New installations should not contain field 01e Coded field error (RLIN) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96481|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 13:46:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 12:46:56 +0000 Subject: [Koha-bugs] [Bug 24274] New installations should not contain field 01e Coded field error (RLIN) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 96483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96483&action=edit Bug 24274: Remove field 01e from sql installer files Field 01e comes from an older utility (RLIN) and does not belong here. Note: It is the only non-numeric field tag in Koha. And it seems to be an violation of the MARC standard. Test plan: Run a new install and check the bibliographic frameworks. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 13:55:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 12:55:05 +0000 Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 96484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96484&action=edit Bug 24266: Don't search for patrons if no borrowernumbers This patch makes the reconcile_balances.pl script skip searching for patrons from a given borrowernumbers list, if the list is empty. The code was logically incorrect, and it doesn't break because of a bug in SQL::Abstract that in recent versions started raising a noisy warning. I couldn't reproduce it in koha-testing-docker but it's been found in the wild. I submit this obvious fix so people having the issue can test it properly. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 13:55:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 12:55:38 +0000 Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |Needs Signoff --- Comment #5 from Tomás Cohen Arazi --- Liz, please test it on your production site and let me know if it fixes the issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 14:05:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 13:05:53 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #5 from Marcel de Rooy --- Any chance to extend Breeding.t for this sub ;) Sorry.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 14:20:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 13:20:59 +0000 Subject: [Koha-bugs] [Bug 24275] New: Inventory table should allow for title sort with anti-the Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275 Bug ID: 24275 Summary: Inventory table should allow for title sort with anti-the Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries have sections where the books are ordered by title, or they want to get a title sorted list from inventory. Currently we don't ignore leading articles, we should add anti-the to the table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 14:23:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 13:23:26 +0000 Subject: [Koha-bugs] [Bug 24275] Inventory table should allow for title sort with anti-the In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 14:23:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 13:23:28 +0000 Subject: [Koha-bugs] [Bug 24275] Inventory table should allow for title sort with anti-the In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275 --- Comment #1 from Nick Clemens --- Created attachment 96485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96485&action=edit Bug 24275: Apply anti-the to title column in inventory table To test: 1 - Go to Tools->Inventory 2 - Click submit (or add options to get a subset of titles) 3 - Try sorting by title, note that titles with leading articles sort including the articles 4 - Apply patch 5 - Reload the page 6 - Note that leading articles are ignored for sorting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 14:42:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 13:42:51 +0000 Subject: [Koha-bugs] [Bug 24276] New: [WORKING_TITLE] Messing up neworderempty.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Bug ID: 24276 Summary: [WORKING_TITLE] Messing up neworderempty.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 14:45:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 13:45:56 +0000 Subject: [Koha-bugs] [Bug 24276] [WORKING_TITLE] Messing up neworderempty.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 14:46:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 13:46:12 +0000 Subject: [Koha-bugs] [Bug 24276] [WORKING_TITLE] Messing up neworderempty.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 15:19:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 14:19:59 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Andrew Fuerste-Henry --- You probably want to base this on bug 9156. Also, failing this because it's not properly checking each field in order -- in your example, when the system finds that the 082 is empty it jumps straight to the 245 at the end of the list without checking the 092 and 952. Also, if we're gonna change how this works then we need to change the syspref text. How about: List multiple comma-separated fields to check them sequentially. Each field can include multiple subfields. For example: "082ab,092ab" will look in the 082$a and 082$b, then the 092$a and 092$b. Examples (for MARC21 records): Dewey: 082ab,092ab; LOC: 050ab,090ab; from the item record: 952hi -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 15:33:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 14:33:25 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95580|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes --- Created attachment 96486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96486&action=edit Bug 9156: itemcallnumber not pulling more than 2 subfields When the itemcallnumber system preference is defined, the item add form pulls data from the specified tag and subfield(s) to pre-populate the call number field. This update makes it possible to build the prepopulated callnumber from more than just the first two subfields. To test, apply the patch and update the itemcallnumber system preference so that it includes more than two subfields. For instance, "092abef" - Edit a bibliographic record and populate the specified subfields. e.g. subfield a -> "One", b-> "Two", e-> "Three", f-> "Four". - Save the record and go to the add/edit items screen. - The call number field should contain a string which contains each of the subfields you populated, concatenated with spaces: "One Two Three Four." - Test with other numbers of subfields. - Test with an empty itemcallnumber preference. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 15:34:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 14:34:51 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Andrew Fuerste-Henry --- Owen's test plan worked for me. I could not replicate Séverine's issues. I added a subfield A and Koha correctly handled both a and A. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 15:48:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 14:48:40 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96050|0 |1 is obsolete| | --- Comment #18 from ByWater Sandboxes --- Created attachment 96487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96487&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure renewals are allowed in circ rules 4. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row Signed-off-by: tgoat Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott Signed-off-by: Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 16:29:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 15:29:18 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96408|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 96488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96488&action=edit Bug 24259: Handle non existing default circ rule in Charges::Fees Can't call method "lengthunit" on an undefined value at /usr/share/koha/lib/Koha/Charges/Fees.pm line 101. Test plan: 1 - Remove all/all rule form circulation rules 2 - Define a rental fee per day for an itemtype 3 - Checkout an item of this type ot patron 4 - Should get note of no circ rule defined 5 - Confirm the checkout => item is checked out Signed-off-by: hc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 16:31:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 15:31:45 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 16:45:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 15:45:10 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96245|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes --- Created attachment 96489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96489&action=edit Bug 21232: Add a client-side check on biblionumber when creating a subscription This patch adds an AJAX call to the REST API (/api/v1/biblios/) to retrieve and display the biblio's title. On clicking the "next" button a check is done to make sure the title exists, which means the biblionumber we manually entered is valid (can we assume a title is mandatory?) Test plan: - Create or edit a new subscription - Enter an invalid biblionumber in the input => A friendly note is telling you that the biblio does not exist - Try to switch to the next screen => You get an alert - Enter a valid biblionumber in the input => The title is displayed => Try to switch to the next screen => It works! Signed-off-by: hc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 16:46:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 15:46:13 +0000 Subject: [Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 --- Comment #6 from Jonathan Druart --- Tomas, the warning is about ->search({ -in => [undef] }), not ->search({ -in => [] }). So I do not think your patch will change anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 16:46:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 15:46:28 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:04:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:04:08 +0000 Subject: [Koha-bugs] [Bug 24277] New: Date Received in acquisitions cannot be changed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Bug ID: 24277 Summary: Date Received in acquisitions cannot be changed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When receiving an order on orderreceive.pl, Koha gives one a date picker with which to change the Date Received. However, regardless of what one enters in the date picker today's date is used. To Test: - find/create an order ready for receipt - when receiving the order, set Date Received to something other than today's date - after receiving, check Receive Date in the Acquisitions tab of your bib (or query aqorders.datereceived), confirm it shows today's date I tried setting the shipment date on the invoice to something other than today, in case that made a difference, but it didn't help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:04:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:04:37 +0000 Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:07:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:07:39 +0000 Subject: [Koha-bugs] [Bug 24242] Funds with no library assigned do not appear on edit suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96292|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 96490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96490&action=edit Bug 24242: Display funds that the logged in user can access - suggestions The design of this script is pretty bad and any modifications is a challenge. Here we are trying to display to display the funds available for the logged in user. I did not understand previous code, as we are doing a limit using CanUserUseBudget, I do not think it makes sense to retrieve funds for a given library. Also, I am wondering if the dropdown list in the filters has ever been populated: budgetid_loop in the template *never* appeared in the history of suggestion.pl (??) Test plan: Search for suggestions Add/edit suggestions => The funds in the dropdown list should be the ones the logged in user can use. Signed-off-by: hc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:08:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:08:21 +0000 Subject: [Koha-bugs] [Bug 24242] Funds with no library assigned do not appear on edit suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:16:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:16:31 +0000 Subject: [Koha-bugs] [Bug 24278] New: Replace Locale::Currency::Format because it's buggy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24278 Bug ID: 24278 Summary: Replace Locale::Currency::Format because it's buggy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Locale::Currency::Format is used to format the overdue fine printed using items.fines in the overdue notices. I am not sure if it's used in other places. The module has not seen a new version in a longer while and is buggy for some currencies: COP (Colombian peso) - wrong currency symbol RSD (Serbian dinar) - wrong currency symbol TYR (Turkey) - amounts are rounded and printed without decimals What we do at the moment is adding "wrong" codes for those so the formatting is avoided... but when you want to use acq etc this could be a bigger issue. Maybe we shoudl replace the module by enabling the use of the price filter in all notices if not the case yet and treat the existing placeholder items.fine as if the price filter was used? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:18:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:18:06 +0000 Subject: [Koha-bugs] [Bug 24278] Replace Locale::Currency::Format because it's buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24278 --- Comment #1 from Katrin Fischer --- TYR also has a wrong currency symbol. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:18:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:18:54 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96460|0 |1 is obsolete| | Attachment #96461|0 |1 is obsolete| | Attachment #96464|0 |1 is obsolete| | --- Comment #10 from Andrew Nugged --- Created attachment 96491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96491&action=edit Bug 24185: Make holds page faster - improved "if" `$can_item_be_reserved eq 'OK'` moved in `&&` before `IsAvailableForItemLevelRequest` to cut away with static known values before calling to more resource consuming subroutine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:23:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:23:47 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 --- Comment #11 from Andrew Nugged --- Created attachment 96492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96492&action=edit Bug 24185: Make holds page faster - call to subroutine moved below "if" `$on_shelf_holds` was assigned before "return .. if" but not used in that code piece, so sometimes it was useless. Moved assignment after "return .. if". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:30:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:30:12 +0000 Subject: [Koha-bugs] [Bug 24279] New: Claims Returned does not work when set from moredetail.pl or additem.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Bug ID: 24279 Summary: Claims Returned does not work when set from moredetail.pl or additem.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To test: - configure claims returned per bug 14697 - Check an item out to a patron - Go to either moredetail.pl or additem.pl and set the item to your claims returned lost value - observe that the item has followed normal lost behavior rather than claims returned behavior We see two options to fix this, either: - Hide the claims returned lost value from moredetail.pl and additem.pl OR - Make Koha follows claims returned process regardless of how the item is set to that claims returned lost value -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:30:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:30:36 +0000 Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:33:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:33:23 +0000 Subject: [Koha-bugs] [Bug 24280] New: Claims Returned items give erroneous refund message on return Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24280 Bug ID: 24280 Summary: Claims Returned items give erroneous refund message on return Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To test: - Configure claims returned per bug 14697 - set Default lost item fee refund on return policy to Yes - Check an item out to a patron - Set to claims returned without charging a fee - Check item in - Koha gives a message that a refund was applied to the patron account, but no refund was generated as there was no lost fee -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:34:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:34:42 +0000 Subject: [Koha-bugs] [Bug 24280] Claims Returned items give erroneous refund message on return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24280 --- Comment #1 from Andrew Fuerste-Henry --- This might be broader than claims returned, could be it just says that for any lost item checked in while Default lost item fee refund on return policy is Yes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 17:57:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 16:57:02 +0000 Subject: [Koha-bugs] [Bug 24281] New: Fix the list of types of visual materials Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24281 Bug ID: 24281 Summary: Fix the list of types of visual materials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org In the MARC21slim2OPACResults and MARC21slim2IntranetResults XSLT files, the type of visual material for code "g" is "legal article" instead of "game" ; Type of visual material: [...] legal article -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 18:06:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 17:06:23 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 --- Comment #12 from Andrew Nugged --- Created attachment 96493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96493&action=edit Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all unavailable' When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest" called many times with hundred of items and "on shelf holds" parameter set to "If all unavailable" for these items + patron, it goes slow. It happens because in subloop there is checking if all items available so it is O(n^2) and it re-checks each time the same info for each item with repeating DB/data requests. Fix: The inner loop 1:1 picked out from another loop and put before that items processing loop, 'items_any_available' variable precalculated, this variable passed to IsAvailableForItemLevelRequest to be used inside as the precalculated result. On tests it gave a drastic improvement in execution time. How to reproduce: 1) on freshly installed kohadevbox create/import one book, remember that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up a single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", that rule should match above book items/library/patron, check that rule to have a non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create a direct link by yourself, for example, in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time on old code, densely increasing for every hundred items added. In the case of this solution, it's fast, and time increases a little only, linear. I tested on my computer in VirtualBox for page generation times, did 3-5 runs for same case to check if results are stable, and got such values: (old code): 100 items: 38 seconds 200 items: 2.5 minutes 300 items: 5.4 minutes (version with fix): 100 items: 3.7 seconds 200 items: 6.4 seconds 300 items: 8.7 seconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 18:10:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 17:10:59 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 18:11:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 17:11:47 +0000 Subject: [Koha-bugs] [Bug 22789] Establish non-priority holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Summary|Establish Non-Priority |Establish non-priority |Holds |holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 18:21:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 17:21:18 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #8 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 18:26:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 17:26:21 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 18:26:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 17:26:28 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95337|0 |1 is obsolete| | --- Comment #19 from Agustín Moyano --- Created attachment 96494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96494&action=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports Signed-off-by: tgoat Signed-off-by: Kelly McElligott Signed-off-by: Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 18:26:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 17:26:34 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96487|0 |1 is obsolete| | --- Comment #20 from Agustín Moyano --- Created attachment 96495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96495&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure renewals are allowed in circ rules 4. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row Signed-off-by: tgoat Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott Signed-off-by: Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 18:37:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 17:37:40 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #6 from Nick Clemens --- Created attachment 96496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96496&action=edit Bug 24267: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 18:38:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 17:38:33 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #7 from Nick Clemens --- (In reply to Marcel de Rooy from comment #5) > Any chance to extend Breeding.t for this sub ;) Sorry.. I did very brief, let me know if there are more cases to cover -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 18:44:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 17:44:06 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96496|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 96497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96497&action=edit Bug 24267: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 19:48:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 18:48:25 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 19:48:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 18:48:41 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|tomascohen at gmail.com |agustinmoyano at theke.io -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 19:57:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 18:57:54 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io Blocks| |20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 19:57:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 18:57:54 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 19:58:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 18:58:48 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20936 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 19:58:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 18:58:48 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20271 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 19:59:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 18:59:06 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds History for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 19:59:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 18:59:06 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 20:00:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 19:00:31 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 20:00:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 19:00:34 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96468|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 96498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96498&action=edit Bug 3426: Allow for multiple fields in itemcallnumber syspref Note that we change both cataloguing/additem.pl and C4/Items->PrepareItemrecordfordisplay I can find no code that uses callnumber from the C4/Items sub, except for the itemrecorddisplay script which is not called with an itemnumber from Koha and should be deprecated for REST or ILSDI or OAI (imho) To test: 1 - Define itemcallnumber syspref as "082ab,092ab,9520,245a" 2 - Find a record with no items 3 - Ensure it has no 082 field, but an 092 field 4 - Go to add an item - itemcallnumber is empty 5 - Apply patch 6 - Go to add item, itemcallnumber should be the 092ab fields 7 - Delete the 092 field 8 - Go to add item, itemcallnumber should be the 245a 9 - Edit the callnumber to be "testing" and save item 10 - For should now show itemcallnumber="testing" as default 11 - Browse to http://localhost:8081/cgi-bin/koha/services/itemrecorddisplay.pl?itemnumber=## subbing the correct itemnumber 12 - Ensure the callnumber is defaulting to testing 13 - delete the item you created 14 - browse to URL above - callnumber should now be 245 again 15 - Add an 092 field to record and ensure it is now default callnumber 16 - Add an 082 field, it should now be default -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 20:00:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 19:00:47 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9156 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 [Bug 9156] itemcallnumber not pulling more than 2 subfields -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 20:00:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 19:00:47 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |3426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 [Bug 3426] change itemcallnumber system preference to allow multiple tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 20:06:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 19:06:35 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #10 from Nick Clemens --- Created attachment 96499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96499&action=edit Bug 9156: (follow-up) Simpliy code The MARC::Field as_string method can join multiple subfield using a delimiter, this simplifies the code here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 21:15:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 20:15:29 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96493|0 |1 is obsolete| | --- Comment #13 from Andrew Nugged --- Created attachment 96500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96500&action=edit Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all unavailable' When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest" called many times with hundred of items and "on shelf holds" parameter set to "If all unavailable" for these items + patron, it goes slow. It happens because in subloop there is checking if all items available so it is O(n^2) and it re-checks each time the same info for each item with repeating DB/data requests. Fix: The inner loop 1:1 picked out from another loop and put before that items processing loop, 'items_any_available' variable precalculated, this variable passed to IsAvailableForItemLevelRequest to be used inside as the precalculated result. On tests it gave a drastic improvement in execution time. How to reproduce: 1) on freshly installed kohadevbox create/import one book, remember that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up a single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", that rule should match above book items/library/patron, check that rule to have a non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create a direct link by yourself, for example, in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time on old code, densely increasing for every hundred items added. In the case of this solution, it's fast, and time increases a little only, linear. I tested on my computer in VirtualBox for page generation times, did 3-5 runs for same case to check if results are stable, and got such values: (old code): 100 items: 38 seconds 200 items: 2.5 minutes 300 items: 5.4 minutes (version with fix): 100 items: 3.7 seconds 200 items: 6.4 seconds 300 items: 8.7 seconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 22:19:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 21:19:05 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #13 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 22:40:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 21:40:47 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 22:47:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 21:47:38 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | --- Comment #8 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 23:01:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 22:01:07 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 23:03:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 22:03:27 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy at bywatersolutions.com --- Comment #8 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 23:06:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 22:06:17 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 23:08:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 22:08:17 +0000 Subject: [Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 19 23:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 22:20:05 +0000 Subject: [Koha-bugs] [Bug 21565] SCO checkout confirm language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21565 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kelly at bywatersolutions.com --- Comment #5 from Kelly McElligott --- The print dialog box does not appear in both Firefox and Chrome. Printing in other areas in the testing sandbox such as print slips works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 00:48:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Dec 2019 23:48:54 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96498|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 96501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96501&action=edit Bug 3426: Allow for multiple fields in itemcallnumber syspref Note that we change both cataloguing/additem.pl and C4/Items->PrepareItemrecordfordisplay I can find no code that uses callnumber from the C4/Items sub, except for the itemrecorddisplay script which is not called with an itemnumber from Koha and should be deprecated for REST or ILSDI or OAI (imho) To test: 1 - Define itemcallnumber syspref as "082ab,092ab,9520,245a" 2 - Find a record with no items 3 - Ensure it has no 082 field, but an 092 field 4 - Go to add an item - itemcallnumber is empty 5 - Apply patch 6 - Go to add item, itemcallnumber should be the 092ab fields 7 - Delete the 092 field 8 - Go to add item, itemcallnumber should be the 245a 9 - Edit the callnumber to be "testing" and save item 10 - For should now show itemcallnumber="testing" as default 11 - Browse to http://localhost:8081/cgi-bin/koha/services/itemrecorddisplay.pl?itemnumber=## subbing the correct itemnumber 12 - Ensure the callnumber is defaulting to testing 13 - delete the item you created 14 - browse to URL above - callnumber should now be 245 again 15 - Add an 092 field to record and ensure it is now default callnumber 16 - Add an 082 field, it should now be default -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 03:50:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 02:50:26 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 03:50:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 02:50:26 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 [Bug 18731] Add routes for acquisition orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:20:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:20:18 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:20:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:20:21 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96482|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 96502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96502&action=edit Bug 24267: Improve ImportBreedingAuth Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:20:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:20:26 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96497|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 96503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96503&action=edit Bug 24267: Unit tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:20:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:20:30 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #11 from Marcel de Rooy --- Created attachment 96504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96504&action=edit Bug 24267: (QA follow-up) Remove two calls, add transaction Call to GetAuthorizedHeading is already done just before calling ImportBreedingAuth. Call to GuessAuthTypeCode is not used. Adding transaction to test (check your database, kidclamp ;) Test plan: Add new authority via Z3950 in the interface. Run t/db_dependent/Breeding.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:21:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:21:21 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:32:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:32:04 +0000 Subject: [Koha-bugs] [Bug 24129] Add ability to configure some indexes to not autotruncate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24129 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin SOMERS --- That would be great indeed. Same issue with author fields that need no truncation (nor stemming). When you search for first name "Jo" you don't want Joan, Joe... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:33:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:33:46 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:39:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:39:16 +0000 Subject: [Koha-bugs] [Bug 24282] New: SCSS conversion broke style in search results item status Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Bug ID: 24282 Summary: SCSS conversion broke style in search results item status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Before SCSS conversion, there was a style for search results item status : #searchresults span.status { Conversion to SCSS added ul : #searchresults ul span.status { Now style does not apply anymore. You can see that items on loan are not red anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:39:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:39:24 +0000 Subject: [Koha-bugs] [Bug 24282] SCSS conversion broke style in search results item status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:45:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:45:13 +0000 Subject: [Koha-bugs] [Bug 24282] SCSS conversion broke style in search results item status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:45:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:45:16 +0000 Subject: [Koha-bugs] [Bug 24282] SCSS conversion broke style in search results item status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 --- Comment #1 from Fridolin SOMERS --- Created attachment 96505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96505&action=edit Bug 24282: SCSS conversion broke style in search results item status Before SCSS conversion, there was a style for search results item status : #searchresults span.status { Conversion to SCSS added ul : #searchresults ul span.status { Now style does not apply anymore. You can see that items on loan are not red anymore. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. All rules using #searchresults in 17.11 : font-size : 90%; list-style: url(../img/item-bullet.gif); padding : .2em 0; clear : left; } clear : left; color : #900; display : block; } clear : left; display : block; } display : block; } float : left; margin : 3px 5px 3px -5px; } vertical-align : top; } Apply patch update intranet CSS file and check you see the same rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:49:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:49:01 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:49:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:49:04 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #10 from Fridolin SOMERS --- Created attachment 96506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96506&action=edit Bug 24121: Item types icons in intra search results are requesting icons from opac images path When searching in INTRA you'll notice the item type icons not showing. To test: 1) Set syspref item-level_itypes to biblio 2) Confirm that there is a biblioitems.itemtype mapping to a MARC field 3) Verify that item type icons are set for all the types 4) Perform a search where biblios with said MARC field is filled with a type value 5) Verify that where the icon should appear, it's showing the browser icon for image not found 6) Apply patch. 7) Repeat step 4. 8) Observe the icons are now displayed correctly Sponsored-by: Governo Regional dos Açores Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 08:49:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 07:49:52 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:17:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:17:01 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #59 from Jonathan Druart --- Maryse, Séverine, could you signoff Owen's patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:28:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:28:33 +0000 Subject: [Koha-bugs] [Bug 24276] Apply framework mandatory defaults to external sourced records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[WORKING_TITLE] Messing up |Apply framework mandatory |neworderempty.pl |defaults to external | |sourced records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:30:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:30:56 +0000 Subject: [Koha-bugs] [Bug 24276] Apply framework mandatory defaults to external sourced records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #1 from Marcel de Rooy --- If we import a record via Acquisition Z3950 search, the default itemtype (942c) is NULL although it is mandatory. Do not confuse with itype in 952. We apply defaults if we add a new empty record; we should at least apply the mandatory defaults to external records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:40:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:40:55 +0000 Subject: [Koha-bugs] [Bug 24276] Apply framework mandatory defaults to external sourced records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:40:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:40:58 +0000 Subject: [Koha-bugs] [Bug 24276] Apply framework mandatory defaults to external sourced records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #2 from Marcel de Rooy --- Created attachment 96507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96507&action=edit Bug 24276: First change indent No other changes than whitespace, guys. Signed-off-by: Marcel de Rooy Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:41:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:41:03 +0000 Subject: [Koha-bugs] [Bug 24276] Apply framework mandatory defaults to external sourced records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #3 from Marcel de Rooy --- Created attachment 96508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96508&action=edit Bug 24276: Add FillWithDefaultValues call in neworderempty Apply mandatory defaults from the ACQ framework to records from external source in Acquisition. Test plan: [1] Add 'BK' as mandatory default in ACQ framework for 942$c. [2] Add order to basket via external source. [3] Check 942$c on detail page of new record, MARC tab. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:41:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:41:07 +0000 Subject: [Koha-bugs] [Bug 24276] Apply framework mandatory defaults to external sourced records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #4 from Marcel de Rooy --- Created attachment 96509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96509&action=edit Bug 24276: Add unit tests for mandatory parameter of FillWithDefaultValues Test plan: Run t/db_dependent/Acquisition/FillWithDefaultValues.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:44:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:44:15 +0000 Subject: [Koha-bugs] [Bug 24276] Apply framework mandatory defaults to external sourced records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96507|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 96510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96510&action=edit Bug 24276: First change indent No other changes than whitespace, guys. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:44:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:44:19 +0000 Subject: [Koha-bugs] [Bug 24276] Apply framework mandatory defaults to external sourced records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96508|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 96511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96511&action=edit Bug 24276: Add FillWithDefaultValues call in neworderempty Apply mandatory defaults from the ACQ framework to records from external source in Acquisition. Test plan: [1] Add 'BK' as mandatory default in ACQ framework for 942$c. [2] Add order to basket via external source. [3] Check 942$c on detail page of new record, MARC tab. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:44:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:44:23 +0000 Subject: [Koha-bugs] [Bug 24276] Apply framework mandatory defaults to external sourced records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96509|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 96512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96512&action=edit Bug 24276: Add unit tests for mandatory parameter of FillWithDefaultValues Test plan: Run t/db_dependent/Acquisition/FillWithDefaultValues.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:47:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:47:09 +0000 Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply framework mandatory defaults to external sourced records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Apply framework mandatory |Acquisition: Apply |defaults to external |framework mandatory |sourced records |defaults to external | |sourced records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:47:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:47:33 +0000 Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply framework mandatory defaults to records from external sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Acquisition: Apply |Acquisition: Apply |framework mandatory |framework mandatory |defaults to external |defaults to records from |sourced records |external sources -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 09:47:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 08:47:51 +0000 Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Acquisition: Apply |Acquisition: Apply ACQ |framework mandatory |framework mandatory |defaults to records from |defaults to records from |external sources |external sources -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 11:16:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 10:16:35 +0000 Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96512|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 96513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96513&action=edit Bug 24276: Add unit tests for mandatory parameter of FillWithDefaultValues Test plan: Run t/db_dependent/Acquisition/FillWithDefaultValues.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 12:28:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 11:28:37 +0000 Subject: [Koha-bugs] [Bug 24283] New: Missing close parens and closing strong tag in course reserves Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24283 Bug ID: 24283 Summary: Missing close parens and closing strong tag in course reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 12:28:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 11:28:56 +0000 Subject: [Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #16 from Nick Clemens --- Opened bug 24283 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 12:31:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 11:31:39 +0000 Subject: [Koha-bugs] [Bug 24283] Missing close parens and closing strong tag in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24283 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 12:31:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 11:31:42 +0000 Subject: [Koha-bugs] [Bug 24283] Missing close parens and closing strong tag in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24283 --- Comment #1 from Nick Clemens --- Created attachment 96514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96514&action=edit Bug 24283: (bug 21446 follow-up) close strong and add missing parens To Test: 1) Create a course in course reserves, make it inactive 2) Add an item to it, changing item type and location 3) Make the course enabled 4) Note that the normal item type is no longer bold and has both opening and closing parentheses; Note that the normal location is also not bold and has both opening and closing parentheses. 5) Disable the course 6) Note that the normal item type is in bold with an opening parentheses but no closing parentheses; Note that the normal location is in bold with both opening and closing parentheses. 7) Apply patch 8) Note view is fixed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 12:40:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 11:40:29 +0000 Subject: [Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 12:40:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 11:40:31 +0000 Subject: [Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96383|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 96515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96515&action=edit Bug 22838: Remove MIME header warnings from runreports.pl Test plan: - create a savedsql report - run misc/cronjob/runreport.pl with options --format set to html and --to any email - check plack errors log, you should get a warning - apply patch - repeat runreport.pl step - check plack errors log, no additional warning there should be Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 12:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 11:53:57 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96478|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 96516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96516&action=edit Bug 22569: Add a 'Transfers to send' report This patch adds a 'Transfers to send' report to the circulation page which displays items which have been triggered for transfer by the stock rotation subsystem. Caveats: 1) It is currently limited to transfers prompted by stockrotation 2) There is no way to differentiate between a transfer that has been requested and a transfer than has been actually sent. (but we do filter out transfers that have been marked as received) 3) Both 'Advance' and 'Repatriate' actions will be listed and the 'Advance' listings should have the option to set the item as 'In demand' at the current branch and thus cancel the transfer and make the item wait an additional stage period before being automatically set to transfer again. I believe we should enhance the transfers system as a whole to allow this report to be more meaningful and include transfer initiated via other means (along with appropriate actions to be taken upon them) Test plan 1) Setup a rotation plan and add some items to it as per the manual 2) Run the stockrotation cronjob with the --execute flag 3) Check that the expected items appears in the new 'Transfers to send' page. It does not yet catch items that are due for transfer by any other means as at this time we do not store that sort of detail for other mechanisms. See bug 23092 for one proposed resolution to that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 12:54:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 11:54:00 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96479|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 96517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96517&action=edit Bug 22569: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 12:56:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 11:56:52 +0000 Subject: [Koha-bugs] [Bug 24252] Add credits, debits, credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 12:56:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 11:56:54 +0000 Subject: [Koha-bugs] [Bug 24252] Add credits, debits, credit_offsets and debit_offsets relationships to Koha::Account::Line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96371|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 96518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96518&action=edit Bug 24252: Add relations to Koha::Account::Line This patch adds two new relationships to the Koha::Account::Line object. * credit_offsets - returns all credit type Koha::Account::Offsets related to this Koha::Account::Line. * debit_offsets - returns all debit type Koha::Account::Offsets related to this Koha::Account::Line. * credits - returns all credits related to this Koha::Account::Line. * debits - returns all debits related to this Koha::Account::Line. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:01:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:01:13 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:01:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:01:15 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96332|0 |1 is obsolete| | Attachment #96333|0 |1 is obsolete| | Attachment #96334|0 |1 is obsolete| | Attachment #96335|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 96519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96519&action=edit Bug 24080: Payout account debit type Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:02:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:02:55 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96519|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 96520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96520&action=edit Bug 24080: Payout account debit type Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:03:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:03:03 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #22 from Kyle M Hall --- Created attachment 96521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96521&action=edit Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:03:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:03:06 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #23 from Kyle M Hall --- Created attachment 96522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96522&action=edit Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:03:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:03:09 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #24 from Kyle M Hall --- Created attachment 96523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96523&action=edit Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:07:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:07:57 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:09:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:09:49 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 --- Comment #27 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:09:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:09:51 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:09:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:09:53 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:09:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:09:56 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 --- Comment #12 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:09:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:09:58 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:10:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:10:00 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #19 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:10:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:10:02 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:10:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:10:04 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:47:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:47:13 +0000 Subject: [Koha-bugs] [Bug 24284] New: Canelling of holds and order should allow for different translation then cancel as options in dialogs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24284 Bug ID: 24284 Summary: Canelling of holds and order should allow for different translation then cancel as options in dialogs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr At least in German the verb used for cancelling orders/holds is different than the verb used for cancelling a process/cancelling a dialog. It would be nice if Koha allowed for different translations in this case. Maybe the new I18N features could be helpful here? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:47:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:47:45 +0000 Subject: [Koha-bugs] [Bug 24284] Canelling of holds and order should allow for different translation then cancel as options in dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24284 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23983 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 13:47:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 12:47:45 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24284 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:08:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:08:28 +0000 Subject: [Koha-bugs] [Bug 24285] New: Add search index on 008 pos 21 - type of continuing resource Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24285 Bug ID: 24285 Summary: Add search index on 008 pos 21 - type of continuing resource Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de It would be useful if we could differentiate in search between periodicals and monographic series for limiting result lists. This information is encoded in 008 pos 21: https://www.loc.gov/marc/bibliographic/bd008s.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:10:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:10:42 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:13:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:13:01 +0000 Subject: [Koha-bugs] [Bug 22064] Allow to change due date of an item without requiring checkin or renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22064 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:33:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:33:23 +0000 Subject: [Koha-bugs] [Bug 24286] New: FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286 Bug ID: 24286 Summary: FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com To recreate: 0 - Set SearchEngine to Elasticsearch, QueryRegexEscapeOptions to 'Don't Escape' 1 - Browse to Authorities 2 - Select New->New from Z3950 3 - Search for subject 'Short stories' 4 - Auth search explodes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:36:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:36:57 +0000 Subject: [Koha-bugs] [Bug 24283] Missing close parens and closing strong tag in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24283 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:38:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:38:24 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |joonas.kylmala at helsinki.fi --- Comment #12 from Joonas Kylmälä --- Doesn't apply anymore: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22690: Refactor merging of records to improve performance (Elasticsearch) Using index info to reconstruct a base tree... M C4/Items.pm M Koha/Biblio.pm M Koha/Item.pm M t/db_dependent/Koha/Item.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Item.t Auto-merging Koha/Item.pm CONFLICT (content): Merge conflict in Koha/Item.pm Auto-merging Koha/Biblio.pm CONFLICT (content): Merge conflict in Koha/Biblio.pm Auto-merging C4/Items.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 22690: Refactor merging of records to improve performance (Elasticsearch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:38:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:38:25 +0000 Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:38:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:38:28 +0000 Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286 --- Comment #1 from Nick Clemens --- Created attachment 96524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96524&action=edit Bug 24286: Escape forward slash in GENRE/FORM (and any authtype) Note that bug 24267 will fix the issue during Z39 searching for new auth, but the duplicate check at saving will still fail To test: 0 - Set SearchEngine to Elasticsearch, QueryRegexEscapeOptions to 'Don't Escape' 1 - Browse to Authorities 2 - Select New->New from Z3950 3 - Search for subject 'Short stories' 4 - Auth search explodes 5 - Apply patch 6 - Repeat and confirm the search results return 7 - Import and save the GENRE/FORM record for Short stories 8 - Repeat the search and import the same record 9 - Confirm that upon save you are notified of duplicate, don't save 10 - set QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works and importing/save notifies of duplicate 11 - set SearchEngine to Zebra and confirm Z39 searching works and importing/save notifies of duplicate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:38:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:38:40 +0000 Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:39:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:39:12 +0000 Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24264, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24267 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:39:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:39:12 +0000 Subject: [Koha-bugs] [Bug 24264] Elasticsearch - Cannot search for genre/form authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24286 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:39:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:39:12 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24286 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:41:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:41:56 +0000 Subject: [Koha-bugs] [Bug 24284] Cancelling of holds and orders should allow for different translation than cancel as options in dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24284 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Summary|Canelling of holds and |Cancelling of holds and |order should allow for |orders should allow for |different translation then |different translation than |cancel as options in |cancel as options in |dialogs |dialogs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:50:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:50:23 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 14:50:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 13:50:26 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96488|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 96525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96525&action=edit Bug 24259: Handle non existing default circ rule in Charges::Fees Can't call method "lengthunit" on an undefined value at /usr/share/koha/lib/Koha/Charges/Fees.pm line 101. Test plan: 1 - Remove all/all rule form circulation rules 2 - Define a rental fee per day for an itemtype 3 - Checkout an item of this type ot patron 4 - Should get note of no circ rule defined 5 - Confirm the checkout => item is checked out Signed-off-by: hc Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:02:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:02:35 +0000 Subject: [Koha-bugs] [Bug 23883] sip_cli_emulator.pl - typo in parameter name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23883 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |joonas.kylmala at helsinki.fi --- Comment #3 from Joonas Kylmälä --- Well, this same issue happens if you don't specify the --patron parameter: > patron_identifier is required for fee_paid Here if instead of --patron you try --patron-identifier (patron_identifier with hyphen instead) it doesn't work. So the proposed fix doesn't really solve this problem but only the specific case of --fee-amount parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:24:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:24:42 +0000 Subject: [Koha-bugs] [Bug 24281] Fix the list of types of visual materials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24281 --- Comment #1 from Maryse Simard --- Created attachment 96526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96526&action=edit Bug 24281: Fix the list of types of visual materials In the MARC21 XSLT files for results in both staff and OPAC, the type of visual material for code "g" is "legal article" instead of "game". This patch change the value to "game". To test: 0. Set up: - have a MARC21 database - use default XSLT file for display of results : OPACXSLTResultsDisplay : default XSLTResultsDisplay : defaul - If needed, catalog a game. In the 008 tag editor : Type of Material : VM - Visual Materials 33 - Type of visual material : g - Game 1. On both staff and OPAC, make a search which returns results including visual materials of type game (the title catalogued in previous step). 2. Note that in the list of results, the label "Type of visual material" is followed by "legal article". 3. Apply patch. 4. Repeat step 1. 5. Note "legal article" has been replaced by "game". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:25:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:25:02 +0000 Subject: [Koha-bugs] [Bug 24281] Fix the list of types of visual materials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24281 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard at inlibro.com Assignee|koha-bugs at lists.koha-commun |maryse.simard at inlibro.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:27:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:27:11 +0000 Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title without leading articles (allow for title sort with anti-the) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inventory table should |Inventory table should be |allow for title sort with |sortable by title without |anti-the |leading articles (allow for | |title sort with anti-the) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:38:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:38:05 +0000 Subject: [Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Pretty sure this is still valid... ModItemTransfer just obliterates any existing transfer and replaces it. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:49:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:49:12 +0000 Subject: [Koha-bugs] [Bug 24287] New: Transfers should record how they were triggered. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 Bug ID: 24287 Summary: Transfers should record how they were triggered. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, testopia at bugs.koha-community.org Depends on: 22569, 23092, 23432 The transfers system is very much tied to the Holds/Reserves features at the moment, but slowly some other subsystems are starting to use it too (Stock Rotation, Rotating Collections). For full audit purposes, we should record what triggered the transfer. Currently stock rotation misuses 'comments' to record the 'trigger' and these comments can be obliterated by subsequently triggered transfers. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: need transfer reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432 [Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:49:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:49:12 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 [Bug 24287] Transfers should record how they were triggered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:49:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:49:12 +0000 Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 [Bug 24287] Transfers should record how they were triggered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:49:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:49:12 +0000 Subject: [Koha-bugs] [Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 [Bug 24287] Transfers should record how they were triggered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:50:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:50:35 +0000 Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were triggered. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23092, 23432 | Blocks| |23432 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432 [Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:50:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:50:35 +0000 Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24287 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 [Bug 24287] Transfers should record how they were triggered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:50:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:50:35 +0000 Subject: [Koha-bugs] [Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24287 | Depends on| |24287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 [Bug 24287] Transfers should record how they were triggered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:50:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:50:52 +0000 Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were triggered. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:51:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:51:31 +0000 Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were triggered. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:53:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:53:55 +0000 Subject: [Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 Frank Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 15:59:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 14:59:52 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:02:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:02:55 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96375|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä --- Created attachment 96527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96527&action=edit Bug 24175: Unit tests Signed-off-by: Jonathan Druart Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:02:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:02:58 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96376|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä --- Created attachment 96528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96528&action=edit Bug 24175: Use itemnumber when searching for holds in SIP drop_hold To test: 1 - place a hold for a patron 2 - Get SIP running https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-' 4 - Attempt to cancel hold 5 - It fails 6 - Apply patch 7 - Try again 8 - It succeeds Signed-off-by: Jonathan Druart Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:03:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:03:01 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96377|0 |1 is obsolete| | --- Comment #10 from Joonas Kylmälä --- Created attachment 96529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96529&action=edit Bug 24175: Take advantage of Koha::Item->holds Signed-off-by: Jonathan Druart Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:03:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:03:05 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96378|0 |1 is obsolete| | --- Comment #11 from Joonas Kylmälä --- Created attachment 96530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96530&action=edit Bug 24175: Simplify tests Signed-off-by: Jonathan Druart Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:03:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:03:09 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:04:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:04:16 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #12 from Joonas Kylmälä --- I added my sign-off for the patches from Jonathan because they were not so trivial. So now waiting for someone to QA this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:08:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:08:52 +0000 Subject: [Koha-bugs] [Bug 24168] Errors with use of CanItemBeReserved return value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24168 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:16:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:16:14 +0000 Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title without leading articles (allow for title sort with anti-the) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275 Deb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dstephen at dubuque.lib.ia.us --- Comment #2 from Deb --- I followed the plan and worked as intended. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:20:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:20:49 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |joonas.kylmala at helsinki.fi --- Comment #4 from Joonas Kylmälä --- After this change the purchase suggestion would not be shown in the list at . So I would like to see a patch that handles these any library suggestions before we merge this otherwise I think we are left with a even worse situation where we have patrons submitting suggestions successfully" but then the librarians never knowing about them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:28:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:28:35 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:37:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:37:40 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #28 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:38:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:38:14 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22368 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 [Bug 22368] Table suggestions lacks foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:38:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:38:14 +0000 Subject: [Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 [Bug 24244] Cannot create suggestion with branch set to 'Any' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:39:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:39:54 +0000 Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:40:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:40:15 +0000 Subject: [Koha-bugs] [Bug 19465] Allow choosing Elasticsearch server on instance creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:40:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:40:39 +0000 Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:41:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:41:35 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #4) > After this change the purchase suggestion would not be shown in the list at > . So I would like to see a patch > that handles these any library suggestions before we merge this otherwise I > think we are left with a even worse situation where we have patrons > submitting suggestions successfully" but then the librarians never knowing > about them. This is a regression - in the past we could create these suggestions and they have never been shown by default. You should be able to see them by opening the Acquisition information filter and setting library to Any Making that more obvious is a separate bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:49:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:49:14 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | --- Comment #12 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:51:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:51:18 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #27 from Joy Nelson --- Not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:51:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:51:18 +0000 Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Bug 23185 depends on bug 21761, which changed state. Bug 21761 Summary: Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 16:51:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 15:51:19 +0000 Subject: [Koha-bugs] [Bug 23187] Koha::Objects supports find_or_create without passing through the Koha::Object store method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23187 Bug 23187 depends on bug 21761, which changed state. Bug 21761 Summary: Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:03:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:03:20 +0000 Subject: [Koha-bugs] [Bug 18021] Confirming each loan when going beyond the limit of loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18021 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca --- Comment #3 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:05:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:05:02 +0000 Subject: [Koha-bugs] [Bug 14089] show reason for cancellation on order search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14089 --- Comment #1 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:08:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:08:16 +0000 Subject: [Koha-bugs] [Bug 16112] Specify due date for batch renew In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 --- Comment #1 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:08:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:08:59 +0000 Subject: [Koha-bugs] [Bug 16748] Batch checkout needs set due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 --- Comment #7 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:10:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:10:28 +0000 Subject: [Koha-bugs] [Bug 9313] Show fine amount on 'Overdues with fines' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9313 --- Comment #3 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:12:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:12:38 +0000 Subject: [Koha-bugs] [Bug 19762] Add option for PREDUE notices to take calendar into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19762 --- Comment #2 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:13:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:13:52 +0000 Subject: [Koha-bugs] [Bug 24288] New: Add wording to authorized value interface to indicate valid code length Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Bug ID: 24288 Summary: Add wording to authorized value interface to indicate valid code length Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Several standard authorized values feed into fields that require a single character code (LOST, NOTFORLOAN, DAMAGED, RESTRICTED, WITHDRAWN). It'd be good to have some wording in the authorized value interface that would indicate this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:14:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:14:05 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:14:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:14:08 +0000 Subject: [Koha-bugs] [Bug 24288] Add wording to authorized value interface to indicate valid code length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:19:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:19:01 +0000 Subject: [Koha-bugs] [Bug 21791] Add payment type on Cash register report (cash_register_stats.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791 --- Comment #1 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:19:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:19:55 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy at bywatersolutions.com --- Comment #21 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:21:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:21:30 +0000 Subject: [Koha-bugs] [Bug 23016] Add columns for copy number and material specified in patron checkout (circulation.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23016 --- Comment #2 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:23:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:23:30 +0000 Subject: [Koha-bugs] [Bug 24289] New: Deleting branch will not delete entry in special holidays Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 Bug ID: 24289 Summary: Deleting branch will not delete entry in special holidays Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: rocio at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When you delete a branch that has holidays specified in special_holidays, these entries don't get deleted. To recreate: - add an calendar entry to Calendar for this branch - select * from special_holidays where branchcode = 'YOUR BRANCH'; - delete branch from Administration -> Libraries - select *.... holidays are still there for that branchcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:26:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:26:08 +0000 Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 --- Comment #1 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:26:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:26:39 +0000 Subject: [Koha-bugs] [Bug 22967] Adding the carousel to the advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22967 --- Comment #5 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 17:39:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 16:39:45 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #5 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:02:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:02:13 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | --- Comment #6 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:02:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:02:20 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:04:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:04:41 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:10:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:10:26 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:11:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:11:39 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #22 from Lucas Gass --- backported to 19.11.x for 19.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:18:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:18:32 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #23 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:43:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:43:55 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96418|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 96531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96531&action=edit Bug 24263: Add tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:43:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:43:58 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96419|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 96532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96532&action=edit Bug 24263: DB changes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:44:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:44:01 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96420|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 96533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96533&action=edit Bug 24263: Replace borrowers.relationship with NULL when was empty string When you create a new patron, its relationship field is populated with an empty string when we are expecting NULL. Otherwise the about page will display a warning about a missing/wrong relationship in data (that is not in the syspref) Test plan: 0/ Do not apply the patches from this bug report 1/ Create a new patron (child) 2/ Notice that relationship column in DB is set to an empty string 3/ Go to the about page, notice the invalid warning about relationship values not in the syspref 4/ Apply DB changes and tests 5/ Execute the update DB entry => The value in DB is now NULL when was "" 6/ Execute the tests => It fails 7/ Apply the last patch 8/ Add and edit a patron (child) => relationship is set to NULL in DB 9/ Execute the tests => They pass! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:44:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:44:32 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize --- Works as expected, Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:56:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:56:36 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96527|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 96534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96534&action=edit Bug 24175: Unit tests Signed-off-by: Jonathan Druart Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:56:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:56:39 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96528|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 96535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96535&action=edit Bug 24175: Use itemnumber when searching for holds in SIP drop_hold To test: 1 - place a hold for a patron 2 - Get SIP running https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-' 4 - Attempt to cancel hold 5 - It fails 6 - Apply patch 7 - Try again 8 - It succeeds Signed-off-by: Jonathan Druart Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:56:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:56:42 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96529|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 96536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96536&action=edit Bug 24175: Take advantage of Koha::Item->holds Signed-off-by: Jonathan Druart Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:56:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:56:45 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96530|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 96537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96537&action=edit Bug 24175: Simplify tests Signed-off-by: Jonathan Druart Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 18:57:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 17:57:24 +0000 Subject: [Koha-bugs] [Bug 24175] Cannot cancel holds - wrong parameter passed for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize --- Works as expected and passes tests and qa scripts.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 19:04:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 18:04:10 +0000 Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #37 from Martin Renvoize --- We need to build a tree of bugs to take notice of this system preference.. I keep finding cases where it's not being applied :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 19:05:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 18:05:55 +0000 Subject: [Koha-bugs] [Bug 24164] Patron emailer cronjob is not generating unique content for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #11 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 19:06:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 18:06:07 +0000 Subject: [Koha-bugs] [Bug 24290] New: `_FixOverduesOnReturn` does not respect `AccountAutoReconcile` Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24290 Bug ID: 24290 Summary: `_FixOverduesOnReturn` does not respect `AccountAutoReconcile` Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com As the title says, C4::Circulation::_FixAccountForLostAndReturned should respect `AccountAutoReconcile` but it does not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 19:06:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 18:06:30 +0000 Subject: [Koha-bugs] [Bug 24290] `_FixOverduesOnReturn` does not respect `AccountAutoReconcile` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 [Bug 21915] Add a way to automatically reconcile balance for patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 19:06:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 18:06:30 +0000 Subject: [Koha-bugs] [Bug 21915] Add a way to automatically reconcile balance for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24290 [Bug 24290] `_FixOverduesOnReturn` does not respect `AccountAutoReconcile` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 19:06:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 18:06:39 +0000 Subject: [Koha-bugs] [Bug 24290] `_FixOverduesOnReturn` does not respect `AccountAutoReconcile` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 19:06:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 18:06:39 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24290 [Bug 24290] `_FixOverduesOnReturn` does not respect `AccountAutoReconcile` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 19:11:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 18:11:20 +0000 Subject: [Koha-bugs] [Bug 24290] `_FixOverduesOnReturn` does not respect `AccountAutoReconcile` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24290 --- Comment #1 from Martin Renvoize --- Oops.. title is correct, the comment is the wrong way around -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 19:15:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 18:15:39 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 19:29:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 18:29:14 +0000 Subject: [Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 19:57:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 18:57:40 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #9 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 20:00:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 19:00:46 +0000 Subject: [Koha-bugs] [Bug 24291] New: Explanation next to limit item types by library is confusing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291 Bug ID: 24291 Summary: Explanation next to limit item types by library is confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 15497 introduced the ability to limit item types by categories. However, the text next to the box mentions authorized values. It should say "Select 'All libraries' if this item type is used by all libraries. Otherwise select libraries you want to associate with this item type." Or something like that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 20:06:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 19:06:51 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #14 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 20:08:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 19:08:53 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 96538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96538&action=edit Bug 24262: Translate installer data in YAML format This patch adds the ability to: 1) Create new translation files from yaml installer files 2) Create installer directory for a given language It will not create a installer directory if it already exists. New (possible) translation files: xx-YY-installer.po xx-YY-installer-MARC21.po xx-YY-installer-UNIMARC.po Needs Bug 13897 (for yaml files) and Bug 18688 (for warnings) To test: 1) Apply patches from Bug 13897 and Bug 18688. 2) Apply this patch 3) Go to misc/translation 4) Create new translation files for a language $ ./translate create xx-YY check new file 'xx-YY-installer.po' 5) Copy ../../installer/data/mysql/en/optional/auth_val.yml into ../../installer/data/mysql/en/marcflavour/marc21/mandatory/ and ../../installer/data/mysql/en/marcflavour/unimarc/mandatory/ remove po/xx-YY*, then repeat creation check new files 'xx-YY-installer.po', 'xx-YY-installer-MARC21.po' and 'xx-YY-installer-UNIMARC.po' remove all new files 6) Create for xx-YY again and try update $ ./translate create xx-YY edit ../../installer/data/mysql/en/optional/auth_val.yml and change one char in one of the translatable values, also edit 'xx-YY-installer.po', translate the same string (in msgstr). Do an update $ ./translate update xx-YY check in 'xx-YY-installer.po' a fuzzy value for the translated value and the preservation of the translation Fix the translation, or add a new one. 7) Create an install dir for xx-YY ./translate install xx-YY Check new dir '../../installer/data/mysql/xx-YY/' Check files on it $ tree ../../installer/data/mysql/xx-YY/ and compare with ../../installer/data/mysql/en/ All installation files must be present 8) Try a new Koha install using this language in the usual way. Check in authorised_values for the translated string. 9) Try create an install dir for an existing language (eg. es-ES, de-DE or fr-FR ) Install dir is ignored and not changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 20:10:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 19:10:35 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |18688 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 [Bug 18688] Warnings about UTF-8 charset when creating a new language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 20:10:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 19:10:35 +0000 Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating a new language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 20:13:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 19:13:34 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96370|0 |1 is obsolete| | --- Comment #32 from Bernardo Gonzalez Kriegel --- Created attachment 96539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96539&action=edit Bug 13897: Use YAML files for installer data This patch modifies C4/Installer.pm to add support for loading YAML files into database. As an example of the functionality, optional auth_val.sql file is replaced by auth_val.yml The rationale behind this feature is to enable the translation of the data that is loaded into the database. That will be addressed in another bug. But taking into account that goal, translatable values are declared in the YAML files, to ease identification by translate script. To test: 0) Do a clean install with all optional data, then dump authorised_values table, reserve. 1) Apply the patch 2) Do a clean install in English (marc21/unimarc) 3) On optional data check for description of auth_val "Some basic default authorised values for ..." 4) Select all optional data 5) Finish installation 6) Dump again authorised_values table and compare with that of point '0'. No differences should be found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 20:16:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 19:16:37 +0000 Subject: [Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 20:17:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 19:17:16 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96538|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 96540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96540&action=edit Bug 24262: Translate installer data in YAML format This patch adds the ability to: 1) Create new translation files from yaml installer files 2) Create installer directory for a given language It will not create a installer directory if it already exists. New (possible) translation files: xx-YY-installer.po xx-YY-installer-MARC21.po xx-YY-installer-UNIMARC.po Needs Bug 13897 (for yaml files) and Bug 18688 (for warnings) To test: 1) Apply patches from Bug 13897 and Bug 18688. 2) Apply this patch 3) Go to misc/translation 4) Create new translation files for a language $ ./translate create xx-YY check new file 'xx-YY-installer.po' 5) Copy ../../installer/data/mysql/en/optional/auth_val.yml into ../../installer/data/mysql/en/marcflavour/marc21/mandatory/ and ../../installer/data/mysql/en/marcflavour/unimarc/mandatory/ remove po/xx-YY*, then repeat creation check new files 'xx-YY-installer.po', 'xx-YY-installer-MARC21.po' and 'xx-YY-installer-UNIMARC.po' remove all new files 6) Create for xx-YY again and try update $ ./translate create xx-YY edit ../../installer/data/mysql/en/optional/auth_val.yml and change one char in one of the translatable values, also edit 'xx-YY-installer.po', translate the same string (in msgstr). Do an update $ ./translate update xx-YY check in 'xx-YY-installer.po' a fuzzy value for the translated value and the preservation of the translation Fix the translation, or add a new one. 7) Create an install dir for xx-YY ./translate install xx-YY Check new dir '../../installer/data/mysql/xx-YY/' Check files on it $ tree ../../installer/data/mysql/xx-YY/ and compare with ../../installer/data/mysql/en/ All installation files must be present 8) Try a new Koha install using this language in the usual way. Check in authorised_values for the translated string. 9) Try create an install dir for an existing language (eg. es-ES, de-DE or fr-FR ) Install dir is ignored and not changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 20:21:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 19:21:55 +0000 Subject: [Koha-bugs] [Bug 24283] Missing close parens and closing strong tag in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24283 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 20:26:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 19:26:01 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #33 from Bernardo Gonzalez Kriegel --- Hi, new patch version taking into account comments. I introduce a new format for YAML, it permits more than one table per file, or same table with different number of columns. The example file is an exact translation of the sql one, same order and column number, as a way to exemplify it's format I also added a patch in Bug 24262, with it, this and Bug 18688, it's possible to translate and install in new language using it's own installer files. A lot more work is needed to enable the complete translation of installer files, but hope this can be considered as first step in that direction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 21:35:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 20:35:13 +0000 Subject: [Koha-bugs] [Bug 24291] Explanation next to limit item types by library is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 21:45:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 20:45:12 +0000 Subject: [Koha-bugs] [Bug 21496] install.pl: DBD::mysql::st execute failed: Index column size too large. The maximum column size is 767 bytes. at /usr/share/perl5/DBIx/RunSQL.pm line 273. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21496 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize at ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 21:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 20:53:29 +0000 Subject: [Koha-bugs] [Bug 13070] Managing staged MARC records, sorting by title should ignore articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13070 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |koha-bugs at lists.koha-commun |.com |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 21:54:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 20:54:14 +0000 Subject: [Koha-bugs] [Bug 13070] Managing staged MARC records, sorting by title should ignore articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13070 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 21:54:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 20:54:29 +0000 Subject: [Koha-bugs] [Bug 13070] Managing staged MARC records, sorting by title should ignore articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13070 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize at ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 21:57:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 20:57:58 +0000 Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC 7XX In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize at ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 22:56:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 21:56:27 +0000 Subject: [Koha-bugs] [Bug 15497] Limit item types by library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Text to go in the| |This enhancement adds the release notes| |ability to limit the use of | |item types by branch. | |This | |will allow libraries in | |large library systems or | |consortia to have their own | |item types. Keywords|Manual, | |release-notes-needed | --- Comment #37 from Caroline Cyr La Rose --- Added release notes and manual patch (in gitlab). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 23:27:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 22:27:33 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 23:27:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 22:27:36 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96352|0 |1 is obsolete| | --- Comment #60 from Maryse Simard --- Created attachment 96541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96541&action=edit Bug 7882: (follow-up) Update sorting interaction This follow-up modifies the CSS for the sortable fields so that a different icon is used. Elsewhere in Koha (stock rotation stage sorting) we use the "bars" icon to indicate a sortable element. I think it would be good to continue to use this. The cursor is now styled as a "Move" cursor. The configuration of the sortable function in the script has been updated in two ways: 1. The movement of the element is constrained along the y-axis, and 2. The movement of the element is contstrained to the container within which it can be moved (for the tag, the tab, and for the subfield, the tag). To test, apply the patch and edit a MARC record in the basic cataloging editor. Confirm that the new icon is used, and that the "Move" cursor shows when you hover over the icon. Confirm that a tag can be dragged up and down within the constraints of the visible section. A subfield should be only movable within its parent tag. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 20 23:27:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 22:27:47 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96384|0 |1 is obsolete| | --- Comment #61 from Maryse Simard --- Created attachment 96542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96542&action=edit Bug 7882: (follow-up) Only show sortable icon for sortable tags Only tags which can be repeated can be sorted, so the "bars" icon should not display by these tags. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 00:03:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 23:03:22 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 00:03:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Dec 2019 23:03:26 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 --- Comment #1 from Agustín Moyano --- Created attachment 96543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96543&action=edit Bug 24228: Add parameters to Koha::Object->to_api to automatically embed objects This patch adds the posibility to define 'x-koha-embed' parameter in swagger and in request headers. If 'x-koha-embed' header is present, in Koha::REST::V1::Auth it's compared with the whitelist defined in swagger through the 'x-koha-embed' parameter, placed at the same level of x-koha-authorization. Whitelist should be composed of DBIC relations (optinally chained by '.') that has the corresponding method in Koha::Object. To test: 1. Apply this patch 2. prove t/db_dependent/Koha/Object.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 10:48:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 09:48:30 +0000 Subject: [Koha-bugs] [Bug 24288] Add wording to authorized value interface to indicate valid code length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:51:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:51:17 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:51:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:51:23 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96448|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:51:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:51:28 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96449|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:51:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:51:34 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96450|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:51:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:51:39 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96437|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:51:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:51:45 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96438|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:51:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:51:50 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:51:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:51:56 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96440|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:52:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:52:02 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96441|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:52:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:52:07 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96442|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:52:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:52:13 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96443|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:52:18 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96444|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:52:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:52:24 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96445|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:52:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:52:29 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96446|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:52:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:52:35 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96447|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:53:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:53:26 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #272 from Tomás Cohen Arazi --- Created attachment 96544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96544&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:53:33 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #273 from Tomás Cohen Arazi --- Created attachment 96545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96545&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:53:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:53:40 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #274 from Tomás Cohen Arazi --- Created attachment 96546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96546&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:53:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:53:47 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #275 from Tomás Cohen Arazi --- Created attachment 96547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96547&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:53:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:53:54 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #276 from Tomás Cohen Arazi --- Created attachment 96548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96548&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:54:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:54:01 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #277 from Tomás Cohen Arazi --- Created attachment 96549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96549&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:54:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:54:08 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #278 from Tomás Cohen Arazi --- Created attachment 96550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96550&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:54:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:54:15 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #279 from Tomás Cohen Arazi --- Created attachment 96551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96551&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:54:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:54:22 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #280 from Tomás Cohen Arazi --- Created attachment 96552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96552&action=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:54:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:54:29 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #281 from Tomás Cohen Arazi --- Created attachment 96553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96553&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Remove commented warn and address test failures * Bug 22284: (follow-up) fix test count after merge * Bug 22284: (follow-up) fixes after 15496 * Bug 22284: (follow-up) fixes after 18936 * Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:54:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:54:36 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #282 from Tomás Cohen Arazi --- Created attachment 96554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96554&action=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:54:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:54:42 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #283 from Tomás Cohen Arazi --- Created attachment 96555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96555&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations * Bug 22284: (follow-up) Fix tests * Bug 22284: (follow-up) Fix typo in request.tt * Bug 22284: (follow-up) Filter pickup on specific item click * Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:54:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:54:49 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #284 from Tomás Cohen Arazi --- Created attachment 96556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96556&action=edit Bug 22284: Schema update Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:54:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:54:56 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #285 from Tomás Cohen Arazi --- Created attachment 96557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96557&action=edit Bug 22284: (follow-up) Anotate boolean values in Koha::Schema::Result::LibraryGroup Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 11:55:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 10:55:03 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #286 from Tomás Cohen Arazi --- Created attachment 96558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96558&action=edit Bug 22284: (QA follow-up) Make pickup locations be Koha::Library objects This patch makes the following methods return array references of Koha::Library objects instead or unblessed objects; - Koha::Item->pickup_locations - Koha::Biblio->pickup_locations - Koha::Libraries->pickup_locations Bonus: - The template plugin is adjusted to unbless things to keep behavior - Tests are moved to the right .t file. - Tests for the new behavior are added. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 14:54:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 13:54:01 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #11 from Andrew Fuerste-Henry --- After Nick's change, this is misbehaving slightly, not getting the right order in the item record. My syspref says: 082abmqA My bib says: 082 $a a $b b $m m $q q $A A The item call number generates as: a A b m q -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 15:05:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 14:05:46 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96501|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes --- Created attachment 96559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96559&action=edit Bug 3426: Allow for multiple fields in itemcallnumber syspref Note that we change both cataloguing/additem.pl and C4/Items->PrepareItemrecordfordisplay I can find no code that uses callnumber from the C4/Items sub, except for the itemrecorddisplay script which is not called with an itemnumber from Koha and should be deprecated for REST or ILSDI or OAI (imho) To test: 1 - Define itemcallnumber syspref as "082ab,092ab,9520,245a" 2 - Find a record with no items 3 - Ensure it has no 082 field, but an 092 field 4 - Go to add an item - itemcallnumber is empty 5 - Apply patch 6 - Go to add item, itemcallnumber should be the 092ab fields 7 - Delete the 092 field 8 - Go to add item, itemcallnumber should be the 245a 9 - Edit the callnumber to be "testing" and save item 10 - For should now show itemcallnumber="testing" as default 11 - Browse to http://localhost:8081/cgi-bin/koha/services/itemrecorddisplay.pl?itemnumber=## subbing the correct itemnumber 12 - Ensure the callnumber is defaulting to testing 13 - delete the item you created 14 - browse to URL above - callnumber should now be 245 again 15 - Add an 092 field to record and ensure it is now default callnumber 16 - Add an 082 field, it should now be default Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 15:06:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 14:06:37 +0000 Subject: [Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Andrew Fuerste-Henry --- I've got a small quibble over on bug 9156, but this part of things worked as desired. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 16:25:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 15:25:44 +0000 Subject: [Koha-bugs] [Bug 24292] New: Upgrade failed, from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292 Bug ID: 24292 Summary: Upgrade failed, from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: mjnkml at gmail.com QA Contact: testopia at bugs.koha-community.org Upgrading koha using apt update from (presumably) 19.05 to 19.11 failed: $ sudo apt upgrade Reading package lists... Done Building dependency tree Reading state information... Done Calculating upgrade... Done 0 to upgrade, 0 to newly install, 0 to remove and 0 not to upgrade. 1 not fully installed or removed. After this operation, 0 B of additional disk space will be used. Do you want to continue? [Y/n] y Setting up koha-common (19.11.00-1) ... Upgrading database schema for instance Can't load '/usr/lib/x86_64-linux-gnu/perl5/5.28/auto/Text/Unaccent/Unaccent.so' for module Text::Unaccent: /usr/lib/x86_64-linux-gnu/perl5/5.28/auto/Text/Unaccent/Unaccent.so: undefined symbol: unac_debug_callback at /usr/lib/x86_64-linux-gnu/perl/5.28/DynaLoader.pm line 187. at /usr/share/koha/lib/Koha/Patron.pm line 26. Compilation failed in require at /usr/share/koha/lib/Koha/Patron.pm line 26. BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Patron.pm line 26. Compilation failed in require at /usr/share/koha/lib/Koha/Patrons.pm line 30. BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Patrons.pm line 30. Compilation failed in require at /usr/share/koha/lib/Koha/Checkouts/ReturnClaim.pm line 27. BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Checkouts/ReturnClaim.pm line 27. Compilation failed in require at /usr/share/koha/lib/Koha/Checkouts/ReturnClaims.pm line 26. BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Checkouts/ReturnClaims.pm line 26. Compilation failed in require at /usr/share/koha/lib/Koha/Checkout.pm line 27. BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Checkout.pm line 27. Compilation failed in require at /usr/share/koha/lib/Koha/Checkouts.pm line 25. BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Checkouts.pm line 25. Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 37. BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth.pm line 37. Compilation failed in require at /usr/share/koha/lib/C4/Output.pm line 34. BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Output.pm line 34. Compilation failed in require at /usr/share/koha/lib/Koha/Plugins.pm line 29. BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Plugins.pm line 29. Compilation failed in require at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 18792. dpkg: error processing package koha-common (--configure): installed koha-common package post-installation script subprocess returned error exit status 2 Errors were encountered while processing: koha-common E: Sub-process /usr/bin/dpkg returned an error code (1) $ The only way I could get it to move forward was to comment out the use Unaccent on line 26, and also comment out the part that actually uses the function. > lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 19.10 Release: 19.10 Codename: eoan > uname -a Linux koha 5.3.0-23-generic #25-Ubuntu SMP Tue Nov 12 09:22:33 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 16:26:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 15:26:26 +0000 Subject: [Koha-bugs] [Bug 24292] Upgrade failed, from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292 mjnkml at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- OS|All |Linux Hardware|All |PC Priority|P5 - low |P4 CC| |mjnkml at gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 16:34:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 15:34:35 +0000 Subject: [Koha-bugs] [Bug 24292] Upgrade failed, from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292 --- Comment #1 from mjnkml at gmail.com --- In Koha's About -> Perl moduls page, Text::Unaccent is shown Installed at version 1.08. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 21 21:13:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Dec 2019 20:13:34 +0000 Subject: [Koha-bugs] [Bug 24292] Upgrade failed, from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- https://rt.cpan.org/Public/Dist/Display.html?Name=Text-Unaccent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 06:15:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 05:15:42 +0000 Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011 --- Comment #4 from Arthur Suzuki --- The regex is needed by the client app we use to provide some client side input validation before sending any new (and possibly wrong) password to koha. i'm thinking of the following solution : is_password_valid could return the regex in addition to the boolean and error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 06:21:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 05:21:07 +0000 Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011 --- Comment #5 from Arthur Suzuki --- Created attachment 96560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96560&action=edit Bug 23011: Have AuthenticatePatron method send more information We want AuthenticatePatron to send some more information upon successful login, especially in the case where password is not safe and should be renewed. The goal is to let a third-party app catch thoses codes and display a warning to the users. Test plan : 1 / apply tests patch 2 / run tests, verify failure 3 / apply C4/ILSDI/Service.pm patch 4 / run tests again, verify green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 06:21:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 05:21:32 +0000 Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011 --- Comment #6 from Arthur Suzuki --- Created attachment 96561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96561&action=edit Bug 23011: Add new tests (AuthenticatePatron error codes) This bug add new tests to the AuthenticatePatron ILS-DI service. It tests new error codes patron might get when successfully connecting but with a password which doesn't match Koha security rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 06:22:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 05:22:10 +0000 Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 06:22:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 05:22:13 +0000 Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96560|0 |1 is obsolete| | --- Comment #7 from Arthur Suzuki --- Created attachment 96562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96562&action=edit Bug 23011: Have AuthenticatePatron method send more information We want AuthenticatePatron to send some more information upon successful login, especially in the case where password is not safe and should be renewed. The goal is to let a third-party app catch thoses codes and display a warning to the users. Test plan : 1 / apply tests patch 2 / run tests, verify failure 3 / apply C4/ILSDI/Service.pm patch 4 / run tests again, verify green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 06:39:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 05:39:30 +0000 Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93512|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 06:39:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 05:39:48 +0000 Subject: [Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93517|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 08:29:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 07:29:46 +0000 Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #6 from Arthur Suzuki --- Created attachment 96563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96563&action=edit Bug 23531: fix ILSDI non-implemented but documented parameters test plan : 1/ Submit a hold through ILSDI with start_date and expiry_date parameters 2/ Verify in Koha those parameters are not applied to the newly created reserve. Delete reserve. 3/ Apply patch and repeat 1. 4/ Verify the reserve created by same request as 1 now has both dates applied and visible in Koha. Signed-off-by: Christophe Croullebois -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 08:29:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 07:29:49 +0000 Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #7 from Arthur Suzuki --- Created attachment 96564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96564&action=edit Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 08:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 07:30:29 +0000 Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 10:44:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 09:44:50 +0000 Subject: [Koha-bugs] [Bug 24292] Upgrade failed, from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14759 CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Katrin Fischer --- Could the last comment on bug 14759 be related to this? Also linking them with see also. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 10:44:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 09:44:50 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24292 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 10:53:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 09:53:10 +0000 Subject: [Koha-bugs] [Bug 13070] Managing staged MARC records, sorting by title should ignore articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Please remember we don't only won't to ignore "the", but all the variations of it in other languages as well. It looks like the list of articles to ignore is currently part of the po files? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 11:00:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 10:00:21 +0000 Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating a new language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 11:00:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 10:00:24 +0000 Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating a new language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96305|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 96565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96565&action=edit Bug 18688: Warnings about UTF-8 charset when creating a new language This patch removes some warnings when creating new languages, those related with uft8 and two not related. Tipical messages are: >Warning: Can't determine original templates' charset, defaulting to UTF-8 >Warning: Charset Out defaulting to UTF-8 >... >Removing empty file /../xx-YY-marc-NORMARC.po >I UTF-8 O UTF-8 at /../kohaclone/misc/translator/tmpl_process3.pl line 365. >Use of uninitialized value $pref_name in concatenation (.) or string at /.../misc/translator/LangInstaller.pm line 197. >Created /../misc/translator/po/xx-YY-messages.po. First four are 'normal' messages The fifth one correspond to an unquoted preference string The sixth one is a normal output message from msgint command We will hide them unless verbose '-v' option is selected, and fix the error. To test: 1) Go to misc/translator 2) Create new language files $ perl translate create xx-YY 3) Check warnings and messages 4) Apply the patch 5) Remove created files, and create them again Ther must be no messages 6) Repeat 5) with verbose option '-v', check old messages 7) BONUS: without the patch update a language, for example de-DE: $ perl translate update de-DE Note (git status) a new file, po/de-DE-messages.po~ This is a backup file from msgmerge command With the patch this backup is removed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 11:02:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 10:02:18 +0000 Subject: [Koha-bugs] [Bug 22967] Add a custom HTML pref for the OPAC's advanced search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding the carousel to the |Add a custom HTML pref for |advanced search |the OPAC's advanced search | |page CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 11:06:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 10:06:18 +0000 Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Alexandre, if the problem is that the shown location might belong to the home library instead of the current library than I am not sure how we can solve this. There is no way to tell if the location applies to the current or the home library. Examples that come to mind: It could also be "CART" or "PROC" which are correct independent from the library setting. Or it might be part of course reserves and the current library has set the location to a specific "course reserves" location. What solution would you prefer? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 11:25:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 10:25:46 +0000 Subject: [Koha-bugs] [Bug 16112] Specify due date for batch renew In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16748 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 11:25:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 10:25:46 +0000 Subject: [Koha-bugs] [Bug 16748] Batch checkout needs set due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16112 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 11:34:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 10:34:09 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- It appears to fix the staff side, but we still got big trouble in the OPAC: - Activate anonymous suggestions for the OPAC - Place a suggestion while logged out - Boom! Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 Leaving this bug right now as I think we could add the important OPAC (end users!) fix into this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 11:38:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 10:38:51 +0000 Subject: [Koha-bugs] [Bug 24293] New: Schema needs 19.11 added Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24293 Bug ID: 24293 Summary: Schema needs 19.11 added Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Bugzilla Assignee: chris at bigballofwax.co.nz Reporter: katrin.fischer at bsz-bw.de We should add 19.11 to http://schema.koha-community.org/. And we should also add a fitting category for schema to bugzilla :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 11:41:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 10:41:43 +0000 Subject: [Koha-bugs] [Bug 24283] Missing close parens and closing strong tag in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24283 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 11:41:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 10:41:47 +0000 Subject: [Koha-bugs] [Bug 24283] Missing close parens and closing strong tag in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24283 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96514|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 96566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96566&action=edit Bug 24283: (bug 21446 follow-up) close strong and add missing parens To Test: 1) Create a course in course reserves, make it inactive 2) Add an item to it, changing item type and location 3) Make the course enabled 4) Note that the normal item type is no longer bold and has both opening and closing parentheses; Note that the normal location is also not bold and has both opening and closing parentheses. 5) Disable the course 6) Note that the normal item type is in bold with an opening parentheses but no closing parentheses; Note that the normal location is in bold with both opening and closing parentheses. 7) Apply patch 8) Note view is fixed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 11:41:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 10:41:59 +0000 Subject: [Koha-bugs] [Bug 24283] Missing close parens and closing strong tag in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24283 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 12:03:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 11:03:43 +0000 Subject: [Koha-bugs] [Bug 24281] Fix the list of types of visual materials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24281 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 12:36:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 11:36:51 +0000 Subject: [Koha-bugs] [Bug 24281] Fix the list of types of visual materials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24281 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 12:36:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 11:36:55 +0000 Subject: [Koha-bugs] [Bug 24281] Fix the list of types of visual materials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24281 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96526|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 96567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96567&action=edit Bug 24281: Fix the list of types of visual materials In the MARC21 XSLT files for results in both staff and OPAC, the type of visual material for code "g" is "legal article" instead of "game". This patch change the value to "game". To test: 0. Set up: - have a MARC21 database - use default XSLT file for display of results : OPACXSLTResultsDisplay : default XSLTResultsDisplay : defaul - If needed, catalog a game. In the 008 tag editor : Type of Material : VM - Visual Materials 33 - Type of visual material : g - Game 1. On both staff and OPAC, make a search which returns results including visual materials of type game (the title catalogued in previous step). 2. Note that in the list of results, the label "Type of visual material" is followed by "legal article". 3. Apply patch. 4. Repeat step 1. 5. Note "legal article" has been replaced by "game". Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 12:37:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 11:37:53 +0000 Subject: [Koha-bugs] [Bug 24281] Fix the list of types of visual materials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24281 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 12:40:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 11:40:25 +0000 Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |14697 Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 12:40:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 11:40:25 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24279 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 12:41:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 11:41:52 +0000 Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Haven't tested, but could this change the items.dateaccessioned instead? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 13:06:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 12:06:23 +0000 Subject: [Koha-bugs] [Bug 24274] New installations should not contain field 01e Coded field error (RLIN) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 13:06:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 12:06:27 +0000 Subject: [Koha-bugs] [Bug 24274] New installations should not contain field 01e Coded field error (RLIN) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96483|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 96568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96568&action=edit Bug 24274: Remove field 01e from sql installer files Field 01e comes from an older utility (RLIN) and does not belong here. Note: It is the only non-numeric field tag in Koha. And it seems to be an violation of the MARC standard. Test plan: Run a new install and check the bibliographic frameworks. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:09:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:09:57 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:10:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:10:00 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #3 from Katrin Fischer --- Created attachment 96569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96569&action=edit Bug 24206: Update URLs for default options in OPACSearchForTitleIn - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify changes to the installer files are correct - Bonus: run the web installer for en, de-DE and nb-NO and verfiy the content of OPACSearchForTitleIn is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:10:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:10:04 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #4 from Katrin Fischer --- Created attachment 96570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96570&action=edit Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:10:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:10:31 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |katrin.fischer at bsz-bw.de Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:11:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:11:58 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advance notices: send |Advance notices: send |separate digest messages |separate digest messages |per branch |per library --- Comment #27 from Katrin Fischer --- (In reply to Jonathan Druart from comment #26) > There is something terribly wrong with this test file, the cronjob script is > run outside the transaction and so changes are effective. Should this be a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:13:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:13:17 +0000 Subject: [Koha-bugs] [Bug 24273] Add IIIF compatibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master CC| |katrin.fischer at bsz-bw.de Summary|It is possible to |Add IIIF compatibility |incorporate IIIF | |compatibility in Koha | |Bibliographic catalog | --- Comment #1 from Katrin Fischer --- Hi Pedro, can you explain a bit more which features would have to be added to Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:16:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:16:04 +0000 Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt increase the original quantity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Should the warn not be removed? + warn "setting ". + $order->{'quantity'} + $parent_order->{'quantity'} . " to $parent_ordernumber"; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:31:13 +0000 Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:31:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:31:17 +0000 Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96173|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 96571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96571&action=edit Bug 24208: Remove change calculation for writeoffs Bug 11373 added change calculation to the payment page. This doesn't work very well in the case of writeoffs: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath. This patch removes these unwanted fields and use the "Writeoff amount" label on the right input. Test plan: 1) Choose a patron who has fees. You can add a manual invoice if necessary. 2) Go to Accounting > Make a payment. 3) Select some fines and click "Write off selected". 4) Note the form has a lot of inputs, not all are necessary for a writeoff. 5) Make a partial writeoff by entering a different amount in the "Writeoff amount" field. => The amount written off is the amount entered in the "Amount paid" field. 6) Apply patch. 7) Repeat steps 1-3. 8) Notice the form only has "Amount outstanding", "Writeoff amount" and "Note" fields, which are enough for a writeoff. 9) Entering any amount lower than or equal to the amount outstanding in the "Writeoff amount" field should create a writeoff of the selected amount. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:31:21 +0000 Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 --- Comment #5 from Katrin Fischer --- Created attachment 96572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96572&action=edit Bug 24208: (follow-up) Change page title from payment to writeoff This makes a change requested by the first tester: Also change the page title when a writeoff is done vs a payment. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:32:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:32:40 +0000 Subject: [Koha-bugs] [Bug 24265] Create a cron job to delete Label Batches after time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24265 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15563 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:32:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:32:40 +0000 Subject: [Koha-bugs] [Bug 15563] Cronjob to regularly delete patroncard label batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #1 from Katrin Fischer --- *** Bug 24265 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:38:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:38:26 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:38:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:38:31 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96340|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 96573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96573&action=edit Bug 24243: Do not explode if invalid metadata when searching catalogue If the bibliographic record metadata cannot be decoded, the get_coins call should catch the exception raised by Koha::Biblio::Metadata->record to not explode Error is: "Invalid data, cannot decode objec" Test plan: 0/ Do not apply the patch 1/ Search for record at the OPAC 2/ Note one of the biblionumber from the first page result 3/ Set to empty string the biblio_metadata to make the error appears: update biblio_metadata set metadata="" where biblionumber=42; 4/ Try the same search => You get an internal server error 5/ Apply the patch, restart plack and try again => It now works, ie. it does not explode Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:39:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:39:44 +0000 Subject: [Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Maybe we should think about displaying a more specific error, currently in the intranet you see: The record you requested does not exist (2). It's not quite correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:58:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:58:28 +0000 Subject: [Koha-bugs] [Bug 24256] Free Form : Move email to Tools > Notices and slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24256 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 22818 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 14:58:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 13:58:28 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #28 from Katrin Fischer --- *** Bug 24256 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:02:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:02:08 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #9 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 24073 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:02:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:02:08 +0000 Subject: [Koha-bugs] [Bug 24073] Allow suggestion management page to default to all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #3 from Katrin Fischer --- *** Bug 14830 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:03:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:03:16 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 --- Comment #10 from Katrin Fischer --- Marked duplicate with a newer bug about this issue/topic - I think it's a recurring problem but with indybranches etc not trivial to solve in a good way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:13:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:13:56 +0000 Subject: [Koha-bugs] [Bug 18414] Allow to use other select criteria with delete_patrons.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:13:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:13:59 +0000 Subject: [Koha-bugs] [Bug 18414] Allow to use other select criteria with delete_patrons.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 --- Comment #2 from Katrin Fischer --- Created attachment 96574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96574&action=edit Bug 18413: Allow to use other select criteria with delete_patrons.pl Adds the ability to specify a file with the --file flag that should be a list of borrowernumbers for deletion. If used without other flags it will delete the list of borrowers, if used with other flags it will treat the other criteria as filters for the list. To Test: 1) Specify a list, e.g. borrowers.txt, of borrowernumbers in the database and put them in a text file with one per line 2) Invoke the script like ./delete_patrons.pl --file borrowers.txt to delete those patrons 3) Populate the list with a mix of borrowers in a category and those not, say categoryfoo 4) Invoke the scirpt as ./delete_patrons.pl --category_code categoryfoo --file borrowers.txt 5) Only the borrowers in the file that have the specified category will be deleted Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:14:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:14:45 +0000 Subject: [Koha-bugs] [Bug 18414] Allow to use other select criteria with delete_patrons.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:24:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:24:51 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer --- This almost works perfectly, but there is one thing that is confusing: When there is a dialog (patron has some fines or more checked out than allowed override) the checkbox appears "unchecked", which is confusing. Could this be improved? Also tested in combination with OnSiteCheckoutAutoCheck. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:27:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:27:27 +0000 Subject: [Koha-bugs] [Bug 24174] OPAC patron self registration requirements conflict with patron modifications (updates) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24174 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 13188 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:27:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:27:27 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #12 from Katrin Fischer --- *** Bug 24174 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:46:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:46:44 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:46:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:46:48 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96506|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 96575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96575&action=edit Bug 24121: Item types icons in intra search results are requesting icons from opac images path When searching in INTRA you'll notice the item type icons not showing. To test: 1) Set syspref item-level_itypes to biblio 2) Confirm that there is a biblioitems.itemtype mapping to a MARC field 3) Verify that item type icons are set for all the types 4) Perform a search where biblios with said MARC field is filled with a type value 5) Verify that where the icon should appear, it's showing the browser icon for image not found 6) Apply patch. 7) Repeat step 4. 8) Observe the icons are now displayed correctly Sponsored-by: Governo Regional dos Açores Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 15:49:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 14:49:02 +0000 Subject: [Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #9 from Katrin Fischer --- (In reply to Myka Kennedy Stephens from comment #8) > I share your concern, Jonathan. I recently needed to use the drop-down in > the staff client to perform a search across two shelving locations because > the limit by shelving location option is currently compiling the query > statement with AND instead of OR (see bug #24109). > > Even though searches using ccl will continue to work without the drop-down, > as Nick pointed out, having the drop-down as an option makes it easier to > build these queries, which I think most library staff appreciate. > > What would it take to make this search index work in Zebra? But should the answer then not be to fix bug 24109? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:06:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:06:48 +0000 Subject: [Koha-bugs] [Bug 24234] Spacing of availability note in intranet search results unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org --- Comment #5 from Katrin Fischer --- I like the boldness on the subheadings, but not sure about the boldness on the locations. I think it might be a bit too much. Adding Owen for another opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:11:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:11:47 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:11:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:11:51 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96489|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 96576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96576&action=edit Bug 21232: Add a client-side check on biblionumber when creating a subscription This patch adds an AJAX call to the REST API (/api/v1/biblios/) to retrieve and display the biblio's title. On clicking the "next" button a check is done to make sure the title exists, which means the biblionumber we manually entered is valid (can we assume a title is mandatory?) Test plan: - Create or edit a new subscription - Enter an invalid biblionumber in the input => A friendly note is telling you that the biblio does not exist - Try to switch to the next screen => You get an alert - Enter a valid biblionumber in the input => The title is displayed => Try to switch to the next screen => It works! Signed-off-by: hc Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:16:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:16:46 +0000 Subject: [Koha-bugs] [Bug 24242] Funds with no library assigned do not appear on edit suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:16:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:16:50 +0000 Subject: [Koha-bugs] [Bug 24242] Funds with no library assigned do not appear on edit suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96490|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 96577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96577&action=edit Bug 24242: Display funds that the logged in user can access - suggestions The design of this script is pretty bad and any modifications is a challenge. Here we are trying to display to display the funds available for the logged in user. I did not understand previous code, as we are doing a limit using CanUserUseBudget, I do not think it makes sense to retrieve funds for a given library. Also, I am wondering if the dropdown list in the filters has ever been populated: budgetid_loop in the template *never* appeared in the history of suggestion.pl (??) Test plan: Search for suggestions Add/edit suggestions => The funds in the dropdown list should be the ones the logged in user can use. Signed-off-by: hc Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:18:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:18:23 +0000 Subject: [Koha-bugs] [Bug 24242] Funds with no library assigned do not appear on edit suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I wonder a bit about the use case here: I could imagine someone checking the suggestions and picking the funds and someone else ordering it later. But this clearly fixes a regression, philosophical discussions can happen later :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:19:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:19:40 +0000 Subject: [Koha-bugs] [Bug 3426] Change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|change itemcallnumber |Change itemcallnumber |system preference to allow |system preference to allow |multiple tags |multiple tags -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:22:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:22:29 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer --- Failing QA because of Andrew's comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:22:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:22:52 +0000 Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|itemcallnumber not pulling |System preference |more than 2 subfields |itemcallnumber not pulling | |more than 2 subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:23:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:23:28 +0000 Subject: [Koha-bugs] [Bug 3426] Change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #13 from Katrin Fischer --- Blocked by FQA on bug 9156 - please switch back once this is resolved. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:26:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:26:23 +0000 Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:31:13 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 22 18:31:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Dec 2019 17:31:17 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95244|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 96578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96578&action=edit Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. s are replaced with