[Koha-bugs] [Bug 24148] New: black magic in Circulation/Returns.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148

            Bug ID: 24148
           Summary: black magic in Circulation/Returns.
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

On the newly created job Koha_Master_D9_MDB_Latest:

koha_1       |     # Looks like you planned 2 tests but ran 1.
koha_1       | 
koha_1       | #   Failed test 'AddReturn logging on statistics table
(item-level_itypes=0)'
koha_1       | #   at t/db_dependent/Circulation/Returns.t line 249.
koha_1       | Can't call method "itemtype" on an undefined value at
t/db_dependent/Circulation/Returns.t line 247.

I recreate locally with this configuration (latest MariaDB version), and tried
to debug:

modified: t/db_dependent/Circulation/Returns.t
@ Returns.t:245 @ subtest "AddReturn logging on statistics table
(item-level_itypes=0)" => sub {
         branch     => $branch,
         type       => 'return',
         itemnumber => $item_without_itemtype->{ itemnumber }
-    }, { order_by => { -asc => 'datetime' } })->next();
+    }, { order_by => { -asc => 'datetime' } });

+    warn $stat->count;
+    $stat = $stat->next;

     is( $stat->itemtype, $blevel_itemtype,
         "biblio-level itype recorded on statistics for return");

 };

 subtest 'Handle ids duplication' => sub {


Guess what?
->count returns 1 but ->next returns undef!

-- 
You are receiving this mail because:
You are watching all bug changes.